Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-05-07 Thread Bjorn Helgaas
[+cc Phillip] On Tue, Apr 30, 2013 at 9:19 PM, Robert Hancock wrote: > On 04/29/2013 10:47 PM, Bjorn Helgaas wrote: >> >> On Sat, Apr 27, 2013 at 4:10 AM, Artem S. Tashkinov >> wrote: >>>> >>>> >>>> Did this problem ever get resolv

Re: 3.8.4 kernel

2013-05-07 Thread Bjorn Helgaas
[+cc Eric because he made a change (69b08f62e17) that apparently exposes driver bugs] On Mon, May 6, 2013 at 7:51 PM, Huang, Xiong wrote: >> > >> > Did this ever get resolved? >> >> I opened https://bugzilla.kernel.org/show_bug.cgi?id=57681 to keep track of >> this and attached the dmesg logs you

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-05-07 Thread Bjorn Helgaas
On Tue, May 7, 2013 at 8:59 AM, Artem S. Tashkinov wrote: > May 7, 2013 09:25:40 PM, Bjorn Helgaas wrote: >> [+cc Phillip] >> >>> I would suspect that Windows' complaint about the BIOS mucking up the MTRRs >>> is likely the best hint. Likely Windo

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-05-07 Thread Bjorn Helgaas
On Tue, May 7, 2013 at 11:50 AM, Artem S. Tashkinov wrote: > May 7, 2013 10:27:30 PM, Bjorn Helgaas wrote: > On Tue, May 7, 2013 at 8:59 AM, Artem S. Tashkinov wrote: >>> May 7, 2013 09:25:40 PM, Bjorn Helgaas wrote: >>>> [+cc Phillip] >>>> >&g

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-05-07 Thread Bjorn Helgaas
On Tue, May 7, 2013 at 12:05 PM, Robert Hancock wrote: > On Tue, May 7, 2013 at 9:59 AM, Artem S. Tashkinov wrote: >> May 7, 2013 09:25:40 PM, Bjorn Helgaas wrote: >>> [+cc Phillip] >>> >>>> I would suspect that Windows' complaint about the

Re: [PATCH] PCI: move down pci_fixup_final for hotplug path

2013-05-07 Thread Bjorn Helgaas
so get it into v3.10 and could get into v3.9 stable instead. > > Reported-by: David Bulkow > Tested-by: David Bulkow > Signed-off-by: Yinghai Lu I applied the following slightly tweaked patch to for-linus and will ask Linus to pull it for v3.10. Let me know if it looks OK. B

Re: [PATCH] PCI: move down pci_fixup_final for hotplug path

2013-05-07 Thread Bjorn Helgaas
On Tue, May 7, 2013 at 2:32 PM, Bjorn Helgaas wrote: > On Thu, Apr 25, 2013 at 06:47:07PM -0700, Yinghai Lu wrote: >> David found some resource conflict issue after >> | PCI: Put pci_dev in device tree as early as possible >> | commit 4f535093cf8f6da8cfda7c36c2c1ecd2e9586e

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-05-07 Thread Bjorn Helgaas
On Tue, May 7, 2013 at 2:48 PM, Patrik Jakobsson wrote: > On Tue, May 7, 2013 at 10:20 PM, Bjorn Helgaas wrote: >>> I'm not sure if reading /proc/mtrr actually reads the registers out of >>> the CPU each time, or whether we just return the cached values we read >>

Re: [PATCH v2 4/4] PCI: Check if the pci device get removed from pci tree already in remove_callback()

2013-05-08 Thread Bjorn Helgaas
On Tue, Apr 30, 2013 at 4:31 AM, Gu Zheng wrote: > From a870da3615988f53a8949e5f8c907b079162067b Mon Sep 17 00:00:00 2001 > From: Gu Zheng > Date: Tue, 30 Apr 2013 18:45:12 +0800 > Subject: [PATCH v2 4/4] PCI: Check if the pci device get removed from pci > tree already in remove_callback > We fo

Re: [PATCH] PCI: Fix racing for pci device removing via sysfs

2013-05-08 Thread Bjorn Helgaas
On Tue, Apr 30, 2013 at 02:29:35PM -0700, Yinghai Lu wrote: > On Mon, Apr 29, 2013 at 3:17 PM, Yinghai Lu wrote: > > On Mon, Apr 29, 2013 at 11:15 AM, Bjorn Helgaas wrote: > >> > >> I think the 1a:01.0 pci_dev should retain its reference to the pci_bus > >> f

[GIT PULL] PCI updates for v3.10

2013-05-09 Thread Bjorn Helgaas
Hi Linus, Here are some fixes for v3.10. They're fairly minor but do fix user-visible issues. Bjorn The following changes since commit ab86e974f04b1cd827a9c7c35273834ebcd9ab38: Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2013-04-30 08:15:4

Re: [PATCH 04/27] block: Convert integrity to bvec_alloc_bs()

2013-05-09 Thread Bjorn Helgaas
On Tue, Feb 19, 2013 at 4:22 PM, Kent Overstreet wrote: > diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c > index 94fa1c5..8c4c604 100644 > --- a/fs/bio-integrity.c > +++ b/fs/bio-integrity.c > ... > @@ -766,13 +733,14 @@ void bioset_integrity_free(struct bio_set *bs) > { > if (bs->

Re: [PATCH -v3] PCI, ACPI, hotplug: Fix BUS_CHECK event handle on root bridge

2013-05-10 Thread Bjorn Helgaas
On Mon, Apr 29, 2013 at 10:19 AM, Jiang Liu wrote: > Hi Yinghai, > Reviewed-by: Jiang Liu > Thanks! > > On 04/26/2013 09:46 AM, Yinghai Lu wrote: >> Gavin found that acpiphp does not handle hotplug anymore even after >> now we have acpiphp built-in preparing for v3.10. >> >> Bjorn

Re: [RFC] The meaning of local_cpulist and local_cpus

2013-04-24 Thread Bjorn Helgaas
[+cc linux-pci, Mike] On Wed, Apr 24, 2013 at 4:06 AM, Bian LuLu wrote: > Hi all, > > Recently, i read some codes of PCI portions. I think > local_cpulist is a list about one kind of CPU and > local_cpus is a mask of CPU. But i am not sure when > and how i should use these two parameters. > > See

Re: [PATCH v3 03/27] PCI: pci resource iterator

2013-04-25 Thread Bjorn Helgaas
On Wed, Apr 24, 2013 at 9:55 PM, Ram Pai wrote: > On Wed, Apr 10, 2013 at 09:22:48AM -0600, Bjorn Helgaas wrote: >> On Mon, Apr 8, 2013 at 10:51 PM, Ram Pai wrote: >> > On Thu, Apr 04, 2013 at 04:18:01PM -0600, Bjorn Helgaas wrote: >> >> On Wed, Mar 13, 2013

Re: [RFC PATCH 1/3] powerpc: Move struct pci_controller to asm-generic

2013-04-25 Thread Bjorn Helgaas
On Thu, Apr 25, 2013 at 3:49 AM, Andrew Murray wrote: > This patch moves struct pci_controller into asm-generic to allow > for use by other architectures thus reducing code duplication in > the kernel. > > Signed-off-by: Andrew Murray > --- > arch/powerpc/include/asm/pci-bridge.h | 87 +---

Re: [PATCH v4 00/29] PCI: Add for_each_pci_resource and addon_res support

2013-04-25 Thread Bjorn Helgaas
On Fri, Apr 12, 2013 at 4:44 PM, Yinghai Lu wrote: > First part is for_each_pci_resource support: > Now pci device resource iteration is done via "for (i=0...)" open code. > That make code hard to read esp when only bridge or sriov resources > are involved. The "for (i = 0; ...)" code *is* a bit

Re: [PATCH v4 27/29] PCI: Make piix4 quirk to use addon_res

2013-04-25 Thread Bjorn Helgaas
On Fri, Apr 12, 2013 at 4:44 PM, Yinghai Lu wrote: > After they are put in add-on resources, they will be safely claimed later. It took me a while to understand what's going on here, but this is actually a pretty cool idea. It would be nice to explain a little about what the patch is doing and h

Re: [PATCH v4 27/29] PCI: Make piix4 quirk to use addon_res

2013-04-26 Thread Bjorn Helgaas
[+cc Rafael, linux-acpi] On Thu, Apr 25, 2013 at 2:39 PM, Bjorn Helgaas wrote: > On Fri, Apr 12, 2013 at 4:44 PM, Yinghai Lu wrote: >> After they are put in add-on resources, they will be safely claimed later. > > It took me a while to understand what's going on here, but

Re: [PATCH] PCI: Fix racing for pci device removing via sysfs

2013-04-26 Thread Bjorn Helgaas
On Thu, Apr 25, 2013 at 7:47 PM, Yinghai Lu wrote: > Gu found nested removing through > echo -n 1 > /sys/bus/pci/devices/\:10\:00.0/remove ; echo -n 1 > > /sys/bus/pci/devices/\:1a\:01.0/remove > > will cause kernel crash as bus get freed. > > [ 418.946462] CPU 4 > [ 418.968377]

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-04-26 Thread Bjorn Helgaas
On Wed, Apr 24, 2013 at 3:33 PM, Alex Williamson wrote: > On Thu, 2013-02-14 at 20:53 -0700, Alex Williamson wrote: >> On Thu, 2013-02-14 at 16:47 -0700, Bjorn Helgaas wrote: >> > On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson >> > wrote: >> > > A bus

Re: [PATCH] PCI: Fix racing for pci device removing via sysfs

2013-04-26 Thread Bjorn Helgaas
On Fri, Apr 26, 2013 at 2:20 PM, Yinghai Lu wrote: > On Fri, Apr 26, 2013 at 9:28 AM, Bjorn Helgaas wrote: >> This is a gross hack. Iterating through all known pci_devs to see if >> this one still exists? >> >> I reproduced the original problem, applied this pat

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-04-26 Thread Bjorn Helgaas
On Wed, Mar 6, 2013 at 5:17 PM, Bjorn Helgaas wrote: > On Tue, Feb 26, 2013 at 12:14 PM, Artem S. Tashkinov > wrote: >> Feb 27, 2013 12:47:01 AM, Bjorn Helgaas wrote: >> On Mon, Feb 25, 2013 at 11:35 PM, Artem S. Tashkinov wrote: >>>> Feb 26, 2013 03

Re: [PATCH] gpu: vga: vgaarb: Ran checkpatch, fixed some warnings

2013-04-26 Thread Bjorn Helgaas
[+cc Dave] I don't maintain this file, regardless of what scripts/get_maintainer.pl says :) On Fri, Apr 26, 2013 at 4:08 PM, Seoras Macdonald wrote: > Fixed some warnings generated by checkpatch and > adjusted some comment blocks to match the coding style. > > Signed-off-by: Seoras Macdonald >

Re: 3.8.4 kernel

2013-04-26 Thread Bjorn Helgaas
On Wed, Mar 27, 2013 at 3:46 PM, Bjorn Helgaas wrote: > On Wed, Mar 27, 2013 at 3:18 PM, Joseph A. Millikan > wrote: >> >> We use Mint 11 32-bit and we've noticed with any kernel beyond 3.6.11, the >> Ethernet port stops responding to pings after 15 minutes and samb

[GIT PULL] PCI changes for v3.10

2013-04-28 Thread Bjorn Helgaas
o_region (Yinghai Lu) - Cache MSI capability offsets & cleanup (Gavin Shan, Bjorn Helgaas) - Clean up EISA resource initialization and logging (Bjorn Helgaas) - Fix prototype warnings (Andy Shevchenko, Bjorn Helgaas) - MIPS: Initialize of_node before scanning bus

Re: [PATCH] PCI: Fix racing for pci device removing via sysfs

2013-04-29 Thread Bjorn Helgaas
On Mon, Apr 29, 2013 at 08:19:10AM -0700, Yinghai Lu wrote: > On Mon, Apr 29, 2013 at 3:04 AM, Gu Zheng wrote: > > On 04/27/2013 05:01 AM, Yinghai Lu wrote: > >> On Fri, Apr 26, 2013 at 1:53 PM, Bjorn Helgaas wrote: > >>> > >>> You can't be seriou

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-04-29 Thread Bjorn Helgaas
On Sat, Apr 27, 2013 at 4:10 AM, Artem S. Tashkinov wrote: >> >>Did this problem ever get resolved? >> > > Hello, > > Unfortunately, no. Out of curiosity I've tried booting kernel > 3.9-rc8 in EUFI mode but it exhibits the same problem. > > Right after the boot: > > [root@localhost ~]# dd if=/dev/

Re: [PATCH v8 10/13] PCI/acpiphp: do not use ACPI PCI subdriver mechanism

2013-04-11 Thread Bjorn Helgaas
On Wed, Apr 10, 2013 at 7:50 PM, Yijing Wang wrote: >>> Hi Bjorn, >>> Thanks for review. >>> My goal is that a user should never have to specify a kernel boot parameter or edit a modules.conf file, but the user did previously have some way to influence whether we use pciehp

Re: [PATCH 2/2] MIPS: implement pcibios_get_phb_of_node

2013-04-11 Thread Bjorn Helgaas
On Thu, Apr 11, 2013 at 11:32 AM, Gabor Juhos wrote: > 2013.04.10. 18:31 keltezéssel, Bjorn Helgaas írta: >> On Thu, Apr 4, 2013 at 12:01 PM, Gabor Juhos wrote: >>> The of_node field of the device assigned to a >>> PCI bus is used during scanning of the PCI bus. >&

Re: [PATCH] pci_ids.h: add PCI_VENDOR_ID_AMCC

2013-04-11 Thread Bjorn Helgaas
On Wed, Mar 6, 2013 at 7:14 AM, Ian Abbott wrote: > Vendor ID 0x10e8 is assigned to Applied Micro Circuits Corporation > (recently AppliedMicro, but AMCC on NASDAQ). The ID currently appears > as PCI_VENDOR_ID_ADDIDATA_OLD in pci_ids.h, which is wrong. Some older > PCI boards made by ADDI-DATA u

Re: [PATCH v9 00/16] Get rid of the ACPI PCI subdriver mechanism

2013-04-12 Thread Bjorn Helgaas
On Fri, Apr 12, 2013 at 9:44 AM, Jiang Liu wrote: > PCI, ACPI: remove ACPI PCI subdriver mechanism > > This patch set is directly derived from two sources: > 1) '[PATCH 00/15] PCI/ACPI: Remove "pci_root" sub-driver support' at > https://lkml.org/lkml/2012/12/7/11 from Myron Stowe > The major goal

Re: [PATCH 2/2] PCI/IA64: fix pci_dev->enable_cnt balance when doing pci hotplug

2013-04-12 Thread Bjorn Helgaas
On Mon, Apr 1, 2013 at 2:42 AM, Yijing Wang wrote: > In IA64 platform, we don't call pci_enable_bridges() > when scan all pci buses during system boot up. But in > X86 we do it in > > pcibios_assign_resources() >pci_assign_unassigned_resources() >... >pci_enable_bridges

Re: [PATCH v7] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-15 Thread Bjorn Helgaas
reminder that their systems are vulnurable to this problem. For > details of those that reported the problem, please see: > https://bugzilla.redhat.com/show_bug.cgi?id=887006 > > Signed-off-by: Neil Horman > CC: Prarit Bhargava > CC: Don Zickus > CC: Don Dutile > CC: Bjorn

Re: [PATCH 1/3] iommu: Move swap_pci_ref function to pci.h.

2013-04-15 Thread Bjorn Helgaas
On Mon, Apr 15, 2013 at 8:58 AM, Joerg Roedel wrote: > On Mon, Apr 15, 2013 at 12:42:00AM +0530, Varun Sethi wrote: >> swap_pci_ref function is used by the IOMMU API code for swapping pci device >> pointers, while determining the iommu group for the device. >> Currently this function was being imp

Re: [PATCH] edac: Handle EDAC ECC errors for Family 16h

2013-04-15 Thread Bjorn Helgaas
On Mon, Apr 15, 2013 at 9:17 AM, Aravind Gopalakrishnan wrote: > Add code to handle ECC decoding for fam16h. Support exists for > previous families already, so code has been reused werever applicable > and some code has been added to handle fam16h specific operations. > > The patch was tested on F

Re: [PATCH 2/6] PCI: use vma_pages() to replace (vm_end - vm_start) >> PAGE_SHIFT

2013-04-15 Thread Bjorn Helgaas
On Mon, Apr 15, 2013 at 6:48 AM, Libin wrote: > (*->vm_end - *->vm_start) >> PAGE_SHIFT operation is implemented > as a inline funcion vma_pages() in linux/mm.h, so using it. > > Signed-off-by: Libin Applied to my pci/misc branch for v3.10, thanks! Bjorn > --- > drivers/pci/pci-sysfs.c | 2 +-

Re: [PATCH v4 01/29] PCI: Clean up quirk_io_region

2013-04-15 Thread Bjorn Helgaas
On Fri, Apr 12, 2013 at 4:44 PM, Yinghai Lu wrote: > Before every quirk_io_region calling, pci_read_config_word is called. > We can fold that calling into quirk_io_region() to make > code more readable. > > According to Bjorn, split this one as separated patch from > addon resource patch. > > Sign

Re: [PATCH] PCI / PM: Fix fallback to PCI_D0 in pci_platform_power_transition()

2013-04-15 Thread Bjorn Helgaas
On Fri, Apr 12, 2013 at 11:50 PM, Yinghai Lu wrote: > On Fri, Apr 12, 2013 at 4:58 PM, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> Commit b51306c (PCI: Set device power state to PCI_D0 for device >> without native PM support) modified pci_platform_power_transition() >> by adding co

Re: is L1 really disabled in iwlwifi

2013-05-16 Thread Bjorn Helgaas
On Sat, May 11, 2013 at 08:22:11PM +, Matthew Garrett wrote: > On Sat, 2013-05-11 at 22:26 +0200, Rafael J. Wysocki wrote: > > On Friday, May 10, 2013 04:52:57 PM Bjorn Helgaas wrote: > > > I propose the following patch. Any comments? > > > > In my opinion this

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-17 Thread Bjorn Helgaas
[+cc Rafael because he knows about dev->state_saved] Sorry, I'm not very familiar with AER, so please excuse some naive questions below. On Fri, Apr 26, 2013 at 12:28 AM, Zhang, LongX wrote: > From: Zhang Long > > Specific pci device drivers might have many functions to call > pci_channel_offli

Re: The dd72be99 breaks some of Intel Medfield based devices

2013-05-20 Thread Bjorn Helgaas
[+cc linux-pci and cc list of Bin's original posting] On Mon, May 20, 2013 at 9:09 AM, Andy Shevchenko wrote: > Hi! > > I don't know what you trying to fix, but your patch dd72be99 > "x86/pci/mrst: Use configuration mechanism 1 for 00:00.0, 00:02.0, > 00:03.0" breaks Intel Medfield devices. > > A

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-20 Thread Bjorn Helgaas
On Fri, May 17, 2013 at 5:56 PM, Rafael J. Wysocki wrote: > On Friday, May 17, 2013 05:43:33 PM Bjorn Helgaas wrote: >> On Fri, Apr 26, 2013 at 12:28 AM, Zhang, LongX wrote: >> > + /* restore cfg space for possible link reset at upstream */ >> > + dev->

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-20 Thread Bjorn Helgaas
On Fri, Apr 26, 2013 at 06:28:59AM +, Zhang, LongX wrote: > From: Zhang Long > > Specific pci device drivers might have many functions to call > pci_channel_offline to check device states. When slot_reset happens, > drivers' slot_reset callback might call such functions and eventually > abort

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-21 Thread Bjorn Helgaas
On Tue, May 21, 2013 at 1:40 AM, Yanmin Zhang wrote: > On Mon, 2013-05-20 at 16:48 -0600, Bjorn Helgaas wrote: >> On Fri, Apr 26, 2013 at 06:28:59AM +, Zhang, LongX wrote: >> > From: Zhang Long >> > >> > Specific pci device drivers might have many functi

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-21 Thread Bjorn Helgaas
On Tue, May 21, 2013 at 9:41 AM, Liu, Joseph wrote: > Bjorn, > >>> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c >>> index ed4d094..7abefd9 100644 >>> --- a/drivers/pci/pcie/portdrv_pci.c >>> +++ b/drivers/pci/pcie/portdrv_pci.c >>> @@ -332,13 +332,11 @@ static pci_e

Re: [PATCH 1/2] PCI: Split pci_assign_unassigned_resources to per root bus

2013-05-21 Thread Bjorn Helgaas
On Mon, May 06, 2013 at 04:15:29PM -0700, Yinghai Lu wrote: > BenH reported that there is some assign unassigned resource problem > in powerpc. > > It turns out after > | commit 0c5be0cb0edfe3b5c4b62eac68aa2aa15ec681af > | Date: Thu Feb 23 19:23:29 2012 -0800 > | > |PCI: Retry on IORESOURCE_

[GIT PULL] PCI updates for v3.10

2013-05-23 Thread Bjorn Helgaas
e configuration mechanism 1 for 00:00.0, 00:02.0, 00:03.0" Hotplug PCI: acpiphp: Re-enumerate devices when host bridge receives Bus Check -------- Bjorn Helgaas (1): Revert "x86/pci/mrst: Use configuration mechanism 1 for 0

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-24 Thread Bjorn Helgaas
b/0x28 > [] ? rest_init+0x60/0x60 > > The most reliable way to trigger this crash seems to be booting a 32-bit > kernel via the EFI boot stub. > > The solution is to use early_ioremap() instead of phys_to_virt() to map > the setup data into the kernel address space. > > T

Re: [PATCH] PCI: Don't let mmio fallback to must-only, if ioport fails with must+optional

2013-05-24 Thread Bjorn Helgaas
On Thu, May 23, 2013 at 11:11 AM, Yinghai Lu wrote: > BenH reported that there is some assign unassigned resource problem > in powerpc. > > It turns out after > | commit 0c5be0cb0edfe3b5c4b62eac68aa2aa15ec681af > | Date: Thu Feb 23 19:23:29 2012 -0800 > | > |PCI: Retry on IORESOURCE_IO type

Re: [PATCH v2] aerdrv: Move cper_print_aer() call out of interrupt context

2013-05-24 Thread Bjorn Helgaas
On Thu, May 9, 2013 at 1:51 PM, Lance Ortiz wrote: > The following warning was seen on 3.9 when a corrected PCIe error was being > handled by the AER subsystem. > > WARNING: at .../drivers/pci/search.c:214 pci_get_dev_by_id+0x8a/0x90() > > This occurred because a call to pci_get_domain_bus_and_slo

Re: [PATCH 09/24] drivers/pci/ioapic: Convert to module_pci_driver

2013-05-27 Thread Bjorn Helgaas
On Sun, May 26, 2013 at 8:28 PM, Libo Chen wrote: > use module_pci_driver instead of init/exit, make code clean. > > Signed-off-by: Libo Chen > --- > drivers/pci/ioapic.c | 13 + > 1 files changed, 1 insertions(+), 12 deletions(-) Applied to my pci/misc branch for v3.11, thanks!

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-28 Thread Bjorn Helgaas
On Tue, May 28, 2013 at 5:36 AM, Matt Fleming wrote: > On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: >> pcibios_add_device() is mostly called at boot-time, when >> early_ioremap() probably works well. But it's also called when we >> hot-add devices later, and i

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-28 Thread Bjorn Helgaas
On Tue, May 28, 2013 at 10:48 AM, Matthew Garrett wrote: > On Tue, May 28, 2013 at 10:31:51AM -0600, Bjorn Helgaas wrote: >> On Tue, May 28, 2013 at 5:36 AM, Matt Fleming wrote: >> > On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: >> >> pcibios_add_device()

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-28 Thread Bjorn Helgaas
desc::multiple' is a bitfield, throwing it out > would not save us any space. > > Signed-off-by: Alexander Gordeev > --- > drivers/pci/msi.c | 10 -- > include/linux/msi.h |1 + > 2 files changed, 9 insertions(+), 2 deletions(-) Acked-by: Bjorn Helgaas

Re: [PATCH v1 1/2] ACPI, PCI: remove unused global list acpi_pci_roots in pci_root.c

2013-05-28 Thread Bjorn Helgaas
gt; --- > drivers/acpi/pci_root.c | 25 +++-- > include/acpi/acpi_bus.h | 1 - > 2 files changed, 3 insertions(+), 23 deletions(-) This and the "use acpi_handle_print()" patch look fine to me. Rafael, I can take them, or if you want to take them yourself, y

Re: [PATCH v2 0/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id

2013-03-26 Thread Bjorn Helgaas
On Wed, Feb 27, 2013 at 5:06 PM, Shuah Khan wrote: > pci defines PCI_DEVFN(), PCI_SLOT(), and PCI_FUNC() interfaces, however, > it doesn't have interfaces to return PCI bus and PCI device id. Drivers > (AMD IOMMU, and AER) have module specific definitions for PCI_BUS() and > AMD_IOMMU driver also

Re: [PATCH] pci: do not try to assign irq 255

2013-03-26 Thread Bjorn Helgaas
On Tue, Mar 5, 2013 at 3:41 PM, Sarah Sharp wrote: > On Fri, Mar 01, 2013 at 08:41:13AM +0100, Hannes Reinecke wrote: >> On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: >> >[+cc Andy] >> > >> >3) I don't understand why the xhci init fails in the first place.

Re: [PATCH v2 0/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id

2013-03-26 Thread Bjorn Helgaas
On Tue, Mar 26, 2013 at 3:59 PM, Joerg Roedel wrote: > Hi Bjorn, > > On Tue, Mar 26, 2013 at 03:41:07PM -0600, Bjorn Helgaas wrote: >> Since some of these touch drivers/iommu, it'd be good if you acked >> them again, Joerg. I know you acked them before, but there have b

Re: [PATCH] PCI, ACPI: hold acpi_scan_lock during root bus hotplug

2013-03-26 Thread Bjorn Helgaas
On Tue, Mar 26, 2013 at 4:54 PM, Rafael J. Wysocki wrote: > On Tuesday, March 26, 2013 08:12:30 AM Yinghai Lu wrote: >> On Tue, Mar 26, 2013 at 6:24 AM, Rafael J. Wysocki wrote: >> > On Sunday, March 10, 2013 10:05:16 PM Yinghai Lu wrote: >> >> During merging pci tree with pm/acpi tree, Linus not

Re: [PATCH 1/3] pci: Add PCI ROM helper for platform-provided ROM images

2013-03-26 Thread Bjorn Helgaas
On Tue, Mar 26, 2013 at 3:25 PM, Matthew Garrett wrote: > It turns out that some UEFI systems provide apparently an apparently valid > PCI ROM BAR that turns out to contain garbage, so the attempt in f4eb5ff05 > to prefer the ROM from the BAR actually breaks a different set of machines. > As Linus

Re: [PATCH] kernel/range.c: subtract_range: fix the broken phrase issued by printk

2013-03-27 Thread Bjorn Helgaas
On Mon, Mar 18, 2013 at 9:54 PM, Lin Feng wrote: > Also replace deprecated printk(KERN_ERR...) with pr_err() as suggested > by Yinghai, attaching the function name to provide plenty info. > > Cc: Yinghai Lu > Signed-off-by: Lin Feng > --- > kernel/range.c | 3 ++- > 1 file changed, 2 insertions

Re: Regression: Screen turns off when booting in EFI mode

2013-03-27 Thread Bjorn Helgaas
[+cc Chris, reporter of Fedora issue] On Mon, Mar 25, 2013 at 5:55 PM, Matthew Garrett wrote: > On Tue, Mar 26, 2013 at 09:52:14AM +1000, Dave Airlie wrote: >> >>> Because it's the only way to get the PCI ROM in some cases, like on >> >>> pretty much all Apples with Radeons. Only using it if we h

Re: Regression: Screen turns off when booting in EFI mode

2013-03-27 Thread Bjorn Helgaas
On Wed, Mar 27, 2013 at 2:02 PM, Dave Airlie wrote: >> >> That RedHat bugzilla is from kernel-3.9.0-0.rc4.git0.1.fc19.x86_64. >> Does that kernel include Matthew's patch from Mar 19? I'm wondering >> if that report is for the same problem Mantas saw and possibly would >> be *fixed* by the Mar 19

Re: [PATCH 1/3] pci: Add PCI ROM helper for platform-provided ROM images

2013-03-27 Thread Bjorn Helgaas
[+cc Mantas, Chris] On Tue, Mar 26, 2013 at 4:55 PM, Matthew Garrett wrote: > On Tue, 2013-03-26 at 16:53 -0600, Bjorn Helgaas wrote: > >> I've been on vacation and didn't follow this closely, but it seems >> like this fixes a regression and should be merged be

Re: [PATCH 1/3] pci: Add PCI ROM helper for platform-provided ROM images

2013-03-27 Thread Bjorn Helgaas
[+cc linux-pci] On Wed, Mar 27, 2013 at 2:33 PM, Bjorn Helgaas wrote: > [+cc Mantas, Chris] > > On Tue, Mar 26, 2013 at 4:55 PM, Matthew Garrett > wrote: >> On Tue, 2013-03-26 at 16:53 -0600, Bjorn Helgaas wrote: >> >>> I've been on vacation and didn't

Re: 3.8.4 kernel

2013-03-27 Thread Bjorn Helgaas
On Wed, Mar 27, 2013 at 3:18 PM, Joseph A. Millikan wrote: > > We use Mint 11 32-bit and we've noticed with any kernel beyond 3.6.11, the > Ethernet port stops responding to pings after 15 minutes and samba clients > cease to receive data in realtime. I hope this is the correct place to > report

Re: 3.8.4: ohci question

2013-03-27 Thread Bjorn Helgaas
[+cc linux-usb] On Wed, Mar 27, 2013 at 11:37 AM, Udo van den Heuvel wrote: > Hello, > > When my dmesg gives me a growing number of lines like the one below, > what is going on? > > ohci_hcd :00:12.0: urb 88023025c500 path 2 ep1in 6c16 cc 6 > --> status -71 > > Please let me know! >

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-03-27 Thread Bjorn Helgaas
On Mon, Mar 18, 2013 at 11:37 AM, Yinghai Lu wrote: > Roman reported ath5k does not work anymore on 3.8. > Bisected to > | commit 8c33f51df406e1a1f7fa4e9b244845b7ebd61fa6 > | Author: Taku Izumi > | Date: Tue Oct 30 15:27:13 2012 +0900 > | > |PCI/ACPI: Request _OSC control before scanning PC

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-03-28 Thread Bjorn Helgaas
On Thu, Mar 28, 2013 at 1:41 AM, Yinghai Lu wrote: > On Wed, Mar 27, 2013 at 3:56 PM, Bjorn Helgaas wrote: >> >> Why can't we set all the ASPM flags *first*, before calling >> pci_acpi_scan_root()? That way we could just do the correct ASPM >> setup as we dis

Re: [PATCH 1/2] eisa, PCI: Fix bus res reference

2013-03-28 Thread Bjorn Helgaas
On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu wrote: > Matthem found that 3.8.3 is having problems with an old (ancient) > PCI-to-EISA bridge, the Intel 82375. It worked with the 3.2 kernel. > He identified the 82375, but doesn't assign the struct resource *res > pointer inside the struct eisa_root

Re: [PATCH 1/2] eisa, PCI: Fix bus res reference

2013-03-28 Thread Bjorn Helgaas
On Thu, Mar 28, 2013 at 9:16 AM, Yinghai Lu wrote: > On Thu, Mar 28, 2013 at 5:52 AM, Bjorn Helgaas wrote: >> On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu wrote: >>> Matthem found that 3.8.3 is having problems with an old (ancient) >>> PCI-to-EISA bridge, the Intel 82

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-03-28 Thread Bjorn Helgaas
; On Thu, Mar 28, 2013 at 5:46 AM, Bjorn Helgaas wrote: > >> This patch might be *safe*, but it (and the changelog) are completely > >> unintelligible. > >> > >> The problem with applying an unintelligible stop-gap patch is that it > >> becomes forever pa

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-03-29 Thread Bjorn Helgaas
On Thu, Mar 28, 2013 at 11:59 PM, Yinghai Lu wrote: > > On Thu, Mar 28, 2013 at 8:22 PM, Bjorn Helgaas wrote: >> >> [+cc Matthew] >> [+cc e1000-de...@lists.sourceforge.net for suspected 82575/82598 >> regression] >> >> On Thu, Mar 28, 2013 at 01:24:55

Re: [PATCH 0/2] eisa: fix eisa with PCI

2013-03-29 Thread Bjorn Helgaas
[+cc linux-pci] On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu wrote: > Looks like pci eisa bridge support is broken for a while. > > one is root io resource reference, and other one is pnp related. > > Please check if we can put them in v3.9. > eisa, PCI: Fix bus res reference > ei

Re: [PATCH 1/2] eisa, PCI: Fix bus res reference

2013-03-29 Thread Bjorn Helgaas
On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu wrote: > Matthem found that 3.8.3 is having problems with an old (ancient) > PCI-to-EISA bridge, the Intel 82375. It worked with the 3.2 kernel. > He identified the 82375, but doesn't assign the struct resource *res > pointer inside the struct eisa_root

Re: [PATCH 2/2] eisa, PCI: init eisa early before pnp step in

2013-03-29 Thread Bjorn Helgaas
[+cc Rafael, just FYI since it involves PNP resources] On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu wrote: > Mathhew reported kernels fail the pci_eisa probe and are later successful > with the virtual_eisa_root_init force probe without slot0. > > The reason for that is: pnp probing is early than

Re: [PATCH 1/2] eisa, PCI: Fix bus res reference

2013-03-29 Thread Bjorn Helgaas
On Fri, Mar 29, 2013 at 12:10:37PM -0700, Yinghai Lu wrote: > On Fri, Mar 29, 2013 at 11:10 AM, Bjorn Helgaas wrote: > > On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu wrote: > >> Matthem found that 3.8.3 is having problems with an old (ancient) > >> PCI-to-EISA bridge,

Re: PNP: List Rafael Wysocki as a maintainer

2013-03-30 Thread Bjorn Helgaas
tainer of it > along with Bjorn and remove the Adam's entry from it. > > Signed-off-by: Rafael J. Wysocki Acked-by: Bjorn Helgaas I poked around a bit and it looks like Adam is in the Stanford Ph.D. program, but I couldn't find a newer email address for him. > --- >

Re: 3.8.0-rc4+ - Oops on removing WinTV-HVR-1400 expresscard TV Tuner

2013-04-01 Thread Bjorn Helgaas
gzilla, I think. > > > On 03/15/13 22:48, Bjorn Helgaas wrote: >> >> On Tue, Mar 12, 2013 at 4:20 PM, Bjorn Helgaas >> wrote: >>> >>> On Sat, Mar 9, 2013 at 2:20 AM, Chris Clayton >>> wrote: >>>> >>>> On 03/08/13 22:57, Bjorn He

Re: [Update][PATCH] PCI / PM: Disable runtime PM of PCIe ports

2013-04-01 Thread Bjorn Helgaas
[+cc Zheng, who added this with 71a83bd727] On Sat, Mar 30, 2013 at 4:38 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The runtime PM of PCIe ports turns out to be quite fragile, as in > some cases things work while in some other cases they don't and we > don't seem to have a good w

Re: [PATCH 1/3] pci: Add PCI ROM helper for platform-provided ROM images

2013-04-01 Thread Bjorn Helgaas
On Thu, Mar 28, 2013 at 2:48 AM, Mantas Mikulėnas wrote: > On 2013-03-27 22:33, Bjorn Helgaas wrote: >> On Tue, Mar 26, 2013 at 4:55 PM, Matthew Garrett >> wrote: >>> On Tue, 2013-03-26 at 16:53 -0600, Bjorn Helgaas wrote: >>> >>>> I've been

Re: [PATCH 4/5] dump_stack: implement arch-specific hardware description in task dumps

2013-04-01 Thread Bjorn Helgaas
On Fri, Mar 29, 2013 at 8:27 PM, Tejun Heo wrote: > x86 and ia64 can acquire extra hardware identification information > from DMI and print it along with task dumps; however, the usage isn't > consistent. > > * x86 show_regs() collects vendor, product and board strings and print > them out with

Re: [PATCH 2/2] eisa, PCI: init eisa early before pnp step in

2013-04-01 Thread Bjorn Helgaas
On Fri, Mar 29, 2013 at 6:18 PM, Yinghai Lu wrote: > On Fri, Mar 29, 2013 at 3:22 PM, Bjorn Helgaas wrote: >> [+cc Rafael, just FYI since it involves PNP resources] >> >> On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu wrote: >>> Mathhew reported kernels fail th

Re: [PATCH 2/2] eisa, PCI: init eisa early before pnp step in

2013-04-01 Thread Bjorn Helgaas
On Mon, Apr 1, 2013 at 12:25 PM, Yinghai Lu wrote: > On Mon, Apr 1, 2013 at 11:15 AM, Bjorn Helgaas wrote: >>> >> Is this a regression? This must have worked at one time, but it seems >> >> like we've had pnpacpi_init/isapnp_init/pnpbios_init before

Re: [Update][PATCH] PCI / PM: Disable runtime PM of PCIe ports

2013-04-01 Thread Bjorn Helgaas
On Mon, Apr 1, 2013 at 2:51 PM, Rafael J. Wysocki wrote: > On Monday, April 01, 2013 11:34:46 AM Bjorn Helgaas wrote: >> [+cc Zheng, who added this with 71a83bd727] >> >> On Sat, Mar 30, 2013 at 4:38 PM, Rafael J. Wysocki wrote: >> > From: Rafael J. Wysocki &g

Re: [PATCH 0/2] eisa: fix eisa with PCI

2013-04-01 Thread Bjorn Helgaas
On Fri, Mar 29, 2013 at 9:16 AM, Bjorn Helgaas wrote: > [+cc linux-pci] > > On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu wrote: >> Looks like pci eisa bridge support is broken for a while. >> >> one is root io resource reference, and other one is pnp related. >&

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-04-01 Thread Bjorn Helgaas
On Fri, Mar 29, 2013 at 11:04:48AM -0700, Yinghai Lu wrote: > attatched -v3 again > > On Fri, Mar 29, 2013 at 11:02 AM, Yinghai Lu wrote: > > On Fri, Mar 29, 2013 at 5:24 AM, Bjorn Helgaas wrote: > >> > >> Half of your v1 patch (removing the pcie_aspm_sanity_

Re: 3.8.0-rc4+ - Oops on removing WinTV-HVR-1400 expresscard TV Tuner

2013-03-06 Thread Bjorn Helgaas
On Thu, Jan 31, 2013 at 5:09 AM, Chris Clayton wrote: > My usb3 expresscard device has arrived and I get an oops with that too, if I > remove it without unloading the driver first. I guess it shouldn't be a > surprise that the driver isn't expecting the device to disappear. > > As I mentioned, I

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-03-06 Thread Bjorn Helgaas
On Tue, Feb 26, 2013 at 12:14 PM, Artem S. Tashkinov wrote: > Feb 27, 2013 12:47:01 AM, Bjorn Helgaas wrote: > On Mon, Feb 25, 2013 at 11:35 PM, Artem S. Tashkinov wrote: >>> Feb 26, 2013 03:57:52 AM, Bjorn Helgaas wrote: >>>> >>>>Where are we at with this

Re: [PATCH 1/2] PCI: define macro for marvell vendor ID

2013-03-07 Thread Bjorn Helgaas
On Thu, Mar 7, 2013 at 7:28 AM, wrote: > From: Xiangliang Yu > > Define PCI_VENDOR_MARVELL_ID_EXT macro for 0x1b4b vendor ID "PCI_VENDOR_MARVELL_ID_EXT" is not actually the symbol you defined below. Per the comment at the top of pci_ids.h, we don't add things here unless they are shared betwee

Re: [PATCH 2/2] PCI: fix system hang issue of Marvell SATA host controller

2013-03-07 Thread Bjorn Helgaas
On Thu, Mar 7, 2013 at 7:29 AM, wrote: > From: Xiangliang Yu > > Fix system hang issue: if first accessed resource file of BAR0 ~ > BAR4, system will hang after executing lspci command This needs more explanation. We've already read the BARs by the time header quirks are run, so apparently it'

Re: 3.8.0-rc4+ - Oops on removing WinTV-HVR-1400 expresscard TV Tuner

2013-03-07 Thread Bjorn Helgaas
On Thu, Mar 7, 2013 at 9:28 AM, Chris Clayton wrote: > > > On 03/06/13 23:45, Bjorn Helgaas wrote: >> >> On Thu, Jan 31, 2013 at 5:09 AM, Chris Clayton >> wrote: >> >>> My usb3 expresscard device has arrived and I get an oops with that too, >>&

Re: 3.8.0-rc4+ - Oops on removing WinTV-HVR-1400 expresscard TV Tuner

2013-03-07 Thread Bjorn Helgaas
On Thu, Mar 7, 2013 at 1:21 PM, Chris Clayton wrote: > > > On 03/07/13 17:30, Bjorn Helgaas wrote: >> >> On Thu, Mar 7, 2013 at 9:28 AM, Chris Clayton >> wrote: >>> >>> >>> >>> On 03/06/13 23:45, Bjorn Helgaas wrote: >>>>

Re: [PATCH 2/2] PCI: fix system hang issue of Marvell SATA host controller

2013-03-07 Thread Bjorn Helgaas
On Thu, Mar 7, 2013 at 8:07 PM, Xiangliang Yu wrote: > Hi, Bjorn > >> > Fix system hang issue: if first accessed resource file of BAR0 ~ >> > BAR4, system will hang after executing lspci command >> >> This needs more explanation. We've already read the BARs by the time >> header quirks are run, s

Re: [PATCH 2/2] PCI: fix system hang issue of Marvell SATA host controller

2013-03-08 Thread Bjorn Helgaas
On Thu, Mar 7, 2013 at 11:51 PM, Xiangliang Yu wrote: > Hi, Bjorn > >> >> > Fix system hang issue: if first accessed resource file of BAR0 ~ >> >> > BAR4, system will hang after executing lspci command >> >> >> >> This needs more explanation. We've already read the BARs by the time >> >> header q

Re: 3.8.0-rc4+ - Oops on removing WinTV-HVR-1400 expresscard TV Tuner

2013-03-08 Thread Bjorn Helgaas
[+cc Rafael, in case the _OSC thing rings a bell with him] On Fri, Mar 8, 2013 at 3:44 AM, Chris Clayton wrote: > On 03/08/13 00:39, Bjorn Helgaas wrote: >> On Thu, Mar 7, 2013 at 1:21 PM, Chris Clayton >> wrote: >>> On 03/07/13 17:30, Bjorn Helgaas wrote: >>>&

Re: [PATCH] Fix priority of non-BAR ROM data

2012-08-01 Thread Bjorn Helgaas
On Sun, Jul 29, 2012 at 3:53 PM, Matthew Garrett wrote: > On Sun, Jul 29, 2012 at 10:49:42PM +0100, David Woodhouse wrote: >> + * Some devices may provide ROMs via a source other than the BAR >> + */ >> + if (pdev->rom && pdev->romlen) { >> + *size = pdev->romlen; >> +

Re: [PATCH] pci: Account for virtual buses in pci_acs_path_enabled

2012-08-05 Thread Bjorn Helgaas
On Sat, Aug 4, 2012 at 12:19 PM, Alex Williamson wrote: > It's possible to have buses without an associated bridge > (bus->self == NULL). SR-IOV can generate such buses. When > we find these, skip to the parent bus to look for the next > ACS test. To make sure I understand the problem here, I t

Re: [PATCH] pci: Account for virtual buses in pci_acs_path_enabled

2012-08-06 Thread Bjorn Helgaas
On Sun, Aug 5, 2012 at 11:55 PM, Alex Williamson wrote: > On Sun, 2012-08-05 at 23:30 -0600, Bjorn Helgaas wrote: >> On Sat, Aug 4, 2012 at 12:19 PM, Alex Williamson >> wrote: >> > It's possible to have buses without an associated bridge >> > (bus->self

<    2   3   4   5   6   7   8   9   10   11   >