Re: [PATCH 4/4] [SCSI]stex: minor cleanup and version update

+ (%s): resetting host\n, pci_name(hba-pdev)); + scsi_print_command(cmd); + Same here. Brian -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 10/20] drivers/scsi/ipr.c: use LIST_HEAD instead of LIST_HEAD_INIT

Acked-by: Brian King [EMAIL PROTECTED] Denis Cheng wrote: single list_head variable initialized with LIST_HEAD_INIT could almost always can be replaced with LIST_HEAD declaration, this shrinks the code and looks better. Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- drivers/scsi/ipr.c

Re: [PATCH 3/8] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

be simplified to an else if, which would remove one indent level... -Brian -- Brian King Linux on Power Virtualization IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 7/8] scsi: megaraid_sas - support for poll_mode_io (reduced interrupt)

PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- Brian King Linux on Power Virtualization IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 3/8] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

*From:* Brian King [mailto:[EMAIL PROTECTED] *Sent:* Fri 9/28/2007 3:30 PM *To:* Yang, Bo *Cc:* [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; Patro, Sumant *Subject:* Re: [PATCH 3/8] scsi

Re: [PATCH] drivers/net/ibmveth.c: memset fix

of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- Brian King Linux on Power Virtualization IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] drivers/net/ibmveth.c: memset fix

Mariusz Kozlowski wrote: Looks like memset() is zeroing wrong nr of bytes. Good catch, however, I think we can just remove this memset altogether since the memory gets allocated via kzalloc. Correct, that memset() is superfluous. Ok. Then this should do it. Acked-by: Brian King [EMAIL

Re: pci: Arch hook to determine config space size

Grant Grundler wrote: On Mon, Jan 31, 2005 at 01:40:04PM -0600, Brian King wrote: CC'ing the linux-pci mailing list... thanks... This patch adds an arch hook so that individual archs can indicate if the underlying system supports expanded config space accesses or not. @@ -653,6 +653,8 @@ static

Re: pci: Arch hook to determine config space size

agree. Also, when sending PCI related patches, please cc the linux-pci mailing list. How about this? -- Brian King eServer Storage I/O IBM Linux Technology Center When working with a PCI-X Mode 2 adapter on a PCI-X Mode 1 PPC64 system, the current code used to determine the config space size

Re: pci: Arch hook to determine config space size

Brian King wrote: Greg KH wrote: On Fri, Jan 28, 2005 at 06:52:34PM +, Christoph Hellwig wrote: +int __attribute__ ((weak)) pcibios_exp_cfg_space(struct pci_dev *dev) { return 1; } - prototypes belong to headers - weak linkage is the perfect way for total obsfucation please make

Re: pci: Arch hook to determine config space size

PCIBIOS_BAD_REGISTER_NUMBER; is checked for in drivers/pci/access.c I can submit a separate patch to clean that up. -- Brian King eServer Storage I/O IBM Linux Technology Center When working with a PCI-X Mode 2 adapter on a PCI-X Mode 1 PPC64 system, the current code used to determine the config space size

Re: pci: Arch hook to determine config space size

Arnd Bergmann wrote: On Maandag 31 Januar 2005 22:35, Brian King wrote: Matthew Wilcox wrote: Basically, ppc64's config ops are broken and need to check the offset being read. Here's i386: static int pci_conf1_write (int seg, int bus, int devfn, int reg, int len, u32 v alue) { unsigned

Re: pci: Arch hook to determine config space size

Benjamin Herrenschmidt wrote: On Mon, 2005-01-31 at 16:43 -0600, Brian King wrote: diff -puN include/asm-ppc64/prom.h~ppc64_pcix_mode2_cfg include/asm-ppc64/prom.h --- linux-2.6.11-rc2-bk9/include/asm-ppc64/prom.h~ppc64_pcix_mode2_cfg 2005-01-31 14:32:01.0 -0600 +++ linux-2.6.11-rc2-bk9

Re: [PATCH 1/1] PCI: Dynids - passing driver data

option is to somehow change the driver to cope with having no driver data, but that will result in more driver code and will ultimately be less flexible in the new chipsets that can be added using dynids. -Brian -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from

Re: [PATCH 1/1] PCI: Dynids - passing driver data

define the operation as cloning of an entry for another device ID, including its driver_data. Possibly. That would potentially require a lot of parameters to userspace. We would really need to duplicate all the currently existing sysfs parms to accomplish this. -- Brian King eServer Storage I/O IBM

Re: [PATCH 1/1] PCI: Dynids - passing driver data

checking on it to verify it is a valid value before indexing into the array. -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 3/13]: PCI Err: IPR scsi device driver recovery

to the pci adapter at all, or should it simply clean up after it? -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: How to add/drop SCSI drives from within the driver?

[EMAIL PROTECTED] list for help. -- Patrick Mansfield - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- Brian King eServer Storage I/O IBM Linux Technology Center

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Alan Cox wrote: On Maw, 2005-01-18 at 15:14, Brian King wrote: Alan - are you satisfied with the most recent patch, or would you prefer the patch not returning failure return codes and just bit bucketing writes and returning all ff's on reads? Either way works for me. Which was the last one

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Alan Cox wrote: On Mer, 2005-01-26 at 22:10, Benjamin Herrenschmidt wrote: On Wed, 2005-01-26 at 10:34 -0600, Brian King wrote: Well, I honestly think that this is unnecessary burden. I think that just dropping writes returning data from the cache on reads is enough, blocking userspace isn't

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Alan Cox wrote: On Mer, 2005-01-26 at 22:10, Benjamin Herrenschmidt wrote: On Wed, 2005-01-26 at 10:34 -0600, Brian King wrote: Well, I honestly think that this is unnecessary burden. I think that just dropping writes returning data from the cache on reads is enough, blocking userspace isn't

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Thanks for looking at this, Greg. Greg KH wrote: On Fri, Jan 28, 2005 at 08:35:46AM -0600, Brian King wrote: +PCI_USER_READ_CONFIG(byte, u8) +PCI_USER_READ_CONFIG(word, u16) +PCI_USER_READ_CONFIG(dword, u32) +PCI_USER_WRITE_CONFIG(byte, u8) +PCI_USER_WRITE_CONFIG(word, u16) +PCI_USER_WRITE_CONFIG

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

management on PPC where a given device could have its config space blocked for a long time. -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Matthew Wilcox wrote: On Tue, Feb 01, 2005 at 11:35:05AM -0600, Brian King wrote: If we've done a write to config space while the adapter was blocked, shouldn't we replay those accesses at this point? I did not think that was necessary. We have to do *something*. We can't just throw away writes

Re: pci: Arch hook to determine config space size

Matthew Wilcox wrote: On Mon, Jan 31, 2005 at 10:52:29PM -0600, Brian King wrote: @@ -62,8 +72,11 @@ static int rtas_read_config(struct devic return PCIBIOS_DEVICE_NOT_FOUND; if (where (size - 1)) return PCIBIOS_BAD_REGISTER_NUMBER; You should probably

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Matthew Wilcox wrote: On Tue, Feb 01, 2005 at 11:35:05AM -0600, Brian King wrote: If we've done a write to config space while the adapter was blocked, shouldn't we replay those accesses at this point? I did not think that was necessary. We have to do *something*. We can't just throw away writes

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

the patch not returning failure return codes and just bit bucketing writes and returning all ff's on reads? Either way works for me. -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Andi Kleen wrote: On Tue, Jan 18, 2005 at 09:14:21AM -0600, Brian King wrote: Andi Kleen wrote: As Brian said the device he was working with would just not answer, leading to a bus abort. This would get on a PC. You could simulate this if you want, although I think a EBUSY or EIO

Re: [PATCH 1/1] block: IBM RamSan 70/80 driver fixes.

to the 8 in the array above? If so, why not have a literal to define the 8 and use it in both places to make this clear? -Brian -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 1/1] block: CFQ refcounting fix

to the leak) ran the scan a few times and verified /proc/meminfo didn't continually decrease like without it, and rebooted again. If there is anything else you would like me to do, I would be happy to do so. Thanks Brian -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from

Re: [PATCH 1/1] block: CFQ refcounting fix

Jens Axboe wrote: On Wed, Aug 31 2005, Brian King wrote: Jens Axboe wrote: On Tue, Aug 30 2005, [EMAIL PROTECTED] wrote: I ran across a memory leak related to the cfq scheduler. The cfq init function increments the refcnt of the associated request_queue. This refcount gets decremented

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

Andrew Morton wrote: Brian King [EMAIL PROTECTED] wrote: +void pci_block_user_cfg_access(struct pci_dev *dev) +{ + unsigned long flags; + + pci_save_state(dev); + spin_lock_irqsave(pci_lock, flags); + dev-block_ucfg_access = 1; + spin_unlock_irqrestore(pci_lock

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

grabs the lock, so we would need to use some special code that did not acquire the lock in pci_save_state if we wanted to do such a thing. Brian -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH 1/2] pci: Block config access during BIST (resend)

Brian King wrote: Greg KH wrote: Here is an updated patch which will now fail writes to config space while the device is blocked. I have also fixed up the caching to return the correct data and tested it on both little endian and big endian machines. Applied, thanks. greg k-h Greg

Re: [PATCH 2/2] ipr: Block config access during BIST (resend)

Greg, Please apply along with the previous pci patch. Thanks -- Brian King eServer Storage I/O IBM Linux Technology Center IPR scsi adapter have an exposure today in that they issue BIST to the adapter to reset the card. If, during the time it takes to complete BIST, userspace attempts

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

Grant Grundler wrote: On Sat, Sep 03, 2005 at 06:37:52PM -0500, Brian King wrote: ... Without the locking, we introduce a race condition. CPU 0 CPU 1 pci_block_user_cfg_access

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

Grant Grundler wrote: On Mon, Sep 05, 2005 at 01:31:20PM -0500, Brian King wrote: +void pci_block_user_cfg_access(struct pci_dev *dev) +{ + pci_save_state(dev); + dev-block_ucfg_access = 1; + mb(); + while (spin_is_locked(pci_lock)) + cpu_relax(); +} +EXPORT_SYMBOL_GPL

Re: [PATCH 1/2] pci: Block config access during BIST (resend)

that's already atomic (assignment) even caught Andrew's attention. I reverted the patch to use a spinlock and added a comment. How does this look? -- Brian King eServer Storage I/O IBM Linux Technology Center Some PCI adapters (eg. ipr scsi adapters) have an exposure today in that they issue

Re: [patch 2/2] [SCSI] ipr: remove an unneeded check

On 07/30/2012 03:18 AM, Dan Carpenter wrote: rc is always zero here, so there is no need to check. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Thanks! Acked-by: Brian King brk...@linux.vnet.ibm.com -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe

Re: [patch 1/2] [SCSI] ipr: missing unlock before a return

On 07/30/2012 03:16 AM, Dan Carpenter wrote: We recently changed the locking in this function, but this return was missed. It needs an unlock and the IRQs need to be restored. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Thanks for catching this. Acked-by: Brian King brk

Re: linux-next: build failure after merge of the scsi tree

with all the fixes. Thanks, James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Brian King Power Linux I/O IBM Linux Technology Center

Re: linux-next: build failure after merge of the scsi tree

On 01/11/2013 10:05 AM, Greg KH wrote: On Fri, Jan 11, 2013 at 03:37:17PM +, James Bottomley wrote: On Fri, 2013-01-11 at 09:27 -0600, Brian King wrote: It looks like this was a due to the fact that the new patches added __devinit tags in the same merge window the __devinit tag itself

Re: [git patches] libata reset sequence update

Jeff Garzik wrote: This has been testing in -mm for a while, but I wanted to send it separated from the main libata update, since it has a chance of breakage. Most notably, a cumulative timeout (deadline) helps the code from diving into overly-long reset sequences. Please pull from

Re: PPC64 build breakage drivers/pci/hotplug/rpadlpar_sysfs.c

Mel Gorman wrote: On (16/05/07 09:30), Bob Picco didst pronounce: [EMAIL PROTECTED] /usr/src/linux-2.6.22-rc1-mm1/drivers/pci/hotplug/rpadlpar_sysfs.c:132: error: unknown field `subsys' specified in initializer /usr/src/linux-2.6.22-rc1-mm1/drivers/pci/hotplug/rpadlpar_sysfs.c:132:

Re: [PATCH] [scsi] enclosure: remove all possible sysfs entries before add device

. Wendy, does this patch fix the issue you are seeing as well or is this a different issue? Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH RFC 36/77] ipr: Enable MSI-X when IPR_USE_MSIX type is set, not IPR_USE_MSI

on the specific adapter. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range()

patches from Alexander and rebase on top of the latest patches you've sent upstream? Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] powerpc/pseries: Force 32 bit MSIs when tearing down

interface is not * present -- 1.7.7.6 -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2 2/2] rsxx: Moving pci_map_page to prevent overflow

].command = dma-cmd; hw_cmd_buf[ctrl-cmd.idx].tag = tag; -Brian -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 1/2] rsxx: Handling failed pci_map_page on PowerPC and double free.

rsxx_dma_cancel(struct rsxx_dma_ctrl *ctrl); void rsxx_dma_cleanup(void); void rsxx_dma_queue_reset(struct rsxx_cardinfo *card); -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v3 2/2] rsxx: Moving pci_map_page to prevent overflow.

be mapped at one time now is: 255 dmas X 4 dma channels X 4096 Bytes. Signed-off-by: Philip J Kelleher pjk1...@linux.vnet.ibm.com Reviewed-by: Brian King brk...@linux.vnet.ibm.com -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 1/2] rsxx: Handling failed pci_map_page on PowerPC and double free.

dmas, that is also fixed here. Signed-off-by: Philip J Kelleher pjk1...@linux.vnet.ibm.com Reviewed-by: Brian King brk...@linux.vnet.ibm.com -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v2 1/2] ipr: Get rid of superfluous call to pci_disable_msi/msix()

Acked-by: Brian King brk...@linux.vnet.ibm.com -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v2 2/2] ipr: Use pci_enable_msi_range() and pci_enable_msix_range()

Acked-by: Brian King brk...@linux.vnet.ibm.com -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range()

/msg71644.html Do you want me to rediff your patches on top of this one, or do you want to keep the entire MSI series together and do the rediff? Otherwise the patches seem fine. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line

Re: [PATCH] Update Maintainers for IBM Power 842, vscsi, and vfc drivers

-by: Brian King brk...@linux.vnet.ibm.com -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH] ibmvfc: fix little endian issues

On 06/26/2014 07:03 PM, Tyrel Datwyler wrote: Added big endian annotations to relevant data structure fields, and necessary byte swappings to support little endian builds. Acked-by: Brian King brk...@linux.vnet.ibm.com Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: linux-next: build failure after merge of the scsi tree

cycles before pushing (assuming merge window opens on Sunday) just in case more things show up. Hi James, Anything preventing this patch set from getting picked up? Do you need a resend? http://marc.info/?l=linux-scsim=140657929221696w=2 Thanks, Brian -- Brian King Power Linux I/O IBM Linux

Re: [PATCH] ibmveth: enable interrupts after napi_complete()

Yongbae, Thank you for submitting the patch for this issue. Issues with this device driver should be reported via net...@vger.kernel.org and also please copy the maintainer of ibmveth, Thomas Falcon tlfal...@linux.vnet.ibm.com. Thanks! Brian -- Brian King Power Linux I/O IBM Linux Technology

Re: [PATCH v2 3/3] ibmvscsi: Allow to configure maximum LUN

doing is translating the incoming bus / id / LUN to a LUN in the logical unit addressing format, as defined in 4.6.9 of SAM-4. -- |Bit | 7 | 6 | 5 | 4 | 3 | 2 | 1 | 0 | ------ | n | (10b) | Target | -

Re: [PATCH v2 3/3] ibmvscsi: Allow to configure maximum LUN

On 11/05/2015 02:26 AM, Laurent Vivier wrote: > > > On 05/11/2015 00:06, Brian King wrote: >> On 11/04/2015 07:02 AM, Hannes Reinecke wrote: >>> On 11/04/2015 12:46 PM, Laurent Vivier wrote: >>>> >>>> >>>> On 04/11/2015 12:16, Hannes

Re: [PATCH v2 3/3] ibmvscsi: Allow to configure maximum LUN

On 11/05/2015 02:51 AM, Hannes Reinecke wrote: > On 11/05/2015 12:06 AM, Brian King wrote: >> On 11/04/2015 07:02 AM, Hannes Reinecke wrote: >>> On 11/04/2015 12:46 PM, Laurent Vivier wrote: >>>> >>>> >>>> On 04/11/2015 12:16, Hannes Reinec

Re: [PATCH] ibmvsci: make parameters max_id and max_channel read-only

On 09/09/2015 10:21 AM, Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> -- Brian King Powe

Re: [PATCH 3/3] ibmvsci: Allow to configure maximum LUN

Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kern

Re: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.

Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kern

Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only

Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

[PATCH] ipr: Fix sync scsi scan

> >> git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc >> >> The short changelog is: >> >> Brian King (1): >> ipr: Wait to do async scan until scsi host is initialized > > This commit seems to be causing a ~10 minute pause during b

Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors

send out? Acked-by: Brian King <brk...@linux.vnet.ibm.com> Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

On 11/06/2016 03:22 PM, Jonathan Maxwell wrote: > On Thu, Nov 3, 2016 at 8:40 AM, Brian King <brk...@linux.vnet.ibm.com> wrote: >> On 10/27/2016 10:26 AM, Eric Dumazet wrote: >>> On Wed, 2016-10-26 at 11:09 +1100, Jon Maxwell wrote: >>>> We recently encounter

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

> > You force gso_size to device mtu, regardless of real MSS used by the TCP > sender. > > Don't you have the MSS provided in RX descriptor, instead of guessing > the value ? Eric, We are currently pursuing making changes to the Power Virtual I/O Server to provide the MSS to the ibmveth driver. However, this will take time to go through test and ultimately get released. Although imperfect, this patch does help a real customer hitting this issue right now. Would you object to this patch getting merged as is, with the understanding that when we get the change in the Virtual I/O Server released, we will revert this interim change and apply the new method? Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

the VIOS (AIX based) is actually being done by software in the VIOS. What they may be able to do is when performing this aggregation, they could look at the packet lengths of all the packets being aggregated and take the largest packet size within the aggregation unit, minus the header length a

Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI

le we set that flag properly when deciding initially whether to use LSIs or MSIs, we fail to set it if we first chose MSIs, the test fails, then fallback to LSIs. Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> Signed-off-by: Brian King <brk...@linux.vnet.ibm.com> ---

Re: [PATCH V2] scsi: mpt3sas: remove redundant wmb

writel() function on arm/arm64 >>> arhictectures have an embedded wmb() call inside. > > [Sreekanth] Whether same thing applicable for SPARC & POWER > architectures. If yes then we are fine with this patch changes. This is also true for Power. Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> -Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc

t supported by ipr, it should return with an illegal request. When I'm hung at this point, there is nothing outstanding to the adapter / driver. I'll continue debugging... -Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

On 07/28/2017 10:17 AM, Brian J King wrote: > Jens Axboe wrote on 07/28/2017 09:25:48 AM: > >> Can you try the below fix? Should be more palatable than the previous >> one. Brian, maybe you can take a look at the IRQ issue mentioned above? Michael, Does this address the issue

[PATCH] ipr: Fix scsi-mq lockdep issue

/0x4a0 [c01fffe97f90] [c002da50] call_do_irq+0x14/0x24 [c007fad93aa0] [c0017e8c] do_IRQ+0x9c/0x140 [c007fad93af0] [c0008b98] hardware_interrupt_common+0x138/0x140 Reported-by: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Brian King <brk...@linux.vne

Re: WARNING: CPU: 15 PID: 0 at block/blk-mq.c:1111 __blk_mq_run_hw_queue+0x1d8/0x1f0

37f90] [c003ea20] call_do_irq+0x14/0x24 >> [c007f84e3a70] [c001dae0] do_IRQ+0xd0/0x190 >> [c0000007f84e3ac0] [c0008c58] hardware_interrupt_common >> +0x158/0x160 > > Hello Brian, > > In the MAINTAINERS file I found the following: > > I

Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc

On 08/17/2017 10:52 AM, Bart Van Assche wrote: > On Wed, 2017-08-16 at 18:18 -0500, Brian King wrote: >> On 08/16/2017 12:21 PM, Bart Van Assche wrote: >>> On Wed, 2017-08-16 at 22:30 +0530, Abdul Haleem wrote: >>>> As of next-20170809, linux-next on powerpc boot hung

[PATCH] ipr: Set no_report_opcodes for RAID arrays

Since ipr RAID arrays do not support the MAINTENANCE_IN / MI_REPORT_SUPPORTED_OPERATION_CODES, set no_report_opcodes to prevent it from being sent. Signed-off-by: Brian King <brk...@linux.vnet.ibm.com> --- Index: linux-2.6.git/drivers/scsi

Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc

On 08/18/2017 04:41 PM, Bart Van Assche wrote: > On Fri, 2017-08-18 at 16:04 -0500, Brian King wrote: >> I think I have an understanding what is going on and why Bart's patch is >> causing problems for ipr. >> I can work around the boot hang in ipr, but ultimately I think

Re: WARNING: CPU: 15 PID: 0 at block/blk-mq.c:1111 __blk_mq_run_hw_queue+0x1d8/0x1f0

On 08/17/2017 10:32 AM, Bart Van Assche wrote: > On Wed, 2017-08-16 at 15:10 -0500, Brian King wrote: >> On 08/16/2017 01:15 PM, Bart Van Assche wrote: >>> On Wed, 2017-08-16 at 23:37 +0530, Abdul Haleem wrote: >>>> Linux-next booted with

Re: [GIT PULL] SCSI fixes for 4.13-rc6

ers when issuing i/o to already configured devices. Therefore, we cannot simply move the initialization of jiffies_at_alloc to scsi_init_rq. I've been working on moving the retry counter and jiffies_at_alloc into struct scsi_request, as that doesn't get reinitialized. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 1/2] scsi: Move scsi_cmd->jiffies_at_alloc initialization to allocation time

Scratch this one... Version 2 on the way with the corresponding changes in scsi_init_request... -Brian -- Brian King Power Linux I/O IBM Linux Technology Center

[PATCH 2/2] scsi: Preserve retry counter through scsi_prep_fn

Save / restore the retry counter in scsi_cmd in scsi_init_command. This allows us to go back through scsi_init_command for retries and not forget we are doing a retry. Signed-off-by: Brian King <brk...@linux.vnet.ibm.com> --- Index: linux-2.6.git/drivers/scsi/scsi

[PATCH 1/2] scsi: Move scsi_cmd->jiffies_at_alloc initialization to allocation time

art Van Assche <bart.vanass...@wdc.com> Signed-off-by: Brian King <brk...@linux.vnet.ibm.com> --- Index: linux-2.6.git/drivers/scsi/scsi_lib.c === --- linux-2.6.git.orig/drivers/scsi/scsi_lib.c +++ linux-2.6.git/drivers/

[PATCHv2 1/2] scsi: Move scsi_cmd->jiffies_at_alloc initialization to allocation time

break the overall retry timer logic in scsi_softirq_done. Suggested-by: Bart Van Assche <bart.vanass...@wdc.com> Signed-off-by: Brian King <brk...@linux.vnet.ibm.com> --- Index: linux-2.6.git/drivers/scsi/scsi_lib.c === ---

[PATCH 0/2] Allow scsi_prep_fn to occur for retried commands

the retry counter in scsi_init_command which lets us go through scsi_init_command for retries and not forget why we were there. These patches have only been boot tested on my Power machine with ipr to ensure they fix the issue I was seeing. -Brian -- Brian King Power Linux I/O IBM Linux Technology

Re: [PATCH] scsi: ipr: fix incorrect indentation of assignment statement

id = > - (entries_each_hrrq - 1); > + ioa_cfg->hrrq[i].max_cmd_id = > + (entries_each_hrrq - 1); > } else { > entries_each_hrrq =

Re: pci: Arch hook to determine config space size

Grant Grundler wrote: On Mon, Jan 31, 2005 at 01:40:04PM -0600, Brian King wrote: CC'ing the linux-pci mailing list... thanks... This patch adds an arch hook so that individual archs can indicate if the underlying system supports expanded config space accesses or not. @@ -653,6 +653,8 @@ static

Re: pci: Arch hook to determine config space size

agree. Also, when sending PCI related patches, please cc the linux-pci mailing list. How about this? -- Brian King eServer Storage I/O IBM Linux Technology Center When working with a PCI-X Mode 2 adapter on a PCI-X Mode 1 PPC64 system, the current code used to determine the config space size

Re: pci: Arch hook to determine config space size

Brian King wrote: Greg KH wrote: On Fri, Jan 28, 2005 at 06:52:34PM +, Christoph Hellwig wrote: +int __attribute__ ((weak)) pcibios_exp_cfg_space(struct pci_dev *dev) { return 1; } - prototypes belong to headers - weak linkage is the perfect way for total obsfucation please make

Re: pci: Arch hook to determine config space size

return PCIBIOS_BAD_REGISTER_NUMBER; is checked for in drivers/pci/access.c I can submit a separate patch to clean that up. -- Brian King eServer Storage I/O IBM Linux Technology Center When working with a PCI-X Mode 2 adapter on a PCI-X Mode 1 PPC64 system, the current code used to determine the conf

Re: pci: Arch hook to determine config space size

Arnd Bergmann wrote: On Maandag 31 Januar 2005 22:35, Brian King wrote: Matthew Wilcox wrote: Basically, ppc64's config ops are broken and need to check the offset being read. Here's i386: static int pci_conf1_write (int seg, int bus, int devfn, int reg, int len, u32 v alue) { unsigned

Re: pci: Arch hook to determine config space size

Benjamin Herrenschmidt wrote: On Mon, 2005-01-31 at 16:43 -0600, Brian King wrote: diff -puN include/asm-ppc64/prom.h~ppc64_pcix_mode2_cfg include/asm-ppc64/prom.h --- linux-2.6.11-rc2-bk9/include/asm-ppc64/prom.h~ppc64_pcix_mode2_cfg 2005-01-31 14:32:01.0 -0600 +++ linux-2.6.11-rc2-bk9

Re: [PATCH 1/1] PCI: Dynids - passing driver data

ay. My other option is to somehow change the driver to cope with having no driver data, but that will result in more driver code and will ultimately be less flexible in the new chipsets that can be added using dynids. -Brian -- Brian King eServer Storage I/O IBM Linux Technology Center - To uns

Re: [PATCH 1/1] PCI: Dynids - passing driver data

could just define the operation as cloning of an entry for another device ID, including its driver_data. Possibly. That would potentially require a lot of parameters to userspace. We would really need to duplicate all the currently existing sysfs parms to accomplish this. -- Brian King eServer Stora

Re: [PATCH 1/1] PCI: Dynids - passing driver data

ay can easily allow it to be passed in and do some simple range checking on it to verify it is a valid value before indexing into the array. -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH 3/13]: PCI Err: IPR scsi device driver recovery

ig accesses all fail? Should the driver attempt to talk to the pci adapter at all, or should it simply clean up after it? -- Brian King eServer Storage I/O IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: How to add/drop SCSI drives from within the driver?

d not get it working. Try [EMAIL PROTECTED] list for help. -- Patrick Mansfield - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- Brian King eServer St

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

Alan Cox wrote: On Maw, 2005-01-18 at 15:14, Brian King wrote: Alan - are you satisfied with the most recent patch, or would you prefer the patch not returning failure return codes and just bit bucketing writes and returning all ff's on reads? Either way works for me. Which was the last one

  1   2   3   >