suming that:
table->id[mid].temp < temp
I believe that's the case due to the round-down nature of the
mid = (low + high) / 2
computation, but it's still a bit hard to reason about your binary
search loop.
Anyway, I think this is correct, so if you improve the commit messag
On Tue, Nov 22, 2016 at 08:34:48PM +0800, Caesar Wang wrote:
> In some cases, some sensors didn't need the trip points, the
> set_trips will return {-INT_MAX, INT_MAX} to trigger thermal alarm.
>
> Signed-off-by: Caesar Wang
> ---
>
> drivers/thermal/rockchip_thermal.c | 13 +
> 1 f
On Tue, Nov 22, 2016 at 08:34:46PM +0800, Caesar Wang wrote:
> The temp_to_code function will return 0 when we set the trip points value
> or valid temperature.
I'm not quite sure what you mean by "when we set the trip points value
or valid temperature." Do you mean "when we set the trip point's v
On Fri, Oct 28, 2016 at 11:51:47AM -0700, Joe Perches wrote:
> I'd suggest as well fixing all the dev_ uses
> to be a consistent form: (this also fixes the typo)
> and a few other bits
>
> o Coalesce formats
> o Realign arguments
> o Add missing newlines
Yeah, Colin missed this on the line he was
On Fri, Oct 28, 2016 at 07:25:59PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King
> ---
> drivers/mtd/mtdswap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/mtdswa
On Sun, Nov 20, 2016 at 04:09:30PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki
>
> After parsing TRX we should skip to the first block placed behind it.
> Our code was working only with TRX with length not aligned to the
> blocksize. In other cases (length aligned) it was missing the block
On Wed, Nov 16, 2016 at 10:50:16PM +, Luis Henriques wrote:
> This patch was triggered by the following Coccinelle error:
>
> ./drivers/mtd/maps/sc520cdp.c:246:3-9: \
> ERROR: missing iounmap; ioremap on line 242 \
> and execution via conditional on line 244
>
> Signed-off-by: Lui
are ordered in terms of their dependencies, but ideally, all 5
> would need to be applied for this to work as intended.
Other than some small comments, the MTD parts look fine to me. For
patches 1, 3, 4, and 5 with my comments fixed:
Acked-by: Brian Norris
For the UBI part, I wasn&#x
On Mon, Nov 21, 2016 at 01:51:38PM -0600, Zach Brown wrote:
> Implement the new mtd function 'max_bad_blocks'. Using the chip's
> max_bb_per_die and blocks_per_die fields to determine the maximum bad
> blocks to reserve for an MTD.
>
> Signed-off-by: Jeff Westfahl
> Signed-off-by: Zach Brown
> A
On Mon, Nov 21, 2016 at 01:51:36PM -0600, Zach Brown wrote:
> From: Jeff Westfahl
>
> Use the MTD function 'max_bad_blocks' to compute the UBI bad_peb_limit,
> if the function is implemented for an MTD and doesn't return an error.
>
> Signed-off-by: Jeff Westfahl
> Signed-off-by: Zach Brown
>
A few small comments.
On Mon, Nov 21, 2016 at 01:51:35PM -0600, Zach Brown wrote:
> From: Jeff Westfahl
>
> If implemented, 'max_bad_blocks' returns the maximum number of bad
> blocks to reserve for an MTD. An implementation for NAND is coming soon.
>
> Signed-off-by: Jeff Westfahl
> Signed-of
On Mon, Nov 21, 2016 at 01:51:36PM -0600, Zach Brown wrote:
> From: Jeff Westfahl
>
> Use the MTD function 'max_bad_blocks' to compute the UBI bad_peb_limit,
> if the function is implemented for an MTD and doesn't return an error.
I'm not exactly a UBI expert here, but it seems reasonable that w
On Tue, Nov 22, 2016 at 10:33:27AM +0800, Caesar Wang wrote:
> 在 2016年11月22日 10:15, Brian Norris 写道:
> >On Tue, Nov 22, 2016 at 09:51:23AM +0800, Caesar Wang wrote:
> >>CHECK: Alignment should match open parenthesis
> >>#428: FILE: drivers/thermal/rockchip_thermal
On Tue, Nov 22, 2016 at 09:51:23AM +0800, Caesar Wang wrote:
> CHECK: Alignment should match open parenthesis
> #428: FILE: drivers/thermal/rockchip_thermal.c:428:
> +pr_err("%s: invalid temperature, temp=%d error=%d\n",
> +__func__, temp, error);
>
> CHECK: Alignment should match open
Hi,
On Fri, Nov 18, 2016 at 07:41:59PM -0800, Eduardo Valentin wrote:
> On Fri, Nov 18, 2016 at 03:52:55PM -0800, Brian Norris wrote:
> > If using CONFIG_THERMAL_EMULATION, there's a corner case where we might
> > get an error from the zone's get_temp() callback, but
This driver passes struct chip_tsadc_table by value throughout; this is
inefficient, and AFAICT, there is no reason for it. Let's pass pointers
instead.
Signed-off-by: Brian Norris
---
drivers/thermal/rockchip_thermal.c | 80 +++---
1 file changed, 40 inser
fix the grammar too.
Signed-off-by: Brian Norris
---
Note: it'd probably be even nicer to know which sensor this was, but we've
kinda abstracted that one away by this point...
drivers/thermal/rockchip_thermal.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/driv
If using CONFIG_THERMAL_EMULATION, there's a corner case where we might
get an error from the zone's get_temp() callback, but we'll ignore that
and keep using its value. Let's just error out properly instead.
Signed-off-by: Brian Norris
---
drivers/thermal/thermal_core.c | 3
Hi,
I've been poking around KGDB, and I noticed that the KDB 'ftdump'
command (to dump ftrace logs) produces warnings like this:
(gdb) monitor ftdump
Dumping ftrace buffer:
BUG: sleeping function called from invalid context at mm/slab.h:359
in_atomic(): 1, irqs_disabled(): 128, pid: 116, name: ir
Per the original author, the proposed document was never deemed
necessary, and the important bits got merged into completion.txt. Let's
just stop confusing readers by pointing at a nonexistent doc.
Signed-off-by: Brian Norris
---
On Wed, Oct 26, 2016 at 10:11:26AM +, Nicholas Mc Guire
On Fri, Nov 11, 2016 at 08:47:54AM -0800, Tony Lindgren wrote:
> But sounds like the threaded IRQ is not your concern and you mostly
Right, threaded is OK for this; it's not performance critical. It just
highlighted the fact that its completion is not synchronized with
anything.
> care about gett
On Thu, Nov 10, 2016 at 09:57:20PM +0100, Pavel Machek wrote:
> On Thu 2016-11-10 10:07:07, Brian Norris wrote:
> > It's important that user space can figure out what device woke the
> > system from suspend -- e.g., for debugging, or for implementing
> > conditional wake
On Thu, Nov 10, 2016 at 01:49:11PM -0700, Tony Lindgren wrote:
> * Brian Norris [161110 11:49]:
> > On Thu, Nov 10, 2016 at 10:13:55AM -0800, Dmitry Torokhov wrote:
> > > On Thu, Nov 10, 2016 at 10:07 AM, Brian Norris
> > > wrote:
> > > > It's i
On Thu, Nov 10, 2016 at 10:13:55AM -0800, Dmitry Torokhov wrote:
> On Thu, Nov 10, 2016 at 10:07 AM, Brian Norris
> wrote:
> > It's important that user space can figure out what device woke the
> > system from suspend -- e.g., for debugging, or for implementing
> &
nize with these events in their resume path (hence, disable_irq()
instead of disable_irq_nosync()).
Signed-off-by: Brian Norris
---
drivers/base/power/wakeirq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c
ind
Drivers might include this header without .
Signed-off-by: Brian Norris
---
include/linux/pm_wakeirq.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/pm_wakeirq.h b/include/linux/pm_wakeirq.h
index cd5b62db9084..49c2220fb245 100644
--- a/include/linux/pm_wakeirq.h
+++ b
On Thu, Nov 10, 2016 at 02:53:20AM +0100, Rafael J. Wysocki wrote:
> On Thu, Nov 10, 2016 at 2:21 AM, Brian Norris
> wrote:
> > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> > index c58563581345..57a8ca4bc8ab 100644
> > --- a/drivers/base/power/
chronous threads for suspend_noirq")
Reported-by: Jeffy Chen
Signed-off-by: Brian Norris
---
v2: s/early/late/ in commit message
v3:
* drop patch 1, as the callback-printing is unrelated, semi-controversial, and
might break existing (but poor -- c'mon, since when do tools get to rely on
ker
On Thu, Nov 10, 2016 at 01:08:56AM +0100, Rafael J. Wysocki wrote:
> On Wed, Nov 2, 2016 at 6:07 AM, Brian Norris wrote:
> > I can test this and send it in proper form if that looks preferable.
>
> It does to me as per the discussion at the LPC.
>
> Are you still going t
s allocated in function
> + * mwifiex_fill_new_bss_desc(). Free it now.
> + */
> + kfree(bss_desc->beacon_buf);
For a bit, I thought this was possibly a sort of double-free, since
mwifiex_fill_new_bss_desc() might actually fail to allocate
->beacon_buf, but kfree(NULL) is safe, so:
Reviewed-by: Brian Norris
> kfree(bss_desc);
> return 0;
> }
> --
> 2.6.6
>
On Thu, Nov 10, 2016 at 12:20:53AM +0200, Kalle Valo wrote:
> Brian Norris writes:
>
> > SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length
> > when we print them out.
> >
> > This can be easily noticed by connecting to a network with a
9abcdef ' bssid
xx:xx:xx:xx:xx:xx
Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex
driver")
Signed-off-by: Brian Norris
Cc:
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/driver
turn 0 if (!(-e "$root/scripts/get_maintainer.pl"));
> + return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
>
> my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol
> --nogit --nogit-fallback -f $filename 2>&1`;
>
> _
>
FWIW:
Reviewed-by: Brian Norris
Hi,
On Mon, Aug 15, 2016 at 02:21:28PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki
>
> BCM53573 is a new series of Broadcom's SoCs. It's based on ARM and uses
> this old ChipCommon-based flash access. Early tests resulted in flash
> corruptions that were tracked down to using cached MMIO f
---
Arnd Bergmann (1):
mtd: mtk: avoid warning in mtk_ecc_encode
Boris Brezillon (2):
MAINTAINERS: add more people to the MTD maintainer team
mtd: nand: Fix data interface configuration logic
Brian Norris (1):
Merge tag 'nand
On Tue, Nov 01, 2016 at 05:27:05AM +0100, Rafael J. Wysocki wrote:
> Any reason why you need to rely on the initcall_debug stuff instead of using
> the tracepoints we have there (for exactly the reason why you are pushing this
> patch)?
This was mentioned on the last submission. I'll paste Doug's
+ more genpd folks
On Wed, Nov 02, 2016 at 04:51:08AM +0100, Rafael J. Wysocki wrote:
> On Tuesday, November 01, 2016 12:04:28 AM Dmitry Torokhov wrote:
> > On Mon, Oct 31, 2016 at 10:25 PM, Rafael J. Wysocki
> > wrote:
> > > On Thursday, October 27, 2016 09:05:
Hi Rafael,
On Tue, Nov 01, 2016 at 05:25:39AM +0100, Rafael J. Wysocki wrote:
> On Thursday, October 27, 2016 09:05:34 AM Brian Norris wrote:
> > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> > index c58563581345..eaf6b53463a5 100644
> > --- a/driv
les.
Fixes: 85b0ee18bbf8 ("checkpatch: see if modified files are marked obsolete in
MAINTAINERS")
Signed-off-by: Brian Norris
---
v2: change condition to check for $root, not $tree
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/checkpatch.pl b/scrip
On Fri, Oct 28, 2016 at 07:26:31PM -0700, Brian Norris wrote:
> From: Brian Norris
>
> If checkpatch.pl gets copied out of the tree, --no-tree shouldn't start
> complaining:
>
> Use of uninitialized value $root in concatenation (.) or string at
> /path/to/checkpat
From: Brian Norris
If checkpatch.pl gets copied out of the tree, --no-tree shouldn't start
complaining:
Use of uninitialized value $root in concatenation (.) or string at
/path/to/checkpatch.pl line 764.
Let's just give the safe answer instead -- don't warn about "obs
model, and so it should be unnecessary for a
child device to grab a refcount on its parent device.
Signed-off-by: Brian Norris
---
This reflects my understanding (and testing), as well as the majority of usage
-- there are *very* few interface drivers that actually call usb_get_dev(). If
I&#
s planning to do right now for 4.9-rc) I don't see a problem with
that either.
> If you have other ideas, or would like to proceed differently, don't
> hesitate propose them.
Good luck, and happy MTD hacking :)
Brian
> Thanks,
>
> Boris
> ---
> MAINTAINERS | 4 ++++
> 1 fil
Hi,
On Fri, Oct 21, 2016 at 11:28:00PM +0530, Jagan Teki wrote:
> On Thu, Oct 20, 2016 at 7:12 PM, Marek Vasut wrote:
> > On 10/19/2016 05:34 PM, Cyrille Pitchen wrote:
> >> I would like to volunteer as a maintainer for the SPI NOR part of the MTD
> >> subsystem.
Thanks! I'll be happy to have th
l get called. (Or similarly, fake a wakeup
event at the right (or is it wrong?) time.)
Fixes: de377b397272 ("PM / sleep: Asynchronous threads for suspend_late")
Fixes: 28b6fd6e3779 ("PM / sleep: Asynchronous threads for suspend_noirq")
Reported-by: Jeffy Chen
Signed-off-by:
On Thu, Oct 27, 2016 at 05:34:06PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 19, 2016 at 05:46:11PM -0700, Brian Norris wrote:
> > Ugh, as I hope the patch context makes clear, the subject should be
> >
> > s/early/late/
> >
> > as should the body of the
On Wed, Oct 26, 2016 at 04:35:54PM -0700, Dmitry Torokhov wrote:
> On Wed, Oct 26, 2016 at 04:29:20PM -0700, Brian Norris wrote:
> > diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c
> > b/drivers/net/wireless/marvell/mwifiex/sdio.c
> > index 8718950004f3..f04cf5a5
e able to clear
that one for us.
Signed-off-by: Brian Norris
---
drivers/net/wireless/marvell/mwifiex/pcie.c | 5 +
drivers/net/wireless/marvell/mwifiex/sdio.c | 16 ++--
drivers/net/wireless/marvell/mwifiex/usb.c | 7 +--
3 files changed, 12 insertions(+), 16 deletions(-)
d
Hi,
It looks like Nicholas submitted this doc a while back as patch 2/2:
"[PATCH 2/2] doc: detailed documentation for completion"
http://lkml.iu.edu/hypermail/linux/kernel/1412.2/03676.html
where patch 1/2 got merged as this:
202799be447b doc: brief user documentation for completion
References
Hi Michal,
On Fri, Oct 21, 2016 at 08:46:02AM +0200, Michal Hocko wrote:
> On Thu 20-10-16 23:39:39, Brian Norris wrote:
> > I'm not sure the best way to report this, but the Chrome OS test
> > infrastructure noticed some problems when testing the following patch
> > bac
(Preface: this wasn't a clean backport, I'm a bit under the weather, and
it's getting late here. So forgive me if my head's not on straight.)
Hi,
I'm not sure the best way to report this, but the Chrome OS test
infrastructure noticed some problems when testing the following patch
backported to ou
Ugh, as I hope the patch context makes clear, the subject should be
s/early/late/
as should the body of the commit message.
On Wed, Oct 19, 2016 at 05:26:10PM -0700, Brian Norris wrote:
> Consider two devices, A and B, where B is a child of A, and B utilizes
> asynchronous suspend (it do
still get called. (Or similarly, fake a wakeup
event at the right (or is it wrong?) time.)
Fixes: de377b397272 ("PM / sleep: Asynchronous threads for suspend_late")
Fixes: 28b6fd6e3779 ("PM / sleep: Asynchronous threads for suspend_noirq")
Reported-by: Jeffy Chen
Signed-off-by:
15793, parent: mmc2:0001:1, cb: wiphy_resume [cfg80211]
call phy0+ returned 0 after 12 usecs
calling rfkill1+ @ 15793, parent: phy0, cb: rfkill_resume
call rfkill1+ returned 0 after 1 usecs
Signed-off-by: Douglas Anderson
Acked-by: Pavel Machek
Signed-off-by: Brian Norris
---
This is a resend of
On Tue, Oct 18, 2016 at 06:24:41PM -0700, Stephen Boyd wrote:
> Just curious, do we enter this state during cpuidle as well? Or
> is it only across suspend that the clock stops working?
I believe we do not on either rk3288 or rk3399. We'd have to be powering
off almost the entire system before we'
ld get this right.
Fixes: ca1989084054 ("PCI: rockchip: Fix wrong transmitted FTS count")
Signed-off-by: Brian Norris
---
drivers/pci/host/pcie-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
inde
;>> I've already helped by reviewing patches from other contributors on the
> >>>> mailing list, and would like to help getting those patches integrated by
> >>>> volunteering as a maintainer for this specific area.
Agreed.
> >>>> Boris Bre
/timer.c | 20 ++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
I've reviewed the logic here to the best of my ability, and it looks
good to me now. I'll admit that I'm not really a timekeeping or
scheduler expert, but FWIW:
Reviewed-by: Brian Norris
>
Hi Doug,
On Mon, Oct 10, 2016 at 11:47:57AM -0700, Doug Anderson wrote:
> diff --git a/kernel/time/timer.c b/kernel/time/timer.c
> index 32bf6f75a8fe..ab03c7e403a4 100644
> --- a/kernel/time/timer.c
> +++ b/kernel/time/timer.c
> @@ -1898,12 +1898,29 @@ EXPORT_SYMBOL(msleep_interruptible);
>
> s
I realize I didn't comment on the latest copy of this patch, so copying
my questions here:
On Wed, Sep 21, 2016 at 11:45:12AM +0200, Daniel Walter wrote:
> From: Richard Weinberger
>
> del_mtd_device() is allowed to fail.
> i.e. when the MTD is busy.
> Unregister the reboot notifier only when we
maximize the ECC strength
mtd: nand: Support maximizing ECC when using software BCH
mtd: nand: sunxi: Support ECC maximization
mtd: nand: Fix nand_command_lp() for 8bits opcodes
mtd: nand: mxc: Test CONFIG_OF instead of CONFIG_OF_MTD
mtd: Kill the OF_MTD Kconfig option
Br
the conversion between absolute
> offsets and wunits, and query the number of pairing groups.
>
> Signed-off-by: Boris Brezillon
> Reviewed-by: Brian Norris
> ---
> Hi Brian,
>
> Here is a new version addressing your comments.
> If you're okay with this version, y
om the
24MHz clock to the 32KHz clock in low-power suspend, so let's mark it as
such.
Signed-off-by: Brian Norris
---
v2: new in v2
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
b/arch/arm64/boot/
ched from their high-power clock to the lower-power clock used in
system suspend. Support this quirk by adding a new device tree property.
Signed-off-by: Brian Norris
---
v2:
* add new device tree property, instead of re-using the "always-on"
property (which has different meaning)
Hi Marc,
On Thu, Sep 29, 2016 at 05:08:47PM +0100, Marc Zyngier wrote:
> On Tue, 27 Sep 2016 18:23:11 -0700
> Brian Norris wrote:
> > On Tue, Sep 20, 2016 at 08:47:07AM +0100, Marc Zyngier wrote:
> >
> > rk3288 (ARMv7 system widely used for our Chromebooks) has the sa
Hi Boris,
On Sun, Sep 25, 2016 at 08:53:26PM +0200, Boris Brezillon wrote:
> Hi Brian,
>
> Here is my PR for 4.9. Let me know if you see any problem.
> Also, please let us know ahead of time if you can't take this PR (I know you
> are busy lately, and I guess I could send this PR directly to Linu
On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote:
> On Wed, 21 Sep 2016 11:43:56 +0200
> Daniel Walter wrote:
>
> > From: Richard Weinberger
> >
> > If the master device has callbacks for _get/put_device()
> > and this MTD has slaves a get_mtd_device() call on paritions
> > will
Hi Linus,
My apologies for sending this so late. I've been fairly absent as a
maintainer this cycle, but I did queue these up weeks ago. In the
meantime, Richard was able to handle some other fixes (thanks!) but
didn't pick these up.
On the bright side, these are very simple changes that should c
Hi Richard,
On Fri, Sep 23, 2016 at 02:05:20PM +0200, Richard Weinberger wrote:
> This pull request contains fixes for bugs which got introduced in -rc1.
> You may wonder why I'm sending this pull request. Usually Brian takes NAND
> patches
> from Boris, but since Brian is very busy these days wi
Hi Marc,
Thanks again for the help. I was checking with Rockchip on the details.
On Tue, Sep 20, 2016 at 08:47:07AM +0100, Marc Zyngier wrote:
> The counter is allowed to be clocked at a different rate, as long as it
> is incremented by the frequency ratio on each tick of the new frequency.
> In
Hi Shawn,
On Fri, Sep 23, 2016 at 08:27:35AM +0800, Shawn Lin wrote:
> 在 2016/9/23 1:31, Brian Norris 写道:
> >rk3399 supports PCIe 2.x link speeds marginally at best, and on some
> >boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500
> >ms waiting fo
rk3399 supports PCIe 2.x link speeds marginally at best, and on some
boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500
ms waiting for training that will never happen, let's support a device
tree quirk flag to disable generation 2 speeds entirely.
Signed-off-by: Br
tform_device
> *pdev)
> goto err_vpcie;
>
> /* Get the I/O and memory ranges from DT */
> + io_size = 0;
> resource_list_for_each_entry(win, &res) {
> switch (resource_type(win->res)) {
> case IORESOURCE_IO:
I feel like we've fixed this one before, but then it's been refactored
many times along the way...
Reviewed-by: Brian Norris
On Fri, Sep 16, 2016 at 09:06:55AM +0100, Marc Zyngier wrote:
> Hi Brian,
Hi Marc,
Thanks for the quick response.
> On 16/09/16 06:49, Brian Norris wrote:
> > Since commit 4fbcdc813fb9 ("clocksource: arm_arch_timer: Use clocksource
> > for suspend timekeeping"), this
OP, since if the timer doesn't keep context for CPU sleep,
it likely doesn't for system sleep either.
Signed-off-by: Brian Norris
---
drivers/clocksource/arm_arch_timer.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/arm_arch_timer.c
b/dr
On Wed, Sep 14, 2016 at 03:55:05PM +0800, Brian Norris wrote:
> The default behavior of regulator_get() is to provide a dummy regulator
> if none is found. So the pointer is never NULL, and it won't break
> devices without a regulator. If you don't want a dummy regula
Hi Benjamin,
On Wed, Sep 14, 2016 at 09:36:03AM +0200, Benjamin Tissoires wrote:
> On Sep 05 2016 or thereabouts, Caesar Wang wrote:
> > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> > index b3ec4f2..07cc7aa 100644
> > --- a/drivers/hid/i2c-hid/i2c-hid.c
> > +++ b/dr
On Mon, Aug 29, 2016 at 10:45:41PM +0200, Boris Brezillon wrote:
> On Mon, 29 Aug 2016 13:38:47 -0700
> Brian Norris wrote:
>
> > On Mon, Aug 29, 2016 at 11:59:30AM +0200, Boris Brezillon wrote:
> > > Brian, can you take this patch directly in your tree. If that's no
On Thu, Sep 08, 2016 at 10:38:11AM -0700, Chris Zhong wrote:
> Add pm_runtime_disable in err case to make the pm_runtime_enable/disable
> is invoked balanced.
>
> Signed-off-by: Chris Zhong
Makes sense.
Reviewed-by: Brian Norris
Colin Ian King
> Good find. Strange that got through 0-day without a warning...
>
> Cc'd Brian as author of the fix this is fixing.
> Brian can you sanity check this patch as well.
Indeed, looks fine, and works fine:
Tested-by: Brian Norris
Reviewed-by: Brian Norris
Tha
'll rename it and put it
> in -next.
I'll append a patch that gets things building and working for me. With
that:
Tested-by: Brian Norris
I haven't examined all the changes in detail, but they mostly seem
reasonable.
> I'll also post the broken-out patches f
ris Brezillon wrote:
> On Thu, 4 Aug 2016 12:37:51 +0800
> Brian Norris wrote:
> > On Mon, Jun 20, 2016 at 03:50:16PM +0200, Boris Brezillon wrote:
>
> >
> > > + * (3 bits in a single cell). A pair should regroup all pages that are
> > > sharing
&g
On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote:
> In the interest of making progress, I made most of the changes Guenter
> suggested (thanks very much, Guenter!) and made some more of my own on
> top of those.
I'm not sure, but was this change your idea Bjorn?
commit 88cb3f59d73e26
On Tue, Aug 30, 2016 at 09:05:06AM +0200, Heiko Stuebner wrote:
> Am Dienstag, 30. August 2016, 08:59:31 schrieb Elaine Zhang:
> > On 08/30/2016 02:18 AM, Brian Norris wrote:
> > > On Mon, Aug 29, 2016 at 11:11:24AM -0700, Doug Anderson wrote:
> > >> --- a/arch/arm64
("PCI: rockchip: Add Rockchip PCIe controller support")
Signed-off-by: Brian Norris
Cc: Shawn Lin
---
Patched against git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
pci/host-rockchip
drivers/pci/host/pcie-rockchip.c | 7 ---
1 file changed, 4 insertions(+), 3 d
On Mon, Aug 29, 2016 at 11:59:30AM +0200, Boris Brezillon wrote:
> On Mon, 29 Aug 2016 07:45:49 +
> Karl Beldan wrote:
>
> > This fixes subpage writes when using 4-bit HW ECC.
> >
> > There has been numerous reports about ECC errors with devices using this
> > driver for a while. Also the 4
On Mon, Aug 15, 2016 at 05:22:00PM +0200, Boris Brezillon wrote:
> On Mon, 15 Aug 2016 10:47:39 +0300
> Roger Quadros wrote:
>
> > dma_request_chan() can fail returning an error pointer. In this case
> > prevent calling dma_release_channel() to prevent a ERR_PTR() dereference.
> >
> > As error p
think this makes sense and is a good idea. One alternative would be to
have the various children actually set a rate that they expect, but
several of them don't have a separate driver at all, and that would be
of dubious value anyway I think.
Reviewed-by: Brian Norris
> };
>
> cru: clock-controller@ff76 {
> --
> 2.8.0.rc3.226.g39d4020
>
Corrected a bouncing email address (sorry for the noise)
On Fri, Aug 26, 2016 at 03:11:36PM -0700, Brian Norris wrote:
> Hi,
>
> On Wed, Aug 24, 2016 at 04:48:01PM -0400, Robert Foss wrote:
> > On 2016-08-22 11:23 PM, Brian Norris wrote:
> > >+ others
> &g
Hi,
On Wed, Aug 24, 2016 at 04:48:01PM -0400, Robert Foss wrote:
> On 2016-08-22 11:23 PM, Brian Norris wrote:
> >+ others
> >
> >Hi Robert and Felipe,
> >
> >I have a few questions for one or both of you. I'm not really an expert
> >on runtime PM, so p
Taking our cue from commit a42f6e3f8f03 ("drm/panel: simple: Add delay
timing for Sharp LQ123P1JX31"), let's add timings:
.prepare = t1 + t3
.enable = t7
.unprepare = t11 + 12
Without this, the panel may not be given enough time to come up.
Signed-off-by: Brian Norris
---
Hi,
On Mon, Aug 22, 2016 at 11:36:23AM +0800, Lin Huang wrote:
> base on dfi result, we do ddr frequency scaling, register
> dmc driver to devfreq framework, and use simple-ondemand
> policy.
>
> Signed-off-by: Lin Huang
> Reviewed-by: Chanwoo Choi
> ---
> Changes in v7:
> - remove a blank line
+ devicetree list
You should be including devicet...@vger.kernel.org on all binding
documents. And as Chanwoo Choi already mentioned, you didn't fix his
comments from v6:
https://lkml.org/lkml/2016/8/16/913
On Mon, Aug 22, 2016 at 11:36:22AM +0800, Lin Huang wrote:
> This patch adds the document
+ others
Hi Robert and Felipe,
I have a few questions for one or both of you. I'm not really an expert
on runtime PM, so please take my questions with a grain of salt.
On Wed, Aug 10, 2016 at 04:32:15PM -0400, robert.f...@collabora.com wrote:
> From: Robert Foss
>
> Enable runtime PM for the x
The dwc3 driver expicitly looks for "usb2-phy" or "usb3-phy", but we
never noted these names in the documentation.
Signed-off-by: Brian Norris
---
Documentation/devicetree/bindings/usb/dwc3.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Docu
to find panel
...
Let's just drop the message.
Signed-off-by: Brian Norris
---
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
b/drivers/gpu/drm/rockchip/analogix_dp-rockc
where we
don't want to constantly poll the bus, but instead back off and
sleep/retry for a little while.
Fixes: 2c7589af3c4d ("mfd: cros_ec: add proto v3 skeleton")
Signed-off-by: Shawn Nematbakhsh
Signed-off-by: Brian Norris
---
MAINTAINERS tells me this goes through Olof, but many t
romeOS EC keyboard driver")
Cc: # 9798ac6d32c1 mfd: cros_ec: Add
cros_ec_cmd_xfer_status() helper
Signed-off-by: Brian Norris
Reviewed-by: Javier Martinez Canillas
Acked-by: Dmitry Torokhov
---
drivers/input/keyboard/cros_ec_keyb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
present in v4.8-rc1.
These can be taken independently by their subsystem maintainers. (Wolfram and
Dmitry, who already acked them.)
Regards,
Brian
Brian Norris (2):
i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()
Input: cros_ec_keyb - Fix usage of cros_ec_cmd_xfer()
drivers/i2c/busses/i2c
ChromeOS EC tunnel driver")
Cc: # 9798ac6d32c1 mfd: cros_ec: Add
cros_ec_cmd_xfer_status() helper
Signed-off-by: Brian Norris
Reviewed-by: Javier Martinez Canillas
Acked-by: Wolfram Sang
---
drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
801 - 900 of 2491 matches
Mail list logo
