[PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-09 Thread Brian Norris
nter Roeck Signed-off-by: Brian Norris --- On Fri, Nov 09, 2018 at 11:55:26AM +0900, Masahiro Yamada wrote: > > On Wed, Nov 7, 2018 at 1:18 PM Doug Anderson wrote: > > > On Wed, Nov 7, 2018 at 1:07 PM Genki Sky wrote: > > > > On Wed, 7 Nov 2018 12:55:14 -0800, Guenter

Re: [PATCH] cfg80211: use IDA to allocate wiphy indeces

2018-06-29 Thread Brian Norris
Hi Johannes, On Fri, Jun 29, 2018 at 09:42:20AM +0200, Johannes Berg wrote: > On Wed, 2018-06-20 at 18:29 -0700, Brian Norris wrote: > > It's annoying to see the phy index increase arbitrarily, just because a > > device got removed and re-probed (e.g., during a device reset,

Re: [PATCH v3 02/12] PM / devfreq: Fix handling of min/max_freq == 0

2018-06-18 Thread Brian Norris
(the core devfreq bugfixes and features, and a small cpufreq helper fixup), and they seem pretty clear and good to me, aside from a minor error in the current subject (s/devfreg/devfreq/). So: Reviewed-by: Brian Norris

Re: [PATCH v3 10/12] misc: throttler: Add core support for non-thermal throttling

2018-06-18 Thread Brian Norris
Hi Matthias, On Thu, Jun 14, 2018 at 12:47:10PM -0700, Matthias Kaehlcke wrote: > The purpose of the throttler is to provide support for non-thermal > throttling. Throttling is triggered by external event, e.g. the > detection of a high battery discharge current, close to the OCP limit > of the ba

Re: [PATCH v3 12/12] mfd: cros_ec: Add throttler sub-device

2018-06-18 Thread Brian Norris
Hi, On Thu, Jun 14, 2018 at 12:47:12PM -0700, Matthias Kaehlcke wrote: > Instantiate the CrOS EC throttler if it is enabled in the kernel > configuration. > > Signed-off-by: Matthias Kaehlcke > --- > Changes in v3: > - patch added to series > > drivers/mfd/cros_ec.c | 16 > 1

Re: [PATCH v3 11/12] misc: throttler: Add Chrome OS EC throttler

2018-06-18 Thread Brian Norris
c Balletbo i Serra One suggestion, and otherwise: Reviewed-by: Brian Norris > --- > Changes in v3: > - change module license to GPL v2 as in the SPDX identifier > - don't instantiate the throttler through the DT (instantiation > by CrOS EC MFD in a separate patch) &

[PATCH] ACPI / processor: Finish making acpi_processor_ppc_has_changed() void

2018-06-19 Thread Brian Norris
Commit bca5f557dcea ("ACPI / processor: Make acpi_processor_ppc_has_changed() void") changed one of the declarations of acpi_processor_ppc_has_changed() to return void, but the !CPU_FREQ version still return int. Let's return void to be consistent. Signed-off-by: Brian Norris --

[PATCH 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-05-31 Thread Brian Norris
a 'ti,bq20z75' compatible property, then we retain the existing TI command behaviors. [1] http://www.ti.com/lit/er/sluu265a/sluu265a.pdf Signed-off-by: Brian Norris --- drivers/power/supply/sbs-battery.c | 61 +- 1 file changed, 52 insertions(+), 9 deletions(-)

[PATCH 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

2018-05-31 Thread Brian Norris
, and because we've noticed there are some lingering TI specifics (in the manufacturer-specific portion of the SBS spec), we'd like to start using this property again to differentiate. Cc: Rhyland Klein Signed-off-by: Brian Norris --- .../devicetree/bindings/power/supply/sbs_sbs-b

[PATCH v2 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-06-01 Thread Brian Norris
a 'ti,bq20z75' compatible property, then we retain the existing TI command behaviors. [1] http://www.ti.com/lit/er/sluu265a/sluu265a.pdf Signed-off-by: Brian Norris --- v2: * don't stub out POWER_SUPPLY_PROP_PRESENT from sbs_data[] * use if/else instead of switch/case --- drivers/powe

[PATCH v2 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

2018-06-01 Thread Brian Norris
, and because we've noticed there are some lingering TI specifics (in the manufacturer-specific portion of the SBS spec), we'd like to start using this property again to differentiate. Signed-off-by: Brian Norris Acked-by: Rhyland Klein --- v2: add Rhyland's Acked-by --- .../devi

Re: [PATCH v2 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-06-01 Thread Brian Norris
Hi, On Fri, Jun 01, 2018 at 10:34:34AM -0700, Guenter Roeck wrote: > On Fri, Jun 01, 2018 at 10:23:59AM -0700, Brian Norris wrote: > > drivers/power/supply/sbs-battery.c | 54 +- > > 1 file changed, 46 insertions(+), 8 deletions(-) > > > >

[PATCH v3 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

2018-06-01 Thread Brian Norris
, and because we've noticed there are some lingering TI specifics (in the manufacturer-specific portion of the SBS spec), we'd like to start using this property again to differentiate. Signed-off-by: Brian Norris Acked-by: Rhyland Klein --- v2: add Rhyland's Acked-by v3: no change -

[PATCH v3 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-06-01 Thread Brian Norris
a 'ti,bq20z75' compatible property, then we retain the existing TI command behaviors. [1] http://www.ti.com/lit/er/sluu265a/sluu265a.pdf Signed-off-by: Brian Norris Reviewed-by: Guenter Roeck Acked-by: Rhyland Klein --- v2: * don't stub out POWER_SUPPLY_PROP_PRESENT from sbs_data[] *

Re: [PATCH v2 09/11] misc: throttler: Add core support for non-thermal throttling

2018-06-12 Thread Brian Norris
Hi, On Tue, Jun 12, 2018 at 10:11:40AM -0700, Matthias Kaehlcke wrote: > On Mon, Jun 11, 2018 at 06:49:13PM -0700, Brian Norris wrote: > > On Thu, Jun 07, 2018 at 11:12:12AM -0700, Matthias Kaehlcke wrote: > > > The purpose of the throttler is to provide support for non-therma

[PATCH 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-06-12 Thread Brian Norris
27;ti,bq20z75' compatible property, then we continue to use the existing TI command behaviors, and we effectively revert commit 17c6d3979e5b ("sbs-battery: make writes to ManufacturerAccess optional") to again make these commands required. [1] http://www.ti.com/li

[PATCH 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

2018-06-12 Thread Brian Norris
quot; string, so we can handle vendor specifics -- so document this. Language borrowed mostly from Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt Also fixup the example to use this property (it's already implying that it's "bq20z75@b"); fixup the node name to be gene

Re: [PATCH 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-06-12 Thread Brian Norris
Eek, sorry this series should have subjects "[PATCH v5 X/2] ...". I can resend if really needed, but hopefully by now this is ready to go... Brian On Tue, Jun 12, 2018 at 1:20 PM, Brian Norris wrote: > This driver was originally submitted for the TI BQ20Z75 battery IC > (com

Re: [PATCH v2 10/11] dt-bindings: misc: add bindings for cros_ec_throttler

2018-06-12 Thread Brian Norris
Hi Rob, On Tue, Jun 12, 2018 at 01:10:11PM -0600, Rob Herring wrote: > On Thu, Jun 07, 2018 at 11:12:13AM -0700, Matthias Kaehlcke wrote: > > The cros_ec_throttler monitors events from the Chrome OS Embedded > > Controller to throttle the system if needed, using the mechanisms > > provided by the

Re: [PATCH v3 01/12] PM / devfreq: Init user limits from OPP limits, not viceversa

2018-06-15 Thread Brian Norris
ity. > --- BTW, putting the '---' here means that stuff below it usually gets dropped when applied (e.g., with git-am). So it'll drop your Signed-off-by and Reviewed-by. Not a huge problem if the maintainers look out for that. > Signed-off-by: Matthias Kaehlcke > Reviewed-by

Re: [PATCH v5 4/4] drm/rockchip: support dp training outside dp firmware

2018-05-17 Thread Brian Norris
On Thu, May 17, 2018 at 6:41 PM, hl wrote: > On Thursday, May 17, 2018 09:51 PM, Sean Paul wrote: >> On Thu, May 17, 2018 at 05:18:00PM +0800, Lin Huang wrote: >>> DP firmware uses fixed phy config values to do training, but some >>> boards need to adjust these values to fit for their unique hardw

Re: [PATCH v1 1/2] soc: qcom: rmtfs-mem: Add class to enable uevents

2018-12-20 Thread Brian Norris
Hi Evan, On Mon, Dec 17, 2018 at 04:08:33PM -0800, Evan Green wrote: > Currently the qcom_rmtfs_memN devices are entirely invisible to the udev > world. > Add a class to the rmtfs device so that uevents fire when the device is added. > > Signed-off-by: Evan Green > --- > > drivers/soc/qcom/rm

Re: [PATCH v1 2/2] soc: qcom: rmtfs-mem: Make sysfs attributes world-readable

2018-12-20 Thread Brian Norris
ive, since if you have access to physical memory, the jig is > up anyway. > > Make those attributes readable by all. > > Signed-off-by: Evan Green > --- Seems fine to me. Reviewed-by: Brian Norris > > drivers/soc/qcom/rmtfs_mem.c | 6 +++--- > 1 file changed, 3 i

Re: [PATCH v2 1/2] soc: qcom: rmtfs-mem: Add class to enable uevents

2018-12-21 Thread Brian Norris
27;ve got some spurious whitespace changes below, but otherwise: Reviewed-by: Brian Norris > Changes in v2: > - Moved class registration/deregistration into init/exit routines (Brian) > > drivers/soc/qcom/rmtfs_mem.c | 29 + > 1 file changed, 21 insertion

Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom: Add firmware bindings for Q6V5

2019-01-04 Thread Brian Norris
Hi again, On Thu, Jan 03, 2019 at 04:11:58PM -0800, Brian Norris wrote: > On Thu, Jan 03, 2019 at 04:01:45PM -0800, Bjorn Andersson wrote: > > I share your concern about this, but I came to suggest this as the > > driver cares about platforms but the firmware is (often?) >

Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom: Add firmware bindings for Q6V5

2019-01-03 Thread Brian Norris
Hi Sibi, On Fri, Dec 28, 2018 at 10:18:18AM +0530, Sibi Sankar wrote: > Add optional "firmware-name" bindings for Q6V5 MSS and PAS based > remoteprocs. For Q6V5 MSS/PAS the two/one relative firmware > paths/path are to be listed respectively. Fallback to the default > images for mba/modem for Q6V5

Re: [PATCH v2 2/2] remoteproc: qcom: Add support for parsing fw dt bindings

2019-01-03 Thread Brian Norris
On Fri, Dec 28, 2018 at 10:18:19AM +0530, Sibi Sankar wrote: > Add support for parsing "firmware-name" dt bindings which specifies > the relative paths of mba/modem/pas image as strings. Fallback to > the default paths for mba/modem/pas image on -EINVAL. > > Signed-off-by: Sibi Sankar > --- > dr

Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom: Add firmware bindings for Q6V5

2019-01-03 Thread Brian Norris
On Thu, Jan 03, 2019 at 03:30:14PM -0800, Brian Norris wrote: > On Fri, Dec 28, 2018 at 10:18:18AM +0530, Sibi Sankar wrote: > > +- firmware-name: > > + Usage: optional > > + Value type: > > + Definition: must list the relative firmware image path for the >

Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom: Add firmware bindings for Q6V5

2019-01-03 Thread Brian Norris
Hi Bjorn, On Thu, Jan 03, 2019 at 04:01:45PM -0800, Bjorn Andersson wrote: > On Thu 03 Jan 15:50 PST 2019, Brian Norris wrote: > > > On Thu, Jan 03, 2019 at 03:30:14PM -0800, Brian Norris wrote: > > > On Fri, Dec 28, 2018 at 10:18:18AM +0530, Sibi Sankar wrote: >

[PATCH] remoteproc: qcom: q6v5-pil: add SCM probe dependency

2018-10-08 Thread Brian Norris
Similar to qcom_q6v5_pas and qcom_wcnss drivers, probe will fail if SCM is not up. Signed-off-by: Brian Norris --- drivers/remoteproc/qcom_q6v5_mss.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c index

Re: [PATCH] remoteproc: qcom: q6v5-pil: add SCM probe dependency

2018-10-09 Thread Brian Norris
On Mon, Oct 08, 2018 at 11:21:25PM -0700, Bjorn Andersson wrote: > On Mon 08 Oct 19:08 PDT 2018, Brian Norris wrote: > > > Similar to qcom_q6v5_pas and qcom_wcnss drivers, probe will fail if SCM > > is not up. > > > > Thanks Brian, this dependency was introd

[PATCH] remoteproc: qcom: q6v5: shore up resource probe handling

2018-10-09 Thread Brian Norris
all explicitly. Fixes: d5269c4553a6 ("remoteproc: qcom: q6v5: Propagate EPROBE_DEFER") Signed-off-by: Brian Norris --- drivers/remoteproc/qcom_q6v5.c | 44 +++--- 1 file changed, 36 insertions(+), 8 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5.c b/drive

Re: [PATCH] remoteproc: qcom: q6v5: shore up resource probe handling

2018-10-09 Thread Brian Norris
On Tue, Oct 9, 2018 at 4:34 PM Doug Anderson wrote: > On Tue, Oct 9, 2018 at 3:33 PM Brian Norris wrote: > > + if (q6v5->wdog_irq < 0) { > > + if (q6v5->wdog_irq != -EPROBE_DEFER) > > + dev_err(&pdev->dev, > >

Re: [RFC PATCH] soc: qcom: rmtfs_mem: Control remoteproc from rmtfs_mem

2018-10-17 Thread Brian Norris
Hi Bjorn, Sorry for getting back to this late. On Tue, Oct 02, 2018 at 12:34:45PM -0700, Bjorn Andersson wrote: > On Tue 25 Sep 10:29 PDT 2018, Brian Norris wrote: > For the record; I did consider making the rmtfs implementation the one > driving the remoteproc state through /

Re: [RFC PATCH] soc: qcom: rmtfs_mem: Control remoteproc from rmtfs_mem

2018-10-17 Thread Brian Norris
Hi Sibi, On Sun, Sep 30, 2018 at 08:58:49PM +0530, Sibi Sankar wrote: > On 2018-09-25 22:59, Brian Norris wrote: > > On Tue, Sep 25, 2018 at 01:06:07AM -0700, Bjorn Andersson wrote: > > So rather than looking for open(), I think somebody needs to be looking > > f

Re: [RFC PATCH v2] soc: qcom: rmtfs_mem: Control remoteproc from rmtfs_mem

2018-10-17 Thread Brian Norris
Hi Sibi, On Sun, Sep 30, 2018 at 09:26:46PM +0530, Sibi Sankar wrote: > From: Bjorn Andersson > > rmtfs_mem provides access to physical storage and is crucial for the > operation of the Qualcomm modem subsystem. > > The rmtfs_mem implementation must be available before the modem > subsystem is

Re: [PATCH] Revert "scripts/setlocalversion: git: Make -dirty check more robust"

2018-11-06 Thread Brian Norris
heck $(touch .git/some-file-here > 2>/dev/null && ...) instead of $(test -w .git) to handle misconfigured > NFS setups. But not sure if that has its own problems. Trying to 'touch' the source tree will also break us. No matter whether you redirect stderr, our sandbox will still notice the build is doing something fishy and complain. In any case, I'd be very happy with a Revert for now (for 4.20, and even -stable), and a follow-up replacement, so: Reviewed-by: Brian Norris for the $subject patch.

Re: [PATCH] Revert "scripts/setlocalversion: git: Make -dirty check more robust"

2018-11-06 Thread Brian Norris
On Tue, Nov 6, 2018 at 6:58 PM Christian Kujau wrote: > FWIW, the issue I reported back in 2013[0] was not an ill-configured NFS > export, but a read-only NFS export (and then a read-write exported NFS > export, but the user compiling the kernel did not have write permission) > and so "test -w .gi

Re: [PATCH] Revert "scripts/setlocalversion: git: Make -dirty check more robust"

2018-11-07 Thread Brian Norris
On Tue, Nov 06, 2018 at 08:00:36PM -0800, Brian Norris wrote: > On a different tangent: how about the --no-optional-locks (see > git(1))? Will this get you your "up-to-date" result without writing to > the .git directory? I've only read the documentation, but not tested &g

[PATCH] input: cros_ec_keyb: fix button/switch capability reports

2018-11-07 Thread Brian Norris
the downstream Chromium OS kernel to be upstreamed. Fixes: cdd7950e7aa4 ("input: cros_ec_keyb: Add non-matrix buttons and switches") Cc: Cc: Douglas Anderson Cc: Enric Balletbo i Serra Signed-off-by: Brian Norris --- drivers/input/keyboard/cros_ec_keyb.c | 3 ++- 1 file changed, 2

[PATCH] input: cros_ec_keyb: fix button/switch capability reports

2018-11-07 Thread Brian Norris
the downstream Chromium OS kernel to be upstreamed. Fixes: cdd7950e7aa4 ("input: cros_ec_keyb: Add non-matrix buttons and switches") Cc: Cc: Douglas Anderson Cc: Enric Balletbo i Serra Signed-off-by: Brian Norris --- drivers/input/keyboard/cros_ec_keyb.c | 3 ++- 1 file changed, 2

[PATCH 2/2] platform/chrome: don't report EC_MKBP_EVENT_SENSOR_FIFO as wakeup

2018-11-07 Thread Brian Norris
ly. This was causing /sys/power/wakeup_count to increase very frequently, often needlessly interrupting our ability to suspend the system. Signed-off-by: Brian Norris --- drivers/platform/chrome/cros_ec_proto.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --gi

[PATCH 1/2] platform/chrome: fixup cros_ec_get_next_event() error codes

2018-11-07 Thread Brian Norris
ol errors (including EC_RES_UNAVAILABLE) are treated as "no data available." Signed-off-by: Brian Norris --- This barely touches MFD code, but overall this series should probably go through the platform/chrome maintenance, IMO. --- drivers/mfd/cros_ec.c | 4 ++-- drivers/platfo

Re: [PATCH 1/2] platform/chrome: fixup cros_ec_get_next_event() error codes

2018-11-07 Thread Brian Norris
On Wed, Nov 7, 2018 at 5:30 PM Brian Norris wrote: > > cros_ec_get_next_event() is documented to return 0 for success and > negative for errors. It currently returns negative for some errors, and > non-negative (number of bytes received) for success (including some "no > data

[PATCH v2 1/2] platform/chrome: straighten out cros_ec_get_{next,host}_event() error codes

2018-11-07 Thread Brian Norris
ned 0 bytes). And fix the documentation of cros_ec_get_host_event() and cros_ec_get_next_event() to accurately describe their behavior. Signed-off-by: Brian Norris --- v1 -> v2: * don't make as many changes to the API -- just fix the documentation and a few corner cases instead --- driver

[PATCH v2 2/2] platform/chrome: don't report EC_MKBP_EVENT_SENSOR_FIFO as wakeup

2018-11-07 Thread Brian Norris
ly. This was causing /sys/power/wakeup_count to increase very frequently, often needlessly interrupting our ability to suspend the system. Signed-off-by: Brian Norris --- v1 -> v2: * no change --- drivers/platform/chrome/cros_ec_proto.c | 18 +++--- 1 file changed, 15 insertions(+

Re: [PATCH] Revert "scripts/setlocalversion: git: Make -dirty check more robust"

2018-11-07 Thread Brian Norris
On Wed, Nov 7, 2018 at 1:18 PM Doug Anderson wrote: > On Wed, Nov 7, 2018 at 1:07 PM Genki Sky wrote: > > On Wed, 7 Nov 2018 12:55:14 -0800, Guenter Roeck wrote: > > > Ubuntu 16.04 ships with git version 2.7.4. > > > > Okay. I guess --no-optional-locks is a no-go then. > > In theory you could wr

Re: [PATCH] ath10k: avoid -Wmaybe-uninitialized warning

2018-11-02 Thread Brian Norris
Hi, On Fri, Nov 2, 2018 at 9:19 AM Arnd Bergmann wrote: > > In some configurations the inlining in gcc is suboptimal, causing > a false-positive warning: > > drivers/net/wireless/ath/ath10k/mac.c: In function 'ath10k_mac_init_rd': > drivers/net/wireless/ath/ath10k/mac.c:8374:39: error: 'rd' may b

Re: [PATCH 0/2] net: mwifiex: add support for the SD8777 chipset

2023-11-02 Thread Brian Norris
On Sun, Oct 29, 2023 at 12:08:15PM +0100, Karel Balej wrote: > The driver requires proprietary firmware which is not yet part of > linux-firmware, but it is packaged in postmarketOS. You gotta get that done: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#new_driver

Re: [PATCH 1/2] dt-bindings: mwifiex: document use with the SD8777 chipset

2023-11-02 Thread Brian Norris
On Sun, Oct 29, 2023 at 12:08:16PM +0100, Karel Balej wrote: > Document the corresponding compatible string for the use of this driver > with the Marvell SD8777 wireless chipset. > > Signed-off-by: Karel Balej FWIW, the binding looks fine from mwifiex point of view, so: Acked-by:

Re: [PATCH] mtd: add reboot notifier to mtdcore and register nand_shutdown with notifier

2014-12-04 Thread Brian Norris
On Thu, Dec 04, 2014 at 04:13:01PM -0800, Scott Branden wrote: > Apologies: patch fails checkpatch due to spaces instead of tabs > during cut and paste. > > But, please comment on this patch before I create a new version. I'd prefer the separation to be as I sent in the first place; one patch to

Re: [PATCH] Documentation: Add entry for dell-laptop sysfs interface

2014-12-30 Thread Brian Norris
Hi, On Wed, Dec 03, 2014 at 06:41:33PM +0100, Gabriele Mazzotta wrote: > Add the documentation for the new sysfs interface of dell-laptop > that allows to configure the keyboard illumination on Dell systems. > > Signed-off-by: Gabriele Mazzotta > Signed-off-by: Pali Rohár > --- > .../ABI/testi

[PATCH] xfs: fix typo

2015-01-23 Thread Brian Norris
'tobe' should be two words. Signed-off-by: Brian Norris --- fs/xfs/xfs_aops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 18e2f3bbae5e..af729e8975aa 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -1161

Re: [PATCH 1/2] MAINTAINERS: update brcmstb entries

2015-01-14 Thread Brian Norris
b92a78d1d5..33a8b31e03f0 100644 >>>>> --- a/MAINTAINERS >>>>> +++ b/MAINTAINERS >>>>> @@ -2093,8 +2093,9 @@ F: arch/arm/mach-bcm/bcm63xx.c >>>>> F: arch/arm/include/debug/bcm63xx.S >>>>> >>>>> BROADCOM BCM7XXX ARM ARCH

Re: [V7 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2015-01-07 Thread Brian Norris
On Wed, Dec 17, 2014 at 07:35:45AM +, Bean Huo 霍斌斌 (beanhuo) wrote: > This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. > > For Micron SPI NOR flash, enabling or disabling quad I/O protocol can be done > By two methods, which are to use EVCR(Enhanced Volatile Configur

Re: [RESEND PATCH 1/3] mtd:mtdblock: remove the needless mtdblks_lock

2015-01-07 Thread Brian Norris
On Wed, Dec 03, 2014 at 10:19:52AM +0800, Gu Zheng wrote: > The global lock mtdblks_lock was used to protect the original mtdblks > array to avoid race conditions. As the mtdblks array was already gone, > but the mtdblks_lock is left, and it causes latency when open/release dev. > So we need to rem

Re: [PATCH 0/3] An alternative to SPI NAND

2015-01-07 Thread Brian Norris
On Thu, Jan 08, 2015 at 12:47:24AM +, Peter Pan 潘栋 (peterpandong) wrote: > Documentation/devicetree/bindings/mtd/spi-nand.txt | 22 + > drivers/mtd/Kconfig|2 + > drivers/mtd/Makefile |1 + > drivers/mtd/spi-nand/Kconfig

Re: [PATCH v3] mtd: test: Replace timeval with ktime_t in speedtest.c and torturetest.c

2015-01-07 Thread Brian Norris
the > y2038 branch together with the patch that introduces ktime_ms_delta. > > David or Brian, can you provide an Ack for this, or do you have > any objections? I just tested v2, which doesn't have this dependency and has only a trivial difference from v3. Seems to work OK. So:

Re: [PATCH] Documentation: Add entry for dell-laptop sysfs interface

2015-01-10 Thread Brian Norris
On Fri, Jan 9, 2015 at 10:57 PM, Darren Hart wrote: > On Wed, Dec 31, 2014 at 12:20:59PM +0100, Gabriele Mazzotta wrote: >> You are perfectly right, the documentation is wrong and I'm sorry for >> that. als_setting should allow you to define when the keyboard >> backlight has to be turned on or of

Re: [PATCH 3/3] [PATCH] mtd: fix concurrent access to mtd->usecount

2015-01-10 Thread Brian Norris
On Wed, Nov 26, 2014 at 09:36:30PM +0800, zhangxingcai wrote: > __get_mtd_device() is called to increment mtd->usecount when we access > mtd via /dev/mtd1 or /dev/mtdblock1, but mtd_table_mutex lock is used in the > former > via get_mtd_device(), while &dev->lock lock is used in the latter. There

[PATCH] kgdb: fix potential out-of-bounds access

2015-01-12 Thread Brian Norris
CPU arrays (e.g., kgdb_info[]) are indexed from 0 (inclusive) to NR_CPUS (exclusive). Pointed out by Coverity, CID 1262269 Signed-off-by: Brian Norris Cc: Jason Wessel --- Untested kernel/debug/kdb/kdb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/debug

Re: [PATCH] kgdb: fix potential out-of-bounds access

2015-01-12 Thread Brian Norris
On Mon, Jan 12, 2015 at 11:54 AM, Jason Wessel wrote: > This is actually already fixed a different way in the kgdb-next: > > https://git.kernel.org/cgit/linux/kernel/git/jwessel/kgdb.git/commit/?h=kgdb-next&id=c7d9ebf81c456dc185c8eae9e293bfdccf2a65f5 Great. Thanks for the quick response. Brian -

Re: [PATCH mtd] mtd:devices: Add Altera EPCQ Driver

2015-01-12 Thread Brian Norris
epcq_write_erase_check(struct altera_epcq *dev, > + bool write_erase) > +{ > + u32 val; > + u32 mask; > + > + if (write_erase) > + mask = EPCQ_ISR_ILLEGAL_WRITE_MASK; > + else > + mask = EPCQ_ISR_ILL

Re: [PATCH v3 11/13] mtd: st_spi_fsm: General tidy-up

2015-01-12 Thread Brian Norris
On Mon, Dec 15, 2014 at 11:59:18AM +, Lee Jones wrote: > Due to the nature of the port (lots of copy/paste) much of the white-space > is taken up by spaces instead of tab separators. This patch aims to change > that. > > Signed-off-by: Lee Jones checkpatch.pl gives several warnings like this

Re: [PATCH] jffs2: compr_rubin: Remove unused function

2015-01-12 Thread Brian Norris
On Sun, Jan 11, 2015 at 05:36:48PM +0100, Rickard Strandqvist wrote: > Remove the function pulledbits() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist Pushed to l2-mtd.git. Thanks. Brian

Re: [PATCH v3 04/13] mtd: st_spi_fsm: Fetch boot device locations from DT match tables

2015-01-12 Thread Brian Norris
+ devicetree On Mon, Dec 15, 2014 at 11:59:11AM +, Lee Jones wrote: > To trim down on the amount of properties used by this driver and to conform > to the newly agreed method of acquiring syscfg registers/offsets, we now > obtain this information using match tables. > > In the process we are

Re: [PATCH v3 03/13] mtd: st_spi_fsm: dt-bindings: Deprecate generic compatible string

2015-01-12 Thread Brian Norris
+ devicetree Please include devicet...@vger.kernel.org whenever you send DT patches like this. On Mon, Dec 15, 2014 at 11:59:10AM +, Lee Jones wrote: > This driver now obtains platform information via DT matching, which requires > a compatible string per platform. This change introduces the

Re: [PATCH v3 08/13] mtd: st_spi_fsm: Update the JEDEC probe to handle extended READIDs

2015-01-12 Thread Brian Norris
On Mon, Dec 15, 2014 at 11:59:15AM +, Lee Jones wrote: > The previous code was based on 3-byte JEDEC IDs, with a possible 2-byte > extension. However, devices are now emerging that return 6 or more bytes of > READID data and the additional bytes are required to differentiate between > variants

Re: [PATCH v3 00/13] mtd: st_spi_fsm: Align with ST's internal development

2015-01-12 Thread Brian Norris
On Mon, Dec 15, 2014 at 11:59:07AM +, Lee Jones wrote: > Hi Brian, all, > > [x] Bulid test > [x] Bisectable > [x] Smatch > [x] Sparse Picked patches 1, 2, and 5 to l2-mtd.git. I requested changes to patch 3 and possibly 4. The rest look OK, but I don't want to futz with patch conflicts o

Re: [PATCH] mtd: denali: fix incorrect bitmask error in denali_setup_dma

2015-01-13 Thread Brian Norris
On Fri, Jan 09, 2015 at 09:32:35AM -0600, dingu...@opensource.altera.com wrote: > From: Graham Moore > > commit "3157d1ed2309 mtd: denali: remove unnecessary casts" introduced > an error by using a wrong bitmask. > > A uint16_t cast was replaced with & 0xff, should be & 0x. > > Signed-off-b

Re: [PATCH] MTD: Deletion of checks before the function call "iounmap"

2015-01-19 Thread Brian Norris
On Sun, Jan 18, 2015 at 06:08:12PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 18 Jan 2015 17:30:23 +0100 > > The iounmap() function performs also input parameter validation. > Thus the test around the call is not needed. Is this guaranteed for all arch'es? I expect that

Re: [PATCH] MTD: Deletion of checks before the function call "iounmap"

2015-01-19 Thread Brian Norris
On Mon, Jan 19, 2015 at 07:19:34PM +0100, SF Markus Elfring wrote: > > Anyway, I'm essentially saying that I'd like to be 100% sure we have a > > guarantee before dropping all these. > > You can not be absolutely sure. There are various implementation details > which will eventually need further c

Re: [PATCH] MTD: Deletion of checks before the function call "iounmap"

2015-01-19 Thread Brian Norris
On Mon, Jan 19, 2015 at 09:20:47PM +0300, Dan Carpenter wrote: > The sparc iounmap() implementation in arch/sparc/kernel/ioport.c looks > it prints an error message if you pass a NULL pointer. Seems that way. Thanks. Nak to the patch then. Brian -- To unsubscribe from this list: send the line "u

Re: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two function calls

2015-01-19 Thread Brian Norris
I went digging through some of Markus's old patch history, and noticed this... On Mon, Nov 03, 2014 at 12:50:59PM +0300, Dan Carpenter wrote: > This one is buggy. > > I'm sorry, but please stop sending these. I'm tending to concur. > For kfree(), at least we all know that kfree() accepts NULL p

Re: [PATCH] MTD: Deletion of checks before the function call "iounmap"

2015-01-19 Thread Brian Norris
On Mon, Jan 19, 2015 at 08:07:34PM +0100, SF Markus Elfring wrote: > >> I published scripts for static source code analysis in March 2004. ^^ That would be March 2014, not March 2004. > > I didn't ask "when?"; where? > > https://lkml.org/lkml/2014/3/5/356 > http://article.gmane.org/gmane.comp.ve

Re: [PATCH] mtd: export new mtd_mmap_capabilities

2015-01-28 Thread Brian Norris
This adds the missing export. > > Signed-off-by: Arnd Bergmann > Fixes: b4caecd48005f ("fs: introduce f_op->mmap_capabilities for nommu mmap > support") Acked-by: Brian Norris This should go through the block tree in which the target commit is queued. Brian -- To unsubsc

Re: [PATCH 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY

2015-03-19 Thread Brian Norris
Hi Hans, Thanks for the review. On Thu, Mar 19, 2015 at 12:10:25PM +0100, Hans de Goede wrote: > On 19-03-15 02:23, Brian Norris wrote: > >Signed-off-by: Brian Norris > >--- > >Light dependency on: > > > > http://lists.infradead.org/pipermail/linux-arm-ker

Re: [PATCH 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY

2015-03-19 Thread Brian Norris
Hi Sergei, On Thu, Mar 19, 2015 at 02:33:32PM +0300, Sergei Shtylyov wrote: > Hello. > > On 3/19/2015 4:23 AM, Brian Norris wrote: > > >Signed-off-by: Brian Norris > >--- > >Light dependency on: > > > > http://lists.infradead.org/pipermail/linux-ar

Re: [PATCH] tools: unbreak 'make tools/*'

2015-03-19 Thread Brian Norris
On Thu, Mar 19, 2015 at 03:20:26PM +0100, Jiri Olsa wrote: > On Thu, Mar 19, 2015 at 10:39:25AM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > [acme@ssdandy linux]$ > > > > --- > > > > Jiri, can you take a look at the above? > > > > It

Re: [PATCH 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY

2015-03-19 Thread Brian Norris
On Thu, Mar 19, 2015 at 06:02:16PM +0100, Hans de Goede wrote: > On 19-03-15 16:53, Brian Norris wrote: > >On Thu, Mar 19, 2015 at 12:10:25PM +0100, Hans de Goede wrote: > >>On 19-03-15 02:23, Brian Norris wrote: > >>>Signed-off-by: Brian Norris >

Re: [PATCH] mtd:spi-nor: Add lock and unlock callback functions to struct spi_nor

2015-03-19 Thread Brian Norris
Hi Viet, On Mon, Mar 16, 2015 at 01:15:14AM -0700, vn...@altera.com wrote: > From: VIET NGA DAO > > This patch introduces a properly-replaceable spi_nor callback that does > flash specific lock and unlock. The existing code for spi_nor_lock and > spi_nor_unlock is moved into their own functions

Re: [PATCH 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY

2015-03-19 Thread Brian Norris
Replying to myself, because I may or may not like having conversations with myself :) On Thu, Mar 19, 2015 at 10:36:40AM -0700, Brian Norris wrote: > On Thu, Mar 19, 2015 at 06:02:16PM +0100, Hans de Goede wrote: > > On 19-03-15 16:53, Brian Norris wrote: > > >On Thu, Mar 19,

[PATCH] thermal: user_space: add trip point number to uevent data

2015-04-01 Thread Brian Norris
pdate(), which loops over *all* trip points. This seems very counter-intuitive and unhelpful, but maybe I'm just clueless. Signed-off-by: Brian Norris --- drivers/thermal/user_space.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/user

Re: [PATCH 4/5] phy: add Broadcom SATA3 PHY driver for Broadcom STB SoCs

2015-04-01 Thread Brian Norris
On Tue, Mar 31, 2015 at 11:31:40AM +0530, Kishon Vijay Abraham I wrote: > On Saturday 28 March 2015 05:58 AM, Brian Norris wrote: > >On Thu, Mar 26, 2015 at 03:29:44AM +0530, Kishon Vijay Abraham I wrote: > >>On Thursday 19 March 2015 06:53 AM, Brian Norris wrote: >

Re: [PATCH] mtd: Add simple read disturb test

2015-04-02 Thread Brian Norris
On Thu, Apr 02, 2015 at 04:13:46PM +0200, Richard Weinberger wrote: > This simple MTD tests allows the user to see when read disturb happens. > By reading blocks over and over it reports flipped bits. > Currently it reports only flipped bits of the worst page of a block. > If within block X page P1

Re: [PATCH 2/2] mtd: mtd_oobtest: Fix the address offset with vary_offset case

2015-04-02 Thread Brian Norris
(unsigned long)addr, i, *su1, *su2, res); > + pr_info("error @addr[0x%lx:0x%lx] 0x%x -> 0x%x diff > 0x%x\n", > + (unsigned long)addr, (unsigned long)offset + i, > + *su1, *su2, res); This hunk doesn't apply

Re: [PATCH v5 2/2] memory: pl353: Add driver for arm pl353 static memory controller

2015-04-02 Thread Brian Norris
I'm not following the review of the 'memory' portions much, but has this gotten much review? I was looking at the MTD portions when I noticed an obvious issue below: On Tue, Jan 06, 2015 at 11:19:17PM +0530, Punnaiah Choudary Kalluri wrote: > Add driver for arm pl353 static memory controller. This

Re: [PATCH] mtd: fsl_ifc_nand: use msecs_to_jiffies for time conversion

2015-04-05 Thread Brian Norris
On Fri, Mar 13, 2015 at 07:23:47AM -0400, Nicholas Mc Guire wrote: > This is only an API consolidation and should make things more readable > it replaces var * HZ / 1000 by msecs_to_jiffies(var) which helps readability > and also handles all corner-cases properly. > > Signed-off-by: Nicholas Mc Gu

Re: [PATCH 1/2] mtd: mtd_oobtest: Fix bitflip_limit usage in test case 3

2015-04-05 Thread Brian Norris
On Fri, Dec 05, 2014 at 05:18:39PM +0200, Roger Quadros wrote: > In test case 3, we set vary_offset to write at different > offsets and lengths in the OOB available area. We need to > do the bitflip_limit check while checking for 0xff outside the > OOB offset + length area that we didn't modify dur

Re: [PATCH v2] mtd: Make MTD tests cancelable

2015-04-05 Thread Brian Norris
On Sun, Mar 29, 2015 at 09:52:06PM +0200, Richard Weinberger wrote: > I always go nuts when I start an MTD test on a slow device > and have to wait forever until it finishes. As do I. As an additional measure, I'm tempted to add an 'ebcnt' parameter for some of the tests that don't have them, for

[GIT PULL] MTD updates for 4.1

2015-04-22 Thread Brian Norris
ack size mtd: clean up whitespace in linux/mtd/map.h Baruch Siach (1): mtd: nand: sunxi: fix generic nand binding reference Boris Brezillon (1): mtd: atmel_nand: check NFC busy flag by HSMC_SR instead of NFC cmd regs Brian Norris (17): Merge MTD updates into -next

Re: [PATCH 1/6] mtd: nand_bbt: drop unnecessary header

2015-04-22 Thread Brian Norris
On Thu, Apr 16, 2015 at 02:09:41AM +, Peter Pan 潘栋 (peterpandong) wrote: > > Signed-off-by: Brian Norris > Signed-off-by: Peter Pan Why are you just resending my patches? You could Ack/Reviewed-by/etc. instead... http://patchwork.ozlabs.org/patch/444604/ > --- > d

Re: [PATCH 2/6] mtd: diskonchip: don't call nand_scan_bbt() directly

2015-04-22 Thread Brian Norris
7;s refactor the BBT initialization code into a private 'late_init' > hook which handles all the private details. Note the usage of > NAND_SKIP_BBTSCAN, which allows us to defer the BBT scan until we've > prepared everything. > > Signed-off-by: Brian Norris > Signed-off-by:

Re: [PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-22 Thread Brian Norris
ff-by" or done something else? > Please let me know if this is OK or if you would like something changed. No problem. 'Suggested-by' seems appropriate to me. For the patch: Acked-by: Brian Norris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

[PATCH v2 0/5] AHCI and SATA PHY support for Broadcom STB SoCs

2015-04-22 Thread Brian Norris
SW frameworks want to use the hardware. Enjoy, Brian Brian Norris (5): Documentation: devicetree: add Broadcom SATA binding Documentation: devicetree: add Broadcom SATA PHY binding ata: add Broadcom AHCI SATA3 driver for STB chips phy: add Broadcom SATA3 PHY driver for Broadcom STB SoCs

[PATCH v2 2/5] Documentation: devicetree: add Broadcom SATA PHY binding

2015-04-22 Thread Brian Norris
For 28nm STB chips, based on BCM7445. Signed-off-by: Brian Norris --- v2: - make each subnode into a provider, so we can use direct phandle references to them - drop the 'port-ctrl' register range, since this was shared with the SATA node .../bindings/phy/brcm,brcmstb-sa

[PATCH v2 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips

2015-04-22 Thread Brian Norris
Pretty straightforward driver, using the nice library-ization of the generic ahci_platform driver. Signed-off-by: Brian Norris --- v2: - move port enabling into this driver, since the affected registers are in the SATA_TOP_CTRL block. This means we need to check for the implemented

[PATCH v2 1/5] Documentation: devicetree: add Broadcom SATA binding

2015-04-22 Thread Brian Norris
Signed-off-by: Brian Norris --- v2: no change .../devicetree/bindings/ata/brcm,sata-brcmstb.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcmstb.txt diff --git a/Documentation/devicetree/bindings/ata/brcm

[PATCH v2 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY

2015-04-22 Thread Brian Norris
Signed-off-by: Brian Norris --- v2: - fix up some typos - account for binding changes in previous patches arch/arm/boot/dts/bcm7445.dtsi | 37 + 1 file changed, 37 insertions(+) diff --git a/arch/arm/boot/dts/bcm7445.dtsi b/arch/arm/boot/dts/bcm7445.dtsi

[PATCH v2 4/5] phy: add Broadcom SATA3 PHY driver for Broadcom STB SoCs

2015-04-22 Thread Brian Norris
Supports up to two ports which can each be powered on/off and configured independently. Signed-off-by: Brian Norris --- v2: - stop sharing SATA_TOP_CTRL registers with SATA driver - kill custom xlate function drivers/phy/Kconfig| 9 ++ drivers/phy/Makefile | 1

<    1   2   3   4   5   6   7   8   9   10   >