Re: [PATCH v6 0/3] Mediatek SPI-NOR flash driver

Hi Bayi, On Fri, Nov 06, 2015 at 11:48:06PM +0800, Bayi Cheng wrote: > This series is based on v4.3-rc1 and l2-mtd.git [0] and erase_sector > implementation patch [1] > > [0]: git://git.infradead.org/l2-mtd.git > [1]: http://lists.infradead.org/pipermail/linux-mtd/2015-October//062959.html > >

spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

(Changing subject line, because apparently some people ignore mail if it doesn't have 'SPI' in the subject line) On Thu, Nov 12, 2015 at 10:59:26AM -0800, Brian Norris wrote: > + others > > On Sat, Oct 03, 2015 at 11:54:16PM +0200, Heiner Kallweit wrote: > > Se

Re: [PATCH v6 1/3] doc: dt: add documentation for Mediatek spi-nor controller

On Fri, Nov 13, 2015 at 03:20:45PM +0800, Bayi Cheng wrote: > On Wed, 2015-11-11 at 12:38 -0800, Brian Norris wrote: > > Applied to l2-mtd.git/next (for 4.5). This will show up in > > linux-next.git after the merge window. > > > > Also squashed in a small diff (belo

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

Hi Mark, On Fri, Nov 13, 2015 at 10:12:28PM +, Mark Brown wrote: > On Fri, Nov 13, 2015 at 11:40:31AM -0800, Brian Norris wrote: > > > (Changing subject line, because apparently some people ignore mail if it > > doesn't have 'SPI' in the subject line) > > Well, if

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

Hi, On Fri, Nov 13, 2015 at 11:14:10PM +, Mark Brown wrote: > On Fri, Nov 13, 2015 at 02:51:13PM -0800, Brian Norris wrote: > > > General problem: > > > > > The SPI core doesn't use the OF compatible property for generating > > uevent/modal

Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference

On Thu, Nov 12, 2015 at 09:19:09AM +0100, Uwe Kleine-König wrote: > I really wonder there is no helper > function like: > > #define of_sensible_name(dev) > of_match_device(dev->driver->of_match_table, dev) How about of_device_get_match_data()? It's not exactly what you asked for, but

[PATCH] mtd: fsl-quadspi: possible NULL reference

It is theoretically possible to probe this driver without a matching device tree, so let's guard against this. Also, use the of_device_get_match_data() helper to make this a bit simpler. Coverity complained about this one. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc:

[PATCH v2] mtd: fsl-quadspi: possible NULL dereference

It is theoretically possible to probe this driver without a matching device tree, so let's guard against this. Also, use the of_device_get_match_data() helper to make this a bit simpler. Coverity complained about this one. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc:

[BUG] checkpatch: false positive for commits with quote characters

Hi, What is the Blessed (TM) style for referencing commits that have quote characters in their subject line? e.g., this commit: commit 43163022927b6e7d202a7e6f939c3f392465494d Author: Brian Norris <computersforpe...@gmail.com> Date: Tue May 19 14:38:22 2015 -0700 mtd: m25p80:

[PATCH 3/3] doc: dt: mtd: stop referring to driver code for spi-nor IDs

e hardware, not software. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc: <devicet...@vger.kernel.org> --- .../devicetree/bindings/mtd/jedec,spi-nor.txt | 56 -- 1 file changed, 51 insertions(+), 5 deletions(-) diff --git a/Documentation/devicet

Re: spi: OF module autoloading is still broken

Hi Javier, On Mon, Nov 16, 2015 at 06:32:22PM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 05:47 PM, Brian Norris wrote: > > On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: > >> Now that I think about it, there is another issue and is

[PATCH 0/3] mtd: m25p80: fix some module and documentation issues

/lists.infradead.org/pipermail/linux-mtd/2015-October/062369.html https://lkml.org/lkml/2015/11/12/574 That thread covers some other interesting issues that are still not solved, but let's fix the ones we can here in MTD right now. Regards, Brian Brian Norris (3): mtd: m25p80: fix module autolo

[PATCH 1/3] mtd: m25p80: fix module autoloading for "jedec,spi-nor" and "spi-nor"

iny-new-device", "jedec,spi-nor"; ... }; unless we also list "shiny-new-device" in m25p_ids[]. There has been discussion on future work for this issue here: https://lkml.org/lkml/2015/11/12/574 Cc: Heiner Kallweit <hkallwe...@gmail.com> Signe

[PATCH 2/3] mtd: m25p80: replace leftover "nor-jedec" with "spi-nor" in comments

I overlooked a few comments in commit 8947e396a829 ("Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor""). Fix these up now. Suggested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Signed-off-by: Brian Norris <computersforpe

Re: spi: OF module autoloading is still broken

Hi Javier, On Mon, Nov 16, 2015 at 02:19:27PM -0300, Javier Martinez Canillas wrote: > On 11/13/2015 08:48 PM, Brian Norris wrote: > > On Fri, Nov 13, 2015 at 11:14:10PM +, Mark Brown wrote: > >> On Fri, Nov 13, 2015 at 02:51:13PM -0800, Brian Norris wrote: > Doc

Re: spi: OF module autoloading is still broken

Hi, On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 04:24 PM, Brian Norris wrote: > I also didn't think about wilcards... I wonder why there are trailing > wildcards for a compatible string. After all a compatible string should > define a p

Re: [PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode

+ bcm-kernel-feedback-list On Mon, Nov 16, 2015 at 10:05:39PM +, Simon Arlott wrote: > If an error occurs in flash above 4GB in PIO mode then the EXT_ADDR > registers will be set to the location of the error and never cleared. > > Reset them to 0 before reading. > > Signed-off-by: Simon

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Boris, On Mon, Nov 16, 2015 at 02:37:47PM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris

Re: [PATCH 18/27] mtd: nand: update mtd_to_nand()

On Mon, Nov 16, 2015 at 02:37:51PM +0100, Boris Brezillon wrote: > Now that all drivers are using the mtd instance embedded in the nand_chip Do you have a script that verifies this? I thought you did at some point, and it'd be nice to note it, so I can also use it to verify things once it gets

Re: [PATCH 1/7] phy: brcmstb-sata: add missing of_node_put

t; * return ...; > ) >... > } > // > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > > --- For this patch: Acked-by: Brian Norris <computersforpe...@gmail.com> > drivers/phy/phy-brcmstb-sata.c | 17 - >

Re: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support

On Mon, Nov 16, 2015 at 04:08:39AM +, Yao Yuan wrote: > It looks like easier to read, use and change. > Is it? It looks fine either way, IMO. > And David Woodhouse, Xu Han, Mark Brown > is there any other comments from you? FYI, Mark Brown doesn't really have much to do with this. Though he

Re: [PATCH v2 06/11] mtd: nand: drop unnecessary partition parser data

On Mon, Nov 02, 2015 at 01:00:01PM -0800, Brian Norris wrote: > On Sun, Nov 01, 2015 at 11:32:37PM +0100, Boris Brezillon wrote: > > On Fri, 30 Oct 2015 20:33:25 -0700 > > Brian Norris <computersforpe...@gmail.com> wrote: > > > [...] > > > diff --git a/dr

Re: [PATCH v2 09/11] mtd: drop unnecessary partition parser data

On Thu, Nov 05, 2015 at 09:49:30AM +0100, Boris Brezillon wrote: > On Fri, 30 Oct 2015 20:33:28 -0700 > Brian Norris <computersforpe...@gmail.com> wrote: > > > --- a/drivers/mtd/maps/lantiq-flash.c > > +++ b/drivers/mtd/maps/lantiq-flash.c > > @@ -110,7 +110,6 @@

Re: [PATCH v2 12/11] mtd: nand: convert to nand_get_flash_node()

On Mon, Nov 02, 2015 at 12:03:38AM +0100, Boris Brezillon wrote: > Used semantic patch with 'make coccicheck MODE=patch COCCI=script.cocci': > > ---8< > virtual patch > > @@ > struct nand_chip c; > struct nand_chip *cp; > @@ > ( > -(cp)->flash_node > +nand_get_flash_node(cp) > | >

Re: [PATCH v2 13/11] mtd: assign mtd->dev.of_node when creating partition devices

On Mon, Nov 02, 2015 at 01:38:41AM +0100, Boris Brezillon wrote: > MTD partitions may have been created from a DT definition, and in this case > the ->of_node of the struct device embedded in mtd_info should point to > the DT node that was used to create the partition. > > Signed-off-by: Boris

Re: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support

A few corrections for the record: On Fri, Oct 30, 2015 at 09:49:41AM +, Yao Yuan wrote: > Hi Fabio Estevam, > > Thanks for your suggestion. > We have an internal discussions for that. > > We think that: > According to the initial commit message of regmap, it is targeting > non-memory mapped

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

In addition to my other comments: On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: > In addition to providing direct access to SPI bus, some spi controller > hardwares (like ti-qspi) provide special memory mapped port > to accesses SPI flash devices in order to increase read

Re: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support

+ devicetree On Wed, Nov 11, 2015 at 11:51:13AM -0600, Han Xu wrote: > On Fri, Oct 30, 2015 at 04:49:41AM -0500, Yuan Yao-B46683 wrote: (BTW Yuan, replying on top doesn't make the conversation as easy to follow) > > Although it is possible to add the endianness support in the > > regmap_mmio

Re: [PATCH v6 2/3] mtd: mtk-nor: mtk serial flash controller driver

Hi Bayi, A few small comments. On Fri, Nov 06, 2015 at 11:48:08PM +0800, Bayi Cheng wrote: > add spi nor flash driver for mediatek controller > > Signed-off-by: Bayi Cheng > --- > drivers/mtd/spi-nor/Kconfig | 7 + > drivers/mtd/spi-nor/Makefile | 1 + >

Re: [PATCH v6 1/3] doc: dt: add documentation for Mediatek spi-nor controller

On Fri, Nov 06, 2015 at 11:48:07PM +0800, Bayi Cheng wrote: > Add device tree binding documentation for serial flash with > Mediatek serial flash controller > > Signed-off-by: Bayi Cheng > --- Applied to l2-mtd.git/next (for 4.5). This will show up in linux-next.git

Re: [PATCH] mtd: phram: error handling

Hi Saurabh, On Wed, Nov 11, 2015 at 01:53:58PM +0530, Saurabh Sengar wrote: > Brian Norris wrote: > > Well, today you're in luck! You're touching a driver that requires no > > special hardware, so you should be able to test it. > > > I think you can try using the me

Re: [PATCH v6 0/3] Mediatek SPI-NOR flash driver

On Wed, Nov 11, 2015 at 10:04:14PM +0800, Bayi Cheng wrote: > On Mon, 2015-11-09 at 18:46 -0800, Brian Norris wrote: > > I believe you didn't completely answer all my questions from v5 though. > > I'll repeat a bit here. Particularly, refer to [1]. > > I'll summarize; I unders

Re: [PATCH v6 3/3] arm64: dts: mt8173: Add nor flash node

On Fri, Nov 06, 2015 at 11:48:09PM +0800, Bayi Cheng wrote: > Add Mediatek nor flash node > > Signed-off-by: Bayi Cheng <bayi.ch...@mediatek.com> Acked-by: Brian Norris <computersforpe...@gmail.com> > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 +++

Re: [PATCH v6 2/3] mtd: mtk-nor: mtk serial flash controller driver

One more small comment, since you're respinning this: On Fri, Nov 06, 2015 at 11:48:08PM +0800, Bayi Cheng wrote: > diff --git a/drivers/mtd/spi-nor/mtk-quadspi.c > b/drivers/mtd/spi-nor/mtk-quadspi.c > new file mode 100644 > index 000..6582811 > --- /dev/null > +++

Re: [PATCH v2 01/11] mtd: add get/set of_node/flash_node helpers

On Fri, Oct 30, 2015 at 08:33:20PM -0700, Brian Norris wrote: > We are going to begin using the mtd->dev.of_node field for MTD device > nodes, so let's add helpers for it. Also, we'll be making some > conversions on spi_nor (and nand_chip eventually) too, so get that ready > with th

Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading

+ others On Sat, Oct 03, 2015 at 11:54:16PM +0200, Heiner Kallweit wrote: > Seems like commit 43163022927b6e7d202a7e6f939c3f392465494d > (allow arbitrary OF matching for "jedec,spi-nor") broke autoloading > of the m25p80 module. > MODALIAS is "spi:spi-nor" and removing "spi-nor" as device alias >

Re: [PATCH 1/7] phy: brcmstb-sata: add missing of_node_put

On Tue, Nov 17, 2015 at 06:48:39PM +0100, Julia Lawall wrote: > On Tue, 17 Nov 2015, Brian Norris wrote: > > On Tue, Nov 17, 2015 at 07:12:22AM +0100, Julia Lawall wrote: > > > On Mon, 16 Nov 2015, Brian Norris wrote: > > > > diff --git a/drivers/phy/phy-c

Re: [PATCH 1/7] phy: brcmstb-sata: add missing of_node_put

On Tue, Nov 17, 2015 at 10:30:36AM -0800, Brian Norris wrote: > I expect the same sort of problem shows up plenty of other places. I > don't think many people use CONFIG_OF_DYNAMIC, so the effects of these > failures probably aren't felt by many. Also, there's a quite-relevant

Re: [PATCH 1/7] phy: brcmstb-sata: add missing of_node_put

On Tue, Nov 17, 2015 at 07:12:22AM +0100, Julia Lawall wrote: > On Mon, 16 Nov 2015, Brian Norris wrote: > > > > This reminds me of a potential problem I'm looking at in other > > subsystems: from code reading (I haven't seen any issues in practice, > > probably bec

Re: [PATCH] brcmnand: Clear EXT_ADDR error registers in PIO mode

On Tue, Nov 17, 2015 at 07:41:21AM +, Simon Arlott wrote: > On 17/11/15 00:40, Brian Norris wrote: > > + bcm-kernel-feedback-list > > > > On Mon, Nov 16, 2015 at 10:05:39PM +, Simon Arlott wrote: > >> If an error occurs in flash above 4GB in PIO mode th

Re: [BUG] checkpatch: false positive for commits with quote characters

On Tue, Nov 17, 2015 at 09:48:27AM -0800, Joe Perches wrote: > On Mon, 2015-11-16 at 14:43 -0800, Brian Norris wrote: > > Hi, > > > > What is the Blessed (TM) style for referencing commits that have quote > > characters in their subject line? e.g., t

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

Hi, On Tue, Nov 17, 2015 at 12:02:29PM +0530, Vignesh R wrote: > On 11/13/2015 09:35 PM, Cyrille Pitchen wrote: > > > > In September I've sent a series of patches to enhance the support of QSPI > > flash > > memories. Patch 4 was dedicated to the m25p80 driver and set the > > rx_nbits /

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

Hi, On Wed, Nov 11, 2015 at 12:20:46PM +0530, R, Vignesh wrote: > On 11/11/2015 4:53 AM, Brian Norris wrote: > > On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: > >> diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h > >> index cce80e6d

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

Hi Vignesh, Sorry for the late review. I did not have time to review much back when you submitted your first RFCs for this. On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: > diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h > index cce80e6dc7d1..2f2c431b8917 100644 > ---

Re: [PATCH v5 2/3] mtd: mtk-nor: mtk serial flash controller driver

Hi Bayi, (I drafted most of this before you clarified on how to read out 6 bytes of ID. So a bit of this is slightly out-of-date. Still, I think most of the comments and much of the appended patch should be useful to you.) On Mon, Oct 26, 2015 at 09:40:38PM +0800, Bayi Cheng wrote: > add spi nor

Re: [PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

Hi Bayi, On Fri, Oct 30, 2015 at 10:12:39AM +0800, bayi.cheng wrote: > Hi Brian, The current station is as follows. > > 1: put 0x9F to MTK_NOR_PRGDATA5_REG, and five 0x0 to > MTK_NOR_PRGDATA4_REG ~ MTK_NOR_PRGDATA0_REG, then set (1 + 5) * 8 > to MTK_NOR_CNT_REG, for this way, we can read five

Re: Problems with 'mtd: warn when registering the same master many times'

On Mon, Nov 02, 2015 at 07:41:48AM -0800, Guenter Roeck wrote: > Brian, > > I see the following warnings in recent mips qemu tests on linux-next. > > WARNING: CPU: 0 PID: 1 at drivers/mtd/mtdcore.c:619 > mtd_device_parse_register+0x160/0x16c() > MTD already registered > > Looking into the

Re: [PATCH] mtd: blkdevs: fix potential deadlock + lockdep warnings

On Mon, Oct 26, 2015 at 07:38:49PM -0700, Brian Norris wrote: > Commit 073db4a51ee4 ("mtd: fix: avoid race condition when accessing > mtd->usecount") fixed a race condition but due to poor ordering of the > mutex acquisition, introduced a potential deadlock. [...] > &g

[PATCH v2 08/11] mtd: spi-nor: drop flash_node field

We can just alias to the MTD of_node. Signed-off-by: Brian Norris <computersforpe...@gmail.com> --- v2: new drivers/mtd/spi-nor/spi-nor.c | 1 - include/linux/mtd/spi-nor.h | 6 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drive

[PATCH v2 10/11] mtd: ofpart: drop 'of_node' partition parser data

This field is no longer used anywhere, as it is superseded by mtd->dev.of_node. Signed-off-by: Brian Norris <computersforpe...@gmail.com> --- v2: use new helpers drivers/mtd/ofpart.c | 14 -- include/linux/mtd/partitions.h | 4 2 files changed, 4 insertio

[PATCH v2 11/11] mtd: physmap_of: assign parent for the concatenated MTD

-by: Brian Norris <computersforpe...@gmail.com> --- v2: lumped into this series, since its context depends on this series drivers/mtd/maps/physmap_of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c index b78265688075..70c453

[PATCH v2 02/11] mtd: ofpart: grab device tree node directly from master device node

ecates the parser data 'of_node' field Driver conversions may now follow. Additional side benefit to assigning mtd->dev.of_node rather than using parser data: the driver core will automatically create a device -> node symlink for us. Signed-off-by: Brian Norris <computersforpe...@gm

[PATCH v2 05/11] mtd: spi-nor: convert to spi_nor_{get,set}_flash_node()

a manual conversion for the one use of spi_nor_get_flash_node(). Signed-off-by: Brian Norris <computersforpe...@gmail.com> --- v2: new drivers/mtd/devices/m25p80.c | 2 +- drivers/mtd/spi-nor/fsl-quadspi.c | 2 +- drivers/mtd/spi-nor/nxp-spifi.c | 2 +- drivers/mtd/spi-nor/spi-nor.c

[PATCH v2 09/11] mtd: drop unnecessary partition parser data

-by: Brian Norris <computersforpe...@gmail.com> --- v2: use new helpers drivers/mtd/devices/mtd_dataflash.c | 5 ++--- drivers/mtd/devices/spear_smi.c | 6 ++ drivers/mtd/devices/st_spi_fsm.c| 5 ++--- drivers/mtd/maps/lantiq-flash.c | 5 ++--- drivers/mtd/maps/physma

[PATCH v2 00/11] mtd: migrate 'of_node' handling to core, not in mtd_part_parser_data

obably convert anyway. So, please test your favorite driver! v1 -> v2: * add helper functions for getting/setting the MTD/SPI-NOR/NAND DT node * fix some build errors * drop spi_nor's flash_node field (just use the MTD of_node) Regards, Brian Brian Norris (11): mtd: add get/set of_node/f

Re: [PATCH v3 5/5] mtd: ofpart: move ofpart partitions to a dedicated dt node

On Tue, Aug 18, 2015 at 03:34:09PM -, Michal Suchanek wrote: > Parsing direct subnodes of a mtd device as partitions is unreliable > since the mtd device is also part of its bus subsystem and can contain > bus data in subnodes. > > Move ofpart data to a subnode of its own so it is clear which

[PATCH v2 06/11] mtd: nand: drop unnecessary partition parser data

for us, but for now, I don't want to fiddle with each of these drivers. The parsing is done in duplicate for now on some drivers. I don't think this should break things. (Famous last words.) Signed-off-by: Brian Norris <computersforpe...@gmail.com> Acked-by: Boris Brezillon <boris.brezil...@fre

[PATCH v2 07/11] mtd: spi-nor: drop unnecessary partition parser data

Now that the SPI-NOR/MTD framework pass the 'flash_node' through to the partition parsing code, we don't have to do it ourselves. Also convert to mtd_device_register(), since we don't need the 2nd and 3rd parameters anymore. Signed-off-by: Brian Norris <computersforpe...@gmail.com>

[PATCH v2 03/11] mtd: {nand,spi-nor}: assign MTD of_node

We should pass along our flash DT node to the MTD layer, so it can set up ofpart for us. Signed-off-by: Brian Norris <computersforpe...@gmail.com> --- v2: split out of the previous patch drivers/mtd/nand/nand_base.c | 3 +++ drivers/mtd/spi-nor/spi-nor.c | 1 + 2 files changed, 4 inse

[PATCH v2 01/11] mtd: add get/set of_node/flash_node helpers

We are going to begin using the mtd->dev.of_node field for MTD device nodes, so let's add helpers for it. Also, we'll be making some conversions on spi_nor (and nand_chip eventually) too, so get that ready with their own helpers. Signed-off-by: Brian Norris <computersforpe...@gmail.com&g

[PATCH v2 04/11] mtd: nand: convert to nand_set_flash_node()

Used semantic patch with 'make coccicheck MODE=patch COCCI=script.cocci': ---8< virtual patch @@ struct nand_chip *c; struct device_node *d; @@ -(c)->flash_node = (d) +nand_set_flash_node(c, d) ---8< Signed-off-by: Brian Norris <computersforpe...@gmail.com> --- v2: ne

Re: [PATCH v2 3/4] get_maintainer: add --no-foo options to --help

On Wed, Nov 04, 2015 at 11:48:44AM -0800, Joe Perches wrote: > On Wed, 2015-11-04 at 11:28 -0800, Brian Norris wrote: > > Many flag options are boolean and support both a positive and a negative > > invocation from the command line. Some of these are even mentioned by > > e

Re: [PATCH v2 3/4] get_maintainer: add --no-foo options to --help

On Wed, Nov 04, 2015 at 11:48:44AM -0800, Joe Perches wrote: > Most options have both positive and negative forms. > The negative forms for -- are --no and --no-. I just noticed you included both --no and --no-. I didn't even notice that Perl supported both variants here. Good thing the clueless

[PATCH v3 4/4] get_maintainer: --r (list reviewer) is on by default

We don't consistenly document the default value next to the option listing, but we do have a list of defaults here, so let's keep it up to date. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Joe Perches <j...@perches.co

[PATCH v3 2/4] get_maintainer: it's '--pattern-depth', not '-pattern-depth'

Though it appears that Perl's GetOptions will take either, the latter is not documented in the options listing. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Joe Perches <j...@perches.com> --- v2 -> v3: * no ch

[PATCH v3 1/4] get_maintainer: add missing documentation for --git-blame-signatures

I really haven't used this option much myself, so feel free to improve on the documentation for it. I just noticed it while inspecting this script for undocumented features. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Jo

[PATCH v3 3/4] get_maintainer: add --no-foo options to --help

of these are pretty important, as they are default-on, and to turn them off, you have to know about the --no-foo version. Rather than clutter the whole help text with bracketed '--[no]foo', let's just mention the general rule, a la 'man gcc'. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc:

[PATCH v2 1/4] get_maintainer: add missing documentation for --git-blame-signatures

I really haven't used this option much myself, so feel free to improve on the documentation for it. I just noticed it while inspecting this script for undocumented features. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Jo

[PATCH v2 3/4] get_maintainer: add --no-foo options to --help

of these are pretty important, as they are default-on, and to turn them off, you have to know about the --no-foo version. Rather than clutter the whole help text with bracketed '--[no]foo', let's just mention the general rule, a la 'man gcc'. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc:

[PATCH v2 4/4] get_maintainer: --r (list reviewer) is on by default

We don't consistenly document the default value next to the option listing, but we do have a list of defaults here, so let's keep it up to date. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Joe Perches <j...@perches.com

[PATCH v2 2/4] get_maintainer: it's '--pattern-depth', not '-pattern-depth'

Though it appears that Perl's GetOptions will take either, the latter is not documented in the options listing. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Joe Perches <j...@perches.com> --- new in v2 scripts/get

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

Hi Yakir, On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote: > On 11/03/2015 12:38 PM, Brian Norris wrote: > >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > >(FYI, I came across this by inspection when comparing Heiko's > >'somewhat-stable' branch

Re: [PATCH] mtd: Make MTD_BCM47XXSFLASH to depend on MIPS

On Wed, Nov 04, 2015 at 10:04:26AM +0100, Rafał Miłecki wrote: > On 14 October 2015 at 11:04, Javier Martinez Canillas > wrote: > > The bcm47xxsflash driver uses the KSEG0ADDR() function to map an address > > to a certain kernel segment. But that is only defined if the

Re: [PATCH v2 06/11] mtd: nand: drop unnecessary partition parser data

On Sun, Nov 01, 2015 at 11:32:37PM +0100, Boris Brezillon wrote: > On Fri, 30 Oct 2015 20:33:25 -0700 > Brian Norris <computersforpe...@gmail.com> wrote: > [...] > > diff --git a/drivers/mtd/nand/fsl_elbc_nand.c > > b/drivers/mtd/nand/fsl_elbc_nand.c > > index

Re: [PATCH v2 01/11] mtd: add get/set of_node/flash_node helpers

On Mon, Nov 02, 2015 at 12:27:58AM +0100, Boris Brezillon wrote: > On Fri, 30 Oct 2015 20:33:20 -0700 > Brian Norris <computersforpe...@gmail.com> wrote: > > > We are going to begin using the mtd->dev.of_node field for MTD device > > nodes, so let's add helpers for

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

Hi Yakir, On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > Add phy driver for the Rockchip DisplayPort PHY module. This > is required to get DisplayPort working in Rockchip SoCs. > > Reviewed-by: Heiko Stuebner > Signed-off-by: Yakir Yang >

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

Hi, A few updates: On Tue, Nov 03, 2015 at 05:13:48PM -0800, Brian Norris wrote: > On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote: > > On 11/03/2015 12:38 PM, Brian Norris wrote: > > >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > &

[GIT PULL] MTD updates for 4.4-rc1

ods mtd: nand: sunxi: fix sunxi_nfc_hw_ecc_read/write_chunk() mtd: nand: sunxi: avoid retrieving data before ECC pass Brian Norris (39): mtd: spi-nor: assign mtd->priv in spi_nor_scan() mtd: spi-nor: add forward declaration for mtd_info mtd: spi-nor: embed struct

Re: [PATCH v5 0/3] NAND support for Broadcom NS2 SoC

On Fri, Oct 30, 2015 at 12:29:18PM +0530, Anup Patel wrote: > We enable NAND support for Broadcom NS2 SoC by reusing existing > BRCMNAND driver. > > This patchset applies on-top of "arm64: Simple additions to > NS2 DT" v1 patchset and is available in ns2_nand_v5 branch of >

Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2

On Wed, Oct 28, 2015 at 09:08:02AM -0700, Ray Jui wrote: > On 10/28/2015 2:06 AM, Anup Patel wrote: > > > >I think for a newly created OF devices the Linux device driver framework will > >match the platform drivers in the order in which they are registered by > >module > >init functions. Now the

Re: [PATCH v5 2/3] mtd: mtk-nor: mtk serial flash controller driver

Hi Bayi, In reviewing your updated instructions on how to read 6 bytes of ID, I have one more question about how the PRGDATA and SHREG registers are supposed to work. On Mon, Oct 26, 2015 at 09:40:38PM +0800, Bayi Cheng wrote: [...] > +static void mt8173_nor_set_read_mode(struct mt8173_nor

Re: [PATCH v2 09/11] mtd: drop unnecessary partition parser data

On Sat, Oct 31, 2015 at 04:26:32PM +0100, Marek Vasut wrote: > On Saturday, October 31, 2015 at 04:33:28 AM, Brian Norris wrote: > > - mtd_device_parse_register(info->cmtd, part_probe_types, , > > + mtd_device_parse_register(info->cmtd, part_probe_types, NULL, >

Re: [PATCH v5 2/3] mtd: brcmnand: Force 8bit mode before doing nand_scan_ident()

rop the upper 8 bits. That's what these two commits did for read ID and parameter page read commands: commit 3dad2344e92c6e1aeae42df1c4824f307c51bcc7 Author: Brian Norris <computersforpe...@gmail.com> Date: Wed Jan 29 14:08:12 2014 -0800 mtd: nand: force NAND_CMD_READID onto 8-bit bu

Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64

On Fri, Oct 16, 2015 at 06:24:21PM +0200, Arnd Bergmann wrote: > I think you also need this one: Are you sure? > 8<--- > From 0ab7b2d32921b3f3da15274d8c3982ba1d54660f Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann > Date: Thu, 4 Jun 2015 09:25:59 +0200 > Subject: [PATCH]

Re: [PATCH] mtd: Make MTD_BCM47XXSFLASH to depend on MIPS

+ Rafał On Wed, Oct 14, 2015 at 11:04:54AM +0200, Javier Martinez Canillas wrote: > The bcm47xxsflash driver uses the KSEG0ADDR() function to map an address > to a certain kernel segment. But that is only defined if the MIPS config > symbol is enabled. The driver does not have an explicit

Re: [PATCH 1/2] get_maintainer: add --no-foo options to --help

+ akpm On Wed, Oct 14, 2015 at 10:15:31AM -0700, Joe Perches wrote: > On Wed, 2015-10-14 at 10:10 -0700, Brian Norris wrote: > > Ping? Should I resend? > > I don't have a strong opinion about this. > > It seems the [no] blocks make the generic options mor

Re: [PATCH 1/2] get_maintainer: add --no-foo options to --help

Ping? Should I resend? On Wed, Aug 19, 2015 at 03:09:39PM -0700, Brian Norris wrote: > Many flag options are boolean and support both a positive and a negative > invocation from the command line. Some of these are even mentioned by > example (e.g., --nogit is mentioned as a defau

Re: [PATCH v4 1/3] doc: dt: add documentation for Mediatek spi-nor controller

Hi Bayi, On Tue, Oct 13, 2015 at 05:39:18PM +0800, Bayi Cheng wrote: > Add device tree binding documentation for serial flash with > Mediatek serial flash controller > > Signed-off-by: Bayi Cheng > --- > .../devicetree/bindings/mtd/mtk-quadspi.txt| 30 >

Re: [PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

Hi Bayi, On Tue, Oct 13, 2015 at 05:39:19PM +0800, Bayi Cheng wrote: > add spi nor flash driver for mediatek controller > > Signed-off-by: Bayi Cheng > --- > drivers/mtd/spi-nor/Kconfig | 7 + > drivers/mtd/spi-nor/Makefile | 1 + >

Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64

On Fri, Oct 16, 2015 at 08:36:58AM -0700, Ray Jui wrote: > This patch is the same. I thought it has already been merged by Brian? Right as well. I'll ignore this one. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v2 1/4] mtd: brcmnand: Fix pointer type-cast in brcmnand_write()

On Fri, Oct 16, 2015 at 08:36:22AM -0700, Ray Jui wrote: > Correct me if I remember it wrong, but I thought this patch has already > been merged by Brian? You are correct. Anup, Please base MTD patches on the MTD development tree (i.e., l2-mtd.git): http://linux-mtd.infradead.org/source.html

Re: [PATCH v4 1/5] mtd: nand: Create a BBT flag to access bad block markers in raw mode

Hi Boris, On Fri, Oct 02, 2015 at 08:27:38AM +0200, Boris Brezillon wrote: > Brian, Archit, > > On Thu, 1 Oct 2015 19:44:34 -0700 > Brian Norris <computersforpe...@gmail.com> wrote: > > > On Wed, Aug 19, 2015 at 10:19:02AM +0530, Archit Taneja wrote: > &

Re: [PATCH v3 2/5] mtd: mtdpart: Do not fail mtd probe when parsing partitions fails.

t; + return 0; > } > > int mtd_is_partition(const struct mtd_info *mtd) All in all, I think my suggestions would look something like the following alternative patch. I haven't tested it yet. Brian (git-format-patch pasted below) >From 53b60f31a2a0f2a7e8220a4aff47457248bccbcf Mon S

Re: [PATCH v3 4/5] mtd: ofpart: document the lock flag.

On Tue, Aug 18, 2015 at 03:34:08PM -, Michal Suchanek wrote: > The lock flag of ofpart is undocumented. Add to binding doc. Good catch. There are a lot of small corners of very old code that never really got reviewed properly, I expect... (And the flag looks very odd. Why exactly is it in

Re: [PATCH v3 3/5] mtd: ofpart: update devicetree binding specification

Hi DT maintainers, It's a bit hypocritical of me, since I've been a slow reviewer as well, but... can we get some review on this one? Usually, I'm comfortable taking driver DT bindings without your review, but this one is a bit more generic and is more far-reaching than the average driver. I'm

Re: [PATCH v3 1/5] mtd: mtdpart: add debug prints to partition parser.

On Tue, Aug 18, 2015 at 03:34:07PM -, Michal Suchanek wrote: > The probe of a mtd device can fail when a partition parser returns > error. The failure due to partition parsing can be quite mysterious when > multiple partitioning schemes are comiled in and any of them can fail > the probe. > >

Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap

ion for deprecating ioremap_cache() convert its usage in > pxa2xx-flash to memremap. > > Cc: David Woodhouse <dw...@infradead.org> > Cc: Brian Norris <computersforpe...@gmail.com> > [brian: also convert iounmap to memunmap] > Signed-off-by: Dan Williams <dan.j.will

Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap

On Mon, Oct 12, 2015 at 10:58:03AM -0700, Brian Norris wrote: > You missed linux-mtd again. Please use scripts/get_maintainer.pl next > time to at least get the relevant mailing list(s). (The individual CC's > are not always necessary, but the subsystem lists definitely are.) Anyway, pus

Re: [PATCH 1/5] mtd: brcmnand: Fix pointer type-cast in brcmnand_write()

On Fri, Oct 02, 2015 at 11:26:42PM +0530, Anup Patel wrote: > We should always type-cast pointer to "long" or "unsigned long" > because size of pointer is same as machine word size. This will > avoid pointer type-cast issues on both 32bit and 64bit systems. > > This patch fixes pointer type-cast

Re: [PATCH] mtd: Add simple read disturb test

Resurrecting this old thread, since it was mentioned at ELCE. On Sun, Apr 12, 2015 at 09:31:20PM +0200, Boris Brezillon wrote: > On Thu, 02 Apr 2015 18:18:34 +0200 > Richard Weinberger <rich...@nod.at> wrote: > > Am 02.04.2015 um 18:04 schrieb Brian Norris: > > > On

<    5   6   7   8   9   10   11   12   13   14   >