[PATCH v2 2/2] hp-wmi: Fix detection for dock and tablet mode

2017-04-19 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> The current driver code is not checking for the error values returned by 'hp_wmi_dock_state()' and 'hp_wmi_tablet_state()' before passing the returned values down to 'input_report_switch()'. This error code is being translated to '1' in the input sub

[PATCH v2 2/2] hp-wmi: Fix detection for dock and tablet mode

2017-04-19 Thread Carlo Caione
From: Carlo Caione The current driver code is not checking for the error values returned by 'hp_wmi_dock_state()' and 'hp_wmi_tablet_state()' before passing the returned values down to 'input_report_switch()'. This error code is being translated to '1' in the input subsystem, reporting the wrong

Re: [PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state

2017-04-19 Thread Carlo Caione
On Wed, Apr 19, 2017 at 6:21 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Sun, Apr 9, 2017 at 4:56 PM, Carlo Caione <ca...@caione.org> wrote: >> From: Carlo Caione <ca...@endlessm.com> >> >> hp_wmi_tablet_state() fails to return the correct

Re: [PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state

2017-04-19 Thread Carlo Caione
On Wed, Apr 19, 2017 at 6:21 PM, Andy Shevchenko wrote: > On Sun, Apr 9, 2017 at 4:56 PM, Carlo Caione wrote: >> From: Carlo Caione >> >> hp_wmi_tablet_state() fails to return the correct error code when >> hp_wmi_perform_query() returns the HP WM

Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode

2017-04-13 Thread Carlo Caione
On Thu, Apr 13, 2017 at 8:21 PM, Darren Hart <dvh...@infradead.org> wrote: > On Sun, Apr 09, 2017 at 03:56:08PM +0200, Carlo Caione wrote: >> From: Carlo Caione <ca...@endlessm.com> /cut >> @@ -644,6 +646,7 @@ static int __init hp_wmi_input_setup(void) >&g

Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode

2017-04-13 Thread Carlo Caione
On Thu, Apr 13, 2017 at 8:21 PM, Darren Hart wrote: > On Sun, Apr 09, 2017 at 03:56:08PM +0200, Carlo Caione wrote: >> From: Carlo Caione /cut >> @@ -644,6 +646,7 @@ static int __init hp_wmi_input_setup(void) >> { >> acpi_status status; >>

Re: [PATCH 0/2] hp-wmi: Fix dock status and tablet mode reporting

2017-04-13 Thread Carlo Caione
On Sun, Apr 9, 2017 at 3:56 PM, Carlo Caione <ca...@caione.org> wrote: > From: Carlo Caione <ca...@endlessm.com> > > Several HP laptops cannot be put to sleep using the LID since systemd > complains > that the system is docked even though the laptop is

Re: [PATCH 0/2] hp-wmi: Fix dock status and tablet mode reporting

2017-04-13 Thread Carlo Caione
On Sun, Apr 9, 2017 at 3:56 PM, Carlo Caione wrote: > From: Carlo Caione > > Several HP laptops cannot be put to sleep using the LID since systemd > complains > that the system is docked even though the laptop is not even dockable (see > [1]). > > This is due to a bug in

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Carlo Caione
On Wed, Apr 12, 2017 at 10:12 PM, Jiri Kosina <ji...@kernel.org> wrote: > On Wed, 12 Apr 2017, Carlo Caione wrote: > >> >> + ret = devm_led_classdev_register(>dev, >> >> >kbd_backlight->cdev); >> >> + if (ret < 0

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Carlo Caione
On Wed, Apr 12, 2017 at 10:12 PM, Jiri Kosina wrote: > On Wed, 12 Apr 2017, Carlo Caione wrote: > >> >> + ret = devm_led_classdev_register(>dev, >> >> >kbd_backlight->cdev); >> >> + if (ret < 0) { >> >> + /* N

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Carlo Caione
On Mon, Apr 10, 2017 at 8:39 AM, Benjamin Tissoires <benjamin.tissoi...@redhat.com> wrote: > On Apr 06 2017 or thereabouts, Carlo Caione wrote: >> + ret = devm_led_classdev_register(>dev, >> >kbd_backlight->cdev); >> + if (ret < 0) { >> +

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Carlo Caione
On Mon, Apr 10, 2017 at 8:39 AM, Benjamin Tissoires wrote: > On Apr 06 2017 or thereabouts, Carlo Caione wrote: >> + ret = devm_led_classdev_register(>dev, >> >kbd_backlight->cdev); >> + if (ret < 0) { >> + /* No need to have this stil

[PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode

2017-04-09 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> The current driver code is not checking for the error values returned by 'hp_wmi_dock_state()' and 'hp_wmi_tablet_state()' before passing the returned values down to 'input_report_switch()'. This error code is being translated to '1' in the input sub

[PATCH 0/2] hp-wmi: Fix dock status and tablet mode reporting

2017-04-09 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Several HP laptops cannot be put to sleep using the LID since systemd complains that the system is docked even though the laptop is not even dockable (see [1]). This is due to a bug in hp-wmi where the driver is failing to check for errors before cr

[PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode

2017-04-09 Thread Carlo Caione
From: Carlo Caione The current driver code is not checking for the error values returned by 'hp_wmi_dock_state()' and 'hp_wmi_tablet_state()' before passing the returned values down to 'input_report_switch()'. This error code is being translated to '1' in the input subsystem, reporting the wrong

[PATCH 0/2] hp-wmi: Fix dock status and tablet mode reporting

2017-04-09 Thread Carlo Caione
From: Carlo Caione Several HP laptops cannot be put to sleep using the LID since systemd complains that the system is docked even though the laptop is not even dockable (see [1]). This is due to a bug in hp-wmi where the driver is failing to check for errors before creating the input switches

[PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state

2017-04-09 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> hp_wmi_tablet_state() fails to return the correct error code when hp_wmi_perform_query() returns the HP WMI query specific error code that is a positive value. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- drivers/platform/x86/hp-wmi

[PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state

2017-04-09 Thread Carlo Caione
From: Carlo Caione hp_wmi_tablet_state() fails to return the correct error code when hp_wmi_perform_query() returns the HP WMI query specific error code that is a positive value. Signed-off-by: Carlo Caione --- drivers/platform/x86/hp-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-06 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> The latest USB keyboards shipped on several ASUS laptop models (including ROG laptop models such as GL702VMK) have the keyboards backlight controlled by the keyboard firmware. The firmware implements at least 3 different commands: - Init command (

[PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-06 Thread Carlo Caione
From: Carlo Caione The latest USB keyboards shipped on several ASUS laptop models (including ROG laptop models such as GL702VMK) have the keyboards backlight controlled by the keyboard firmware. The firmware implements at least 3 different commands: - Init command (to use when the system starts

Re: [PATCH v2] HID: asus: support backlight on USB keyboards

2017-04-06 Thread Carlo Caione
struct asus_drvdata *drvdata = hid_get_drvdata(hdev); >> + >> + if (drvdata->kbd_backlight) >> + drvdata->kbd_backlight->removed = true; > > Add a cancel_work_sync() here too to terminate currently working > workers. Bonus point, you don't need the mutex if you call > cancel_work_sync(). I'll do. Thanks for the quick review. -- Carlo Caione | +39.340.80.30.096 | Endless

Re: [PATCH v2] HID: asus: support backlight on USB keyboards

2017-04-06 Thread Carlo Caione
_get_drvdata(hdev); >> + >> + if (drvdata->kbd_backlight) >> + drvdata->kbd_backlight->removed = true; > > Add a cancel_work_sync() here too to terminate currently working > workers. Bonus point, you don't need the mutex if you call > cancel_work_sync(). I'll do. Thanks for the quick review. -- Carlo Caione | +39.340.80.30.096 | Endless

[PATCH v2] HID: asus: support backlight on USB keyboards

2017-04-05 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> The latest USB keyboards shipped on several ASUS laptop models (including ROG laptop models such as GL702VMK) have the keyboards backlight controlled by the keyboard firmware. The firmware implements at least 3 different commands: - Init command (

[PATCH v2] HID: asus: support backlight on USB keyboards

2017-04-05 Thread Carlo Caione
From: Carlo Caione The latest USB keyboards shipped on several ASUS laptop models (including ROG laptop models such as GL702VMK) have the keyboards backlight controlled by the keyboard firmware. The firmware implements at least 3 different commands: - Init command (to use when the system starts

Re: [PATCH] HID: asus: support backlight on USB keyboards

2017-04-05 Thread Carlo Caione
reate a useless (and probably confusing) sysfs entry for a non-existent backlight. Otherwise we could do the opposite if you agree: delete the QUIRK and just using this test to decide whether to create the led class or not. >> + >> + if (kbd_func & SUPPORT_BKD_BACKLIGHT) >> + asus_register_kbd_leds(hdev); > > Don't you need to check for the return value here? As written before, I guess if we fail to register the leds it's just ok to continue (given that we already printed the error message). Cheers, -- Carlo Caione | +39.340.80.30.096 | Endless

Re: [PATCH] HID: asus: support backlight on USB keyboards

2017-04-05 Thread Carlo Caione
ing) sysfs entry for a non-existent backlight. Otherwise we could do the opposite if you agree: delete the QUIRK and just using this test to decide whether to create the led class or not. >> + >> + if (kbd_func & SUPPORT_BKD_BACKLIGHT) >> + asus_register_kbd_leds(hdev); > > Don't you need to check for the return value here? As written before, I guess if we fail to register the leds it's just ok to continue (given that we already printed the error message). Cheers, -- Carlo Caione | +39.340.80.30.096 | Endless

[PATCH] HID: asus: support backlight on USB keyboards

2017-04-04 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> The latest USB keyboards shipped on several ASUS laptop models (including ROG laptop models such as GL702VMK) have the keyboards backlight controlled by the keyboard firmware. The firmware implements at least 3 different commands: - Init command (

[PATCH] HID: asus: support backlight on USB keyboards

2017-04-04 Thread Carlo Caione
From: Carlo Caione The latest USB keyboards shipped on several ASUS laptop models (including ROG laptop models such as GL702VMK) have the keyboards backlight controlled by the keyboard firmware. The firmware implements at least 3 different commands: - Init command (to use when the system starts

Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X

2016-09-13 Thread Carlo Caione
you use "amlogic,s905x". Simple. We > never match partial strings, so there is no sense in a hardcoded prefix > that is duplicating information already available. Ok, then. Fine with me. Neil, do you want to resend my patch or you can take care of the fixes for the whole patchset? Thanks, -- Carlo Caione

Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X

2016-09-13 Thread Carlo Caione
5x". Simple. We > never match partial strings, so there is no sense in a hardcoded prefix > that is duplicating information already available. Ok, then. Fine with me. Neil, do you want to resend my patch or you can take care of the fixes for the whole patchset? Thanks, -- Carlo Caione

Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X

2016-09-12 Thread Carlo Caione
] >> + >> +/* This UART is brought out to the DB9 connector */ >> +_AO { >> + status = "okay"; >> +}; >> + > > Trailing white line - please watch out for that, git-am will complain. Right. [cut] >> +#include "meson-gxl.dtsi" >> + >> +/ { >> + compatible = "amlogic,meson-gxl", "amlogic,meson-gxl-s905x"; > > This needs to be reversed. Agree. Cheers, -- Carlo Caione

Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X

2016-09-12 Thread Carlo Caione
;> +/* This UART is brought out to the DB9 connector */ >> +_AO { >> + status = "okay"; >> +}; >> + > > Trailing white line - please watch out for that, git-am will complain. Right. [cut] >> +#include "meson-gxl.dtsi" >> + >> +/ { >> + compatible = "amlogic,meson-gxl", "amlogic,meson-gxl-s905x"; > > This needs to be reversed. Agree. Cheers, -- Carlo Caione

Re: [RFC PATCH 0/3] ARm64: amlogic: Introduce common GX family dtsi

2016-08-29 Thread Carlo Caione
On 29/08/16 20:38, Andreas Färber wrote: > Am 29.08.2016 um 10:01 schrieb Carlo Caione: > > On Mon, Aug 29, 2016 at 9:56 AM, Neil Armstrong <narmstr...@baylibre.com> > > wrote: > >> The new Amlogic GLX SoCs (S905X and S905D) are part of the Meson GX family >

Re: [RFC PATCH 0/3] ARm64: amlogic: Introduce common GX family dtsi

2016-08-29 Thread Carlo Caione
On 29/08/16 20:38, Andreas Färber wrote: > Am 29.08.2016 um 10:01 schrieb Carlo Caione: > > On Mon, Aug 29, 2016 at 9:56 AM, Neil Armstrong > > wrote: > >> The new Amlogic GLX SoCs (S905X and S905D) are part of the Meson GX family > >> so > >> the

Re: [RFC PATCH 0/3] ARm64: amlogic: Introduce common GX family dtsi

2016-08-29 Thread Carlo Caione
Meson GXL dtsi. > > This patchset introduces the common dtsi and switches the GLX and GXBB to use > the common dtsi, the GXBB dtsi is reformated to handle this situation. > > This patchset depends on Carlo Caione "ARM64: dts: amlogic: Add basic support > for Amlogic S905X&qu

Re: [RFC PATCH 0/3] ARm64: amlogic: Introduce common GX family dtsi

2016-08-29 Thread Carlo Caione
hset introduces the common dtsi and switches the GLX and GXBB to use > the common dtsi, the GXBB dtsi is reformated to handle this situation. > > This patchset depends on Carlo Caione "ARM64: dts: amlogic: Add basic support > for Amlogic S905X" [1] > > [1] > http:/

Re: [PATCH v3 1/5] ARM: dts: meson: minix-neo-x8: define PMIC as power controller

2016-06-27 Thread Carlo Caione
l Ziswiler <marcel.ziswi...@toradex.com> Acked-by: Carlo Caione <ca...@endlessm.com> -- Carlo Caione

Re: [PATCH v3 1/5] ARM: dts: meson: minix-neo-x8: define PMIC as power controller

2016-06-27 Thread Carlo Caione
On 25/06/16 18:15, Stefan Agner wrote: > The PMIC driver used to register itself as poweroff controller by > default, hence assuming that this device is using the PMIC as > system power controller. > > Signed-off-by: Stefan Agner > Reviewed-by: Marcel Ziswiler Acke

Re: [PATCH v3 2/2] arm64: dts: Fix broken architected timer interrupt trigger

2016-06-09 Thread Carlo Caione
on ThunderX, and their complete > absence on ls1043a (both of which seem to be related to copy-pasting > from other DTs). > > Signed-off-by: Marc Zyngier <marc.zyng...@arm.com> For meson-gxbb.dtsi: Acked-by: Carlo Caione <ca...@endlessm.com> -- Carlo Caione

Re: [PATCH v3 2/2] arm64: dts: Fix broken architected timer interrupt trigger

2016-06-09 Thread Carlo Caione
on ThunderX, and their complete > absence on ls1043a (both of which seem to be related to copy-pasting > from other DTs). > > Signed-off-by: Marc Zyngier For meson-gxbb.dtsi: Acked-by: Carlo Caione -- Carlo Caione

Re: [PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

2016-05-30 Thread Carlo Caione
L1_GPIO_POL_RESET_0 BIT(16) > +#define GXBB_WDT_CTRL1_GPIO_POL_RESET_1 (0) > +#define GXBB_WDT_CTRL1_GPIO_PULSE_CNT(BIT(16) - 1) nit: all these defines are not used at all in the driver. You can remove them Thanks! -- Carlo Caione

Re: [PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

2016-05-30 Thread Carlo Caione
0 BIT(16) > +#define GXBB_WDT_CTRL1_GPIO_POL_RESET_1 (0) > +#define GXBB_WDT_CTRL1_GPIO_PULSE_CNT(BIT(16) - 1) nit: all these defines are not used at all in the driver. You can remove them Thanks! -- Carlo Caione

Re: [PATCH 0/3] watchdog: Add Amlogic Meson GXBB Watchdog Timer driver

2016-05-30 Thread Carlo Caione
il Armstrong (3): > watchdog: Add Meson GXBB Watchdog Driver > dt-bindings: watchdog: Add Meson GXBB Watchdog bindings > ARM64: dts: amlogic: meson-gxbb: Add watchdog node I'm missing [PATCH 2/3] -- Carlo Caione

Re: [PATCH 0/3] watchdog: Add Amlogic Meson GXBB Watchdog Timer driver

2016-05-30 Thread Carlo Caione
il Armstrong (3): > watchdog: Add Meson GXBB Watchdog Driver > dt-bindings: watchdog: Add Meson GXBB Watchdog bindings > ARM64: dts: amlogic: meson-gxbb: Add watchdog node I'm missing [PATCH 2/3] -- Carlo Caione

Re: [RFC PATCH 2/3] dt-bindings: watchdog: Add Meson GXBB Watchdog bindings

2016-05-26 Thread Carlo Caione
/devicetree/bindings/watchdog/meson-gxbb-wdt.txt > @@ -0,0 +1,13 @@ > +Meson GXBB SoCs Watchdog timer > + > +Required properties: > + > +- compatible : should be "amlogic,meson-gxbb-wdt" > +- reg : Specifies base physical address and size of the registers. 'clocks' is also required IIRC. Thanks, -- Carlo Caione

Re: [RFC PATCH 2/3] dt-bindings: watchdog: Add Meson GXBB Watchdog bindings

2016-05-26 Thread Carlo Caione
n-gxbb-wdt.txt > @@ -0,0 +1,13 @@ > +Meson GXBB SoCs Watchdog timer > + > +Required properties: > + > +- compatible : should be "amlogic,meson-gxbb-wdt" > +- reg : Specifies base physical address and size of the registers. 'clocks' is also required IIRC. Thanks, -- Carlo Caione

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

2016-05-26 Thread Carlo Caione
gt; + return PTR_ERR(data->clk); > + > + clk_prepare_enable(data->clk); Do we need to merge the clock controller driver before this? Cheers, -- Carlo Caione

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

2016-05-26 Thread Carlo Caione
wdt_stop(wdt_dev); > + > + meson_gxbb_wdt_ping(wdt_dev); > + > + writel(timeout*1000, data->reg_base + GXBB_WDT_TCNT_REG); nit: spaces around "*" [...] > + data->clk = devm_clk_get(>dev, NULL); > + if (IS_ERR(data->clk)) > + return PTR_ERR(data->clk); > + > + clk_prepare_enable(data->clk); Do we need to merge the clock controller driver before this? Cheers, -- Carlo Caione

Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller

2016-05-20 Thread Carlo Caione
On 20/05/16 14:20, Neil Armstrong wrote: > On 05/20/2016 12:04 PM, Carlo Caione wrote: > > On 20/05/16 11:10, Neil Armstrong wrote: > >> On 05/20/2016 11:04 AM, Carlo Caione wrote: > >>> On 20/05/16 10:27, Neil Armstrong wrote: > >>>> This patch adds t

Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller

2016-05-20 Thread Carlo Caione
On 20/05/16 14:20, Neil Armstrong wrote: > On 05/20/2016 12:04 PM, Carlo Caione wrote: > > On 20/05/16 11:10, Neil Armstrong wrote: > >> On 05/20/2016 11:04 AM, Carlo Caione wrote: > >>> On 20/05/16 10:27, Neil Armstrong wrote: > >>>> This patch adds t

Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms

2016-05-20 Thread Carlo Caione
l post it with the Ethernet nodes. > > > > Why? The header file is related to the reset controller. Better add it > > now with this patchset. > > > > Cheers, > > > > OK, I will add it in gxbb and meson8b dtsi files. Why also meson8b DTSI? -- Carlo Caione

Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms

2016-05-20 Thread Carlo Caione
l post it with the Ethernet nodes. > > > > Why? The header file is related to the reset controller. Better add it > > now with this patchset. > > > > Cheers, > > > > OK, I will add it in gxbb and meson8b dtsi files. Why also meson8b DTSI? -- Carlo Caione

Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller

2016-05-20 Thread Carlo Caione
On 20/05/16 11:10, Neil Armstrong wrote: > On 05/20/2016 11:04 AM, Carlo Caione wrote: > > On 20/05/16 10:27, Neil Armstrong wrote: > >> This patch adds the platform driver for the Amlogic Meson GXBB Reset > >> Controller. > >> > >> Signed-of

Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller

2016-05-20 Thread Carlo Caione
On 20/05/16 11:10, Neil Armstrong wrote: > On 05/20/2016 11:04 AM, Carlo Caione wrote: > > On 20/05/16 10:27, Neil Armstrong wrote: > >> This patch adds the platform driver for the Amlogic Meson GXBB Reset > >> Controller. > >> > >> Signed-off-by:

Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms

2016-05-20 Thread Carlo Caione
On 20/05/16 10:53, Neil Armstrong wrote: > On 05/20/2016 10:47 AM, Carlo Caione wrote: > > On 20/05/16 10:27, Neil Armstrong wrote: > >> Update DTSI file to add the reset controller node. > >> > >> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com>

Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms

2016-05-20 Thread Carlo Caione
On 20/05/16 10:53, Neil Armstrong wrote: > On 05/20/2016 10:47 AM, Carlo Caione wrote: > > On 20/05/16 10:27, Neil Armstrong wrote: > >> Update DTSI file to add the reset controller node. > >> > >> Signed-off-by: Neil Armstrong > >> --- > >

Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller

2016-05-20 Thread Carlo Caione
On 20/05/16 10:51, Neil Armstrong wrote: > On 05/20/2016 10:46 AM, Carlo Caione wrote: > > On 20/05/16 10:27, Neil Armstrong wrote: > >> Add DT bindings for the Meson GXBB SoC Reset Controller documentation and > >> the > >> associated include fil

Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller

2016-05-20 Thread Carlo Caione
On 20/05/16 10:51, Neil Armstrong wrote: > On 05/20/2016 10:46 AM, Carlo Caione wrote: > > On 20/05/16 10:27, Neil Armstrong wrote: > >> Add DT bindings for the Meson GXBB SoC Reset Controller documentation and > >> the > >> associated include fil

Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller

2016-05-20 Thread Carlo Caione
rm_driver meson_gxbb_reset_driver = { > + .probe = meson_gxbb_reset_probe, > + .remove = meson_gxbb_reset_remove, > + .driver = { > + .name = "meson_gxbb_reset", > + .of_match_table = meson_gxbb_reset_dt_ids, > + }, > +}; > + > +module_platform_driver(meson_gxbb_reset_driver); No MODULE_AUTHOR, MODULE_LICENSE, etc... ? -- Carlo Caione

Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller

2016-05-20 Thread Carlo Caione
{ > + .probe = meson_gxbb_reset_probe, > + .remove = meson_gxbb_reset_remove, > + .driver = { > + .name = "meson_gxbb_reset", > + .of_match_table = meson_gxbb_reset_dt_ids, > + }, > +}; > + > +module_platform_driver(meson_gxbb_reset_driver); No MODULE_AUTHOR, MODULE_LICENSE, etc... ? -- Carlo Caione

Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms

2016-05-20 Thread Carlo Caione
reg = <0x0 0x04404 0x0 0x20>; > + #reset-cells = <1>; > + }; > + > uart_A: serial@84c0 { > compatible = "amlogic,meson-uart"; > reg = <0x0 0x084c0 0x0 0x14>; Missing #include ? Thanks, -- Carlo Caione

Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms

2016-05-20 Thread Carlo Caione
reg = <0x0 0x04404 0x0 0x20>; > + #reset-cells = <1>; > + }; > + > uart_A: serial@84c0 { > compatible = "amlogic,meson-uart"; > reg = <0x0 0x084c0 0x0 0x14>; Missing #include ? Thanks, -- Carlo Caione

Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller

2016-05-20 Thread Carlo Caione
C_ARB 229 > +/* 230 */ > +#define RESET_VID_LOCK 231 > +#define RESET_A9_DMC_PIPEL 232 > +/* 233-255 */ > + > +#endif Indentation looks really messy. Can you just shift the numbers to the right so that they are on the same column? -- Carlo Caione

Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller

2016-05-20 Thread Carlo Caione
C_ARB 229 > +/* 230 */ > +#define RESET_VID_LOCK 231 > +#define RESET_A9_DMC_PIPEL 232 > +/* 233-255 */ > + > +#endif Indentation looks really messy. Can you just shift the numbers to the right so that they are on the same column? -- Carlo Caione

Re: [PATCH] MAINTAINERS: ARM/Amlogic: add co-maintainer, misc. updates

2016-05-06 Thread Carlo Caione
On Fri, May 6, 2016 at 3:59 PM, Kevin Hilman <khil...@baylibre.com> wrote: > Add myself as co-maintainer, update mailing list entry and add a couple > more directories. > > Signed-off-by: Kevin Hilman <khil...@baylibre.com> Acked-by: Carlo Caione <ca...@caione.org> Thank you! -- Carlo Caione

Re: [PATCH] MAINTAINERS: ARM/Amlogic: add co-maintainer, misc. updates

2016-05-06 Thread Carlo Caione
On Fri, May 6, 2016 at 3:59 PM, Kevin Hilman wrote: > Add myself as co-maintainer, update mailing list entry and add a couple > more directories. > > Signed-off-by: Kevin Hilman Acked-by: Carlo Caione Thank you! -- Carlo Caione

Re: [PATCH v2 0/6] ARM64: meson: GXBaby (S905) and Vega S95 enablement

2016-03-23 Thread Carlo Caione
istro-incompatible way. I wonder if we can add this kind of information in Documentation/arm/meson/. Probably it could be handy until we have a proper u-boot porting. -- Carlo Caione

Re: [PATCH v2 0/6] ARM64: meson: GXBaby (S905) and Vega S95 enablement

2016-03-23 Thread Carlo Caione
this kind of information in Documentation/arm/meson/. Probably it could be handy until we have a proper u-boot porting. -- Carlo Caione

Re: [PATCH] ARM64: dts: amlogic: Clean up Vega S95 /memory nodes

2016-03-23 Thread Carlo Caione
s.dts > index fff7bfa2aa39..2fe167b2609d 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dts > @@ -48,7 +48,7 @@ > compatible = "tronsmart,vega-s95-telos", "tronsmart,vega-s95", > "amlogic,meson-gxbb"; > model = "Tronsmart Vega S95 Telos"; > > - memory { > + memory@0 { > device_type = "memory"; > reg = <0x0 0x0 0x0 0x8000>; > }; Acked-by: Carlo Caione <ca...@endlessm.com> Thanks, -- Carlo Caione

Re: [PATCH] ARM64: dts: amlogic: Clean up Vega S95 /memory nodes

2016-03-23 Thread Carlo Caione
44 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dts > @@ -48,7 +48,7 @@ > compatible = "tronsmart,vega-s95-telos", "tronsmart,vega-s95", > "amlogic,meson-gxbb"; > model = "Tronsmart Vega S95 Telos"; > > - memory { > + memory@0 { > device_type = "memory"; > reg = <0x0 0x0 0x0 0x8000>; > }; Acked-by: Carlo Caione Thanks, -- Carlo Caione

Re: [PATCH v2 0/6] ARM64: meson: GXBaby (S905) and Vega S95 enablement

2016-03-07 Thread Carlo Caione
ext days I'll pick the whole series up. Cheers, -- Carlo Caione

Re: [PATCH v2 0/6] ARM64: meson: GXBaby (S905) and Vega S95 enablement

2016-03-07 Thread Carlo Caione
le series up. Cheers, -- Carlo Caione

Re: [PATCH v3] tty: serial: meson: Implement earlycon support

2016-03-02 Thread Carlo Caione
earlycon driver name, courtesy of Nicolas. > > Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> > Signed-off-by: Andreas Färber <afaer...@suse.de> Acked-by: Carlo Caione <ca...@endlessm.com> Thanks, -- Carlo Caione

Re: [PATCH v3] tty: serial: meson: Implement earlycon support

2016-03-02 Thread Carlo Caione
name, courtesy of Nicolas. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Andreas Färber Acked-by: Carlo Caione Thanks, -- Carlo Caione

Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node

2016-03-01 Thread Carlo Caione
this the SoC that > is driving all those hardware and the peripherals that you describe in > there are clearly within the SoC. > So something like meson-s905.dtsi or the like? When I first submitted support for the meson8 and meson8b I picked up the names according to the Amlogic SDK. In the latest Amlogic drop this SoC is identified as meson-gxbb so probably we should stick to this name. -- Carlo Caione

Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node

2016-03-01 Thread Carlo Caione
e and the peripherals that you describe in > there are clearly within the SoC. > So something like meson-s905.dtsi or the like? When I first submitted support for the meson8 and meson8b I picked up the names according to the Amlogic SDK. In the latest Amlogic drop this SoC is identified as meson-gxbb so probably we should stick to this name. -- Carlo Caione

Re: [PATCH 14/50] pinctrl: meson: Use devm_pinctrl_register() for pinctrl registration

2016-02-26 Thread Carlo Caione
On Wed, Feb 24, 2016 at 2:15 PM, Laxman Dewangan <ldewan...@nvidia.com> wrote: > Use devm_pinctrl_register() for pin control registration. > > Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> > Cc: Carlo Caione <ca...@endlessm.com> > Cc: Beniamino Galvani <

Re: [PATCH 14/50] pinctrl: meson: Use devm_pinctrl_register() for pinctrl registration

2016-02-26 Thread Carlo Caione
On Wed, Feb 24, 2016 at 2:15 PM, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration. > > Signed-off-by: Laxman Dewangan > Cc: Carlo Caione > Cc: Beniamino Galvani > Cc: Lee Jones Acked-by: -- Carlo Caione

[PATCH] ASoC: cht_bsw_rt5645: Enable jack detection

2016-02-16 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Add missing DAPM pins and enable jack detection on those pins for Cherrytrail and Braswell. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/intel/boards/cht_bsw_rt5645.c | 15 +-- 1 file changed, 13 insertions(+),

[PATCH] ASoC: cht_bsw_rt5645: Enable jack detection

2016-02-16 Thread Carlo Caione
From: Carlo Caione Add missing DAPM pins and enable jack detection on those pins for Cherrytrail and Braswell. Signed-off-by: Carlo Caione --- sound/soc/intel/boards/cht_bsw_rt5645.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/boards

Re: [PATCH] tty: serial: meson: Add support for XTAL clock input

2016-02-09 Thread Carlo Caione
On Mon, Feb 8, 2016 at 1:49 PM, Andreas Färber wrote: > Fix the baudrate calculation for 24 MHz XTAL clock found on gxbb platforms. > > Signed-off-by: Andreas Färber Acked-by: Carlo Caione Thanks! -- Carlo Caione

Re: [PATCH] tty: serial: meson: Add support for XTAL clock input

2016-02-09 Thread Carlo Caione
On Mon, Feb 8, 2016 at 1:49 PM, Andreas Färber <afaer...@suse.de> wrote: > Fix the baudrate calculation for 24 MHz XTAL clock found on gxbb platforms. > > Signed-off-by: Andreas Färber <afaer...@suse.de> Acked-by: Carlo Caione <ca...@endlessm.com> Thanks! -- Carlo Caione

Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch

2016-02-08 Thread Carlo Caione
On Mon, Feb 8, 2016 at 9:34 AM, Carlo Caione wrote: > On Sun, Feb 7, 2016 at 10:13 PM, Andreas Färber wrote: >> As preparation for arm64 based mesongxbb, which pulls in this code once >> enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch. >> The loop uses

Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch

2016-02-08 Thread Carlo Caione
ith size_t since we are going to use it for array indexing. Also please, CC linux-me...@googlegroups.com on meson related patches. Thanks! -- Carlo Caione

Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch

2016-02-08 Thread Carlo Caione
On Mon, Feb 8, 2016 at 9:34 AM, Carlo Caione <ca...@caione.org> wrote: > On Sun, Feb 7, 2016 at 10:13 PM, Andreas Färber <afaer...@suse.de> wrote: >> As preparation for arm64 based mesongxbb, which pulls in this code once >> enabling ARCH_MESON, fix a size_t vs.

Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch

2016-02-08 Thread Carlo Caione
to fix declaration in drivers/clk/meson/clkc.h with size_t since we are going to use it for array indexing. Also please, CC linux-me...@googlegroups.com on meson related patches. Thanks! -- Carlo Caione

Re: [PATCH 1/1] ARM: meson: Add status LED for Odroid-C1

2015-10-30 Thread Carlo Caione
ght but I'll modify it myself and I'll push a PR. Cheers, -- Carlo Caione -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/1] ARM: meson: Add status LED for Odroid-C1

2015-10-30 Thread Carlo Caione
to you on Oct 12. I was waiting for a resubmission without the added copyright but I'll modify it myself and I'll push a PR. Cheers, -- Carlo Caione -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH 1/1] ARM: meson: Add status LED for Odroid-C1

2015-10-12 Thread Carlo Caione
/* > * Copyright 2015 Endless Mobile, Inc. > * Author: Carlo Caione > + * Copyright 2015 Codethink Ltd. > + * Author: Edward Cragg Usually we do not add a copyright line for each small addition to the DTS. > * > * This file is dual-licensed: you can use it either unde

Re: [PATCH 1/1] ARM: meson: Add status LED for Odroid-C1

2015-10-12 Thread Carlo Caione
s > +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts > @@ -1,6 +1,8 @@ > /* > * Copyright 2015 Endless Mobile, Inc. > * Author: Carlo Caione <ca...@endlessm.com> > + * Copyright 2015 Codethink Ltd. > + * Author: Edward Cragg <edward.cr...@codethink.co.uk> Usually we do no

Re: [linux-sunxi] [PATCH] Input: axp20x-pek: Add module alias

2015-08-03 Thread Carlo Caione
On Mon, Aug 3, 2015 at 9:48 AM, Chen-Yu Tsai wrote: > Add a proper module alias so the driver can be autoloaded when the > parent axp20x mfd driver registers its cells. > > Signed-off-by: Chen-Yu Tsai Acked-by: Carlo Caione Thanks, -- Carlo Caione -- To unsubscribe from thi

Re: [linux-sunxi] [PATCH] Input: axp20x-pek: Add module alias

2015-08-03 Thread Carlo Caione
On Mon, Aug 3, 2015 at 9:48 AM, Chen-Yu Tsai w...@csie.org wrote: Add a proper module alias so the driver can be autoloaded when the parent axp20x mfd driver registers its cells. Signed-off-by: Chen-Yu Tsai w...@csie.org Acked-by: Carlo Caione ca...@caione.org Thanks, -- Carlo Caione

Re: [PATCH 09/41] clocksource: meson6: Migrate to new 'set-state' interface

2015-06-20 Thread Carlo Caione
event > devices, for example: ONESHOT_STOPPED. > > Cc: Carlo Caione > Signed-off-by: Viresh Kumar > --- > drivers/clocksource/meson6_timer.c | 50 > -- > 1 file changed, 27 insertions(+), 23 deletions(-) Acked-by: Carlo Caione -- Carlo

Re: [PATCH 09/41] clocksource: meson6: Migrate to new 'set-state' interface

2015-06-20 Thread Carlo Caione
devices, for example: ONESHOT_STOPPED. Cc: Carlo Caione ca...@caione.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/clocksource/meson6_timer.c | 50 -- 1 file changed, 27 insertions(+), 23 deletions(-) Acked-by: Carlo Caione ca

Re: [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct

2015-06-08 Thread Carlo Caione
, flow_type); > > - for (i = 0; i <= gc->num_ct; i++, ct++) > + for (i = 0; i < gc->num_ct; i++, ct++) > if (ct->type & flow_type) > ctrl_off = ct->regs.type; Acked-by: Carlo Caione -- Carlo Caione -- To unsu

Re: [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc-num_ct

2015-06-08 Thread Carlo Caione
); - for (i = 0; i = gc-num_ct; i++, ct++) + for (i = 0; i gc-num_ct; i++, ct++) if (ct-type flow_type) ctrl_off = ct-regs.type; Acked-by: Carlo Caione ca...@endlessm.com -- Carlo Caione -- To unsubscribe from this list: send the line

Re: [PATCH v3 2/3] media: rc: add driver for Amlogic Meson IR remote receiver

2014-11-26 Thread Carlo Caione
++ >> 4 files changed, 229 insertions(+) >> create mode 100644 drivers/media/rc/meson-ir.c >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 0662378..f1bc045 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -850,6 +850,7 @@ ARM/

Re: [PATCH v3 2/3] media: rc: add driver for Amlogic Meson IR remote receiver

2014-11-26 Thread Carlo Caione
diff --git a/MAINTAINERS b/MAINTAINERS index 0662378..f1bc045 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -850,6 +850,7 @@ ARM/Amlogic MesonX SoC support M: Carlo Caione ca...@caione.org L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) S: Maintained +F

Re: [PATCH] ARM: dts: meson: enable Ethernet controller

2014-11-23 Thread Carlo Caione
.dts > index d7d351a..1237faa 100644 > --- a/arch/arm/boot/dts/meson6-atv1200.dts > +++ b/arch/arm/boot/dts/meson6-atv1200.dts > @@ -64,3 +64,7 @@ > _AO { > status = "okay"; > }; > + > + { > + status = "okay"; > +}; > -- > 1.9.1 > Tested-by: Carlo

Re: [PATCH] ARM: dts: meson: enable Ethernet controller

2014-11-23 Thread Carlo Caione
; +}; -- 1.9.1 Tested-by: Carlo Caione ca...@caione.org Thanks, -- Carlo Caione -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

<    1   2   3   >