sequence when iDisp codec is present, bus
initialization has to be called only after _i915_init() finishes.
With additional _reset_list preceding _i915_init(), iDisp codec never
gets the chance to enumerate on the link. Remove the superfluous
initialization to address the issue.
Signed-off-by: Cezary
e.de/
[3]:
https://lore.kernel.org/alsa-devel/20200427132727.24942-1-mateusz.gor...@linux.intel.com/
Cezary Rojewski (6):
ASoC: Intel: Skylake: Remove superfluous chip initialization
ASoC: Intel: Skylake: Select hda configuration permissively
ASoC: Intel: Skylake: Enable codec wakeup during
. codec_mask will be set to proper value during probe_work -
before skl_codec_create() ever gets called.
Signed-off-by: Cezary Rojewski
Reviewed-by: Pierre-Louis Bossart
Link: https://lore.kernel.org/r/20200305145314.32579-3-cezary.rojew...@intel.com
Signed-off-by: Mark Brown
Cc: # 5.4.x
---
sound/soc
.
Signed-off-by: Cezary Rojewski
Reviewed-by: Pierre-Louis Bossart
Link: https://lore.kernel.org/r/20200305145314.32579-5-cezary.rojew...@intel.com
Signed-off-by: Mark Brown
Cc: # 5.4.x
---
sound/soc/intel/skylake/skl-nhlt.c | 3 ++-
sound/soc/intel/skylake/skl.c | 9 +++--
2 files changed
commit e603f11d5df8997d104ab405ff27640b90baffaa upstream.
Follow the recommendation set by hda_intel.c and enable HDMI/DP codec
wakeup during bus initialization procedure. Disable wakeup once init
completes.
Signed-off-by: Cezary Rojewski
Reviewed-by: Pierre-Louis Bossart
Link: https
: cb6a55284629 ("ASoC: Intel: cnl: Add sst library functions for cnl
platform")
Signed-off-by: Cezary Rojewski
Reviewed-by: Pierre-Louis Bossart
Link: https://lore.kernel.org/r/20200305145314.32579-7-cezary.rojew...@intel.com
Signed-off-by: Mark Brown
Cc: # 5.4.x
---
sound/soc/intel/s
moving forward. Without doing so, ROM init poll may
start too early and false timeouts can occur.
Fixes: cb6a55284629 ("ASoC: Intel: cnl: Add sst library functions for cnl
platform")
Signed-off-by: Cezary Rojewski
Reviewed-by: Pierre-Louis Bossart
Link: https://lore.kernel.org/r/2020030514
allows user to select configuration of choice
using amixer settings.
Signed-off-by: Mateusz Gorski
Signed-off-by: Pavan K S
Reviewed-by: Cezary Rojewski
Reviewed-by: Pierre-Louis Bossart
Link:
https://lore.kernel.org/r/20200427132727.24942-3-mateusz.gor...@linux.intel.com
Signed-off-by: Mark
-by: Mateusz Gorski
Reviewed-by: Cezary Rojewski
Reviewed-by: Pierre-Louis Bossart
Link:
https://lore.kernel.org/r/20200427132727.24942-4-mateusz.gor...@linux.intel.com
Signed-off-by: Mark Brown
Cc: # 5.4.x
---
include/uapi/sound/skl-tplg-interface.h | 1 +
sound/soc/intel/skylake/skl-topology.c
On 2021-02-03 6:08 PM, Andy Shevchenko wrote:
On Wed, Feb 3, 2021 at 7:06 PM Andy Shevchenko
wrote:
On Wed, Feb 3, 2021 at 5:53 PM Cezary Rojewski
wrote:
This reverts commit 842067940a3e3fc008a60fee388e000219b32632.
For some solutions e.g. sound/soc/intel/catpt, DW DMA is part
On 2021-02-03 6:06 PM, Andy Shevchenko wrote:
On Wed, Feb 3, 2021 at 5:53 PM Cezary Rojewski
wrote:
This reverts commit 842067940a3e3fc008a60fee388e000219b32632.
For some solutions e.g. sound/soc/intel/catpt, DW DMA is part of a
compound device (in that very example, domains: ADSP, SSP0, SSP1
dysfunctional after first suspend() attempt. Revert the
change to address the problem.
Fixes: 842067940a3e ("dmaengine: dw: Enable runtime PM")
Cc: Andy Shevchenko
Signed-off-by: Cezary Rojewski
Acked-by: Andy Shevchenko
---
Changes v2:
- enriched tag area with fixes tag
drivers/dma/dw/
On 2021-02-01 10:03 PM, Cezary Rojewski wrote:
On 2021-02-01 9:01 AM, Yang Li wrote:
Eliminate the following coccicheck warning:
./sound/soc/intel/catpt/pcm.c:355:2-3: Unneeded semicolon
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
sound/soc/intel/catpt/pcm.c | 2 +-
1 file changed
dysfunctional after first suspend() attempt. Revert the
change to address the problem.
Cc: Andy Shevchenko
Signed-off-by: Cezary Rojewski
---
drivers/dma/dw/core.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c
index 19a23767533a..7ab83fe601ed 100644
On 2019-07-12 16:56, Oleksandr Suvorov wrote:
+enum {
+ HP_POWER_EVENT,
+ DAC_POWER_EVENT,
+ ADC_POWER_EVENT
+};
+
+struct sgtl5000_mute_state {
+ u16 hp_event;
+ u16 dac_event;
+ u16 adc_event;
+};
+
/* sgtl5000 private structure in codec */
struct
On 2019-07-26 01:39, Pierre-Louis Bossart wrote:
+static ssize_t sdw_slave_reg_read(struct file *file, char __user *user_buf,
+ size_t count, loff_t *ppos)
+{
+ struct sdw_slave *slave = file->private_data;
+ unsigned int reg;
+ char *buf;
+
On 2019-07-26 01:39, Pierre-Louis Bossart wrote:
+static void intel_debugfs_init(struct sdw_intel *sdw)
+{
+ struct dentry *root = sdw->cdns.bus.debugfs;
+
+ if (!root)
+ return;
+
+ sdw->fs = debugfs_create_dir("intel-sdw", root);
+ if
On 2019-07-26 01:39, Pierre-Louis Bossart wrote:
SQUASHME
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index
On 2019-07-26 01:39, Pierre-Louis Bossart wrote:
This should not happen in production systems but we should test for
all callback arguments before invoking the config_stream callback.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 2 +-
1 file changed, 1 insertion(+), 1
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
/*
* debugfs
*/
@@ -758,15 +774,9 @@ static int _cdns_enable_interrupt(struct sdw_cdns *cdns)
*/
int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns)
{
- int ret;
-
_cdns_enable_interrupt(cdns);
- ret =
On 2019-07-26 11:53, Cezary Rojewski wrote:
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
/*
* debugfs
*/
@@ -758,15 +774,9 @@ static int _cdns_enable_interrupt(struct sdw_cdns
*cdns)
*/
int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns)
{
- int ret
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/soundwire/cadence_master.h
b/drivers/soundwire/cadence_master.h
index c0bf6ff00a44..d375bbfead18 100644
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
- return do_bank_switch(stream);
+ ret = do_bank_switch(stream);
+ if (ret < 0) {
+ dev_err(bus->dev, "Bank switch failed: %d\n", ret);
+ return ret;
+ }
+
+ /* make sure alternate bank
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
+static u32 cdns_set_default_frame_shape(int n_rows, int n_cols)
+{
+ u32 val;
+ int c;
+ int r;
+
+ r = sdw_find_row_index(n_rows);
+ c = sdw_find_col_index(n_cols);
+
+ val = (r << 3) | c;
+
+ return
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
@@ -83,6 +87,9 @@ static struct sdw_intel_ctx
caps = ioread32(res->mmio_base + SDW_SHIM_BASE + SDW_SHIM_LCAP);
caps &= GENMASK(2, 0);
+ dev_dbg(>dev, "SoundWire links: BIOS count %d hardware caps %d\n",
+ count,
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
+void intel_shutdown(struct snd_pcm_substream *substream,
+ struct snd_soc_dai *dai)
+{
+ struct sdw_cdns_dma_data *dma;
+
+ dma = snd_soc_dai_get_dma_data(dai, substream);
+ if (!dma)
+ return;
+
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
Move code to helper for reuse in power management routines
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/soundwire/intel.c
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
+static int intel_resume(struct device *dev)
+{
+ struct sdw_intel *sdw;
+ int ret;
+
+ sdw = dev_get_drvdata(dev);
+
+ ret = intel_init(sdw);
+ if (ret) {
+ dev_err(dev, "%s failed: %d", __func__, ret);
On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
This algorithm computes bus parameters like clock frequency, frame
shape and port transport parameters based on active stream(s) running
on the bus.
This implementation is optimal for Intel platforms. Developers can
also implement their own
On 2019-07-26 01:39, Pierre-Louis Bossart wrote:
The existing upstream code allows for SoundWire devices to be
enumerated and managed by the bus, but streaming is not currently
supported.
Bard Liao, Rander Wang and I did quite a bit of integration/validation
work to close this gap and we now
On 2019-06-07 10:56, Srinivas Kandagatla wrote:
On platforms which have smart speaker amplifiers connected via
soundwire and modeled as aux devices in ASoC, in such usecases machine
driver should be able to get sdw master stream from dai so that it can
use the runtime stream to setup slave
On 2019-06-07 14:31, Pierre-Louis Bossart wrote:
On 6/7/19 3:56 AM, Srinivas Kandagatla wrote:
This patch adds SDW_MAX_PORT so that other driver can use it.
Signed-off-by: Srinivas Kandagatla
---
include/linux/soundwire/sdw.h | 1 +
1 file changed, 1 insertion(+)
diff --git
On 2019-06-07 10:56, Srinivas Kandagatla wrote:
Qualcomm SoundWire Master controller is present in most Qualcomm SoCs
either integrated as part of WCD audio codecs via slimbus or
as part of SOC I/O.
This patchset adds support to a very basic controller which has been
tested with WCD934x
On 2019-06-05 15:45, Amadeusz Sławiński wrote:
When we remove component we need to reverse things which were done on
init, this consists of topology cleanup, lists cleanup and releasing
firmware.
Currently cleanup handlers are put in wrong places or otherwise missing.
So add proper component
On 2019-07-18 11:02, Oleksandr Suvorov wrote:
+enum {
+ HP_POWER_EVENT,
+ DAC_POWER_EVENT,
+ ADC_POWER_EVENT,
+ LAST_POWER_EVENT
+};
+
+static u16 mute_mask[] = {
+ SGTL5000_HP_MUTE,
+ SGTL5000_OUTPUTS_MUTE,
+ SGTL5000_OUTPUTS_MUTE
+};
If
On 2019-07-18 20:42, Cezary Rojewski wrote:
On 2019-07-18 11:02, Oleksandr Suvorov wrote:
+enum {
+ HP_POWER_EVENT,
+ DAC_POWER_EVENT,
+ ADC_POWER_EVENT,
+ LAST_POWER_EVENT
+};
+
+static u16 mute_mask[] = {
+ SGTL5000_HP_MUTE,
+ SGTL5000_OUTPUTS_MUTE
On 2019-07-19 09:09, Oleksandr Suvorov wrote:
On Thu, 18 Jul 2019 at 21:49, Cezary Rojewski wrote:
On 2019-07-18 20:42, Cezary Rojewski wrote:
On 2019-07-18 11:02, Oleksandr Suvorov wrote:
+enum {
+HP_POWER_EVENT,
+DAC_POWER_EVENT,
+ADC_POWER_EVENT,
+LAST_POWER_EVENT
t;)
Signed-off-by: Oleksandr Suvorov
Reviewed-by: Marcel Ziswiler
Reviewed-by: Fabio Estevam
---
Changes in v6:
- Code optimization
You went crazy with that description (u16 mute_mask[]) :)
Reviewed-by: Cezary Rojewski
On 2019-08-06 02:55, Pierre-Louis Bossart wrote:
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index 5d9729b4d634..89c55e4bb72c 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -48,6 +48,8 @@
#define
On 2019-08-06 02:55, Pierre-Louis Bossart wrote:
@@ -1493,6 +1493,11 @@ static int _sdw_prepare_stream(struct sdw_stream_runtime
*stream)
}
}
+ if (!bus) {
+ pr_err("Configuration error in %s\n", __func__);
+ return -EINVAL;
+ }
+
On 2019-08-06 17:36, Pierre-Louis Bossart wrote:
On 8/6/19 10:27 AM, Cezary Rojewski wrote:
On 2019-08-06 02:55, Pierre-Louis Bossart wrote:
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index 5d9729b4d634..89c55e4bb72c 100644
--- a/drivers/soundwire
On 2019-09-27 15:14, Pierre-Louis Bossart wrote:
On 9/26/19 9:55 PM, Navid Emamdoost wrote:
On Wed, Sep 25, 2019 at 12:05:28PM -0500, Pierre-Louis Bossart wrote:
On 9/25/19 11:19 AM, Navid Emamdoost wrote:
In snd_skl_parse_uuids if allocation for module->instance_id fails, the
allocated
On 2019-08-13 10:35, Srinivas Kandagatla wrote:
On platforms which have smart speaker amplifiers connected via
soundwire and modeled as aux devices in ASoC, in such usecases machine
driver should be able to get sdw master stream from dai so that it can
use the runtime stream to setup slave
On 2019-08-13 18:52, Srinivas Kandagatla wrote:
Thanks for the review,
On 13/08/2019 17:03, Cezary Rojewski wrote:
On 2019-08-13 10:35, Srinivas Kandagatla wrote:
On platforms which have smart speaker amplifiers connected via
soundwire and modeled as aux devices in ASoC, in such usecases
On 2019-08-27 16:17, Amadeusz Sławiński wrote:
From: Amadeusz Sławiński
If ipc->ops.reply_msg_match is NULL, we may end up using uninitialized
mask value.
reported by smatch:
sound/soc/intel/common/sst-ipc.c:266 sst_ipc_reply_find_msg() error:
uninitialized symbol 'mask'.
Signed-off-by:
On 2019-06-14 21:48, Fletcher Woodruff wrote:
From: Ben Zhang
The rt5677 jack detection function has a requirement that the polarity
of an interrupt be flipped after it fires in order to clear the
interrupt.
This patch implements an irq_chip with irq_domain directly instead of
using
On 2019-07-03 08:42, shengjiu.w...@nxp.com wrote:
+static void fsl_esai_reset(unsigned long arg)
+{
+ struct fsl_esai *esai_priv = (struct fsl_esai *)arg;
+ u32 saisr, tfcr, rfcr;
+
+ /* save the registers */
+ regmap_read(esai_priv->regmap, REG_ESAI_TFCR, );
+
On 2019-06-11 19:49, Thomas Preston wrote:
Add a device attribute to control the enable regulator. Write 1 to
enable, 0 to disable (ref-count minus one), or -1 to force disable the
physical pin.
To disable a set of amplifiers wired to the same enable gpio, each
device must be disabled. For
On 2019-06-11 19:49, Thomas Preston wrote:
Add speaker_test device attribute. When the speaker-test node is read
the hardware speaker test is started.
$ cat /sys/devices/.../device:00/speaker_test
04 04 04 04
Signed-off-by: Thomas Preston
Cc: Patrick Glaser
Cc: Rob Duncan
2) Currently Skylake does not output MCLK/FS when the back-end DAI op
hw_param is called, so we cannot switch to MCLK/FS in hw_param. This
patch reduces pop by letting nau8825 keep using its internal VCO clock
during widget power up sequence, until SNDRV_PCM_TRIGGER_START when
hanged, 5 insertions(+), 5 deletions(-)
Acked-by: Cezary Rojewski
Thanks,
Czarek
On 2019-10-18 02:18, Srinivas Kandagatla wrote:
+static int wcd934x_codec_enable_slim(struct snd_soc_dapm_widget *w,
+struct snd_kcontrol *kc,
+ int event)
+{
+ struct snd_soc_component *comp =
On 2021-02-01 9:01 AM, Yang Li wrote:
Eliminate the following coccicheck warning:
./sound/soc/intel/catpt/pcm.c:355:2-3: Unneeded semicolon
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
sound/soc/intel/catpt/pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 2021-03-09 1:19 PM, Chris Chiu wrote:
Hi Guys,
We have received reports that on some Kabylake laptops (Acer Swift
SF314-54/55 and Lenovo Yoga C930...etc), all sound cards no longer be
detected after upgrade to kernel later than 5.8. These laptops have
one thing in common, all of them
On 2021-03-11 6:50 AM, Chris Chiu wrote:
On Tue, Mar 9, 2021 at 11:29 PM Cezary Rojewski
wrote:
...
Topologies for most common skylake driver configurations:
- skl/kbl with i2s rt286
- apl/glk with i2s rt298
- with hda dsp
can be found in alsa-topology-conf [2].
Standard, official tool
55 matches
Mail list logo
