Re: [PATCH 1/2] extcon: Unregister compat class at module unload to fix oops

2012-09-24 Thread Chanwoo Choi
. If you will write patch about extcon, please work patch based on below git repository. You will check it after some hours on below git repository. - http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next Thanks, Chanwoo Choi -- To unsubscribe from this list: send

Re: [PATCH 2/2] extcon: unregister compat link on cleanup

2012-09-24 Thread Chanwoo Choi
:825: warning: extra tokens at end of #ifdef directive make[2]: *** [drivers/extcon/extcon-class.o] Error 1 make[1]: *** [drivers/extcon] Error 2 make[1]: *** Waiting for unfinished jobs Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] extcon: Fix return value in extcon_register_interest()

2012-09-25 Thread Chanwoo Choi
-cable_index = extcon_find_cable_index(obj-edev, cable_name); if (obj-cable_index 0) - return -ENODEV; + return -EINVAL; obj-user_nb = nb; Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH Resend] extcon: Fix return value in extcon_register_interest()

2012-09-25 Thread Chanwoo Choi
some hours at below git repository for Extcon. - http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] extcon: max77693: Fix max77693_muic_probe error handling

2012-10-03 Thread Chanwoo Choi
parameter is unrequested irq. err_irq: + for (i = 0; i ARRAY_SIZE(muic_irqs); i++) + free_irq(muic_irqs[i].virq, info); Thank you, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] extcon: Fix kerneldoc for extcon_set_cable_state and extcon_set_cable_state_

2012-10-03 Thread Chanwoo Choi
: cable name. * @cable_state: the new cable status. The default semantics is Applied, thanks. I applied this patch at extcon git repository and you can check it after some hours. - http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next Thank you, Chanwoo

Re: [PATCH] extcon: max77693: Use max77693_update_reg for rmw operations

2012-10-03 Thread Chanwoo Choi
. Cheers, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] extcon: MAX77693: Add platform data for MUIC device to initialize registers

2012-10-03 Thread Chanwoo Choi
This patch add platform data for MUIC device to initialize register on probe() call because it should unmask interrupt mask register and initialize some register related to MUIC device. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com Signed

Re: [PATCH] extcon: arizona: unlock mutex on error path in arizona_micdet()

2012-11-05 Thread Chanwoo Choi
(linuxtesting.org). Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Applied, thanks. You can check this patch on extcon git tree: - git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git (for-next branch) Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] extcon : callback function to read cable property

2012-11-07 Thread Chanwoo Choi
that the provider device driver detect changed state of host. Could you provide example device driver? Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] extcon : callback function to read cable property

2012-10-19 Thread Chanwoo Choi
/detached and define two type cable of MHL cable. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] [PATCH] extcon: driver model release call not needed

2012-10-19 Thread Chanwoo Choi
pointer of extcon_dev_release() in extcon_dev_register(). edev-dev-parent = dev; edev-dev-class = extcon_class; edev-dev-release = extcon_dev_release; Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH] [PATCH] extcon: driver model release call not needed

2012-10-19 Thread Chanwoo Choi
On 10/20/2012 11:30 AM, anish kumar wrote: On Sat, 2012-10-20 at 10:57 +0900, Chanwoo Choi wrote: On 10/19/2012 02:12 AM, anish kumar wrote: From: anish kumar anish198519851...@gmail.com We don't need a release call in this file as we are doing everything needed in unregister call and we

Re: [PATCH] [PATCH] extcon: driver model release call not needed

2012-10-19 Thread Chanwoo Choi
) + class_compat_remove_link(switch_class, edev-dev, NULL); +#endif + device_unregister(edev-dev); + put_device(edev-dev); } EXPORT_SYMBOL_GPL(extcon_dev_unregister); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] extcon: driver model release call not needed

2012-10-21 Thread Chanwoo Choi
, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] extcon: trivial: kfree missed from remove path

2012-10-21 Thread Chanwoo Choi
-max77693.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Applied, thanks. You can check it after some hours at extcon tree: - http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH V2] extcon : register for cable interest by cable name

2012-10-21 Thread Chanwoo Choi
submit V2: Removed the new API and modified the extcon_register_interest API to accomodate the new requirement drivers/extcon/extcon-class.c | 43 +++-- 1 file changed, 33 insertions(+), 10 deletions(-) Tested-by: Chanwoo Choi cw00.c...@samsung.com

[GIT PULL] extcon fixes for Linux 3.6

2012-10-10 Thread Chanwoo Choi
small bugfixes and enhancements, fix typos. And extcon-max77693 initialize MUIC register during probe() to unmask internal interrupt of max77693 MUIC device. Thanks, Chanwoo Choi The following changes since commit e0f21e6d52cc245e7d4f7e02ca4b7b6571660ec2: Axel Lin (1

Re: [PATCH] extcon: remove duplicated include from extcon-gpio.c

2012-10-10 Thread Chanwoo Choi
was already applied from Sachin Kamat and you can check previous patch on below extcon-for-next git tree: - http://git.infradead.org/users/kmpark/linux-samsung/commit/e16bce4f25980a4f0b02b5297e87673800be5474 Thank you, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [GIT PULL] extcon fixes for Linux 3.6

2012-10-10 Thread Chanwoo Choi
On 10/11/2012 10:40 AM, Greg KH wrote: On Thu, Oct 11, 2012 at 10:31:19AM +0900, Chanwoo Choi wrote: Hi Greg, Please pull extcon fixes for Linux 3.6 from: git://git.infradead.org/users/kmpark/linux-samsung extcon-for-next Linux 3.6 has been released already, I can't take any patches

Re: [GIT PULL] extcon fixes for Linux 3.6

2012-10-18 Thread Chanwoo Choi
On 10/19/2012 02:24 AM, Greg KH wrote: On Thu, Oct 11, 2012 at 10:31:19AM +0900, Chanwoo Choi wrote: Hi Greg, Please pull extcon fixes for Linux 3.6 from: git://git.infradead.org/users/kmpark/linux-samsung extcon-for-next I've been creating extcon-for-next tree at git.infradead.org

Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break

2012-07-12 Thread Chanwoo Choi
Hi Greg, On 07/13/2012 12:36 AM, Greg KH wrote: On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: This patch modify 'Kconfig' of EXTCON Subsystem to support either active or inactive of EXTCON Subsystem. The various subsystem refer to EXTCON subsystem for controlling external

Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break

2012-07-12 Thread Chanwoo Choi
On 07/13/2012 01:16 AM, Mark Brown wrote: On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: This patch modify 'Kconfig' of EXTCON Subsystem to support either active or inactive of EXTCON Subsystem. The various subsystem refer to EXTCON subsystem for controlling external connector

Re: [PATCH 0/2] charger-manager: Use EXTCON Subsystem to control charger cable

2012-07-15 Thread Chanwoo Choi
On 07/14/2012 10:37 AM, Anton Vorontsov wrote: On Thu, Jul 12, 2012 at 03:03:16PM +0900, Chanwoo Choi wrote: This patchset add support EXTCON Subsystem in which charger-manager identify the type of external connector and enable/disable charger(regulator) according to the state of charger

[PATCH] charger-manager: Fix build break related to EXTCON

2012-07-15 Thread Chanwoo Choi
:(.text+0x11d7b6): undefined reference to `extcon_unregister_interest' drivers/built-in.o: In function `charger_manager_remove': charger-manager.c:(.devexit.text+0x8f3): undefined reference to `extcon_unregister_interest' Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham

Re: linux-next: build failure after merge of the battery tree

2012-07-15 Thread Chanwoo Choi
, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] mfd: MAX77693: Fix bug of interrupt handlding for MAX77693 devices

2012-07-16 Thread Chanwoo Choi
This patch fix bug related to interrupt handling for MAX77693 devices. - Unmask interrupt masking bit for charger/flash/muic to revolve that interrupt isn't happened when external connector is attached. - Fix wrong regmap instance when muic interrupt is happened. Signed-off-by: Chanwoo Choi cw00

Re: [PATCH] mfd: MAX77693: Fix bug of interrupt handlding for MAX77693 devices

2012-07-16 Thread Chanwoo Choi
On 07/16/2012 10:36 PM, Mark Brown wrote: On Mon, Jul 16, 2012 at 06:41:05PM +0900, Chanwoo Choi wrote: This patch fix bug related to interrupt handling for MAX77693 devices. - Unmask interrupt masking bit for charger/flash/muic to revolve that interrupt isn't happened when external connector

[PATCH] extcon: MAX77693: Add extcon-max77693 driver to support Maxim MAX77693 MUIC device

2012-07-16 Thread Chanwoo Choi
This patch support Maxim MAX77693 MUIC device by using EXTCON Subsystem to handle various external connector. The extcon-max77693 use regmap method for i2c communication and support irq domain instead of previous method of irq base. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off

Re: [PATCH] mfd: MAX77693: Fix bug of interrupt handlding for MAX77693 devices

2012-07-17 Thread Chanwoo Choi
On 07/18/2012 04:14 AM, Mark Brown wrote: On Tue, Jul 17, 2012 at 08:30:17AM +0900, Chanwoo Choi wrote: On 07/16/2012 10:36 PM, Mark Brown wrote: On Mon, Jul 16, 2012 at 06:41:05PM +0900, Chanwoo Choi wrote: This patch fix bug related to interrupt handling for MAX77693 devices. - Unmask

Re: [RESEND PATCH 1/2] mfd: add irq domain support for max8997 interrupts

2012-07-17 Thread Chanwoo Choi
On 07/18/2012 01:34 AM, Greg KH wrote: On Mon, Jul 02, 2012 at 09:02:55AM +0900, Chanwoo Choi wrote: From: Thomas Abraham thomas.abra...@linaro.org Add irq domain support for max8997 interrupts. The reverse mapping method used is linear mapping since the sub-drivers of max8997

[GIT PULL] extcon fixes for 3.9-rc6

2013-04-07 Thread Chanwoo Choi
Hi Greg, This is extcon fixes for 3.9-rc6 Please pull extcon with following updates. Best Regards and thanks, Chanwoo Choi The following changes since commit 07961ac7c0ee8b546658717034fe692fd12eefa9: Linux 3.9-rc5 (2013-03-31 15:12:43 -0700) are available in the git repository at: git

Re: [GIT PULL] extcon fixes for 3.9-rc6

2013-04-07 Thread Chanwoo Choi
On 04/08/2013 11:36 AM, Greg KH wrote: On Mon, Apr 08, 2013 at 11:02:14AM +0900, Chanwoo Choi wrote: Hi Greg, This is extcon fixes for 3.9-rc6 Please pull extcon with following updates. Best Regards and thanks, Chanwoo Choi The following changes since commit

[GIT PULL] extcon for 3.10

2013-04-08 Thread Chanwoo Choi
Hi Greg, This is extcon pull request for v3.10. Please pull extcon with following updates. The following changes since commit 07961ac7c0ee8b546658717034fe692fd12eefa9: Linux 3.9-rc5 (2013-03-31 15:12:43 -0700) are available in the git repository at:

Re: [PATCH v2 1/2] extcon: max77693: Fix return value

2013-03-28 Thread Chanwoo Choi
1 files changed, 4 insertions(+), 4 deletions(-) Applied this patchset. Thanks. Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[GIT PULL] extcon fixes for 3.9-rc3

2013-03-13 Thread Chanwoo Choi
Hi Greg, This is extcon fixes for 3.9-rc3. Please pull extcon with following updates. Best Regards, Chanwoo Choi The following changes since commit f6161aa153581da4a3867a2d1a7caf4be19b6ec9: Linux 3.9-rc2 (2013-03-10 16:54:19 -0700) are available in the git repository at: git

Re: [PATCH 1/1] extcon: max77693: Staticize default_init_data

2013-03-19 Thread Chanwoo Choi
default_init_data[] = { +static struct max77693_reg_data default_init_data[] = { { /* STATUS2 - [3]ChgDetRun */ .addr = MAX77693_MUIC_REG_STATUS2, Applied it. Thanks. Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v2 1/2] extcon: max8997: use dev_err() instead of pr_err()

2013-03-19 Thread Chanwoo Choi
0) - pr_err(failed to detect cable type\n); + dev_err(info-dev, failed to detect cable type\n); } static int max8997_muic_probe(struct platform_device *pdev) Applied it. Thanks. Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH v2 2/2] extcon: max8997: add missing const

2013-03-19 Thread Chanwoo Choi
agree this coding style. I think this coding style is not general method. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH 2/2] extcon: max8997: Fix return value

2013-03-27 Thread Chanwoo Choi
-max8997.c? I'd like to receive one patch related to modification for fixing return type. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] extcon: max77693: Fix return value

2013-03-27 Thread Chanwoo Choi
return value, I wish to receive one patch which modify all of return value with 'ret' in extcon-max77693.c. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH 0/3] extcon: max8997/max77693: Fix bug and set default value to bring up

2013-03-13 Thread Chanwoo Choi
isn't used. Chanwoo Choi (3): extcon: max8997: Check the pointer of platform data to protect null pointer error extcon: max77693: Fix bug of wrong pointer when platform data is not used extcon: max77693: Initialize register of MUIC device to bring up it without platform data drivers

[PATCH 3/3] extcon: max77693: Initialize register of MUIC device to bring up it without platform data

2013-03-13 Thread Chanwoo Choi
This patch set default value of MUIC register to bring up MUIC device. If user don't set some initial value for MUIC device through platform data, extcon-max77693 driver use 'default_init_data' to bring up base operation of MAX77693 MUIC device. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com

[PATCH 2/3] extcon: max77693: Fix bug of wrong pointer when platform data is not used

2013-03-13 Thread Chanwoo Choi
This patch fix wrong pointer of platform data. If each machine set platform data for h/w path or delay time of workqueue, this driver happen kernel panic related to null pointer. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers

[PATCH 1/3] extcon: max8997: Check the pointer of platform data to protect null pointer error

2013-03-13 Thread Chanwoo Choi
This patch check the pointer of platform data to protect kernel panic when platform data is not used and code clean. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-max8997.c | 56

Re: [PATCH] EXTCON: Get and set cable properties

2012-12-02 Thread Chanwoo Choi
We discussed about this patch and then suggest some method to resolve this issue by Myungjoo Ham. Why don't you write additional feature or your opinion based on following patch by Myungjoo Ham? -

[PATCH 0/9] extcon: Update for extcon-max8997/77693

2013-02-13 Thread Chanwoo Choi
style Thanks, Chanwoo Choi Chanwoo Choi (9): extcon: gpio: Rename filename of extcon-gpio.c according to kernel naming style extcon: max77693: Convert to devm_input_allocate_device() extcon: max77693: Remove unnecessary goto statement to improve readability extcon: max8997: Move defined

[PATCH 6/9] extcon: max8997: Set default of ADC debounce time during initialization

2013-02-13 Thread Chanwoo Choi
This patch set default of ADC Debounce Time(25ms) during probe step. Also, can possible change ADC Debounce Time according to H/W situation by using max8997_set_adc_debounce_time() Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers

[PATCH 9/9] extcon: max8997: Use workqueue to check cable state after completing boot of platform

2013-02-13 Thread Chanwoo Choi
of platform initialization Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-max8997.c | 45 - include/linux/mfd/max8997.h | 3 +++ 2 files changed, 39 insertions(+), 9 deletions

[PATCH 8/9] extcon: max8997: Set default UART/USB path on probe

2013-02-13 Thread Chanwoo Choi
, micro usb cable is connected to AP(Application Processor) and if H/W line path set UART_AUX/USB_AUX, micro usb cable is connected to CP(Coprocessor). Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-max8997.c | 28

[PATCH 5/9] extcon: max8997: Remove duplicate code related to set H/W line path

2013-02-13 Thread Chanwoo Choi
Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-max8997.c | 62 ++--- include/linux/mfd/max8997-private.h | 19 +++- 2 files changed, 69 insertions(+), 12 deletions

[PATCH 7/9] extcon: max8997: Consolidate duplicate code for checking ADC/CHG cable type

2013-02-13 Thread Chanwoo Choi
in max8997_*_handler() function. Lastly, this patch move defined constant in header file(include/ linux/mfd/max8997.h, max8997-private.h) because defined constant is only used in the 'extcon-max8997.c'. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo

[PATCH 2/9] extcon: max77693: Convert to devm_input_allocate_device()

2013-02-13 Thread Chanwoo Choi
Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-max77693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c index a645268

[PATCH 3/9] extcon: max77693: Remove unnecessary goto statement to improve readability

2013-02-13 Thread Chanwoo Choi
Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-max77693.c | 77 ++-- 1 file changed, 43 insertions(+), 34 deletions(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers

[PATCH 4/9] extcon: max8997: Move defined constant to header file

2013-02-13 Thread Chanwoo Choi
This patch move defined constants to header file(max77693-private.h) because of mask/unmask selectively interrupt of MUIC device according to attribute of H/W board. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers/extcon/extcon

[PATCH 1/9] extcon: gpio: Rename filename of extcon-gpio.c according to kernel naming style

2013-02-13 Thread Chanwoo Choi
Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-gpio.c | 2 +- include/linux/extcon/extcon-gpio.h | 52 ++ include/linux/extcon/extcon_gpio.h | 52

Re: [PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static

2013-02-03 Thread Chanwoo Choi
const char *max8997_extcon_cable[] = { [0] = USB, [1] = USB-Host, [2] = TA, Patches 1-3 applied. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: linux-next: Tree for Jan 24 (extcon-max77693)

2013-01-24 Thread Chanwoo Choi
]: *** [vmlinux] Error 1 Needs depends on INPUT ?? You are right. I miss to add CONFIG_INPUT driver/extcon/Kconfig. I will send fix patch of this build error right now. Thank you, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH] extcon: max77693: Fix bug of build error related to INPUT subsystem

2013-01-24 Thread Chanwoo Choi
-max77693.c:(.text+0x665318): undefined reference to `input_event' extcon-max77693.c:(.text+0x66532a): undefined reference to `input_event' make[1]: *** [vmlinux] Error 1 Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers/extcon/Kconfig

Re: [PATCH] extcon: arizona: Use regulated mode for microphone supply when detecting

2013-01-25 Thread Chanwoo Choi
/Kconfig |2 +- drivers/extcon/extcon-arizona.c | 62 +++ 2 files changed, 63 insertions(+), 1 deletion(-) Applied it. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 5/5] extcon: arizona: Use regulated mode for microphone supply when detecting

2013-01-23 Thread Chanwoo Choi
: undefined reference to `snd_soc_dapm_disable_pin' Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 1/5] extcon: arizona: Disable debouce for accessory removal detection

2013-01-23 Thread Chanwoo Choi
, 9 insertions(+) Patches 1-4 applied. Patch 5 failed to build, so I sent reply related to build error of Patch 5. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [GIT PULL] extcon for 3.8-rc4

2013-01-15 Thread Chanwoo Choi
On 01/15/2013 10:49 PM, Greg KH wrote: On Tue, Jan 15, 2013 at 10:23:44PM +0900, Chanwoo Choi wrote: On Tuesday, January 15, 2013, Greg KH wrote: On Tue, Jan 15, 2013 at 09:09:20PM +0900, Chanwoo Choi wrote: On Tuesday, January 15, 2013, Greg KH wrote: On Tue, Jan 15

[GIT PULL] extcon for v3.9

2013-01-15 Thread Chanwoo Choi
. - MICBIAS rise time configuration. Best regards, Chanwoo Choi The following changes since commit 9931faca02c604c22335f5a935a501bb2ace6e20: Linux 3.8-rc3 (2013-01-09 18:59:55 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon

Re: [GIT PULL] extcon for 3.8-rc4

2013-01-15 Thread Chanwoo Choi
On 01/16/2013 03:46 PM, Greg KH wrote: On Wed, Jan 16, 2013 at 12:38:35PM +0900, Chanwoo Choi wrote: OK, I will resend pull-request to include only bugfixes patch in 3.8. After released v3.8-rc7 or 3.8-rc8 kernel, I will send pull-request of extcon to include new feature patches of extcon

Re: [GIT PULL] extcon for v3.9

2013-01-15 Thread Chanwoo Choi
On 01/16/2013 04:28 PM, Greg KH wrote: On Wed, Jan 16, 2013 at 03:06:53PM +0900, Chanwoo Choi wrote: Hi Greg, This is the extcon pull request for v3.9. I don't send separate pull request of extcon about bugfixes patch. I'd like to apply this patch-set to your next branch for v3.9. Please

[GIT PULL] extcon for 3.9

2013-02-13 Thread Chanwoo Choi
Hi Greg, This pull-reqeust patchset is based on char-misc-next branch(char-misc.git). Please pull extcon with following updates. Best regards, Chanwoo Choi The following changes since commit 19d3243e797c2abc02a214d3cec9fefa5dc048ff: extcon: max77693: Remove unnecessary goto statement

Re: [GIT PULL] extcon for 3.9

2013-02-13 Thread Chanwoo Choi
On 02/14/2013 08:52 AM, Greg KH wrote: On Thu, Feb 14, 2013 at 08:41:43AM +0900, Chanwoo Choi wrote: Hi Greg, This pull-reqeust patchset is based on char-misc-next branch(char-misc.git). Please pull extcon with following updates. Best regards, Chanwoo Choi The following changes since commit

Re: [PATCH 4/5] charger-manager: Check fully charged state of battery periodically

2012-09-21 Thread Chanwoo Choi
On 09/21/2012 02:10 PM, Anton Vorontsov wrote: On Tue, Aug 21, 2012 at 05:06:52PM +0900, Chanwoo Choi wrote: This patch check periodically fully charged state of battery to protect overcharge and overheat. If battery is fully charged, stop charging and check droped voltage

Re: [PATCH 3/5] charger-manager: Add support sysfs entry for charger

2012-09-21 Thread Chanwoo Choi
On 09/21/2012 02:12 PM, Anton Vorontsov wrote: On Tue, Aug 21, 2012 at 05:06:49PM +0900, Chanwoo Choi wrote: This patch add support sysfs entry for each charger(regulator). Charger-manager use one or more chargers for charging battery but some charger isn't necessary on specific scenario. So

[PATCH v2] charger-manager: Add support sysfs entry for charger

2012-09-21 Thread Chanwoo Choi
is 1, Charger-manager cannot enable regulator for charging when charger cable is attached and charger must be maintained with disabled state. If 'externally_control' is zero, Charger-manager usually can control to enable/disable regulator. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off

Re: [PATCH 0/2] mfd: MAX77693: Fix bug

2012-09-16 Thread Chanwoo Choi
On 09/16/2012 07:32 AM, Samuel Ortiz wrote: Hi Chanwoo, On Tue, Aug 21, 2012 at 03:15:47PM +0900, Chanwoo Choi wrote: This patchset fix bug of Maxim MAX77693 chip. First patch unmask interrupt masking bit for charger/flas/muic device of Maxim MAX77693 and second patch remove NULL pointer

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-25 Thread Chanwoo Choi
. Thank you, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 2/2] charger-manager: Use replacement variable to check state of battery

2012-07-26 Thread Chanwoo Choi
This patch remove unnecessary variable(cm-fullbatt_vchk_uV) by using 'desc-fullbatt_uV' field directly in fullbatt_handler() function to check the state of battery. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park

[PATCH 0/2] charger-manager: Stop charging when charge cable is detached and code clean

2012-07-26 Thread Chanwoo Choi
This patchset fix bug related to stop charging when charger cable is detached and check return value of regulator_enable/disable() function to confirm correct operation of enabled or disabling regulator for charging. Second patch is code clean which remove unnecessary variable type. Chanwoo Choi

[PATCH 1/2] charger-manager: Disable regulator for charging when charger cable is detached

2012-07-26 Thread Chanwoo Choi
This patch disable regulator for charging when charger cable is detached before stopping charging forcibly on abnormal battery state and check return value of regulator_enable/disable() function to confirm correct operation of enabling or disabling regulator for charging. Signed-off-by: Chanwoo

Re: [PATCH] extcon: arizona: Implement button detection support

2012-07-27 Thread Chanwoo Choi
On 07/26/2012 05:11 PM, Mark Brown wrote: On Thu, Jul 26, 2012 at 09:10:08AM +0900, Chanwoo Choi wrote: If user press BTN_0 and BTN_1 at the same time and then user only released BTN_0 but BTN_1 is still pressed, is it right that report released event to all of buttons? I think

Re: [PATCH RESEND] extcon: fix typos in sys-class-extcon

2012-08-22 Thread Chanwoo Choi
is + {0x3, 0x5, 0xC, 0x0}, then the output is: # ls mutually_exclusive/ 0x3 0x5 Signed-off-by: Chanwoo Choi cw00.c...@samsung.com I will apply this patch to http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon

Re: [PATCH RESEND] extcon: fix typos in max77693 driver

2012-08-22 Thread Chanwoo Choi
. - http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next Thank you Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH RESEND] extcon: fixing typos

2012-08-22 Thread Chanwoo Choi
which rename file name(extcon-class.c, extcon-gpio.c) http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=commit;h=0ea62503782699adf5757cb1d3cd9f880d13c48c Thank you, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH RESEND] extcon: fix typos in extcon-arizona

2012-08-22 Thread Chanwoo Choi
-edev, arizona-dev); if (ret 0) { - dev_err(arizona-dev, extcon_dev_regster() failed: %d\n, + dev_err(arizona-dev, extcon_dev_register() failed: %d\n, ret); goto err; } Signed-off-by: Chanwoo Choi cw00.c...@samsung.com I

[PATCH 0/4] extcon: fix typos

2012-08-22 Thread Chanwoo Choi
This patchset fix typos of extcon by Peter Meerwald. Peter Meerwald (4): extcon: fix typos in sys-class-extcon extcon: fix typos in max77693 driver extcon: fix typos in extcon-arizona extcon: fixing typos Documentation/ABI/testing/sysfs-class-extcon | 22 +++---

[PATCH 1/4] extcon: fix typos in sys-class-extcon

2012-08-22 Thread Chanwoo Choi
From: Peter Meerwald pme...@pmeerw.net Signed-off-by: Peter Meerwald pme...@pmeerw.net Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- Documentation/ABI/testing/sysfs-class-extcon | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Documentation

[PATCH 3/4] extcon: fix typos in extcon-arizona

2012-08-22 Thread Chanwoo Choi
From: Peter Meerwald pme...@pmeerw.net Signed-off-by: Peter Meerwald pme...@pmeerw.net Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/extcon/extcon-arizona.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers

[PATCH 2/4] extcon: fix typos in max77693 driver

2012-08-22 Thread Chanwoo Choi
From: Peter Meerwald pme...@pmeerw.net Signed-off-by: Peter Meerwald pme...@pmeerw.net Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-max77693.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon-max77693.c

[PATCH 4/4] extcon: fixing typos

2012-08-22 Thread Chanwoo Choi
From: Peter Meerwald pme...@pmeerw.net Signed-off-by: Peter Meerwald pme...@pmeerw.net Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- drivers/extcon/extcon-class.c |8 include/linux/extcon.h| 18 +- 2 files changed, 13 insertions(+), 13

Re: [PATCH 0/2] charger-manager: Stop charging when charge cable is detached and code clean

2012-08-22 Thread Chanwoo Choi
On 08/23/2012 12:10 PM, Anton Vorontsov wrote: On Fri, Jul 27, 2012 at 02:01:25PM +0900, Chanwoo Choi wrote: This patchset fix bug related to stop charging when charger cable is detached and check return value of regulator_enable/disable() function to confirm correct operation of enabled

Re: [PATCH -next] extcon: extcon-arizona depends on INPUT

2012-08-26 Thread Chanwoo Choi
] undefined! Signed-off-by: Randy Dunlap rdun...@xenotime.net Cc: MyungJoo Ham myungjoo@samsung.com Cc: Chanwoo Choi cw00.c...@samsung.com Cc: Mark Brown broo...@opensource.wolfsonmicro.com --- Thanks much, Signed-off-by: Chanwoo Choi cw00.c...@samsung.com I will apply this patch to http

Re: [PATCH] extcon: arizona: Free MICDET IRQ on error during probe

2012-08-26 Thread Chanwoo Choi
: Thanks much, Signed-off-by: Chanwoo Choi cw00.c...@samsung.com I will apply this patch to http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next and you can check it after some hours. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH 0/2] mfd: MAX77693: Fix bug

2012-08-21 Thread Chanwoo Choi
This patchset fix bug of Maxim MAX77693 chip. First patch unmask interrupt masking bit for charger/flas/muic device of Maxim MAX77693 and second patch remove NULL pointer error when mfd-max77693 driver initialize irqs of Maxim MAX77693 devices. Chanwoo Choi (2): mfd: MAX77693: Fix bug

[RESEND PATCH 1/2] mfd: MAX77693: Fix bug of interrupt handlding for MAX77693 devices

2012-08-21 Thread Chanwoo Choi
and confirm discussion about this patch on below url: http://lkml.org/lkml/2012/7/16/118 Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/mfd/max77693-irq.c | 36

[PATCH 2/2] mfd: MAX77693: Fix NULL pointer error when initialize irqs of Maxim MAX77693

2012-08-21 Thread Chanwoo Choi
This patch initialize register map of MUIC device because mfd driver of Maxim MAX77693 use regmap-muic instance of MUIC device when irqs of Maxim MAX77693 is initialized before call max77693-muic probe() function. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham

[PATCH 0/5] charger-manager: Update charger-manager to support various charging conditions

2012-08-21 Thread Chanwoo Choi
possible duration of charging to prevent overcharging, also check discharging duration to maintain fully charged state of battery and to prevent much drop voltage than given data through platform data of charger_desc. Chanwoo Choi (5): charger-manager: Disable battery charging when charger

[PATCH 3/5] charger-manager: Add support sysfs entry for charger

2012-08-21 Thread Chanwoo Choi
, Charger-manager usually can control to enable/disable regulator. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/power/charger-manager.c | 172

[PATCH 5/5] charger-manager: Support limit of maximum possible duration for charging/discharging

2012-08-21 Thread Chanwoo Choi
fully charged state for battery. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/power/charger-manager.c | 81 - include/linux/power

[PATCH 1/5] charger-manager: Disable battery charging when charger cable is detached

2012-08-21 Thread Chanwoo Choi
This patch disable before stop chargint forcibly when charger cable is detached and check return value of regulator_enable/disable() fucntion to confirm correct opertion of enabling/disabling charger(regulator). Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham

[PATCH 4/5] charger-manager: Check fully charged state of battery periodically

2012-08-21 Thread Chanwoo Choi
will restart charging for battery. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/power/charger-manager.c | 161 - include/linux/power

[PATCH 2/5] charger-manager: Use replacement variable to check state of battery

2012-08-21 Thread Chanwoo Choi
This patch remove unnecessary variable(cm-fullbatt_vchk_uV) by using 'desc-fullbatt_uV' field directly in fullbatt_handler() function to check the state of battery. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park

Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()

2012-07-11 Thread Chanwoo Choi
) { dev_err(arizona-dev, Failed to read MICDET: %d\n, ret); + mutex_unlock(info-lock); return IRQ_NONE; } This patch is right. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break

2012-07-11 Thread Chanwoo Choi
, other subsystem have build break because of linking the core class of EXTCON. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/extcon/Kconfig |2 +- 1 files changed, 1

  1   2   3   4   5   6   7   8   9   10   >