Hi Matthias,
On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote:
> On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote:
>> Hi Chanwoo,
>>
>> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote:
>>> Hi Matthias,
>>>
>>> On 2018년
Hi Matthias,
On 2018년 08월 03일 09:24, Matthias Kaehlcke wrote:
> On Fri, Aug 03, 2018 at 09:03:30AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 03일 08:36, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>> this patch and "PM / de
Hi Matthias,
On 2018년 08월 07일 03:46, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Fri, Aug 03, 2018 at 08:56:57AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>>
Hi Matthias,
On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote:
>>> On Thu, Aug 02, 2018 at 04:13:43PM -07
ble 500Mhz at this time
such as cooling.
I think that if OPP support the use of multiple device drivers,
dev_pm_opp_enable() and dev_pm_opp_disable() should support the usage count
such as regulator/clock.
I would like your opinion.
Regards,
Chanwoo Choi
On 2018년 08월 07일 07:31, Chanwoo Cho
Hi Matthias,
On 2018년 08월 07일 09:23, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>>
Hi Enric,
On 2018년 06월 20일 19:32, Enric Balletbo i Serra wrote:
> Hi Chanwoo,
>
> On 20/06/18 02:47, Chanwoo Choi wrote:
>> Hi Enric,
>>
>> On 2018년 06월 19일 17:22, Enric Balletbo i Serra wrote:
>>> Hi Chanwoo,
>>>
>>> On 18/06/18 11:02, Enri
Dear Rob,
On 2018년 08월 28일 10:52, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
>
> Cc: Chanwoo Choi
> Cc: MyungJoo Ham
> Cc: Kyungmin Park
> Cc: Kukjin Kim
>
(!edev)
> return -EINVAL;
>
Applied all patches of this series. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
.
Cc: sta...@vger.kernel.org
Fixes: 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for
sysfs")
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 11 +++
include/linux/devfreq.h | 3 +++
2 files changed, 14 insertions(+)
diff --git a/drivers/devfreq/devfreq
Dear Greg,
On 2018년 08월 29일 19:57, Greg KH wrote:
> On Wed, Aug 29, 2018 at 04:34:06PM +0900, Chanwoo Choi wrote:
>> commit 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for
>> sysfs") changed the node name to devfreq(x). After this commit, it is n
Hi Bartlomiej,
On 2018년 08월 29일 21:50, Bartlomiej Zolnierkiewicz wrote:
>
> Hi Chanwoo,
>
> On Wednesday, August 29, 2018 04:34:06 PM Chanwoo Choi wrote:
>> commit 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for
>> sysfs") changed the n
on-max77693.c | 22 ++
> drivers/extcon/extcon-max77843.c | 19 +++
> drivers/extcon/extcon-max8997.c | 22 ++
> 4 files changed, 26 insertions(+), 61 deletions(-)
>
Thanks. Applied it for v4.20.
(snip)
--
Best Regards,
Chanwoo Choi
Samsung Electronics
dt-bindings/clock/s3c2443.h | 5 +
> include/dt-bindings/clock/samsung,s2mps11.h | 5 +
> include/dt-bindings/clock/samsung,s3c64xx-clock.h | 7 ++-
> 13 files changed, 20 insertions(+), 59 deletions(-)
>
Looks good to me.
Acked-by: Chanwoo Choi
(snip)
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Dear Greg,
This is extcon-next pull request for v4.19. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40:
Linux 4.18-rc1 (2018-06-17 08
On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote:
> On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote:
>> On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote:
>>> Hi Matthias,
>>>
>>> On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote:
>&
Hi Matthias,
On 2018년 08월 01일 04:29, Matthias Kaehlcke wrote:
> On Mon, Jul 16, 2018 at 12:41:14PM -0700, Matthias Kaehlcke wrote:
>> Hi Chanwoo,
>>
>> On Thu, Jul 12, 2018 at 06:08:36PM +0900, Chanwoo Choi wrote:
>>> Hi Matthias,
>>>
>>> On 2018년
; phandle.
cpu0_opp03 indicates the only one specific OPP entry among set of OPP entries
of CPU0 cpufreq? or
cpu0_opp03 indicates the set of OPP entries for CPU0 cpufreq ?
--
Best Regards,
Chanwoo Choi
Samsung Electronics
int update_devfreq(struct devfreq *devfreq);
> +
> /* Helper functions for devfreq user device driver with OPP. */
> extern struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
> unsigned long *freq, u32 flags);
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Matthias,
On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote:
>> On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote:
>>> On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote:
>>
extcon/extcon-max3355.c
> +++ b/drivers/extcon/extcon-max3355.c
> @@ -14,6 +14,7 @@
> #include
> #include
> #include
> +#include
> #include
>
> struct max3355_data {
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On 2018년 07월 12일 10:30, Chanwoo Choi wrote:
> On 2018년 07월 12일 00:50, Arnd Bergmann wrote:
>> Another driver turned up that is missing linux/mod_devicetable.h after
>> the device IDs are split out from linux/platform_device.h:
>>
>> drivers/extcon/extcon-max3355.c:12
Hi Matthias,
On 2018년 07월 07일 01:36, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Wed, Jul 04, 2018 at 11:20:31AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote:
>>> Commit ab8f58ad72c4 ("PM /
Hi Matthias,
On 2018년 07월 07일 02:07, Matthias Kaehlcke wrote:
> Hi,
>
> On Wed, Jul 04, 2018 at 11:51:30AM +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote:
>>> Move variables related with devfreq policy changes from
Hi Matthias,
On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote:
>
>> Firstly,
>> I'm not sure why devfreq needs the devfreq_verify_within_limits() function.
>>
>> devfreq alre
Hi Matthias,
On 2018년 07월 07일 03:09, Matthias Kaehlcke wrote:
> Hi,
>
> On Wed, Jul 04, 2018 at 02:30:32PM +0900, Chanwoo Choi wrote:
>
>> I didn't see any framework which exporting the class instance.
>> It is very dangerous. Unknown device drivers is able t
On 2018년 01월 10일 19:53, Sudeep Holla wrote:
>
>
> On 10/01/18 01:46, Chanwoo Choi wrote:
>> On 2018년 01월 09일 23:11, Sudeep Holla wrote:
>>>
>>>
>>> On 09/01/18 07:59, Chanwoo Choi wrote:
>>>> This patch adds the PMU (Power Management Uni
On 2018년 01월 09일 21:23, Krzysztof Kozlowski wrote:
> On Tue, Jan 9, 2018 at 8:59 AM, Chanwoo Choi wrote:
>> This patch adds the PMU (Power Management Unit) data of exynos5433 SoC
>> in order to support the various power modes. Each power mode has
>> the different value f
On 2018년 01월 09일 21:45, Krzysztof Kozlowski wrote:
> On Tue, Jan 9, 2018 at 8:59 AM, Chanwoo Choi wrote:
>> This patch adds the specific exynos_pm_data instance for Exynos5433
>> in order to support the suspend-to-ram. Exynos5433 SoC need to write
>> the 'cpu_resu
ry it.
Best Regards,
Chanwoo Choi
Samsung Electronics
On 2018년 01월 09일 21:37, Krzysztof Kozlowski wrote:
> On Tue, Jan 9, 2018 at 8:59 AM, Chanwoo Choi wrote:
>> To enter suspend, Exynos SoC requires the some machine dependent procedures.
>> This patch introduces the generic power-ma
;info->det_work, axp288_extcon_det_work);
>
> platform_set_drvdata(pdev, info);
>
> @@ -315,7 +287,7 @@ static int axp288_extcon_probe(struct platform_device
> *pdev)
> }
>
> /* Start charger cable type detection */
> - queue_delayed_work(system_wq, &info->det_work, 0);
> + axp288_extcon_enable(info);
>
> return 0;
> }
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
> return ret;
> }
>
> - /* queue initial processing of id-pin */
> - queue_delayed_work(system_wq, &data->work, 0);
> -
> platform_set_drvdata(pdev, data);
>
> return 0;
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On 2018년 01월 16일 18:33, Hans de Goede wrote:
> Hi,
>
> On 16-01-18 00:43, Chanwoo Choi wrote:
>> On 2018년 01월 15일 20:32, Hans de Goede wrote:
>>> HI,
>>>
>>> On 15-01-18 10:08, Chanwoo Choi wrote:
>>>> On 2018년 01월 15일 17:36, Hans de Goede w
This patch uses the power-key as a wakeup source from suspend/freeze state.
Signed-off-by: Chanwoo Choi
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
b/arch/arm64/boot/dts
RAM of cpu is successful.
- Exynos5433 SoC has two EXYNOS5433_EINT_WAKEUP_MASKx registers. The
pinctr-exynos.c need to handle the extra EINT_WAKEUP_MASKx for Exynos5433.
The suspend-to-ram test is failed on first time and then next tryout is ok.
I'm developing it.
Chanwoo Choi (9)
This patch adds the iRAM device-tree node of Exynos5433 which
defines the memory map of iRAM as following and it is used for suspend.
- address: 0x0202_ ~ 0x3000_
Signed-off-by: Jonghwa Lee
Signed-off-by: Chanwoo Choi
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14
This patch adds the specific exynos_pm_data instance for Exynos5433
in order to support the suspend-to-ram. Exynos5433 SoC need to write
the 'cpu_resume' poiter address and the specific magic number
for suspend mode.
Signed-off-by: Jonghwa Lee
Signed-off-by: Chanwoo Choi
---
d
This patch adds the 'cpu-map' for the cpu topology information
of Exynos5433 which has the following two clusters.
- cluster0 contains the four LITTLE cores (cpu0-3).
- cluster1 contains the four big cores (cpu4-7).
Signed-off-by: Chanwoo Choi
---
arch/arm64/boot/dts/exynos/exynos5433
To enter suspend, Exynos SoC requires the some machine dependent procedures.
This patch introduces the generic power-management driver to support
those requirements and generic interface for power state management.
Signed-off-by: Jonghwa Lee
Signed-off-by: Chanwoo Choi
---
arch/arm/mach-exynos
This patch adds the PMU (Power Management Unit) data of exynos5433 SoC
in order to support the various power modes. Each power mode has
the different value for reducing the power-consumption.
Signed-off-by: Jonghwa Lee
Signed-off-by: Chanwoo Choi
---
arch/arm/mach-exynos/common.h
This patch adds the powerup_conf callback which is used to re-initialize
the PMU registers during the resume state.
Signed-off-by: Chanwoo Choi
---
drivers/soc/samsung/exynos-pmu.c | 8
drivers/soc/samsung/exynos-pmu.h | 1 +
include/linux/soc/samsung/exynos-pmu.h | 1 +
3
uspend' on PSCI v1.0.
So, the 'cpu_suspend' of PSCI v0.1 on Exynos5433 is used for both
cpuidle and suspend-to-RAM.
[1]
http://infocenter.arm.com/help/topic/com.arm.doc.den0022d/Power_State_Coordination_Interface_PDD_v1_1_DEN0022D.pdf
Signed-off-by: Chanwoo Choi
---
arch/arm64/boot/dts/ex
This patch adds the CLK_IS_CRITICAL and CLK_IGNORE_UNUSED flag
to some clocks in order to avoid the hang-out in the suspend mode.
Signed-off-by: Chanwoo Choi
Cc: Tomasz Figa
Cc: Michael Turquette
Cc: Stephen Boyd
Cc: linux-...@vger.kernel.org
---
drivers/clk/samsung/clk-exynos5433.c | 22
On 2018년 01월 09일 23:11, Sudeep Holla wrote:
>
>
> On 09/01/18 07:59, Chanwoo Choi wrote:
>> This patch adds the PMU (Power Management Unit) data of exynos5433 SoC
>> in order to support the various power modes. Each power mode has
>> the different value for red
On 2018년 01월 09일 20:56, Krzysztof Kozlowski wrote:
> On Tue, Jan 9, 2018 at 8:58 AM, Chanwoo Choi wrote:
>> In the mainline, there is no case to support the suspend-to-RAM for Samsung
>> Exynos SoC. This patchset support the suspend-to-RAM for 64bit Exynos SoC.
>>
>&g
On 2018년 01월 09일 20:44, Krzysztof Kozlowski wrote:
> On Tue, Jan 9, 2018 at 8:58 AM, Chanwoo Choi wrote:
>> This patch adds the CLK_IS_CRITICAL and CLK_IGNORE_UNUSED flag
>> to some clocks in order to avoid the hang-out in the suspend mode.
>>
>> Signed-off-by: Chanw
cond delayed_work because of dependency
of other consumer driver. But, this patch is not proper method. It looks
like the workaround.
We need to consider the fundamental solution such as using OF graph
or sending the pending notification when consumer driver is probed.
I don't know what is best solution right now. I'll consider the appropriate
method for all extcon provider drivers.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
_extcon_log_rsi(struct axp288_extcon_info *info)
> {
> - char **rsi;
> + const char * const *rsi;
> unsigned int val, i, clear_mask = 0;
> int ret;
>
>
Applied it to v4.17
because I had finished the extcon pull request for v4.16.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On 2018년 01월 15일 17:36, Hans de Goede wrote:
> Hi,
>
> On 15-01-18 06:22, Chanwoo Choi wrote:
>> On 2018년 01월 15일 00:10, Hans de Goede wrote:
>>> The only misdetection which can happen at boot due to data-lines mux issues
>>> is detecting a non SDP as SDP, so we
On 2018년 01월 15일 20:32, Hans de Goede wrote:
> HI,
>
> On 15-01-18 10:08, Chanwoo Choi wrote:
>> On 2018년 01월 15일 17:36, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 15-01-18 06:22, Chanwoo Choi wrote:
>>>> On 2018년 01월 15일 00:10, Hans de Goede
Hi Andrzej and Rob,
On 2018년 03월 09일 18:20, Andrzej Hajda wrote:
> Hi Chanwoo,
>
> On 08.03.2018 02:52, Chanwoo Choi wrote:
>> Hi Andrzej, Archit,
>>
>> On 2018년 03월 07일 20:13, Andrzej Hajda wrote:
>>> Hi Chanwoo, Archit,
>>>
>>> On 07.03.20
sztof will merge dts via
> samsung-soc tree.
>
> Is it OK, for all? Better ideas?
Krzysztof picked the dts patches. I'll make the immutable branch based on
v4.16-rc1
and apply them except for dts patchs. And I'll send the immutable branch to Rob
and Andrzej.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On 2018년 03월 07일 11:12, Chanwoo Choi wrote:
> Hi Rob and Andrzej,
>
> On 2018년 03월 06일 21:53, Andrzej Hajda wrote:
>> Hi Rob, Chanwoo, Krzysztof,
>>
>>
>> On 27.02.2018 08:11, Andrzej Hajda wrote:
>>> Hi,
>>>
>>> Thanks for reviews
1].supply = "iovcc18";
>> 2378 ret = devm_regulator_bulk_get(dev, 2, ctx->supplies);
>> 2379 if (ret)
>> 2380 return ret;
>> 2381
>> 2382 ret = sii8620_extcon_init(ctx);
>> 2383 if (ret < 0) {
>> 2384 dev_err(ctx->dev, "failed to initialize
>> EXTCON\n");
>> 2385 return ret;
>> 2386 }
>> 2387
>> 2388 i2c_set_clientdata(client, ctx);
>> 2389
>> 2390 ctx->bridge.funcs = &sii8620_bridge_funcs;
>> 2391 ctx->bridge.of_node = dev->of_node;
>> 2392 drm_bridge_add(&ctx->bridge);
>> 2393
>> 2394 if (!ctx->extcon)
>> 2395 sii8620_cable_in(ctx);
>> 2396
>> 2397 return 0;
>> 2398 }
>> 2399
>> 2400 static int sii8620_remove(struct i2c_client *client)
>> 2401 {
>> 2402 struct sii8620 *ctx = i2c_get_clientdata(client);
>> 2403
>> 2404 if (ctx->extcon) {
>>> 2405extcon_unregister_notifier(ctx->extcon,
>>> EXTCON_DISP_MHL,
>> 2406 &ctx->extcon_nb);
>> 2407 flush_work(&ctx->extcon_wq);
>> 2408 if (ctx->cable_state > 0)
>> 2409 sii8620_cable_out(ctx);
>> 2410 } else {
>> 2411 sii8620_cable_out(ctx);
>> 2412 }
>> 2413 drm_bridge_remove(&ctx->bridge);
>> 2414
>> 2415 return 0;
>> 2416 }
>> 2417
>>
>> ---
>> 0-DAY kernel test infrastructureOpen Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
20,7 @@
>
> #include
> #include
> -#include
> +#include
> #include
> #include
> #include
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
ce(struct device *dev,
> mutex_unlock(&devfreq_list_lock);
>
> device_unregister(&devfreq->dev);
> + devfreq = NULL;
It is wrong. If you initialize the devfreq as NULL,
never free the 'devfreq' instance.
> err_dev:
> if (devfreq)
> kfree(devfreq);
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On 2018년 04월 13일 10:03, Chanwoo Choi wrote:
> Hi,
>
> I'm sorry for the late reply.
>
> On 2018년 03월 30일 20:44, Arvind Yadav wrote:
>> Never directly free @dev after calling device_register() or
>> device_unregister(), even if device_register() returned an erro
On 2018년 04월 13일 10:09, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 04월 10일 21:43, Wolfram Sang wrote:
>> Since commit eca0f13c836a ("extcon: int3496: Ignore incorrect
>> IoRestriction for ID pin"), the driver doesn't use GPIOF_* flags
>> anymore. We can thu
On 2018년 04월 13일 11:15, arvindY wrote:
> Hi Chanwoo,
>
> On Friday 13 April 2018 06:43 AM, Chanwoo Choi wrote:
>> On 2018년 04월 13일 10:03, Chanwoo Choi wrote:
>>> Hi,
>>>
>>> I'm sorry for the late reply.
>>>
>>> On 2018년 03월 3
On 2018년 04월 13일 11:37, arvindY wrote:
>
>
> On Friday 13 April 2018 07:59 AM, Chanwoo Choi wrote:
>> On 2018년 04월 13일 11:15, arvindY wrote:
>>> Hi Chanwoo,
>>>
>>> On Friday 13 April 2018 06:43 AM, Chanwoo Choi wrote:
>>>> On 2018년 04월 13
Dear Greg,
This is extcon-next pull request for v4.17. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit 4a3928c6f8a53fa1aed28ccba227742486e8ddcb:
Linux 4.16-rc3 (2018-02-25 18
C is only used on X86)
> -Use new acpi_dev_get_first_match_name() helper to get the INT3496 device-name
> -Add Heikki's Reviewed-by
> ---
> drivers/extcon/Kconfig | 3 +-
> drivers/extcon/extcon-axp288.c | 176
> +++++++--
> 2 files changed, 170 insertions(+), 9 deletions(-)
Acked-by: Chanwoo Choi
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Andrzej, Archit,
On 2018년 03월 07일 20:13, Andrzej Hajda wrote:
> Hi Chanwoo, Archit,
>
> On 07.03.2018 05:48, Chanwoo Choi wrote:
>> On 2018년 03월 07일 11:12, Chanwoo Choi wrote:
>>> Hi Rob and Andrzej,
>>>
>>> On 2018년 03월 06일 21:53, Andrzej Ha
Hi Lukasz,
On 2018년 11월 22일 19:40, Lukasz Luba wrote:
> Hi Chanwoo Choi
>
> On 11/22/18 3:52 AM, Chanwoo Choi wrote:
>> On 2018년 11월 22일 03:01, Lukasz Luba wrote:
>>> The refactoring is needed for the new client in devfreq: suspend.
>>> To avoid code dupl
Hi Lukasz,
I add one more comment about devfreq_resume_device().
On 2018년 11월 22일 20:00, Lukasz Luba wrote:
>
>
> On 11/22/18 3:58 AM, Chanwoo Choi wrote:
>> On 2018년 11월 22일 03:01, Lukasz Luba wrote:
>>> The patch adds support for handling suspend/resume process.
>
Hi Lukasz,
I add the one more comment for devfreq_resume_device()
On 2018년 11월 23일 19:01, Lukasz Luba wrote:
> Hi Chanwoo Choi,
>
> On 11/23/18 12:54 AM, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> I add one more comment about devfreq_resume_device().
>>
>> On
g3d bus node using VDD_INI
> for Exynos542x SoC.
>
> - CLK_DOUT_ACLK_G3D for G3D's AXI
>
> Cc: Chanwoo Choi
> Signed-off-by: Anand Moon
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 57 +--
> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 5 ++
> 2
Hi,
On 2018년 11월 23일 18:44, Anand Moon wrote:
> From: Marian Mihailescu
>
> A specific clock rate table is added for VPLL so it is possible
> to set frequency of the VPLL output clock that used by the g3d clock.
>
> Cc: Andrzej Hajda
> Cc: Chanwoo Choi
> Signed-o
RBG_TX21
> +#define CLK_ACLK_GIC 22
> +#define CLK_ACLK_INT_MEM 23
> +#define CLK_ACLK_XIU_PIMEMX 24
> +#define CLK_ACLK_AXI2APB_IMEM0P 25
> +#define CLK_ACLK_AXI2APB_IMEM1P 26
> +#define CLK_ACLK_ASYNCAXIS_MIF_PIMEMX27
> +#define CLK_ACLK_AXIDS_PIMEMX_GIC28
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM0P 29
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM1P 30
> +#define CLK_ACLK_SROMC 31
> +#define CLK_ACLK_AXIDS_SROMC 32
> +#define CLK_ACLK_AXI2AHB_IMEMH 33
> +#define CLK_PCLK_SSS 34
> +#define CLK_PCLK_SLIMSSS 35
> +#define CLK_PCLK_RTIC36
> +#define CLK_PCLK_SYSREG_IMEM 37
> +#define CLK_PCLK_PMU_IMEM38
> +#define CLK_PCLK_ALB_IMEM39
> +#define CLK_PCLK_BTS_SSS_CCI 40
> +#define CLK_PCLK_BTS_SSS_DRAM41
> +#define CLK_PCLK_BTS_SLIMSSS 42
> +#define CLK_PCLK_SMMU_SSS_CCI43
> +#define CLK_PCLK_SMMU_SSS_DRAM 44
> +#define CLK_PCLK_SMMU_SLIMSSS45
> +#define CLK_PCLK_SMMU_RTIC 46
> +#define CLK_PCLK_ASYNCAPB_ARBG_TX47
> +#define CLK_PCLK_BTS_ARBG_TX 48
> +#define CLK_PCLK_SMMU_ARBG_TX49
> +#define CLK_PCLK_ASYNCAXI_IMEMX 50
> +#define CLK_PCLK_GPIO_IMEM 51
> +
> +#define IMEM_NR_CLK 52
> +
> /* CMU_G2D */
> #define CLK_MUX_ACLK_G2D_266_USER1
> #define CLK_MUX_ACLK_G2D_400_USER2
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
is patch address them keeping in mind suggestions
> from Chanwoo Choi.
You already explain the patch history on cover letter. It is enough.
Please remove the duplicate history description from all patches except for
cover letter.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Cho
o
> solve issue with devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
As I commented on patch1, please remove
On 2018년 11월 22일 11:52, Chanwoo Choi wrote:
> On 2018년 11월 22일 03:01, Lukasz Luba wrote:
>> The refactoring is needed for the new client in devfreq: suspend.
>> To avoid code duplication, move it to the new local function
>> devfreq_set_target.
>>
>> The patch dra
olve issue with devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
Please remove the duplicate information about patc
ith devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
Please remove the duplicate information about patch history.
During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
> arc
rs ago, who tried to
> solve issue with devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
Please remove the dupl
10
> +#define CLK_ACLK_SMMU_SSS_DRAM 11
> +#define CLK_ACLK_SMMU_SLIMSSS12
> +#define CLK_ACLK_SMMU_RTIC 13
> +#define CLK_ACLK_IMEMND_266 14
> +#define CLK_ACLK_ALB_IMEM15
> +#define CLK_ACLK_XIU_IMEMX 16
> +#define CLK_ACLK_AXIUS_IMEMX 17
> +#define CLK_ACLK_ASYNCAXI_IMEMX 18
> +#define CLK_ACLK_ARBG_TX 19
> +#define CLK_ACLK_BTS_ARBG_TX 20
> +#define CLK_ACLK_SMMU_ARBG_TX21
> +#define CLK_ACLK_GIC 22
> +#define CLK_ACLK_INT_MEM 23
> +#define CLK_ACLK_XIU_PIMEMX 24
> +#define CLK_ACLK_AXI2APB_IMEM0P 25
> +#define CLK_ACLK_AXI2APB_IMEM1P 26
> +#define CLK_ACLK_ASYNCAXIS_MIF_PIMEMX27
> +#define CLK_ACLK_AXIDS_PIMEMX_GIC28
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM0P 29
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM1P 30
> +#define CLK_ACLK_SROMC 31
> +#define CLK_ACLK_AXIDS_SROMC 32
> +#define CLK_ACLK_AXI2AHB_IMEMH 33
> +#define CLK_PCLK_SSS 34
> +#define CLK_PCLK_SLIMSSS 35
> +#define CLK_PCLK_RTIC36
> +#define CLK_PCLK_SYSREG_IMEM 37
> +#define CLK_PCLK_PMU_IMEM38
> +#define CLK_PCLK_ALB_IMEM39
> +#define CLK_PCLK_BTS_SSS_CCI 40
> +#define CLK_PCLK_BTS_SSS_DRAM41
> +#define CLK_PCLK_BTS_SLIMSSS 42
> +#define CLK_PCLK_SMMU_SSS_CCI43
> +#define CLK_PCLK_SMMU_SSS_DRAM 44
> +#define CLK_PCLK_SMMU_SLIMSSS45
> +#define CLK_PCLK_SMMU_RTIC 46
> +#define CLK_PCLK_ASYNCAPB_ARBG_TX47
> +#define CLK_PCLK_BTS_ARBG_TX 48
> +#define CLK_PCLK_SMMU_ARBG_TX49
> +#define CLK_PCLK_ASYNCAXI_IMEMX 50
> +#define CLK_PCLK_GPIO_IMEM 51
> +
> +#define IMEM_NR_CLK 52
> +
> /* CMU_G2D */
> #define CLK_MUX_ACLK_G2D_266_USER1
> #define CLK_MUX_ACLK_G2D_400_USER2
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
843.c | 18 +++---
> drivers/extcon/extcon-max8997.c | 15 +++++++++--
> 4 files changed, 55 insertions(+), 9 deletions(-)
>
Applied them. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
= max8997_muic_set_path(info, info->path_usb, attached);
> + if (ret < 0) {
> + dev_err(info->dev, "failed to update muic register\n");
> + return ret;
> }
>
> switch (usb_type) {
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
t:
> mutex_unlock(&info->lock);
> - return 0;
> + return ret;
> }
>
> static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm)
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Lukasz,
On 2018년 12월 04일 18:53, Lukasz Luba wrote:
> Hi Chanwoo,
>
> On 12/4/18 7:10 AM, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> I add the comment about 'suspend_count'.
>>
>> On 2018년 12월 04일 14:43, Chanwoo Choi wrote:
>>> Hi,
&
tions in the drivers code. It uses atomic variables to
> make sure no race condition affects the process.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
> drivers/devfreq/devfreq.c | 47
>
Hi Lukasz,
On 2018년 12월 05일 20:05, Lukasz Luba wrote:
> This patch adds implementation for global suspend/resume for
> devfreq framework. System suspend will next use these functions.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
mmented, Please remove it. You already mentioned it on
cover-letter.
If you want to contain the contribution history of Tobias, you might better
to add 'Signed-off-by' or others.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
&g
Hi Lukasz,
Looks good to me. But, I add the some comments.
If you will fix it, feel free to add my tag:
Reviewed-by: Chanwoo choi
On 2018년 12월 03일 23:31, Lukasz Luba wrote:
> The patch prepares devfreq device for handling suspend/resume
> functionality. The new fields will store
Hi,
On 2018년 12월 04일 13:39, Chanwoo Choi wrote:
> Hi Lukasz,
>
> On 2018년 12월 03일 23:31, Lukasz Luba wrote:
>> The refactoring is needed for the new client in devfreq: suspend.
>> To avoid code duplication, move it to the new local function
>> devfreq_set_target.
Hi,
On 2018년 12월 04일 14:36, Chanwoo Choi wrote:
> Hi Lukasz,
>
> Looks good to me. But, I add the some comments.
> If you will fix it, feel free to add my tag:
> Reviewed-by: Chanwoo choi
Sorry. Fix typo 'choi' to 'Choi' as following.
Reviewed-by: Chanwoo
Hi Lukasz,
I add the comment about 'suspend_count'.
On 2018년 12월 04일 14:43, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 12월 04일 14:36, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> Looks good to me. But, I add the some comments.
>> If you will fix it, feel free
description.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
> drivers/devfreq/devfreq.c | 42 ++
> include/linux/devfreq.h | 6 ++
> 2 files changed, 48 insertions(+)
>
>
devfreq->scaling_max_freq) {
> mutex_unlock(&devfreq->lock);
> err = -EINVAL;
> goto err_dev;
> }
> - devfreq->scaling_max_freq = devfreq->max_freq;
> + devfreq->max_freq = devfreq->scaling_max_freq;
>
df->max_freq;
> return 0;
> }
>
> /* Set MAX if we do not know the initial frequency */
> if (stat->current_frequency == 0) {
> - *freq = max;
> + *freq = df->max_freq;
> return 0;
> }
>
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
&& adjusted_freq < df->min_freq)
> - adjusted_freq = df->min_freq;
> -
> - *freq = adjusted_freq;
> - } else {
> + if (data->valid)
> + *freq = data->user_frequency;
> + else
> *freq = df->previous_freq; /* No user freq specified yet */
> - }
> +
> return 0;
> }
>
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
goto unlock;
> + }
> }
>
> df->max_freq = value;
>
Actually, min_freq_store() and max_freq_store() are very similar.
But, this patch changed the order of conditional statement as following:
If there is no special reason, you better to keep the same format
for the readability.
min_freq_store()
if (value) {
...
} else {
value = df->profile->freq_table[df->profile->max_state - 1];
}
max_freq_store()
if (!value) {
value = df->profile->freq_table[0];
} else {
...
--
Best Regards,
Chanwoo Choi
Samsung Electronics
->max_freq;
> + *freq = df->scaling_max_freq;
> return 0;
> }
>
> /* Set MAX if we do not know the initial frequency */
> if (stat->current_frequency == 0) {
> - *freq = df->max_freq;
> + *freq = df->scaling_max_freq;
> return 0;
> }
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
evfreq patches separately.
Regards,
Chanwoo Choi
On 2018년 05월 26일 05:30, Matthias Kaehlcke wrote:
> The purpose of the throttler is to provide support for non-thermal
> throttling. Throttling is triggered by external event, e.g. the
> detection of a high battery discharge current, close to t
9_GRF_H
> +#define __SOC_RK3399_GRF_H
> +
> +/* PMU GRF Registers */
> +#define RK3399_PMUGRF_OS_REG20x308
> +#define RK3399_PMUGRF_DDRTYPE_SHIFT 13
> +#define RK3399_PMUGRF_DDRTYPE_MASK 7
> +#define RK3399_PMUGRF_DDRTYPE_DDR3 3
> +#define RK3399_PMUGRF_DDRTYPE_LPDDR2 5
> +#define RK3399_PMUGRF_DDRTYPE_LPDDR3 6
> +#define RK3399_PMUGRF_DDRTYPE_LPDDR4 7
> +
> +#endif
>
Looks good to me.
Acked-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
t;
>> Changes in v3: None
>> Changes in v2: None
>>
>> drivers/devfreq/rk3399_dmc.c | 12 ++--
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Acked-by: MyungJoo Ham
Maybe, when you apply this patch on devfreq.git,
you are missing the my reviewed-by tag.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
2018-06-14 20:33 GMT+09:00 H. Nikolaus Schaller :
>
>> Am 14.06.2018 um 12:39 schrieb H. Nikolaus Schaller :
>>
>> Hi Roger and Chanwoo,
>>
>>> Am 14.06.2018 um 12:18 schrieb Chanwoo Choi :
>>>
>>> + H. Nikolaus Schaller
>>>
goto err_free_opp;
> + }
> +
> devm_devfreq_register_opp_notifier(dev, data->devfreq);
>
> data->dev = dev;
> platform_set_drvdata(pdev, data);
>
> + return 0;
It looks strange. Because rk3399_dmcfreq_probe() already include
'return 0' when success.
What is the base commit of this patch?
[snip]
Anyway, if probe fail, device driver have to remove registered OPP table.
Looks good to me.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
ble to find governor for the
> device\n",
> + __func__);
> + err = PTR_ERR(governor);
> + goto err_init;
> + }
> }
>
> devfreq->governor = governor;
> @@ -669
401 - 500 of 3909 matches
Mail list logo
