[f2fs-dev][PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache

2015-01-25 Thread Chao Yu
f2fs_kmem_cache_alloc/f2fs_radix_tree_insert for code readability. o fix some coding style and typo issues. o get rid of node/tree count stat in f2fs_{shrink,destroy}_extent_tree. Signed-off-by: Chao Yu chao2...@samsung.com Signed-off-by: Jaegeuk Kim jaeg...@kernel.org Signed-off-by: Changman

RE: [f2fs-dev] [PATCH 1/2] f2fs: trigger correct checkpoint during umount

2015-01-23 Thread Chao Yu
, this patch adds a flag to indicate f2fs_sync_fs is called during umount. Nice catch! Signed-off-by: Jaegeuk Kim jaeg...@kernel.org Reviewed-by: Chao Yu chao2...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

RE: [f2fs-dev] [PATCH 2/2] f2fs: do checkpoint when umount flag is not set

2015-01-23 Thread Chao Yu
umount flag is not set If the previous checkpoint was done without CP_UMOUNT flag, it needs to do checkpoint with CP_UMOUNT for the next fast boot. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org Reviewed-by: Chao Yu chao2...@samsung.com --- fs/f2fs/checkpoint.c | 3 ++- fs/f2fs/super.c

RE: [f2fs-dev] [PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache

2015-02-01 Thread Chao Yu
Hi all, -Original Message- From: Chao Yu [mailto:chao2...@samsung.com] Sent: Monday, January 26, 2015 1:52 PM To: Jaegeuk Kim; Changman Lee Cc: linux-kernel@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: [f2fs-dev] [PATCH v2 06/10] f2fs: add core functions for rb

[f2fs-dev][PATCH] f2fs: fix wrong memory footprint statistics in debugfs

2015-01-06 Thread Chao Yu
Our value of memory footprint statistics showed in debugfs is not calculated correctly. Fix it in this patch. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/debug.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c

[f2fs-dev][PATCH 2/2] f2fs: enable recover_xattr_data to avoid cp when fsync after operating xattr

2015-01-05 Thread Chao Yu
node segment, and then it can be recovered when we mount this device later on. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/f2fs.h | 3 +-- fs/f2fs/file.c | 3 --- fs/f2fs/node.c | 28 fs/f2fs/node.h | 2 +- fs/f2fs/recovery.c | 4 +++- fs

[f2fs-dev][PATCH 1/2] f2fs: get rid of kzalloc in __recover_inline_status

2015-01-05 Thread Chao Yu
We use kzalloc to allocate memory in __recover_inline_status, and use this all-zero memory to check the inline date content of inode page by comparing them. This is low effective and not needed, let's check inline date content directly. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs

RE: [f2fs-dev][PATCH] f2fs: fix wrong memory footprint statistics in debugfs

2015-01-10 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, January 07, 2015 3:49 AM To: Chao Yu Cc: Changman Lee; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev][PATCH] f2fs: fix wrong memory footprint

RE: [f2fs-dev][PATCH 1/2] f2fs: get rid of kzalloc in __recover_inline_status

2015-01-10 Thread Chao Yu
Hi, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, January 07, 2015 3:32 AM To: Chao Yu Cc: Changman Lee; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev][PATCH 1/2] f2fs: get rid of kzalloc

RE: [f2fs-dev][PATCH 2/2] f2fs: enable recover_xattr_data to avoid cp when fsync after operating xattr

2015-01-10 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, January 07, 2015 3:44 AM To: Chao Yu Cc: Changman Lee; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev][PATCH 2/2] f2fs: enable

RE: [RFC PATCH] f2fs: add extent cache base on rb-tree

2015-01-11 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, January 07, 2015 7:01 AM To: Chao Yu Cc: 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] f2fs: add extent cache base on rb

[f2fs-dev][RFC PATCH 05/10] f2fs: introduce infra macro and data structure of rb-tree extent cache

2015-01-11 Thread Chao Yu
will be shrunk. Basic data structures for extent cache: * struct extent_tree: extent tree entry per inode. * struct extent_node: extent info node linked in extent tree. Besides, adding new extent cache related fields in f2fs_sb_info. Signed-off-by: Chao Yu chao2...@samsung.com Signed-off

[f2fs-dev][RFC PATCH 06/10] f2fs: add core functions for rb-tree extent cache

2015-01-11 Thread Chao Yu
into struct extent_tree for a quick recent cache. * register rb-based extent cache shrink with mm shrink interface. * disable dir inode's extent cache. Signed-off-by: Chao Yu chao2...@samsung.com Signed-off-by: Jaegeuk Kim jaeg...@kernel.org Signed-off-by: Changman Lee cm224@samsung.com --- fs

[f2fs-dev][RFC PATCH 07/10] f2fs: add a mount option for rb-tree extent cache

2015-01-11 Thread Chao Yu
-by: Chao Yu chao2...@samsung.com --- Documentation/filesystems/f2fs.txt | 4 fs/f2fs/f2fs.h | 1 + fs/f2fs/super.c| 7 +++ 3 files changed, 12 insertions(+) diff --git a/Documentation/filesystems/f2fs.txt b/Documentation/filesystems/f2fs.txt index

[f2fs-dev][RFC PATCH 01/10] f2fs: move ext_lock out of struct extent_info

2015-01-11 Thread Chao Yu
Move ext_lock out of struct extent_info, then in the following patches we can use variables with struct extent_info type as a parameter to pass pure data. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 12 ++-- fs/f2fs/f2fs.h | 6 +- fs/f2fs/inode.c | 7

RE: [f2fs-dev][PATCH 2/2] f2fs: enable recover_xattr_data to avoid cp when fsync after operating xattr

2015-01-12 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Sunday, January 11, 2015 1:32 PM To: Chao Yu Cc: 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev][PATCH 2/2] f2fs: enable

[f2fs-dev][RFC PATCH 08/10] f2fs: enable rb-tree extent cache

2015-01-11 Thread Chao Yu
(offset: 48M, size: 1M); 5.echo 3 /proc/sys/vm/drop_caches 6.read file originalnew Hit Ratio 61 / 264264 / 264 Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c| 13 + fs/f2fs/f2fs.h| 5 + fs/f2fs/inode.c | 1 + fs/f2fs

[f2fs-dev][RFC PATCH 09/10] f2fs: show extent tree,node stat info in debugfs

2015-01-11 Thread Chao Yu
This patch add and show stat info of total memory footprint for extent tree,node in debugfs. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/debug.c | 7 +++ fs/f2fs/f2fs.h | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c index

[f2fs-dev][RFC PATCH 10/10] f2fs: add trace for rb-tree extent cache ops

2015-01-11 Thread Chao Yu
This patch adds trace for lookup/update/shrink/destroy ops in rb-tree extent cache. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 9 +++ include/trace/events/f2fs.h | 134 2 files changed, 143 insertions(+) diff

RE: [RFC PATCH] f2fs: add extent cache base on rb-tree

2015-01-11 Thread Chao Yu
Hi Changman, -Original Message- From: Changman Lee [mailto:cm224@samsung.com] Sent: Wednesday, January 07, 2015 7:17 PM To: Chao Yu Cc: 'Jaegeuk Kim'; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] f2fs: add extent cache base

[f2fs-dev][RFC PATCH 04/10] f2fs: introduce universal lookup/update interface for extent cache

2015-01-11 Thread Chao Yu
cleanup, we can add new rb-tree based extent cache into exported interfaces. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 66 +- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 2 +- fs/f2fs/inline.c | 2 +- fs/f2fs

[f2fs-dev][RFC PATCH 03/10] f2fs: introduce f2fs_map_bh to clean codes of check_extent_cache

2015-01-11 Thread Chao Yu
This patch introduces f2fs_map_bh to clean codes of check_extent_cache. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 935a23b

[f2fs-dev][RFC PATCH 02/10] f2fs: simplfy a field name in struct f2fs_extent,extent_info

2015-01-11 Thread Chao Yu
Rename a filed name from 'blk_addr' to 'blk' in struct {f2fs_extent,extent_info} as annotation of this field descripts its meaning well to us. By this way, we can avoid long statement in code of following patches. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 13

RE: [f2fs-dev][PATCH 2/2] f2fs: enable recover_xattr_data to avoid cp when fsync after operating xattr

2015-01-13 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, January 14, 2015 8:22 AM To: Chao Yu Cc: 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev][PATCH 2/2] f2fs: enable

[PATCH] f2fs: avoid data offset overflow when lseeking huge file

2015-02-08 Thread Chao Yu
offset: loff_t. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 5cbbc9a..7dc0ed8 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -357,7 +357,7 @@ static loff_t f2fs_seek_block

[PATCH] f2fs: use spinlock for segmap_lock instead of rwlock

2015-02-11 Thread Chao Yu
it with spinlock_t type. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/segment.c | 6 +++--- fs/f2fs/segment.h | 18 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index c542f63..5a6c818 100644 --- a/fs/f2fs/segment.c +++ b/fs

[PATCH 1/4] f2fs: remove unused inline_dentry_addr

2015-02-16 Thread Chao Yu
inline_dentry_addr is introduced with inline dentry feature without being used, now we do not need to keep it for any reason, so remove it. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/f2fs.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h

[PATCH 2/4] f2fs: introduce f2fs_update_dentry to clean up duplicated codes

2015-02-16 Thread Chao Yu
This patch introduces f2fs_update_dentry to remove redundant code in f2fs_add_inline_entry and __f2fs_add_link. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/dir.c| 33 +++-- fs/f2fs/f2fs.h | 2 ++ fs/f2fs/inline.c | 18 ++ 3 files

[PATCH 3/4] f2fs: use -writepage in sync_meta_pages

2015-02-16 Thread Chao Yu
This patch uses -writepage of meta mapping in sync_meta_pages instead of f2fs_write_meta_page, by this way, in its caller we can ignore any changes (e.g. changing name) of this registered function. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/checkpoint.c | 2 +- 1 file changed, 1

RE: [f2fs-dev] [PATCH v3 06/10] f2fs: add core functions for rb-tree extent cache

2015-02-16 Thread Chao Yu
Ping. Any comments on this patch now? -Original Message- From: Chao Yu [mailto:chao2...@samsung.com] Sent: Thursday, February 05, 2015 5:55 PM To: Jaegeuk Kim; Changman Lee Cc: linux-kernel@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: [f2fs-dev] [PATCH v3 06/10

[PATCH 4/4] f2fs: fix incorrectly stat number of inline data inode

2015-02-16 Thread Chao Yu
We should stat inline data information for temp file in f2fs_tmpfile if we enable inline_data feature. Otherwise, inline data stat number will be wrong after this temp file is evicted. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/namei.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v3 06/10] f2fs: add core functions for rb-tree extent cache

2015-02-05 Thread Chao Yu
issues. v3: o fix oops due to using an unassigned pointer. o use list_del to remove extent node in shrink list. Signed-off-by: Chao Yu chao2...@samsung.com Signed-off-by: Jaegeuk Kim jaeg...@kernel.org Signed-off-by: Changman Lee cm224@samsung.com --- fs/f2fs/data.c | 411

RE: [RFC PATCH] f2fs: add extent cache base on rb-tree

2015-01-03 Thread Chao Yu
Hi Changman, Sorry for replying late! -Original Message- From: Changman Lee [mailto:cm224@samsung.com] Sent: Tuesday, December 30, 2014 8:32 AM To: Jaegeuk Kim Cc: Chao Yu; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] f2fs: add

RE: [RFC PATCH] f2fs: add extent cache base on rb-tree

2015-01-04 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, December 31, 2014 4:26 PM To: Chao Yu Cc: 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] f2fs: add extent cache base on rb

[PATCH] f2fs: set SBI_NEED_FSCK when encountering exception in recovery

2015-03-16 Thread Chao Yu
This patch tries to set SBI_NEED_FSCK flag into sbi only when we fail to recover in fill_super, so we could skip fscking image when we fail to fill super for other reason. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/super.c | 10 ++ 1 file changed, 6 insertions(+), 4

RE: [PATCH v3] f2fs: add fast symlink support

2015-03-16 Thread Chao Yu
Hi Wanpeng, Jaegeuk, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Friday, March 13, 2015 2:34 PM To: Jaegeuk Kim Cc: Changman Lee; Chao Yu; linux-f2fs-de...@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; Wanpeng

RE: [f2fs-dev] [PATCH 4/4] f2fs: avoid wrong f2fs_bug_on when truncating inline_data

2015-03-17 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, March 18, 2015 12:58 AM To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 4/4] f2fs: avoid

RE: [f2fs-dev] [PATCH 2/4] f2fs: set buffer_new when new blocks are allocated

2015-03-17 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, March 18, 2015 12:58 AM To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 2/4] f2fs: set

RE: [PATCH v3] f2fs: add fast symlink support

2015-03-18 Thread Chao Yu
Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Thursday, March 19, 2015 7:02 AM To: Jaegeuk Kim Cc: Wanpeng Li; Changman Lee; Chao Yu; linux-f2fs-de...@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org

[PATCH 4/4] f2fs: preserve extent info for extent cache

2015-03-19 Thread Chao Yu
This patch tries to preserve last extent info in extent tree cache into on-disk inode, so this can help us to reuse the last extent info next time for performance. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 49 + fs/f2fs

[PATCH 1/4] f2fs: split set_data_blkaddr from f2fs_update_extent_cache

2015-03-19 Thread Chao Yu
Split __set_data_blkaddr from f2fs_update_extent_cache for readability. Additionally rename __set_data_blkaddr to set_data_blkaddr for exporting. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 10 -- fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 1 + fs/f2fs

RE: [f2fs-dev] [PATCH 4/4] f2fs: avoid wrong f2fs_bug_on when truncating inline_data

2015-03-19 Thread Chao Yu
Hi Jeageuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Thursday, March 19, 2015 1:58 AM To: Chao Yu Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 4/4] f2fs: avoid

RE: [f2fs-dev] [PATCH 2/4 v2] f2fs: set buffer_new when new blocks are allocated

2015-03-19 Thread Chao Yu
-Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Thursday, March 19, 2015 1:57 AM To: Chao Yu Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 2/4 v2] f2fs: set buffer_new

[PATCH 3/4] f2fs: initialize extent tree with on-disk extent info of inode

2015-03-19 Thread Chao Yu
extent. We'd better to load the extent info into extent tree cache when inode is loaded. By this way we can have more chance to hit extent tree cache rather than taking more time to read dnode page for block address. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 43

[PATCH 2/4] f2fs: introduce __{find,grab}_extent_tree

2015-03-19 Thread Chao Yu
This patch introduces __{find,grab}_extent_tree for reusing by following patches. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 79 +++--- 1 file changed, 48 insertions(+), 31 deletions(-) diff --git a/fs/f2fs/data.c b/fs

RE: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-09 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Tuesday, March 10, 2015 11:00 AM To: Chao Yu Cc: 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix to truncate inline data past EOF

[PATCH v2] f2fs: fix to truncate inline data past EOF

2015-03-09 Thread Chao Yu
-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 16 +++- fs/f2fs/inline.c | 26 +- 3 files changed, 33 insertions(+), 10 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 511d6cd..c1ad404 100644 --- a/fs/f2fs

RE: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-09 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Tuesday, March 10, 2015 12:16 AM To: Chao Yu Cc: 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix to truncate inline data past EOF

RE: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-09 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Monday, March 09, 2015 11:49 AM To: Chao Yu Cc: 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix to truncate inline data past EOF

RE: [PATCH RFC] f2fs: add fast symlink

2015-03-12 Thread Chao Yu
Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Thursday, March 12, 2015 2:42 PM To: Chao Yu Cc: 'Wanpeng Li'; 'Jaegeuk Kim'; 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-kernel

[PATCH] f2fs: fix to check current blkaddr in __allocate_data_blocks

2015-03-12 Thread Chao Yu
In __allocate_data_blocks, we should check current blkaddr which is located at ofs_in_node of dnode page instead of checking first blkaddr all the time. Otherwise we can only allocate one blkaddr in each dnode page. Fix it. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 5

RE: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-08 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Friday, March 06, 2015 5:34 AM To: Chao Yu Cc: Changman Lee; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix to truncate inline data past EOF

RE: [PATCH 1/2] f2fs: fix extent cache memory leak

2015-03-08 Thread Chao Yu
Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Friday, March 06, 2015 3:01 PM To: Jaegeuk Kim Cc: Changman Lee; Chao Yu; linux-f2fs-de...@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; Wanpeng Li

RE: [f2fs-dev] [PATCH 2/3] f2fs:set the correct place of initializing *res_page

2015-03-09 Thread Chao Yu
codes. Thank you. Signed-off-by: Yuan Zhong yuan.mark.zh...@samsung.com Reviewed-by: Chao Yu chao2...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

RE: [f2fs-dev] [PATCH 1/3 v2] f2fs:remove unnecessary condition judgment

2015-03-09 Thread Chao Yu
unnecessary condition judgment Remove the unnecessary condition judgment, because 'max_slots' has been initialized to '0' at the beginging of the function, as following: if (max_slots) *max_slots = 0; Signed-off-by: Yuan Zhong yuan.mark.zh...@samsung.com Reviewed-by: Chao Yu chao2

RE: [f2fs-dev] [PATCH 3/3] f2fs:use enum dentrt_ptr type to replace constant use

2015-03-09 Thread Chao Yu
Hi Yuan, -Original Message- From: Yuan Zhong [mailto:yuan.mark.zh...@samsung.com] Sent: Saturday, March 07, 2015 6:10 PM To: Jaegeuk Kim Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: [f2fs-dev] [PATCH 3/3] f2fs:use

RE: [PATCH v2] f2fs: add fast symlink support

2015-03-12 Thread Chao Yu
Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Thursday, March 12, 2015 5:12 PM To: Jaegeuk Kim Cc: Changman Lee; Chao Yu; linux-f2fs-de...@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; Wanpeng Li

[PATCH] f2fs: fix to calculate max length of contiguous free slots correctly

2015-03-09 Thread Chao Yu
) update max_slots with max_len if max_len is larger than max_slots; c) reset max_len to zero if current slot is not free. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/dir.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index

[PATCH] f2fs: fix reference leaks in f2fs_acl_create

2015-03-09 Thread Chao Yu
. https://lkml.org/lkml/2015/2/9/5 Let's fix this issue in f2fs_acl_create too. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/acl.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index 7422027..4320ffa 100644 --- a/fs/f2fs

RE: [PATCH 2/3] f2fs: fix get stale meta pages when build free nids

2015-03-09 Thread Chao Yu
Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Monday, March 09, 2015 12:25 PM To: Jaegeuk Kim Cc: Changman Lee; Chao Yu; linux-f2fs-de...@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; Wanpeng Li

RE: [PATCH RFC] f2fs: add fast symlink

2015-03-11 Thread Chao Yu
Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Wednesday, March 11, 2015 7:52 PM To: Jaegeuk Kim Cc: Changman Lee; Chao Yu; linux-f2fs-de...@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; Wanpeng Li

[PATCH 1/4] f2fs: limit b_size of mapped bh in f2fs_map_bh

2015-03-22 Thread Chao Yu
Map bh over max size which caller defined is not needed, limit it in f2fs_map_bh. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index f0a18a0..a99bc7f 100644 --- a/fs/f2fs

[PATCH 2/4] f2fs: preallocate fallocated blocks for direct IO

2015-03-22 Thread Chao Yu
: 67108864 bytes (67 MB) copied, 36.16 s, 1.9 MB/s real0m36.162s user0m0.000s sys 0m0.180s Time after applying the patch: 67108864 bytes (67 MB) copied, 27.7776 s, 2.4 MB/s real0m27.780s user0m0.000s sys 0m0.036s Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs

[PATCH 3/4] f2fs: avoid NULL pointer dereference in f2fs_xattr_advise_get

2015-03-22 Thread Chao Yu
pointer directly without checking whether the pointer is valid or not in f2fs_xattr_advise_get, so the oops occurs. This patch fixes this issue by verifying @value pointer before using. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/xattr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 4/4] f2fs: persist system.advise into on-disk inode

2015-03-22 Thread Chao Yu
This patch fixes to dirty inode for persisting i_advise of f2fs inode info into on-disk inode if user sets system.advise through setxattr. Otherwise the new value will be lost. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/xattr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs

RE: [PATCH v2 1/2] f2fs: enable inline data by default

2015-03-23 Thread Chao Yu
Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Monday, March 23, 2015 7:44 AM To: Jaegeuk Kim Cc: Changman Lee; Chao Yu; linux-f2fs-de...@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; Wanpeng Li

RE: [PATCH v2 1/2] f2fs: enable inline data by default

2015-03-23 Thread Chao Yu
Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Monday, March 23, 2015 3:15 PM To: Chao Yu Cc: 'Jaegeuk Kim'; 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; Wanpeng Li

RE: [PATCH v2] f2fs: fix max orphan inodes calculation

2015-02-28 Thread Chao Yu
-Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Friday, February 27, 2015 5:38 PM To: Jaegeuk Kim Cc: Changman Lee; Chao Yu; linux-f2fs-de...@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; Wanpeng Li Subject: [PATCH

[PATCH] f2fs: fix to issue small discard in real-time mode discard

2015-02-28 Thread Chao Yu
fragmented freespace or not, this makes us ignore small discard sometimes. Fix it. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index daee4ab..fcc1cc2 100644 --- a/fs

RE: [f2fs-dev] [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries

2015-02-28 Thread Chao Yu
-by: Wanpeng Li wanpeng...@linux.intel.com Reviewed-by: Chao Yu chao2...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

RE: [f2fs-dev] [PATCH] f2fs: fix max orphan inodes calculation

2015-02-27 Thread Chao Yu
Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Friday, February 27, 2015 3:05 PM To: Jaegeuk Kim Cc: Wanpeng Li; linux-kernel@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: [f2fs-dev] [PATCH] f2fs: fix max orphan inodes

[PATCH] f2fs: fix to truncate inline data past EOF

2015-03-05 Thread Chao Yu
() to truncate_inline_inode() for code readability, then intruduces new truncate_inline_data() and use it to truncate inline data in page #0 and inode page in truncate_partial_data_page() for fixing. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 13 - fs/f2fs

RE: [f2fs-dev] [PATCH 2/2] f2fs: avoid wrong error during recovery

2015-02-25 Thread Chao Yu
-by: Chao Yu chao2...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [f2fs-dev] [PATCH 1/2] f2fs: introduce macro __cp_payload

2015-02-25 Thread Chao Yu
__cp_payload This patch introduce macro __cp_payload. Good work! This patch looks good to me. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com Reviewed-by: Chao Yu chao2...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

RE: [f2fs-dev] [PATCH 2/2] f2fs: fix the number of orphan inode blocks

2015-02-25 Thread Chao Yu
to reduce the number of cp payload blocks when calculate the number of orphan inode blocks. This patch fix it. Nice work! looks good to me. :) Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com Reviewed-by: Chao Yu chao2...@samsung.com -- To unsubscribe from this list: send the line

RE: [PATCH 1/4] f2fs: limit b_size of mapped bh in f2fs_map_bh

2015-03-23 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Tuesday, March 24, 2015 12:42 PM To: Chao Yu Cc: Changman Lee; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] f2fs: limit b_size of mapped bh

[PATCH v2] f2fs: limit b_size of mapped bh in f2fs_map_bh

2015-03-23 Thread Chao Yu
Map bh over max size which caller defined is not needed, limit it in f2fs_map_bh. Signed-off-by: Chao Yu chao2...@samsung.com --- v2 change log: - use min() for cleanup code suggested by Jaegeuk Kim. fs/f2fs/data.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

RE: [PATCH v2] f2fs: fix max orphan inodes calculation

2015-03-05 Thread Chao Yu
Hi Changman, -Original Message- From: Changman Lee [mailto:cm224@samsung.com] Sent: Tuesday, March 03, 2015 9:40 AM To: linux-f2fs-de...@lists.sourceforge.net Cc: Jaegeuk Kim; Chao Yu; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] f2fs

[f2fs-dev][PATCH] f2fs: use f2fs_radix_tree_insert to clean codes

2015-01-23 Thread Chao Yu
No modification in functionality, just clean codes with f2fs_radix_tree_insert. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/gc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 40887d3..180b161 100644 --- a/fs/f2fs/gc.c

[f2fs-dev][PATCH] f2fs: add F2FS_IOC_GETVERSION support

2015-01-23 Thread Chao Yu
In this patch we add the FS_IOC_GETVERSION ioctl for getting i_generation from inode, after that, users can list file's generation number by using lsattr -v. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 9 + 2 files changed, 10 insertions

RE: [PATCH 2/5] f2fs: support norecovery mount option

2015-01-29 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Friday, January 30, 2015 2:28 AM To: Chao Yu Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: Re: [PATCH 2/5] f2fs: support norecovery

RE: [PATCH 1/5 v2] f2fs: fix not to drop mount options when retrying fill_super

2015-01-29 Thread Chao Yu
-Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Friday, January 30, 2015 2:21 AM To: Chao Yu Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: Re: [PATCH 1/5 v2] f2fs: fix not to drop mount options

RE: [PATCH 4/5] f2fs: should fail mount when trying to recover data on read-only dev

2015-01-29 Thread Chao Yu
there will be no data to be recovered. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org Reviewed-by: Chao Yu chao2...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

RE: [PATCH 5/5] f2fs: introduce a batched trim

2015-01-29 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Friday, January 30, 2015 5:41 AM To: Chao Yu Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: Re: [PATCH 5/5] f2fs: introduce a batched

RE: [PATCH 4/5] f2fs: should fail mount when trying to recover data on read-only dev

2015-01-29 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Friday, January 30, 2015 5:40 AM To: Chao Yu Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: Re: [PATCH 4/5] f2fs: should fail mount

RE: [f2fs-dev] [PATCH 2/5 v2] f2fs: support norecovery mount option

2015-01-29 Thread Chao Yu
-Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Friday, January 30, 2015 2:31 AM To: Chao Yu Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 2/5 v2] f2fs: support norecovery

[PATCH] MAINTAINERS: fix incorrect email address of docking station

2015-04-13 Thread Chao Yu
The old email address of Shaohua will no longer be used, let's update it with last valid one. Signed-off-by: Chao Yu chao2...@samsung.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a36be4e..bbcbb83 100644 --- a/MAINTAINERS

RE: [PATCH] elevator: fix double release for elevator module

2015-04-23 Thread Chao Yu
Hi Jens and Jeff, Thanks for your review and help! :) Regards, -Original Message- From: Jens Axboe [mailto:ax...@kernel.dk] Sent: Friday, April 24, 2015 12:49 AM To: Jeff Moyer; Chao Yu Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] elevator: fix double release for elevator

[PATCH] elevator: remove unneeded kfree in error path of elevator_alloc

2015-04-23 Thread Chao Yu
In elevator_alloc, if we fail to allocate memory for storing elevator queue, our eq pointer must be NULL, we do not need to release it in error path, so remove it. Signed-off-by: Chao Yu chao2...@samsung.com --- block/elevator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/elevator.c

[PATCH] elevator: fix double release for elevator module

2015-04-23 Thread Chao Yu
elevator_put invoking in error path of elevator_alloc to avoid double release issue. Signed-off-by: Chao Yu chao2...@samsung.com --- block/elevator.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index d146a5e..8985038 100644

RE: [f2fs-dev] [PATCH] f2fs: fix wrong error hanlder in f2fs_follow_link

2015-04-24 Thread Chao Yu
in f2fs_follow_link The page_follow_link_light returns NULL and its error pointer was remained in nd-path. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Jaegeuk Kim jaeg...@kernel.org Reviewed-by: Chao Yu chao2...@samsung.com -- To unsubscribe from this list: send

[PATCH] elevator: fix memory leak in -elevator_init_fn

2015-04-23 Thread Chao Yu
In -elevator_init_fn, if we fail to call kzalloc_node, we should release elevator queue space which is allocated previously, otherwise it will cause memory leak. Signed-off-by: Chao Yu chao2...@samsung.com --- block/cfq-iosched.c | 1 + block/deadline-iosched.c | 1 + block/noop-iosched.c

RE: [f2fs-dev] [PATCH 1/2] f2fs: support FALLOC_FL_COLLAPSE_RANGE

2015-04-28 Thread Chao Yu
Ping, any comments? -Original Message- From: Chao Yu [mailto:chao2...@samsung.com] Sent: Saturday, April 18, 2015 6:01 PM To: Jaegeuk Kim; Changman Lee Cc: linux-kernel@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Subject: [f2fs-dev] [PATCH 1/2] f2fs: support

[PATCH 1/2] f2fs: remove unneeded f2fs_make_empty declaration

2015-04-30 Thread Chao Yu
Remove f2fs_make_empty() declaration, since the main body of this function is move into do_make_empty_dir() and the function is obsolete now. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/f2fs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index

[PATCH 2/2] f2fs: don not re-lookup nat cache with same nid

2015-04-30 Thread Chao Yu
judgment for reducing unneeded lookup. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/node.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 1676c7a..7a6d99f 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -312,7 +312,8

[PATCH v2 3/3] f2fs: support FALLOC_FL_ZERO_RANGE

2015-04-30 Thread Chao Yu
a hole of len bytes at offset. This patch implements fallocate's FALLOC_FL_ZERO_RANGE for f2fs. Signed-off-by: Chao Yu chao2...@samsung.com --- v2: * rebase to last git repository of f2fs (20150430) fs/f2fs/file.c | 106 - 1 file changed, 105

[PATCH v2 1/3] f2fs: introduce replace_block() for reuse

2015-04-30 Thread Chao Yu
Introduce a generic function replace_block base on recover_data_page, and export it. So wit it we can operate file's meta data which is in CP/SSA area when we invoke fallocate with FALLOC_FL_COLLAPSE_RANGE flag. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/f2fs.h | 4 ++-- fs

[PATCH v2 2/3] f2fs: support FALLOC_FL_COLLAPSE_RANGE

2015-04-30 Thread Chao Yu
and ext4. 4) Collaspe range does not work beyond i_size. This patch implements fallocate's FALLOC_FL_COLLAPSE_RANGE for f2fs. Signed-off-by: Chao Yu chao2...@samsung.com --- v2: * rebase to last git repository of f2fs (20150430) * remove replace_block() introduction. fs/f2fs/file.c | 135

RE: [PATCH] elevator: fix memory leak in -elevator_init_fn

2015-04-26 Thread Chao Yu
ignore this patch, sorry for the noisy! Regards, -Original Message- From: Chao Yu [mailto:chao2...@samsung.com] Sent: Friday, April 24, 2015 10:09 AM To: 'ax...@kernel.dk' Cc: 'linux-kernel@vger.kernel.org' Subject: [PATCH] elevator: fix memory leak in -elevator_init_fn

RE: [PATCH 1/2] f2fs: support FALLOC_FL_COLLAPSE_RANGE

2015-04-29 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Thursday, April 30, 2015 5:31 AM To: Chao Yu Cc: Changman Lee; linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] f2fs: support FALLOC_FL_COLLAPSE_RANGE

<    1   2   3   4   5   6   7   8   9   10   >