[PATCH] extcon: arizona: Ensure variables are set for headphone detection

2015-06-18 Thread Charles Keepax
The detecting flag really refers to the microphone detection stage and as such should be cleared before arizona_identify_headphones is called. Also the mic flag should be set before identify headphones is called as well. Signed-off-by: Charles Keepax --- Note this was generated on top of the

Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod

2015-06-19 Thread Charles Keepax
On Fri, Jun 19, 2015 at 11:36:47AM +0900, Chanwoo Choi wrote: > Hi Charles, > > On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax > wrote: > > Convert to using the newer gpiod interface for the micd_pol_gpio. > > Although we still carry support for the old g

Re: [PATCH v2 2/5] extcon: arizona: Add basic microphone detection DT/ACPI bindings

2015-06-19 Thread Charles Keepax
On Fri, Jun 19, 2015 at 11:25:57AM +0900, Chanwoo Choi wrote: > Hi Charles, > > On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax > wrote: > > This patch adds bindings for the basic microphone detection platform > > data. > > > > Signed-off-by: Charles Ke

Re: [PATCH v2 2/5] extcon: arizona: Add basic microphone detection DT/ACPI bindings

2015-06-19 Thread Charles Keepax
On Fri, Jun 19, 2015 at 05:28:11PM +0900, Chanwoo Choi wrote: > On Fri, Jun 19, 2015 at 5:17 PM, Charles Keepax > wrote: > > On Fri, Jun 19, 2015 at 11:25:57AM +0900, Chanwoo Choi wrote: > >> Hi Charles, > >> > >> On Thu, Jun 18, 2015 at 11:43 PM, Charle

Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod

2015-06-19 Thread Charles Keepax
On Fri, Jun 19, 2015 at 05:39:22PM +0900, Chanwoo Choi wrote: > On Fri, Jun 19, 2015 at 5:14 PM, Charles Keepax > wrote: > > On Fri, Jun 19, 2015 at 11:36:47AM +0900, Chanwoo Choi wrote: > >> Hi Charles, > >> > >> On Thu, Jun 18, 2015 at 11:43 PM, Charle

Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod

2015-06-19 Thread Charles Keepax
On Fri, Jun 19, 2015 at 06:50:03PM +0900, Chanwoo Choi wrote: > On Fri, Jun 19, 2015 at 6:13 PM, Charles Keepax > wrote: > > On Fri, Jun 19, 2015 at 05:39:22PM +0900, Chanwoo Choi wrote: > >> On Fri, Jun 19, 2015 at 5:14 PM, Charles Keepax > >> wrote: > >&g

Re: [PATCH] extcon: arizona: Ensure variables are set for headphone detection

2015-06-19 Thread Charles Keepax
On Thu, Jun 18, 2015 at 04:41:59PM +0100, Charles Keepax wrote: > The detecting flag really refers to the microphone detection stage and > as such should be cleared before arizona_identify_headphones is called. > Also the mic flag should be set before identify headphones is called

[PATCH v3 3/7] extcon: arizona: Add basic microphone detection DT/ACPI bindings

2015-06-19 Thread Charles Keepax
This patch adds bindings for the basic microphone detection platform data. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 30 ++ include/linux/mfd/arizona/pdata.h |3 +++ 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a

[PATCH v3 0/7] Add basic microphone detection bindings

2015-06-19 Thread Charles Keepax
easy of applying. Thanks, Charles Charles Keepax (7): extcon: arizona: Factor out initial GPIO state extcon: arizona: Update to use the new device properties API extcon: arizona: Add basic microphone detection DT/ACPI bindings extcon: arizona: Convert to gpiod extcon: arizona: Ensure var

[PATCH v3 7/7] mfd: arizona: Update several pdata members to unsigned

2015-06-19 Thread Charles Keepax
-by: Charles Keepax --- include/linux/mfd/arizona/pdata.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h index af44081..f2c8381 100644 --- a/include/linux/mfd/arizona/pdata.h +++ b/include

[PATCH v3 2/7] extcon: arizona: Update to use the new device properties API

2015-06-19 Thread Charles Keepax
The device properties API will load data from both device tree and ACPI, update the binding to use this API instead of the OF API. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/extcon

[PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state

2015-06-19 Thread Charles Keepax
Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 9262b45..e31613a 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon

[PATCH v3 5/7] extcon: arizona: Ensure variables are set for headphone detection

2015-06-19 Thread Charles Keepax
detection and we can get false button reports caused by the clamping that is part of the headphone detection. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b

[PATCH v3 6/7] mfd: arizona: Update DT doc for new mic detection bindings

2015-06-19 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Documentation/devicetree/bindings/mfd/arizona.txt | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt index 32a71b7

[PATCH v3 4/7] extcon: arizona: Convert to gpiod

2015-06-19 Thread Charles Keepax
Convert to using the newer gpiod interface for the micd_pol_gpio. Although we still carry support for the old gpio interface from pdata. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 41 ++ 1 files changed, 36 insertions(+), 5

Re: [PATCH v2 2/5] extcon: arizona: Add basic microphone detection DT/ACPI bindings

2015-06-19 Thread Charles Keepax
On Fri, Jun 19, 2015 at 07:31:49PM +0900, Chanwoo Choi wrote: > On Fri, Jun 19, 2015 at 6:08 PM, Charles Keepax > wrote: > > On Fri, Jun 19, 2015 at 05:28:11PM +0900, Chanwoo Choi wrote: > >> On Fri, Jun 19, 2015 at 5:17 PM, Charles Keepax > >> wrote: > >&g

[PATCH v3 0/7] Add basic microphone detection bindings

2015-06-19 Thread Charles Keepax
easy of applying. Thanks, Charles Charles Keepax (7): extcon: arizona: Factor out initial GPIO state extcon: arizona: Update to use the new device properties API extcon: arizona: Add basic microphone detection DT/ACPI bindings extcon: arizona: Convert to gpiod extcon: arizona: Ensure var

[PATCH v3 2/7] extcon: arizona: Update to use the new device properties API

2015-06-19 Thread Charles Keepax
The device properties API will load data from both device tree and ACPI, update the binding to use this API instead of the OF API. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/extcon

[PATCH v3 4/7] extcon: arizona: Convert to gpiod

2015-06-19 Thread Charles Keepax
Convert to using the newer gpiod interface for the micd_pol_gpio. Although we still carry support for the old gpio interface from pdata. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 41 ++ 1 files changed, 36 insertions(+), 5

[PATCH v3 5/7] extcon: arizona: Ensure variables are set for headphone detection

2015-06-19 Thread Charles Keepax
detection and we can get false button reports caused by the clamping that is part of the headphone detection. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b

Re: [PATCH v3 0/7] Add basic microphone detection bindings

2015-06-19 Thread Charles Keepax
On Fri, Jun 19, 2015 at 11:24:20AM +0100, Charles Keepax wrote: > This series adds basic microphone detection DT/ACPI bindings > using the device properties API. > > The MFD parts and the extcon parts can go seperately through > there respective trees, but I sent them together so

[PATCH v3 7/7] mfd: arizona: Update several pdata members to unsigned

2015-06-19 Thread Charles Keepax
-by: Charles Keepax --- include/linux/mfd/arizona/pdata.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h index af44081..f2c8381 100644 --- a/include/linux/mfd/arizona/pdata.h +++ b/include

[PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state

2015-06-19 Thread Charles Keepax
Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 9262b45..e31613a 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon

[PATCH v3 6/7] mfd: arizona: Update DT doc for new mic detection bindings

2015-06-19 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Documentation/devicetree/bindings/mfd/arizona.txt | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt index 32a71b7

[PATCH v3 3/7] extcon: arizona: Add basic microphone detection DT/ACPI bindings

2015-06-19 Thread Charles Keepax
This patch adds bindings for the basic microphone detection platform data. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 30 ++ include/linux/mfd/arizona/pdata.h |3 +++ 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a

Re: [PATCH v2 2/5] extcon: arizona: Add basic microphone detection DT/ACPI bindings

2015-06-19 Thread Charles Keepax
On Fri, Jun 19, 2015 at 08:03:37PM +0900, Chanwoo Choi wrote: > On Fri, Jun 19, 2015 at 7:44 PM, Charles Keepax > wrote: > > On Fri, Jun 19, 2015 at 07:31:49PM +0900, Chanwoo Choi wrote: > >> On Fri, Jun 19, 2015 at 6:08 PM, Charles Keepax > >> wrote: > >&g

[PATCH v4 0/8] Add basic microphone detection bindings

2015-06-19 Thread Charles Keepax
easy of applying. Changes since v3: - Simplify the symantics of the pdata for micd_dbtime Thanks, Charles Charles Keepax (8): extcon: arizona: Simplify pdata symantics for micd_dbtime extcon: arizona: Factor out initial GPIO state extcon: arizona: Update to use the new device properties AP

[PATCH v4 8/8] mfd: arizona: Update several pdata members to unsigned

2015-06-19 Thread Charles Keepax
-by: Charles Keepax --- include/linux/mfd/arizona/pdata.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h index bd68355..85b132c 100644 --- a/include/linux/mfd/arizona/pdata.h +++ b/include

[PATCH v4 7/8] mfd: arizona: Update DT doc for new mic detection bindings

2015-06-19 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Documentation/devicetree/bindings/mfd/arizona.txt | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt index 32a71b7

[PATCH v4 6/8] extcon: arizona: Ensure variables are set for headphone detection

2015-06-19 Thread Charles Keepax
The detecting flag really refers to the microphone detection stage and as such should be cleared before arizona_identify_headphones is called. Also the mic flag should be set before identify headphones is called as well. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 11

[PATCH v4 1/8] extcon: arizona: Simplify pdata symantics for micd_dbtime

2015-06-19 Thread Charles Keepax
pdata at this stage in the drivers life, but acceptance of the DT binding for this field has been made conditional on this happening. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 14 +++--- include/linux/mfd/arizona/pdata.h |3 +++ 2 files changed, 14

[PATCH v4 5/8] extcon: arizona: Convert to gpiod

2015-06-19 Thread Charles Keepax
Convert to using the newer gpiod interface for the micd_pol_gpio. Although we still carry support for the old gpio interface from pdata. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 41 ++ 1 files changed, 36 insertions(+), 5

[PATCH v4 2/8] extcon: arizona: Factor out initial GPIO state

2015-06-19 Thread Charles Keepax
Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 1fbe3b4..c4d179b 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon

[PATCH v4 3/8] extcon: arizona: Update to use the new device properties API

2015-06-19 Thread Charles Keepax
The device properties API will load data from both device tree and ACPI, update the binding to use this API instead of the OF API. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/extcon

[PATCH v4 4/8] extcon: arizona: Add basic microphone detection DT/ACPI bindings

2015-06-19 Thread Charles Keepax
This patch adds bindings for the basic microphone detection platform data. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon

Re: [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state

2015-06-19 Thread Charles Keepax
On Fri, Jun 19, 2015 at 09:29:34PM +0900, Chanwoo Choi wrote: > Hi Charles, > > I'm sorry about lack of my commet on previous patch. > I just want to know the what is meaning of zero(0) index of > "info->micd_modes[0] array" > instead of separate variable (gpio_initial_level). > > So, I'd like yo

[PATCH v5 0/7] Add basic microphone detection bindings

2015-06-19 Thread Charles Keepax
easy of applying. Changes since v3: - Simplify the symantics of the pdata for micd_dbtime Changes since v4: - Remove the gpio initial state patch added in v2 Thanks, Charles Charles Keepax (7): extcon: arizona: Simplify pdata symantics for micd_dbtime extcon: arizona: Update to use the

[PATCH v5 3/7] extcon: arizona: Add basic microphone detection DT/ACPI bindings

2015-06-19 Thread Charles Keepax
This patch adds bindings for the basic microphone detection platform data. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon

[PATCH v5 5/7] extcon: arizona: Ensure variables are set for headphone detection

2015-06-19 Thread Charles Keepax
The detecting flag really refers to the microphone detection stage and as such should be cleared before arizona_identify_headphones is called. Also the mic flag should be set before identify headphones is called as well. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 11

[PATCH v5 4/7] extcon: arizona: Convert to gpiod

2015-06-19 Thread Charles Keepax
Convert to using the newer gpiod interface for the micd_pol_gpio. Although we still carry support for the old gpio interface from pdata. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 41 ++ 1 files changed, 36 insertions(+), 5

[PATCH v5 7/7] mfd: arizona: Update several pdata members to unsigned

2015-06-19 Thread Charles Keepax
-by: Charles Keepax --- include/linux/mfd/arizona/pdata.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h index bd68355..85b132c 100644 --- a/include/linux/mfd/arizona/pdata.h +++ b/include

[PATCH v5 2/7] extcon: arizona: Update to use the new device properties API

2015-06-19 Thread Charles Keepax
The device properties API will load data from both device tree and ACPI, update the binding to use this API instead of the OF API. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/extcon

[PATCH v5 1/7] extcon: arizona: Simplify pdata symantics for micd_dbtime

2015-06-19 Thread Charles Keepax
pdata at this stage in the drivers life, but acceptance of the DT binding for this field has been made conditional on this happening. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 14 +++--- include/linux/mfd/arizona/pdata.h |3 +++ 2 files changed, 14

[PATCH v5 6/7] mfd: arizona: Update DT doc for new mic detection bindings

2015-06-19 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Documentation/devicetree/bindings/mfd/arizona.txt | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt index 32a71b7

Re: [alsa-devel] [PATCH RFC] ASoC: dai playback_active and capture_active may be greater than 1

2018-04-30 Thread Charles Keepax
as soc_dpcm_runtime_update(), won't run > correctly. > > Storing these usage counts on plain 'unsigned int' solves the problem. > > Fixes: f0fba2ad1b6b ("ASoC: multi-component - ASoC Multi-Component Support") > Signed-off-by: Jerome Brunet > --- Reviewed-by: Charles Keepax Thanks, Charles

Re: [PATCH] mfd: arizona: Don't use regmap_read_poll_timeout

2018-06-04 Thread Charles Keepax
On Mon, Jun 04, 2018 at 12:40:37PM +0300, Andy Shevchenko wrote: > On Mon, Jun 4, 2018 at 8:44 AM, Lee Jones wrote: > > On Fri, 11 May 2018, Charles Keepax wrote: > > >> + while (true) { > >> + ret = regmap_read(arizona->regmap, reg, &val); &g

Re: [PATCH] mfd: arizona: Don't use regmap_read_poll_timeout

2018-06-04 Thread Charles Keepax
On Mon, Jun 04, 2018 at 11:27:19AM +0100, Charles Keepax wrote: > On Mon, Jun 04, 2018 at 12:40:37PM +0300, Andy Shevchenko wrote: > > On Mon, Jun 4, 2018 at 8:44 AM, Lee Jones wrote: > > > On Fri, 11 May 2018, Charles Keepax wrote: > > > > >> + whi

[PATCH v2] mfd: arizona: Don't use regmap_read_poll_timeout

2018-06-04 Thread Charles Keepax
("mfd: arizona: Refactor arizona_poll_reg") Signed-off-by: Charles Keepax --- Changes since v1: - Explicitly include ktime header - Use USEC_PER_MSEC instead of a constant - Refactor the loop to not use a while (true) Thanks, Charles drivers/mfd/arizona-core.c | 29

Re: [PATCH 03/19 v3] regulator: arizona-ldo1: Look up a descriptor and pass to the core

2018-05-15 Thread Charles Keepax
t; in commit 6a537d48461d > "gpio: of: Support regulator nonstandard GPIO properties". > > Cc: patc...@opensource.cirrus.com > Cc: Richard Fitzgerald > Cc: Charles Keepax > Signed-off-by: Linus Walleij > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH] regulator: wm8400: Fix trivial typo

2019-02-28 Thread Charles Keepax
On Wed, Feb 27, 2019 at 01:54:21PM +0800, Axel Lin wrote: > Use WM8400_DC2_ENA_MASK for DCDC2 enable_mask. > The define is the same as WM8400_DC1_ENA_MASK, just a cleanup. > > Signed-off-by: Axel Lin > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH] regulator: wm8400: Get rid of wm8400_block_read/wm8400_set_bits functions

2019-02-28 Thread Charles Keepax
400_set_bits functions. > > Signed-off-by: Axel Lin > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 11/11] regulator: wm831x-dcdc: Convert to use regulator_set/get_current_limit_regmap

2019-03-01 Thread Charles Keepax
On Thu, Feb 28, 2019 at 09:40:22PM +0800, Axel Lin wrote: > Use regulator_set/get_current_limit_regmap helpers to save some code. > > Signed-off-by: Axel Lin > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 1/4] regulator: wm831x-isink: Select maximum current in specific range

2019-03-13 Thread Charles Keepax
On Wed, Mar 13, 2019 at 12:33:54AM +0800, Axel Lin wrote: > .set_current_limit callback should select the current closest to max_uA. > > Signed-off-by: Axel Lin > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 2/4] regulator: wm8350: Select maximum current in specific range

2019-03-13 Thread Charles Keepax
On Wed, Mar 13, 2019 at 12:33:55AM +0800, Axel Lin wrote: > .set_current_limit callback should select the current closest to max_uA. > > Signed-off-by: Axel Lin > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 3/4] regulator: wm831x-isink: Convert to use regulator_set/get_current_limit_regmap

2019-03-13 Thread Charles Keepax
On Wed, Mar 13, 2019 at 12:33:56AM +0800, Axel Lin wrote: > Use regulator_set/get_current_limit_regmap helpers to save some code. > > Signed-off-by: Axel Lin > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 4/4] regulator: wm8350: Convert to use regulator_set/get_current_limit_regmap

2019-03-13 Thread Charles Keepax
On Wed, Mar 13, 2019 at 12:33:57AM +0800, Axel Lin wrote: > Use regulator_set/get_current_limit_regmap helpers to save some code. > > Signed-off-by: Axel Lin > --- Acked-by: Charles Keepax Thanks, Charles

[PATCH] regulator: as3722: Correct minor typo

2019-02-05 Thread Charles Keepax
A comma has been accidentally used where a semi-colon was clearly intended, correct this typo. Signed-off-by: Charles Keepax --- drivers/regulator/as3722-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator

Re: [BUG BISECT] NULL pointer after commit "ASoC: dapm: Only power up active channels from a DAI"

2019-02-06 Thread Charles Keepax
On Tue, Feb 05, 2019 at 10:16:22PM +0100, Krzysztof Kozlowski wrote: > Bisect pointed to commit: > commit 078a85f2806f0ffd11289009462a6a390f9adb5c > Author: Charles Keepax > Date: Thu Jan 31 13:30:18 2019 + > ASoC: dapm: Only power up active channels from

[PATCH] ASoC: dapm: Check for NULL widget in dapm_update_dai_unlocked

2019-02-06 Thread Charles Keepax
DAIs linked to the dummy will not have an associated playback/capture widget, so we need to skip the update in that case. Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI") Signed-off-by: Charles Keepax --- Ok so that all makes sense, this patch is probabl

Re: [PATCH] ASoC: dapm: Check for NULL widget in dapm_update_dai_unlocked

2019-02-06 Thread Charles Keepax
On Wed, Feb 06, 2019 at 11:22:33AM +0100, Krzysztof Kozlowski wrote: > On Wed, 6 Feb 2019 at 11:05, Charles Keepax > wrote: > > > > DAIs linked to the dummy will not have an associated playback/capture > > widget, so we need to skip the update in that case. > >

Re: [BUG BISECT] NULL pointer after commit "ASoC: dapm: Only power up active channels from a DAI"

2019-02-06 Thread Charles Keepax
On Wed, Feb 06, 2019 at 11:11:03AM +0100, Sylwester Nawrocki wrote: > On 2/6/19 10:46, Sylwester Nawrocki wrote: > > On 2/5/19 22:16, Krzysztof Kozlowski wrote: > >> Bisect pointed to commit: > >> commit 078a85f2806f0ffd11289009462a6a390f9adb5c > >> A

Re: [PATCH] ASoC: dapm: Check for NULL widget in dapm_update_dai_unlocked

2019-02-06 Thread Charles Keepax
On Wed, Feb 06, 2019 at 12:14:56PM +0100, Krzysztof Kozlowski wrote: > On Wed, 6 Feb 2019 at 12:00, Charles Keepax > wrote: > > > > On Wed, Feb 06, 2019 at 11:22:33AM +0100, Krzysztof Kozlowski wrote: > > > On Wed, 6 Feb 2019 at 11:05, Charles Keepax > > > w

Re: Bad file pattern in MAINTAINERS section 'CIRRUS LOGIC LOCHNAGAR DRIVER'

2019-03-26 Thread Charles Keepax
S section: > > 3792CIRRUS LOGIC LOCHNAGAR DRIVER > 3793M: Charles Keepax > 3794M: Richard Fitzgerald > 3795L: patc...@opensource.cirrus.com > 3796S: Supported > --> 3797F: drivers/clk/c

Re: [PATCH -next] ASoC: fix SND_SOC_LOCHNAGAR_SC kconfig warning

2019-03-27 Thread Charles Keepax
amp;& SND_SOC [=m] && > MFD_LOCHNAGAR [=n] > Selected by [m]: > - SND_SOC_ALL_CODECS [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=m] > && COMPILE_TEST [=y] > > Signed-off-by: Randy Dunlap > Cc: Piotr Stankiewicz

[PATCH 2/2] mfd: cs47l90: Make DAC_AEC_CONTROL_2 readable

2019-04-03 Thread Charles Keepax
From: Ajit Pandey There is a second AEC loopback on cs47l90 so the registers for it should be readable. Signed-off-by: Ajit Pandey Signed-off-by: Charles Keepax --- drivers/mfd/cs47l90-tables.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/cs47l90-tables.c b/drivers/mfd

[PATCH 1/2] mfd: cs47l35: Make DAC_AEC_CONTROL_2 readable

2019-04-03 Thread Charles Keepax
From: Richard Fitzgerald There is a second AEC loopback on cs47l35 so the registers for it should be readable. Signed-off-by: Richard Fitzgerald Signed-off-by: Charles Keepax --- drivers/mfd/cs47l35-tables.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/cs47l35-tables.c b

Regulator Potential Deadlock

2019-04-03 Thread Charles Keepax
Hi Guys, Was testing some of my hardware and hit this potential lockup: Possible unsafe locking scenario: CPU0CPU1 lock((work_completion)(&(&rdev->disable_work)->work)); lock(regulator_list_mutex); l

[PATCH] ASoC: wm_adsp: Remove unused control callback structure

2021-02-11 Thread Charles Keepax
This callback structure has never been used and it is not clear why it was added in the first place. Remove it to clear up the code a little. Signed-off-by: Charles Keepax --- sound/soc/codecs/wm_adsp.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/sound/soc/codecs/wm_adsp.c b

Re: [PATCH -next] mfd: arizona: Make some symbols static

2021-02-11 Thread Charles Keepax
eported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 06/13] ASoC/extcon: arizona: Move arizona jack code to sound/soc/codecs/arizona-jack.c

2021-01-30 Thread Charles Keepax
tly report jack > state through the standard sound/soc/soc-jack.c functions. > > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 05/13] extcon: arizona: Always use pm_runtime_get_sync() when we need the device to be awake

2021-01-30 Thread Charles Keepax
mediately after the call. > This means that we should always use pm_runtime_get_sync(). > > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 03/13] extcon: arizona: Fix various races on driver unbind

2021-01-30 Thread Charles Keepax
eoretically possible races caused > by the wrong ordering inside arizona_extcon_remove(), this fixes the > ordering fixing all possible races, including the reported oops. > > Reviewed-by: Andy Shevchenko > Acked-by: Charles Keepax > Signed-off-by: Hans de Goede > --- Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 13/13] ASoC: Intel: bytcr_wm5102: Add jack detect support

2021-01-30 Thread Charles Keepax
On Sat, Jan 23, 2021 at 01:17:20PM +0100, Hans de Goede wrote: > Add jack detect support by creating a jack and calling > snd_soc_component_set_jack to register the created jack > with the codec. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > +static struct snd_soc_jack_

Re: [PATCH v4 12/13] ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use the new jack library

2021-01-30 Thread Charles Keepax
on a Lenovo Yoga Tablet 2 1051L with a WM5102 codec. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 10/13] ASoC: arizona-jack: Use snd_soc_jack to report jack events

2021-01-30 Thread Charles Keepax
pdata (or defaults) > and cannot be overridden from devicetree. All in-kernel users of the > pdata (and the fallback defaults) define 6 or less buttons/ranges. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 07/13] ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv

2021-01-30 Thread Charles Keepax
a codec-drivers directly report jack > state through the standard sound/soc/soc-jack.c functions. > > Reviewed-by: Andy Shevchenko > Acked-by: Charles Keepax > Signed-off-by: Hans de Goede > --- Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 08/13] ASoC: arizona-jack: Use arizona->dev for runtime-pm

2021-01-30 Thread Charles Keepax
zona extcon driver into > a helper library for letting the arizona codec-drivers directly report > jack state through the standard sound/soc/soc-jack.c functions. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 02/13] extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged

2021-01-30 Thread Charles Keepax
n on the next jack insertion, which in turn > causes the EXTCON_JACK_HEADPHONE state to never get set > > This fixes both issues by skipping these 2 steps when arizona_hpdet_irq > runs after the jack has been unplugged. > > Reviewed-by: Andy Shevchenko > Acked-by: Charles Keepax > Signed-off-by: Hans de Goede > --- Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 09/13] ASoC: arizona-jack: convert into a helper library for codec drivers

2021-01-30 Thread Charles Keepax
ck through snd_soc_card_jack_new() and register > this jack with the codec through snd_soc_component_set_jack(). > > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 01/13] mfd: arizona: Drop arizona-extcon cells

2021-01-30 Thread Charles Keepax
es. > > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-30 Thread Charles Keepax
t; Suggested-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Tested-by: Charles Keepax Thanks, Charles

Re: [PATCH 2/3] mfd: madera: Fix minor formatting issues

2020-06-01 Thread Charles Keepax
On Mon, Jun 01, 2020 at 06:24:33AM +0100, Lee Jones wrote: > On Fri, 29 May 2020, Charles Keepax wrote: > > Still needs a commit log. > > > Signed-off-by: Charles Keepax > > --- > > drivers/mfd/madera-core.c| 12 ++-- > > drivers/mfd/made

Re: [PATCH -next] regulator: wm831x-isink: convert comma to semicolon

2020-12-11 Thread Charles Keepax
On Fri, Dec 11, 2020 at 04:44:40PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- Acked-by: Charles Keepax Thanks, Charles

Re: wm8960: add DAC Slope switch

2020-12-07 Thread Charles Keepax
On Tue, Nov 24, 2020 at 06:23:13PM +0100, Lukas F. Hartmann wrote: > The WM8960 DAC has a "DAC Slope" switch that can toggle between two > different output filter curves. This patch adds support for it. > > Signed-off-by: Lukas F. Hartmann > --- > +static int wm8960_put_dacslope(struct snd_kcontr

Re: [PATCH 02/14] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1")

2020-12-29 Thread Charles Keepax
e existing MODULE_SOFTDEP("pre: wm8994_regulator") > in the wm8994 code, which has a similar init sequence. > > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 04/14] mfd: arizona: Allow building arizona MFD-core as module

2020-12-29 Thread Charles Keepax
On Sun, Dec 27, 2020 at 10:12:22PM +0100, Hans de Goede wrote: > There is no reason why the arizona core,irq and codec model specific > regmap bits cannot be build as a module. All they do is export symbols > which are used by the arizona-spi and/or arizona-i2c modules, which > themselves can be bu

Re: [PATCH 06/14] extcon: arizona: Fix various races on driver unbind

2020-12-29 Thread Charles Keepax
eoretically possible races caused > by the wrong ordering inside arizona_extcon_remove(), this fixes the > ordering fixing all possible races, including the reported oops. > > Signed-off-by: Hans de Goede > --- Sorry yes there are a few rough corners on the extcon stuff, I have

Re: [PATCH 07/14] extcon: arizona: Fix modalias

2020-12-29 Thread Charles Keepax
s "arizona-extcon" and the > modalias must match that. > > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 08/14] extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") call

2020-12-29 Thread Charles Keepax
it was using a hardcoded GPIOD_OUT_LOW. > > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 09/14] extcon: arizona: Add arizona_set_extcon_state() helper

2020-12-29 Thread Charles Keepax
On Sun, Dec 27, 2020 at 10:12:27PM +0100, Hans de Goede wrote: > All the callers of extcon_set_state_sync() log an error on failure, > without doing any further error-handling (as there is nothing they > can do about the error). > > Factor this out into a helper to remove some duplicate code. > >

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-29 Thread Charles Keepax
On Mon, Dec 28, 2020 at 04:28:07PM +, Mark Brown wrote: > On Mon, Dec 28, 2020 at 02:16:04PM +0100, Hans de Goede wrote: > > > And more in general AFAIK extcon is sort of deprecated and it is > > not advised to use it for new code. I would esp. not expect it to > > be used for new jack-detecti

Re: [PATCH 13/14] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102

2020-12-29 Thread Charles Keepax
On Sun, Dec 27, 2020 at 10:12:31PM +0100, Hans de Goede wrote: > From: Pierre-Louis Bossart > > Add a new ASoc Machine driver for Intel Baytrail platforms with a > Wolfson Microelectronics WM5102 codec. > > This is based on a past contributions [1] from Paulo Sergio Travaglia > based on the Lev

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-29 Thread Charles Keepax
On Tue, Dec 29, 2020 at 02:57:38PM +0100, Hans de Goede wrote: > On 12/29/20 2:06 PM, Charles Keepax wrote: > > On Mon, Dec 28, 2020 at 04:28:07PM +, Mark Brown wrote: > >> On Mon, Dec 28, 2020 at 02:16:04PM +0100, Hans de Goede wrote: > >> > >>> And

[PATCH v2] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2020-12-30 Thread Charles Keepax
nce of the flag. Update the if statement to this effect, which repairs the existing users. Fixes: daafa1d33cc9 ("net: macb: add capability to not set the clock rate") Suggested-by: Andrew Lunn Signed-off-by: Charles Keepax --- Changes since v1: - Updated flag semantics to skip fun

[PATCH] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag on Zynq

2020-12-23 Thread Charles Keepax
afa1d33cc9 ("net: macb: add capability to not set the clock rate") Signed-off-by: Charles Keepax --- drivers/net/ethernet/cadence/macb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/caden

Re: [PATCH] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag on Zynq

2020-12-23 Thread Charles Keepax
On Wed, Dec 23, 2020 at 08:24:41PM +0100, Andrew Lunn wrote: > On Wed, Dec 23, 2020 at 06:41:44PM +0000, Charles Keepax wrote: > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > > macb_set_tx_clk were gated on the presence of this flag. > > > > if

Re: [PATCH] ASoC: wm8960: Fix wrong bclk and lrclk with pll enabled for some chips

2021-03-23 Thread Charles Keepax
he best choice. > > So search available sysclk_divs from 2 to 1 other than from 1 to 2. > > Fixes: 84fdc00d519f ("ASoC: codec: wm9860: Refactor PLL out freq search") > Signed-off-by: Shengjiu Wang > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH] mfd: arizona: Fix rumtime PM imbalance on error

2021-04-07 Thread Charles Keepax
ich will not change the runtime > PM counter on error. > > Signed-off-by: Dinghao Liu > --- Acked-by: Charles Keepax Wow, did not realise that was how that worked. Thanks for fixing up. Thanks, Charles

Re: [PATCH 32/32] pinctrl: update pin-control.rst references

2021-04-01 Thread Charles Keepax
s accordingly. > > Fixes: 5513b411ea5b ("Documentation: rename pinctl to pin-control") > Signed-off-by: Mauro Carvalho Chehab > --- Acked-by: Charles Keepax Thanks, Charles

Re: [PATCH 6/7] mfd: wm831x: Correct kerneldoc

2021-04-19 Thread Charles Keepax
ned-off-by: Krzysztof Kozlowski > --- Acked-by: Charles Keepax Thanks, Charles

<    1   2   3   4   5   6   7   8   9   10   >