Re: [PATCH 09/19] mfd: arizona-core: msleep() is unreliable for anything <20ms use usleep_range() instead

2015-12-08 Thread Charles Keepax
.txt > + msleep(1); > > total: 0 errors, 4 warnings, 1407 lines checked > > Cc: patc...@opensource.wolfsonmicro.com > Signed-off-by: Lee Jones > --- This doesn't actually appear to cc patches. But all looks good: Acked-by: Charles Keepax Thanks, Charles -

Re: [PATCH] mfd: wm831x: fix broken wm831x_unique_id_show

2015-12-08 Thread Charles Keepax
uf[i]" should have been > "id[i] & 0xff". > > But while there, it is much simpler to simply use %phN and do all the > formatting at once. > > Signed-off-by: Rasmus Villemoes > --- Acked-by: Charles Keepax Thanks, Charles -- To unsubscribe from this li

[PATCH v3 2/4] regulator: arizona: Add regulator specific device tree binding document

2015-10-27 Thread Charles Keepax
Subsystem specific bindings for the Arizona devices are being factored out of the MFD binding document into separate documents for each subsystem. This patch adds a binding document that covers the existing regulator specific bindings. Signed-off-by: Charles Keepax --- Changes since v2

[PATCH v3 1/4] extcon: arizona: Add extcon specific device tree binding document

2015-10-27 Thread Charles Keepax
Subsystem specific bindings for the Arizona devices are being factored out of the MFD binding document into separate documents for each subsystem. This patch adds a binding document that covers the existing extcon specific bindings. Signed-off-by: Charles Keepax Acked-by: Chanwoo Choi

[PATCH v3 3/4] mfd: arizona: Remove bindings covered in new subsystem specific docs

2015-10-27 Thread Charles Keepax
Binding documentation has been added in new subsystem specific binding documents. This patch removes the now duplicate documentation from the MFD documentation. Signed-off-by: Charles Keepax --- Changes since v2: - No longer moving the core regulators into the regulator binding document, as

[PATCH v3 4/4] MAINTAINERS: Add binding docs for Cirrus Logic/Wolfson Arizona devices

2015-10-27 Thread Charles Keepax
Add device tree binding documentation for the Arizona drivers to the MAINTAINERS file. Signed-off-by: Charles Keepax --- Changes since v2: - Moved all the maintainer updates into this patch Thanks, Charles MAINTAINERS |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap

2015-10-28 Thread Charles Keepax
On Tue, Oct 27, 2015 at 10:58:21PM +0100, Robert Jarzmik wrote: > Convert the Wolfson WM9713 to regmap API. This will leverage all the > regmap functions (debug, registers update, etc ...). > > As a bonus, this will pave the path to gpio chip introduction, and > devicetree support. > > Signed-off

Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap

2015-10-29 Thread Charles Keepax
On Wed, Oct 28, 2015 at 09:34:33PM +0100, Robert Jarzmik wrote: > Charles Keepax writes: > >>/* Disable everything except touchpanel - that will be handled > >> * by the touch driver and left disabled if touch is not in > >> * use. */ > >

[PATCH 2/4] clk: arizona: Add clock driver for the Arizona devices

2016-01-05 Thread Charles Keepax
Add an initial clock driver for the Arizona series audio CODECs. Currently this driver only provides support for parsing the two input clocks (mclk1, mclk2) and providing the internally consumed 32k clock. Signed-off-by: Charles Keepax --- MAINTAINERS | 1 + drivers/clk

[PATCH 1/4] extcon: arizona: Remove enable/disable of 32k clock

2016-01-05 Thread Charles Keepax
The 32k clock is unconditionally enabled by the MFD core so there is no need to control it from the extcon device, so this patch removes the control of the 32k clock. Signed-off-by: Charles Keepax --- drivers/extcon/extcon-arizona.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers

[PATCH 3/4] mfd: arizona: Switch to using clock driver for 32k clock

2016-01-05 Thread Charles Keepax
Now we have a clock driver that can control the 32k clock use this rather than directly controlling the 32k clock from the MFD device. Signed-off-by: Charles Keepax --- drivers/mfd/Kconfig | 1 + drivers/mfd/arizona-core.c | 104

[PATCH 4/4] mfd: arizona: Add device tree binding documentation for new clock driver

2016-01-05 Thread Charles Keepax
Specify the device tree binding for the input clocks to Arizona devices. Signed-off-by: Charles Keepax --- Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree

[PATCH] mfd: arizona: Fix lockdep recursion warning on set_irq_wake

2016-02-18 Thread Charles Keepax
e. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-irq.c| 35 ++- include/linux/mfd/arizona/core.h | 3 +++ 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/arizona-irq.c b/drivers/mfd/arizona-irq.c index 5fef014..6497a65 10

[PATCH RESEND 2/7] mfd: wm5102: Fix defaults array based on testing

2016-02-09 Thread Charles Keepax
My automated test is back and now can check defaults against the actual hardware. This patch updates the defaults array for the differences detected and removes a couple of completely unused registers. Signed-off-by: Charles Keepax --- drivers/mfd/wm5102-tables.c | 16 1 file

[PATCH RESEND 4/7] mfd: cs47l24: Fix defaults array based on testing

2016-02-09 Thread Charles Keepax
My automated test is back and now can check defaults against the actual hardware. This patch updates the defaults array for the differences detected and removes a couple of completely unused registers. Signed-off-by: Charles Keepax --- drivers/mfd/cs47l24-tables.c | 10 +- 1 file

[PATCH RESEND 1/7] mfd: wm5110: Fix defaults array based on testing

2016-02-09 Thread Charles Keepax
My automated test is back and now can check defaults against the actual hardware. This patch updates the defaults array for the differences detected and removes a couple of completely unused registers. Signed-off-by: Charles Keepax --- drivers/mfd/wm5110-tables.c | 82

[PATCH RESEND 3/7] mfd: wm8998: Fix defaults array based on testing

2016-02-09 Thread Charles Keepax
My automated test is back and now can check defaults against the actual hardware. This patch updates the defaults array for the differences detected and removes a couple of completely unused registers. Signed-off-by: Charles Keepax --- drivers/mfd/wm8998-tables.c | 12 ++-- 1 file

[PATCH RESEND 6/7] mfd: arizona: Update small typo in Arizona SPI Kconfig

2016-02-09 Thread Charles Keepax
The help text had a copy and paste error and refers to I2C in the SPI section. This patch corrects this typo. Signed-off-by: Charles Keepax --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 9f012b7

[PATCH RESEND 5/7] mfd: arizona: Remove duplicate select of MFD_CORE

2016-02-09 Thread Charles Keepax
MFD_ARIZONA_I2C and MFD_ARIZONA_SPI both select MFD_ARIZONA and all three of those select MFD_CORE, this makes the selects of MFD_CORE in MFD_ARIZONA_I2C and MFD_ARIZONA_SPI redundant, so we remove them. Signed-off-by: Charles Keepax --- drivers/mfd/Kconfig | 2 -- 1 file changed, 2 deletions

[PATCH 0/7] Minor Arizona MFD Cleanups

2016-02-09 Thread Charles Keepax
Hi, This series fixes up a bunch of register defaults in the Arizona devices and sorts a few Kconfig options. Thanks, Charles Charles Keepax (7): mfd: wm5110: Fix defaults array based on testing mfd: wm5102: Fix defaults array based on testing mfd: wm8998: Fix defaults array based on

[PATCH RESEND 7/7] mfd: arizona: Allow building Arizona MFD as a module

2016-02-09 Thread Charles Keepax
There is nothing that prevents us building the Arizona MFD as a module, this patch enables this. Signed-off-by: Charles Keepax --- drivers/mfd/Kconfig| 2 +- drivers/mfd/Makefile | 18 +- drivers/mfd/arizona-core.c | 4 3 files changed, 14 insertions(+), 10

Re: [PATCH RESEND 7/7] mfd: arizona: Allow building Arizona MFD as a module

2016-02-09 Thread Charles Keepax
On Tue, Feb 09, 2016 at 10:52:03AM +, Charles Keepax wrote: > There is nothing that prevents us building the Arizona MFD as a module, > this patch enables this. > > Signed-off-by: Charles Keepax > --- Actually sorry drop this last patch for now, if you build the MFD as a mo

Re: [PATCH v2] ASoC: wm9713: fix regmap free path

2016-02-23 Thread Charles Keepax
s) from [] (snd_soc_register_card+0x4e4/0xdd4) > (snd_soc_register_card) from [] > (devm_snd_soc_register_card+0x34/0x70) > > Fix this by replacing the devm_regmap initialization code with the non > devm_() variant. > > Fixes: 700dadfefc3d ASoC: wm9713: convert to regmap > Cc: Lars-Pet

Re: [alsa-devel][PATCH] ASoC: wm8960: Add shared_lrclk and capless to device tree

2014-11-19 Thread Charles Keepax
On Wed, Nov 19, 2014 at 08:36:08PM +0800, Zidan Wang wrote: > wm8960 codec has a wm8960_data struct which has two fields shared_lrclk and > capless. > The wm8960_data is get from platform_data and it is reasonable to set it from > device > tree when platform_data is null. > And when shared_lrclk

Re: [alsa-devel][PATCH v2 2/2] ASoC: wm8960: LRCM operation should after software reset

2014-11-20 Thread Charles Keepax
; --- For patch 2 here: Acked-by: Charles Keepax Patch 1 could still use the docs fixups Lars suggested. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-13 Thread Charles Keepax
+++ > > No chance. > > Please resend with these in a header file (like all of the others). > > I'd also like Charles' Reviewed-by before accepting. This looks good to me. I don't quite follow what you are requesting with the header file? This still uses the head

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-12 Thread Charles Keepax
On Tue, Nov 11, 2014 at 05:03:19PM +, Richard Fitzgerald wrote: > Signed-off-by: Richard Fitzgerald > --- > drivers/mfd/Kconfig |6 + > drivers/mfd/Makefile |3 + > drivers/mfd/arizona-core.c | 91 ++- > drivers/mfd/arizona-irq.c| 42 +- > dr

Re: [alsa-devel][PATCH] ASoC: wm8960: Move register initialisation to I2C driver probe()

2014-11-27 Thread Charles Keepax
off-by: Zidan Wang > --- Acked-by: Charles Keepax Looks ok to me. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-17 Thread Charles Keepax
On Mon, Nov 17, 2014 at 12:54:33PM +, Richard Fitzgerald wrote: > On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: > > On Thu, 13 Nov 2014, Charles Keepax wrote: > > > This looks good to me. I don't quite follow what you are > > > requesting with the

Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-25 Thread Charles Keepax
on 0-day kernel tester. > > Signed-off-by: Maciej Szmigiero > Acked-by: Charles Keepax Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

[PATCH 1/2] mfd: arizona: Add convience defines for micd_rate/micd_bias_starttime

2015-05-25 Thread Charles Keepax
Signed-off-by: Charles Keepax --- include/dt-bindings/mfd/arizona.h | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/include/dt-bindings/mfd/arizona.h b/include/dt-bindings/mfd/arizona.h index c7af7c7..5556099 100644 --- a/include/dt-bindings/mfd/arizona.h

[PATCH 2/2] mfd: arizona: Add DT/ACPI u32 helper functions

2015-05-25 Thread Charles Keepax
Add helpers to read u32's and arrays of u32's from device tree or ACPI using the new device properties API. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c | 39 ++ include/linux/mfd/arizona/core.h |5 2 files c

[PATCH] mfd: arizona: Add missing parenthesis

2015-05-15 Thread Charles Keepax
esis. Reported-by: Dan Carpenter Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 5caf579..bebf58a 100644 --- a/drivers/mfd/arizona-core.c +++ b/driv

Re: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-15 Thread Charles Keepax
> > - Previously, use 'cable_index' on these functions: > extcon_get_cable_state_(struct extcon_dev*, int cable_index) > extcon_set_cable_state_(struct extcon_dev*, int cable_index, bool state) > > -Newly, use 'enum extcon id' on these functions: > ex

Re: [PATCH v5 1/1] mfd: arizona: Export functions to control subsystem DVFS

2015-05-19 Thread Charles Keepax
On Mon, May 18, 2015 at 03:15:05PM +0100, Richard Fitzgerald wrote: > The WM5102, WM8997, WM8998 and WM1814 codecs have an internal dynamic > clock booster. When this booster is active, the DCVDD voltage must be > increased. If all the currently active audio paths can run with the root > SYSCLK we

Re: [PATCH v6 1/1] mfd: arizona: Export functions to control subsystem DVFS

2015-05-19 Thread Charles Keepax
, so there's no need for > reference counting, we only need a simple boolean for each subsystem > of whether their current condition could require the booster or will > allow us to turn the codec down to lower operating power. > > Signed-off-by: Richard Fitzgerald > --- Revie

[PATCH v2] mfd: arizona: Add missing braces

2015-05-19 Thread Charles Keepax
eported-by: Dan Carpenter Signed-off-by: Charles Keepax --- Changes since v1: - Corrected braino in commit message (parenthesis -> braces) Thanks, Charles drivers/mfd/arizona-core.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/

[RESEND PATCH v3 05/10] mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch

2015-05-11 Thread Charles Keepax
wm5102 applies a custom hardware boot sequence, for this the SYSCLK needs to be enabled. This patch factors out the code that enables SYSCLK for this sequence such that it can be used for other boot time operations that require SYSCLK. Signed-off-by: Charles Keepax Acked-by: Lee Jones

[RESEND PATCH v3 06/10] mfd: wm5110: Add register patch required for low power sleep

2015-05-11 Thread Charles Keepax
functionality. Signed-off-by: Charles Keepax Acked-by: Lee Jones --- drivers/mfd/arizona-core.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index b5a7e0e..c80ab79 100644 --- a

[RESEND PATCH v3 02/10] mfd: arizona: Factor out hard reset into helper functions

2015-05-11 Thread Charles Keepax
This patch adds functions for enabling and disabling the physical reset line. This will be helpful in future refactoring. Signed-off-by: Charles Keepax Acked-by: Lee Jones --- drivers/mfd/arizona-core.c | 25 + 1 files changed, 17 insertions(+), 8 deletions(-) diff

[RESEND PATCH v3 00/10] wm5110 Boot Fixups

2015-05-11 Thread Charles Keepax
as per Lee's preference. Thanks, Charles Charles Keepax (10): mfd: arizona: Use devres to manage reset GPIO mfd: arizona: Factor out hard reset into helper functions mfd: wm5102: Ensure we always boot the device fully mfd: arizona: Fix formating/style issu

[RESEND PATCH v3 10/10] mfd: wm5110: Add delay before releasing reset line

2015-05-11 Thread Charles Keepax
On the wm5110 it is important the reset line is held for slightly longer to ensure the device starts up well. This patch adds a 5mS delay for this. Signed-off-by: Charles Keepax Acked-by: Lee Jones --- drivers/mfd/arizona-core.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions

[RESEND PATCH v3 08/10] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode

2015-05-11 Thread Charles Keepax
The low power sleep mode on wm5110 requires that the LDO1 regulator be set to 1.175V prior to entering sleep, then returned to 1.2V after exiting sleep mode. This patch apply these regulator settings. Signed-off-by: Charles Keepax Acked-by: Mark Brown Acked-by: Lee Jones --- drivers/mfd

[RESEND PATCH v3 09/10] mfd: arizona: Add better support for system suspend

2015-05-11 Thread Charles Keepax
, because we need to hold reset until the first time DCVDD is powered anyway (which would be in runtime resume), and we might as well save the extra power. Signed-off-by: Charles Keepax Acked-by: Lee Jones --- drivers/mfd/arizona-core.c | 94 +++--- include

[RESEND PATCH v3 01/10] mfd: arizona: Use devres to manage reset GPIO

2015-05-11 Thread Charles Keepax
This also handily fixes a leak of the GPIO in arizona_dev_exit. Signed-off-by: Charles Keepax Acked-by: Lee Jones --- drivers/mfd/arizona-core.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index

[RESEND PATCH v3 04/10] mfd: arizona: Fix formating/style issues in arizona_apply_hardware_patch

2015-05-11 Thread Charles Keepax
In preparation for some refactoring fixup some minor style, formating and code clarity issues. Signed-off-by: Charles Keepax Acked-by: Lee Jones --- drivers/mfd/arizona-core.c | 37 + 1 files changed, 17 insertions(+), 20 deletions(-) diff --git a/drivers

[RESEND PATCH v3 07/10] regulator: arizona-ldo1: Add additional supported voltage

2015-05-11 Thread Charles Keepax
This patch adds support for the 1.175V mode on the LDO1 regulator on the wm5110. This is need as part of the low power sleep mode operation. Signed-off-by: Charles Keepax Acked-by: Mark Brown --- drivers/regulator/arizona-ldo1.c | 15 +++ 1 files changed, 15 insertions(+), 0

[RESEND PATCH v3 03/10] mfd: wm5102: Ensure we always boot the device fully

2015-05-11 Thread Charles Keepax
what this patch does. Signed-off-by: Charles Keepax Acked-by: Lee Jones --- drivers/mfd/arizona-core.c | 50 +++ 1 files changed, 40 insertions(+), 10 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index f30d925..0df1299

Re: [RESEND PATCH v3 07/10] regulator: arizona-ldo1: Add additional supported voltage

2015-05-11 Thread Charles Keepax
On Mon, May 11, 2015 at 03:20:02PM +0100, Mark Brown wrote: > On Mon, May 11, 2015 at 01:58:07PM +0100, Charles Keepax wrote: > > This patch adds support for the 1.175V mode on the LDO1 regulator on the > > wm5110. This is need as part of the low power sleep mode operation. >

Re: [alsa-devel][PATCH 3/4] ASoC: wm8960: fix "RINPUT3" audio route error

2015-05-12 Thread Charles Keepax
On Tue, May 12, 2015 at 02:58:36PM +0800, Zidan Wang wrote: > It should be "RINPUT3" instead of "LINPUT3" route to "Right Input > Mixer". > > Signed-off-by: Zidan Wang > --- Acked-by: Charles Keepax Better to put bug fixes like this at the start of

Re: [alsa-devel][PATCH 4/4] ASoC: wm8958: correct BCLK DIV 348 to 384

2015-05-12 Thread Charles Keepax
On Tue, May 12, 2015 at 02:58:50PM +0800, Zidan Wang wrote: > According to the RM of wm8958, BCLK DIV 348 doesn't exist, correct it > to 384. > > Signed-off-by: Zidan Wang > --- Acked-by: Charles Keepax Thanks, Charles -- To unsubscribe from this list: send the line "

Re: [alsa-devel][PATCH 2/4] ASoC: wm8960: add 32 bit word length support

2015-05-12 Thread Charles Keepax
On Tue, May 12, 2015 at 02:58:21PM +0800, Zidan Wang wrote: > According to referance manual, right justify mode can't > support 32 bit word length. > > Signed-off-by: Zidan Wang > --- Acked-by: Charles Keepax Thanks, Charles -- To unsubscribe from this list: send the lin

Re: [PATCH] mfd: arizona: Move useful defines into a dt-binding include

2015-02-24 Thread Charles Keepax
On Mon, Feb 23, 2015 at 10:00:50AM -0600, Rob Herring wrote: > On Wed, Feb 18, 2015 at 5:03 AM, Charles Keepax > wrote: > > Move parts of linux/mfd/arizona/pdata.h and gpio.h into a new file in > > the dt-binding directory for use by device tree bindings. This also > > m

[PATCH v2] mfd: arizona: Move useful defines into a dt-binding include

2015-02-25 Thread Charles Keepax
Move parts of linux/mfd/arizona/pdata.h and gpio.h into a new file in the dt-binding directory for use by device tree bindings. This also makes gpio.h redundant so remove it in the process. Signed-off-by: Charles Keepax Acked-by: Mark Brown --- Changes since v1: - Removed some defines that

[PATCH v2] mfd: arizona: Move useful defines into a dt-binding include

2015-02-25 Thread Charles Keepax
Move parts of linux/mfd/arizona/pdata.h and gpio.h into a new file in the dt-binding directory for use by device tree bindings. This also makes gpio.h redundant so remove it in the process. Signed-off-by: Charles Keepax Acked-by: Mark Brown --- Changes since v1: - Removed some defines that

[PATCH v3] mfd: arizona: Move useful defines into a dt-binding include

2015-02-25 Thread Charles Keepax
Move parts of linux/mfd/arizona/pdata.h and gpio.h into a new file in the dt-binding directory for use by device tree bindings. This also makes gpio.h redundant so remove it in the process. Signed-off-by: Charles Keepax Acked-by: Mark Brown Acked-by: Rob Herring --- Changes since v2

Re: [PATCH 1/2] ASoC: wm8996: match wait_for_completion_timeout return type

2015-03-09 Thread Charles Keepax
et to > 1 if no timeout occurred. > > Signed-off-by: Nicholas Mc Guire > --- Acked-by: Charles Keepax Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/2] ASoC: wm8996: ensure lower bounds of 1 for timeout

2015-03-09 Thread Charles Keepax
t; timeout to 0. This patch simply adds a lower-bounds of 1. > > Signed-off-by: Nicholas Mc Guire > --- Acked-by: Charles Keepax Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

Re: [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type

2015-03-09 Thread Charles Keepax
On Sun, Mar 08, 2015 at 06:57:07AM -0400, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. An > appropriately named unsigned long is added and the assignment fixed up. > > Signed-off-by: Nicholas Mc Guire > --- Acked-by: Charles

Re: [PATCH] ASoC: arizona: match wait_for_completion_timeout return type

2015-03-09 Thread Charles Keepax
On Sun, Mar 08, 2015 at 09:16:49AM -0400, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. An > appropriately named unsigned long is added and the assignment fixed up. > > Signed-off-by: Nicholas Mc Guire > --- Acked-by: Charles

[PATCH] mfd: arizona: Update DT binding documentation for inmode

2015-03-09 Thread Charles Keepax
Update the DT binding documentation for the inmode binding to mention the new defines and clarify the text slightly. Signed-off-by: Charles Keepax --- Documentation/devicetree/bindings/mfd/arizona.txt | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a

[RESEND PATCH] mfd: arizona: Remove redundant register sync

2015-03-09 Thread Charles Keepax
This soft reset used to be located after the register patch had been applied, but has since moved to before the patch is applied. At the new location there is no requirement to do a register sync as no register writes will have happened yet. Signed-off-by: Charles Keepax --- drivers/mfd/arizona

[PATCH] mfd: arizona: Correct type of gpio_defaults

2015-03-29 Thread Charles Keepax
negative numbers and be written out directly to the hardware. As no where in the code replies on gpio_defaults being an int, the simplest fix is to just change it to unsigned. Signed-off-by: Charles Keepax --- include/linux/mfd/arizona/pdata.h |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [PATCH v2 2/4] mfd: wm5110: Add register patch required for low power sleep

2015-03-23 Thread Charles Keepax
On Mon, Mar 23, 2015 at 02:13:07PM +, Lee Jones wrote: > On Tue, 17 Mar 2015, Charles Keepax wrote: > > > Some register settings must be applied before the first time low power > > sleep mode is entered on the wm5110 to ensure optimium performance. > > These setti

Re: [PATCH v2 1/4] mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch

2015-03-23 Thread Charles Keepax
On Mon, Mar 23, 2015 at 01:52:13PM +, Lee Jones wrote: > On Tue, 17 Mar 2015, Charles Keepax wrote: > > > wm5102 applies a custom hardware boot sequence, for this the SYSCLK > > needs to be enabled. This patch factors out the code that enables > > SYSCLK for this sequ

[PATCH v3 3/4] regulator: arizona-ldo1: Add additional supported voltage

2015-03-23 Thread Charles Keepax
This patch adds support for the 1.175V mode on the LDO1 regulator on the wm5110. This is need as part of the low power sleep mode operation. Signed-off-by: Charles Keepax Acked-by: Mark Brown --- drivers/regulator/arizona-ldo1.c | 15 +++ 1 files changed, 15 insertions(+), 0

[PATCH v3 2/4] mfd: wm5110: Add register patch required for low power sleep

2015-03-23 Thread Charles Keepax
functionality. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 695c68e..b82b909 100644 --- a/drivers/mfd

[PATCH v3 1/4] mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch

2015-03-23 Thread Charles Keepax
wm5102 applies a custom hardware boot sequence, for this the SYSCLK needs to be enabled. This patch factors out the code that enables SYSCLK for this sequence such that it can be used for other boot time operations that require SYSCLK. Signed-off-by: Charles Keepax --- Changes since v3

[PATCH v3 4/4] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode

2015-03-23 Thread Charles Keepax
The low power sleep mode on wm5110 requires that the LDO1 regulator be set to 1.175V prior to entering sleep, then returned to 1.2V after exiting sleep mode. This patch apply these regulator settings. Signed-off-by: Charles Keepax Acked-by: Mark Brown --- drivers/mfd/arizona-core.c | 52

[PATCH] regulator: arizona-ldo1: Add ramp time for HI_PWR

2015-03-24 Thread Charles Keepax
From: Richard Fitzgerald For regulators that support HI_PWR we need to ensure that switching to 1.8v allows time for the regulator to reach that voltage. Signed-off-by: Richard Fitzgerald Signed-off-by: Charles Keepax --- drivers/regulator/arizona-ldo1.c | 12 1 files changed

[PATCH 3/5] mfd: arizona: Factor out hard reset into helper functions

2015-03-24 Thread Charles Keepax
This patch adds functions for enabling and disabling the physical reset line. This will be helpful in future refactoring. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH 5/5] mfd: wm5110: Add delay before releasing reset line

2015-03-24 Thread Charles Keepax
On the wm5110 it is important the reset line is held for slightly longer to ensure the device starts up well. This patch adds a 5mS delay for this. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a

[PATCH 0/5] wm5110 Boot Fixups Part 2

2015-03-24 Thread Charles Keepax
regulators down causing a second cold boot. NOTE: This series is dependent on the other series being reviewed starting with: mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch Thanks, Charles [1] https://lkml.org/lkml/2015/3/16/811 Charles Keepax (5): mfd: arizona: Add missing

[PATCH 2/5] mfd: wm5102: Move check for custom boot into arizona_wait_for_boot

2015-03-24 Thread Charles Keepax
e the custom boot is activated. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c | 54 +-- 1 files changed, 26 insertions(+), 28 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index f0dbaa6..aaaecaa 100644

[PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev_exit

2015-03-24 Thread Charles Keepax
Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 01fb9eb..f0dbaa6 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c

[PATCH 4/5] mfd: arizona: Add better support for system suspend

2015-03-24 Thread Charles Keepax
, because we need to hold reset until the first time DCVDD is powered anyway (which would be in runtime resume), and we might as well save the extra power. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c | 47 ++ include/linux/mfd/arizona/core.h

Re: [PATCH] regulator: arizona-ldo1: Add ramp time for HI_PWR

2015-03-24 Thread Charles Keepax
On Tue, Mar 24, 2015 at 09:06:09AM -0700, Mark Brown wrote: > On Tue, Mar 24, 2015 at 02:27:56PM +0000, Charles Keepax wrote: > > > +static int arizona_ldo1_hc_set_voltage_time_sel(struct regulator_dev *rdev, > > + unsigne

Re: [PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev_exit

2015-03-24 Thread Charles Keepax
On Tue, Mar 24, 2015 at 09:06:43AM -0700, Mark Brown wrote: > On Tue, Mar 24, 2015 at 02:59:48PM +0000, Charles Keepax wrote: > > > - if (arizona->pdata.reset) > > + if (arizona->pdata.reset) { > > gpio_set_value_cansleep(arizona->pdata.reset, 0);

[PATCH v2 5/5] mfd: wm5110: Add delay before releasing reset line

2015-03-24 Thread Charles Keepax
On the wm5110 it is important the reset line is held for slightly longer to ensure the device starts up well. This patch adds a 5mS delay for this. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a

Re: [PATCH] regulator: arizona-ldo1: Add ramp time for HI_PWR

2015-03-24 Thread Charles Keepax
On Tue, Mar 24, 2015 at 10:05:54AM -0700, Mark Brown wrote: > On Tue, Mar 24, 2015 at 04:40:50PM +0000, Charles Keepax wrote: > > On Tue, Mar 24, 2015 at 09:06:09AM -0700, Mark Brown wrote: > > > > So changes to move to the top voltage always take constant time while &g

Re: [PATCH] regulator: arizona-ldo1: Add ramp time for HI_PWR

2015-03-24 Thread Charles Keepax
On Tue, Mar 24, 2015 at 04:40:50PM +, Charles Keepax wrote: > On Tue, Mar 24, 2015 at 09:06:09AM -0700, Mark Brown wrote: > > On Tue, Mar 24, 2015 at 02:27:56PM +, Charles Keepax wrote: > > > > > +static int arizona_ldo1_hc_set_voltage_time_sel(struct re

[PATCH v2 1/5] mfd: arizona: Use devres to manage reset GPIO

2015-03-24 Thread Charles Keepax
This also handily fixes a leak of the GPIO in arizona_dev_exit. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 01fb9eb..c490fe9 100644

[PATCH v2 4/5] mfd: arizona: Add better support for system suspend

2015-03-24 Thread Charles Keepax
, because we need to hold reset until the first time DCVDD is powered anyway (which would be in runtime resume), and we might as well save the extra power. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c | 47 ++ include/linux/mfd/arizona/core.h

[PATCH v2 3/5] mfd: arizona: Factor out hard reset into helper functions

2015-03-24 Thread Charles Keepax
This patch adds functions for enabling and disabling the physical reset line. This will be helpful in future refactoring. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c | 25 + 1 files changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/mfd

[PATCH v2 0/5] wm5110 Boot Fixups Part 2

2015-03-24 Thread Charles Keepax
Charles Keepax (5): mfd: arizona: Use devres to manage reset GPIO mfd: wm5102: Move check for custom boot into arizona_wait_for_boot mfd: arizona: Factor out hard reset into helper functions mfd: arizona: Add better support for system suspend mfd: wm5110: Add delay before releasing reset

[PATCH v2 2/5] mfd: wm5102: Move check for custom boot into arizona_wait_for_boot

2015-03-24 Thread Charles Keepax
e the custom boot is activated. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-core.c | 54 +-- 1 files changed, 26 insertions(+), 28 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index c490fe9..710e9cc 100644

[PATCH v2] regulator: arizona-ldo1: Add ramp time for HI_PWR

2015-03-25 Thread Charles Keepax
From: Richard Fitzgerald For regulators that support HI_PWR we need to ensure that switching to 1.8v allows time for the regulator to reach that voltage. Signed-off-by: Richard Fitzgerald Signed-off-by: Charles Keepax --- Changes since v1: - Don't ever return a zero ramp time dr

[PATCH] ASoC: DAPM: Fix build warning

2015-03-25 Thread Charles Keepax
onst' qualifier from pointer target type snprintf(w_param_text[count], len, This patch fixes this by adding a non-const temporary variable to hold the value as it is created before assigning to the entry in w_param_text. Signed-off-by: Charles Keepax --- sound/soc/soc-dapm.c | 10 ++-

[PATCH v2] ASoC: dapm: Fix build warning

2015-03-25 Thread Charles Keepax
onst' qualifier from pointer target type snprintf(w_param_text[count], len, This patch fixes this by adding a non-const temporary variable to hold the value as it is created before assigning to the entry in w_param_text. Signed-off-by: Charles Keepax --- Changes since v1: - Just small fix

Re: [alsa-devel] [PATCH] ASoC: DAPM: Fix build warning

2015-03-25 Thread Charles Keepax
On Wed, Mar 25, 2015 at 11:53:30AM +0100, Takashi Iwai wrote: > At Wed, 25 Mar 2015 10:13:28 +, > Charles Keepax wrote: > > > > commit c66150824b8a ("ASoC: dapm: add code to configure dai link > > parameters") introduced the following build warning: > >

[PATCH v3] ASoC: dapm: Fix build warning

2015-03-25 Thread Charles Keepax
onst' qualifier from pointer target type snprintf(w_param_text[count], len, This patch fixes this by switching to using devm_kasprintf. This also saves a couple of lines of code. Signed-off-by: Charles Keepax --- Changes since v2: - Use devm_kasprintf sound/soc/soc-dapm.c | 13 +-

[PATCH 2/3] ASoC: wm8804: Use new devres regulator_register_notifier

2015-03-05 Thread Charles Keepax
From: Charles Keepax This is more idiomatic and also fixes an issue where the notifiers were being leaked if probe failed. Signed-off-by: Charles Keepax --- sound/soc/codecs/wm8804.c | 15 --- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/sound/soc/codecs

[PATCH 3/3] ASoC: wm8804: Fix small issues in probe error paths

2015-03-05 Thread Charles Keepax
ed to call regulator_bulk_disable if the enable fails, because the regulator core will handle this clean up for us. Finally, we need to disable the regulators if snd_soc_register_codecs fails. Signed-off-by: Charles Keepax --- sound/soc/codecs/wm8804.c | 13 ++--- 1 files changed, 10 insertions(+), 3

[PATCH 1/3] regulator: core: Add devres versions of notifier registration

2015-03-05 Thread Charles Keepax
From: Charles Keepax Add devm_regulator_register_notifier, this adds the resource against the device for the consumer supply we are registering the notifier for. There seem to be few use-cases where this wouldn't be the users intention and this ensures the notifiers will always be removed a

[PATCH] ASoC: wm8804: Update DT binding document to cover regulator supplies

2015-03-05 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Documentation/devicetree/bindings/sound/wm8804.txt |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/wm8804.txt b/Documentation/devicetree/bindings/sound/wm8804.txt index 4d3a56f..10ef076 100644

Re: [PATCH] drm/exynos: Check for NULL dereference of crtc

2015-03-06 Thread Charles Keepax
On Fri, Mar 06, 2015 at 10:13:42PM +0900, Inki Dae wrote: > On 2015년 02월 18일 02:14, Charles Keepax wrote: > > The commit "drm/exynos: remove exynos_plane_dpms" (d9ea6256) removed the > > use of the enabled flag, which means that the code may attempt to call > >

Re: [PATCH 3/5] mfd: wm5110: Add delay before releasing reset line on cold boot

2015-03-17 Thread Charles Keepax
On Mon, Mar 16, 2015 at 08:47:10PM +, Mark Brown wrote: > On Mon, Mar 16, 2015 at 06:45:18PM +0000, Charles Keepax wrote: > > > I think your suspend example is pretty tricky, we enable the > > regulators for the core_supplies at boot, so I guess we have > > request

Re: [PATCH 3/5] mfd: wm5110: Add delay before releasing reset line on cold boot

2015-03-17 Thread Charles Keepax
On Tue, Mar 17, 2015 at 12:04:21PM +, Mark Brown wrote: > On Tue, Mar 17, 2015 at 11:50:30AM +0000, Charles Keepax wrote: > > On Mon, Mar 16, 2015 at 08:47:10PM +, Mark Brown wrote: > It seems easy enough to check if the device is active and it's very > common fo

[PATCH v2 1/4] mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch

2015-03-17 Thread Charles Keepax
wm5102 applies a custom hardware boot sequence, for this the SYSCLK needs to be enabled. This patch factors out the code that enables SYSCLK for this sequence such that it can be used for other boot time operations that require SYSCLK. Signed-off-by: Charles Keepax --- Changes since v1

[PATCH v2 3/4] regulator: arizona-ldo1: Add additional supported voltage

2015-03-17 Thread Charles Keepax
This patch adds support for the 1.175V mode on the LDO1 regulator on the wm5110. This is need as part of the low power sleep mode operation. Signed-off-by: Charles Keepax Acked-by: Mark Brown --- drivers/regulator/arizona-ldo1.c | 15 +++ 1 files changed, 15 insertions(+), 0

<    5   6   7   8   9   10   11   12   13   14   >