This patchset moves a misplaced include to the proper file, swaps out an overly
aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt().
Chase Southwood (3):
staging: comedi: addi_apci_1564: move addi_watchdog.h include to
addi_apci_1564.c
staging: comedi
Commit aed3f9d (staging: comedi: addi_apci_1564: absorb apci1564_reset()) moved
the only use of addi_watchdog.h from hwdrv_apci1564.c to addi_apci_1564.c, but
left the include statement itself in the former file. Move this include to the
file which actually uses it.
Signed-off-by: Chase
This patchset moves a misplaced include to the proper file, swaps out an overly
aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt().
Chase Southwood (3):
staging: comedi: addi_apci_1564: move addi_watchdog.h include to
addi_apci_1564.c
staging: comedi
Commit aed3f9d (staging: comedi: addi_apci_1564: absorb apci1564_reset()) moved
the only use of addi_watchdog.h from hwdrv_apci1564.c to addi_apci_1564.c, but
left the include statement itself in the former file. Move this include to the
file which actually uses it.
Signed-off-by: Chase
, and
counters as well. Replace the reset function call with a direct disabling of
just the digital input interrupts.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564
of
devpriv-timer_select_mode before processing any triggered interrupts, remove
all occurrences of this.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
Hartley,
I remember that you mentioned
containing only the fields it will actually use.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 182 ++---
drivers/staging/comedi/drivers/addi_apci_1564.c| 46 +++---
2 files changed, 118 insertions
is broken since it does not follow the comedi API for insn_config
functions. Fix this function by implementing the config instruction
INSN_CONFIG_DIGITAL_TRIG.
Add the remaining subdevice operations necessary for the interrupt
subdevice to support async commands.
Signed-off-by: Chase Southwood
Cc: Ian
On moving the function into the driver proper, also check the device is
asserting the shared interrupt line.
This patch also fixes the interrupt handling for the digital input
change-of-state interrupts.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi
The global variables ui_InterruptStatus_1564 and ui_InterruptData are both
set but never used. Just remove them from the driver.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 7 +--
1 file changed, 1
This member of the private data struct is only set at one location in the
entire driver, and then never even used for anything. Let's just remove
its use.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 5
been fixed.
CHANGES FROM v2:
*Just refreshed set against staging-next. Otherwise everything is
exactly the same, and should apply now.
Chase Southwood (5):
staging: comedi: addi_apci_1564: remove use of
devpriv->b_OutputMemoryStatus
staging: comedi: addi_apci_1564: remove unused sta
been fixed.
CHANGES FROM v2:
*Just refreshed set against staging-next. Otherwise everything is
exactly the same, and should apply now.
Chase Southwood (5):
staging: comedi: addi_apci_1564: remove use of
devpriv-b_OutputMemoryStatus
staging: comedi: addi_apci_1564: remove unused static
This member of the private data struct is only set at one location in the
entire driver, and then never even used for anything. Let's just remove
its use.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeeten hswee...@visionengravers.com
The global variables ui_InterruptStatus_1564 and ui_InterruptData are both
set but never used. Just remove them from the driver.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging
containing only the fields it will actually use.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 182 ++---
drivers/staging/comedi/drivers
is broken since it does not follow the comedi API for insn_config
functions. Fix this function by implementing the config instruction
INSN_CONFIG_DIGITAL_TRIG.
Add the remaining subdevice operations necessary for the interrupt
subdevice to support async commands.
Signed-off-by: Chase Southwood
On moving the function into the driver proper, also check the device is
asserting the shared interrupt line.
This patch also fixes the interrupt handling for the digital input
change-of-state interrupts.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc
On moving the function into the driver proper, also check the device is
asserting the shared interrupt line.
This patch also fixes the interrupt handling for the digital input
change-of-state interrupts.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Hartley,
I know
is broken since it does not follow the comedi API for insn_config
functions. Fix this function by implementing the config instruction
INSN_CONFIG_DIGITAL_TRIG.
Add the remaining subdevice operations necessary for the interrupt
subdevice to support async commands.
Signed-off-by: Chase Southwood
Cc: Ian
The global variables ui_InterruptStatus_1564 and ui_InterruptData are both
set but never used. Just remove them from the driver.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 7 +--
1 file changed, 1
containing only the fields it will actually use.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 182 ++---
drivers/staging/comedi/drivers/addi_apci_1564.c| 46 +++---
2 files changed, 118 insertions
This member of the private data struct is only set at one location in the
entire driver, and then never even used for anything. Let's just remove
its use.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 5
been fixed.
Chase Southwood (5):
staging: comedi: addi_apci_1564: remove use of
devpriv->b_OutputMemoryStatus
staging: comedi: addi_apci_1564: remove unused static variables
staging: comedi: addi_apci_1564: introduce apci1564_private struct
staging: comedi: addi_apci_1564: add Cha
been fixed.
Chase Southwood (5):
staging: comedi: addi_apci_1564: remove use of
devpriv-b_OutputMemoryStatus
staging: comedi: addi_apci_1564: remove unused static variables
staging: comedi: addi_apci_1564: introduce apci1564_private struct
staging: comedi: addi_apci_1564: add Change
This member of the private data struct is only set at one location in the
entire driver, and then never even used for anything. Let's just remove
its use.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeeten hswee...@visionengravers.com
containing only the fields it will actually use.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 182 ++---
drivers/staging/comedi/drivers
The global variables ui_InterruptStatus_1564 and ui_InterruptData are both
set but never used. Just remove them from the driver.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging
On moving the function into the driver proper, also check the device is
asserting the shared interrupt line.
This patch also fixes the interrupt handling for the digital input
change-of-state interrupts.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc
is broken since it does not follow the comedi API for insn_config
functions. Fix this function by implementing the config instruction
INSN_CONFIG_DIGITAL_TRIG.
Add the remaining subdevice operations necessary for the interrupt
subdevice to support async commands.
Signed-off-by: Chase Southwood
On Fri, May 30, 2014 at 12:26 PM, Hartley Sweeten
wrote:
> On Thursday, May 29, 2014 9:44 PM, Chase Southwood wrote:
>> Move the function apci1564_interrupt() from hwdrv_apci1564.c to
>> addi_apci_1564.c. On moving, for now just strip out all of the
>> code for interrupts
On Fri, May 30, 2014 at 12:26 PM, Hartley Sweeten
hartl...@visionengravers.com wrote:
On Thursday, May 29, 2014 9:44 PM, Chase Southwood wrote:
Move the function apci1564_interrupt() from hwdrv_apci1564.c to
addi_apci_1564.c. On moving, for now just strip out all of the
code for interrupts
) to IRQ_HANDLED.
We also check the device is asserting the shared interrupt line and check
that interrupts have been enabled.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Admittedly, I am not sure if what I have done in the interrupt handler is
quite sufficient. Am I
functions. Fix this function by implementing the config instruction
INSN_CONFIG_DIGITAL_TRIG.
Add the remaining subdevice operations necessary for the interrupt
subdevice to support async commands.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
The structure of _much_
containing only the fields it will actually use.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 164 +++--
drivers/staging/comedi/drivers/addi_apci_1564.c| 34 ++---
2 files changed, 102 insertions(+), 96
This board supports an interrupt that can be generated by an AND/OR
combination of 16 of the input channels.
Create a separate subdevice to handle this interrupt.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 16
r.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 --
1 file changed, 23 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
b/drivers/staging/comedi/drivers
This member of the private data struct is only set at one location in the
entire driver, and then never even used for anything. Let's just remove
its use.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 5
This patchset introduces a new private data struct for this driver, adds
all of the code required to support Change-of-State interrupts for the
digital input subsystem, and finally focuses and fixes
apci1564_interrupt() to service this type of interrupt correctly.
Chase Southwood (6):
staging
Hi Greg,
On Sat, May 24, 2014 at 5:23 PM, Chase Southwood
wrote:
> This patchset adds the required subdevice for supporting DI COS interrupts,
> as well as introducing a driver-specific private data struct that will
> make the COS interrupt operations much more straightforward
Hi Greg,
On Sat, May 24, 2014 at 5:23 PM, Chase Southwood
chase.southw...@gmail.com wrote:
This patchset adds the required subdevice for supporting DI COS interrupts,
as well as introducing a driver-specific private data struct that will
make the COS interrupt operations much more
This patchset introduces a new private data struct for this driver, adds
all of the code required to support Change-of-State interrupts for the
digital input subsystem, and finally focuses and fixes
apci1564_interrupt() to service this type of interrupt correctly.
Chase Southwood (6):
staging
This member of the private data struct is only set at one location in the
entire driver, and then never even used for anything. Let's just remove
its use.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeeten hswee...@visionengravers.com
-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 --
1 file changed, 23 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi
This board supports an interrupt that can be generated by an AND/OR
combination of 16 of the input channels.
Create a separate subdevice to handle this interrupt.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee
functions. Fix this function by implementing the config instruction
INSN_CONFIG_DIGITAL_TRIG.
Add the remaining subdevice operations necessary for the interrupt
subdevice to support async commands.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H
containing only the fields it will actually use.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 164 +++--
drivers/staging/comedi/drivers
) to IRQ_HANDLED.
We also check the device is asserting the shared interrupt line and check
that interrupts have been enabled.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
Admittedly, I am not sure
On Tue, May 27, 2014 at 11:34 AM, Ian Abbott wrote:
> On 2014-05-24 23:24, Chase Southwood wrote:
>>
>> This board supports an interrupt that can be generated by an AND/OR
>> combination of 16 of the input channels.
>>
>> Create a separate subdevice to hand
On Tue, May 27, 2014 at 11:34 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-05-24 23:24, Chase Southwood wrote:
This board supports an interrupt that can be generated by an AND/OR
combination of 16 of the input channels.
Create a separate subdevice to handle this interrupt.
In doing
containing only the fields it will actually use.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
The idea behind this patch is that it will allow me to rewrite the
apci1564_cos_insn_config() function the same way that Hartley did for
addi_apci_1032.c, using new fields
r.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 --
1 file changed, 23 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
b/drivers/staging/comedi/drivers
renames it to
make it more apparent that it is the config operation for the COS interrupt.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 8
drivers/staging/comedi/drivers/addi_apci_1564.c| 18
This patchset adds the required subdevice for supporting DI COS interrupts,
as well as introducing a driver-specific private data struct that will
make the COS interrupt operations much more straightforward and clean.
Chase Southwood (3):
staging: comedi: addi_apci_1564: add a subdevice
This patchset adds the required subdevice for supporting DI COS interrupts,
as well as introducing a driver-specific private data struct that will
make the COS interrupt operations much more straightforward and clean.
Chase Southwood (3):
staging: comedi: addi_apci_1564: add a subdevice
renames it to
make it more apparent that it is the config operation for the COS interrupt.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 8
-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 --
1 file changed, 23 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi
containing only the fields it will actually use.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
The idea behind this patch is that it will allow me to rewrite the
apci1564_cos_insn_config() function the same
This function is already compliant with the comedi API and is behaving as
comedi core expects. This patch moves it out of
addi-data/hwdrv_apci1564.c and into the driver proper since no further
work needs to be done on it.
Cc: Ian Abbott
Cc: H Hartley Sweeten
Signed-off-by: Chase Southwood
This function is already compliant with the comedi API and is behaving as
comedi core expects. This patch moves it out of
addi-data/hwdrv_apci1564.c and into the driver proper since no further
work needs to be done on it.
Cc: Ian Abbott
Cc: H Hartley Sweeten
Signed-off-by: Chase Southwood
...@visionengravers.com
Signed-off-by: Chase Southwood chase.southw...@gmail.com
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 12
drivers/staging/comedi/drivers/addi_apci_1564.c | 12
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers
...@visionengravers.com
Signed-off-by: Chase Southwood chase.southw...@gmail.com
---
Just a couple patches in this set, but with these out of the way, the
next patchset can focus entirely on getting the change-of-state interrupt
functionality working. Made sense to just finish up with DI/DO and start
COS
This driver only supports a single board type. Remove the boardinfo and
its use in the driver.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff
The only board served by this driver always has a timer, so we can init
the timer subdevice without checking first.
The boardinfo about the timer can also be removed and the data used
directly.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi
This patchset removes the last dependency on this driver's boardinfo (the
timer subdevice init), and then removes the boardinfo from the driver.
To be applied on top of my prior patchset "staging: comedi:
addi_apci_1564: further cleanups"
Chase Southwood (2):
staging: comedi: addi
This patchset removes the last dependency on this driver's boardinfo (the
timer subdevice init), and then removes the boardinfo from the driver.
To be applied on top of my prior patchset staging: comedi:
addi_apci_1564: further cleanups
Chase Southwood (2):
staging: comedi: addi_apci_1564
The only board served by this driver always has a timer, so we can init
the timer subdevice without checking first.
The boardinfo about the timer can also be removed and the data used
directly.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H
This driver only supports a single board type. Remove the boardinfo and
its use in the driver.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 13
On Sat, May 3, 2014 at 6:52 PM, Greg KH wrote:
> On Mon, Apr 28, 2014 at 12:40:05PM +0300, Dan Carpenter wrote:
>> Nice, Chase, you've become an expert on comedi, it seems.
>>
>> I can't say how happy comedi patches make me these days. Ian, you and
>> Hartley are doing a fantastic job.
>
> Same
On Sat, May 3, 2014 at 6:52 PM, Greg KH gre...@linuxfoundation.org wrote:
On Mon, Apr 28, 2014 at 12:40:05PM +0300, Dan Carpenter wrote:
Nice, Chase, you've become an expert on comedi, it seems.
I can't say how happy comedi patches make me these days. Ian, you and
Hartley are doing a
This is the only reset fuction used by this driver. We can remove it from
the boardinfo and absorb the code from hwdrv_apci1564.c into the driver.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 32
Remove the boardinfo about the interrupt function and just call it
directly.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi
The addi-data common code always allocates 7 subdevices. This driver
cannot or will not use the ones we are currently allocating for analog
input and output or EEPROM, so just don't allocate these subdevices at
all.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
This board always has 32 digital outputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver, remove
the boardinfo about the digital outputs and just use the data directly in
the subdevice init.
Signed-off-by: Chase Southwood
Cc
: remove eeprom support code)
Chase Southwood (4):
staging: comedi: addi_apci_1564: board has 32 digital outputs
staging: comedi: addi_apci_1564: don't allocate unused subdevices
staging: comedi: addi_apci_1564: absorb apci1564_reset()
staging: comedi: addi_apci_1564: call apci1564_interrupt
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv->s_EeParameters.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
2: Incorrect patch ti
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv-s_EeParameters.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley
: remove eeprom support code)
Chase Southwood (4):
staging: comedi: addi_apci_1564: board has 32 digital outputs
staging: comedi: addi_apci_1564: don't allocate unused subdevices
staging: comedi: addi_apci_1564: absorb apci1564_reset()
staging: comedi: addi_apci_1564: call apci1564_interrupt
This board always has 32 digital outputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver, remove
the boardinfo about the digital outputs and just use the data directly in
the subdevice init.
Signed-off-by: Chase Southwood
The addi-data common code always allocates 7 subdevices. This driver
cannot or will not use the ones we are currently allocating for analog
input and output or EEPROM, so just don't allocate these subdevices at
all.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo
This is the only reset fuction used by this driver. We can remove it from
the boardinfo and absorb the code from hwdrv_apci1564.c into the driver.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
Remove the boardinfo about the interrupt function and just call it
directly.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 6 +-
1 file changed
AM, Chase Southwood wrote:
>> Thanks so much, I greatly appreciate the review. I'll fix the
>> changelog for patch 4 and send once more (as I assume that's easier
>> for Greg). Also, I should know better about the cover letter as
>> well...I was once told not to sen
This driver only uses PCI bar 0 (devpriv->i_IobaseAmcc), and PCI bar 1
(dev->iobase), don't bother reading the unused PCI bars.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
2: Bad PCI bar numbers corrected.
3: Fixed silly typos in the changelog
drivers/s
:
> On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote:
>> This driver no longer reads the eeprom to find the board specific data,
>> all the necessary data is in the boardinfo. Use the boardinfo directly
>> instead of passing through devpriv->s_EeParameters.
>>
>
...@visionengravers.com wrote:
On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote:
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv-s_EeParameters.
Signed-off
This driver only uses PCI bar 0 (devpriv-i_IobaseAmcc), and PCI bar 1
(dev-iobase), don't bother reading the unused PCI bars.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
2: Bad PCI bar numbers
:
On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote:
Thanks so much, I greatly appreciate the review. I'll fix the
changelog for patch 4 and send once more (as I assume that's easier
for Greg). Also, I should know better about the cover letter as
well...I was once told not to send them
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv->s_EeParameters.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
2: Incorrect patch ti
The i_IorangeBase1, i_PCIEeprom, and pc_EepromChip data in the boardinfo
was only needed to work out the usage of the PCI bars. Now that that is
squared away, this info is no longer needed and can be removed.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
2: Incorrect
This driver only uses PCI bar 1 (devpriv->i_IobaseAmcc), and PCI bar 2
(dev->iobase) doon't bother reading the unused PCI bars.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
2: Bad PCI bar numbers corrected.
drivers/staging/comedi/drivers/addi_apci_1564.
This board always has 32 digital inputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver,
remove the boardinfo about the digital inputs and just use the
data directly in the subdevice init.
Signed-off-by: Chase Southwood
Cc: Ian
to
be more careful in the future.
Thanks your all of the assistance and patience,
Chase
On Mon, Apr 28, 2014 at 1:09 PM, Hartley Sweeten
wrote:
> On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote:
>> This driver only uses PCI bar 1 (devpriv->i_IobaseAmcc), and PCI bar 2
>
day, April 26, 2014 6:39 PM, Chase Southwood wrote:
>> This driver no longer reads the eeprom to find the board specific data,
>> all the necessary data is in the boardinfo. Use the boardinfo directly
>> instead of passing through devpriv->s_EeParameters.
>>
>> Signed
...@visionengravers.com wrote:
On Saturday, April 26, 2014 6:39 PM, Chase Southwood wrote:
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv-s_EeParameters.
Signed-off-by: Chase
to
be more careful in the future.
Thanks your all of the assistance and patience,
Chase
On Mon, Apr 28, 2014 at 1:09 PM, Hartley Sweeten
hartl...@visionengravers.com wrote:
On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote:
This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc
This board always has 32 digital inputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver,
remove the boardinfo about the digital inputs and just use the
data directly in the subdevice init.
Signed-off-by: Chase Southwood
This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2
(dev-iobase) doon't bother reading the unused PCI bars.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
2: Bad PCI bar numbers
The i_IorangeBase1, i_PCIEeprom, and pc_EepromChip data in the boardinfo
was only needed to work out the usage of the PCI bars. Now that that is
squared away, this info is no longer needed and can be removed.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv-s_EeParameters.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley
101 - 200 of 412 matches
Mail list logo
