The i_IorangeBase1, i_PCIEeprom, and pc_EepromChip data in the boardinfo
was only needed to work out the usage of the PCI bars. Now that that is
squared away, this info is no longer needed and can be removed.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv->s_EeParameters.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Ian and Hart
This board always has 32 digital inputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver,
remove the boardinfo about the digital inputs and just use the
data directly in the subdevice init.
Signed-off-by: Chase Southwood
Cc: Ian
This driver only uses PCI bar 1 (devpriv->i_IobaseAmcc), and PCI bar 2
(dev->iobase) doon't bother reading the unused PCI bars.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Hartley,
As far as I can tell from reading the I/O Mapping you sent me, these bar
n
This include is no longer needed.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c
b/drivers/staging/comedi/drivers
Reading the eeprom on this board is not necessary. All information
required is in the boardinfo.
Remove the eeprom support code which is not really useful here.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 46
Reading the eeprom on this board is not necessary. All information
required is in the boardinfo.
Remove the eeprom support code which is not really useful here.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee
This include is no longer needed.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging
This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2
(dev-iobase) doon't bother reading the unused PCI bars.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
Hartley,
As far as I can
This board always has 32 digital inputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver,
remove the boardinfo about the digital inputs and just use the
data directly in the subdevice init.
Signed-off-by: Chase Southwood
The i_IorangeBase1, i_PCIEeprom, and pc_EepromChip data in the boardinfo
was only needed to work out the usage of the PCI bars. Now that that is
squared away, this info is no longer needed and can be removed.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv-s_EeParameters.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley
The board supported by this driver does not have analog outputs. Remove
the subdevice init for it.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Compile tested only.
drivers/staging/comedi/drivers/addi_apci_1564.c | 13 ++---
1 file changed, 2 insertions
This board does not have analog inputs. Remove the subdevice init for
them.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Compile tested only. To be applied on top of
[PATCH] staging: comedi: addi_apci_1564: separate from addi_common.c
drivers/staging/comedi
This board does not have analog inputs. Remove the subdevice init for
them.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
Compile tested only. To be applied on top of
[PATCH] staging: comedi
The board supported by this driver does not have analog outputs. Remove
the subdevice init for it.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
Compile tested only.
drivers/staging/comedi
that a negative error code from comedi_timeout() can be propagated
if necessary.
Signed-off-by: Chase Southwood
---
2: s626_i2c_handshake_eoc() can be used in s626_initialize() as noted by
Ian. So, s626_initialize_eoc() has been removed, and its uses swapped
for s626_i2c_handshake_eoc().
3: *Type
>On Thursday, April 3, 2014 3:38 AM, Dan Carpenter
>wrote:
>>On Tue, Mar 25, 2014 at 10:43:58PM -0500, Chase Southwood wrote:
>>There were just a handful of more while loops in this file that needed
>>timeouts, and this patch takes care of them. One new callback
On Thursday, April 3, 2014 3:38 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Tue, Mar 25, 2014 at 10:43:58PM -0500, Chase Southwood wrote:
There were just a handful of more while loops in this file that needed
timeouts, and this patch takes care of them. One new callback is
introduced
that a negative error code from comedi_timeout() can be propagated
if necessary.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: s626_i2c_handshake_eoc() can be used in s626_initialize() as noted by
Ian. So, s626_initialize_eoc() has been removed, and its uses swapped
There were just a handful of more while loops in this file that needed
timeouts, and this patch takes care of them. One new callback is
introduced, and all of the proper comedi_timeout() calls are then used.
Signed-off-by: Chase Southwood
---
2: s626_i2c_handshake_eoc() can be used
Ian,
>On Tuesday, March 25, 2014 7:13 AM, Ian Abbott wrote:
>>On 2014-03-25 05:09, Chase Southwood wrote:
>>There were just a handful of more while loops in this file that need timeouts,
>>and this patch takes care of them, using comedi_timeout(). A couple of new
>&
Ian,
On Tuesday, March 25, 2014 7:13 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-03-25 05:09, Chase Southwood wrote:
There were just a handful of more while loops in this file that need timeouts,
and this patch takes care of them, using comedi_timeout(). A couple of new
callbacks
There were just a handful of more while loops in this file that needed
timeouts, and this patch takes care of them. One new callback is
introduced, and all of the proper comedi_timeout() calls are then used.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: s626_i2c_handshake_eoc
that.
Signed-off-by: Chase Southwood
---
drivers/staging/comedi/drivers/s626.c | 66 ++-
1 file changed, 58 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s626.c
b/drivers/staging/comedi/drivers/s626.c
index 95fadf3..4dc5659 100644
that.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
drivers/staging/comedi/drivers/s626.c | 66 ++-
1 file changed, 58 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s626.c
b/drivers/staging/comedi/drivers/s626.c
index
>On Saturday, March 15, 2014 1:55 AM, Levente Kurusa wrote:
>>On 03/15/2014 04:30 AM, Chase Southwood wrote:
>>> On Friday, March 14, 2014 11:47 AM, Levente Kurusa wrote:
>>>
>>>Call kfree() on bdev. The variable is otherwise leaked.
>On Saturday, March 15, 2014 12:26 AM, "gre...@linuxfoundation.org"
> wrote:
>>On Fri, Mar 14, 2014 at 06:43:37PM -0700, Chase Southwood wrote:
>>>On Tuesday, March 11, 2014 9:26 AM, Ian Abbott wrote:
>>>>On 2014-03-09 04:00, Chase Southwood wrote:
On Saturday, March 15, 2014 12:26 AM, gre...@linuxfoundation.org
gre...@linuxfoundation.org wrote:
On Fri, Mar 14, 2014 at 06:43:37PM -0700, Chase Southwood wrote:
On Tuesday, March 11, 2014 9:26 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-03-09 04:00, Chase Southwood wrote:
This patch
On Saturday, March 15, 2014 1:55 AM, Levente Kurusa le...@linux.com wrote:
On 03/15/2014 04:30 AM, Chase Southwood wrote:
On Friday, March 14, 2014 11:47 AM, Levente Kurusa le...@linux.com wrote:
Call kfree() on bdev. The variable is otherwise leaked.
Signed-off-by: Levente Kurusa le
>On Friday, March 14, 2014 11:47 AM, Levente Kurusa wrote:
>Call kfree() on bdev. The variable is otherwise leaked.
>
>Signed-off-by: Levente Kurusa
>---
>drivers/staging/comedi/drivers/comedi_bond.c | 1 +
>1 file changed, 1 insertion(+)
>
>diff --git
>On Tuesday, March 11, 2014 9:26 AM, Ian Abbott wrote:
>>On 2014-03-09 04:00, Chase Southwood wrote:
>> This patch changes a handful of while loops to timeouts to prevent
>> infinite looping on hardware failure. A couple such loops are in a
>> function (s626_debi_trans
On Tuesday, March 11, 2014 9:26 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-03-09 04:00, Chase Southwood wrote:
This patch changes a handful of while loops to timeouts to prevent
infinite looping on hardware failure. A couple such loops are in a
function (s626_debi_transfer()) which
On Friday, March 14, 2014 11:47 AM, Levente Kurusa le...@linux.com wrote:
Call kfree() on bdev. The variable is otherwise leaked.
Signed-off-by: Levente Kurusa le...@linux.com
---
drivers/staging/comedi/drivers/comedi_bond.c | 1 +
1 file changed, 1 insertion(+)
diff --git
-by: Chase Southwood
---
Despite apply testing all of the patches in my series which cleaned
up all of these defines, and triple checking my tab space settings to
ensure they were correct, somehow after the set was merged, the
indentation STILL ended up messy. This patch takes care of that
as well
of the different conditions tested in while loops
in s626_send_dac(). The proper comedi_timeout() calls are then used.
Signed-off-by: Chase Southwood
---
Ian, here is a version of this patchset employing the enum you recommended.
The second patch has been rebased on top of this one.
2: Used comedi_timeout
Hi Greg,
>On Saturday, March 8, 2014 9:00 PM, Greg KH wrote:
>>On Fri, Mar 07, 2014 at 07:43:04PM -0600, Chase Southwood wrote:
>>This patch changes a handful of while loops to timeouts to prevent
>>infinite looping on hardware failure. A couple such loop
Hi Greg,
On Saturday, March 8, 2014 9:00 PM, Greg KH gre...@linuxfoundation.org wrote:
On Fri, Mar 07, 2014 at 07:43:04PM -0600, Chase Southwood wrote:
This patch changes a handful of while loops to timeouts to prevent
infinite looping on hardware failure. A couple such loops are in a
function
of the different conditions tested in while loops
in s626_send_dac(). The proper comedi_timeout() calls are then used.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
Ian, here is a version of this patchset employing the enum you recommended.
The second patch has been rebased on top of this one.
2
-by: Chase Southwood chase.southw...@yahoo.com
---
Despite apply testing all of the patches in my series which cleaned
up all of these defines, and triple checking my tab space settings to
ensure they were correct, somehow after the set was merged, the
indentation STILL ended up messy. This patch takes care
This patch for s626.c propagates the errors from the newly introduced
calls to comedi_timeout() as far as possible.
Signed-off-by: Chase Southwood
---
Compile tested.
2: This patch was introduced in v2 of this set.
3: Rebased on top of PATCH 1/2 edits.
drivers/staging/comedi/drivers/s626.c
of the different conditions tested in while loops
in s626_send_dac(). The proper comedi_timeout() calls are then used.
Signed-off-by: Chase Southwood
---
Ian, here is a version of this patchset employing the enum you recommended.
The second patch has been rebased on top of this one.
2: Used comedi_timeout
This patch fixes the register map defines for the counter registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood
---
2: Simplified commit message, fixed indentation and whitespace damage
This patch for fixes the register map defines for the watchdog registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Signed-off-by: Chase Southwood
---
2: Simplified commit message, fixed indentation and whitespace
This patch for fixes the register map defines for the timer registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood
---
2: Simplified commit message, fixed indentation and whitespace damage
. Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood
---
2: Simplified commit message, fixed indentation and whitespace damage.
I have test applied this patch, it should work now.
3: Fixed indentation (again)
.../comedi
swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood
---
2: Simplified commit message, fixed indentation.
3: Fixed indentation (again)
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 78 +-
1 file
>On Friday, March 7, 2014 11:38 AM, Hartley Sweeten
> wrote:
>>On Friday, March 07, 2014 1:38 AM, Chase Southwood wrote:
>>This patch fixes the register map defines for the counter registers such
>>that they are all the real offsets to each register, rather than
This patch for fixes the register map defines for the timer registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood
---
2: Simplified commit message, fixed indentation and whitespace damage
This patch fixes the register map defines for the counter registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood
---
2: Simplified commit message, fixed indentation and whitespace damage
. Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood
---
2: Simplified commit message, fixed indentation and whitespace damage.
I have test applied this patch, it should work now.
.../comedi/drivers/addi-data
swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood
---
2: Simplified commit message, fixed indentation.
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 78 +-
1 file changed, 31 insertions(+), 47
This patch for fixes the register map defines for the watchdog registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Signed-off-by: Chase Southwood
---
2: Simplified commit message, fixed indentation and whitespace
>On Thursday, March 6, 2014 11:59 AM, Hartley Sweeten
> wrote:
>>On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
>>
>>This patch for hwdrv_apci1564.c fixes the register map defines for the
>>digital input registers such that they are all the real offs
On Thursday, March 6, 2014 11:59 AM, Hartley Sweeten
hartl...@visionengravers.com wrote:
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
digital input registers such that they are all the real offsets to each
This patch for fixes the register map defines for the watchdog registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed indentation.
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 78 +-
1 file
. Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed indentation and whitespace damage.
I have test applied this patch, it should work now.
.../comedi
This patch for fixes the register map defines for the timer registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
This patch fixes the register map defines for the counter registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
On Friday, March 7, 2014 11:38 AM, Hartley Sweeten
hartl...@visionengravers.com wrote:
On Friday, March 07, 2014 1:38 AM, Chase Southwood wrote:
This patch fixes the register map defines for the counter registers such
that they are all the real offsets to each register, rather than a mix of
real
swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed indentation.
3: Fixed indentation (again)
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 78
This patch for fixes the register map defines for the watchdog registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
This patch for fixes the register map defines for the timer registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
This patch fixes the register map defines for the counter registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
. Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed indentation and whitespace damage.
I have test applied this patch, it should work now.
3: Fixed
This patch for s626.c propagates the errors from the newly introduced
calls to comedi_timeout() as far as possible.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
Compile tested.
2: This patch was introduced in v2 of this set.
3: Rebased on top of PATCH 1/2 edits.
drivers
of the different conditions tested in while loops
in s626_send_dac(). The proper comedi_timeout() calls are then used.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
Ian, here is a version of this patchset employing the enum you recommended.
The second patch has been rebased on top of this one.
2
>On Wednesday, March 5, 2014 6:10 AM, Ian Abbott wrote:
>>On 2014-03-04 08:43, Chase Southwood wrote:
>>This patch changes a handful of while loops to timeouts to prevent
>>infinite looping on hardware failure. A couple such loops are in a
>>function (s626_debi_trans
On Wednesday, March 5, 2014 6:10 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-03-04 08:43, Chase Southwood wrote:
This patch changes a handful of while loops to timeouts to prevent
infinite looping on hardware failure. A couple such loops are in a
function (s626_debi_transfer()) which
in excess of 80 characters.
Signed-off-by: Chase Southwood
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 48 --
1 file changed, 18 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
b/drivers/staging/comedi/drivers/addi
of 80 characters.
Signed-off-by: Chase Southwood
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 82 +-
1 file changed, 33 insertions(+), 49 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
b/drivers/staging/comedi/drivers/addi
This patch for hwdrv_apci1564.c fixes the register map defines for the
digital input registers such that they are all the real offsets to each
register, rather than a mix of real offsets and adders to those offsets.
Signed-off-by: Chase Southwood
---
.../comedi/drivers/addi-data/hwdrv_apci1564
in excess of 80 characters.
Further, some of the old defines were being used incorrectly in the
i_APCI1564_Reset() function. Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood
---
.../comedi/drivers/addi-data
in excess of 80 characters.
Further, some of the old defines were being used incorrectly in the
i_APCI1564_Reset() function. Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood
---
Greg, as promised, this is the most
in excess of 80 characters.
Further, some of the old defines were being used incorrectly in the
i_APCI1564_Reset() function. Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
Greg
in excess of 80 characters.
Further, some of the old defines were being used incorrectly in the
i_APCI1564_Reset() function. Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
.../comedi
of 80 characters.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 82 +-
1 file changed, 33 insertions(+), 49 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
b/drivers
This patch for hwdrv_apci1564.c fixes the register map defines for the
digital input registers such that they are all the real offsets to each
register, rather than a mix of real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
.../comedi/drivers
in excess of 80 characters.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 48 --
1 file changed, 18 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
b/drivers
>On Tuesday, March 4, 2014 6:38 PM, Greg KH wrote:
>>On Mon, Mar 03, 2014 at 12:27:55PM +0300, Dan Carpenter wrote:
>>> On Sun, Mar 02, 2014 at 08:52:19PM -0600, Chase Southwood wrote:
>>> This patch introduces a few simple outl and inl helper functions to allow
>
This patch for s626.c propagates the errors from the newly introduced
calls to comedi_timeout() as far as possible.
Signed-off-by: Chase Southwood
---
Compile tested only.
drivers/staging/comedi/drivers/s626.c | 63 +--
1 file changed, 45 insertions(+), 18
from, as this information is enough to
recreate the entire readl() call, and is passed in the 'context'
parameter. A couple of additional macros have been defined where this
method is not completely sufficient. The proper comedi_timeout() calls
are then used.
Signed-off-by: Chase Southwood
from, as this information is enough to
recreate the entire readl() call, and is passed in the 'context'
parameter. A couple of additional macros have been defined where this
method is not completely sufficient. The proper comedi_timeout() calls
are then used.
Signed-off-by: Chase Southwood
This patch for s626.c propagates the errors from the newly introduced
calls to comedi_timeout() as far as possible.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
Compile tested only.
drivers/staging/comedi/drivers/s626.c | 63 +--
1 file changed
On Tuesday, March 4, 2014 6:38 PM, Greg KH gre...@linuxfoundation.org wrote:
On Mon, Mar 03, 2014 at 12:27:55PM +0300, Dan Carpenter wrote:
On Sun, Mar 02, 2014 at 08:52:19PM -0600, Chase Southwood wrote:
This patch introduces a few simple outl and inl helper functions to allow
several lines
>On Monday, March 3, 2014 8:13 AM, Ian Abbott wrote:
>>On 2014-03-02 04:13, Chase Southwood wrote:
>>>On Friday, February 28, 2014 11:49 PM, Chase Southwood
>>> wrote:
>>>> On Friday, February 28, 2014 11:26 AM, Ian Abbott
>>>> wrot
On Monday, March 3, 2014 8:13 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-03-02 04:13, Chase Southwood wrote:
On Friday, February 28, 2014 11:49 PM, Chase Southwood
chase.southw...@yahoo.com wrote:
On Friday, February 28, 2014 11:26 AM, Ian Abbott abbo...@mev.co.uk
wrote:
On 2014-02-28
plus the offset. This is to simplify the use of these macros
in the new helper functions.
Cc: Dan Carpenter
Signed-off-by: Chase Southwood
---
All right, here's another shot at this. Dan, I took your outl_amcc idea
and did a version for the outl/inl calls based from devpriv->iobase as well
Use the newly created helper functions to improve code readability and shorten
several lines to under the character limit.
Cc: Dan Carpenter
Signed-off-by: Chase Southwood
---
I've reviewed this as best as I can, but I know it's a bear to review.
If there is some logical way that you'd like me
Use the newly created helper functions to improve code readability and shorten
several lines to under the character limit.
Cc: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
I've reviewed this as best as I can, but I know it's a bear to review
plus the offset. This is to simplify the use of these macros
in the new helper functions.
Cc: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
All right, here's another shot at this. Dan, I took your outl_amcc idea
and did a version for the outl
>On Friday, February 28, 2014 11:49 PM, Chase Southwood
> wrote:
>>On Friday, February 28, 2014 11:26 AM, Ian Abbott wrote:
>>>On 2014-02-28 07:35, Chase Southwood wrote:
[snip]
>>In the case of s626_send_dac(), it doesn't seem to be used in any
>>critic
>On Saturday, March 1, 2014 6:18 PM, Chase Southwood
> wrote:
>Hi Dan,
>
[snip]
>
>I like this idea. Just to clarify though, basically all of the macros would
>change to something like
>
>#define APCI1564_DIGITAL_IP 0x4 #define APCI1564_DIGITAL_IP_INTERRUPT_M
Hi Dan,
>On Saturday, March 1, 2014 6:46 AM, Dan Carpenter
>wrote:
>>On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote:
>> This patch introduces a handful of outl and inl helper functions with the
>> ultimate goal of improving code readability and allowin
We can use these inl and outl helper functions to improve code
readability and shorten several lines to under the character limit.
Cc: Dan Carpenter
Signed-off-by: Chase Southwood
---
I checked over this all several times so I hope it is correct. I welcome
feedback on anything here
Thanks
This patch introduces a handful of outl and inl helper functions with the
ultimate goal of improving code readability and allowing several lines
which violate the character limit to be shortened in a sane way.
Cc: Dan Carpenter
Signed-off-by: Chase Southwood
---
This patchset serves
We can use these inl and outl helper functions to improve code
readability and shorten several lines to under the character limit.
Cc: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
I checked over this all several times so I hope it is correct
This patch introduces a handful of outl and inl helper functions with the
ultimate goal of improving code readability and allowing several lines
which violate the character limit to be shortened in a sane way.
Cc: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Chase Southwood chase.southw
Hi Dan,
On Saturday, March 1, 2014 6:46 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote:
This patch introduces a handful of outl and inl helper functions with the
ultimate goal of improving code readability and allowing several
201 - 300 of 412 matches
Mail list logo
