Re: [PATCH 1/2][RFC] x86/boot/e820: Introduce e820_table_ori to represent the real original e820 layout

2017-07-02 Thread Chen Yu
On Fri, Jun 23, 2017 at 10:42:10AM +0200, Ingo Molnar wrote: > > * Chen Yu wrote: > > > Hi Ingo, > > On Thu, Jun 22, 2017 at 11:40:30AM +0200, Ingo Molnar wrote: > > > > > > * Chen Yu wrote: > > > > > > > Currently we try to have e8

Re: [PATCH] PCI: Work around poweroff & suspend-to-RAM issue on Macbook Pro 11

2017-07-02 Thread Chen Yu
zilla.kernel.org/show_bug.cgi?id=103211 > Tested-by: the...@gmail.com > Signed-off-by: Bjorn Helgaas > Cc: sta...@vger.kernel.org > Cc: Rafael J. Wysocki > Cc: Lukas Wunner > Cc: Chen Yu > > diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c > index 6d52b9

Re: [PATCH][RFC] x86: Fix the irq affinity in fixup_cpus

2017-07-03 Thread Chen Yu
On Sun, Jun 04, 2017 at 10:04:53PM +0200, Thomas Gleixner wrote: > On Mon, 24 Apr 2017, Chen Yu wrote: > > > fixup_cpus() is to set appropriate irq affinity once the CPU > > has been brought down, however we should also adjust the > > desc->irq_common_data.aff

Re: [PATCH] PCI / PM: Restore the status of PCI devices across hibernation

2017-06-01 Thread Chen Yu
On Fri, Jun 02, 2017 at 01:22:28AM +0200, Rafael J. Wysocki wrote: > On Thu, May 25, 2017 at 10:49 AM, Chen Yu wrote: > > Currently we saw a lot of "No irq handler" errors during hibernation, > > which caused the system hang finally: > > > > [ 710.

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Chen Yu
On 2017/11/6 22:00, Mathias Nyman wrote: > On 06.11.2017 14:36, Chen Yu wrote: >> >> >> On 2017/11/6 19:32, Greg KH wrote: >>>> A simple process is as below: >>>> xhci_plat_probe() >>>> | &

[RFC][PATCH] cpufreq: intel_pstate: Delete intel_pstate sysfs if failed to register the driver

2020-10-08 Thread Chen Yu
(for example, echo off to status), but the intel_pstate sysfs should not co-exist when acpi-cpufreq is also present. Fix this issue by deleting the intel_pstate sysfs if the driver failed to be loaded during bootup. Reported-by: Wendy Wang Suggested-by: Zhang Rui Signed-off-by: Chen Yu --- drivers

Re: [PATCH v3 5/5] platform/surface: Move Surface Pro 3 Button driver to platform/surface

2020-10-08 Thread Chen Yu
On Thu, Oct 08, 2020 at 04:34:55PM +0200, Maximilian Luz wrote: > Move the Surface Pro 3 Button driver from platform/x86 to the newly > created platform/surface directory. > > Signed-off-by: Maximilian Luz > Acked-by: Chen Yu Thanks! best, Chenyu

[PATCH][RFC] tools/power turbostat: Fix ACPI CState format issue

2020-10-12 Thread Chen Yu
0.60 Reported-by: Zhang Rui Signed-off-by: Chen Yu --- tools/power/x86/turbostat/turbostat.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c index 33b370865d16

[PATCH] xhci: Introduce max wait timeout in xhci_handshake()

2020-12-15 Thread Chen Yu
for at max 16 ms. Reported-by: "Muchowski, MaciejX" Signed-off-by: Chen Yu --- drivers/usb/host/xhci.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index d4a8d0efbbc4..b8be9f3cc987 100644 --- a/drivers/usb/host/xh

Re: [PATCH] xhci: Introduce max wait timeout in xhci_handshake()

2020-12-15 Thread Chen Yu
Hi Greg, thanks for taking a look at this. On Tue, Dec 15, 2020 at 02:39:14PM +0100, Greg KH wrote: > On Tue, Dec 15, 2020 at 09:22:40PM +0800, Chen Yu wrote: > > The time to finish a xhci_handshake() is platform specific > > and sometimes during suspend resume test the followng

Re: [PATCH][v2] PM / sysfs: Expose suspend resume driver flags in sysfs

2020-10-22 Thread Chen Yu
Hi Greg, On Thu, Oct 22, 2020 at 11:17:07AM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 22, 2020 at 04:52:44PM +0800, Chen Yu wrote: > > Currently there are 4 driver flags to control system suspend/resume > > behavior: DPM_FLAG_NO_DIRECT_COMPLETE, DPM_FLA

Re: [PATCH][v2] PM / sysfs: Expose suspend resume driver flags in sysfs

2020-10-22 Thread Chen Yu
Hi Andy, On Thu, Oct 22, 2020 at 04:36:25PM +0300, Andy Shevchenko wrote: > On Thu, Oct 22, 2020 at 12:24 PM Chen Yu wrote: > > > > Currently there are 4 driver flags to control system suspend/resume > > behavior: DPM_FLAG_NO_DIRECT_COMPLETE, DPM_FLAG_SMART_PREPARE, >

[PATCH] PM / suspend: Print the driver flags of device during suspend resume

2020-10-23 Thread Chen Yu
, and to facilitate suspend/resume debugging/tuning. To enable this tracing: echo 'file drivers/base/power/main.c +p' > /sys/kernel/debug/dynamic_debug/control Signed-off-by: Chen Yu --- drivers/base/power/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

Re: [PATCH v2] sched/fair: check for idle core

2020-10-23 Thread Chen Yu
On Fri, Oct 23, 2020 at 1:32 AM Julia Lawall wrote: > [cut] > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index aa4c6227cd6d..9b23dad883ee 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5804,6 +5804,9 @@ wake_affine_idle(int this_cpu, int prev_cpu, int sync) >

[PATCH] intel_idle: Fix max_cstate for processor models without C-state tables

2020-10-24 Thread Chen Yu
essor models without C-state tables") Reported-by: Pengfei Xu Cc: 5.6+ # 5.6+ Signed-off-by: Chen Yu --- drivers/idle/intel_idle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index 9a810e4a7946..dbd4be1c271b 100644 ---

Re: bootconfig length parse error in kernel

2020-11-11 Thread Chen Yu
Hi Masami, On Wed, Nov 11, 2020 at 5:37 PM Masami Hiramatsu wrote: > > Hi Chen, > > On Tue, 10 Nov 2020 23:39:53 +0800 > Chen Yu wrote: > > > Hi Masami, > > Thanks for writing bootconfig and it is useful for boot up trace event > > debugging. > > Than

Re: bootconfig length parse error in kernel

2020-11-11 Thread Chen Yu
On Thu, Nov 12, 2020 at 1:50 PM Masami Hiramatsu wrote: > > Hi Chen, > > On Thu, 12 Nov 2020 12:34:36 +0800 > Chen Yu wrote: > > > Hi Masami, > > > > On Wed, Nov 11, 2020 at 5:37 PM Masami Hiramatsu > > wrote: > > > > > > Hi Chen,

Re: bootconfig length parse error in kernel

2020-11-12 Thread Chen Yu
On Thu, Nov 12, 2020 at 11:36 PM Masami Hiramatsu wrote: > > On Thu, 12 Nov 2020 14:49:16 +0800 > Chen Yu wrote: > > > On Thu, Nov 12, 2020 at 1:50 PM Masami Hiramatsu > > wrote: > > > > > > Hi Chen, > > > > > > On Thu, 12 Nov 2020

Re: [PATCH] bootconfig: Extend the magic check range to the preceding 3 bytes

2020-11-12 Thread Chen Yu
; bootconfig explicitly") > Reported-by: Chen Yu > Signed-off-by: Masami Hiramatsu > --- Works for me, thanks! Tested-by: Chen Yu Best, Chenyu

Re: [PATCH][RFC] x86/microcode/intel: check cpu stepping and processor flag before saving microcode

2020-11-12 Thread Chen Yu
Nov 10, 2020 at 09:52:47PM +0800, Chen Yu wrote: > > Currently scan_microcode() leverages microcode_matches() to check if the > > microcode matches the CPU by comparing the family and model. However before > > saving the microcode in scan_microcode(), the processor stepping and fl

[PATCH][v2] x86/microcode/intel: check cpu stepping and processor flag before saving microcode

2020-11-12 Thread Chen Yu
loading") Cc: sta...@vger.kernel.org#v4.10+ Reviewed-by: Ashok Raj Signed-off-by: Chen Yu --- v2: Remove RFC tag and Cc the stable mailing list. --- arch/x86/kernel/cpu/microcode/intel.c | 50 ++- 1 file changed, 2 insertions(+), 48 deletions(-) diff --git a/arch/x

[PATCH] PM / sysfs: Expose suspend resume driver flags in sysfs

2020-10-21 Thread Chen Yu
-by: Len Brown Signed-off-by: Chen Yu --- drivers/base/power/sysfs.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/sysfs.c b/drivers/base/power/sysfs.c index a1474fb67db9..48313a1040a5 100644 --- a/drivers/base/power/sysfs.c +++ b

Re: [PATCH] PM / sysfs: Expose suspend resume driver flags in sysfs

2020-10-21 Thread Chen Yu
Hi Greg, thanks for taking a look at this. On Thu, Oct 22, 2020 at 07:31:43AM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 22, 2020 at 11:23:24AM +0800, Chen Yu wrote: > > Currently there are 4 driver flags to control system suspend/resume > > behavior: DPM_FLAG_NO_

[PATCH][v2] PM / sysfs: Expose suspend resume driver flags in sysfs

2020-10-22 Thread Chen Yu
-by: Len Brown Signed-off-by: Chen Yu --- v2: Adding description in Documentation/ABI/testing/sysfs-devices-power according to Greg's suggestion. -- Documentation/ABI/testing/sysfs-devices-power | 11 +++ drivers/base/power/sysfs.c| 29 ++- 2 files changed

[PATCH][RFC] x86/microcode/intel: check cpu stepping and processor flag before saving microcode

2020-11-10 Thread Chen Yu
icrocode loading") Suggested-by: "Raj, Ashok" Cc: Borislav Petkov Cc: Len Brown Cc: "Rafael J. Wysocki" Cc: "Raj, Ashok" Cc: Tony Luck Signed-off-by: Chen Yu -- arch/x86/kernel/cpu/microcode/intel.c | 50 ++- 1 file changed, 2 insertions

bootconfig length parse error in kernel

2020-11-10 Thread Chen Yu
Hi Masami, Thanks for writing bootconfig and it is useful for boot up trace event debugging. However it was found that on 5.10-rc2 the bootconfig does not work and it shows "'bootconfig' found on command line, but no bootconfig found" And the reason for this is the kernel found the magic number to

[PATCH 1/4][RFC] e1000e: save the return value of e1000e_reset()

2020-11-10 Thread Chen Yu
(), except that the former returns the result of this reset. No functional change expected. Signed-off-by: Chen Yu --- drivers/net/ethernet/intel/e1000e/netdev.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net

[PATCH 0/4][RFC] Disable e1000e power management if hardware error is detected

2020-11-10 Thread Chen Yu
bring potential issue in race condition. 3. Approach 2 is a clean solution and it is platform independent that, not only e1000e, but also other drivers could leverage this generic mechanism in the future. Comments appreciated. Chen Yu (4): e1000e: save the return value of e1000e_reset

[PATCH 3/4][RFC] e1000e: Introduce workqueue to disable the power management

2020-11-10 Thread Chen Yu
Introduce a workqueue to disable the power management of this device. It is supposed to be triggered when e1000e hardware error is detected during resume from S3. Signed-off-by: Chen Yu --- drivers/net/ethernet/intel/e1000e/e1000.h | 1 + drivers/net/ethernet/intel/e1000e/netdev.c | 12

[PATCH 2/4][RFC] PM: sleep: export device_pm_remove() for driver use

2020-11-10 Thread Chen Yu
Export device_pm_remove() and move the declaration of device_pm_remove() into generic power header file so that the drivers could use this interface to disable power management on that device. Signed-off-by: Chen Yu --- drivers/base/power/main.c | 1 + drivers/base/power/power.h | 8

[PATCH 4/4][RFC] e1000e: Disable the power management if hardware error detected during resume

2020-11-10 Thread Chen Yu
will not be considered during suspend/resume, thus not to prevent the system from suspend/resume. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=205015 Reported-by: "Brandt, Todd E" Reported-by: Len Brown Signed-off-by: Chen Yu --- drivers/net/ethernet/intel/e1000e/netdev.c | 3 ++- 1 fi

Re: [PATCH][v2] x86/microcode/intel: check cpu stepping and processor flag before saving microcode

2020-11-16 Thread Chen Yu
Hi Boris, thanks for taking a look, On Mon, Nov 16, 2020 at 01:27:35PM +0100, Borislav Petkov wrote: > ( drop stable@ from Cc because this is not how fixes get added to stable@ ) > > On Fri, Nov 13, 2020 at 09:59:23AM +0800, Chen Yu wrote: > > Currently scan_microc

Re: [PATCH][v2] x86/microcode/intel: check cpu stepping and processor flag before saving microcode

2020-11-17 Thread Chen Yu
On Tue, Nov 17, 2020 at 10:18:37AM +0100, Borislav Petkov wrote: > On Tue, Nov 17, 2020 at 10:25:18AM +0800, Chen Yu wrote: > > If I understand correctly, the only place that invokes > > save_mc_for_early() is in generic_load_microcode(). While in > > generic_load_microcode

Re: [PATCH v3 1/3] tools/bootconfig: Fix to check the write failure correctly

2020-11-17 Thread Chen Yu
tconfig: Add bootconfig magic word for indicating > bootconfig explicitly") > Suggested-by: Linus Torvalds > Signed-off-by: Masami Hiramatsu For [1/3] and [2/3] Tested-by: Chen Yu -- Thanks, Chenyu

Re: [PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-30 Thread Chen Yu
On Fri, Nov 27, 2020 at 08:20:17PM +0800, Kai-Heng Feng wrote: > Thanks for the confirmation. How about a different approach? > Simply use direct-complete to let PM core handle the rest: > Thanks for your suggestion and sorry about replying too late. Yes, using direct-complete could leverage pm

[PATCH 0/2][v3] Put the NIC in runtime suspended during s2ram

2020-11-30 Thread Chen Yu
to manipulate S0ix settings during suspend. Chen Yu (2): e1000e: Leverage direct_complete to speed up s2ram e1000e: Remove the runtime suspend restriction on CNP+ drivers/net/ethernet/intel/e1000e/netdev.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) -- 2.17.1

[PATCH 2/2][v3] e1000e: Remove the runtime suspend restriction on CNP+

2020-11-30 Thread Chen Yu
uld support runtime suspend, disabling the runtime suspend on them by default would impact the validation. Only disable runtime suspend on CNP in case of any user space regression. Signed-off-by: Chen Yu --- drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 1/2][v3] e1000e: Leverage direct_complete to speed up s2ram

2020-11-30 Thread Chen Yu
ted-by: Kai-Heng Feng Signed-off-by: Chen Yu --- v2: Added test data and some commit log revise(Paul Menzel) Only skip the suspend/resume if the NIC is not a wake up device specified by the user(Kai-Heng Feng) v3: Leverage direct complete mechanism to skip all hooks(Kai-Heng Feng) --- driv

[PATCH] tools/power turbostat: Support Ice Lake D

2020-11-23 Thread Chen Yu
Ice Lake D is low-end server version of Ice Lake X, reuse the code accordingly. Tested-by: Wendy Wang Signed-off-by: Chen Yu --- tools/power/x86/turbostat/turbostat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat

Re: [PATCH 1/2][v3] e1000e: Leverage direct_complete to speed up s2ram

2020-12-02 Thread Chen Yu
Hi Kai-Heng, On Wed, Dec 02, 2020 at 09:06:19PM +0800, Kai-Heng Feng wrote: > > --- > > v2: Added test data and some commit log revise(Paul Menzel) > >Only skip the suspend/resume if the NIC is not a wake up device specified > >by the user(Kai-Heng Feng) > > v3: Leverage direct complete

Re: [PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-26 Thread Chen Yu
On Thu, Nov 26, 2020 at 02:36:42PM +0800, Kai-Heng Feng wrote: > >> > >> What about plugging ethernet cable and using WoL after system is suspended? > >> Commit "e1000e: Exclude device from suspend direct complete optimization" > >> was to address that scenario. [cut] > > I don't think this is

Re: [PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-26 Thread Chen Yu
On Thu, Nov 26, 2020 at 08:05:02PM +0800, Kai-Heng Feng wrote: > > > > On Nov 26, 2020, at 19:10, Chen Yu wrote: > > > > On Thu, Nov 26, 2020 at 02:36:42PM +0800, Kai-Heng Feng wrote: > >>>> > >>>> What about plugging ethernet

[PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-24 Thread Chen Yu
() and dev_pm_skip_resume() return true, so as to speed up the s2ram. Signed-off-by: Chen Yu --- drivers/base/power/main.c | 2 ++ drivers/net/ethernet/intel/e1000e/netdev.c | 14 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/main.c b

Re: [Intel-wired-lan] [PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-25 Thread Chen Yu
Hi Paul, On Tue, Nov 24, 2020 at 04:47:30PM +0100, Paul Menzel wrote: > Dear Chen, > > > Thank you for the patch. > Thanks for reviewing this change. > Am 24.11.20 um 16:32 schrieb Chen Yu: > > The NIC is put in runtime suspend status when there is no wire connected. >

Re: [PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-25 Thread Chen Yu
Hi Kai-Heng, On Wed, Nov 25, 2020 at 01:17:28AM +0800, Kai-Heng Feng wrote: > Hi Yu, > > > On Nov 24, 2020, at 23:32, Chen Yu wrote: > > > > The NIC is put in runtime suspend status when there is no wire connected. > > As a result, it is safe to keep this NIC in

Re: [PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-25 Thread Chen Yu
On Thu, Nov 26, 2020 at 02:36:42PM +0800, Kai-Heng Feng wrote: > > > > On Nov 25, 2020, at 18:36, Chen Yu wrote: > > > > Hi Kai-Heng, > > On Wed, Nov 25, 2020 at 01:17:28AM +0800, Kai-Heng Feng wrote: > >> Hi Yu, > >> > >>> On

[PATCH] Introducing the mask_cstate to disable specific c-states during bootup

2019-07-30 Thread Chen Yu
ox Cc: "Tan, Raymond" Signed-off-by: Chen Yu --- .../admin-guide/kernel-parameters.txt | 7 drivers/idle/intel_idle.c | 36 +++ 2 files changed, 43 insertions(+) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documenta

Re: [PATCH][RFC] ACPI: processor: Print more information when acpi_processor_evaluate_cst() failed

2020-08-18 Thread Chen Yu
On Tue, Aug 18, 2020 at 12:46:12PM +0200, Rafael J. Wysocki wrote: > On Sun, Aug 16, 2020 at 5:12 PM Chen Yu wrote: > > > > Some platforms have bogus _CST which might cause expectd behavior > > in the cpu idle driver. Some bogus _CST might be unable to be > > disas

[PATCH][v2] ACPI: processor: Print more information when acpi_processor_evaluate_cst() failed

2020-08-18 Thread Chen Yu
idle driver fails to behave as expected. Suggested-by: Zhang Rui Signed-off-by: Chen Yu --- v2: According to Rafael's suggestion, change the log level from "warn" to "info" --- drivers/acpi/acpi_processor.c | 34 -- 1 file changed, 28 insert

[PATCH][RFC] ACPI: processor: Print more information when acpi_processor_evaluate_cst() failed

2020-08-16 Thread Chen Yu
idle driver fails to behave as expected. Suggested-by: Zhang Rui Signed-off-by: Chen Yu --- drivers/acpi/acpi_processor.c | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index

[PATCH] tools/power turbostat: Support Sapphire Rapids

2020-08-17 Thread Chen Yu
Enumerate Saphire Rapids. Treat it like Sky Lake and Ice Lake server in turbostat. Signed-off-by: Chen Yu --- tools/power/x86/turbostat/turbostat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c index

Re: [RFC][PATCH] cpufreq: intel_pstate: Delete intel_pstate sysfs if failed to register the driver

2020-10-13 Thread Chen Yu
Hi Srinivas, On Mon, Oct 12, 2020 at 06:22:40AM -0700, srinivas pandruvada wrote: > On Fri, 2020-10-09 at 11:30 +0800, Chen Yu wrote: > > There is a corner case that if the intel_pstate driver failed to be > > registered(might be due to invalid MSR access) > Do you have logs wh

[PATCH 1/2] tools/power turbostat: Support Alder Lake P

2021-02-03 Thread Chen Yu
Share the code between Alder Lake P and Alder Lake S. Tested-by: Wendy Wang Signed-off-by: Chen Yu --- tools/power/x86/turbostat/turbostat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c index 389ea5209a83

[PATCH 0/2] Add more CPUs support in turbostat

2021-02-03 Thread Chen Yu
Alder Lake P and Ice Lake D are added in this patch set. Chen Yu (2): tools/power turbostat: Support Alder Lake Mobile tools/power turbostat: Support Ice Lake D tools/power/x86/turbostat/turbostat.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1

[PATCH 2/2] tools/power turbostat: Support Ice Lake D

2021-02-03 Thread Chen Yu
Ice Lake D is low-end server version of Ice Lake X, reuse the code accordingly. Tested-by: Wendy Wang Signed-off-by: Chen Yu --- tools/power/x86/turbostat/turbostat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat

Re: [PATCH 2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability

2020-05-23 Thread Chen Yu
Hi Michal, Thanks for reviewing, and sorry for late reply. On Thu, May 21, 2020 at 09:23:42PM +0200, Michal Kubecek wrote: > On Fri, May 22, 2020 at 01:59:13AM +0800, Chen Yu wrote: > > Currently the ethtool shows that WOL(Wake On Lan) is enabled > > even if the device wakeup a

Re: [PATCH 2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability

2020-05-25 Thread Chen Yu
On Sun, May 24, 2020 at 11:06:53PM +0200, Michal Kubecek wrote: > On Sat, May 23, 2020 at 05:09:50PM +0800, Chen Yu wrote: > > Hi Michal, > > Thanks for reviewing, > > and sorry for late reply. > > On Thu, May 21, 2020 at 09:23:42PM +0200, Michal Kubecek wrote: > >

[PATCH 2/2][RFC] PM-runtime: add tracepoints to cover all usage_count changes

2020-06-05 Thread Chen Yu
t_noresume() and pm_runtime_put_noidle() 2. The change of the usage count will not be tracked if decreased from 1 to 0. This patch address above issues by tracking the usage count whenever it has been modified. And these changes has helped track down the e1000e runtime issue. Signed-off-b

[PATCH 1/2][RFC] PM-runtime: Move all runtime usage related function to runtime.c

2020-06-05 Thread Chen Yu
use them. No functional change. Signed-off-by: Chen Yu --- drivers/base/power/runtime.c | 12 include/linux/pm_runtime.h | 14 -- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index

[PATCH 0/2][RFC] Add more trace point for runtime usage count

2020-06-05 Thread Chen Yu
Currentlt some code flow of runtime usage count changes is not covered by the tracepoints. Add corresponding tracepoints to monitor all the usage_count changes. Chen Yu (2): PM-runtime: Move all runtime usage related function to runtime.c PM-runtime: add more tracepoints for usage_count

Re: [PATCH 2/2][RFC] PM-runtime: add tracepoints to cover all usage_count changes

2020-06-06 Thread Chen Yu
Hi, On Fri, Jun 05, 2020 at 09:33:11PM +0200, Michal Miroslaw wrote: > On Sat, Jun 06, 2020 at 03:05:52AM +0800, Chen Yu wrote: > > Commit d229290689ae ("PM-runtime: add tracepoints for usage_count changes") > > has added some tracepoints to monitor th

Re: [PATCH 1/2][RFC] PM-runtime: Move all runtime usage related function to runtime.c

2020-06-06 Thread Chen Yu
On Sat, Jun 06, 2020 at 03:05:35AM +0800, Chen Yu wrote: > In order to track all the runtime usage count change, move the code > related to runtime usage count change from pm_runtime.h to runtime.c, > so that in runtime.c we can leverage trace event to do the tracking. > Mean

Re: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960

2017-10-24 Thread Chen Yu
Hi, Felipe On 2017/10/24 16:25, Felipe Balbi wrote: > Hi, > > Yu Chen writes: >> > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 >> > Controller. >> > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub >> > on board Hikey960. >> > >> >

Re: [PATCH 2/2][v3] PM / s2idle: Code cleanup to make s2idle consistent with normal idle path

2020-06-24 Thread Chen Yu
. However in [1/2 patch], it might exit the s2idle phase directly once when we see TIF_NEED_RESCHED is set(because entered_state is postive we treat it as a successful s2idle). In summary I think the change (patch [2/2]) is more robust. Acked-by: Chen Yu Thanks, Chenyu

[PATCH 1/2][RESEND v3] PM-runtime: Move all runtime usage related function to runtime.c

2020-07-15 Thread Chen Yu
use them. No functional changes intended. Signed-off-by: Chen Yu --- drivers/base/power/runtime.c | 12 include/linux/pm_runtime.h | 12 ++-- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index

[PATCH 0/2][RESEND v3] Extend trace point to cover all runtime usage count

2020-07-15 Thread Chen Yu
Currently some code flow of runtime usage count changes is not covered by the rpm_runtime_usage tracepoints. Adjust corresponding tracepoints to monitor all the runtime usage count changes. Chen Yu (2): PM-runtime: Move all runtime usage related function to runtime.c PM-runtime: change

[PATCH 2/2][RESEND v3] PM-runtime: change the tracepoints to cover all usage_count

2020-07-15 Thread Chen Yu
all usage changes will be shown using rpm_usage even if included by other trace points. And these changes has helped track down the e1000e runtime issue. Reviewed-by: Michał Mirosław Signed-off-by: Chen Yu --- drivers/base/power/runtime.c | 38 +++- 1 file c

Re: [PATCH 2/2][RESEND v3] PM-runtime: change the tracepoints to cover all usage_count

2020-07-15 Thread Chen Yu
Hi Greg, thanks very much for taking a look, On Wed, Jul 15, 2020 at 09:06:14AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 15, 2020 at 02:28:03PM +0800, Chen Yu wrote: > > Commit d229290689ae ("PM-runtime: add tracepoints for usage_count changes") > > has added so

Re: [PATCH 2/2][RESEND v3] PM-runtime: change the tracepoints to cover all usage_count

2020-07-15 Thread Chen Yu
On Wed, Jul 15, 2020 at 10:33:22AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 15, 2020 at 04:18:38PM +0800, Chen Yu wrote: > > Hi Greg, > > thanks very much for taking a look, > > On Wed, Jul 15, 2020 at 09:06:14AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Ju

Re: [PATCH 2/2][RESEND v3] PM-runtime: change the tracepoints to cover all usage_count

2020-07-15 Thread Chen Yu
On Wed, Jul 15, 2020 at 05:47:36PM +0200, Rafael J. Wysocki wrote: > On Wed, Jul 15, 2020 at 8:26 AM Chen Yu wrote: > > > > Commit d229290689ae ("PM-runtime: add tracepoints for usage_count changes") > > has added some tracepoints to monitor the change of runtime us

[PATCH] intel_idle: Customize IceLake server support

2020-07-03 Thread Chen Yu
+C6, rather than PC6+C6 when C6 was measured. Tested-by: Artem Bityutskiy Acked-by: Artem Bityutskiy Signed-off-by: Zhang Rui Signed-off-by: Chen Yu --- drivers/idle/intel_idle.c | 36 1 file changed, 36 insertions(+) diff --git a/drivers/idle/intel_idle.c

Re: [PATCH 0/2][RFC] Makes sd->flags sysctl writable

2020-07-07 Thread Chen Yu
Hi Peter, On Mon, Jul 06, 2020 at 10:00:49PM +0200, Peter Zijlstra wrote: > On Tue, Jul 07, 2020 at 03:36:13AM +0800, Chen Yu wrote: > > It was found that recently the flags of sched domain could > > not be customized via sysctl, which might make it a little > > inconenient f

Re: [PATCH 0/2][RFC] Makes sd->flags sysctl writable

2020-07-07 Thread Chen Yu
Hi Valentin, On Mon, Jul 06, 2020 at 11:11:32PM +0100, Valentin Schneider wrote: > > On 06/07/20 21:00, Peter Zijlstra wrote: > > On Tue, Jul 07, 2020 at 03:36:13AM +0800, Chen Yu wrote: > >> It was found that recently the flags of sched domain could > >> not be cust

[PATCH][v2] intel_idle: Customize IceLake server support

2020-07-09 Thread Chen Yu
in theory. Reported-by: kernel test robot Tested-by: Artem Bityutskiy Acked-by: Artem Bityutskiy Cc: Len Brown Cc: Rafael J. Wysocki Signed-off-by: Zhang Rui Signed-off-by: Chen Yu --- v2: Minor commit message refinement for better understanding. -- drivers/idle/intel_idle.c | 36

[PATCH 0/2][RFC] Makes sd->flags sysctl writable

2020-07-06 Thread Chen Yu
the system easier. Any comment would be appreciated. Chen Yu (2): sched/topology: Add update_domain_cpu() sched/debug: Make sd->flags sysctl writable again include/linux/sched/topology.h | 5 + kernel/sched/debug.c | 30 +++--- kernel/sched/topology.c

[PATCH 2/2][RFC] sched/debug: Make sd->flags sysctl writable again

2020-07-06 Thread Chen Yu
nce the flags has been changed. Signed-off-by: Chen Yu --- kernel/sched/debug.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 36c54265bb2b..bfeaf547d4af 100644 --- a/kernel/sched/debug.c +++ b

[PATCH 1/2][RFC] sched/topology: Add update_domain_cpu()

2020-07-06 Thread Chen Yu
tch is to prepare for the next patch to update the flags of sched domain via sysctl. No intentional functional impact. Signed-off-by: Chen Yu --- include/linux/sched/topology.h | 5 + kernel/sched/topology.c| 11 +++ 2 files changed, 16 insertions(+) diff --git a/include/li

Re: [PATCH][v2] PM / s2idle: Clear _TIF_POLLING_NRFLAG before suspend to idle

2020-06-22 Thread Chen Yu
Hi Rafael, On Mon, Jun 22, 2020 at 06:19:35PM +0200, Rafael J. Wysocki wrote: [cut] > > +{ > > + if (!current_clr_polling_and_test()) > > + s2idle_enter(drv, dev, index); > > + > > + return index; > > Is the value returned here used at all? > It is not used for now IMO.

Re: [PATCH][v2] PM / s2idle: Clear _TIF_POLLING_NRFLAG before suspend to idle

2020-06-22 Thread Chen Yu
On Mon, Jun 22, 2020 at 09:45:35PM +0200, Rafael J. Wysocki wrote: > On Mon, Jun 22, 2020 at 7:16 PM Chen Yu wrote: > > > > Hi Rafael, > > On Mon, Jun 22, 2020 at 06:19:35PM +0200, Rafael J. Wysocki wrote: > > [cut] > > > > +{ > >

Re: [smp] b2a02fc43a: suspend-stress.fail

2020-06-11 Thread Chen Yu
Hi Peter, On Wed, Jun 10, 2020 at 5:52 PM Peter Zijlstra wrote: > > On Wed, Jun 10, 2020 at 04:35:02PM +0800, kernel test robot wrote: > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: b2a02fc43a1f40ef4eb2fb2b06357382608d4d84 ("smp: Optimize > >

[PATCH 0/2] Make WOL of e1000e consistent with sysfs device wakeup

2020-05-21 Thread Chen Yu
Currently the WOL(Wake On Lan) bahavior of e1000e is not consistent with its corresponding device wake up ability. Fix this by: 1. Do not wake up the system via WOL if device wakeup is disabled 2. Make WOL display info from ethtool consistent with device wake up settings in sysfs Chen Yu (2

[PATCH 1/2] e1000e: Do not wake up the system via WOL if device wakeup is disabled

2020-05-21 Thread Chen Yu
. This patch clears the WOL ability of this network device if the user has disabled the wake up ability in sysfs. Fixes: bc7f75fa9788 ("[E1000E]: New pci-express e1000 driver") Reported-by: Rafael J. Wysocki Reviewed-by: Andy Shevchenko Cc: Signed-off-by: Chen Yu --- drivers/net/ethe

[PATCH 2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability

2020-05-21 Thread Chen Yu
the wake up ability for this device. Fixes: 6ff68026f475 ("e1000e: Use device_set_wakeup_enable") Reported-by: Len Brown Reviewed-by: Andy Shevchenko Cc: Signed-off-by: Chen Yu --- drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 2/2][RFC] PM-runtime: add tracepoints to cover all usage_count changes

2020-06-08 Thread Chen Yu
On Sun, Jun 07, 2020 at 06:55:35AM +0200, Michal Miroslaw wrote: > On Sat, Jun 06, 2020 at 03:14:59PM +0800, Chen Yu wrote: > > Hi, > > On Fri, Jun 05, 2020 at 09:33:11PM +0200, Michal Miroslaw wrote: > > > On Sat, Jun 06, 2020 at 03:05:52AM +0800, Chen Yu wrote: > >

[PATCH 0/2][RFC v2] Change trace point to cover all runtime usage count

2020-06-08 Thread Chen Yu
Currently some code flow of runtime usage count changes is not covered by the rpm_runtime_usage tracepoints. Adjust corresponding tracepoints to monitor all the runtime usage count changes. Chen Yu (2): PM-runtime: Move all runtime usage related function to runtime.c PM-runtime: change

[PATCH 1/2][RFC v2] PM-runtime: Move all runtime usage related function to runtime.c

2020-06-08 Thread Chen Yu
use them. No functional change. Reported-by: kernel test robot Signed-off-by: Chen Yu --- drivers/base/power/runtime.c | 12 include/linux/pm_runtime.h | 12 ++-- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/base/power/runtime.c b/drivers/base

[PATCH 2/2][RFC v2] PM-runtime: change the tracepoints to cover all usage_count

2020-06-08 Thread Chen Yu
sides, all usage changes will be shown using rpm_usage even if included by other trace points. And these changes has helped track down the e1000e runtime issue. Signed-off-by: Chen Yu --- v2: According to Michal's suggestion, adjust the commit log to better describe the meaning of this patch. -

[PATCH 1/2][v3] PM / s2idle: Clear _TIF_POLLING_NRFLAG before suspend to idle

2020-06-23 Thread Chen Yu
cki" Cc: Peter Zijlstra (Intel) Cc: Len Brown Signed-off-by: Chen Yu --- v2: According to Peter's review, v1 is racy, if someone already set TIF_NEED_RESCHED this patch just clear POLLING and go to sleep. Check TIF_NEED_RESCHED before entering suspend to idle and adjust the naming

[PATCH 0/2][v3] Fix IPI missing issue when woken from suspend to idle

2020-06-23 Thread Chen Yu
during suspend to idle. Chen Yu (2): PM / s2idle: Clear _TIF_POLLING_NRFLAG before suspend to idle PM / s2idle: Code cleanup to make s2idle consistent with normal idle path drivers/cpuidle/cpuidle.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) -- 2.17.1

[PATCH 2/2][v3] PM / s2idle: Code cleanup to make s2idle consistent with normal idle path

2020-06-23 Thread Chen Yu
Cc: Peter Zijlstra (Intel) Signed-off-by: Chen Yu --- drivers/cpuidle/cpuidle.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index e092789187c6..b2e764d1ac99 100644 --- a/drivers/cpuidle/cpuidle.c +++

[PATCH][RFC] PM / s2idle: Clear _TIF_POLLING_NRFLAG before suspend to idle

2020-06-15 Thread Chen Yu
-by: kbuild test robot Cc: Peter Zijlstra (Intel) Signed-off-by: Chen Yu --- drivers/cpuidle/cpuidle.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index c149d9e20dfd..d17dad362d34 100644 --- a/drivers/cpuidle/cpuidle.

Re: [PATCH][RFC] PM / s2idle: Clear _TIF_POLLING_NRFLAG before suspend to idle

2020-06-15 Thread Chen Yu
On Mon, Jun 15, 2020 at 09:31:54PM +0200, Peter Zijlstra wrote: > On Mon, Jun 15, 2020 at 08:40:41PM +0200, Peter Zijlstra wrote: > > > > @@ -186,8 +187,10 @@ int cpuidle_enter_s2idle(struct cpuidle_driver *drv, > > > struct cpuidle_device *dev) > > >* be frozen safely. > > >*/ > > >

[PATCH][v2] PM / s2idle: Clear _TIF_POLLING_NRFLAG before suspend to idle

2020-06-15 Thread Chen Yu
just the naming to be consistent with call_cpuidle(). Fixes: b2a02fc43a1f ("smp: Optimize send_call_function_single_ipi()") Suggested-by: Peter Zijlstra (Intel) Reported-by: kbuild test robot Cc: "Rafael J. Wysocki" Cc: Len Brown Cc: Peter Zijlstra (Intel) Signed-off-by: Chen

Re: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device wakeup is disabled

2020-06-16 Thread Chen Yu
On Tue, Jun 16, 2020 at 02:51:27AM +0800, Brown, Aaron F wrote: > > From: Chen Yu > > Sent: Thursday, May 21, 2020 10:59 AM > > To: Kirsher, Jeffrey T ; David S. Miller > > ; Jakub Kicinski ; Kok, Auke-jan H > > ; Jeff Garzik > > Cc: intel-wired-...@list

[PATCH][RFC] ACPI: add "processor.broadcast_ppc" hook to broadcast _PPC to all online CPUs

2019-02-09 Thread Chen Yu
this problem by updating the policy's cpuinfo.max and broadcast the _PPC notifier to all online CPUs. Link: https://bugzilla.kernel.org/show_bug.cgi?id=200759 Reported-and-tested-by: Gabriele Mazzotta Originally-by: Srinivas Pandruvada Signed-off-by: Chen Yu --- drivers/acpi/processor_perflib.c | 16

[PATCH 0/3][RFC] Introduce the in-kernel hibernation encryption

2018-06-20 Thread Chen Yu
-crypto/msg33145.html Chen Yu (3): PM / Hibernate: Add helper functions for hibernation encryption PM / Hibernate: Encrypt the snapshot pages before submitted to the block device tools: create power/crypto utility MAINTAINERS | 8 + kernel/power/Kconfig

[PATCH 1/3][RFC] PM / Hibernate: Add helper functions for hibernation encryption

2018-06-20 Thread Chen Yu
nel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Chen Yu --- kernel/power/Kconfig | 13 ++ kernel/power/Makefile | 1 + kernel/power/crypto_hibernation.c | 405 ++ kernel/power/power.h | 37 4 files changed, 456

[PATCH 2/3][RFC] PM / Hibernate: Encrypt the snapshot pages before submitted to the block device

2018-06-20 Thread Chen Yu
: Rafael J. Wysocki Cc: Pavel Machek Cc: Len Brown Cc: Borislav Petkov Cc: "Lee, Chun-Yi" Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Chen Yu --- kernel/power/power.h | 1 + kernel/power/swap.c | 215

[PATCH 3/3][RFC] tools: create power/crypto utility

2018-06-20 Thread Chen Yu
-by: "Theodore Ts'o" Cc: Rafael J. Wysocki Cc: "Theodore Ts'o" Cc: Stephan Mueller Cc: Eric Biggers Cc: Denis Kenzior Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Chen Yu --- MAINTAINERS | 8 + tools/p

Re: [PATCH 01/10] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-12-14 Thread Chen Yu
Hi, On 2018/12/4 0:01, Rob Herring wrote: > On Fri, Nov 16, 2018 at 8:29 PM Chen Yu wrote: >> >> Hi, >> >> On 2018/11/13 0:02, Rob Herring wrote: >>> On Sat, Oct 27, 2018 at 05:58:11PM +0800, Yu Chen wrote: >>>> This patch adds bin

<    1   2   3   4   5   6   7   8   9   10   >