Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-25 Thread Ching Huang
On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function. This patch fix ioctl data read/write error and change data I/O access from byte to Dword. Signed

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-26 Thread Ching Huang
On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-27 Thread Ching Huang
On Tue, 2014-08-26 at 15:20 +0200, Tomas Henzl wrote: On 08/26/2014 10:27 PM, Ching Huang wrote: On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote

[PATCH v1.3 0/18] arcmsr: bugfix, new features and support new adapters

2014-08-01 Thread Ching Huang
Hi Christoph, This patches are made against the git://git.infradead.org/users/hch/scsi-queue.git/tree/drivers/scsi/arcmsr/ This patches series address following issues. 1. Bugfix for command timeout, abort and ioctl error. 2. Add new feature of support MSI-X interrupt and system hibernation.

[PATCH v1.3 1/18] arcmsr: Revised interrupt service routine relate function to fix bug

2014-08-01 Thread Ching Huang
This patch rewrite the interrupt service routine relate function to fix command timeout when controller has very heavy loading. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h

[PATCH v1.3 2/18] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-01 Thread Ching Huang
This patch adds code to support MSI, MSI-X interrupt. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h

[PATCH v1.3 3/18] arcmsr: Add code to support system hibernation

2014-08-01 Thread Ching Huang
This patch adds code to support system hibernation. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-01 11:03:00.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

2014-08-01 Thread Ching Huang
This patch limits the max. number of SCSI command request to avoid command overflow. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:24:06.0 +0800 +++

[PATCH v1.3 5/18] arcmsr: bugfix - return status of abort command

2014-08-01 Thread Ching Huang
This patch fixes the wrong return status of abort command. Singed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-01 11:05:44.0 +0800 +++

[PATCH v1.3 6/18] arcmsr: precise checking adapter ID

2014-08-01 Thread Ching Huang
This patch rewrites the arcmsr_define_adapter_type function to precisely check Areca adapter's ID. This can prevent an unknown adapter being used as a default adapter type by driver. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c

Re: [PATCH v1.3 2/18] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-01 Thread Ching Huang
Hi Alexander, Thanks for your advice. This patch was revised according to your comment. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0 +0800 +++

[PATCH v2 2/18] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-03 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Changes in v2 of 2/18: * remove the checking of capability of MSI-X, MSI. * correct the wrong IRQ vector of request_irq failed. * replace pci_enable_msi_range() by pci_enable_msi_exact(). Signed-off-by: Ching Huang ching2...@areca.com.tw --- Thanks

Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

2014-08-03 Thread Ching Huang
On Fri, 2014-08-01 at 05:35 -0700, Christoph Hellwig wrote: @@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru arcmsr_handle_virtual_command(acb, cmd); return 0; } - if (atomic_read(acb-ccboutstandingcount) = -

[PATCH v2 6/18] arcmsr: precise checking adapter ID

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch rewrites the arcmsr_define_adapter_type function to precisely check Areca adapter's ID. This can prevent an unknown adapter being used as a default adapter type by driver. Signed-off-by: Ching Huang ching2...@areca.com.tw --- Thanks

[PATCH v1.3 7/18] arcmsr: revise messages_isr_bh_fn to remove duplicate code

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Revise message_isr_bh_fn to remove the duplicate code for each adapter type. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v1.3 8/18] arcmsr: remove calling arcmsr_hbb_enable_driver_mode

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Remove calling arcmsr_hbb_enable_driver_mode by in-line code. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16:43

[PATCH v1.3 9/18] arcmsr: modify printing adapter model number and F/W messages

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Adjust printing order of adapter model name and firmware version. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16

[PATCH v1.3 10/18] arcmsr: clear outbound doorbell buffer completely

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Clear outbound doorbell buffer completely for adapter type C. This is to prevent getting bad data input from IOP before ioctl command beginning. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b

[PATCH v1.3 11/18] arcmsr: rename function and variable

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Rename some variable and function name for readability and consistency. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15

[PATCH v1.3 12/18] arcmsr: revise allocation of second dma_coherent_handle for type B adapter

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This modification is for consistency with up-coming adapter type D. They have similar H/W and S/W structure. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi

[PATCH v1.3 13/18] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate functions. This patch fix ioctl data read/write error and change data I/O access from byte to Dword. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi

[PATCH v1.3 14/18] arcmsr: fix sparse waring and error

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Fix sparse utility checking error and warning. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16:46:30.0

[PATCH v1.3 15/18] arcmsr: modify some character string

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Revise comment and some character strings. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16:45:46.0 +0800

[PATCH v1.3 16/18] arcmsr: support new adapter ARC12x4 series

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Add code for supporting Areca new Raid adapter ARC12x4 series. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:29

[PATCH v1.3 17/18] arcmsr: modify calling scsi_scan_host after all initialization done

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Modify calling scsi_scan_host until all initialization done. And fix error path of free allocated resource. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v1.3 18/18] arcmsr: replace flush_scheduled_work() by flush_work()

2014-08-04 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw To prevent flushing entire workqueue, replace flush_scheduled_work() by flush_work(). Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr

Re: [PATCH v3 0/17] arcmsr: change note since v13 or v2

2014-08-20 Thread Ching Huang
Hi Christoph, Thanks for your effort to fix up errors and apply the patches of arcmsr to a branch. It is great. Regards, Ching Huang On Tue, 2014-08-19 at 08:02 -0700, Christoph Hellwig wrote: Hi Ching, I've fixed up various checkpatch errors and fixed up some descriptions and applied

[PATCH v2 3/17] arcmsr: Add code to support system hibernation

2014-08-08 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch adds code to support system hibernation. Changes in v2 of 3/17: * merge patch 18/18 to this patch Signed-off-by: Ching Huang ching2...@areca.com.tw --- Thanks to Tomas's advice. diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi

[PATCH v2 4/17] arcmsr: limit max. number of SCSI command request

2014-08-08 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch limits the max. number of SCSI command request to avoid command overflow. Changes in v2 4/17: * set the correct host-can_queue value after read adapter's limitation. Signed-off-by: Ching Huang ching2...@areca.com.tw --- Thanks to Tomas's

Re: [PATCH v2 3/17] arcmsr: Add code to support system hibernation

2014-08-11 Thread Ching Huang
Yes. 18/18 is obsolete. Thanks to Tomas's advice. Ching On Fri, 2014-08-08 at 16:23 +0200, Tomas Henzl wrote: On 08/08/2014 02:05 PM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch adds code to support system hibernation. Changes in v2 of 3/17: * merge patch

[PATCH v3 0/17] arcmsr: change note since v13 or v2

2014-08-18 Thread Ching Huang
Change note: 1,5,7~17/17 since v1.3 are not change. 2,3,4/17 since v2 are not change. 6/17 since v2: 1. pre-define adapter_type value in private data of pci_device_id. 2. remove the arcmsr_define_adapter_type function. Ching Huang ching2...@areca.com.tw -- To unsubscribe from this list: send

[PATCH v3 1/17] arcmsr: Revised interrupt service routine relate function to fix bug

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch rewrite the interrupt service routine relate function to fix command timeout when controller has very heavy loading. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr

[PATCH v3 2/17] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch adds code to support MSI, MSI-X interrupt. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0

[PATCH v3 3/17] arcmsr: Add code to support hibernation

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch adds code to support system hibernation. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-01 17:54

[PATCH v4 4/17] arcmsr: limit max. number of SCSI command request

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch limits the max. number of SCSI commmand request to avoid command overflow. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h

Ignore the [PATCH v4 4/17]

2014-08-19 Thread Ching Huang
Please ignore the patch [PATCH v4 4/17], I will resend the patch [PATCH v3 4/17]. Regards, Ching Huang ching2...@areca.com.tw -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH v3 4/17] arcmsr: limit max. number of SCSI command request

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch limits the max. number of SCSI command request to avoid command overflow. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h

[PATCH v3 5/17] arcmsr: bugfix - return status of abort command

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch fixed the wrong return status of abort command. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-08 19:35

[PATCH v3 6/17] arcmsr: precise checking adapter ID

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw change since v2: 1. This patch pre-define the adapter-type in private data of struct pci_device_id. 2. Remove arcmsr_define_adapter_type function. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b

[PATCH v3 7/17] arcmsr: revise message_isr_bh_fn to remove duplicate code

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Revise message_isr_bh_fn to remove the duplicate code for each adapter type. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v3 8/17] arcmsr: remove calling arcmsr_hbb_enable_driver_mode

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Remove calling arcmsr_hbb_enable_driver_mode by in-line code. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:39

[PATCH v3 9/17] arcmsr: modify printing adapter model number and F/W messages

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Adjust printing order of adapter model name and firmware version. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18

[PATCH v3 10/17] arcmsr: clear outbound doorbell buffer completely

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Clear outbound doorbell buffer completely for adapter type C. This is to prevent getting bad data input from IOP before ioctl command beginning. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b

[PATCH v3 11/17] arcmsr: rename function and variable

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Rename some variable and function name for readability and consistency. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15

[PATCH v3 12/17] arcmsr: revise allocation of second dma_coherent_handle for type B

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This modification is for consistency with upcoming adapter type D. Both adapter type B and D have similar H/W and S/W structure. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr

[PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function. This patch fix ioctl data read/write error and change data I/O access from byte to Dword. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi

[PATCH v3 14/17] arcmsr: fix sparse warning and error

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Fix sparse utility checking error and warning. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:40:48.0

[PATCH v3 15/17] arcmsr: modify some character string

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Revise comment and some character strings. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:41:02.0 +0800

[PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Add code for supporting Areca new Raid adapter ARC12x4 series. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:29

[PATCH v3 17/17] arcmsr: modify calling scsi_scan_host after all initialization done

2014-08-19 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Modify calling scsi_scan_host until all initialization done. And fix error path of free allocation resource. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-27 Thread Ching Huang
On Wed, 2014-08-27 at 14:29 +0200, Tomas Henzl wrote: On 08/27/2014 10:19 PM, Ching Huang wrote: On Tue, 2014-08-26 at 15:20 +0200, Tomas Henzl wrote: On 08/26/2014 10:27 PM, Ching Huang wrote: On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-08-28 Thread Ching Huang
On Wed, 2014-08-27 at 16:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:25 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Add code for supporting Areca new Raid adapter ARC12x4 series. Signed-off-by: Ching Huang ching2...@areca.com.tw --- Hi Ching, please look

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-11 Thread Ching Huang
On Thu, 2014-09-11 at 16:21 +0200, Tomas Henzl wrote: On 09/11/2014 05:59 AM, Ching Huang wrote: On Wed, 2014-09-10 at 11:58 +0200, Tomas Henzl wrote: On 09/09/2014 06:30 PM, Christoph Hellwig wrote: Ching, do you have a chance to address Thomas second concern below? As far as I can

[PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-12 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 13/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr change in v4: 1. for readability, rename firstindex to getIndex, rename lastindex to putIndex 2

[PATCH v4 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-12 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 16/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr change in v4: 1. clean up of duplicate variable declaration in switch. 2. simplify of updating

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-14 Thread Ching Huang
On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: On 09/12/2014 09:29 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 13/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi

Re: [PATCH v4 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-14 Thread Ching Huang
On Fri, 2014-09-12 at 16:05 +0200, Tomas Henzl wrote: On 09/12/2014 10:22 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 16/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Ching Huang
On Mon, 2014-09-15 at 12:25 +0200, Tomas Henzl wrote: On 09/15/2014 04:56 AM, Ching Huang wrote: On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: On 09/12/2014 09:29 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 13/17

[PATCH v5 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-15 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch is to modify previous patch 16/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr change since v4: 1. add spin_lock in arcmsr_done4abort_postqueue for protect doneq_index. 2. fix

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Ching Huang
On Mon, 2014-09-15 at 13:50 +0200, Tomas Henzl wrote: On 09/15/2014 12:36 PM, Ching Huang wrote: On Mon, 2014-09-15 at 12:25 +0200, Tomas Henzl wrote: On 09/15/2014 04:56 AM, Ching Huang wrote: On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: On 09/12/2014 09:29 AM, Ching Huang wrote

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-10 Thread Ching Huang
On Wed, 2014-09-10 at 11:58 +0200, Tomas Henzl wrote: On 09/09/2014 06:30 PM, Christoph Hellwig wrote: Ching, do you have a chance to address Thomas second concern below? As far as I can tell (Thomas, please correct me) that's the last outstanding concern, and I'd really like to merge

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-15 Thread Ching Huang
On Mon, 2014-09-15 at 10:05 -0700, Christoph Hellwig wrote: On Mon, Sep 15, 2014 at 03:23:36PM +0200, Tomas Henzl wrote: Christoph, you may add my 'reviewed-by' to the arcmsr series http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr with the

Re: [PATCH v5 1/2] arcmsr: simplify ioctl data read/write

2014-09-25 Thread Ching Huang
On Thu, 2014-09-25 at 19:01 +0200, Christoph Hellwig wrote: Thanks, applied to drivers-for-3.18. Thanks for all of your review, especially Tomas. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v5 1/2] arcmsr: simplify ioctl data read/write

2014-09-24 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch is relative to: http://git.infradead.org/users/hch/scsi-queue.git/tree/drivers-for-3.18:/drivers/scsi/arcmsr change in v5: 1. rename firstindex to getIndex, lastindex to putIndex for readability 2. define ARCMSR_API_DATA_BUFLEN as 1032 3

Re: [PATCH v5 1/2] arcmsr: simplify ioctl data read/write

2014-09-25 Thread Ching Huang
On Wed, 2014-09-24 at 17:48 +0200, Tomas Henzl wrote: On 09/24/2014 11:33 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw This patch is relative to: http://git.infradead.org/users/hch/scsi-queue.git/tree/drivers-for-3.18:/drivers/scsi/arcmsr change in v5: 1. rename

[PATCH 1/1] arcmsr: Notify has sense data report

2014-11-27 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw This patch is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/heads/drivers-for-3.18:/drivers/scsi/arcmsr Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we have sense data. Signed-off-by: Ching Huang

Re: [PATCH 1/1] arcmsr: Notify has sense data report

2014-11-28 Thread Ching Huang
Thanks to Dan's advice and Hannes' suggestion. I will revise and resubmit it later. On Fri, 2014-11-28 at 12:17 +0300, Dan Carpenter wrote: On Fri, Nov 28, 2014 at 12:20:44PM +0800, Ching Huang wrote: This patch is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/refs

[PATCH 1.1 1/1] arcmsr: Notify has sense data report

2014-11-28 Thread Ching Huang
From: Ching Huang ching2...@areca.com.tw Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we have sense data. Signed-off-by: Ching Huang ching2...@areca.com.tw --- This patch is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/heads/drivers

Re: [PATCH 2/3] arcmsr: Split dma resource allocation to a new function

2015-11-26 Thread Ching Huang
On Thu, 2015-11-26 at 11:46 -0800, Joe Perches wrote: > On Thu, 2015-11-26 at 19:41 +0800, Ching Huang wrote: > > split dma resource allocation and io register assignment from get_config to > > a new function arcmsr_alloc_io_queue. > > trivia: > > > diff -uprN a/dr

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

2015-11-25 Thread Ching Huang
On Wed, 2015-11-25 at 14:55 +0100, Tomas Henzl wrote: > On 25.11.2015 12:41, Ching Huang wrote: > > From: Ching Huang <ching2...@areca.com.tw> > > > > Releasing allocated resource if get configuration data failed. > > > > Signed-of-by: Ching Huang <ching2

Re: [PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

2015-11-25 Thread Ching Huang
On Wed, 2015-11-25 at 08:18 +0100, Hannes Reinecke wrote: > On 11/25/2015 04:25 AM, Ching Huang wrote: > > From: Ching Huang <ching2...@areca.com.tw> > > > > Support areca new PCIe to SATA RAID adapter ARC1203 > > > > Signed-of-by: Ching Huang<ching2..

Re: [PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

2015-11-25 Thread Ching Huang
On Wed, 2015-11-25 at 09:43 +0100, Johannes Thumshirn wrote: > On Wed, 2015-11-25 at 11:25 +0800, Ching Huang wrote: > > From: Ching Huang <ching2...@areca.com.tw> > > > > Support areca new PCIe to SATA RAID adapter ARC1203 > > > > Signed-of

[PATCH v3 3/5] arcmsr: modifies codes for more readable

2015-11-25 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Modifies codes for more readable Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 10:52:16.28647 +0800 +

[PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

2015-11-25 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Fixed getting wrong configuration data of adapter type B and type D. Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr

[PATCH v3 2/5] arcmsr: fixes not release allocated resource

2015-11-25 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Releasing allocated resource if get configuration data failed. Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v3 0/5] arcmsr: support areca new adapter ARC1203

2015-11-25 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Patch 1 fixes getting wrong configuration data. Patch 2 fixes not release allocated resource if get configuration data failed. Patch 3 modifies codes for more readable. Pacth 4 adds codes to support new adapter ARC1203. Patch 5 changes driver v

[PATCH v3 4/5] arcmsr: adds code for support areca new adapter ARC1203

2015-11-25 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Support areca new PCIe to SATA RAID adapter ARC1203 Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 19:10:

[PATCH v3 5/5] arcmsr: changes driver version number

2015-11-25 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Changes driver version number. Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 18:25:42.926038000 +0800 +

Re: [PATCH 0/2] arcmsr: support areca new adapter ARC1203

2015-11-24 Thread Ching Huang
On Tue, 2015-11-24 at 16:07 +0100, Hannes Reinecke wrote: > On 11/24/2015 09:00 AM, Ching Huang wrote: > > From: Ching Huang <ching2...@areca.com.tw> > > > > Patch 1 fixes getting wrong configuration data. > > > > Pacth 2 adds codes to support new adapter A

[PATCH v2 0/3] arcmsr: support areca new adapter ARC1203

2015-11-24 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Patch 1 fixes getting wrong configuration data. Pacth 2 adds codes to support new adapter ARC1203. Patch 3 changes driver version number. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

[PATCH v2 1/3] arcmsr: fixed getting wrong configuration data

2015-11-24 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Fixed getting wrong configuration data of adapter type B and type D. Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr

[PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

2015-11-24 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Support areca new PCIe to SATA RAID adapter ARC1203 Signed-of-by: Ching Huang<ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 10:52:

[PATCH v2 3/3] arcmsr: changes driver version number

2015-11-24 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Changes driver version number. Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 10:52:13.33447 +0800 +

Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

2015-11-30 Thread Ching Huang
On Mon, 2015-11-30 at 19:17 -0500, Martin K. Petersen wrote: > >>>>> "Ching" == Ching Huang <ching2...@areca.com.tw> writes: > > Hello Ching, > > I applied both your series to 4.5/scsi-queue. > > In the future please run checkpatch b

[PATCH 0/3] arcmsr: fix bug of reallocate dma resource

2015-11-26 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> This patch is relative to previous version v1.30.00.21-20151016. This patch series are to fix reallocate dma resource if get_firmware_spec was called again when eh_bus_reset_handler occurred. Patch 1 modifies codes for more readable. Patch 2

[PATCH 1/3] arcmsr: modify codes for more readable

2015-11-26 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> modify codes for more readable Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-25 18:08:52.0

[PATCH 2/3] arcmsr: Split dma resource allocation to a new function

2015-11-26 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> split dma resource allocation and io register assignment from get_config to a new function arcmsr_alloc_io_queue. Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/

[PATCH 3/3] arcmsr: change driver version to v1.30.00.22-20151126

2015-11-26 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> change driver version to v1.30.00.22-20151126 Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 18:04:26.000

[PATCH 0/2] arcmsr: support areca new adapter ARC1203

2015-11-24 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Patch 1 fixes getting wrong configuration data. Pacth 2 adds codes to support new adapter ARC1203. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

[PATCH 1/2] arcmsr: fixed getting wrong configuration data

2015-11-24 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Fixed getting wrong configuration data of adapter type B and type D. Signed-of-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2

[PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203

2015-11-24 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Support areca new PCIe to SATA RAID adapter ARC1203 Signed-of-by: Ching Huang<ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-24 11:36:

Re: [PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203

2015-11-24 Thread Ching Huang
On Tue, 2015-11-24 at 01:33 -0800, Joe Perches wrote: > On Tue, 2015-11-24 at 16:17 +0800, Ching Huang wrote: > > From: Ching Huang <ching2...@areca.com.tw> > > > > Support areca new PCIe to SATA RAID adapter ARC1203 > > Why add the dma_free_coherent to an old d

Re: [PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203

2015-11-24 Thread Ching Huang
On Tue, 2015-11-24 at 02:24 -0800, Joe Perches wrote: > On Tue, 2015-11-24 at 17:53 +0800, Ching Huang wrote: > > On Tue, 2015-11-24 at 01:33 -0800, Joe Perches wrote: > > > On Tue, 2015-11-24 at 16:17 +0800, Ching Huang wrote: > > > > From: Ching

[PATCH v2 1/3] scsi: arcmsr: Add driver module parameter msi_enable

2017-11-28 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Add module parameter msi_enable to has a chance to disable msi interrupt if between controller and system has msi INT compatible issue. Signed-off-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/

[PATCH v2 2/3] scsi: arcmsr: Add driver module parameter msix_enable

2017-11-28 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Add module parameter msix_enable to has a chance to disable msix interrupt if between controller and system has msix INT compatible issue. Signed-off-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba

[PATCH v2 3/3] scsi: arcmsr: Update driver version to v1.40.00.03-20171124

2017-11-28 Thread Ching Huang
From: Ching Huang <ching2...@areca.com.tw> Update driver version to v1.40.00.03-20171124 Signed-off-by: Ching Huang <ching2...@areca.com.tw> --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2017-11-23 14:29:46.000

Re: [PATCH 1/3] scsi: arcmsr: Add driver module parameter msi_enable

2017-11-24 Thread Ching Huang
On Fri, 2017-11-24 at 04:45 +0800, Ching Huang wrote: > Hello Dan, > > On Thu, 2017-11-23 at 13:44 +0300, Dan Carpenter wrote: > > On Thu, Nov 23, 2017 at 09:27:19AM +0800, Ching Huang wrote: > > > From: Ching Huang <ching2...@areca.com.tw> > > > >

Re: [PATCH 1/3] scsi: arcmsr: Add driver module parameter msi_enable

2017-11-23 Thread Ching Huang
Hello Dan, On Thu, 2017-11-23 at 13:44 +0300, Dan Carpenter wrote: > On Thu, Nov 23, 2017 at 09:27:19AM +0800, Ching Huang wrote: > > From: Ching Huang <ching2...@areca.com.tw> > > > > Add module parameter msi_enable to has a chance to disable msi interrupt if &g

Re: [PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable

2017-11-23 Thread Ching Huang
On Thu, 2017-11-23 at 14:43 +0300, Dan Carpenter wrote: > On Thu, Nov 23, 2017 at 09:31:14AM +0800, Ching Huang wrote: > > @@ -829,12 +833,15 @@ arcmsr_request_irq(struct pci_dev *pdev, > > unsigned long flags; > > int nvec, i; > > > > + if (msix_

Re: [PATCH 0/3] scsi: arcmsr: add driver module parameter - msi_enable, msix_enable

2017-11-23 Thread Ching Huang
On Thu, 2017-11-23 at 04:57 -0800, Christoph Hellwig wrote: > On Thu, Nov 23, 2017 at 09:22:03AM +0800, Ching Huang wrote: > > From: Ching Huang <ching2...@areca.com.tw> > > > > Hi all, > > > > The following patches apply to Martin's 4.16/scsi-queue.

  1   2   3   4   >