Re: [PATCH v6 07/12] ARM: EXYNOS: remove system mmu initialization from exynos tree

2013-09-29 Thread Cho KyongHo
On Sun, 29 Sep 2013 20:38:38 -0400, Sean Paul wrote: On Sun, Sep 29, 2013 at 8:35 PM, Cho KyongHo pullip@samsung.com wrote: On Fri, 27 Sep 2013 14:55:51 -0400, Sean Paul wrote: On Tue, Dec 25, 2012 at 8:54 PM, Cho KyongHo pullip@samsung.com wrote: This removes System MMU

Re: [PATCH v6 07/12] ARM: EXYNOS: remove system mmu initialization from exynos tree

2013-09-29 Thread Cho KyongHo
On Sun, 29 Sep 2013 19:03:06 -0700, Olof Johansson wrote: Hi, 2013/9/29 Cho KyongHo pullip@samsung.com: Ah, I remember that this is merged. I agreed to merge this patch because iommu driver need to be completely changed. Whenever I change exynos-iommu driver, synchronizing

Re: [PATCH 2/2] iommu/exynos: Follow kernel coding style for __sysmmu_enable return type

2013-08-16 Thread Cho KyongHo
On Wed, 14 Aug 2013 15:15:49 +0200, 'Joerg Roedel' wrote: > KyongHo, > > On Fri, Jul 26, 2013 at 07:46:01PM +0900, Cho KyongHo wrote: > > __sysmmu_enable() must return 1 if it is called with the same page table. > > I have fixed it exynos_iommu_attach_device()

Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-16 Thread Cho KyongHo
On Wed, 14 Aug 2013 12:56:16 +0200, 'Joerg Roedel' wrote: > On Fri, Aug 09, 2013 at 09:55:30AM +0200, Tomasz Figa wrote: > > Oh, this is a valid point, but it was more a nitpick about the coding > > style. Single path error handling (with goto) is widely used in the kernel > > in cases when more

Re: [PATCH v9 03/16] iommu/exynos: fix page table maintenance

2013-08-16 Thread Cho KyongHo
On Wed, 14 Aug 2013 13:54:53 -0700, Grant Grundler wrote: > On Wed, Aug 14, 2013 at 3:49 AM, Joerg Roedel wrote: > > On Thu, Aug 08, 2013 at 11:28:44AM -0700, Grant Grundler wrote: > >> I can't speak to the previous BUG_ON(). I believe the EADDRESSINUSE > >> failures could be either WARN_ON or

Re: [PATCH v9 03/16] iommu/exynos: fix page table maintenance

2013-08-16 Thread Cho KyongHo
On Wed, 14 Aug 2013 13:54:53 -0700, Grant Grundler wrote: On Wed, Aug 14, 2013 at 3:49 AM, Joerg Roedel j...@8bytes.org wrote: On Thu, Aug 08, 2013 at 11:28:44AM -0700, Grant Grundler wrote: I can't speak to the previous BUG_ON(). I believe the EADDRESSINUSE failures could be either WARN_ON

Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-16 Thread Cho KyongHo
On Wed, 14 Aug 2013 12:56:16 +0200, 'Joerg Roedel' wrote: On Fri, Aug 09, 2013 at 09:55:30AM +0200, Tomasz Figa wrote: Oh, this is a valid point, but it was more a nitpick about the coding style. Single path error handling (with goto) is widely used in the kernel in cases when more than

Re: [PATCH 2/2] iommu/exynos: Follow kernel coding style for __sysmmu_enable return type

2013-08-16 Thread Cho KyongHo
On Wed, 14 Aug 2013 15:15:49 +0200, 'Joerg Roedel' wrote: KyongHo, On Fri, Jul 26, 2013 at 07:46:01PM +0900, Cho KyongHo wrote: __sysmmu_enable() must return 1 if it is called with the same page table. I have fixed it exynos_iommu_attach_device() to always return zero on success

Re: [PATCH v9 07/16] iommu/exynos: support for device tree

2013-08-11 Thread Cho KyongHo
On Fri, 09 Aug 2013 10:30:11 +0200, Tomasz Figa wrote: > On Friday 09 of August 2013 15:37:30 Cho KyongHo wrote: > > On Fri, 09 Aug 2013 00:41:25 +0200, Tomasz Figa wrote: > > > Hi KyongHo, > > > > > > On Thursday 08 of August 2013 18:38:49 Cho KyongHo wrote:

Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-11 Thread Cho KyongHo
On Fri, 09 Aug 2013 11:35:20 +0200, Tomasz Figa wrote: > On Friday 09 of August 2013 17:51:56 Cho KyongHo wrote: > > On Fri, 09 Aug 2013 09:55:30 +0200, Tomasz Figa wrote: > > > Hi KyongHo, > > > > > > On Friday 09 of August 2013 14:58:49 Cho KyongHo wrote:

Re: [PATCH v9 14/16] iommu/exynos: add support for power management subsystems.

2013-08-11 Thread Cho KyongHo
On Fri, 09 Aug 2013 10:32:40 +0200, Tomasz Figa wrote: > On Friday 09 of August 2013 16:49:43 Cho KyongHo wrote: > > On Fri, 09 Aug 2013 01:03:05 +0200, Tomasz Figa wrote: > > > Hi KyongHo, > > > > > > nit: Please drop the trailing dot at the end of patch

Re: [PATCH v9 14/16] iommu/exynos: add support for power management subsystems.

2013-08-11 Thread Cho KyongHo
On Fri, 09 Aug 2013 10:32:40 +0200, Tomasz Figa wrote: On Friday 09 of August 2013 16:49:43 Cho KyongHo wrote: On Fri, 09 Aug 2013 01:03:05 +0200, Tomasz Figa wrote: Hi KyongHo, nit: Please drop the trailing dot at the end of patch subject. Oh. I didn't catch that. Thank you

Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-11 Thread Cho KyongHo
On Fri, 09 Aug 2013 11:35:20 +0200, Tomasz Figa wrote: On Friday 09 of August 2013 17:51:56 Cho KyongHo wrote: On Fri, 09 Aug 2013 09:55:30 +0200, Tomasz Figa wrote: Hi KyongHo, On Friday 09 of August 2013 14:58:49 Cho KyongHo wrote: On Thu, 08 Aug 2013 16:00:18 +0200, Tomasz Figa

Re: [PATCH v9 07/16] iommu/exynos: support for device tree

2013-08-11 Thread Cho KyongHo
On Fri, 09 Aug 2013 10:30:11 +0200, Tomasz Figa wrote: On Friday 09 of August 2013 15:37:30 Cho KyongHo wrote: On Fri, 09 Aug 2013 00:41:25 +0200, Tomasz Figa wrote: Hi KyongHo, On Thursday 08 of August 2013 18:38:49 Cho KyongHo wrote: This commit adds device tree support

Re: [PATCH v9 06/16] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 10:04:03 +0200, Tomasz Figa wrote: > On Friday 09 of August 2013 15:15:57 Cho KyongHo wrote: > > On Fri, 09 Aug 2013 00:26:51 +0200, Tomasz Figa wrote: > > > Hi KyongHo, > > > > > > On Thursday 08 of August 2013 18:38:35 Cho KyongHo wrote

Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 09:55:30 +0200, Tomasz Figa wrote: > Hi KyongHo, > > On Friday 09 of August 2013 14:58:49 Cho KyongHo wrote: > > On Thu, 08 Aug 2013 16:00:18 +0200, Tomasz Figa wrote: > > > On Thursday 08 of August 2013 18:38:04 Cho KyongHo wrote: > > > >

Re: [PATCH v9 03/16] iommu/exynos: fix page table maintenance

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 09:47:28 +0200, Tomasz Figa wrote: > Hi KyongHo, > > On Friday 09 of August 2013 13:15:20 Cho KyongHo wrote: > > On Thu, 08 Aug 2013 15:54:50 +0200, Tomasz Figa wrote: > > > On Thursday 08 of August 2013 18:37:43 Cho KyongHo wrote: > > > &g

Re: [PATCH v9 14/16] iommu/exynos: add support for power management subsystems.

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 01:03:05 +0200, Tomasz Figa wrote: > Hi KyongHo, > > nit: Please drop the trailing dot at the end of patch subject. > Oh. I didn't catch that. Thank you. > On Thursday 08 of August 2013 18:41:17 Cho KyongHo wrote: > > This adds support for Adv

Re: [PATCH v9 08/16] iommu/exynos: gating clocks of master H/W

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 00:45:17 +0200, Tomasz Figa wrote: > Hi KyongHo, > > On Thursday 08 of August 2013 18:39:05 Cho KyongHo wrote: > > This patch gates clocks of master H/W as well as clocks of System MMU > > if master clocks are specified. > > > > Some Exynos

Re: [PATCH v9 07/16] iommu/exynos: support for device tree

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 00:41:25 +0200, Tomasz Figa wrote: > Hi KyongHo, > > On Thursday 08 of August 2013 18:38:49 Cho KyongHo wrote: > > This commit adds device tree support for System MMU. > > This also include the following changes and enhancements: > > > > * us

Re: [PATCH v9 06/16] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 00:26:51 +0200, Tomasz Figa wrote: > Hi KyongHo, > > On Thursday 08 of August 2013 18:38:35 Cho KyongHo wrote: > > Signed-off-by: Cho KyongHo > > --- > > .../bindings/iommu/samsung,exynos4210-sysmmu.txt | 103 +++ > >

Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-09 Thread Cho KyongHo
On Thu, 08 Aug 2013 16:00:18 +0200, Tomasz Figa wrote: > On Thursday 08 of August 2013 18:38:04 Cho KyongHo wrote: > > Since kmalloc() does not guarantee that the allignment of 1KiB when it > > allocates 1KiB, it is required to allocate lv2 page table from own > > slab that

Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-09 Thread Cho KyongHo
On Thu, 08 Aug 2013 16:00:18 +0200, Tomasz Figa wrote: On Thursday 08 of August 2013 18:38:04 Cho KyongHo wrote: Since kmalloc() does not guarantee that the allignment of 1KiB when it allocates 1KiB, it is required to allocate lv2 page table from own slab that guarantees alignment of 1KiB

Re: [PATCH v9 06/16] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 00:26:51 +0200, Tomasz Figa wrote: Hi KyongHo, On Thursday 08 of August 2013 18:38:35 Cho KyongHo wrote: Signed-off-by: Cho KyongHo pullip@samsung.com --- .../bindings/iommu/samsung,exynos4210-sysmmu.txt | 103 +++ arch/arm/boot/dts/exynos4.dtsi

Re: [PATCH v9 07/16] iommu/exynos: support for device tree

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 00:41:25 +0200, Tomasz Figa wrote: Hi KyongHo, On Thursday 08 of August 2013 18:38:49 Cho KyongHo wrote: This commit adds device tree support for System MMU. This also include the following changes and enhancements: * use managed device helper functions

Re: [PATCH v9 08/16] iommu/exynos: gating clocks of master H/W

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 00:45:17 +0200, Tomasz Figa wrote: Hi KyongHo, On Thursday 08 of August 2013 18:39:05 Cho KyongHo wrote: This patch gates clocks of master H/W as well as clocks of System MMU if master clocks are specified. Some Exynos SoCs (i.e. GScalers in Exynos5250) have

Re: [PATCH v9 14/16] iommu/exynos: add support for power management subsystems.

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 01:03:05 +0200, Tomasz Figa wrote: Hi KyongHo, nit: Please drop the trailing dot at the end of patch subject. Oh. I didn't catch that. Thank you. On Thursday 08 of August 2013 18:41:17 Cho KyongHo wrote: This adds support for Advance Power Management and Runtime

Re: [PATCH v9 03/16] iommu/exynos: fix page table maintenance

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 09:47:28 +0200, Tomasz Figa wrote: Hi KyongHo, On Friday 09 of August 2013 13:15:20 Cho KyongHo wrote: On Thu, 08 Aug 2013 15:54:50 +0200, Tomasz Figa wrote: On Thursday 08 of August 2013 18:37:43 Cho KyongHo wrote: This prevents allocating lv2 page table

Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 09:55:30 +0200, Tomasz Figa wrote: Hi KyongHo, On Friday 09 of August 2013 14:58:49 Cho KyongHo wrote: On Thu, 08 Aug 2013 16:00:18 +0200, Tomasz Figa wrote: On Thursday 08 of August 2013 18:38:04 Cho KyongHo wrote: Since kmalloc() does not guarantee

Re: [PATCH v9 06/16] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-09 Thread Cho KyongHo
On Fri, 09 Aug 2013 10:04:03 +0200, Tomasz Figa wrote: On Friday 09 of August 2013 15:15:57 Cho KyongHo wrote: On Fri, 09 Aug 2013 00:26:51 +0200, Tomasz Figa wrote: Hi KyongHo, On Thursday 08 of August 2013 18:38:35 Cho KyongHo wrote: Signed-off-by: Cho KyongHo pullip

Re: [PATCH v9 03/16] iommu/exynos: fix page table maintenance

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 15:54:50 +0200, Tomasz Figa wrote: > On Thursday 08 of August 2013 18:37:43 Cho KyongHo wrote: > > This prevents allocating lv2 page table for the lv1 page table entry > ^ What this is this this about? :) > As you might indicate, 'this' means this patch :) &

Re: [PATCH v9 01/16] iommu/exynos: do not include removed header

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 15:42:24 +0200, Tomasz Figa wrote: > Hi KyongHo, > > On Thursday 08 of August 2013 18:37:25 Cho KyongHo wrote: > > This commit remove which is removed. > > I would prefer a more meaningful commit message, something among following > lines: >

Re: [PATCH v9 02/16] iommu/exynos: add missing cache flush for removed page table entries

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 15:44:09 +0200, Tomasz Figa wrote: > On Thursday 08 of August 2013 18:37:34 Cho KyongHo wrote: > > This commit adds cache flush for removed small and large page entries > > in exynos_iommu_unmap(). Missing cache flush of removed page table > > entries c

Re: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 22:43:43 +0100, Will Deacon wrote: > On Thu, Aug 08, 2013 at 10:38:10PM +0100, Tomasz Figa wrote: > > On Thursday 08 of August 2013 08:09:49 Rob Herring wrote: > > > On Thu, Aug 1, 2013 at 8:05 AM, Cho KyongHo > > wrote: > > > > Should thi

Re: [PATCH v9 00/16] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-08-08 Thread Cho KyongHo
e order of patches. Thank you. KyongHo. > Best regards, > Tomasz > > On Thursday 08 of August 2013 18:37:10 Cho KyongHo wrote: > > The current exynos-iommu(System MMU) driver does not work autonomously > > since it is lack of support for power management of peripheral

Re: [PATCH v9 05/16] clk: exynos: add gate clock descriptions of System MMU

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 13:40:13 +0200, Tomasz Figa wrote: > On Thursday 08 of August 2013 13:17:34 Sylwester Nawrocki wrote: > > On 08/08/2013 11:38 AM, Cho KyongHo wrote: > > > This adds gate clocks of all System MMUs and their master IPs > > > that are not apeared in

Re: [PATCH v9 06/16] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 12:45:34 +0200, Sylwester Nawrocki wrote: > Hi, > > On 08/08/2013 11:38 AM, Cho KyongHo wrote: > > How about something along the lines of: > > "This patch adds dts entries for the SYSMMU devices found on Exynos4 > and Exynos5 SoC series and the

[PATCH v9 16/16] iommu/exynos: return 0 if iommu_attach_device() successes

2013-08-08 Thread Cho KyongHo
Grundler Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 2d16fc0..d959e95 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu

[PATCH v9 14/16] iommu/exynos: add support for power management subsystems.

2013-08-08 Thread Cho KyongHo
/O power domain, its driver must call iommu_attach_device() after its local power domain is turned on, iommu_detach_device before turned off. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 235 +- 1 files changed, 231 insertions(+), 4

[PATCH v9 15/16] iommu/exynos: change rwlock to spinlock

2013-08-08 Thread Cho KyongHo
Since acquiring read_lock is not more frequent than write_lock, it is not beneficial to use rwlock, this commit changes rwlock to spinlock. Reviewed-by: Grant Grundler Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 36 ++-- 1 files changed, 18

[PATCH v9 13/16] iommu/exynos: turn on useful configuration options

2013-08-08 Thread Cho KyongHo
master H/W's transaction. This new feature is enabled by default and QoS value written to MMU_CFG is ignored. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 20 +--- 1 files changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b

[PATCH v9 12/16] iommu/exynos: add bus notifier for registering System MMU

2013-08-08 Thread Cho KyongHo
attached to iommu_domain is now master H/W. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 435 -- 1 files changed, 291 insertions(+), 144 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 686e3c8..8240f7f

[PATCH v9 10/16] iommu/exynos: remove custom fault handler

2013-08-08 Thread Cho KyongHo
This commit removes custom fault handler. The device drivers that need to register fault handler can register with iommu_set_fault_handler(). Reviewed-by: Grant Grundler Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 71 ++ 1 files

[PATCH v9 11/16] iommu/exynos: remove calls to Runtime PM API functions

2013-08-08 Thread Cho KyongHo
to exynos-iommu driver. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 20 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index e8f3e82..686e3c8 100644 --- a/drivers/iommu/exynos-iommu.c

[PATCH v9 06/16] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-08 Thread Cho KyongHo
Signed-off-by: Cho KyongHo --- .../bindings/iommu/samsung,exynos4210-sysmmu.txt | 103 +++ arch/arm/boot/dts/exynos4.dtsi | 122 arch/arm/boot/dts/exynos4210.dtsi | 25 ++ arch/arm/boot/dts/exynos4x12.dtsi | 82

[PATCH v9 08/16] iommu/exynos: gating clocks of master H/W

2013-08-08 Thread Cho KyongHo
is prohibited unless both of the gating clocks of System MMU and its master H/W. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 38 ++ 1 files changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos

[PATCH v9 09/16] iommu/exynos: remove prefetch buffer setting when enabling System MMU

2013-08-08 Thread Cho KyongHo
Prefetch buffer must be handled accurately, exact range of a buffer, frame by frame manually. Otherwise, it may causes page fault or deadlock in System MMU. Thus this patch removes prefetch buffer setting when System MMU is initialized(enabled). Signed-off-by: Cho KyongHo --- drivers/iommu

[PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-08 Thread Cho KyongHo
Since kmalloc() does not guarantee that the allignment of 1KiB when it allocates 1KiB, it is required to allocate lv2 page table from own slab that guarantees alignment of 1KiB Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 24 1 files changed, 20

[PATCH v9 07/16] iommu/exynos: support for device tree

2013-08-08 Thread Cho KyongHo
a single clock descriptor to make a device descriptor for a group of System MMUs. * removed dbgname member from sysmmu_drvdata structure. debugging kernel message for a System MMU is distinguisheable with the name of device descroptors. Signed-off-by: Cho KyongHo --- drivers/iommu/Kconfig

[PATCH v9 05/16] clk: exynos: add gate clock descriptions of System MMU

2013-08-08 Thread Cho KyongHo
This adds gate clocks of all System MMUs and their master IPs that are not apeared in clk-exynos5250.c Also fixes GATE_IP_ACP to 0x18800 and changed GATE_DA to GATE for System MMU clocks in clk-exynos4.c Signed-off-by: Cho KyongHo --- .../devicetree/bindings/clock/exynos5250-clock.txt | 26

[PATCH v9 02/16] iommu/exynos: add missing cache flush for removed page table entries

2013-08-08 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Tested-by: Grant Grundler Signed-off-by: Cho KyongHo --- drivers

[PATCH v9 01/16] iommu/exynos: do not include removed header

2013-08-08 Thread Cho KyongHo
This commit remove which is removed. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 3f32d64..233f382 100644 --- a/drivers/iommu/exynos

[PATCH v9 03/16] iommu/exynos: fix page table maintenance

2013-08-08 Thread Cho KyongHo
This prevents allocating lv2 page table for the lv1 page table entry that already has 1MB page mapping. In addition, changed to BUG_ON instead of returning -EADDRINUSE. Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 68 - 1 files changed

[PATCH v9 00/16] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-08-08 Thread Cho KyongHo
The current exynos-iommu(System MMU) driver does not work autonomously since it is lack of support for power management of peripheral blocks. For example, MFC device driver must ensure that its System MMU is disabled before MFC block is power-down not to invalidate IOTLB in the System MMU when I/O

[PATCH v9 00/16] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-08-08 Thread Cho KyongHo
The current exynos-iommu(System MMU) driver does not work autonomously since it is lack of support for power management of peripheral blocks. For example, MFC device driver must ensure that its System MMU is disabled before MFC block is power-down not to invalidate IOTLB in the System MMU when I/O

[PATCH v9 03/16] iommu/exynos: fix page table maintenance

2013-08-08 Thread Cho KyongHo
This prevents allocating lv2 page table for the lv1 page table entry that already has 1MB page mapping. In addition, changed to BUG_ON instead of returning -EADDRINUSE. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 68

[PATCH v9 01/16] iommu/exynos: do not include removed header

2013-08-08 Thread Cho KyongHo
This commit remove mach/sysmmu.h which is removed. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 3f32d64..233f382

[PATCH v9 02/16] iommu/exynos: add missing cache flush for removed page table entries

2013-08-08 Thread Cho KyongHo
This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Tested-by: Grant Grundler grund...@chromium.org Signed-off-by: Cho

[PATCH v9 05/16] clk: exynos: add gate clock descriptions of System MMU

2013-08-08 Thread Cho KyongHo
This adds gate clocks of all System MMUs and their master IPs that are not apeared in clk-exynos5250.c Also fixes GATE_IP_ACP to 0x18800 and changed GATE_DA to GATE for System MMU clocks in clk-exynos4.c Signed-off-by: Cho KyongHo pullip@samsung.com --- .../devicetree/bindings/clock

[PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-08 Thread Cho KyongHo
Since kmalloc() does not guarantee that the allignment of 1KiB when it allocates 1KiB, it is required to allocate lv2 page table from own slab that guarantees alignment of 1KiB Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 24 1

[PATCH v9 07/16] iommu/exynos: support for device tree

2013-08-08 Thread Cho KyongHo
a single clock descriptor to make a device descriptor for a group of System MMUs. * removed dbgname member from sysmmu_drvdata structure. debugging kernel message for a System MMU is distinguisheable with the name of device descroptors. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers

[PATCH v9 09/16] iommu/exynos: remove prefetch buffer setting when enabling System MMU

2013-08-08 Thread Cho KyongHo
Prefetch buffer must be handled accurately, exact range of a buffer, frame by frame manually. Otherwise, it may causes page fault or deadlock in System MMU. Thus this patch removes prefetch buffer setting when System MMU is initialized(enabled). Signed-off-by: Cho KyongHo pullip@samsung.com

[PATCH v9 06/16] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-08 Thread Cho KyongHo
Signed-off-by: Cho KyongHo pullip@samsung.com --- .../bindings/iommu/samsung,exynos4210-sysmmu.txt | 103 +++ arch/arm/boot/dts/exynos4.dtsi | 122 arch/arm/boot/dts/exynos4210.dtsi | 25 ++ arch/arm/boot/dts/exynos4x12.dtsi

[PATCH v9 08/16] iommu/exynos: gating clocks of master H/W

2013-08-08 Thread Cho KyongHo
is prohibited unless both of the gating clocks of System MMU and its master H/W. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 38 ++ 1 files changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b

[PATCH v9 12/16] iommu/exynos: add bus notifier for registering System MMU

2013-08-08 Thread Cho KyongHo
attached to iommu_domain is now master H/W. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 435 -- 1 files changed, 291 insertions(+), 144 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c

[PATCH v9 10/16] iommu/exynos: remove custom fault handler

2013-08-08 Thread Cho KyongHo
This commit removes custom fault handler. The device drivers that need to register fault handler can register with iommu_set_fault_handler(). Reviewed-by: Grant Grundler grund...@chromium.org Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 71

[PATCH v9 13/16] iommu/exynos: turn on useful configuration options

2013-08-08 Thread Cho KyongHo
master H/W's transaction. This new feature is enabled by default and QoS value written to MMU_CFG is ignored. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 20 +--- 1 files changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/iommu

[PATCH v9 11/16] iommu/exynos: remove calls to Runtime PM API functions

2013-08-08 Thread Cho KyongHo
to exynos-iommu driver. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 20 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index e8f3e82..686e3c8 100644

[PATCH v9 15/16] iommu/exynos: change rwlock to spinlock

2013-08-08 Thread Cho KyongHo
Since acquiring read_lock is not more frequent than write_lock, it is not beneficial to use rwlock, this commit changes rwlock to spinlock. Reviewed-by: Grant Grundler grund...@chromium.org Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 36

[PATCH v9 14/16] iommu/exynos: add support for power management subsystems.

2013-08-08 Thread Cho KyongHo
/O power domain, its driver must call iommu_attach_device() after its local power domain is turned on, iommu_detach_device before turned off. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 235 +- 1 files changed, 231

[PATCH v9 16/16] iommu/exynos: return 0 if iommu_attach_device() successes

2013-08-08 Thread Cho KyongHo
Grundler grund...@chromium.org Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 2d16fc0..d959e95 100644 --- a/drivers

Re: [PATCH v9 06/16] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 12:45:34 +0200, Sylwester Nawrocki wrote: Hi, On 08/08/2013 11:38 AM, Cho KyongHo wrote: How about something along the lines of: This patch adds dts entries for the SYSMMU devices found on Exynos4 and Exynos5 SoC series and the SYSMMU binding documentation

Re: [PATCH v9 05/16] clk: exynos: add gate clock descriptions of System MMU

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 13:40:13 +0200, Tomasz Figa wrote: On Thursday 08 of August 2013 13:17:34 Sylwester Nawrocki wrote: On 08/08/2013 11:38 AM, Cho KyongHo wrote: This adds gate clocks of all System MMUs and their master IPs that are not apeared in clk-exynos5250.c Also fixes

Re: [PATCH v9 00/16] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-08-08 Thread Cho KyongHo
. Best regards, Tomasz On Thursday 08 of August 2013 18:37:10 Cho KyongHo wrote: The current exynos-iommu(System MMU) driver does not work autonomously since it is lack of support for power management of peripheral blocks. For example, MFC device driver must ensure that its System MMU

Re: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 22:43:43 +0100, Will Deacon wrote: On Thu, Aug 08, 2013 at 10:38:10PM +0100, Tomasz Figa wrote: On Thursday 08 of August 2013 08:09:49 Rob Herring wrote: On Thu, Aug 1, 2013 at 8:05 AM, Cho KyongHo pullip@samsung.com wrote: Should this align with ARM System MMU

Re: [PATCH v9 02/16] iommu/exynos: add missing cache flush for removed page table entries

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 15:44:09 +0200, Tomasz Figa wrote: On Thursday 08 of August 2013 18:37:34 Cho KyongHo wrote: This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault

Re: [PATCH v9 01/16] iommu/exynos: do not include removed header

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 15:42:24 +0200, Tomasz Figa wrote: Hi KyongHo, On Thursday 08 of August 2013 18:37:25 Cho KyongHo wrote: This commit remove mach/sysmmu.h which is removed. I would prefer a more meaningful commit message, something among following lines: 8--- Commit 25e9d28d92

Re: [PATCH v9 03/16] iommu/exynos: fix page table maintenance

2013-08-08 Thread Cho KyongHo
On Thu, 08 Aug 2013 15:54:50 +0200, Tomasz Figa wrote: On Thursday 08 of August 2013 18:37:43 Cho KyongHo wrote: This prevents allocating lv2 page table for the lv1 page table entry ^ What this is this this about? :) As you might indicate, 'this' means this patch :) that already has 1MB

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-07 Thread Cho KyongHo
> -Original Message- > From: grund...@google.com [mailto:grund...@google.com] On Behalf Of Grant > Grundler > Sent: Thursday, August 08, 2013 1:21 AM > > On Wed, Aug 7, 2013 at 5:07 AM, Cho KyongHo wrote: > ... > >> I don't understand how this is

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-07 Thread Cho KyongHo
> -Original Message- > From: grund...@google.com [mailto:grund...@google.com] On Behalf Of Grant > Grundler > Sent: Wednesday, August 07, 2013 1:07 AM > To: Marek Szyprowski > > Hi Marek, > > On Tue, Aug 6, 2013 at 6:17 AM, Marek Szyprowski > wrote: > ... > > IMHO it is much better to

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-07 Thread Cho KyongHo
-Original Message- From: grund...@google.com [mailto:grund...@google.com] On Behalf Of Grant Grundler Sent: Wednesday, August 07, 2013 1:07 AM To: Marek Szyprowski Hi Marek, On Tue, Aug 6, 2013 at 6:17 AM, Marek Szyprowski m.szyprow...@samsung.com wrote: ... IMHO it is much

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-07 Thread Cho KyongHo
-Original Message- From: grund...@google.com [mailto:grund...@google.com] On Behalf Of Grant Grundler Sent: Thursday, August 08, 2013 1:21 AM On Wed, Aug 7, 2013 at 5:07 AM, Cho KyongHo pullip@samsung.com wrote: ... I don't understand how this is possible. Can someone

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-06 Thread Cho KyongHo
> -Original Message- > From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Monday, August 05, 2013 10:10 PM > > On Monday, August 05, 2013 08:16:40 PM Cho KyongHo wrote: > > > -Original Message- > > > From: Bartlomiej

RE: [PATCH] iommu/exynos: remove dead code (set_prefbuf)

2013-08-06 Thread Cho KyongHo
2013 at 9:08 AM, Grant Grundler wrote: > > exynos_sysmmu_set_prefbuf() is not called any where. > > > > Signed-off-by: Grant Grundler Reviewed-by: Cho KyongHo Thank you. KyongHo. > > --- > > drivers/iommu/exynos-iommu.c | 44 > > >

RE: [PATCH] iommu/exynos: remove dead code (set_prefbuf)

2013-08-06 Thread Cho KyongHo
: exynos_sysmmu_set_prefbuf() is not called any where. Signed-off-by: Grant Grundler grund...@chromium.org Reviewed-by: Cho KyongHo pullip@samsung.com Thank you. KyongHo. --- drivers/iommu/exynos-iommu.c | 44 1 file changed, 44 deletions

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-06 Thread Cho KyongHo
-Original Message- From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] Sent: Monday, August 05, 2013 10:10 PM On Monday, August 05, 2013 08:16:40 PM Cho KyongHo wrote: -Original Message- From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com

RE: [PATCH v8 10/12] iommu/exynos: add bus notifier for registering System MMU

2013-08-05 Thread Cho KyongHo
> -Original Message- > From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Saturday, August 03, 2013 2:32 AM > > Hi, > > On Friday, July 26, 2013 08:30:17 PM Cho KyongHo wrote: > > When a device driver is registered, all cons

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-05 Thread Cho KyongHo
> -Original Message- > From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Saturday, August 03, 2013 2:14 AM > > Hi, > > On Friday, July 26, 2013 08:28:19 PM Cho KyongHo wrote: > > Signed-off-by: Cho KyongHo > > --- > >

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-05 Thread Cho KyongHo
-Original Message- From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] Sent: Saturday, August 03, 2013 2:14 AM Hi, On Friday, July 26, 2013 08:28:19 PM Cho KyongHo wrote: Signed-off-by: Cho KyongHo pullip@samsung.com --- .../bindings/iommu/samsung

RE: [PATCH v8 10/12] iommu/exynos: add bus notifier for registering System MMU

2013-08-05 Thread Cho KyongHo
-Original Message- From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] Sent: Saturday, August 03, 2013 2:32 AM Hi, On Friday, July 26, 2013 08:30:17 PM Cho KyongHo wrote: When a device driver is registered, all constructs to handle System MMU is prepared by bus

RE: [PATCH v8 10/12] iommu/exynos: add bus notifier for registering System MMU

2013-08-02 Thread Cho KyongHo
> -Original Message- > From: Rahul Sharma [mailto:r.sh.o...@gmail.com] > Sent: Friday, August 02, 2013 2:18 PM > > Hi Cho, > > On Fri, Jul 26, 2013 at 5:00 PM, Cho KyongHo wrote: > > When a device driver is registered, all constructs to handle System MMU >

RE: [PATCH v8 10/12] iommu/exynos: add bus notifier for registering System MMU

2013-08-02 Thread Cho KyongHo
-Original Message- From: Rahul Sharma [mailto:r.sh.o...@gmail.com] Sent: Friday, August 02, 2013 2:18 PM Hi Cho, On Fri, Jul 26, 2013 at 5:00 PM, Cho KyongHo pullip@samsung.com wrote: When a device driver is registered, all constructs to handle System MMU is prepared

RE: [PATCH v8 07/12] iommu/exynos: support for device tree

2013-08-01 Thread Cho KyongHo
> -Original Message- > From: Tomasz Figa [mailto:tomasz.f...@gmail.com] > Sent: Saturday, July 27, 2013 11:07 PM > > Hi, > > On Friday 26 of July 2013 20:28:36 Cho KyongHo wrote: > > This commit adds device tree support for System MMU. > > This a

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-01 Thread Cho KyongHo
> -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Monday, July 29, 2013 5:05 PM > > On 29 July 2013 13:27, Cho KyongHo wrote: > >> -Original Message- > >> From: Cho KyongHo [mailto:pullip@samsung.com] > &g

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-01 Thread Cho KyongHo
> -Original Message- > From: Rob Herring [mailto:robherri...@gmail.com] > Sent: Saturday, July 27, 2013 10:55 PM > On Fri, Jul 26, 2013 at 6:28 AM, Cho KyongHo wrote: > > Signed-off-by: Cho KyongHo > > --- > > .../bindings/iommu/samsung,exynos4210-sysmmu.

RE: RE: [PATCH v8 05/12] clk: exynos5250: add gate clock descriptions of System MMU

2013-08-01 Thread Cho KyongHo
> -Original Message- > From: Rahul Sharma [mailto:r.sh.o...@gmail.com] > Sent: Thursday, August 01, 2013 7:22 PM > > Hi Cho, > > On Tue, Jul 30, 2013 at 4:47 PM, Cho KyongHo wrote: > >> -Original Message- > >> From: Mike Turquette [

RE: RE: [PATCH v8 05/12] clk: exynos5250: add gate clock descriptions of System MMU

2013-08-01 Thread Cho KyongHo
-Original Message- From: Rahul Sharma [mailto:r.sh.o...@gmail.com] Sent: Thursday, August 01, 2013 7:22 PM Hi Cho, On Tue, Jul 30, 2013 at 4:47 PM, Cho KyongHo pullip@samsung.com wrote: -Original Message- From: Mike Turquette [mailto:mturque...@linaro.org] Sent

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-01 Thread Cho KyongHo
-Original Message- From: Rob Herring [mailto:robherri...@gmail.com] Sent: Saturday, July 27, 2013 10:55 PM On Fri, Jul 26, 2013 at 6:28 AM, Cho KyongHo pullip@samsung.com wrote: Signed-off-by: Cho KyongHo pullip@samsung.com --- .../bindings/iommu/samsung,exynos4210

RE: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-08-01 Thread Cho KyongHo
-Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: Monday, July 29, 2013 5:05 PM On 29 July 2013 13:27, Cho KyongHo pullip@samsung.com wrote: -Original Message- From: Cho KyongHo [mailto:pullip@samsung.com] Sent: Monday, July 29, 2013 4

RE: [PATCH v8 07/12] iommu/exynos: support for device tree

2013-08-01 Thread Cho KyongHo
-Original Message- From: Tomasz Figa [mailto:tomasz.f...@gmail.com] Sent: Saturday, July 27, 2013 11:07 PM Hi, On Friday 26 of July 2013 20:28:36 Cho KyongHo wrote: This commit adds device tree support for System MMU. This also include the following changes and enhancements

<    1   2   3   4   5   6   >