[PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-14 Thread Chris Chiu
connects to touchpad interrupt is in ACPI mode after resume and no longer work as IRQ. Fix this by saving HOSTSW_OWN register during suspend and restore them at resume. Signed-off-by: Chris Chiu --- drivers/pinctrl/intel/pinctrl-intel.c | 22 +- 1 file changed, 21 insertions

Built in PS2 keyboard in new ASUS/acer laptops can not wake up system after s2idle

2018-08-03 Thread Chris Chiu
Hi guys, We have some new laptops with Intel new Intel WiskyLake CPU come in and they all have the same problem. They all have the so-called "Modern Standby" feature which is s2idle in Linux. The problem is the built-in keyboard no longer wake up the system after it goes to s2idle. Only th

Re: Built in PS2 keyboard in new ASUS/acer laptops can not wake up system after s2idle

2018-08-06 Thread Chris Chiu
On Mon, Aug 6, 2018 at 5:37 PM, Rafael J. Wysocki wrote: > On Friday, August 3, 2018 10:04:09 AM CEST Chris Chiu wrote: >> Hi guys, >> We have some new laptops with Intel new Intel WiskyLake CPU come >> in and they all have the same problem. They all have the so-call

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-06-20 Thread Chris Chiu
On Wed, Jun 20, 2018 at 12:46 AM, Daniel Drake wrote: > Hi, > > On Thu, Jun 14, 2018 at 1:58 AM, Chris Chiu wrote: >> >> On Wed, Jun 13, 2018 at 8:49 PM, Andy Shevchenko >> wrote: >> > On Mon, Jun 11, 2018 at 10:18 AM, Chris Chiu wrote: >> >&g

[PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-06-20 Thread Chris Chiu
led_classdev_notify_brightness_hw_changed. This will allow userspace to monitor (poll) for brightness changes on the LED without reporting via input keymapping. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a

[PATCH v3 2/2] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-06-20 Thread Chris Chiu
brightness for each keypress, then toggle(off) the LED when it already reached the max level. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index

Re: r8169 take too long to complete driver initialization

2018-01-30 Thread Chris Chiu
ing for incorrect register bit? Can you help work out a patch for this? Chris >> -Original Message- >> From: Chris Chiu [mailto:c...@endlessm.com] >> Sent: Monday, January 29, 2018 6:12 PM >> To: nic_swsd ; net...@vger.kernel.org; Linux >> Kernel ; Linux Upstreaming

Re: r8169 take too long to complete driver initialization

2018-01-04 Thread Chris Chiu
On Wed, Dec 20, 2017 at 4:41 PM, Chris Chiu wrote: > Hi, > We've hit a suspend/resume issue on a Acer desktop caused by r8169 > driver. The dmseg > https://gist.github.com/mschiu77/b741849b5070281daaead8dfee312d1a > shows it's still in msleep() within a mutex lock.

Re: r8169 take too long to complete driver initialization

2018-01-29 Thread Chris Chiu
On Fri, Jan 5, 2018 at 10:17 AM, Chris Chiu wrote: > On Wed, Dec 20, 2017 at 4:41 PM, Chris Chiu wrote: >> Hi, >> We've hit a suspend/resume issue on a Acer desktop caused by r8169 >> driver. The dmseg >> https://gist.github.com/mschiu77/b741849b5070281daaea

[PATCH] HID: input: support Microsoft wireless radio control hotkey

2018-11-29 Thread Chris Chiu
's easy to add the HID I2C vendor and product id to the quirk list and apply HID_QUIRK_HIDINPUT_FORCE to make it work. But it can be more generic to support such kind of application on PC. Signed-off-by: Chris Chiu --- include/linux/hid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH] HID: input: support Microsoft wireless radio control hotkey

2018-12-04 Thread Chris Chiu
On Fri, Nov 30, 2018 at 7:18 PM Benjamin Tissoires wrote: > > On Fri, Nov 30, 2018 at 7:46 AM Chris Chiu wrote: > > > > The ASUS laptops start to support the airplane mode radio management > > to replace the original machanism of airplane mode toggle hotkey. > > On

Re: [PATCH] HID: input: support Microsoft wireless radio control hotkey

2018-12-06 Thread Chris Chiu
On Wed, Dec 5, 2018 at 8:56 AM Chris Chiu wrote: > > On Fri, Nov 30, 2018 at 7:18 PM Benjamin Tissoires > wrote: > > > > On Fri, Nov 30, 2018 at 7:46 AM Chris Chiu wrote: > > > > > > The ASUS laptops start to support the airplane mode radio management >

[PATCH 1/2] HID: use macros in IS_INPUT_APPLICATION

2018-12-02 Thread Chris Chiu
Add missing definition for HID_DG_WHITEBOARD then replace the hid usage hex with macros for better readibility. Signed-off-by: Chris Chiu --- include/linux/hid.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/linux/hid.h b/include/linux/hid.h index a355d61940f2

[PATCH 2/2] HID: input: support Microsoft wireless radio control hotkey

2018-12-02 Thread Chris Chiu
easy to add the HID I2C vendor and product id to the quirk list and apply HID_QUIRK_HIDINPUT_FORCE to make it work. But it makes more sense to support it as a generic input application. Signed-off-by: Chris Chiu --- include/linux/hid.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-06-27 Thread Chris Chiu
On Wed, Jun 20, 2018 at 10:46 PM, Chris Chiu wrote: > Make asus-wmi notify on hotkey kbd brightness changes, listen for > brightness events and update the brightness directly in the driver. > Create new do_kbd_led_set function for in-driver update, and leave > kbd_led_set

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-06-19 Thread Chris Chiu
On Thu, Jun 14, 2018 at 2:58 PM, Chris Chiu wrote: > On Wed, Jun 13, 2018 at 8:49 PM, Andy Shevchenko > wrote: >> On Mon, Jun 11, 2018 at 10:18 AM, Chris Chiu wrote: >>> Make asus-wmi notify on hotkey kbd brightness changes, listen for >>> brightness events and upd

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-06-13 Thread Chris Chiu
On Mon, Jun 11, 2018 at 3:18 PM, Chris Chiu wrote: > Make asus-wmi notify on hotkey kbd brightness changes, listen for > brightness events and update the brightness directly in the driver. > For this purpose, bound check on brightness in kbd_led_set must be > based on the same

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-06-13 Thread Chris Chiu
On Wed, Jun 13, 2018 at 8:49 PM, Andy Shevchenko wrote: > On Mon, Jun 11, 2018 at 10:18 AM, Chris Chiu wrote: >> Make asus-wmi notify on hotkey kbd brightness changes, listen for >> brightness events and update the brightness directly in the driver. > >> For this

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-17 Thread Chris Chiu
On Thu, May 17, 2018 at 3:48 PM, Jarkko Nikula wrote: > Hi > > On 05/15/2018 01:20 PM, Jarkko Nikula wrote: >> >> On 05/15/2018 06:22 AM, Chris Chiu wrote: >>> >>> What if I change the 120MHz to 180MHz and then make sure that the I2C >>> operates

Re: [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-08-15 Thread Chris Chiu
On Mon, Jul 2, 2018 at 8:10 PM, Andy Shevchenko wrote: > On Wed, Jun 27, 2018 at 1:27 PM, Chris Chiu wrote: >> On Wed, Jun 20, 2018 at 10:46 PM, Chris Chiu wrote: >>> Make asus-wmi notify on hotkey kbd brightness changes, listen for >>> brightness events and update

Re: [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-08-15 Thread Chris Chiu
On Wed, Aug 15, 2018 at 5:45 PM, Andy Shevchenko wrote: > On Wed, Aug 15, 2018 at 12:34 PM, Chris Chiu wrote: >> On Mon, Jul 2, 2018 at 8:10 PM, Andy Shevchenko >> wrote: >>> On Wed, Jun 27, 2018 at 1:27 PM, Chris Chiu wrote: >>>> On Wed, Jun 20, 2018 at 10:

Keyboard lost after exit s2idle on ASUS UX433FN

2018-08-15 Thread Chris Chiu
Hi, We recently hit a weird problem on the ASUS laptop UX433FN with latest Intel Core i7-8565U CPU on kernel 4.18. The keyboard stops functioning after exit s2idle. It stops firing interrupts after resume on any keypress. We thought it should be something wrong with i8042 driver or even atkbd d

Re: Keyboard lost after exit s2idle on ASUS UX433FN

2018-08-16 Thread Chris Chiu
On Thu, Aug 16, 2018 at 3:26 PM, Rafael J. Wysocki wrote: > On Thu, Aug 16, 2018 at 4:45 AM Chris Chiu wrote: >> >> Hi, >> We recently hit a weird problem on the ASUS laptop UX433FN with >> latest Intel Core i7-8565U CPU on kernel 4.18. The keyboard stops >>

Re: Keyboard lost after exit s2idle on ASUS UX433FN

2018-08-16 Thread Chris Chiu
On Thu, Aug 16, 2018 at 4:54 PM, Rafael J. Wysocki wrote: > On Thu, Aug 16, 2018 at 10:18 AM Chris Chiu wrote: >> >> On Thu, Aug 16, 2018 at 3:26 PM, Rafael J. Wysocki wrote: >> > On Thu, Aug 16, 2018 at 4:45 AM Chris Chiu wrote: >> >> >> >> Hi,

A weird problem of Realtek r8168 after resume from S3

2018-12-12 Thread Chris Chiu
Hi, We got an acer laptop which has a problem with ethernet networking after resuming from S3. The ethernet is popular realtek r8168. The lspci shows as follows. 02:00.1 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller [10ec:8

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-13 Thread Chris Chiu
On Thu, Dec 13, 2018 at 10:20 AM Chris Chiu wrote: > > Hi, > We got an acer laptop which has a problem with ethernet networking after > resuming from S3. The ethernet is popular realtek r8168. The lspci shows as > follows. > 02:00.1 Ethernet controller [0200]: Realtek Semi

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-18 Thread Chris Chiu
On Tue, Dec 18, 2018 at 5:45 AM Heiner Kallweit wrote: > > On 17.12.2018 14:25, Chris Chiu wrote: > > On Fri, Dec 14, 2018 at 3:37 PM Heiner Kallweit > > wrote: > >> > >> On 14.12.2018 04:33, Chris Chiu wrote: > >>> On Thu, Dec 13, 2018

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-18 Thread Chris Chiu
On Tue, Dec 18, 2018 at 3:08 AM Heiner Kallweit wrote: > > On 17.12.2018 14:25, Chris Chiu wrote: > > On Fri, Dec 14, 2018 at 3:37 PM Heiner Kallweit > > wrote: > >> > >> On 14.12.2018 04:33, Chris Chiu wrote: > >>> On Thu, Dec 13, 2018

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-19 Thread Chris Chiu
On Wed, Dec 19, 2018 at 2:22 AM Heiner Kallweit wrote: > > On 18.12.2018 14:25, Chris Chiu wrote: > > On Tue, Dec 18, 2018 at 3:08 AM Heiner Kallweit > > wrote: > >> > >> On 17.12.2018 14:25, Chris Chiu wrote: > >>> On Fri, Dec 14, 2018 at 3:37 PM

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-19 Thread Chris Chiu
On Wed, Dec 19, 2018 at 4:28 AM Heiner Kallweit wrote: > > On 18.12.2018 14:25, Chris Chiu wrote: > > On Tue, Dec 18, 2018 at 3:08 AM Heiner Kallweit > > wrote: > >> > >> On 17.12.2018 14:25, Chris Chiu wrote: > >>> On Fri, Dec 14, 2018 at 3:37 PM

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-17 Thread Chris Chiu
On Fri, Dec 14, 2018 at 3:37 PM Heiner Kallweit wrote: > > On 14.12.2018 04:33, Chris Chiu wrote: > > On Thu, Dec 13, 2018 at 10:20 AM Chris Chiu wrote: > >> > >> Hi, > >> We got an acer laptop which has a problem with ethernet networking > >&

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-20 Thread Chris Chiu
On Thu, Dec 20, 2018 at 3:41 AM Heiner Kallweit wrote: > > On 19.12.2018 16:32, Chris Chiu wrote: > > On Wed, Dec 19, 2018 at 4:28 AM Heiner Kallweit > > wrote: > >> > >> On 18.12.2018 14:25, Chris Chiu wrote: > >>> On Tue, Dec 18, 2018 at 3:08 AM

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-21 Thread Chris Chiu
On Fri, Dec 21, 2018 at 3:22 AM Heiner Kallweit wrote: > > On 20.12.2018 10:43, Chris Chiu wrote: > > On Thu, Dec 20, 2018 at 3:41 AM Heiner Kallweit > > wrote: > >> > >> On 19.12.2018 16:32, Chris Chiu wrote: > >>> On Wed, Dec 19, 2018 at 4:28 AM

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-20 Thread Chris Chiu
On Tue, Apr 20, 2021 at 11:28 PM Alan Stern wrote: > > On Tue, Apr 20, 2021 at 03:14:56PM +0800, Chris Chiu wrote: > > On Mon, Apr 19, 2021 at 10:19 PM Alan Stern > > wrote: > > > > > > On Mon, Apr 19, 2021 at 01:11:38AM -0400, Chris Chiu wrote: > > &g

[PATCH] USB: Add reset-resume quirk for WD19's Realtek Hub

2021-04-20 Thread chris . chiu
From: Chris Chiu Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work after the system resumes from suspend with remote wakeup enabled device connected: [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-05-22 Thread Chris Chiu
On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko wrote: > On Tue, May 15, 2018 at 4:41 PM, Benjamin Berg wrote: > >> I had a quick chat with Bastien about this. The conclusion was that >> reusing the TOGGLE key may be problematic for gnome-settings-daemon. >> And the alternative of a new CYCLE ke

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-05-24 Thread Chris Chiu
On Tue, May 22, 2018 at 9:48 PM, Daniel Drake wrote: > On Tue, May 22, 2018 at 4:11 AM, Chris Chiu wrote: >> On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko >>> Btw, I mistakenly thought that patch in the queue for-next, while it's >>> not. So, I'm goin

[PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-05-01 Thread Chris Chiu
KEY_KBDILLUMUP to increment the brightness, then pass KEY_KBDILLUMTOGGLE to user space after the brightness max been reached for switching the led off. https://phabricator.endlessm.com/T21390 Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-nb-wmi.c | 1 + drivers/platform/x86/asus-wmi.c

Re: [PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-05-02 Thread Chris Chiu
On Wed, May 2, 2018 at 10:29 PM, Puma D. wrote: > On 02.05.2018 08:02, Chris Chiu wrote: >> >> Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard >> backlight toggle. In this UX550GE, the hotkey incremet the level >> of brightness for each keypress from

[PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-05-02 Thread Chris Chiu
KEY_KBDILLUMUP to increment the brightness, then pass KEY_KBDILLUMTOGGLE to user space after the brightness max been reached for switching the led off. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan Tested-by: Jian-Hong Pan --- Notes: v2: - Remove redundant 'else' br

[PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-04 Thread Chris Chiu
led_classdev_notify_brightness_hw_changed. This will allow userspace to monitor (poll) for brightness changes on the LED without reporting via input keymapping. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-nb-wmi.c | 2 -- drivers/platform/x86/asus-wmi.c| 21 +++-- 2 files

[PATCH 2/2] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-06-04 Thread Chris Chiu
brightness for each keypress, then toggle(off) the LED when it already reached the max level. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-04 Thread Chris Chiu
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart wrote: > On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote: >> Hi, >> >> On 04-06-18 15:51, Daniel Drake wrote: >> > On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote: >> > > Is this really a case of the hardware itself processing the >>

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-05 Thread Chris Chiu
On Tue, Jun 5, 2018 at 7:06 PM, Hans de Goede wrote: > Hi, > > > On 05-06-18 12:46, Benjamin Berg wrote: >> >> Hey, >> >> On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote: >>> >>> On 05-06-18 12:14, Bastien Nocera wrote: On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote: >

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-14 Thread Chris Chiu
On Mon, May 14, 2018 at 10:20 PM, Jarkko Nikula wrote: > On 05/10/2018 03:03 PM, Chris Chiu wrote: >> >> Report from guys who can access scope. If i2c-sda-falling-time-ns=400ns >> , HCNT increase to 117, the SCL high duration is 576ns as follows >> https://pasteboa

[PATCH] platform/x86: asus-wmi: Add fn-lock mode switch support

2019-04-17 Thread Chris Chiu
. Because there's no way to retrieve the fn-lock mode via existing WMI methods per ASUS spec, driver need to initialize and keep the fn-lock mode by itself. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c| 36 ++ include/linux/platform_data/x86

Re: [PATCH] platform/x86: asus-wmi: Add fn-lock mode switch support

2019-04-23 Thread Chris Chiu
On Thu, Apr 18, 2019 at 2:46 PM Chris Chiu wrote: > > Some of latest ASUS laptops support new fn-lock mode switching. > This commit detect whether if the fn-lock option is enabled in > BIOS setting, and toggle the fn-lock mode via a new WMI DEVID > 0x00100023 when the correspond

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2019-03-28 Thread Chris Chiu
On Thu, Mar 28, 2019 at 5:38 PM Daniel Drake wrote: > > On Thu, Mar 28, 2019 at 5:17 PM Andy Shevchenko > wrote: > > Hmm... Can you confirm that laptop you declared as a fixed case and the > > mentioned here is the same one? > > They are definitely not the same exact unit - originally we had a >

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2019-04-01 Thread Chris Chiu
On Mon, Apr 1, 2019 at 8:23 PM Andy Shevchenko wrote: > > On Mon, Apr 01, 2019 at 06:41:57PM +0800, Chris Chiu wrote: > > Thanks for the patch. > My comments below. > > > diff --git a/drivers/pinctrl/intel/pinctrl-intel.c > > b/drivers/pinctrl/intel/pinctrl-

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2019-04-03 Thread Chris Chiu
On Tue, Apr 2, 2019 at 7:58 PM Andy Shevchenko wrote: > > + base = community->regs + community->hostown_offset; > > + for (gpp = 0; gpp < community->ngpps; gpp++) { > > + if (communities[i].hostown[gpp] && > > + communitie

[PATCH v2] pinctrl:intel: Retain HOSTSW_OWN for requested gpio pin

2019-04-08 Thread Chris Chiu
pinctrl. After system resumes, the GPIO is in ACPI mode and no longer works as an IRQ. This commit saves the HOSTSW_OWN value during suspend, make sure the HOSTSW_OWN mode remains the same after resume. Signed-off-by: Chris Chiu --- Note: v2: update hostown and show pr_info only when the host mode

[PATCH] ALSA: hda/realtek: Enable MICs of Acer SWIFT with ALC256

2021-02-25 Thread Chris Chiu
The Acer SWIFT Swift SF314-54/55 with ALC256 cannot detect the headset microphone and suffers the noise problem in audio capture. This patch enables the headset jack sense and fixes the noise problem with aamix fixup. Signed-off-by: Chris Chiu --- sound/pci/hda/patch_realtek.c | 20

Re: [PATCH] ALSA: hda/realtek: Enable MICs of Acer SWIFT with ALC256

2021-02-25 Thread Chris Chiu
On Thu, Feb 25, 2021 at 5:32 PM Takashi Iwai wrote: > > On Thu, 25 Feb 2021 10:21:07 +0100, > Chris Chiu wrote: > > > > The Acer SWIFT Swift SF314-54/55 with ALC256 cannot detect the headset > > microphone and suffers the noise problem in audio capture. > > > &

[PATCH v2] ALSA: hda/realtek: Enable headset mic of Acer SWIFT with ALC256

2021-02-25 Thread chris . chiu
From: Chris Chiu The Acer SWIFT Swift SF314-54/55 laptops with ALC256 cannot detect both the headset mic and the internal mic. Introduce new fixup to enable the jack sense and the headset mic. However, the internal mic actually connects to Intel SST audio. It still needs Intel SST support to

[PATCH v2] ALSA: hda/realtek: Enable headset mic of Acer SWIFT with ALC256

2021-02-25 Thread chris . chiu
From: Chris Chiu The Acer SWIFT Swift SF314-54/55 laptops with ALC256 cannot detect both the headset mic and the internal mic. Introduce new fixup to enable the jack sense and the headset mic. However, the internal mic actually connects to Intel SST audio. It still needs Intel SST support to

Re: [PATCH v2] ALSA: hda/realtek: Enable headset mic of Acer SWIFT with ALC256

2021-02-25 Thread Chris Chiu
On Fri, Feb 26, 2021 at 10:06 AM Jian-Hong Pan wrote: > > 於 2021年2月26日 週五 上午9:04寫道: > > > > From: Chris Chiu > > > > The Acer SWIFT Swift SF314-54/55 laptops with ALC256 cannot detect > > both the headset mic and the internal mic. Introduce new fixup > >

asus-wmi fails to load on new ASUS laptop UX325JA

2020-05-21 Thread Chris Chiu
Hi, I have the ASUS new laptop UX325JA and most of the media keys are not working even with the latest kernel (5.7.0-rc5+). Looking into the dmesg log, the ASUS WMI driver fails to load because of [7.827241] asus-nb-wmi: probe of asus-nb-wmi failed with error -5. Before this message, t

[PATCH v3 4/4] ASoC: rt5645: Enable internal microphone and JD on ECS EF20

2021-01-10 Thread Chris Chiu
On ECS EF20 series laptops, the internal mic is on DMIC2/IN2P. And they need the inv_hp_det to make jack detection to work as exoected. Signed-off-by: Chris Chiu --- v2 -> v3: - restore the terminator {} of the dmi_platform_data[] v1 -> v2: - none sound/soc/codecs/rt

[PATCH v3 0/4] ASoC: rt5645: Enable internal mic and headset on ECS EF20

2021-01-10 Thread Chris Chiu
the dmi_platform_data[]. v1 -> v2: Invoke callback() of the DMI quirk if it exists, because the dmi_first_match() doesn't. --- Chris Chiu (4): ASoC: rt5645: Introduce mapping for ACPI-defined GPIO ASoC: rt5645: Add ACPI-defined GPIO for ECS EF20 series ASoC: rt5645: add inv_

[PATCH v3 3/4] ASoC: rt5645: add inv_hp_det flag

2021-01-10 Thread Chris Chiu
ge () {"hp-detect-gpio", Package() {^RTK2, 0, 0, 1 }}, } }) This flag will invert the hp-detect gpio polarity. Signed-off-by: Chris Chiu --- v2 -> v3: - none v1 -> v2: - none include/sound/rt5645.h| 2 ++ sound/soc/codecs/rt5645.c | 4 2 files chan

[PATCH v3 2/4] ASoC: rt5645: Add ACPI-defined GPIO for ECS EF20 series

2021-01-10 Thread Chris Chiu
"\\_SB.GPO3", 0x00, ResourceConsumer, , ) { // Pin list 0x004F } }) Return (SBUF) /* \_SB_.PCI0.I2C2.RTK2._CRS.SBUF */ } Signed-off-by: Chris Chiu --- v2 -> v3: - restore the terminator {} of the dmi_platform_data[] v1 ->

[PATCH v3 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2021-01-10 Thread Chris Chiu
On at least one laptop (ECS EF20EA) the 'hp-detect' GPIO is defined in the DSDT table by the ACPI GpioIo resources in _CRS. The GPIO related information should be mapped to the rt5645 driver to enable the jack detection also on non-DT platforms. Signed-off-by: Chris Chiu ---

[PATCH 1/2] ALSA: hda/realtek: Apply jack fixup for Quanta NL3

2020-12-22 Thread Chris Chiu
output. The ALC269_FIXUP_LIFEBOOK chained with ALC269_FIXUP_QUANTA_MUTE can help to differentiate 2 jacks and get the 'Auto-Mute Mode' working correctly. Signed-off-by: Chris Chiu --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_r

[PATCH 2/2] ALSA/hda: apply jack fixup for the Acer Veriton N4640G/N6640G/N2510G

2020-12-22 Thread Chris Chiu
OK to have all audio jacks to work as expected. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index bb1010d78717..9eb43d827bda 100644 --- a

Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirks for DeeQ X5-Z8300

2020-12-22 Thread Chris Chiu
On Wed, Dec 16, 2020 at 12:18 PM Chris Chiu wrote: > > DeeQ X5-Z8300 is a laptop empowered by Intel Atom Cherry Trail. Add > quirks to select the correct input map, jack-detect options to enable > jack sensing and internal/headset microphones. > > Signed-off-by: Chris Chiu

Re: [PATCH] HID: Add Wireless Radio Control feature for Chicony devices

2020-12-22 Thread Chris Chiu
On Tue, Dec 22, 2020 at 3:41 PM Jian-Hong Pan wrote: > > Some Chicony's keyboards support airplane mode hotkey (Fn+F2) with > "Wireless Radio Control" feature. For example, the wireless keyboard > [04f2:1236] shipped with ASUS all-in-one desktop. > > After consulting Chicony for this hotkey, learn

Re: [PATCH] ALSA: hda/realtek - Add support for Memeza EDL03 headset mic

2020-12-07 Thread Chris Chiu
On Mon, Dec 7, 2020 at 4:38 PM Takashi Iwai wrote: > > On Mon, 07 Dec 2020 08:33:46 +0100, > Chris Chiu wrote: > > > > The Memeza laptop EDL03 with codec ALC256 can't detect the headset > > microphone. The headphone jack sensing works after we ad

[PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for ARCHOS Cesium 140

2020-12-07 Thread Chris Chiu
for jack-detect. Signed-off-by: Chris Chiu --- sound/soc/intel/boards/bytcr_rt5640.c | 12 1 file changed, 12 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c index f790514a147d..cd6f7caa43c8 100644 --- a/sound/soc/intel

[PATCH] x86/platform: classmate-laptop: add WiFi media button

2020-12-07 Thread Chris Chiu
From: Carlo Caione The WiFi media button on the Quanta NL3 reports keycodes 0x8b and 0x9b to the platform driver. Add the mapping to support these codes. Signed-off-by: Carlo Caione Reviewed-by: Chris Chiu --- drivers/platform/x86/classmate-laptop.c | 2 ++ 1 file changed, 2 insertions

Re: [PATCH 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2021-01-07 Thread Chris Chiu
On Thu, Jan 7, 2021 at 10:28 PM Mark Brown wrote: > > On Thu, Jan 07, 2021 at 05:06:22PM +0800, Chris Chiu wrote: > > > +static const struct acpi_gpio_mapping *cht_rt5645_gpios; > > + > > You're adding a read only static variable with no way to set it. This > d

[PATCH] ALSA: hda/realtek - Limit int mic boost on Acer Aspire E5-575T

2021-01-14 Thread Chris Chiu
Acer Aspire E5-575T. Signed-off-by: Chris Chiu --- sound/pci/hda/patch_realtek.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3c1d2a3fb1a4..60eb8383a704 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci

[PATCH] mailmap: update the email address for Chris Chiu

2021-03-25 Thread chris . chiu
From: Chris Chiu Redirect my older email addresses in the git logs. Signed-off-by: Chris Chiu --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index 85b93cdefc87..1f8579db5a3f 100644 --- a/.mailmap +++ b/.mailmap @@ -65,6 +65,8 @@ Changbin Du Changbin

[PATCH] block: clear GD_NEED_PART_SCAN later in bdev_disk_changed

2021-03-23 Thread chris . chiu
From: Chris Chiu The GD_NEED_PART_SCAN is set by bdev_check_media_change to initiate a partition scan while removing a block device. It should be cleared after blk_drop_paritions because blk_drop_paritions could return -EBUSY and then the consequence __blkdev_get has no chance to do

[PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-15 Thread chris . chiu
From: Chris Chiu Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work after the system resumes from suspend with remote wakeup enabled device connected: [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-15 Thread Chris Chiu
On Thu, Apr 15, 2021 at 8:32 PM Greg KH wrote: > > On Thu, Apr 15, 2021 at 07:48:56PM +0800, chris.c...@canonical.com wrote: > > From: Chris Chiu > > > > Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work > > after the system resumes from susp

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-15 Thread Chris Chiu
On Fri, Apr 16, 2021 at 2:46 AM Alan Stern wrote: > > On Fri, Apr 16, 2021 at 12:13:43AM +0800, Chris Chiu wrote: > > One thing worth mentioning here, I never hit the hub_ext_port_status -71 > > problem if I resume by waking up from the keyboard connected to the hub. >

[PATCH] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-12 Thread chris . chiu
From: Chris Chiu Realtek Hub (0bda:5413) in Dell Dock WD19 sometimes fails to work after the system resumes from suspend with remote wakeup enabled device connected: [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71

Re: [PATCH] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-13 Thread Chris Chiu
On Mon, Apr 12, 2021 at 11:12 PM Alan Stern wrote: > > On Mon, Apr 12, 2021 at 11:00:06PM +0800, chris.c...@canonical.com wrote: > > From: Chris Chiu > > > > Realtek Hub (0bda:5413) in Dell Dock WD19 sometimes fails to work > > after the system resumes from susp

[PATCH v2] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-13 Thread chris . chiu
From: Chris Chiu Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work after the system resumes from suspend with remote wakeup enabled device connected: [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71

Re: [PATCH] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-13 Thread Chris Chiu
On Tue, Apr 13, 2021 at 10:44 PM Alan Stern wrote: > > On Tue, Apr 13, 2021 at 03:52:14PM +0800, Chris Chiu wrote: > > On Mon, Apr 12, 2021 at 11:12 PM Alan Stern > > wrote: > > > > > > On Mon, Apr 12, 2021 at 11:00:06PM +0800, chris.c...@canonical.com wrot

Re: [PATCH] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-14 Thread Chris Chiu
On Wed, Apr 14, 2021 at 10:32 PM Alan Stern wrote: > > On Wed, Apr 14, 2021 at 01:07:43PM +0800, Chris Chiu wrote: > > Thanks for the instructions. I can hit the same timeout problem with > > runtime PM. The > > fail rate seems the same as normal PM. (around 1/4 ~ 1/7

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-18 Thread Chris Chiu
On Fri, Apr 16, 2021 at 11:39 AM Alan Stern wrote: > > On Fri, Apr 16, 2021 at 09:24:30AM +0800, Chris Chiu wrote: > > On Fri, Apr 16, 2021 at 2:46 AM Alan Stern > > wrote: > > > > > > On Fri, Apr 16, 2021 at 12:13:43AM +0800, Chris Chiu wrote: > > &g

Broadcom 9460 raid card takes too long at system resuming

2021-04-19 Thread Chris Chiu
Hi, We found that the Broadcom 9460 RAID card will take ~40 seconds in megasas_resume. It is mainly waiting for the FW to come to ready state, please refer to the following kernel log. The FW version is "megasas: 07.714.04.00-rc1". It seems that the megasas_transition_to_ready() loop costs ~40

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-20 Thread Chris Chiu
On Mon, Apr 19, 2021 at 10:19 PM Alan Stern wrote: > > On Mon, Apr 19, 2021 at 01:11:38AM -0400, Chris Chiu wrote: > > Sorry that I didn't make myself clear. I found that if I applied > > RESET_RESUME > > quirk on the problematic hub, the Set-Port-Feature(suspend)

[PATCH] power: supply: axp288_fuel_gauge: Add the ECS EF20EA to the blacklist

2020-12-08 Thread Chris Chiu
The ECS EF20EA laptop ships an AXP288 but it is actually using a different, separate FG chip for AC and battery monitoring. On this laptop we need to keep using the regular ACPI driver and disable the AXP288 FG to avoid reporting two batteries to userspace. Signed-off-by: Chris Chiu --- drivers

[PATCH] ALSA: hda/realtek - Enable headset mic of ASUS Q524UQK with ALC255

2020-12-08 Thread Chris Chiu
The ASUS laptop Q524UQK with ALC255 codec can't detect the headset microphone until ALC255_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pc

Re: [PATCH] power: supply: axp288_fuel_gauge: Add the ECS EF20EA to the blacklist

2020-12-09 Thread Chris Chiu
On Wed, Dec 9, 2020 at 10:57 PM Hans de Goede wrote: > > Hi, > > On 12/9/20 5:50 AM, Chris Chiu wrote: > > The ECS EF20EA laptop ships an AXP288 but it is actually using a > > different, separate FG chip for AC and battery monitoring. On this > > laptop we need

[PATCH] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk

2020-12-09 Thread Chris Chiu
From: Dan Nicholson The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi reboot. It works withour problem after adding the parameter reboot=bios. Signed-off-by: Dan Nicholson Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- arch/x86/kernel/reboot.c | 10 ++ 1 file

[PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk

2020-12-09 Thread Chris Chiu
From: Dan Nicholson The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi reboot. It works without problem after adding the parameter reboot=bios. Signed-off-by: Dan Nicholson Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- v2: - fix typo in the commit message. arch

[PATCH] acer-wireless: send an EV_SYN/SYN_REPORT between state changes

2020-12-06 Thread Chris Chiu
of libinput changed to only process the device state and SYN_REPORT time, so now the key event is lost. Same fix as 'commit ("platform/x86: asus-wireless: send an EV_SYN/SYN_REPORT between state changes")' Signed-off-by: Daniel Drake Signed-off-by: Chris Chiu --- drive

[PATCH] Input: i8042 - add Acer laptops to the i8042 reset list

2020-12-06 Thread Chris Chiu
The touchpad operates in Basic Mode by default in the Acer BIOS setup, but some Aspire/TravelMate models require the i8042 to be reset in order to be correctly detected. Signed-off-by: Chris Chiu --- drivers/input/serio/i8042-x86ia64io.h | 42 +++ 1 file changed, 42

[PATCH] ALSA: hda/realtek - Enable headset mic of ASUS X430UN with ALC256

2020-12-06 Thread Chris Chiu
The ASUS laptop X430UN with ALC256 can't detect the headset microphone until ALC256_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pc

[PATCH] ALSA: hda/realtek - Add support for Memeza EDL03 headset mic

2020-12-06 Thread Chris Chiu
The Memeza laptop EDL03 with codec ALC256 can't detect the headset microphone. The headphone jack sensing works after we add a pin definition for it by ALC256_FIXUP_ASUS_MIC_NO_PRESENCE. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 1 + 1

[PATCH] ACPI: Add DMI quirk for GIGABYTE GB-BXBT-2807

2020-12-01 Thread Chris Chiu
h sees the existence of a backlight device node and has the unrealistic belief that there is actually a backlight there! Add a DMI quirk to force the backlight off on this system. Signed-off-by: Jasper St. Pierre Reviewed-by: Chris Chiu --- drivers/acpi/video_detect.c | 7 +++ 1 file

[PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

2021-03-11 Thread chris . chiu
From: Chris Chiu The .callback of the quirk for Sony VPCEH3U1E was unintetionally removed by the commit 25417185e9b5 ("ACPI: video: Add DMI quirk for GIGABYTE GB-BXBT-2807"). Add it back to make sure the quirk for Sony VPCEH3U1E works as expected. Signed-off-by: Chris Chiu Reported

Re: No sound cards detected on Kabylake laptops after upgrade to kernel 5.8

2021-03-10 Thread Chris Chiu
On Tue, Mar 9, 2021 at 11:29 PM Cezary Rojewski wrote: > > On 2021-03-09 1:19 PM, Chris Chiu wrote: > > Hi Guys, > > We have received reports that on some Kabylake laptops (Acer Swift > > SF314-54/55 and Lenovo Yoga C930...etc), all sound cards no longer be >

No sound cards detected on Kabylake laptops after upgrade to kernel 5.8

2021-03-09 Thread Chris Chiu
Hi Guys, We have received reports that on some Kabylake laptops (Acer Swift SF314-54/55 and Lenovo Yoga C930...etc), all sound cards no longer be detected after upgrade to kernel later than 5.8. These laptops have one thing in common, all of them have Realtek audio codec and connect the interna

Re: [PATCH v2] HID: Add Wireless Radio Control feature for Chicony devices

2021-01-04 Thread Chris Chiu
onsulting Chicony for this hotkey, learned the device will send > with 0x11 as the report ID and 0x1 as the value when the key is pressed > down. > > This patch maps the event as KEY_RFKILL. > > Signed-off-by: Jian-Hong Pan Reviewed-by: Chris Chiu > --- > v2: Remove the duplicat

[PATCH 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2021-01-07 Thread Chris Chiu
On at least one laptop (ECS EF20EA) the 'hp-detect' GPIO is defined in the DSDT table by the ACPI GpioIo resources in _CRS. The GPIO related information should be mapped to the rt5645 driver to enable the jack detection also on non-DT platforms. Signed-off-by: Chris Chiu --- sound/

[PATCH 2/4] ASoC: rt5645: Add ACPI-defined GPIO for ECS EF20 series

2021-01-07 Thread Chris Chiu
"\\_SB.GPO3", 0x00, ResourceConsumer, , ) { // Pin list 0x004F } }) Return (SBUF) /* \_SB_.PCI0.I2C2.RTK2._CRS.SBUF */ } Signed-off-by: Chris Chiu --- sound/soc/codecs/rt5645.c | 27 +++ 1 file changed, 27 inserti

  1   2   3   >