Re: [PATCH] platform/x86: Add Acer Wireless Radio Control driver

2017-11-19 Thread Chris Chiu
On Fri, Nov 17, 2017 at 10:25 PM, Andy Shevchenko wrote: > On Thu, Nov 16, 2017 at 3:44 PM, Chris Chiu wrote: >> New Acer laptops in 2018 will have a separate ACPI device for >> notifications from the airplane mode hotkey. The device name in >> the DSDT is SMKB and its

Re: [PATCH] pinctrl: intel: Initialize GPIO properly when used through irqchip

2017-11-20 Thread Chris Chiu
; used directly through irqchip. > > Reported-by: Daniel Drake > Reported-by: Chris Chiu > Signed-off-by: Mika Westerberg > --- > Chris, Daniel, > > Could you check that this still solves the issue and maybe provide your > Tested-by? Thanks! > I've verified on X540NA h

Re: [PATCH] platform/x86: Add Acer Wireless Radio Control driver

2017-11-20 Thread Chris Chiu
On Mon, Nov 20, 2017 at 8:24 PM, Andy Shevchenko wrote: > On Mon, Nov 20, 2017 at 8:31 AM, Chris Chiu wrote: >> On Fri, Nov 17, 2017 at 10:25 PM, Andy Shevchenko >> wrote: >>> On Thu, Nov 16, 2017 at 3:44 PM, Chris Chiu wrote: > >>>> + >>>&g

[PATCH v2] platform/x86: Add Acer Wireless Radio Control driver

2017-11-20 Thread Chris Chiu
} } Based on code from asus-wireless Signed-off-by: Chris Chiu Reviewed-by: João Paulo Rechi Vita --- Notes: v2: less code and no redundant data structure drivers/platform/x86/Kconfig | 14 +++ drivers/platform/x86/Makefile| 1 + drivers

[PATCH] ACPI / PM: Fix wake up by PS2 keyboard fail on ASUS UX331UA

2018-03-30 Thread Chris Chiu
interrupt completion. Signed-off-by: Chris Chiu https://phabricator.endlessm.com/T21599 --- drivers/acpi/sleep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 8082871..c6e1b4b 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi

[PATCH] ACPI / PM: Fix wake up by PS2 keyboard fail on ASUS UX331UA

2018-03-30 Thread Chris Chiu
interrupt completion. Signed-off-by: Chris Chiu --- drivers/acpi/sleep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 8082871..c6e1b4b 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -982,8 +982,9 @@ static void

Re: r8169 take too long to complete driver initialization

2018-02-01 Thread Chris Chiu
On Tue, Jan 30, 2018 at 8:07 PM, Chris Chiu wrote: > On Mon, Jan 29, 2018 at 11:24 PM, Hau wrote: >> Hi Chris, >> >> Could you test following patch? >> >> DECLARE_RTL_COND(rtl_ocp_tx_cond) >> { >> void __iomem *ioaddr = tp->mmio_

Re: r8169 take too long to complete driver initialization

2018-02-04 Thread Chris Chiu
On Fri, Feb 2, 2018 at 7:49 PM, Hau wrote: > >> -Original Message- >> From: Chris Chiu [mailto:c...@endlessm.com] >> Sent: Friday, February 2, 2018 10:03 AM >> To: Hau >> Cc: nic_swsd ; net...@vger.kernel.org; Linux >> Kernel ; Linux Upstreaming

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-21 Thread Chris Chiu
On Tue, Nov 21, 2017 at 6:52 PM, Mika Westerberg wrote: > On Fri, Nov 17, 2017 at 04:11:31PM +0800, Chris Chiu wrote: >> On Fri, Nov 17, 2017 at 2:49 PM, Mika Westerberg >> wrote: >> > On Thu, Nov 16, 2017 at 09:27:51PM +0800, Chris Chiu wrote: >> >> O

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-23 Thread Chris Chiu
On Tue, Nov 21, 2017 at 8:04 PM, Mika Westerberg wrote: > On Tue, Nov 21, 2017 at 07:54:26PM +0800, Chris Chiu wrote: >> Yup, I checked the value of the corresponded pin. It shows following before >> suspend >> pin 18 (GPIO_18) GPIO 0x40800102 0x00024075 >> >> The

Re: GemniLake laptops goes power off directly after performing suspend

2017-12-06 Thread Chris Chiu
On Wed, Dec 6, 2017 at 9:34 PM, Rafael J. Wysocki wrote: > On Wed, Dec 6, 2017 at 10:33 AM, Chris Chiu wrote: >> On Wed, Dec 6, 2017 at 5:56 AM, Rafael J. Wysocki wrote: >>> On Tuesday, December 5, 2017 5:19:03 PM CET Chris Chiu wrote: >>>> On Tue, Dec 5, 2017

Re: [Intel-gfx] GemniLake laptops goes power off directly after performing suspend

2017-12-13 Thread Chris Chiu
On Tue, Dec 12, 2017 at 9:32 PM, Imre Deak wrote: > On Fri, Dec 08, 2017 at 10:31:30AM +, Daniel Drake wrote: >> Hi, >> >> Adding intel-gfx list in case i915 developers can help. Updated summary >> below. >> >> On Thu, Dec 7, 2017 at 2:14 AM, Chris Chi

[PATCH] ALSA: hda/realtek - Limit int mic boost on Acer Aspire E5-575T

2021-01-14 Thread Chris Chiu
for Acer Aspire E5-575T. Signed-off-by: Chris Chiu --- sound/pci/hda/patch_realtek.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3c1d2a3fb1a4..60eb8383a704 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci

[PATCH 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2021-01-07 Thread Chris Chiu
On at least one laptop (ECS EF20EA) the 'hp-detect' GPIO is defined in the DSDT table by the ACPI GpioIo resources in _CRS. The GPIO related information should be mapped to the rt5645 driver to enable the jack detection also on non-DT platforms. Signed-off-by: Chris Chiu --- sound/soc/codecs

[PATCH 2/4] ASoC: rt5645: Add ACPI-defined GPIO for ECS EF20 series

2021-01-07 Thread Chris Chiu
"\\_SB.GPO3", 0x00, ResourceConsumer, , ) { // Pin list 0x004F } }) Return (SBUF) /* \_SB_.PCI0.I2C2.RTK2._CRS.SBUF */ } Signed-off-by: Chris Chiu --- sound/soc/codecs/rt5645.c | 27 +++ 1 file changed, 27 inserti

[PATCH 3/4] ASoC: rt5645: add inv_hp_det flag

2021-01-07 Thread Chris Chiu
ge () {"hp-detect-gpio", Package() {^RTK2, 0, 0, 1 }}, } }) This flag will invert the hp-detect gpio polarity. Signed-off-by: Chris Chiu --- include/sound/rt5645.h| 2 ++ sound/soc/codecs/rt5645.c | 4 2 files changed, 6 insertions(+) diff --git a/include/sound/rt5645.h b/

[PATCH 0/4] ASoC: rt5645: Enable internal mic and headset on ECS EF20

2021-01-07 Thread Chris Chiu
These patches are trying to fix the jack detection and internal microphone problems on ECS EF20 series laptops which are empowered by Intel Atom x5-Z8350 CPU (CherryTrail) with Realtek rt5645 audio codec. Chris Chiu (4): ASoC: rt5645: Introduce mapping for ACPI-defined GPIO ASoC: rt5645: Add

[PATCH 4/4] ASoC: rt5645: Enable internal microphone and JD on ECS EF20

2021-01-07 Thread Chris Chiu
On ECS EF20 series laptops, the internal mic is on DMIC2/IN2P. And they need the inv_hp_det to make jack detection to work as exoected. Signed-off-by: Chris Chiu --- sound/soc/codecs/rt5645.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc

[PATCH v2 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2021-01-07 Thread Chris Chiu
On at least one laptop (ECS EF20EA) the 'hp-detect' GPIO is defined in the DSDT table by the ACPI GpioIo resources in _CRS. The GPIO related information should be mapped to the rt5645 driver to enable the jack detection also on non-DT platforms. Signed-off-by: Chris Chiu --- v1 ->

[PATCH v2 3/4] ASoC: rt5645: add inv_hp_det flag

2021-01-07 Thread Chris Chiu
ge () {"hp-detect-gpio", Package() {^RTK2, 0, 0, 1 }}, } }) This flag will invert the hp-detect gpio polarity. Signed-off-by: Chris Chiu --- v1 -> v2: - none include/sound/rt5645.h| 2 ++ sound/soc/codecs/rt5645.c | 4 2 files changed, 6 insertions(+) dif

[PATCH v2 2/4] ASoC: rt5645: Add ACPI-defined GPIO for ECS EF20 series

2021-01-07 Thread Chris Chiu
"\\_SB.GPO3", 0x00, ResourceConsumer, , ) { // Pin list 0x004F } }) Return (SBUF) /* \_SB_.PCI0.I2C2.RTK2._CRS.SBUF */ } Signed-off-by: Chris Chiu --- v1 -> v2: - Invoke callback() of the DMI quirk if it exists.

[PATCH v2 0/4] ASoC: rt5645: Enable internal mic and headset on ECS EF20

2021-01-07 Thread Chris Chiu
use the dmi_first_match() doesn't. --- Chris Chiu (4): ASoC: rt5645: Introduce mapping for ACPI-defined GPIO ASoC: rt5645: Add ACPI-defined GPIO for ECS EF20 series ASoC: rt5645: add inv_hp_det flag ASoC: rt5645: Enable internal microphone and JD on ECS EF20 include/sound/rt5645.h|

[PATCH v2 4/4] ASoC: rt5645: Enable internal microphone and JD on ECS EF20

2021-01-07 Thread Chris Chiu
On ECS EF20 series laptops, the internal mic is on DMIC2/IN2P. And they need the inv_hp_det to make jack detection to work as exoected. Signed-off-by: Chris Chiu --- v1 -> v2: - none sound/soc/codecs/rt5645.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/

Re: [PATCH 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2021-01-07 Thread Chris Chiu
On Thu, Jan 7, 2021 at 10:28 PM Mark Brown wrote: > > On Thu, Jan 07, 2021 at 05:06:22PM +0800, Chris Chiu wrote: > > > +static const struct acpi_gpio_mapping *cht_rt5645_gpios; > > + > > You're adding a read only static variable with no way to set it. This >

[PATCH 1/3] rtlwifi: rtl8192se: remove duplicated legacy_httxpowerdiff

2020-10-05 Thread Chris Chiu
From: Chris Chiu The legacy_httxpowerdiff in rtl8192se is pretty much the same as the legacy_ht_txpowerdiff for other chips. Use the same name to keep the consistency. Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 2 +- drivers/net/wireless/realtek

[PATCH] rtlwifi: rtl8192se: remove duplicated legacy_httxpowerdiff

2020-10-05 Thread Chris Chiu
From: Chris Chiu The legacy_httxpowerdiff in rtl8192se is pretty much the same as the legacy_ht_txpowerdiff for other chips. Use the same name to keep the consistency. Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 2 +- drivers/net/wireless/realtek

mt7615: Fail to load firmware on AZWAVE-CB434NF module

2020-09-08 Thread Chris Chiu
Hi Sean, Ryder, We have an ASUS laptop X532EQ with the wifi module AZWAVE-CB434NF which fails to bring up the wifi interface on kernel 5.9.0-rc1. The dmesg shows the firmware load error. [ 25.630850] mt7615e :2d:00.0: Message -4294967280 (seq 1) timeout [ 25.630851] mt7615e

Re: mt7615: Fail to load firmware on AZWAVE-CB434NF module

2020-09-13 Thread Chris Chiu
On Tue, Sep 8, 2020 at 8:33 PM Chris Chiu wrote: > > Hi Sean, Ryder, > We have an ASUS laptop X532EQ with the wifi module AZWAVE-CB434NF > which fails to bring up the wifi interface on kernel 5.9.0-rc1. The > dmesg shows the firmware load error. > > [ 25.630850]

[PATCH] power: supply: axp288_fuel_gauge: Add the ECS EF20EA to the blacklist

2020-12-08 Thread Chris Chiu
The ECS EF20EA laptop ships an AXP288 but it is actually using a different, separate FG chip for AC and battery monitoring. On this laptop we need to keep using the regular ACPI driver and disable the AXP288 FG to avoid reporting two batteries to userspace. Signed-off-by: Chris Chiu --- drivers

[PATCH] ALSA: hda/realtek - Enable headset mic of ASUS Q524UQK with ALC255

2020-12-08 Thread Chris Chiu
The ASUS laptop Q524UQK with ALC255 codec can't detect the headset microphone until ALC255_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda

Re: [PATCH] power: supply: axp288_fuel_gauge: Add the ECS EF20EA to the blacklist

2020-12-09 Thread Chris Chiu
On Wed, Dec 9, 2020 at 10:57 PM Hans de Goede wrote: > > Hi, > > On 12/9/20 5:50 AM, Chris Chiu wrote: > > The ECS EF20EA laptop ships an AXP288 but it is actually using a > > different, separate FG chip for AC and battery monitoring. On this > > laptop we need

[PATCH] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk

2020-12-09 Thread Chris Chiu
From: Dan Nicholson The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi reboot. It works withour problem after adding the parameter reboot=bios. Signed-off-by: Dan Nicholson Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- arch/x86/kernel/reboot.c | 10 ++ 1 file

[PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk

2020-12-09 Thread Chris Chiu
From: Dan Nicholson The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi reboot. It works without problem after adding the parameter reboot=bios. Signed-off-by: Dan Nicholson Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- v2: - fix typo in the commit message. arch

[PATCH 1/2] ALSA: hda/realtek: Apply jack fixup for Quanta NL3

2020-12-22 Thread Chris Chiu
output. The ALC269_FIXUP_LIFEBOOK chained with ALC269_FIXUP_QUANTA_MUTE can help to differentiate 2 jacks and get the 'Auto-Mute Mode' working correctly. Signed-off-by: Chris Chiu --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b

[PATCH 2/2] ALSA/hda: apply jack fixup for the Acer Veriton N4640G/N6640G/N2510G

2020-12-22 Thread Chris Chiu
all audio jacks to work as expected. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index bb1010d78717..9eb43d827bda 100644 --- a/sound/pci

Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirks for DeeQ X5-Z8300

2020-12-22 Thread Chris Chiu
On Wed, Dec 16, 2020 at 12:18 PM Chris Chiu wrote: > > DeeQ X5-Z8300 is a laptop empowered by Intel Atom Cherry Trail. Add > quirks to select the correct input map, jack-detect options to enable > jack sensing and internal/headset microphones. > > Signed-off-by: Chris Chiu

Re: [PATCH] HID: Add Wireless Radio Control feature for Chicony devices

2020-12-22 Thread Chris Chiu
On Tue, Dec 22, 2020 at 3:41 PM Jian-Hong Pan wrote: > > Some Chicony's keyboards support airplane mode hotkey (Fn+F2) with > "Wireless Radio Control" feature. For example, the wireless keyboard > [04f2:1236] shipped with ASUS all-in-one desktop. > > After consulting Chicony for this hotkey,

Re: [PATCH v2] HID: Add Wireless Radio Control feature for Chicony devices

2021-01-04 Thread Chris Chiu
ting Chicony for this hotkey, learned the device will send > with 0x11 as the report ID and 0x1 as the value when the key is pressed > down. > > This patch maps the event as KEY_RFKILL. > > Signed-off-by: Jian-Hong Pan Reviewed-by: Chris Chiu > --- > v2: Remove the duplicated ke

[PATCH] ASoC: Intel: bytcr_rt5640: Add quirks for DeeQ X5-Z8300

2020-12-15 Thread Chris Chiu
DeeQ X5-Z8300 is a laptop empowered by Intel Atom Cherry Trail. Add quirks to select the correct input map, jack-detect options to enable jack sensing and internal/headset microphones. Signed-off-by: Chris Chiu --- sound/soc/intel/boards/bytcr_rt5651.c | 8 1 file changed, 8 insertions

[PATCH] ALSA: hda/realtek: Remove dummy lineout on Acer TravelMate P648/P658

2020-12-16 Thread Chris Chiu
quirk to remove the useless lineout and enable the pin 0x18 for jack sensing and headset microphone. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/sound/pci/hda

[PATCH v2] Bluetooth: btusb: Add support for 13d3:3560 MediaTek MT7615E device

2020-11-09 Thread Chris Chiu
-by: Chris Chiu --- v2: - Add comment for the MT7615E BT device. drivers/bluetooth/btusb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 5af2e3f30a5e..7e05be1a7bff 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth

[PATCH] acer-wireless: send an EV_SYN/SYN_REPORT between state changes

2020-12-06 Thread Chris Chiu
of libinput changed to only process the device state and SYN_REPORT time, so now the key event is lost. Same fix as 'commit ("platform/x86: asus-wireless: send an EV_SYN/SYN_REPORT between state changes")' Signed-off-by: Daniel Drake Signed-off-by: Chris Chiu --- drivers/platfor

[PATCH] Input: i8042 - add Acer laptops to the i8042 reset list

2020-12-06 Thread Chris Chiu
The touchpad operates in Basic Mode by default in the Acer BIOS setup, but some Aspire/TravelMate models require the i8042 to be reset in order to be correctly detected. Signed-off-by: Chris Chiu --- drivers/input/serio/i8042-x86ia64io.h | 42 +++ 1 file changed, 42

[PATCH] ALSA: hda/realtek - Enable headset mic of ASUS X430UN with ALC256

2020-12-06 Thread Chris Chiu
The ASUS laptop X430UN with ALC256 can't detect the headset microphone until ALC256_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda

[PATCH] ALSA: hda/realtek - Add support for Memeza EDL03 headset mic

2020-12-06 Thread Chris Chiu
The Memeza laptop EDL03 with codec ALC256 can't detect the headset microphone. The headphone jack sensing works after we add a pin definition for it by ALC256_FIXUP_ASUS_MIC_NO_PRESENCE. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 1 + 1 file

[PATCH] ACPI: Add DMI quirk for GIGABYTE GB-BXBT-2807

2020-12-01 Thread Chris Chiu
which sees the existence of a backlight device node and has the unrealistic belief that there is actually a backlight there! Add a DMI quirk to force the backlight off on this system. Signed-off-by: Jasper St. Pierre Reviewed-by: Chris Chiu --- drivers/acpi/video_detect.c | 7 +++ 1 file

[PATCH] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-09-02 Thread Chris Chiu
invokes the handle_c2h is only for 8723b and 8192e so the mechanism is expected to work on both chips with single antenna. Note RTL8192EU dual antenna is not supported. Signed-off-by: Chris Chiu --- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 37 +++ .../realtek/rtl8xxxu/rtl8xxxu_8723b.c

Tweak I2C SDA hold time on GemniLake to make touchpad work

2019-09-03 Thread Chris Chiu
Hi, We're working on the acer Gemnilake laptop TravelMate B118-M for touchpad not working issue. The touchpad fails to bring up and the i2c-hid ouput the message as follows [8.317293] i2c_hid i2c-ELAN0502:00: hid_descr_cmd failed We tried on latest linux kernel 5.3.0-rc6 and it reports

Re: Tweak I2C SDA hold time on GemniLake to make touchpad work

2019-09-03 Thread Chris Chiu
On Tue, Sep 3, 2019 at 8:03 PM Jarkko Nikula wrote: > > Hi Chris > > On 9/3/19 11:18 AM, Mika Westerberg wrote: > > +Jarkko > > > > On Tue, Sep 03, 2019 at 04:10:27PM +0800, Chris Chiu wrote: > >> Hi, > >> > >> We're working on the

Re: Tweak I2C SDA hold time on GemniLake to make touchpad work

2019-09-04 Thread Chris Chiu
On Wed, Sep 4, 2019 at 1:54 PM Jarkko Nikula wrote: > > On 9/4/19 7:38 AM, Chris Chiu wrote: > > On Tue, Sep 3, 2019 at 8:03 PM Jarkko Nikula > > wrote: > >> > >> Hi Chris > >> > >> On 9/3/19 11:18 AM, Mika Westerberg wrote: > >>

[PATCH] staging: rtl8723bs: indicate disconnection when disconnecting

2019-07-31 Thread Chris Chiu
to indicate the disconnection events during disconnection so the cfg80211_connect can connect to a different AP without problem. Signed-off-by: Chris Chiu --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep

[PATCH] pinctrl: intel: remap the pin number to gpio offset for irq enabled pin

2019-08-16 Thread Chris Chiu
. Signed-off-by: Chris Chiu --- drivers/pinctrl/intel/pinctrl-intel.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index a18d6eefe672..8d6a843bbc7e 100644 --- a/drivers

[RFC PATCH v4] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-31 Thread Chris Chiu
fix. And I think we can still bring in the dm_watchdog as rtlwifi to improve from the driver side. Please leave precious comments for my commits and suggest what I can do better. Or suggest if there's any better idea to fix this. Thanks. Signed-off-by: Chris Chiu --- Notes: v2: - Fix errors

[PATCH] rtl8xxxu: prevent potential memory leak

2020-09-05 Thread Chris Chiu
Free the skb if usb_submit_urb fails on rx_urb. And free the urb no matter usb_submit_urb succeeds or not in rtl8xxxu_submit_int_urb. Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[PATCH] Bluetooth: btusb: Add support for 13d3:3560 MediaTek MT7615E device

2020-11-02 Thread Chris Chiu
=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms Signed-off-by: Chris Chiu

Re: [RFC PATCH v7] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-09-16 Thread Chris Chiu
On Mon, Aug 12, 2019 at 11:21 PM Jes Sorensen wrote: > > On 8/12/19 10:32 AM, Kalle Valo wrote: > >> Signed-off-by: Jes Sorensen > > > > This is marked as RFC so I'm not sure what's the plan. Should I apply > > this? > > I think it's at a point where it's worth applying - I kinda wish I had >

[PATCH v7] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-09-17 Thread Chris Chiu
be further improved. Signed-off-by: Chris Chiu Reviewed-by: Daniel Drake --- Notes: v2: - Fix errors and warnings complained by checkpatch.pl - Replace data structure rate_adaptive by 2 member variables - Make rtl8xxxu_wireless_mode non-static - Runs refresh_rate_mask() only

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-09-18 Thread Chris Chiu
On Wed, Sep 11, 2019 at 10:50 AM Chris Chiu wrote: > > > Notes: > v2: >- Add helper functions to replace bunch of tdma settings >- Reformat some lines to meet kernel coding style > > Gentle ping. Any suggestions would be appreciated. Thanks. Chris

Re: [PATCH] [v2] pinctrl: intel: mark intel_pin_to_gpio __maybe_unused

2019-09-08 Thread Chris Chiu
[-Werror,-Wunused-function] > > Mark it __maybe_unused to suppress the warning. > > Suggested-by: Andy Shevchenko > Signed-off-by: Arnd Bergmann Reviewed-by: Chris Chiu

[PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-09-10 Thread Chris Chiu
invokes the handle_c2h is only for 8723b and 8192e so the mechanism is expected to work on both chips with single antenna. Note RTL8192EU dual antenna is not supported. Signed-off-by: Chris Chiu --- Notes: v2: - Add helper functions to replace bunch of tdma settings - Reformat some lines

[PATCH] ALSA: usb: mixer: volume quirk for ESS Technology Asus USB DAC

2020-05-26 Thread Chris Chiu
-23040/0/1 Signed-off-by: Chris Chiu --- sound/usb/mixer.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 81b2db0edd5f..0b568a9fdab3 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -1171,6 +1171,14 @@ static void volume_control_

Re: r8169 take too long to complete driver initialization

2018-01-30 Thread Chris Chiu
ister bit? Can you help work out a patch for this? Chris >> -Original Message- >> From: Chris Chiu [mailto:c...@endlessm.com] >> Sent: Monday, January 29, 2018 6:12 PM >> To: nic_swsd ; net...@vger.kernel.org; Linux >> Kernel ; Linux Upstreaming Team >

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-15 Thread Chris Chiu
Hi Mika, Yes, that’s the most weird part. Chris 從我的 iPhone 傳送 > Mika Westerberg 於 2017年11月15日 下午4:04 寫道: > >> On Tue, Nov 14, 2017 at 06:41:36PM +0800, Chris Chiu wrote: >> The touchpad in the Asus laptop model X540NA is unresponsive >> after suspend/resume. The

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-15 Thread Chris Chiu
Hi Mika, I've confirmed with Asus and they said it's the latest BIOS for shipment and verified OK on Windows. So their BIOS team will not do anything for this. Chris On Wed, Nov 15, 2017 at 6:13 PM, Mika Westerberg wrote: > On Wed, Nov 15, 2017 at 04:08:32PM +0800, Chris Chiu wr

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-16 Thread Chris Chiu
On Thu, Nov 16, 2017 at 8:44 PM, Mika Westerberg wrote: > On Wed, Nov 15, 2017 at 06:19:56PM +0800, Chris Chiu wrote: >> Hi Mika, >> I've confirmed with Asus and they said it's the latest BIOS for >> shipment and verified OK on Windows. So their BIOS team wi

[PATCH] platform/x86: Add Acer Wireless Radio Control driver

2017-11-16 Thread Chris Chiu
} } Based on code from asus-wireless Signed-off-by: Chris Chiu Reviewed-by: João Paulo Rechi Vita --- drivers/platform/x86/Kconfig | 14 ++ drivers/platform/x86/Makefile| 1 + drivers/platform/x86/acer-wireless.c | 86

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2017-11-17 Thread Chris Chiu
On Fri, Nov 17, 2017 at 2:49 PM, Mika Westerberg wrote: > On Thu, Nov 16, 2017 at 09:27:51PM +0800, Chris Chiu wrote: >> On Thu, Nov 16, 2017 at 8:44 PM, Mika Westerberg >> wrote: >> > On Wed, Nov 15, 2017 at 06:19:56PM +0800, Chris Chiu wrote: >> >> Hi Mika

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-17 Thread Chris Chiu
The dmesg log is here https://gist.github.com/mschiu77/5dfe91ef319de16fb343c5d907b2cbc5 And the acpidump is here https://gist.github.com/mschiu77/d9b72d89a6a21efb616f153f164c0d18 On Fri, Nov 17, 2017 at 4:27 PM, Chris Chiu wrote: > On Thu, Nov 16, 2017 at 9:07 PM, Mika Westerberg >

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-17 Thread Chris Chiu
On Fri, Nov 17, 2017 at 5:11 PM, Mika Westerberg wrote: > On Fri, Nov 17, 2017 at 04:27:39PM +0800, Chris Chiu wrote: >> On Thu, Nov 16, 2017 at 9:07 PM, Mika Westerberg >> wrote: >> > On Thu, Nov 16, 2017 at 12:01:24PM +, Daniel Drake wrote: >> >> On

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-17 Thread Chris Chiu
On Fri, Nov 17, 2017 at 5:13 PM, Chris Chiu wrote: > On Fri, Nov 17, 2017 at 5:11 PM, Mika Westerberg > wrote: >> On Fri, Nov 17, 2017 at 04:27:39PM +0800, Chris Chiu wrote: >>> On Thu, Nov 16, 2017 at 9:07 PM, Mika Westerberg >>> wrote: >>> > On Thu

Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad

2017-11-17 Thread Chris Chiu
On Fri, Nov 17, 2017 at 7:00 PM, Mika Westerberg wrote: > On Fri, Nov 17, 2017 at 06:01:27PM +0800, Chris Chiu wrote: >> Hi Mika, >> Here's the full dmesg log you need. The touchpad stop reporting at >> the last of the log. >> https://gist.github.com/mschiu77/a0b8d

ipmi_si fails to get BMC ID

2018-02-07 Thread Chris Chiu
Hi, We are working with a new desktop Acer Veriton Z4640G and get stumbled on failing to enter S3 suspend with kernel version 4.14 even the latest 4.15+. Here's the kernel log https://gist.github.com/mschiu77/76888f1fd4eb56aa8959d76759a912bb. As you see, it is due to

Re: ipmi_si fails to get BMC ID

2018-02-08 Thread Chris Chiu
On Thu, Feb 8, 2018 at 11:53 PM, Corey Minyard wrote: > On 02/07/2018 09:01 PM, Chris Chiu wrote: >> >> Hi, >> We are working with a new desktop Acer Veriton Z4640G and get >> stumbled on failing to enter S3 suspend with kernel version 4.14 even >> the la

Re: r8169 take too long to complete driver initialization

2018-01-29 Thread Chris Chiu
On Fri, Jan 5, 2018 at 10:17 AM, Chris Chiu wrote: > On Wed, Dec 20, 2017 at 4:41 PM, Chris Chiu wrote: >> Hi, >> We've hit a suspend/resume issue on a Acer desktop caused by r8169 >> driver. The dmseg >> https://gist.github.com/mschiu77/b741849b5070281daaead8dfe

Re: [RFC PATCH v4] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-06-10 Thread Chris Chiu
On Wed, Jun 5, 2019 at 10:17 AM Chris Chiu wrote: > > On Tue, Jun 4, 2019 at 3:21 AM Jes Sorensen wrote: > > > > On 5/31/19 5:12 AM, Chris Chiu wrote: > > > We have 3 laptops which connect the wifi by the same RTL8723BU. > > > The PCI VID/PID of the wifi

[RFC PATCH v3] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-28 Thread Chris Chiu
think we can still bring in the dm_watchdog as rtlwifi to improve from the driver side. Please leave precious comments for my commits and suggest what I can do better. Or suggest if there's any better idea to fix this. Thanks. Signed-off-by: Chris Chiu --- Notes: v2: - Fix errors and warnings

Re: [RFC PATCH v3] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-29 Thread Chris Chiu
On Thu, May 30, 2019 at 2:12 AM Daniel Drake wrote: > > Hi Chris, > > On Tue, May 28, 2019 at 11:03 PM Chris Chiu wrote: > > + /* > > +* Single virtual interface permitted since the driver supports > > STATION > > +* mode only. > &

Re: [RFC PATCH v3] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-29 Thread Chris Chiu
On Thu, May 30, 2019 at 2:22 AM Larry Finger wrote: > > On 5/29/19 12:03 AM, Chris Chiu wrote: > > We have 3 laptops which connect the wifi by the same RTL8723BU. > > The PCI VID/PID of the wifi chip is 10EC:B720 which is supported. > > They have the same problem wit

[RFC PATCH v7] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-08-05 Thread Chris Chiu
be further improved. Signed-off-by: Chris Chiu Reviewed-by: Daniel Drake --- Notes: v2: - Fix errors and warnings complained by checkpatch.pl - Replace data structure rate_adaptive by 2 member variables - Make rtl8xxxu_wireless_mode non-static - Runs refresh_rate_mask() only

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-01 Thread Chris Chiu
On Thu, Sep 19, 2019 at 9:44 AM Chris Chiu wrote: > > On Wed, Sep 11, 2019 at 10:50 AM Chris Chiu wrote: > > > > > > Notes: > > v2: > >- Add helper functions to replace bunch of tdma settings > >- Reformat some lines to meet kernel coding s

[PATCH v8] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-10-02 Thread Chris Chiu
be further improved. Signed-off-by: Chris Chiu Reviewed-by: Daniel Drake Acked-by: Jes Sorensen --- Notes: v2: - Fix errors and warnings complained by checkpatch.pl - Replace data structure rate_adaptive by 2 member variables - Make rtl8xxxu_wireless_mode non-static - Runs

Re: [PATCH v7] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-10-02 Thread Chris Chiu
On Wed, Oct 2, 2019 at 12:30 PM Kalle Valo wrote: > New warning: > > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function > 'rtl8xxxu_refresh_rate_mask': > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5907:7: warning: this > statement may fall through

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-02 Thread Chris Chiu
On Wed, Oct 2, 2019 at 12:29 PM Kalle Valo wrote: > Failed to apply, please rebase on top of wireless-drivers-next. > > fatal: sha1 information is lacking or useless > (drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h). > error: could not build fake ancestor > Applying: rtl8xxxu: add bluetooth

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-02 Thread Chris Chiu
On Wed, Oct 2, 2019 at 11:04 PM Jes Sorensen wrote: > > > In general I think it looks good! One nit below: > > Sorry I have been traveling for the last three weeks, so just catching up. > > > > +void rtl8723bu_set_coex_with_type(struct rtl8xxxu_priv *priv, u8 type) > > +{ > > + switch (type)

Re: [PATCH] rtl8xxxu: prevent leaking urb

2019-09-20 Thread Chris Chiu
On Fri, Sep 20, 2019 at 11:01 AM Navid Emamdoost wrote: > > In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb > should be released. > > Signed-off-by: Navid Emamdoost Reviewed-by: Chris Chiu > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c &

[PATCH v3] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-05 Thread Chris Chiu
invokes the handle_c2h is only for 8723b and 8192e so the mechanism is expected to work on both chips with single antenna. Note RTL8192EU dual antenna is not supported. Signed-off-by: Chris Chiu --- Notes: v2: - Add helper functions to replace bunch of tdma settings - Reformat some lines

Re: [RFC PATCH v7] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-08-12 Thread Chris Chiu
On Mon, Aug 5, 2019 at 9:15 PM Chris Chiu wrote: > > We have 3 laptops which connect the wifi by the same RTL8723BU. > The PCI VID/PID of the wifi chip is 10EC:B720 which is supported. > They have the same problem with the in-kernel rtl8xxxu driver, the > iperf (as a client

Re: [PATCH] rtl8xxxu: make arrays static, makes object smaller

2019-10-07 Thread Chris Chiu
148619024 0 238855d4d realtek/rtl8xxxu/rtl8xxxu_8192e.o > 149536616 0 215695441 realtek/rtl8xxxu/rtl8xxxu_8723b.o > 102986 31458 576 135020 20f6c realtek/rtl8xxxu/rtl8xxxu_core.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King > --- Reviewed-by: Chris Chiu

Re: [PATCH v8] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-10-08 Thread Chris Chiu
On Wed, Oct 2, 2019 at 8:18 PM Chris Chiu wrote: > v7: >- Fix reported bug of watchdog stop >- refer to the RxPWDBAll in vendor driver for SNR calculation > v8: >- Add missing break in switch case > > + case WIRELESS_MODE_N_24G: &

Re: [PATCH v2] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot

2019-10-16 Thread Chris Chiu
On Wed, Oct 16, 2019 at 9:54 AM Chris Chiu wrote: > > The RTL8723BU has problems connecting to AP after each warm reboot. > Sometimes it returns no scan result, and in most cases, it fails > the authentication for unknown reason. However, it works totally > fine after cold rebo

Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'

2019-10-23 Thread Chris Chiu
erformance of RTL8723BU on rtl8xxxu driver") > > Signed-off-by: YueHaibing > --- Singed-off-by: Chris Chiu > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_

[PATCH] rtl8xxxu: fix warnings for symbol not declared.

2019-10-23 Thread Chris Chiu
: symbol 'rtl8723bu_handle_bt_info' was not declared. Should it be static? Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless

[PATCH] rtl8xxxu: fix connection failure issue after warm reboot

2019-10-15 Thread Chris Chiu
--- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 +++ 3 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h

[PATCH] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot

2019-10-15 Thread Chris Chiu
only tells the RTL8723BU to do full initilization without checking MAC status. Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 +++ 3

[PATCH] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot

2019-10-15 Thread Chris Chiu
only tells the RTL8723BU to do full initialization without checking MAC status. https://phabricator.endlessm.com/T28000 Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 + drivers/net/wireless

Re: [PATCH] rtl8xxxu: fix connection failure issue after warm reboot

2019-10-15 Thread Chris Chiu
On Tue, Oct 15, 2019 at 6:16 PM Chris Chiu wrote: > > --- > 2.23.0 > Please ignore this message since it's not properly titled and no detail description. Sorry for inconvenience. Chris

[PATCH v2] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot

2019-10-15 Thread Chris Chiu
only tells the RTL8723BU to do full initialization without checking MAC status. Signed-off-by: Chris Chiu --- Note: v2: fix typo of commit message drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 + drivers/net/wireless

Re: [PATCH] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-09-05 Thread Chris Chiu
On Tue, Sep 3, 2019 at 1:37 PM Chris Chiu wrote: > > The RTL8723BU suffers the wifi disconnection problem while bluetooth > device connected. While wifi is doing tx/rx, the bluetooth will scan > without results. This is due to the wifi and bluetooth share the same > single

Re: [RFC PATCH 2/2] rtl8xxxu: Add watchdog to update rate mask by signal strength

2019-05-27 Thread Chris Chiu
On Wed, May 22, 2019 at 2:38 AM Daniel Drake wrote: > > On Fri, May 10, 2019 at 2:37 AM Chris Chiu wrote: > > I've verified that multiple virtual interface can not work simultaneously in > > STA mode. I assigned different mac address for different vifs, I can only > > bri

[RFC PATCH v5] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-06-17 Thread Chris Chiu
fix. And I think we can still bring in the dm_watchdog as rtlwifi to improve from the driver side. Please leave precious comments for my commits and suggest what I can do better. Or suggest if there's any better idea to fix this. Thanks. Signed-off-by: Chris Chiu --- Notes: v2: - Fix errors

<    1   2   3   4   >