Re: frequent lockups in 3.18rc4

On Tue, Dec 2, 2014 at 11:33 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Tue, Dec 2, 2014 at 6:13 AM, Mike Galbraith umgwanakikb...@gmail.com wrote: At the same time, the whole incapacitated by the rt throttle long enough for the hard lockup detector to trigger commentary about

Re: frequent lockups in 3.18rc4

On Wed, Dec 3, 2014 at 2:00 PM, Dave Jones da...@redhat.com wrote: On Wed, Dec 03, 2014 at 10:45:57AM -0800, Linus Torvalds wrote: On Wed, Dec 3, 2014 at 10:41 AM, Dave Jones da...@redhat.com wrote: I've been stuck on this kernel for a few days now trying to prove it good/bad one

Re: frequent lockups in 3.18rc4

On Wed, Dec 3, 2014 at 3:11 PM, Dave Jones da...@redhat.com wrote: On Wed, Dec 03, 2014 at 02:59:58PM -0500, Chris Mason wrote: You've also mentioned a few times where messages stopped hitting the console? commit 5874af2003b1053128d655710140e3187226 Author: Jan Kara j

Re: frequent lockups in 3.18rc4

On Thu, Dec 18, 2014 at 12:13 AM, Dave Jones da...@redhat.com wrote: On Mon, Dec 15, 2014 at 03:46:41PM -0800, Linus Torvalds wrote: On Mon, Dec 15, 2014 at 10:21 AM, Linus Torvalds torva...@linux-foundation.org wrote: So let's just fix it. Here's a completely untested patch. So

Re: frequent lockups in 3.18rc4

On Thu, Dec 18, 2014 at 10:58 PM, Dave Jones da...@redhat.com wrote: On Thu, Dec 18, 2014 at 07:49:41PM -0800, Linus Torvalds wrote: And when spinlocks start getting contention, *nested* spinlocks really really hurt. And you've got all the spinlock debugging on etc, don't you? Yeah,

[GIT PULL] Btrfs pull part two

Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus It has part two of our merge window patches. These are all from Filipe, and fix some really hard to find races that can cause corruptions. Most of them involved block

Re: frequent lockups in 3.18rc4

On Fri, Dec 19, 2014 at 9:55 AM, Dave Jones da...@redhat.com wrote: On Thu, Dec 18, 2014 at 08:48:24PM -0800, Linus Torvalds wrote: On Thu, Dec 18, 2014 at 8:03 PM, Dave Jones da...@redhat.com wrote: So the only thing that was on that could cause spinlock overhead was

Re: [PATCH v2 3/3] X86: Add a thread cpu time implementation to vDSO

On Fri, Dec 19, 2014 at 11:48 AM, Andy Lutomirski l...@amacapital.net wrote: On Fri, Dec 19, 2014 at 3:23 AM, Peter Zijlstra pet...@infradead.org wrote: On Thu, Dec 18, 2014 at 04:22:59PM -0800, Andy Lutomirski wrote: Bad news: this patch is incorrect, I think. Take a look at

Re: frequent lockups in 3.18rc4

On Fri, Dec 19, 2014 at 11:15:21AM -0800, Linus Torvalds wrote: Here's another pattern. In your latest thing, every single time that CPU1 is waiting for some other CPU to pick up the IPI, we have CPU0 doing this: [24998.060963] NMI backtrace for cpu 0 [24998.061989] CPU: 0 PID: 2940 Comm:

Re: frequent lockups in 3.18rc4

On Fri, Dec 19, 2014 at 6:22 PM, Thomas Gleixner t...@linutronix.de wrote: On Fri, 19 Dec 2014, Chris Mason wrote: On Fri, Dec 19, 2014 at 11:15:21AM -0800, Linus Torvalds wrote: Here's another pattern. In your latest thing, every single time that CPU1 is waiting for some other CPU

Re: [PATCH 3/3] X86: Add a thread cpu time implementation to vDSO

On Thu, Dec 11, 2014 at 1:36 AM, Ingo Molnar mi...@kernel.org wrote: * Andy Lutomirski l...@amacapital.net wrote: On Wed, Dec 10, 2014 at 2:56 PM, Shaohua Li s...@fb.com wrote: On Wed, Dec 10, 2014 at 02:13:23PM -0800, Andy Lutomirski wrote: On Wed, Dec 10, 2014 at 1:57 PM, Shaohua Li

[GIT PULL] Btrfs

) commits (+2/-2): Btrfs: use BUG_ON Sage Weil (1) commits (+9/-3): Btrfs: fix race in WAIT_SYNC ioctl Filipe David Borba Manana (1) commits (+3/-2): Btrfs: set default max_inline to 8KiB instead of 8MiB Li RongQing (1) commits (+0/-4): btrfs: remove the wrong comments Chris Mason (1

Re: btrfs: kernel BUG at fs/btrfs/extent_io.c:676!

On Sun, Oct 12, 2014 at 10:15 PM, Sasha Levin sasha.le...@oracle.com wrote: Ping? This BUG_ON()ing due to GFP_ATOMIC allocation failure is really silly :( Agreed, I have a patch for this in testing. It didn't make my first pull but I'll get it fixed up. -chris -- To unsubscribe from

Re: frequent lockups in 3.18rc4

I asked Dave for his lockups from 3.17-rc1, and they were in the flush_tlb code waiting for remote CPUs to finish flushing. It feels like that's a common theme, and there are a few commits there between 3.16 and 3.17. One guess is that trinity is generating a huge number of tlb invalidations

Re: frequent lockups in 3.18rc4

On Thu, Dec 4, 2014 at 12:49 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Wed, Dec 3, 2014 at 7:15 PM, Chris Mason c...@fb.com wrote: One guess is that trinity is generating a huge number of tlb invalidations over sparse and horrible ranges. Perhaps the old code

Re: frequent lockups in 3.18rc4

On Thu, Dec 4, 2014 at 10:22 AM, Dave Hansen dave.han...@intel.com wrote: On 12/03/2014 09:49 PM, Linus Torvalds wrote: On Wed, Dec 3, 2014 at 7:15 PM, Chris Mason c...@fb.com wrote: One guess is that trinity is generating a huge number of tlb invalidations over sparse and horrible ranges

[PATCH] eventfd: don't take the spinlock in eventfd_poll

with concurrent readers slightly larger. This spinlock is the top CPU user in kernel code during one of our workloads. Removing it gives us a ~2% boost. Signed-off-by: Chris Mason c...@fb.com --- fs/eventfd.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fs

Re: frequent lockups in 3.18rc4

On Fri, Dec 5, 2014 at 1:38 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Dec 5, 2014 at 9:15 AM, Dave Jones da...@redhat.com wrote: A bisect later, and I landed on a kernel that ran for a day, before spewing NMI messages, recovering, and then..

[GIT PULL] Btrfs fixes

Hi Linus, We have a few fixes in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Qu Wenruo's batch fix a regression between some our merge window pull and the inode_cache feature. The rest are smaller bugs. Qu Wenruo (2) commits (+11/-1):

[GIT PULL] Btrfs fix

Hi Linus, We have one more fix for btrfs in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus This was a bug in the new raid5/6 scrubbing support. Gui Hecheng (1) commits (+2/-0): btrfs: fix raid56 scrub failed in xfstests btrfs/072 Total:

[GIT PULL] Btrfs fix

Hi Linus, Forrest Liu tracked down a missing blk_finish_plug in the btrfs logging code. This isn't a new bug, and it's hard to hit. But, it's safe enough for inclusion now, and in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus I missed the

Re: __might_sleep() warnings on v3.19-rc6

On Sat, Jan 31, 2015 at 07:43:15PM -0800, Fengguang Wu wrote: Hi all, I see 2 __might_sleep() warnings on when running LKP tests on v3.19-rc6, one related to raid5 and another related to btrfs. They might be exposed by this patch. FSUse%Count SizeFiles/sec App

Re: linux-next: build warning after merge of the akpm-current tree

On Mon, Jan 19, 2015 at 2:45 AM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Andrew, After merging the akpm-current tree, today's linux-next build (x86_64 allmodconfig) produced this warning: fs/eventfd.c: In function 'eventfd_poll': fs/eventfd.c:121:16: warning: unused variable

Re: Linux 3.19-rc3

Zijlstra pet...@infradead.org wrote: On Tue, Jan 06, 2015 at 10:57:19AM +0100, Sedat Dilek wrote: [ 88.028739] [8124433f] aio_read_events+0x4f/0x2d0 Ah, that one. Chris Mason and Kent Overstreet were looking at that one. I'm not touching the AIO code either ;-) I know, I

[GIT PULL] Btrfs

Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus This was held up a little trying to track down a use-after-free in btrfs raid5/6. It's not clear yet if this is just made easier to trigger with this pull or if its a new

Re: [PATCH] Btrfs: avoid build warning on 32-bit

On Tue, Jan 13, 2015 at 7:16 PM, David Sterba dste...@suse.cz wrote: On Tue, Jan 13, 2015 at 03:09:03PM +0100, Arnd Bergmann wrote: A recent change introduced a type cast from a private 64-bit value to a pointer, which works fine on 64-bit architectures, but not on 32-bit ones, where it

[GIT PULL] Btrfs fixes

to the list of Btrfs maintainers. It doesn't mean we're doing things differently, but Dave has really been helping with the maintainer workload for years. Chris Mason (2) commits (+9/-0): Btrfs: don't delay inode ref updates during log replay (+8/-0) Btrfs: add more maintainers (+1/-0

[GIT PULL] Btrfs fixes

Hi Linus, Please grab my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Most of these are fixing extent reservation accounting, or corners with tree writeback during commit. Josef's set does add a test, which isn't strictly a fix, but it'll keep

[GIT PULL] Btrfs

Hi Linus, My for-linus branch has some btrfs fixes: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus I did rebase a patch out of the queue last night after tracking down some problems Dave Sterba was seeing during xfstests (the top three are obviously rebased). It

Re: [PATCH 5/7] btrfs: add support for write stream IDs

On Wed, Mar 25, 2015 at 11:07 AM, Jens Axboe ax...@fb.com wrote: Both buffered and O_DIRECT. Looks good, thanks Jens. Acked-by: Chris Mason c...@fb.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] Btrfs:__add_inode_ref: out of bounds memory read when looking for extended ref.

On Tue, Mar 3, 2015 at 9:38 AM, David Sterba dste...@suse.cz wrote: Adding linux-btrfs to CC On Thu, Feb 26, 2015 at 05:00:37PM +0100, Quentin Casasnovas wrote: Improper arithmetics when calculting the address of the extended ref could lead to an out of bounds memory read and kernel

Re: [PATCH] Btrfs:__add_inode_ref: out of bounds memory read when looking for extended ref.

On Tue, Mar 3, 2015 at 10:31 AM, Quentin Casasnovas quentin.casasno...@oracle.com wrote: Improper arithmetics when calculting the address of the extended ref could lead to an out of bounds memory read and kernel panic. Signed-off-by: Quentin Casasnovas quentin.casasno...@oracle.com ---

[GIT PULL] Btrfs

Hi Linus, I'm still testing more fixes, but I wanted to get out the fix for the btrfs raid5/6 memory corruption I mentioned in my merge window pull. Please pull my for-linus: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Chris Mason (1) commits (+8/-1

[GIT PULL] Btrfs for 4.1

) btrfs: Fix NO_SPACE bug caused by delayed-iput (+13/-1) btrfs: Support busy loop of write and delete (+14/-12) btrfs: fix condition of commit transaction (+15/-7) Chris Mason (9) commits (+656/-128): Btrfs: allow block group cache writeout outside critical section in commit (+341/-37

[GIT PULL] Btrfs fixes

Hi Linus, Filipe hit two problems in my block group cache patches. We finalized the fixes last week and ran through more tests. Can you please pull: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 Chris Mason (2) commits (+25/-17): Btrfs: prevent list

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

On 04/20/2015 01:27 AM, NeilBrown wrote: This allows fscache to cachefiles in a btrfs filesystem. Thanks for working on this Neil. Signed-off-by: Chris Mason c...@fb.com -chris Signed-off-by: NeilBrown ne...@suse.de --- fs/btrfs/super.c |3 ++- 1 file changed, 2 insertions(+), 1

[GIT PULL] Btrfs fixes

writeout and bg deletion (+27/-17) Btrfs: fix deadlock when starting writeback of bg caches (+1/-1) Yang Dongsheng (1) commits (+14/-9): Btrfs: fill -last_trans for delayed inode in btrfs_fill_inode. Chris Mason (1) commits (+1/-2): Btrfs: don't check for delalloc_bytes in cache_save_setup

[GIT PULL] Btrfs fix

Hi Linus, When an arm user reported crashes near page_address(page) in my new code, it became clear that I can't be trusted with GFP masks. Filipe beat me to the patch, and I'll just be in the corner with my dunce cap on. git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git

[GIT PULL] Btrfs fixes

Hi Linus, I have a few more fixes in my for-linus-4.1 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 The first commit is a fix from Filipe for a very old extent buffer reuse race that triggered a BUG_ON. It hasn't come up often, I looked through old

Re: [PATCH RFC 3/3] btrfs: add .copy_file_range file operation

btrfs error checks that should be shared. Thanks Zach, the btrfs bits look reasonable Signed-off-by: Chris Mason c...@fb.com -chris -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] fs: btrfs: Add missing include file

On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck li...@roeck-us.net wrote: On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote: Building alpha:allmodconfig fails with fs/btrfs/inode.c: In function 'check_direct_IO': fs/btrfs/inode.c:8050:2: error: implicit declaration of function

Re: [PATCH] fs: btrfs: Add missing include file

On Wed, Apr 1, 2015 at 3:58 PM, Guenter Roeck li...@roeck-us.net wrote: On 04/01/2015 12:28 PM, Chris Mason wrote: On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck li...@roeck-us.net wrote: On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote: Building alpha:allmodconfig fails

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: Hi all I am seeing the following crash on my btrfs filesystem with nfs export. If I disable the nfs share and reboot, I do not hit the crash. Look like the crash happens on btrfs with nfs export. Is this a known issue? Has anyone

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

On 05/19/2015 09:54 AM, Piotr Szymaniak wrote: On Tue, May 19, 2015 at 09:43:10AM -0400, Chris Mason wrote: On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: 2286---BUG_ON(!PageLocked(page)); [ 166.769868] BTRFS info (device sdf): no csum found for inode 1154 start 43192320

Re: [4.1-rc7] btrfs related VM_BUG_ON in filemap.c

On 06/10/2015 09:40 AM, Dave Jones wrote: Found this on serial console this morning. The machine had rebooted itself shortly afterwards (surprising, given I don't have panic-on-oops or similar set). We had one other report of this a few months ago. Josef and I read through all of this and

Re: [4.1-rc7] btrfs related VM_BUG_ON in filemap.c

On 06/16/2015 01:14 PM, David Sterba wrote: On Wed, Jun 10, 2015 at 01:43:31PM -0400, Chris Mason wrote: On 06/10/2015 09:40 AM, Dave Jones wrote: Found this on serial console this morning. The machine had rebooted itself shortly afterwards (surprising, given I don't have panic-on-oops

[GIT PULL] Btrfs

where it was possible to double allocate chunks on the drive. Mark has a fix for fiemap. All three will get bundled off for stable as well. Chris Mason (1) commits (+18/-0): Btrfs: fix regression in raid level conversion Filipe Manana (1) commits (+3/-0): Btrfs: fix racy system chunk

Re: [GIT PULL] Btrfs

On 05/26/2015 08:33 AM, Josh Boyer wrote: On Fri, May 22, 2015 at 9:14 PM, Chris Mason c...@fb.com wrote: Hi Linus, My for-linus-4.1 branch has three more fixes: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 I fixed up a regression from 4.0 where

[GIT PULL] Btrfs

Hi Linus, We have a btrfs quota regression fix in my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 I merged this one on Thursday and have run it through tests against current master. Normally I wouldn't have sent this while you were

Re: [RFC -v2 7/8] btrfs: Prevent from early transaction abort

On Tue, Aug 18, 2015 at 12:40:32PM +0200, Michal Hocko wrote: From: Michal Hocko mho...@suse.com Btrfs relies on GFP_NOFS allocation when commiting the transaction but since mm: page_alloc: do not lock up GFP_NOFS allocations upon OOM those allocations are allowed to fail which can lead to a

Re: [PATCH 0/2] btrfs: fortification for GFP_NOFS allocations

On Wed, Aug 19, 2015 at 02:17:39PM +0200, mho...@kernel.org wrote: Hi, these two patches were sent as a part of a larger RFC which aims at allowing GFP_NOFS allocations to fail to help sort out memory reclaim issues bound to the current behavior

Re: linux-next conflict resolution branch for btrfs

On Fri, Aug 21, 2015 at 10:45:24AM +1000, Stephen Rothwell wrote: Hi Chris, On Thu, 20 Aug 2015 13:39:18 -0400 Chris Mason c...@fb.com wrote: There are a few conflicts for btrfs in linux-next this time. They are small, but I pushed out the merge commit I'm using here: git

Re: linux-next conflict resolution branch for btrfs

On Fri, Aug 21, 2015 at 10:45:24AM +1000, Stephen Rothwell wrote: Hi Chris, On Thu, 20 Aug 2015 13:39:18 -0400 Chris Mason c...@fb.com wrote: There are a few conflicts for btrfs in linux-next this time. They are small, but I pushed out the merge commit I'm using here: git

linux-next conflict resolution branch for btrfs

Hi Stephen, There are a few conflicts for btrfs in linux-next this time. They are small, but I pushed out the merge commit I'm using here: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git next-merge -chris -- To unsubscribe from this list: send the line unsubscribe

[GIT PULL] Btrfs

Hi Linus, Please pull my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 Outside of our usual batch of fixes, this integrates the subvolume quota updates that Qu Wenruo from Fujitsu has been working on for a few releases now. He gets an

[GIT PULL] Btrfs

Hi Linus, Please pull the fixes from my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 Filipe fixed up a hard to trigger ENOSPC regression from our merge window pull, and we have a few other smaller fixes. Zhao Lei (2) commits (+4/-2):

Re: [PATCH block/for-linus] block: export bio_associate_*() and wbc_account_io()

On Thu, Jul 23, 2015 at 02:27:09PM -0400, Tejun Heo wrote: bio_associate_blkcg(), bio_associate_current() and wbc_account_io() are used to implement cgroup writeback support for filesystems and thus need to be exported. Export them. Thanks, these were the only three I needed on the btrfs

[GIT PULL] Btrfs

Hi Linus, We have some fixes in my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 These are all from Filipe, and cover a few problems we've had reported on the list recently (along with ones he found on his own). Filipe Manana (5)

Re: [PATCH 2/2] ubifs: Allow O_DIRECT

On Tue, Aug 25, 2015 at 09:46:11AM +1000, Dave Chinner wrote: On Mon, Aug 24, 2015 at 01:19:24PM -0400, Jeff Moyer wrote: Brian Norris computersforpe...@gmail.com writes: On Mon, Aug 24, 2015 at 10:13:25AM +0300, Artem Bityutskiy wrote: Now, some user-space fails when direct I/O is not

Re: [PATCH 2/2] ubifs: Allow O_DIRECT

On Tue, Aug 25, 2015 at 10:00:58AM -0400, Jeff Moyer wrote: Dave Chinner da...@fromorbit.com writes: On Mon, Aug 24, 2015 at 01:19:24PM -0400, Jeff Moyer wrote: Brian Norris computersforpe...@gmail.com writes: On Mon, Aug 24, 2015 at 10:13:25AM +0300, Artem Bityutskiy wrote: Now,

[GIT PULL] Btrfs

Hi Linus, I have two more small fixes this week in my for-linus-4.3 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.3 Qu's fix avoids unneeded COW during fallocate, and Christian found a memory leak in the error handling of an earlier fix. Qu Wenruo (1)

[GIT PULL] Btrfs

Hi Linus, My for-linus-4.4 branch is ready for pulling: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.4 Some of this got cherry-picked from a github repo this week, but I verified the patches. We have three small scrub cleanups and a collection of fixes.

Re: [PATCH/RFC] make btrfs subvol mounts appear in /proc/mounts

On Mon, Nov 02, 2015 at 03:50:12PM -0500, J. Bruce Fields wrote: > On Wed, Oct 28, 2015 at 07:25:10AM +0900, Neil Brown wrote: > > > > If you create a subvolume in btrfs and access it (by name) without > > mounting it, then the subvolume looks like a separate mount to some > > extent, returning a

[GIT PULL] Btrfs

out of dev_replace lock range Shan Hai (1) commits (+0/-3): btrfs/file.c: remove an unsed varialbe first_index Chris Mason (1) commits (+3/-5): btrfs: fix use after free iterating extrefs Robin Ruede (1) commits (+8/-2): btrfs: fix resending received snapshot with parent Geliang Tang (1) commits

[GIT PULL] Btrfs

sure balance on current kernels ignores filters it doesn't understand. The penalty for being wrong is just doing more work (not crashing etc), but it's a good fix. Chris Mason (1) commits (+3/-5): btrfs: fix use after free iterating extrefs David Sterba (1) commits (+13/-0): btrfs: check

[GIT PULL] Btrfs

Hi Linus, I have a few fixes in my for-linus-4.3 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.3 These are small and assorted. Neil's is the oldest, I dropped the ball thinking he was going to send it in. Filipe Manana (3) commits (+26/-12):

Re: [Ksummit-discuss] [CORE TOPIC] lightweight per-cpu locks / restartable sequences

On Thu, Jul 09, 2015 at 11:32:45AM -0700, Andy Lutomirski wrote: Several people have suggested that Linux should provide users with a lightweight mechanism that allows light-weight fancy per-cpu operations. This could be used to implement free lists or counters without any barriers or atomic

[GIT PULL] Btrfs

Hi Linus, Please pull my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 This is an assortment of fixes. Most of the commits are from Filipe (fsync, the inode allocation cache and a few others). Mark kicked in a series fixing corners in

[GIT PULL] Btrfs for 4.3

transaction abort (+2/-4) btrfs: use __GFP_NOFAIL in alloc_btrfs_bio (+1/-3) Liu Bo (2) commits (+7/-7): Btrfs: fix defrag to merge tail file extent (+5/-1) Btrfs: fix warning in backref walking (+2/-6) Chris Mason (2) commits (+33/-4): btrfs: fix compile when block cgroups ar

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Sat, Sep 12, 2015 at 04:29:06PM -0700, Linus Torvalds wrote: > On Sat, Sep 12, 2015 at 4:00 PM, Chris Mason <c...@fb.com> wrote: > > > > I did the plain revert as well, just to have a baseline. > > Ahh, I ended up not expecting you to get this done unti

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Fri, Sep 11, 2015 at 04:36:39PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 4:16 PM, Chris Mason <c...@fb.com> wrote: > > > > For 4.3 timeframes, what runs do you want to see numbers for: > > > > 1) revert > > 2) my hack > > 3) plug o

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Sat, Sep 12, 2015 at 07:46:32PM -0400, Chris Mason wrote: > I don't think the XFS numbers can be trusted too much since it was > basically bottlenecked behind that single pegged CPU. It was bouncing > around and I couldn't quite track it down to a process name (or perf > profil

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Mon, Sep 14, 2015 at 01:06:25PM -0700, Linus Torvalds wrote: > On Sun, Sep 13, 2015 at 4:12 PM, Dave Chinner wrote: > > > > Really need to run these numbers on slower disks where block layer > > merging makes a difference to performance. > > Yeah. We've seen plugging and

[PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

259] [] btrfs_raid_unplug+0x23/0x70 [btrfs] [ 2854.307334] [] blk_flush_plug_list+0x82/0x1f0 [ 2854.319542] [] blk_finish_plug+0x34/0x50 [ 2854.330878] [] writeback_sb_inodes+0x122/0x580 [ 2854.343256] [] wb_writeback+0x136/0x4e0 Signed-off-by: Chris Mason <c...@fb.com> Reviewed-by: Jens Axboe <

[GIT PULL] Btrfs

Hi Linus, We have a few more for the btrfs tree in my for-linus-4.3 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.3 These are small cleanups, and also some fixes for our async worker thread initialization. I was having some trouble testing these, but

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Fri, Sep 11, 2015 at 02:04:13PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 1:40 PM, Josef Bacik wrote: > > > > So we talked about this when we were trying to figure out a solution. The > > problem with this approach is now we have a plug that covers multiple super >

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Fri, Sep 11, 2015 at 03:06:18PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 2:04 PM, Linus Torvalds > wrote: > > > > Of course, actual numbers would be the deciding factor if this really > > is noticeable. But "cleaner code and saner locking" is

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Fri, Sep 11, 2015 at 05:52:27PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 4:36 PM, Linus Torvalds > wrote: > > > > Are we really ok with waiting synchronously for an inode while holding > > the plug? No chance of deadlock (waiting for IO that we've

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Wed, Sep 16, 2015 at 09:58:06PM +0200, Jan Kara wrote: > On Wed 16-09-15 11:16:21, Chris Mason wrote: > > Short version, Linus' patch still gives bigger IOs and similar perf to > > Dave's original. I should have done the blktrace runs for 60 seconds > > instead of 30, I su

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Thu, Sep 17, 2015 at 10:37:38AM +1000, Dave Chinner wrote: > [cc Tejun] > > On Thu, Sep 17, 2015 at 08:07:04AM +1000, Dave Chinner wrote: > > On Wed, Sep 16, 2015 at 04:00:12PM -0400, Chris Mason wrote: > > > On Wed, Sep 16, 2015 at 09:58:06PM +0200, Jan Kara wrote: &g

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Thu, Sep 17, 2015 at 02:30:08PM +1000, Dave Chinner wrote: > On Wed, Sep 16, 2015 at 11:48:59PM -0400, Chris Mason wrote: > > On Thu, Sep 17, 2015 at 10:37:38AM +1000, Dave Chinner wrote: > > > [cc Tejun] > > > > > > On Thu, Sep 17, 2015 at

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Thu, Sep 17, 2015 at 12:39:51PM -0700, Linus Torvalds wrote: > On Wed, Sep 16, 2015 at 7:14 PM, Dave Chinner wrote: > >> > >> Dave, if you're testing my current -git, the other performance issue > >> might still be the spinlock thing. > > > > I have the fix as the first

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Thu, Sep 17, 2015 at 04:08:19PM -0700, Linus Torvalds wrote: > On Thu, Sep 17, 2015 at 3:42 PM, Chris Mason <c...@fb.com> wrote: > > > > Playing around with the plug a little, most of the unplugs are coming > > from the cond_resched_lock(). Not really sure why we are

Re: ext4: performance regression introduced by the cgroup writeback support

On Wed, Sep 23, 2015 at 01:49:31PM +, Dexuan Cui wrote: > Hi all, > Since some point between July and Sep, I have been suffered from a strange > "very slow write" issue and on Sep 9 I reported it to LKML (but got no > reply): https://lkml.org/lkml/2015/9/9/290 > > The issue is: under high

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 03:49:12PM +0300, Artem Bityutskiy wrote: > On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote: > > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB. > > > > > > Signed-off-by: Tejun Heo > > > Cc: "Theodore Ts'o" > > > Cc: Andreas Dilger

Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 08:41:25PM +0300, Artem Bityutskiy wrote: >Hi > >$ sync >$ reboot If this is case, it should be possible to reproduce with: cp a bunch of stuff to /ext4 unmount /ext4 mount ext4 compare data If you're not getting a clean unmount of the test FS during the

[GIT PULL] Btrfs

Hi Linus, My for-linus-4.3 branch has a few fixes: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.3 This is an assorted set I've been queuing up: Jeff Mahoney tracked down a tricky one where we ended up starting IO on the wrong mapping for special files in

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

On Thu, Sep 17, 2015 at 11:04:03PM -0700, Linus Torvalds wrote: > On Thu, Sep 17, 2015 at 10:40 PM, Dave Chinner wrote: > > > > Ok, makes sense - the plug is not being flushed as we switch away, > > but Chris' patch makes it do that. > > Yup. Huh, that does make much more

Re: [PATCH 1/3] BTRFS: support NFSv2 export

On Thu, Sep 24, 2015 at 11:59:02AM +1000, Neil Brown wrote: > David Sterba writes: > > > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote: > >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as > >> that returned by encode_fh - it may be larger. > >>

Re: 4.4rc3 nfsd/btrfs kasan warning.

On Wed, Dec 02, 2015 at 11:09:43AM -0500, Dave Jones wrote: > On Wed, Dec 02, 2015 at 10:11:28AM -0500, Josef Bacik wrote: > > On 12/02/2015 09:59 AM, Dave Jones wrote: > > > Got a few of these in the logs this morning after an overnight rsync > over nfs > > > to an exported btrfs volume. > >

Re: 4.4rc3 nfsd/btrfs kasan warning.

On Wed, Dec 02, 2015 at 09:32:34PM +0300, Andrey Ryabinin wrote: > 2015-12-02 20:14 GMT+03:00 Chris Mason <c...@fb.com>: > > On Wed, Dec 02, 2015 at 11:09:43AM -0500, Dave Jones wrote: > >> On Wed, Dec 02, 2015 at 10:11:28AM -0500, Josef Bacik wrote: > >> >

Re: new oops in 4.4.0-rc4

On Thu, Dec 10, 2015 at 10:36:17AM -0600, Jon Christopherson wrote: > Hello, > > I noticed this new oops since running 4.4.0-rc4. Happens shortly after boot > and pretty much kills the system: > > > [ 177.774250] [ cut here ] > >[ 177.774256] kernel BUG at

Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

On Mon, Dec 14, 2015 at 01:33:56PM -0500, Dave Jones wrote: > On Sat, Dec 12, 2015 at 07:07:46PM -0500, Chris Mason wrote: > > On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > > > On Sat, Dec 12, 2015 at 10:33 AM, Linus Torvalds > > > <torva.

Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

On Sun, Dec 13, 2015 at 10:50:01AM +0100, Peter Zijlstra wrote: > On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > > It looks like PeterZ's pending patch should fix this, by passing in > > the proper TASK_UNINTERRUPTIBLE to the bit_wait_io function, and going > > back to

[PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

f it's a dup. Reported-by: Dave Jones <d...@fb.com>, Reported-by: Jon Christopherson <j...@jons.org> Signed-off-by: Chris Mason <c...@fb.com> diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c index f10bd87..12f69df 100644 --- a/kernel/sched/wait.c +++ b/kernel/sched

Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

On Mon, Dec 14, 2015 at 01:33:56PM -0500, Dave Jones wrote: > On Sat, Dec 12, 2015 at 07:07:46PM -0500, Chris Mason wrote: > > On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > > > On Sat, Dec 12, 2015 at 10:33 AM, Linus Torvalds > > > <torva.

Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > On Sat, Dec 12, 2015 at 10:33 AM, Linus Torvalds > wrote: > > > > Peter, did that patch also handle just plain "lock_page()" case? > > Looking more at it, I think this all goes back to commit

Re: [PATCH RESEND 2/2] btrfs:Fix error handling in the function btrfs_dev_replace_kthread

On Tue, Dec 29, 2015 at 08:10:07PM -0500, Nicholas Krause wrote: > This fixes error handling in the function btrfs_dev_replace_kthread > by checking if the call to the function btrfs_dev_replace_continue_on_mount > has failed and if so return the error code to this function's caller in > order to

Re: [PATCH RESEND] btrfs:Fix incorrect return statement if failure occurs in the function btrfs_mark_extent_written

On Tue, Dec 29, 2015 at 08:20:47PM -0500, Nicholas Krause wrote: > This fixes the incorrect return statement if failure occurs by > returning 0 rather then the variable ret which may hold a error > code to signal when a failure has occurred in the function > btrfs_mark_extent_written to its

[GIT PULL] Btrfs

Hi Linus, A couple of small fixes in my for-linus-4.4 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.4 Chris Mason (2) commits (+19/-7): Btrfs: check for empty bitmap list in setup_cluster_bitmaps (+5/-3) Btrfs: check prepare_uptodate_page

<    1   2   3   4   5   6   7   8   9   10   >