Re: Re: [PATCH 5/9] KVM: selftests: Align memory region addresses to 1M on s390x

2019-05-24 Thread Christian Borntraeger
On 23.05.19 19:40, Andrew Jones wrote: > On Thu, May 23, 2019 at 06:43:05PM +0200, Thomas Huth wrote: >> On s390x, there is a constraint that memory regions have to be aligned >> to 1M (or running the VM will fail). Introduce a new "alignment" variable >> in the vm_userspace_mem_region_add()

Re: [RFC PATCH 1/4] KVM: selftests: Guard struct kvm_vcpu_events with __KVM_HAVE_VCPU_EVENTS

2019-05-20 Thread Christian Borntraeger
On 20.05.19 10:08, Thomas Huth wrote: > On 20/05/2019 09.12, Christian Borntraeger wrote: >> >> On 16.05.19 13:12, Thomas Huth wrote: >>> The struct kvm_vcpu_events code is only available on certain architectures >>> (arm, arm64 and x86). To be able to

Re: [RFC PATCH 1/4] KVM: selftests: Guard struct kvm_vcpu_events with __KVM_HAVE_VCPU_EVENTS

2019-05-20 Thread Christian Borntraeger
by: Thomas Huth Acked-by: Christian Borntraeger According to the MAINTAINERS patches, you want me to pick these patches. Correct? > --- > tools/testing/selftests/kvm/include/kvm_util.h | 2 ++ > tools/testing/selftests/kvm/lib/kvm_util.c | 2 ++ > 2 files changed, 4 insertions

Re: [PATCH v2 1/2] KVM: Start populating /sys/hypervisor with KVM entries

2019-05-14 Thread Christian Borntraeger
On 14.05.19 18:09, Sironi, Filippo wrote: >> Isnt kvm_para_available a function that is defined in the context of the HOST >> and not of the guest? > > No, kvm_para_available is defined in the guest context. > On x86, it checks for the presence of the KVM CPUID leafs. > Right you are, I

Re: [PATCH v2 1/2] KVM: Start populating /sys/hypervisor with KVM entries

2019-05-14 Thread Christian Borntraeger
On 14.05.19 17:16, Filippo Sironi wrote: > Start populating /sys/hypervisor with KVM entries when we're running on > KVM. This is to replicate functionality that's available when we're > running on Xen. > > Start with /sys/hypervisor/uuid, which users prefer over >

Re: [PATCH] KVM: s390: vsie: Do not shadow CRYCB when no AP and no keys

2019-04-29 Thread Christian Borntraeger
BD > validity") > Fixes: 6ee74098201b ("KVM: s390: vsie: allow CRYCB FORMAT-0") > > Signed-off-by: Pierre Morel > Reported-by: Christian Borntraeger > --- > arch/s390/kvm/vsie.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff

Re: [PATCH] KVM: s390: vsie: Return correct values for Invalid CRYCB format

2019-04-29 Thread Christian Borntraeger
On 26.04.19 11:00, Pierre Morel wrote: > Let's use the correct validity number. > > Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2" > > Signed-off-by: Pierre Morel > Reviewed-by: Christian Borntraeger > --- > arch/s390/kvm/vsie.c | 2 +- > 1 fil

Re: [PATCH] KVM: s390: vsie: Do not shadow CRYCB when no AP and no keys

2019-04-26 Thread Christian Borntraeger
BD > validity") > Fixes: 6ee74098201b ("KVM: s390: vsie: allow CRYCB FORMAT-0") > > Signed-off-by: Pierre Morel > Reported-by: Christian Borntraeger Tested-by: Christian Borntraeger Reviewed-by: Christian Borntraeger > --- > arch/s390/kvm/vsie.c

Re: [PATCH] KVM: s390: vsie: Return correct values for Invalid CRYCB format

2019-04-26 Thread Christian Borntraeger
'55ded154b43': unknown revision or path not in > the working tree. > Use '--' to separate paths from revisions, like this: > I think this should be 56019f9aca2266edc7f304d91e4e772023b7aa14 > >> >> Signed-off-by: Pierre Morel >> Reviewed-by: Christian Borntraeger

Re: [PATCH v4 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-01 Thread Christian Borntraeger
On 01.03.2019 13:03, Pierre Morel wrote: > On 28/02/2019 15:14, Pierre Morel wrote: >> On 28/02/2019 14:52, Cornelia Huck wrote: >>> On Thu, 28 Feb 2019 14:16:09 +0100 >>> Pierre Morel wrote: >>> On 28/02/2019 12:22, Cornelia Huck wrote: >>> > So, to summarize, the function should do:

Re: [PATCH v4 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-01 Thread Christian Borntraeger
On 28.02.2019 16:35, Tony Krowiak wrote: > On 2/28/19 4:42 AM, Christian Borntraeger wrote: >> >> >> On 27.02.2019 19:00, Tony Krowiak wrote: >>> On 2/27/19 3:09 AM, Pierre Morel wrote: >>>> On 26/02/2019 16:47, Tony Krowiak wrote: >>>>>

Re: [PATCH v4 4/7] vfio: ap: register IOMMU VFIO notifier

2019-02-28 Thread Christian Borntraeger
On 28.02.2019 17:55, Halil Pasic wrote: > On Thu, 28 Feb 2019 09:48:39 +0100 > Pierre Morel wrote: > >> On 28/02/2019 09:23, Christian Borntraeger wrote: >>> On 22.02.2019 16:29, Pierre Morel wrote: >>>> To be able to use the VFIO interface to facilitate th

Re: [PATCH v4 5/7] s390: ap: implement PAPQ AQIC interception in kernel

2019-02-28 Thread Christian Borntraeger
On 22.02.2019 16:29, Pierre Morel wrote: > We register the AP PQAP instruction hook during the open > of the mediated device. And unregister it on release. > > In the AP PQAP instruction hook, if we receive a demand to > enable IRQs, > - we retrieve the vfio_ap_queue based on the APQN we

Re: [PATCH v4 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-02-28 Thread Christian Borntraeger
On 28.02.2019 14:23, Pierre Morel wrote: > On 28/02/2019 10:42, Christian Borntraeger wrote: >> >> >> On 27.02.2019 19:00, Tony Krowiak wrote: >>> On 2/27/19 3:09 AM, Pierre Morel wrote: >>>> On 26/02/2019 16:47, Tony Krowiak wrote: >>>>>

Re: [PATCH v4 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-02-28 Thread Christian Borntraeger
On 28.02.2019 10:42, Christian Borntraeger wrote: [...] >> Okay, let's go back to the genesis of this discussion; namely, my >> suggestion about moving the fc == 0x03 check into the hook code. If >> the vfio_ap module is not loaded, there will be no hook code. In that

Re: [PATCH v4 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-02-28 Thread Christian Borntraeger
On 27.02.2019 19:00, Tony Krowiak wrote: > On 2/27/19 3:09 AM, Pierre Morel wrote: >> On 26/02/2019 16:47, Tony Krowiak wrote: >>> On 2/26/19 6:47 AM, Pierre Morel wrote: On 25/02/2019 19:36, Tony Krowiak wrote: > On 2/22/19 10:29 AM, Pierre Morel wrote: >> We prepare the

Re: [PATCH v4 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-02-28 Thread Christian Borntraeger
On 25.02.2019 19:36, Tony Krowiak wrote: > On 2/22/19 10:29 AM, Pierre Morel wrote: >> We prepare the interception of the PQAP/AQIC instruction for >> the case the AQIC facility is enabled in the guest. >> >> We add a callback inside the KVM arch structure for s390 for >> a VFIO driver to

Re: [PATCH v4 4/7] vfio: ap: register IOMMU VFIO notifier

2019-02-28 Thread Christian Borntraeger
On 22.02.2019 16:29, Pierre Morel wrote: > To be able to use the VFIO interface to facilitate the > mediated device memory pining/unpining we need to register > a notifier for IOMMU. You might want to add that while we start to pin one guest page for the interrupt indicator byte in the next

Re: [PATCH v3 1/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-21 Thread Christian Borntraeger
change the search for the devices on the vfio_ap driver in > the function vfio_ap_verify_queue_reserved. > > Fixes: 1fde573413b5 ("s390: vfio-ap: base implementation of VFIO AP device > driver") > > Cc: sta...@vger.kernel.org > > Reported-by: Marc Hartmayer > Repor

Re: [PATCH v2 1/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-21 Thread Christian Borntraeger
On 21.02.2019 13:51, Pierre Morel wrote: > On 21/02/2019 13:35, Christian Borntraeger wrote: >> >> [..] >> Go ahead and send this as v3? >> > > OK > CC stable ? Yes, also add a "Fixes:" tag.

Re: [PATCH v2 1/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-21 Thread Christian Borntraeger
On 21.02.2019 13:10, Pierre Morel wrote: > On 20/02/2019 13:51, Halil Pasic wrote: >> On Wed, 20 Feb 2019 10:27:31 +0100 >> Cornelia Huck wrote: >> >>> On Tue, 19 Feb 2019 22:31:17 +0100 >>> Pierre Morel wrote: >>> On 19/02/2019 19:52, Tony Krowiak wrote: > On 2/18/19 1:08 PM, Pierre

Re: [PATCH v2 1/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-20 Thread Christian Borntraeger
t; Since the associated matrix driver is not the vfio_ap driver any more, >> we have to change the search for the devices on the vfio_ap driver in >> the function vfio_ap_verify_queue_reserved. >> >> Reported-by: Marc Hartmayer >> Reported-by: Christian Bornt

Re: [PATCH v2 1/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-19 Thread Christian Borntraeger
gt; > s/suppress/remove/ ? > >> anymore. >> >> Since the associated matrix driver is not the vfio_ap driver any more, >> we have to change the search for the devices on the vfio_ap driver in >> the function vfio_ap_verify_queue_reserved. >> >> Reported-by: Mar

Re: [PATCH v2 1/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-19 Thread Christian Borntraeger
change the search for the devices on the vfio_ap driver in > the function vfio_ap_verify_queue_reserved. > > Reported-by: Marc Hartmayer > Reported-by: Christian Borntraeger Can you also add a "Fixes:" tag Tested-by: Christian Borntraeger Would be good to have someone

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Christian Borntraeger
On 14.02.2019 15:54, Cornelia Huck wrote: > On Thu, 14 Feb 2019 14:51:01 +0100 > Pierre Morel wrote: Pierre, this is independent from this series and should have been sent separately. In the end (when we have the final solution) this will require cc stable. > >> Libudev relies on having a

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Christian Borntraeger
On 14.02.2019 14:51, Pierre Morel wrote: > Libudev relies on having a subsystem link for non-root devices. To > avoid libudev (and potentially other userspace tools) choking on the > matrix device let us introduce a vfio_ap bus and with that the vfio_ap > bus subsytem, and make the matrix

Re: [PATCH 4.20 193/352] KVM: s390: unregister debug feature on failing arch init

2019-02-11 Thread Christian Borntraeger
enbrand > Message-Id: <20181130143215.69496-2-m...@linux.ibm.com> > Signed-off-by: Christian Borntraeger > Signed-off-by: Sasha Levin It does not hurt, but I explicitly did not cc stable for this patch as kvm_register_device_ops only fails in case of a code error. > --- >

Re: [PATCH v2] s390: vsie: Use effective CRYCBD.31 to check CRYCBD validity

2019-02-11 Thread Christian Borntraeger
Signed-off-by: Pierre Morel > Reported-by: Claudio Imbrenda > Acked-by: David Hildenbrand Reviewed-by: Christian Borntraeger thanks applied. > --- > arch/s390/kvm/vsie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/vsie.c b/arch/s39

Re: [PATCH v7 00/15] KVM: s390: make use of the GIB

2019-02-06 Thread Christian Borntraeger
Series Applied and queued. see https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git/log/?h=next On 31.01.2019 09:52, Michael Mueller wrote: > The Guest Information Area (GIB) and its mechanics is part of > the AIV facility. It provides hardware support to process > Adapter

Re: [PATCH v7 15/15] KVM: s390: fix possible null pointer dereference in pending_irqs()

2019-02-05 Thread Christian Borntraeger
On 31.01.2019 18:47, Cornelia Huck wrote: > On Thu, 31 Jan 2019 09:52:46 +0100 > Michael Mueller wrote: > >> Assure a GISA is in use before accessing the IPM to avoid a >> null pointer dereference issue. > > This series can hopefully make it into the next merge window; > otherwise, queuing a

Re: [PATCH v1] KVM: s390: vsie: fix Do the CRYCB validation first

2019-02-04 Thread Christian Borntraeger
On 01.02.2019 14:37, Pierre Morel wrote: > On 01/02/2019 11:56, David Hildenbrand wrote: >> On 01.02.19 10:52, Pierre Morel wrote: >>> The case when the SIE for guest3 is not setup for using >>> encryption keys nor Adjunct processor but the guest2 >>> does use these features was not properly

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-23 Thread Christian Borntraeger
On 23.01.2019 00:11, Paolo Bonzini wrote: > On 22/01/19 21:48, Greg Kroah-Hartman wrote: >>> This also brings the question: shall we move these counters out of debugfs >>> into something else? >> If you have code that relies on debugfs, yes, you need to move that out >> of debugfs because more

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Christian Borntraeger
On 22.01.2019 16:21, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc:

Re: [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation

2019-01-09 Thread Christian Borntraeger
On 09.01.2019 15:52, Michael S. Tsirkin wrote: > On Wed, Jan 09, 2019 at 01:07:16PM +0100, Christian Borntraeger wrote: >> On 09.01.2019 11:35, Wei Wang wrote: >>> On 01/08/2019 04:46 PM, Christian Borntraeger wrote: >>>> >>>> On 08.01.2019 06:35, We

Re: [PATCH v1 2/2] virtio: don't allocate vqs when names[i] = NULL

2019-01-09 Thread Christian Borntraeger
Cc: sta...@vger.kernel.org Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") On 28.12.2018 03:26, Wei Wang wrote: > Some vqs may not need to be allocated when their related feature bits > are disabled. So callers may pass in such vqs with "names = NULL". > Then we skip such

Re: [PATCH v1 1/2] virtio_pci: use queue idx instead of array idx to set up the vq

2019-01-09 Thread Christian Borntraeger
Cc: sta...@vger.kernel.org Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") On 28.12.2018 03:26, Wei Wang wrote: > When find_vqs, there will be no vq[i] allocation if its corresponding > names[i] is NULL. For example, the caller may pass in names[i] (i=4) > with names[2]

Re: [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation

2019-01-09 Thread Christian Borntraeger
On 09.01.2019 11:35, Wei Wang wrote: > On 01/08/2019 04:46 PM, Christian Borntraeger wrote: >> >> On 08.01.2019 06:35, Wei Wang wrote: >>> On 01/07/2019 09:49 PM, Christian Borntraeger wrote: >>>> On 07.01.2019 08:01, Wei Wang wrote: >>>>> vir

Re: [PATCH] vhost/vsock: fix vhost vsock cid hashing inconsistent

2019-01-09 Thread Christian Borntraeger
Adding Peter, is this the same problem that you reported me today? Can you test Zha Bins patch? Christian On 08.01.2019 09:07, Zha Bin wrote: > The vsock core only supports 32bit CID, but the Virtio-vsock spec define > CID (dst_cid and src_cid) as u64 and the upper 32bits is reserved as > zero.

Re: [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation

2019-01-08 Thread Christian Borntraeger
On 08.01.2019 06:35, Wei Wang wrote: > On 01/07/2019 09:49 PM, Christian Borntraeger wrote: >> >> On 07.01.2019 08:01, Wei Wang wrote: >>> virtio-ccw has deadlock issues with reading the config space inside the >>> interrupt context, so we tweak the v

Re: [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation

2019-01-07 Thread Christian Borntraeger
tmap is used as a flag to the workqueue callbacks > about the related config fields that need to be read. > > The cmd_id_received is also renamed to cmd_id_received_cache, and > the value should be obtained via virtio_balloon_cmd_id_received. > > Reported-by: Christian Borntrae

Re: [PATCH v3 0/3] virtio-balloon: tweak config_changed

2019-01-07 Thread Christian Borntraeger
On 07.01.2019 14:45, Michael S. Tsirkin wrote: > On Mon, Jan 07, 2019 at 03:01:03PM +0800, Wei Wang wrote: >> Since virtio-ccw doesn't work with accessing to the config space >> inside an interrupt context, this patch series avoids that issue by >> moving the config register accesses to the

Re: [PATCH v3 0/3] virtio-balloon: tweak config_changed

2019-01-07 Thread Christian Borntraeger
Can you please cc stable? Right now 4.20 does not work under KVM. On 07.01.2019 08:01, Wei Wang wrote: > Since virtio-ccw doesn't work with accessing to the config space > inside an interrupt context, this patch series avoids that issue by > moving the config register accesses to the related

Re: [PATCH 4.20 005/145] tap: call skb_probe_transport_header after setting skb->dev

2019-01-07 Thread Christian Borntraeger
w_dissector: lookup netns by skb->sk if skb->dev is > NULL") > Reported-by: Christian Borntraeger > Signed-off-by: Willem de Bruijn > Signed-off-by: David S. Miller > Signed-off-by: Greg Kroah-Hartman I can confirm that this fixes my issue. Tested-by: Christian Bo

Re: [PATCH v37 1/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-12-28 Thread Christian Borntraeger
On 28.12.2018 04:12, Wei Wang wrote: > On 12/27/2018 08:03 PM, Christian Borntraeger wrote: >> On 27.08.2018 03:32, Wei Wang wrote: >>>   static int init_vqs(struct virtio_balloon *vb) >>>   { >>> -    struct virtqueue *vqs[3]; >>> -    vq_callbac

Re: [PATCH v1 0/2] Virtio: fix some vq allocation issues

2018-12-27 Thread Christian Borntraeger
On 28.12.2018 03:26, Wei Wang wrote: > Some vqs don't need to be allocated when the related feature bits are > disabled. Callers notice the vq allocation layer by setting the related > names[i] to be NULL. > > This patch series fixes the find_vqs implementations to handle this case. So the

Re: 4.19.5 and later has tons of false messages "BUG: non-zero pgtables_bytes on freeing mm: -16384"

2018-12-27 Thread Christian Borntraeger
On 12/27/2018 10:01 PM, Sasha Levin wrote: > On Thu, Dec 27, 2018 at 10:28:56AM +0100, Christian Borntraeger wrote: >> >> >> On 27.12.2018 10:13, Christian Borntraeger wrote: >>> Martin, >>> >>> Right now you get a message >>> "BUG

Re: [PATCH v37 0/3] Virtio-balloon: support free page reporting

2018-12-27 Thread Christian Borntraeger
On 27.12.2018 12:59, Christian Borntraeger wrote: > On 27.12.2018 12:31, Christian Borntraeger wrote: >> This patch triggers random crashes in the guest kernel on s390 early during >> boot. >> No migration and no setting of the balloon is involved. >>

Re: [PATCH v37 1/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-12-27 Thread Christian Borntraeger
On 27.08.2018 03:32, Wei Wang wrote: > static int init_vqs(struct virtio_balloon *vb) > { > - struct virtqueue *vqs[3]; > - vq_callback_t *callbacks[] = { balloon_ack, balloon_ack, stats_request > }; > - static const char * const names[] = { "inflate", "deflate", "stats" }; > -

Re: [PATCH v37 0/3] Virtio-balloon: support free page reporting

2018-12-27 Thread Christian Borntraeger
On 27.12.2018 12:31, Christian Borntraeger wrote: > This patch triggers random crashes in the guest kernel on s390 early during > boot. > No migration and no setting of the balloon is involved. > Adding Conny and Halil, As the QEMU provides no PAGE_HINT feature yet, this quic

Re: [PATCH v37 0/3] Virtio-balloon: support free page reporting

2018-12-27 Thread Christian Borntraeger
This patch triggers random crashes in the guest kernel on s390 early during boot. No migration and no setting of the balloon is involved. On 27.08.2018 03:32, Wei Wang wrote: > The new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT, implemented by this > series enables the virtio-balloon driver to

Re: 4.19.5 and later has tons of false messages "BUG: non-zero pgtables_bytes on freeing mm: -16384"

2018-12-27 Thread Christian Borntraeger
On 27.12.2018 10:13, Christian Borntraeger wrote: > Martin, > > Right now you get a message > "BUG: non-zero pgtables_bytes on freeing mm: -16384" > for EVERY process that exits in 4.19.5 and later. > > bisect points to > commit 4136161d676a93fc8df6bdb

4.19.5 and later has tons of false messages "BUG: non-zero pgtables_bytes on freeing mm: -16384"

2018-12-27 Thread Christian Borntraeger
Martin, Right now you get a message "BUG: non-zero pgtables_bytes on freeing mm: -16384" for EVERY process that exits in 4.19.5 and later. bisect points to commit 4136161d676a93fc8df6bdb80d720c15522d6c24 Author: Martin Schwidefsky Date: Mon Oct 15 11:09:16 2018 +0200 s390/mm: fix

Re: 4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-20 Thread Christian Borntraeger
On 20.12.2018 18:23, Willem de Bruijn wrote: > On Thu, Dec 20, 2018 at 11:17 AM Ido Schimmel wrote: >> >> On Thu, Dec 20, 2018 at 03:09:22PM +0100, Christian Borntraeger wrote: >>> On 20.12.2018 10:12, Ido Schimmel wrote: >>>> +Willem >>>&g

Re: 4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-20 Thread Christian Borntraeger
On 20.12.2018 10:12, Ido Schimmel wrote: > +Willem > > On Thu, Dec 20, 2018 at 08:45:40AM +0100, Christian Borntraeger wrote: >> Folks, >> >> I got this warning today. I cant tell when and why this happened, so I do >> not know yet how to reproduce.

Re: [PATCH v5 01/15] KVM: s390: unregister debug feature on failing arch init

2018-12-19 Thread Christian Borntraeger
upon unsuccessful architecture initialization. >>> >>> A related indication of the issue will be reported as kernel >>> message. >>> >>> Signed-off-by: Michael Mueller >>> Reviewed-by: Cornelia Huck >>> Reviewed-by: Pierre Morel >>> Rev

4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-19 Thread Christian Borntraeger
Folks, I got this warning today. I cant tell when and why this happened, so I do not know yet how to reproduce. Maybe someone has a quick idea. [85109.572032] WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect+0x1f0/0x1318 [85109.572036] Modules linked in:

Re: [PATCH 15/52] fuse: map virtio_fs DAX window BAR

2018-12-12 Thread Christian Borntraeger
On 10.12.2018 18:12, Vivek Goyal wrote: > From: Stefan Hajnoczi > +static int virtio_fs_setup_dax(struct virtio_device *vdev, struct virtio_fs > *fs) > +{ > + struct virtio_fs_memremap_info *mi; > + struct dev_pagemap *pgmap; > + struct pci_dev *pci_dev; > + phys_addr_t

[PATCH] MAINTAINERS/vfio-ccw: add Farhan and Eric, make Halil Reviewer

2018-12-12 Thread Christian Borntraeger
Eric and Farhan will help with maintaining vfio-ccw. Cc: Cornelia Huck Cc: Halil Pasic Cc: Farhan Ali Cc: Eric Farman Signed-off-by: Christian Borntraeger --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8119141a926f

Re: [PATCH] genwqe: Fix size check

2018-12-12 Thread Christian Borntraeger
On 12.12.2018 15:18, haver wrote: > Hi Christian, > > On 2018-12-12 14:45, Christian Borntraeger wrote: >> Calling the test program genwqe_cksum with the default buffer size of >> 2MB triggers the following kernel warning on s390: >> >> WARNING: CPU: 30

[PATCH] genwqe: Fix size check

2018-12-12 Thread Christian Borntraeger
he mm code uses ">= MAX_ORDER". Fix genwqe. Cc: sta...@vger.kernel.org Signed-off-by: Christian Borntraeger --- drivers/misc/genwqe/card_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c index 3fc

Re: [PATCH 1/1] s390: vfio-ap: include for test_facility()

2018-11-16 Thread Christian Borntraeger
vfio_ap_drv.c > > > > > > > > Files should not rely on such fragile implicit includes. > > Signed-off-by: Petr Tesarik Acked-by: Christian Borntraeger > --- > drivers/s390/crypto/vfio_ap_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [PATCH 1/1] s390: vfio-ap: include for test_facility()

2018-11-16 Thread Christian Borntraeger
vfio_ap_drv.c > > > > > > > > Files should not rely on such fragile implicit includes. > > Signed-off-by: Petr Tesarik Acked-by: Christian Borntraeger > --- > drivers/s390/crypto/vfio_ap_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: Linux kernel crash

2018-10-27 Thread Christian Borntraeger
On 10/27/2018 06:07 AM, Stephen Smith wrote: > On Wednesday, October 24, 2018 10:20:05 PM MST Stephen Smith wrote: >> >> Whenever I run "shutdown -h now" or "reboot" I receive an immediate kernel >> crash with a dump that has: >> >> "Code: Bad RIP value" > > I Canonical response noted the

Re: Linux kernel crash

2018-10-27 Thread Christian Borntraeger
On 10/27/2018 06:07 AM, Stephen Smith wrote: > On Wednesday, October 24, 2018 10:20:05 PM MST Stephen Smith wrote: >> >> Whenever I run "shutdown -h now" or "reboot" I receive an immediate kernel >> crash with a dump that has: >> >> "Code: Bad RIP value" > > I Canonical response noted the

Re: [PATCH] KVM: Start populating /sys/hypervisor with KVM entries

2018-10-09 Thread Christian Borntraeger
On 10/09/2018 11:54 AM, Filippo Sironi wrote: > Start populating /sys/hypervisor with KVM entries when we're running on > KVM. This is to replicate functionality that's available when we're > running on Xen. > > Let's start with /sys/hypervisor/uuid, which users prefer over >

Re: [PATCH] KVM: Start populating /sys/hypervisor with KVM entries

2018-10-09 Thread Christian Borntraeger
On 10/09/2018 11:54 AM, Filippo Sironi wrote: > Start populating /sys/hypervisor with KVM entries when we're running on > KVM. This is to replicate functionality that's available when we're > running on Xen. > > Let's start with /sys/hypervisor/uuid, which users prefer over >

Re: [PATCH v1 0/2] KVM: s390: Tracing APCB changes

2018-10-05 Thread Christian Borntraeger
Both applied. (FWIW, this was based on an older version of the ap patch set, I had to fixup the 2 patch) On 10/05/2018 10:31 AM, Pierre Morel wrote: > In the first patch we define kvm_arch_crypto_set_masks, > a new function to centralize the setup the APCB masks > inside the CRYCB SIE satelite

Re: [PATCH v1 0/2] KVM: s390: Tracing APCB changes

2018-10-05 Thread Christian Borntraeger
Both applied. (FWIW, this was based on an older version of the ap patch set, I had to fixup the 2 patch) On 10/05/2018 10:31 AM, Pierre Morel wrote: > In the first patch we define kvm_arch_crypto_set_masks, > a new function to centralize the setup the APCB masks > inside the CRYCB SIE satelite

Re: [PATCH] s390: vfio-ap: trace the update of APCB masks

2018-10-05 Thread Christian Borntraeger
On 10/05/2018 09:54 AM, David Hildenbrand wrote: > On 05/10/2018 09:50, Cornelia Huck wrote: >> On Fri, 5 Oct 2018 09:33:01 +0200 >> Pierre Morel wrote: >> >>> Define a tracing function to trace in the KVM trace buffer >>> and trace the changes of the APCB masks. >> >> In general, trace

Re: [PATCH] s390: vfio-ap: trace the update of APCB masks

2018-10-05 Thread Christian Borntraeger
On 10/05/2018 09:54 AM, David Hildenbrand wrote: > On 05/10/2018 09:50, Cornelia Huck wrote: >> On Fri, 5 Oct 2018 09:33:01 +0200 >> Pierre Morel wrote: >> >>> Define a tracing function to trace in the KVM trace buffer >>> and trace the changes of the APCB masks. >> >> In general, trace

Re: [FIXUP v9] fixup! fixup! s390: doc: detailed specifications for AP virtualization

2018-09-28 Thread Christian Borntraeger
On 09/28/2018 03:43 PM, Tony Krowiak wrote: > From: Tony Krowiak > > Removes extraneous text from third line below: > > +05 CEX5A Accelerator > +05.0047 CEX5A Accelerator > +05.00ff CEX5A Accelerator (5,4), (5,171), (6,4), (6,171), >

Re: [FIXUP v9] fixup! fixup! s390: doc: detailed specifications for AP virtualization

2018-09-28 Thread Christian Borntraeger
On 09/28/2018 03:43 PM, Tony Krowiak wrote: > From: Tony Krowiak > > Removes extraneous text from third line below: > > +05 CEX5A Accelerator > +05.0047 CEX5A Accelerator > +05.00ff CEX5A Accelerator (5,4), (5,171), (6,4), (6,171), >

Re: [FIXUP v11] fixup! s390: vfio-ap: implement mediated device open callback

2018-09-28 Thread Christian Borntraeger
On 09/28/2018 03:41 PM, Halil Pasic wrote: > > > On 09/28/2018 03:35 PM, Cornelia Huck wrote: >> On Fri, 28 Sep 2018 09:33:21 -0400 >> Tony Krowiak wrote: >> >>> From: Tony Krowiak >>> >>> Fixes case statement in vfio_ap_mdev_copy_masks() function in >>> vfio-ap-ops.c. >>> --- >>>

Re: [FIXUP v11] fixup! s390: vfio-ap: implement mediated device open callback

2018-09-28 Thread Christian Borntraeger
On 09/28/2018 03:41 PM, Halil Pasic wrote: > > > On 09/28/2018 03:35 PM, Cornelia Huck wrote: >> On Fri, 28 Sep 2018 09:33:21 -0400 >> Tony Krowiak wrote: >> >>> From: Tony Krowiak >>> >>> Fixes case statement in vfio_ap_mdev_copy_masks() function in >>> vfio-ap-ops.c. >>> --- >>>

Re: [FIXUP v11] fixup! s390: vfio-ap: implement mediated device open callback

2018-09-28 Thread Christian Borntraeger
On 09/28/2018 03:35 PM, Cornelia Huck wrote: > On Fri, 28 Sep 2018 09:33:21 -0400 > Tony Krowiak wrote: > >> From: Tony Krowiak >> >> Fixes case statement in vfio_ap_mdev_copy_masks() function in >> vfio-ap-ops.c. >> --- >> drivers/s390/crypto/vfio_ap_ops.c | 3 ++- >> 1 file changed, 2

Re: [FIXUP v11] fixup! s390: vfio-ap: implement mediated device open callback

2018-09-28 Thread Christian Borntraeger
On 09/28/2018 03:35 PM, Cornelia Huck wrote: > On Fri, 28 Sep 2018 09:33:21 -0400 > Tony Krowiak wrote: > >> From: Tony Krowiak >> >> Fixes case statement in vfio_ap_mdev_copy_masks() function in >> vfio-ap-ops.c. >> --- >> drivers/s390/crypto/vfio_ap_ops.c | 3 ++- >> 1 file changed, 2

Re: [FIXUP v11] fixup! s390: vfio-ap: implement mediated device open callback

2018-09-28 Thread Christian Borntraeger
I will fold in. On 09/28/2018 03:33 PM, Tony Krowiak wrote: > From: Tony Krowiak > > Fixes case statement in vfio_ap_mdev_copy_masks() function in > vfio-ap-ops.c. > --- > drivers/s390/crypto/vfio_ap_ops.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [FIXUP v11] fixup! s390: vfio-ap: implement mediated device open callback

2018-09-28 Thread Christian Borntraeger
I will fold in. On 09/28/2018 03:33 PM, Tony Krowiak wrote: > From: Tony Krowiak > > Fixes case statement in vfio_ap_mdev_copy_masks() function in > vfio-ap-ops.c. > --- > drivers/s390/crypto/vfio_ap_ops.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP virtualization

2018-09-28 Thread Christian Borntraeger
On 09/27/2018 09:19 PM, Tony Krowiak wrote: > The following fixup attempts to clarify the bit ordering confusion, > hopefully this is acceptable. > looks good to me, I will fold in. > ---8<--- > > From: Tony Krowiak > Date:

Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP virtualization

2018-09-28 Thread Christian Borntraeger
On 09/27/2018 09:19 PM, Tony Krowiak wrote: > The following fixup attempts to clarify the bit ordering confusion, > hopefully this is acceptable. > looks good to me, I will fold in. > ---8<--- > > From: Tony Krowiak > Date:

Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP virtualization

2018-09-28 Thread Christian Borntraeger
On 09/27/2018 09:19 PM, Tony Krowiak wrote: > On 09/26/2018 06:42 PM, Alex Williamson wrote: >> On Tue, 25 Sep 2018 19:16:41 -0400 >> Tony Krowiak wrote: >> >>> From: Tony Krowiak >>> >>> This patch provides documentation describing the AP architecture and >>> design concepts behind the

Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP virtualization

2018-09-28 Thread Christian Borntraeger
On 09/27/2018 09:19 PM, Tony Krowiak wrote: > On 09/26/2018 06:42 PM, Alex Williamson wrote: >> On Tue, 25 Sep 2018 19:16:41 -0400 >> Tony Krowiak wrote: >> >>> From: Tony Krowiak >>> >>> This patch provides documentation describing the AP architecture and >>> design concepts behind the

Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP virtualization

2018-09-27 Thread Christian Borntraeger
On 09/27/2018 01:51 PM, Cornelia Huck wrote: > On Thu, 27 Sep 2018 13:29:43 +0200 > Halil Pasic wrote: > >> On 09/27/2018 12:42 AM, Alex Williamson wrote: >>> On Tue, 25 Sep 2018 19:16:41 -0400 >>> Tony Krowiak wrote: + This is how the matrix is configured for Guest2: + +

Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP virtualization

2018-09-27 Thread Christian Borntraeger
On 09/27/2018 01:51 PM, Cornelia Huck wrote: > On Thu, 27 Sep 2018 13:29:43 +0200 > Halil Pasic wrote: > >> On 09/27/2018 12:42 AM, Alex Williamson wrote: >>> On Tue, 25 Sep 2018 19:16:41 -0400 >>> Tony Krowiak wrote: + This is how the matrix is configured for Guest2: + +

Re: [PATCH v11 13/26] s390: vfio-ap: zeroize the AP queues

2018-09-26 Thread Christian Borntraeger
On 09/26/2018 03:38 PM, Cornelia Huck wrote: > On Tue, 25 Sep 2018 19:16:28 -0400 > Tony Krowiak wrote: > >> From: Tony Krowiak >> >> Let's call PAPQ(ZAPQ) to zeroize a queue for each queue configured >> for a mediated matrix device when it is released. >> >> Zeroizing a queue resets the

Re: [PATCH v11 13/26] s390: vfio-ap: zeroize the AP queues

2018-09-26 Thread Christian Borntraeger
On 09/26/2018 03:38 PM, Cornelia Huck wrote: > On Tue, 25 Sep 2018 19:16:28 -0400 > Tony Krowiak wrote: > >> From: Tony Krowiak >> >> Let's call PAPQ(ZAPQ) to zeroize a queue for each queue configured >> for a mediated matrix device when it is released. >> >> Zeroizing a queue resets the

Re: [PATCH v11 00/26] guest dedicated crypto adapters

2018-09-26 Thread Christian Borntraeger
I added the series (with a small fixup for 25 and added one Acked-by) to git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git apv11 I can still add Rb and Acks. I will probably merge this in kvms390/next at the end of the week. On 09/26/2018 01:16 AM, Tony Krowiak wrote: > From:

Re: [PATCH v11 00/26] guest dedicated crypto adapters

2018-09-26 Thread Christian Borntraeger
I added the series (with a small fixup for 25 and added one Acked-by) to git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git apv11 I can still add Rb and Acks. I will probably merge this in kvms390/next at the end of the week. On 09/26/2018 01:16 AM, Tony Krowiak wrote: > From:

Re: [PATCH v11 25/26] KVM: s390: CPU model support for AP virtualization

2018-09-26 Thread Christian Borntraeger
rdless of >>the guest's matrix configuration for the virtual >>machine. This is a limitation of the Linux AP bus. >> >> Signed-off-by: Tony Krowiak >> Reviewed-by: Christian Borntraeger >> Reviewed-by: Halil Pasic >> Reviewed-by: David Hildenbr

Re: [PATCH v11 25/26] KVM: s390: CPU model support for AP virtualization

2018-09-26 Thread Christian Borntraeger
rdless of >>the guest's matrix configuration for the virtual >>machine. This is a limitation of the Linux AP bus. >> >> Signed-off-by: Tony Krowiak >> Reviewed-by: Christian Borntraeger >> Reviewed-by: Halil Pasic >> Reviewed-by: David Hildenbr

Re: [PATCH v10 02/26] KVM: s390: introduce and use KVM_REQ_VSIE_RESTART

2018-09-24 Thread Christian Borntraeger
IE data (including rebuilding the crycb) when re-entering the vSIE > interception handler the next time. > > Reviewed-by: Pierre Morel > Reviewed-by: Cornelia Huck > Reviewed-by: Janosch Frank > Signed-off-by: Tony Krowiak > Signed-off-by: David Hildenbrand same he

Re: [PATCH v10 02/26] KVM: s390: introduce and use KVM_REQ_VSIE_RESTART

2018-09-24 Thread Christian Borntraeger
IE data (including rebuilding the crycb) when re-entering the vSIE > interception handler the next time. > > Reviewed-by: Pierre Morel > Reviewed-by: Cornelia Huck > Reviewed-by: Janosch Frank > Signed-off-by: Tony Krowiak > Signed-off-by: David Hildenbrand same he

Re: [PATCH v10 01/26] KVM: s390: vsie: simulate VCPU SIE entry/exit

2018-09-24 Thread Christian Borntraeger
ldenbrand I guess you should want to swap both signoffs? In the end they should show the patch flow. Other than that: Reviewed-by: Christian Borntraeger > --- > arch/s390/kvm/kvm-s390.c |9 - > arch/s390/kvm/kvm-s390.h |1 + > arch/s390/kvm/vsie.c | 21 +++

Re: [PATCH v10 01/26] KVM: s390: vsie: simulate VCPU SIE entry/exit

2018-09-24 Thread Christian Borntraeger
ldenbrand I guess you should want to swap both signoffs? In the end they should show the patch flow. Other than that: Reviewed-by: Christian Borntraeger > --- > arch/s390/kvm/kvm-s390.c |9 - > arch/s390/kvm/kvm-s390.h |1 + > arch/s390/kvm/vsie.c | 21 +++

Re: [PATCH v10 00/26] guest dedicated crypto adapters

2018-09-24 Thread Christian Borntraeger
FWIW, assuming that review comments for v10 will be addresses in v11, I plan to add the upcoming v11 to a topic branch and will merge that after 2 or 3 days after v11 in kvms390/next. In the future the vfio-ap driver will likely be handled by Martins s390 tree, so I guess it makes sense for him

Re: [PATCH v10 00/26] guest dedicated crypto adapters

2018-09-24 Thread Christian Borntraeger
FWIW, assuming that review comments for v10 will be addresses in v11, I plan to add the upcoming v11 to a topic branch and will merge that after 2 or 3 days after v11 in kvms390/next. In the future the vfio-ap driver will likely be handled by Martins s390 tree, so I guess it makes sense for him

Re: [RFC][PATCH 1/5] [PATCH 1/5] kvm: register in task_struct

2018-09-04 Thread Christian Borntraeger
On 09/04/2018 09:15 AM, Fengguang Wu wrote: > On Tue, Sep 04, 2018 at 08:37:03AM +0200, Nikita Leshenko wrote: >> On 4 Sep 2018, at 2:46, Fengguang Wu wrote: >>> >>> Here it goes: >>> >>> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h >>> index 99ce070e7dcb..27c5446f3deb

Re: [RFC][PATCH 1/5] [PATCH 1/5] kvm: register in task_struct

2018-09-04 Thread Christian Borntraeger
On 09/04/2018 09:15 AM, Fengguang Wu wrote: > On Tue, Sep 04, 2018 at 08:37:03AM +0200, Nikita Leshenko wrote: >> On 4 Sep 2018, at 2:46, Fengguang Wu wrote: >>> >>> Here it goes: >>> >>> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h >>> index 99ce070e7dcb..27c5446f3deb

Re: [RFC][PATCH 1/5] [PATCH 1/5] kvm: register in task_struct

2018-09-03 Thread Christian Borntraeger
On 09/03/2018 04:10 PM, Nikita Leshenko wrote: > On September 2, 2018 5:21:15 AM, fengguang...@intel.com wrote: >> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >> index 8b47507faab5..0c483720de8d 100644 >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -3892,6 +3892,7 @@

Re: [RFC][PATCH 1/5] [PATCH 1/5] kvm: register in task_struct

2018-09-03 Thread Christian Borntraeger
On 09/03/2018 04:10 PM, Nikita Leshenko wrote: > On September 2, 2018 5:21:15 AM, fengguang...@intel.com wrote: >> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >> index 8b47507faab5..0c483720de8d 100644 >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -3892,6 +3892,7 @@

<    1   2   3   4   5   6   7   8   9   10   >