Re: [PATCH] livepatch: add load/unload hooks to objects

2016-08-30 Thread Christopher Arges
On Tue, Aug 30, 2016 at 04:43:30PM +0200, Petr Mladek wrote: > On Mon 2016-08-29 11:16:28, Christopher Arges wrote: > > On Mon, Aug 29, 2016 at 05:23:30PM +0200, Petr Mladek wrote: > > > On Fri 2016-08-26 13:50:27, Chris J Arges wrote: > > > > It can be useful to e

Re: [PATCH] livepatch: add load/unload hooks to objects

2016-08-30 Thread Christopher Arges
On Tue, Aug 30, 2016 at 04:43:30PM +0200, Petr Mladek wrote: > On Mon 2016-08-29 11:16:28, Christopher Arges wrote: > > On Mon, Aug 29, 2016 at 05:23:30PM +0200, Petr Mladek wrote: > > > On Fri 2016-08-26 13:50:27, Chris J Arges wrote: > > > > It can be useful to e

Re: [PATCH] livepatch: add load/unload hooks to objects

2016-08-30 Thread Christopher Arges
On Tue, Aug 30, 2016 at 11:41:28AM +0200, Jiri Kosina wrote: > On Mon, 29 Aug 2016, Christopher Arges wrote: > > > Another example is CVE-2016-2117. Here we need to unset NETIF_F_SG on a > > particular device. If the device is already loaded we need a way to > > fixup h

Re: [PATCH] livepatch: add load/unload hooks to objects

2016-08-30 Thread Christopher Arges
On Tue, Aug 30, 2016 at 11:41:28AM +0200, Jiri Kosina wrote: > On Mon, 29 Aug 2016, Christopher Arges wrote: > > > Another example is CVE-2016-2117. Here we need to unset NETIF_F_SG on a > > particular device. If the device is already loaded we need a way to > > fixup h

Re: [PATCH] livepatch: add load/unload hooks to objects

2016-08-29 Thread Christopher Arges
On Mon, Aug 29, 2016 at 05:23:30PM +0200, Petr Mladek wrote: > On Fri 2016-08-26 13:50:27, Chris J Arges wrote: > > It can be useful to execute hook functions whenever a livepatch is applied > > or unapplied to a particular object. Currently this is possible by writing > > logic in the __init

Re: [PATCH] livepatch: add load/unload hooks to objects

2016-08-29 Thread Christopher Arges
On Mon, Aug 29, 2016 at 05:23:30PM +0200, Petr Mladek wrote: > On Fri 2016-08-26 13:50:27, Chris J Arges wrote: > > It can be useful to execute hook functions whenever a livepatch is applied > > or unapplied to a particular object. Currently this is possible by writing > > logic in the __init

Re: [PATCH 0/2] Fix issue with alternatives/paravirt patches

2016-07-07 Thread Christopher Arges
On Tue, Jul 05, 2016 at 10:34:58PM -0400, Jessica Yu wrote: > Hi, > > A few months ago, Chris Arges reported a bug involving alternatives/paravirt > patching that was discussed here [1] and here [2]. To briefly summarize the > bug, patch modules that contained .altinstructions or

Re: [PATCH 0/2] Fix issue with alternatives/paravirt patches

2016-07-07 Thread Christopher Arges
On Tue, Jul 05, 2016 at 10:34:58PM -0400, Jessica Yu wrote: > Hi, > > A few months ago, Chris Arges reported a bug involving alternatives/paravirt > patching that was discussed here [1] and here [2]. To briefly summarize the > bug, patch modules that contained .altinstructions or

Re: [PATCH v2] livepatch: allow removal of a disabled patch

2016-06-01 Thread Christopher Arges
On Wed, Jun 01, 2016 at 10:31:59AM +0200, Miroslav Benes wrote: > Currently we do not allow patch module to unload since there is no > method to determine if a task is still running in the patched code. > > The consistency model gives us the way because when the unpatching > finishes we know that

Re: [PATCH v2] livepatch: allow removal of a disabled patch

2016-06-01 Thread Christopher Arges
On Wed, Jun 01, 2016 at 10:31:59AM +0200, Miroslav Benes wrote: > Currently we do not allow patch module to unload since there is no > method to determine if a task is still running in the patched code. > > The consistency model gives us the way because when the unpatching > finishes we know that