Re: [PATCH v2 5/5] soc / drm: mediatek: Move mtk mutex driver to soc folder

2021-01-20 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2021年1月21日 週四 上午2:33寫道: > > On Thu, Jan 07, 2021 at 07:17:29AM +0800, Chun-Kuang Hu wrote: > > From: CK Hu > > > > mtk mutex is used by DRM and MDP driver, and its function is SoC-specific, > > so move it to soc folder. > >

Re: [PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

2021-01-20 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2021年1月21日 週四 上午2:27寫道: > > On Thu, Jan 07, 2021 at 07:17:27AM +0800, Chun-Kuang Hu wrote: > > From: CK Hu > > > > mtk mutex is used by both drm and mdp driver, so change disp/ddp term to > > mutex to show that it's a

Re: [PATCH next v2 04/17] dt-bindings: phy: mediatek: dsi-phy: add optional clock-names

2021-01-22 Thread Chun-Kuang Hu
tree. If a property does not exist in binding document, we should not write it in device tree. So let's drop this patch and remove clock-names in mt8183.dtsi. Regards, Chun-Kuang. > > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Signed-off-by: Chunfeng Yun > --- > v2: new patch

Re: [PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

2021-01-21 Thread Chun-Kuang Hu
Matthias Brugger 於 2021年1月21日 週四 下午4:19寫道: > > On Thu, Jan 21, 2021 at 07:46:44AM +0800, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2021年1月21日 週四 上午2:27寫道: > > > > > > On Thu, Jan 07, 2021 at 07:17:27AM +0800, Chun-Kuang Hu wrote

Re: [PATCH next 03/15] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

2021-01-18 Thread Chun-Kuang Hu
add an optional "clock-names" property, it's not used to get the clock, > but some DTS files provide it. Separate the clock part to another patch. Regards, Chun-Kuang. > > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Signed-off-by: Chunfeng Yun > --- > .../binding

Re: [PATCH v2 0/5] Share mtk mutex driver for both DRM and MDP

2021-01-19 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2021年1月7日 週四 上午7:17寫道: > > mtk mutex is a driver used by DRM and MDP [1], so this series move > mtk mutex driver from DRM folder to soc folder, so it could be used > by DRM and MDP. Applied [1/5] ~ [4/5] to mediatek-drm-next [1]. [1] https://git.kernel.org/pub/scm/

Re: [PATCH next 04/15] dt-bindings: phy: mediatek: hdmi-phy: modify compatible items

2021-01-18 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2021年1月16日 週六 下午5:07寫道: > > The compatilbe "mediatek,mt7623-hdmi-tx" is not supported in driver, > and in fact uses "mediatek,mt2701-hdmi-tx" instead on MT7623, so changes > the compatible items to make dependence clear. > >

Re: [PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

2021-01-14 Thread Chun-Kuang Hu
Rob Herring 於 2021年1月15日 週五 上午3:11寫道: > > On Mon, 11 Jan 2021 15:43:37 +0800, Yongqiang Niu wrote: > > add description for postmask > > postmask is used control round corner for display frame > > > > Signed-off-by: Yongqiang Niu > > --- > >

Re: [PATCH v3, 11/15] drm/mediatek: fix aal size config

2021-01-14 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > the orginal setting is not correct, fix it follow hardware data sheet. > if keep this error setting, mt8173/mt8183 display ok > but mt8192 display abnormal. > Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v9, 05/11] drm/mediatek: add fifo_size into rdma private data

2021-01-14 Thread Chun-Kuang Hu
Hi, Yongqiang: Chun-Kuang Hu 於 2021年1月7日 週四 下午6:05寫道: > > Hi, Yongqiang: > > Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道: > > > > Get the fifo size from device tree > > because each rdma in the same SoC may have different fifo size > > Reviewed-by: Chun-Kuang

Re: [PATCH v4, 10/10] soc: mediatek: mmsys: add mt8192 mmsys support

2021-01-06 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月5日 週二 上午11:17寫道: > > add mt8192 mmsys support > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mmsys/Makefile | 1 + > drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 149 > ++ >

[PATCH v2 0/5] Share mtk mutex driver for both DRM and MDP

2021-01-06 Thread Chun-Kuang Hu
mtk mutex is a driver used by DRM and MDP [1], so this series move mtk mutex driver from DRM folder to soc folder, so it could be used by DRM and MDP. Changes in v2: 1. Rebase onto mediatek-drm-next [2]. 2. Export symbol for mtk-mutex API. [1] https://patchwork.kernel.org/patch/11140751/ [2]

[PATCH v2 1/5] drm/mediatek: Remove redundant file including

2021-01-06 Thread Chun-Kuang Hu
From: CK Hu Those file includings are useless, so remove them. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 2 -- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/mediatek

[PATCH v2 2/5] drm/mediatek: Rename file mtk_drm_ddp to mtk_mutex

2021-01-06 Thread Chun-Kuang Hu
From: CK Hu After mmsys routing function is moved out of mtk_drm_ddp.c, mtk_drm_ddp.c has only mtk mutex function, so rename it to match the function in it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Makefile | 4 ++-- drivers/gpu/drm

[PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

2021-01-06 Thread Chun-Kuang Hu
From: CK Hu mtk mutex is used by both drm and mdp driver, so change disp/ddp term to mutex to show that it's a common driver for drm and mdp. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 30 +-- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2

[PATCH v2 5/5] soc / drm: mediatek: Move mtk mutex driver to soc folder

2021-01-06 Thread Chun-Kuang Hu
From: CK Hu mtk mutex is used by DRM and MDP driver, and its function is SoC-specific, so move it to soc folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Makefile | 3 +-- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2

[PATCH v2 4/5] drm/mediatek: Automatically search unclaimed mtk mutex in mtk_mutex_get()

2021-01-06 Thread Chun-Kuang Hu
From: CK Hu Moving mutex resource management from client driver to mutex driver could prevent client drivers negotiating for resource management. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_mutex.c

Re: [PATCH v9, 01/11] dt-bindings: mediatek: add rdma-fifo-size description for mt8183 display

2021-01-07 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:11寫道: > > rdma fifo size may be different even in same SOC, add this > property to the corresponding rdma Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediatek/mediat

Re: [PATCH v9, 03/11] arm64: dts: mt8183: rename rdma fifo size

2021-01-07 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道: > > property name must include only lowercase and '-' Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH v9, 05/11] drm/mediatek: add fifo_size into rdma private data

2021-01-07 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道: > > Get the fifo size from device tree > because each rdma in the same SoC may have different fifo size Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek

Re: [PATCH v9, 02/11] dt-bindings: mediatek: add description for mt8183 display

2021-01-07 Thread Chun-Kuang Hu
ongqiang Niu > Reviewed-by: Chun-Kuang Hu > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/

Re: [PATCH v9, 07/11] drm/mediatek: separate gamma module

2021-01-07 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道: > > mt8183 gamma module will different with mt8173 > separate gamma for add private data I've applied series "Decouple Mediatek DRM sub driver" [1] into mediatek-drm-next [2] and this patch would conflict with mediatek-drm-next, so please

Re: [PATCH v9, 08/11] drm/mediatek: add has_dither private data for gamma

2021-01-07 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道: > > not all SoC has dither function in gamma module > dd private data to control this function setting 'add' ? > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 12 +--- > 1 file changed, 9

Re: [PATCH v9, 10/11] drm/mediatek: add DDP support for MT8183

2021-01-07 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道: > > Add DDP support for MT8167 SoC. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 48 > ++ > 1 file changed, 48 insertions(+) > > diff --git

Re: [PATCH] drm/mediatek: dsi: Fix EoTp flag

2021-01-07 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年1月7日 週四 下午10:34寫道: > > SoC will transmit the EoTp (End of Transmission packet) when > MIPI_DSI_MODE_EOT_PACKET flag is set. > > Enabling EoTp will make the line time larger, so the hfp and > hbp should be reduced to keep line time. > > Signed-off-by: Jitao Shi > ---

Re: [PATCH v3, 09/15] drm/mediatek: Add pm runtime support for gamma

2021-01-12 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > gamma power domain need controled in the device. In this series, why only gamma and color add pm runtime support? I think all ddp component need pm runtime support. And pm runtime support is not related to mt8192, so move these patches

Re: [PATCH v3, 12/15] drm/mediatek: separate ccorr module

2021-01-12 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:54寫道: > > ccorr ctm matrix bits will be different in mt8192 This patch has conflicts with the series "Decouple Mediatek DRM sub driver" [1] which has been applied to mediatek-drm-next, so please rebase this patch onto mediatek-drm-next. [1]

Re: [PATCH next v2 03/17] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

2021-01-23 Thread Chun-Kuang Hu
Hi, Chunfeng: Chun-Kuang Hu 於 2021年1月24日 週日 下午12:47寫道: > > Hi, Chunfeng: > > Chunfeng Yun 於 2021年1月22日 週五 下午8:04寫道: > > > > The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver, > > and in fact uses "mediatek,mt2701-mipi-tx" inst

Re: [PATCH next v2 03/17] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

2021-01-23 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2021年1月22日 週五 下午8:04寫道: > > The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver, > and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so changes > the compatible items to make dependence clear. Reviewed-

Re: [PATCH] drm/mediatek: mtk_dpi: Create connector for bridges

2021-01-13 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Chun-Kuang Hu 於 2020年12月11日 週五 下午10:04寫道: > > Hi, Hsin-Yi: > > Hsin-Yi Wang 於 2020年12月3日 週四 下午4:24寫道: > > > > Similar to a9d9fea74be2 ("drm/mediatek: mtk_dsi: Create connector for > > bridges"): > > > > Use the drm_bridge_

Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions

2020-10-05 Thread Chun-Kuang Hu
Hi, Rob: Rob Herring 於 2020年10月5日 週一 下午9:45寫道: > > On Sun, Oct 4, 2020 at 12:50 AM Phil Chang wrote: > > > > Certain SoCs need to support large amount of reserved memory > > regions, especially to follow the GKI rules from Google. > > In MTK new SoC requires more than 68 regions of reserved

Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions

2020-10-05 Thread Chun-Kuang Hu
f this patch is more important than HOW of this patch. Regards, Chun-Kuang. > > Rob > > > > > > > On Sun, 2020-10-04 at 21:05 +0800, Chun-Kuang Hu wrote: > > > Hi, Phil: > > > > > > Phil Chang 於 2020年10月4日 週日 下午1:51寫道: > > > > > &g

Re: [PATCH 2/4] soc: mediatek: mmsys: Use devm_platform_ioremap_resource()

2020-10-06 Thread Chun-Kuang Hu
Enric Balletbo i Serra 於 2020年10月7日 週三 上午3:33寫道: > > For the common platform_get_resource()+devm_platform_ioremap() combination, > there is a helper, so use it and make the code a bit more compact. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --

Re: [PATCH 3/4] soc: mediatek: mmsys: Create struct mtk_mmsys to store context data

2020-10-06 Thread Chun-Kuang Hu
Reviewed-by: Chun-Kuang Hu > > Signed-off-by: CK Hu > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/soc/mediatek/mtk-mmsys.c | 47 ++-- > 1 file changed, 27 insertions(+), 20 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-

Re: [PATCH 3/4] soc: mediatek: mmsys: Create struct mtk_mmsys to store context data

2020-10-06 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年10月7日 週三 上午7:24寫道: > > Enric Balletbo i Serra 於 2020年10月7日 週三 > 上午3:33寫道: > > > > From: CK Hu > > > > Apart from the driver data, in order to extend the driver to support more > > and more SoCs, we will need to store other configu

Re: [PATCH 2/4] soc: mediatek: mmsys: Use devm_platform_ioremap_resource()

2020-10-06 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年10月7日 週三 上午7:21寫道: > > Enric Balletbo i Serra 於 2020年10月7日 週三 > 上午3:33寫道: > > > > For the common platform_get_resource()+devm_platform_ioremap() combination, > > there is a helper, so use it and make the code a bit more compact. > > Rev

Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-06 Thread Chun-Kuang Hu
se a table per SoC so the > code will be more portable and clear. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: CK Hu > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/soc/mediatek/mtk-mmsys.c | 393 +-- > 1 file changed, 210 insertions(+), 183 deletions(-) >

Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts > > Signed-off-by: Frank Wunderlich > --- >

Re: [PATCH v3 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-08-04 Thread Chun-Kuang Hu
search > pipeline information to find out the correct possible crtc. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Stu Hsieh > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 42 + > drivers/gpu/drm/mediatek/mtk_drm_d

Re: [PATCH v3 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-04 Thread Chun-Kuang Hu
this case, so call > mtk_drm_find_possible_crtc_by_comp() to find out the correct possible > crtc. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++- > drivers/gpu/drm/mediatek/mtk_dsi.c | 3

Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Ryder Lee > > Add display subsystem related device nodes for MT7623. > > Cc: CK Hu > Signed-off-by: chunhui dai > Signed-off-by: Bibby Hsieh > Signed-off-by: Ryder Lee > Signed-off-by: Frank Wunderlich > Tested-by: Frank

Re: Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年8月4日 週二 下午10:44寫道: > > Hi, > > > Gesendet: Dienstag, 04. August 2020 um 16:34 Uhr > > Von: "Chun-Kuang Hu" > > > > -static const enum mtk_ddp_comp_id mt2712_mtk_ddp_main[] = { > > > +static enum mtk_ddp_comp_id mt2712

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-04 Thread Chun-Kuang Hu
Neal Liu 於 2020年8月4日 週二 上午10:19寫道: > > > On Tue, 2020-08-04 at 00:13 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年8月3日 週一 上午11:32寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Fri, 2020-07-31 at 23:03 +0800, Chu

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-04 Thread Chun-Kuang Hu
Neal Liu 於 2020年8月4日 週二 上午10:08寫道: > > On Tue, 2020-08-04 at 00:04 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年8月3日 週一 下午12:01寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Sat, 2020-08-01 at 08:12 +0800, Chun-

Re: Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
ards Frank > > > > Gesendet: Dienstag, 04. August 2020 um 17:00 Uhr > > Von: "Chun-Kuang Hu" > > An: "Frank Wunderlich" > > > + mipi_tx0: mipi-dphy@1001 { > > > + compatible = "mediatek,mt7623-mipi-tx&quo

Re: [PATCH v4 2/6] drm/mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月5日 週三 上午12:56寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts Reviewed-by: Chun-Kuang Hu > >

Re: [PATCH v4 1/6] dt-bindings: mediatek: add mt7623 display-nodes

2020-08-04 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年8月5日 週三 上午12:56寫道: > > From: Frank Wunderlich > > mt7623 uses mt2701/mt8173 for drm, but have own compatibles Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Frank Wunderlich > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt

Re: [PATCH v7] Add MediaTek MT6779 devapc driver

2020-10-02 Thread Chun-Kuang Hu
Hi, Neal: You may find Matthias in IRC [1], the channel name is #linux-mediatek [1] https://webchat.freenode.net/ Neal Liu 於 2020年9月30日 週三 下午3:10寫道: > > Hi Matt, > > Hope this mail could find you well. > Is everything okay? > It would be glad if you could reply me no matter the review status.

Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver

2020-10-02 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月27日 週四 上午11:07寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. >

Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ

2020-10-02 Thread Chun-Kuang Hu
Hi, Jassi: Jassi Brar 於 2020年10月3日 週六 上午4:30寫道: > > On Sun, Sep 27, 2020 at 6:04 PM Chun-Kuang Hu wrote: > > > > CMDQ helper provide timer to detect execution timeout, but DRM driver > > could have a better way to detect execution timeout by vblank IRQ. > > For DR

Re: [PATCH v3] mailbox: mediatek: Fix handling of platform_get_irq() error

2020-10-02 Thread Chun-Kuang Hu
Krzysztof Kozlowski 於 2020年8月28日 週五 上午2:25寫道: > > platform_get_irq() returns -ERRNO on error. In such case casting to u32 > and comparing to 0 would pass the check. > Reviewed-by: Chun-Kuang Hu > Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver") &

Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions

2020-10-04 Thread Chun-Kuang Hu
Hi, Phil: Phil Chang 於 2020年10月4日 週日 下午1:51寫道: > > Certain SoCs need to support large amount of reserved memory > regions, especially to follow the GKI rules from Google. > In MTK new SoC requires more than 68 regions of reserved memory > for each IP's usage, such as load firmware to specific

Re: [PATCH 1/2] arm: dts: mt7623: move more display-related nodes to mt7623n.dtsi

2020-08-08 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月8日 週六 下午8:27寫道: > > Hi, > > as i made a mistake in cover-letter, it is not assigned to the series. > > to show its content, i send it here as comment (instead of resending the > whole series): > > based on series from David Woodhouse [1] > i moved more

Re: [RESEND v7, PATCH 6/7] drm/mediatek: add support for mediatek SOC MT8183

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午11:05寫道: > > This patch add support for mediatek SOC MT8183 > 1. add ovl private data > 2. add rdma private data > 3. add mutes private data > 4. add main and external path module for crtc create > > Signed-off-by: Yongqiang Niu [snip] > + >

Re: [RESEND v7, PATCH 0/7] add drm support for MT8183

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: This series is 'v8', not 'RESEND v7' Yongqiang Niu 於 2020年8月8日 週六 上午10:56寫道: > > This series are based on 5.8-rc1 and provide 7 patch > to support mediatek SOC MT8183 > > Change since v6 > - move ddp component define into mtk_mmsys.h > - add mmsys private data to support

Re: [RESEND v7, PATCH 2/7] drm/mediatek: move ddp component define into mtk_mmsys.h

2020-08-08 Thread Chun-Kuang Hu
Yongqiang Niu 於 2020年8月8日 週六 上午11:05寫道: > > mmsys is the driver which control the routing of these ddp component, > so the definition of mtk_ddp_comp_id should be placed in mtk-mmsys.h > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Yongqiang Niu > --- > dri

Re: [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午11:04寫道: > > rdma fifo size may be different even in same SOC, add this > property to the corresponding rdma > > Change-Id: I67635ec7f3f59cf4cbc7737285e5e28ff0ab71c9 Remove change-id. > Signed-off-by: Yongqiang Niu > --- >

Re: [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: Chun-Kuang Hu 於 2020年8月9日 週日 上午8:56寫道: > > Hi, Yongqiang: > > Yongqiang Niu 於 2020年8月8日 週六 上午11:04寫道: > > > > rdma fifo size may be different even in same SOC, add this > > property to the corresponding rdma > > > > Change-Id: I67635ec7f

Re: [PATCH 1/2] arm: dts: mt7623: move more display-related nodes to mt7623n.dtsi

2020-08-09 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月9日 週日 下午3:22寫道: > > > > Am 9. August 2020 02:16:59 MESZ schrieb Chun-Kuang Hu > : > > > >I would like to put all device in mt7623.dtsi with some device's > >status is "disabled" and change its status in platf

Re: [PATCH v5 2/2] soc: mediatek: add mt6779 devapc driver

2020-08-10 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月10日 週一 上午11:43寫道: > > Hi Chun-Kuang, > > On Fri, 2020-08-07 at 23:52 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年8月7日 週五 上午10:34寫道: > > > > > > MediaTek bus fabric provides TrustZone security sup

Re: [PATCH 1/2] arm: dts: mt7623: move more display-related nodes to mt7623n.dtsi

2020-08-10 Thread Chun-Kuang Hu
Hi, David: David Woodhouse 於 2020年8月10日 週一 下午3:48寫道: > > On Sun, 2020-08-09 at 08:16 +0800, Chun-Kuang Hu wrote: > > I would like to put all device in mt7623.dtsi with some device's > > status is "disabled" and change its status in platform dtsi. > > I would lik

Re: [RESEND v7, PATCH 3/7] mtk-mmsys: add mmsys private data

2020-08-10 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午10:56寫道: > > the reason why split out display connection function: > 1. there will more and more Mediatek Soc upstream, and the display path > connection function mtk_mmsys_ddp_mout_en, mtk_mmsys_ddp_sel_in and > mtk_mmsys_ddp_sout_sel will

Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-07 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年10月7日 週三 上午3:33寫道: > > From: CK Hu > > Actually, setting the registers for routing, use multiple 'if-else' for > different > routes, but this code would be more and more complicated while we > support more and more SoCs. Change that and use a table per

Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-10 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年10月8日 週四 下午6:22寫道: > > Hi Enric and CK, > > On 06/10/2020 21:33, Enric Balletbo i Serra wrote: > > From: CK Hu > > > > Actually, setting the registers for routing, use multiple 'if-else' for > > different > > routes, but this code would be more and more

Re: [v4 PATCH 0/2] fix scrolling of panel with small hfp or hbp

2020-10-12 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年10月10日 週六 下午3:09寫道: > > Changes since v3: > - Revert v2, for v2 will cause some bridge ic no output. the cause >the video linetime doesn't match display mode from get mode. > - Make sure the horizontal_frontporch_byte and horizontal_backporch_byte >are > 0.

Re: [PATCH v6 2/2] soc: mediatek: add mt6779 devapc driver

2020-08-26 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月26日 週三 下午5:59寫道: > > Hi Chun-Kuang, > > On Tue, 2020-08-18 at 14:20 +0800, Neal Liu wrote: > > Hi Chun-Kuang, > > > > On Tue, 2020-08-18 at 10:44 +0800, Neal Liu wrote: > > > Hi Chun-Kuang, > > > > > > On Mon, 2

Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-08-26 Thread Chun-Kuang Hu
Hi, Jitao: Chun-Kuang Hu 於 2020年8月18日 週二 下午10:45寫道: > > Hi, Jitao: > > Jitao Shi 於 2020年8月18日 週二 上午10:41寫道: > > > > On Tue, 2020-08-18 at 07:42 +0800, Chun-Kuang Hu wrote: > > > Hi, Jitao: > > > > > > Jitao Shi 於 2020年8月17日 週一 下午9:07寫道: >

Re: [PATCH -next] drm/mediatek: remove duplicate include

2020-08-26 Thread Chun-Kuang Hu
Hi, Wang Hai: Chun-Kuang Hu 於 2020年8月21日 週五 上午7:23寫道: > > Hi, Wang Hai: > > Wang Hai 於 2020年8月19日 週三 上午11:00寫道: > > > > Remove mtk_drm_ddp.h which is included more than once > > > > Reviewed-by: Chun-Kuang Hu > Applied to mediatek-drm-fixes [1], thank

Re: [PATCH v5 1/7] dt-bindings: mediatek: add mt7623 display-nodes

2020-08-27 Thread Chun-Kuang Hu
inux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Frank Wunderlich > Acked-by: Rob Herring > Reviewed-by: Chun-Kuang Hu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt| 2 +- > .../devicetree/bindings/display/mediatek/mediatek,dpi

Re: [PATCH v5 2/7] drm/mediatek: add ddp routing for mt7623

2020-08-27 Thread Chun-Kuang Hu
ext [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Frank Wunderlich > Reviewed-by: Chun-Kuang Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 23 +++ >

Re: [PATCH v5 5/7] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-27 Thread Chun-Kuang Hu
Matthias, so squash this patch into 4/7, and applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Regards, > Matthias > > > Signed-off-by: Jitao Shi > > S

Re: Aw: Re: [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701

2020-08-27 Thread Chun-Kuang Hu
Hi, Frank: Matthias Brugger 於 2020年8月27日 週四 下午10:28寫道: > > > > On 27/08/2020 15:41, Frank Wunderlich wrote: > > Hi Matthias, > > > > any opinions about the dts-changes? > > > > they look good to me. > > > maybe series except the tmds-Patch get merged...so i add it only to my own > > repo till

Re: [RESEND PATCH v2 1/2] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-09-09 Thread Chun-Kuang Hu
will be > named next_bridge. This is a DRM-bridge related patch, how do you think about it? Regards, Chun-Kuang. > > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v2: None > > drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++

Re: [RESEND PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-09-09 Thread Chun-Kuang Hu
ang. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v2: > - Maintain error message when attach to bridge fails. (Boris) > > drivers/gpu/drm/mediatek/mtk_dpi.c | 71 ++ > 1 file changed, 42 insertions(+

Re: [PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-31 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年8月31日 週一 上午9:48寫道: > > On Mon, 2020-08-31 at 07:03 +0800, Chun-Kuang Hu wrote: > > Hi, Chunfeng & Kishon: > > > > How do you feel about this patch? > It's fine to me, > > Reviewed-by: Chunfeng Yun > Could you give an

Re: [PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-31 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年8月31日 週一 上午9:50寫道: > > On Sun, 2020-08-23 at 09:48 +0800, Chun-Kuang Hu wrote: > > Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to > > drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' > > informa

Re: [PATCH v9 10/32] drm: mediatek: use common helper for a scatterlist contiguity check

2020-09-01 Thread Chun-Kuang Hu
Hi, Marek: Marek Szyprowski 於 2020年8月26日 週三 下午2:35寫道: > > Use common helper for checking the contiguity of the imported dma-buf and > do this check before allocating resources, so the error path is simpler. > Acked-by: Chun-Kuang Hu > Signed-off-by: Marek Szyprowski > ---

Re: [PATCH v9 11/32] drm: mediatek: use common helper for extracting pages array

2020-09-01 Thread Chun-Kuang Hu
to > sg_free_table(sgt) before its kfree(sgt)? Yes, we need another patch to fix that bug, But for this patch, Acked-by: Chun-Kuang Hu > > > Signed-off-by: Marek Szyprowski > > --- > > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 9 ++--- > > 1 file changed,

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-31 Thread Chun-Kuang Hu
Hi, Neal: This patch is for "mediatek,mt6779-devapc", so I think commit title should show the SoC ID. Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-01 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. >

Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > > From: Bibby Hsieh > > We can select output component by decive node port. > Main path default output component is DSI. > External path default output component is DPI. > > without this Patch i get this warning: > > WARNING: CPU: 3 PID:

Re: [PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:19寫道: > > From: chunhui dai > > - disable tmds on phy on mt2701 > - support other resolutions like 1280x1024 If this patch does two things, it should be broken into two patches. > > without this Patch i see flickering on my TFT (1280x1024), > so

Re: [PATCH v2 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > Describe why need this patch. I think the reason is: For current mediatek dsi encoder, its possible crtc is fixed in crtc 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In some SoC the possible crtc is not fixed in this

Re: [PATCH v2 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > > From: Jitao Shi > > [Detail] > dpi/dsi get the possible_crtc by > mtk_drm_find_possible_crtc_by_comp(*drm_dev, ddp_comp) > I would like more information of why do this patch. For example: For current mediatek dsi encoder, its possible

Re: [PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080

2020-08-02 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月2日 週日 下午12:44寫道: > > Hi, > > Am 2. August 2020 02:08:44 MESZ schrieb Chun-Kuang Hu > : > >Hi, Frank: > >> - disable tmds on phy on mt2701 > >> - support other resolutions like 1280x1024 > > > >If this

Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-02 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月2日 週日 下午4:06寫道: > > > Gesendet: Sonntag, 02. August 2020 um 02:03 Uhr > > Von: "Chun-Kuang Hu" > > An: "Frank Wunderlich" > > Cc: "Chun-Kuang Hu" , "Philipp Zabel" > > , "Davi

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-03 Thread Chun-Kuang Hu
Neal Liu 於 2020年8月3日 週一 下午12:05寫道: > > Hi Chun-Kuang, > > On Sun, 2020-08-02 at 07:50 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > > > > > MediaTek bus fabric provides TrustZone security support and da

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-03 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月3日 週一 下午12:01寫道: > > Hi Chun-Kuang, > > On Sat, 2020-08-01 at 08:12 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > This patch is for "mediatek,mt6779-devapc", so I think commit title > > should show the SoC ID. >

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-03 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月3日 週一 上午11:32寫道: > > Hi Chun-Kuang, > > On Fri, 2020-07-31 at 23:03 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月31日 週五 上午10:44寫道: > > > > > > Hi Chun-Kuang, > > > > > > > &

Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-03 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月3日 週一 下午6:43寫道: > > Hi > > Gesendet: Montag, 03. August 2020 um 01:47 Uhr > > Von: "Chun-Kuang Hu" > > > Now I just care about the bls to dpi. So in mediatek,disp.txt, you > > just need to add a Optional propertie

[PATCH v5 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu tz_disabled is used to control mtk_hdmi output signal, but this variable is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move tz_disabled to mtk_hdmi where it's used. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c

[PATCH v5 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-08-22 Thread Chun-Kuang Hu
: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu (1): MAINTAINERS: add files for Mediatek DRM drivers MAINTAINERS | 1 + drivers/gpu/drm/mediatek/Kconfig | 2 +- drivers/gpu/drm/mediatek/Makefile | 5

[PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-22 Thread Chun-Kuang Hu
Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b

[PATCH v5 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is a part of mtk_hdmi module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig| 9

[PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig

Re: [RESEND PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-09-12 Thread Chun-Kuang Hu
Hi, Daniel Vetter 於 2020年9月10日 週四 下午1:48寫道: > > On Thu, Sep 10, 2020 at 06:35:21AM +0800, Chun-Kuang Hu wrote: > > Hi, Andrzej & Neil: > > > > Enric Balletbo i Serra 於 2020年8月26日 週三 > > 下午4:53寫道: > > > > > > > > Conver

Re: [PATCH v6 1/4] drm/mediatek: disable tmds on mt2701

2020-09-14 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年9月4日 週五 下午7:01寫道: > > From: chunhui dai > > Without that patch if you use specific resolutions like 1280x1024, > I can see distortion in the output. It seems as if the > frequency for updating the pixel of the image is out of sync. > > For initialization tmds

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_ddp_comp_init()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月5日 週六 下午4:31寫道: > > if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have > a corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. > Reviewed-by: Chun-Kuang Hu > F

Re: [PATCH] drm/mediatek: add exception handing in mtk_drm_probe() if component init fail

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月9日 週三 下午4:50寫道: > > mtk_ddp_comp_init() is called in a loop in mtk_drm_probe(), if it > fail, previous successive init component is not proccessed. > > Thus uninitialize valid component and put their device if component > init failed. Reviewed

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_drm_kms_init()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月11日 週五 下午7:22寫道: > > if of_find_device_by_node() succeed, mtk_drm_kms_init() doesn't have > a corresponding put_device(). Thus add jump target to fix the exception > handling for this function implementation. Reviewed-by: Chun-Kuang Hu > > F

  1   2   3   4   5   >