Re: [PATCH v9, 08/11] drm/mediatek: add has_dither private data for gamma

2021-01-07 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道: > > not all SoC has dither function in gamma module > dd private data to control this function setting 'add' ? > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 12 +--- > 1 file changed, 9 inser

Re: [PATCH v2, 01/17] dt-bindings: mediatek: add description for postmask

2020-12-15 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月12日 週六 下午12:12寫道: > > add description for postmask What is postmask? I google it and find a postmask ECO. So it is postmask ECO? Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,di

Re: [PATCH v2, 15/17] soc: mediatek: mmsys: add mt8192 mmsys support

2020-12-15 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月14日 週一 上午8:39寫道: > > On Mon, 2020-12-14 at 00:02 +0800, Chun-Kuang Hu wrote: > > Hi, Yongqiang: > > > > Yongqiang Niu 於 2020年12月12日 週六 下午12:22寫道: > > > > > > add mt8192 mmsys support > > > > > >

Re: [PATCH v2, 10/17] drm/mediatek: fix aal size config

2020-12-16 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月12日 週六 下午12:22寫道: > > fix aal size config > > Fixes: 0664d1392c26 (drm/mediatek: Add AAL engine basic function) > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 11 ++- > 1 file changed, 10 insertions(+), 1 delet

Re: [PATCH v2, 02/17] dt-bindings: mediatek: add CLK_MM_DISP_CONFIG control description for mt8192 display

2020-12-16 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月12日 週六 下午12:12寫道: > > add CLK_MM_DISP_CONFIG control description for mt8192 displa display > > Signed-off-by: Yongqiang Niu > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff -

Re: [PATCH v2, 03/17] dt-bindings: mediatek: add description for mt8192 display

2020-12-13 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月12日 週六 下午12:12寫道: > > add description for mt8192 display Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- > 1 file changed, 1 ins

Re: [PATCH v2, 15/17] soc: mediatek: mmsys: add mt8192 mmsys support

2020-12-13 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月12日 週六 下午12:22寫道: > > add mt8192 mmsys support > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mmsys/Makefile | 1 + > drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 119 > ++ > include/linux/soc/mediatek/mtk

Re: [PATCH v8, 5/6] drm/mediatek: add RDMA fifo size error handle

2020-12-14 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月11日 週五 上午8:45寫道: > > On Thu, 2020-12-10 at 23:50 +0800, Chun-Kuang Hu wrote: > > Hi, Yongqiang: > > > > Yongqiang Niu 於 2020年12月10日 週四 下午5:08寫道: > > > > > > This patch add RDMA fifo size error handle > >

Re: [PATCH v2, 12/17] drm/mediatek: fix gamma size config

2020-12-14 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月12日 週六 下午12:13寫道: > > fix gamma size config I would like you to provide more information. The original code works in mt8173, why do you modify this? The description may be something like this: According to data sheet, the width is in bits [31, 16] and heig

Re: [PATCH v2] soc / drm: mediatek: cmdq: Remove timeout handler in helper function

2020-11-27 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年11月27日 週五 下午8:40寫道: > > Hi Chun-Kuang, > > On 20/11/2020 00:46, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > I've provided the example for why of this patch. How do you think > > about this patch? > > >

Re: [PATCH] drm/mediatek: Use correct aliases name for ovl

2020-11-28 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年11月27日 週五 下午7:02寫道: > > Aliases property name must include only lowercase and '-', so fix this > in the driver, so we're not tempted to do "ovl_2l0 = &ovl_2l0" in the > device-tree instead of the right one which is "ovl-2l0 = &ovl_2l0". > Applied to media

Re: [PATCH] drm/mediatek: dsi: Modify horizontal front/back porch byte formula

2020-11-21 Thread Chun-Kuang Hu
Bilal Wasim 於 2020年11月20日 週五 上午8:30寫道: > > Hi CK, > > On Fri, 20 Nov 2020 07:23:35 +0800 > Chun-Kuang Hu wrote: > > > From: CK Hu > > > > In the patch to be fixed, horizontal_backporch_byte become to large > > for some panel, so roll back that patch

Re: [PATCH v4 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月1日 週五 下午11:23寫道: > > Convert mtk_dsi to a bridge driver with built-in encoder support for > compatibility with existing component drivers. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > Acke

Re: [PATCH v4 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-05-01 Thread Chun-Kuang Hu
l be > named next_bridge. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > Acked-by: Sam Ravnborg > --- > > Changes in v4: None > Changes in v3: > - Replace s/bridge/next bridge/ for comment. (Laurent Pinchart) &g

Re: [PATCH v3 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月1日 週五 下午10:59寫道: > > Hi Chun-Kuang, > > Thank you for your review. > > On 1/5/20 16:26, Chun-Kuang Hu wrote: > > Hi, Enric: > > > > Enric Balletbo i Serra 於 2020年4月17日 週五 > > 下午11:06寫道: > >> &

Re: Re: [PATCH] drm/mediatek: cleanup coding style in mediatek a bit

2020-04-30 Thread Chun-Kuang Hu
Hi, Bernard: Bernard 於 2020年4月30日 週四 下午2:32寫道: > > > > 发件人:Chun-Kuang Hu > 发送日期:2020-04-29 22:22:50 > 收件人:Bernard Zhao > 抄送人:Chun-Kuang Hu ,Philipp Zabel > ,David Airlie ,Daniel Vetter > ,Matthias Brugger ,DRI Development > ,Linux ARM > ,"moderated li

Re: [PATCH v3 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年4月17日 週五 下午11:06寫道: > > Convert mtk_dsi to a bridge driver with built-in encoder support for > compatibility with existing component drivers. > > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v3: > - Add the bridge.type. (Laurent Pinchart) >

Re: [PATCH v3 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年4月17日 週五 下午11:06寫道: > > The mtk_dsi driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by

Re: [PATCH v3 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-05-01 Thread Chun-Kuang Hu
Enric Balletbo i Serra 於 2020年4月17日 週五 下午11:06寫道: > > Replace the manual panel handling code by a drm_panel_bridge. This > simplifies the driver and allows all components in the display pipeline > to be treated as bridges, paving the way to generic connector handling. > > Signed-off-by: Enric Ball

Re: [PATCH v3 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-05-01 Thread Chun-Kuang Hu
t; Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > --- > > Changes in v3: > - Use next_bridge field to store the panel bridge. (Laurent Pinchart) > - Add the bridge.type field. (Laurent Pinchart) > - This patch requires

Re: [PATCH v3 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年4月17日 週五 下午11:06寫道: > > Use the drm_bridge_connector helper to create a connector for pipelines > that use drm_bridge. This allows splitting connector operations across > multiple bridges when necessary, instead of having the last bridge in > the chain cre

Re: [PATCH -next] drm/mediatek: Fix Kconfig warning

2020-04-28 Thread Chun-Kuang Hu
Daniel Vetter 於 2020年4月28日 週二 下午10:55寫道: > > On Sun, Apr 26, 2020 at 04:20:39PM +0800, Chun-Kuang Hu wrote: > > Hi, YueHaibing: > > > > YueHaibing 於 2020年4月20日 週一 下午10:04寫道: > > > > > > WARNING: unmet direct dependencies detected for MTK_MMSYS

Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning

2020-04-29 Thread Chun-Kuang Hu
mp;& HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || > ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] > > Make DRM_MEDIATEK depend on MTK_MMSYS to fix this. Reviewed-by: Chun-Kuang Hu > > Fixes: 2c758e30

Re: [PATCH] drm/mediatek: cleanup coding style in mediatek a bit

2020-04-29 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年4月27日 週一 下午3:53寫道: > > This code change is to make code bit more readable. > Optimise array size align to HDMI macro define. > Add check if len is overange. One patch should just do one thing, but this do three things. So break this into three patches. Regards,

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-11 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月11日 週四 下午5:26寫道: > > On Wed, 2020-06-10 at 00:01 +0800, Chun-Kuang Hu wrote: > Hi Chun-Kuang, > > [snip] > > > > + > > > +/* > > > + * mtk_devapc_pd_get - get devapc pd_types of register address. >

Re: [PATCH] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-05-27 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年5月22日 週五 下午6:12寫道: > > If panel has too small hfp or hbp, horizontal_frontporch_byte or > horizontal_backporch_byte may become very small value or negative > value. This patch adjusts their values so that they are greater > than minimum value and keep total of them unc

Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-06-30 Thread Chun-Kuang Hu
ain of drm_bridge API > >> unconditionally. > >> > >> The patches has been tested on a Acer Chromebook R13 (Elm) running a > >> Chrome OS userspace and checking that the valid EDID mode reported by > >> the bridge is selected. > >> > &g

Re: [PATCH v2 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-24 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月19日 週五 下午6:01寫道: > > MT6873 bus frabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violations are logged and sent to the processor for > further analysis or countermeasures. >

Re: [PATCH v3 9/9] drm/mediatek: reduce clear event

2020-07-07 Thread Chun-Kuang Hu
Hi, Dennis: Dennis YC Hsieh 於 2020年7月7日 週二 下午11:47寫道: > > No need to clear event again since event always clear before wait. > This fix depend on patch: > "soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api" Acked-by: Chun-Kuang Hu > > Fixes: 2f965be7f900

Re: [PATCH v3 8/9] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api

2020-07-07 Thread Chun-Kuang Hu
Hi, Dennis: Dennis YC Hsieh 於 2020年7月7日 週二 下午11:47寫道: > > Add clear parameter to let client decide if > event should be clear to 0 after GCE receive it. For DRM part, Acked-by: Chun-Kuang Hu > > Change since v2: > - Keep behavior in drm crtc driver and > separate bug

Re: [PATCH] drm/mediatek: check plane visibility in atomic_update

2020-06-22 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2020年6月22日 週一 下午1:32寫道: > > Disable the plane if it's not visible. Otherwise mtk_ovl_layer_config() > would proceed with invalid plane and we may see vblank timeout. Except the Fixes tag, Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Hsin-Yi Wa

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-12 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月12日 週五 上午11:04寫道: > > Hi Chun-Kuang, > > [snip] > > > > > +/* > > > > > + * devapc_violation_irq - the devapc Interrupt Service Routine (ISR) > > > > > will dump > > > > > + * violation information including which > > > > > master violates > > >

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-12 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月9日 週二 下午6:25寫道: > > MT6873 bus frabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violations are logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-13 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月9日 週二 下午6:25寫道: > > MT6873 bus frabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violations are logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH] drm/mediatek: remove unnecessary conversion to bool

2020-06-15 Thread Chun-Kuang Hu
Joe Perches 於 2020年6月15日 週一 上午4:41寫道: > > On Fri, 2020-06-12 at 20:40 +0800, Bernard Zhao wrote: > > In function mtk_dsi_clk_hs_state, remove unnecessary conversion > > to bool return, this change is to make the code a bit readable. > [] > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > > b/d

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-15 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月15日 週一 上午10:43寫道: > > Hi Chun-Kuang, > > > On Sun, 2020-06-14 at 11:26 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年6月9日 週二 下午6:25寫道: > > > > > > MT6873 bus frabric provides TrustZone security

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-15 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年6月15日 週一 下午10:14寫道: > > Hi, Neal: > > Neal Liu 於 2020年6月15日 週一 上午10:43寫道: > > > > Hi Chun-Kuang, > > > > > > On Sun, 2020-06-14 at 11:26 +0800, Chun-Kuang Hu wrote: > > > Hi, Neal: > > > > > > Neal Liu

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-15 Thread Chun-Kuang Hu
O should us to find help? I think we just need vio address. Using mt8173 for example, if the vio address is 0x1400d03c, we could find the device in mt8173.dtsi [1], ovl1: ovl@1400d000 { compatible = "mediatek,mt8173-disp-ovl"; reg = <0 0x1400d000 0 0x1000>; }; we co

Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver

2020-07-13 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月13日 週一 下午4:27寫道: > > Hi Chun-Kuang, > > Thanks for your review. > > On Fri, 2020-07-10 at 22:21 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月10日 週五 上午11:23寫道: > > > > > > Hi Chun-Kuang,

Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions

2020-10-05 Thread Chun-Kuang Hu
Hi, Rob: Rob Herring 於 2020年10月5日 週一 下午9:45寫道: > > On Sun, Oct 4, 2020 at 12:50 AM Phil Chang wrote: > > > > Certain SoCs need to support large amount of reserved memory > > regions, especially to follow the GKI rules from Google. > > In MTK new SoC requires more than 68 regions of reserved memo

Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions

2020-10-05 Thread Chun-Kuang Hu
config. Agree that WHY of this patch is more important than HOW of this patch. Regards, Chun-Kuang. > > Rob > > > > > > > On Sun, 2020-10-04 at 21:05 +0800, Chun-Kuang Hu wrote: > > > Hi, Phil: > > > > > > Phil Chang 於 2020年10月4日 週日 下午1:51寫道: &g

Re: [PATCH 2/4] soc: mediatek: mmsys: Use devm_platform_ioremap_resource()

2020-10-06 Thread Chun-Kuang Hu
Enric Balletbo i Serra 於 2020年10月7日 週三 上午3:33寫道: > > For the common platform_get_resource()+devm_platform_ioremap() combination, > there is a helper, so use it and make the code a bit more compact. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --

Re: [PATCH 3/4] soc: mediatek: mmsys: Create struct mtk_mmsys to store context data

2020-10-06 Thread Chun-Kuang Hu
Reviewed-by: Chun-Kuang Hu > > Signed-off-by: CK Hu > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/soc/mediatek/mtk-mmsys.c | 47 ++-- > 1 file changed, 27 insertions(+), 20 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-

Re: [PATCH 3/4] soc: mediatek: mmsys: Create struct mtk_mmsys to store context data

2020-10-06 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年10月7日 週三 上午7:24寫道: > > Enric Balletbo i Serra 於 2020年10月7日 週三 > 上午3:33寫道: > > > > From: CK Hu > > > > Apart from the driver data, in order to extend the driver to support more > > and more SoCs, we will need to store other configu

Re: [PATCH 2/4] soc: mediatek: mmsys: Use devm_platform_ioremap_resource()

2020-10-06 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年10月7日 週三 上午7:21寫道: > > Enric Balletbo i Serra 於 2020年10月7日 週三 > 上午3:33寫道: > > > > For the common platform_get_resource()+devm_platform_ioremap() combination, > > there is a helper, so use it and make the code a bit more compact. > > Reviewe

Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-06 Thread Chun-Kuang Hu
and use a table per SoC so the > code will be more portable and clear. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: CK Hu > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/soc/mediatek/mtk-mmsys.c | 393 +-- > 1 file changed, 210 insertions(+), 183 deletions(-) >

Re: [PATCH v7] Add MediaTek MT6779 devapc driver

2020-10-02 Thread Chun-Kuang Hu
Hi, Neal: You may find Matthias in IRC [1], the channel name is #linux-mediatek [1] https://webchat.freenode.net/ Neal Liu 於 2020年9月30日 週三 下午3:10寫道: > > Hi Matt, > > Hope this mail could find you well. > Is everything okay? > It would be glad if you could reply me no matter the review status. >

Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver

2020-10-02 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月27日 週四 上午11:07寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. >

Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ

2020-10-02 Thread Chun-Kuang Hu
Hi, Jassi: Jassi Brar 於 2020年10月3日 週六 上午4:30寫道: > > On Sun, Sep 27, 2020 at 6:04 PM Chun-Kuang Hu wrote: > > > > CMDQ helper provide timer to detect execution timeout, but DRM driver > > could have a better way to detect execution timeout by vblank IRQ. > > For DR

Re: [PATCH v3] mailbox: mediatek: Fix handling of platform_get_irq() error

2020-10-02 Thread Chun-Kuang Hu
Krzysztof Kozlowski 於 2020年8月28日 週五 上午2:25寫道: > > platform_get_irq() returns -ERRNO on error. In such case casting to u32 > and comparing to 0 would pass the check. > Reviewed-by: Chun-Kuang Hu > Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver") &

Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions

2020-10-04 Thread Chun-Kuang Hu
Hi, Phil: Phil Chang 於 2020年10月4日 週日 下午1:51寫道: > > Certain SoCs need to support large amount of reserved memory > regions, especially to follow the GKI rules from Google. > In MTK new SoC requires more than 68 regions of reserved memory > for each IP's usage, such as load firmware to specific sap

Re: [PATCH v6 2/2] soc: mediatek: add mt6779 devapc driver

2020-08-26 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月26日 週三 下午5:59寫道: > > Hi Chun-Kuang, > > On Tue, 2020-08-18 at 14:20 +0800, Neal Liu wrote: > > Hi Chun-Kuang, > > > > On Tue, 2020-08-18 at 10:44 +0800, Neal Liu wrote: > > > Hi Chun-Kuang, > > > > > > On Mon, 2

Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-08-26 Thread Chun-Kuang Hu
Hi, Jitao: Chun-Kuang Hu 於 2020年8月18日 週二 下午10:45寫道: > > Hi, Jitao: > > Jitao Shi 於 2020年8月18日 週二 上午10:41寫道: > > > > On Tue, 2020-08-18 at 07:42 +0800, Chun-Kuang Hu wrote: > > > Hi, Jitao: > > > > > > Jitao Shi 於 2020年8月17日 週一 下午9:07寫道: >

Re: [PATCH -next] drm/mediatek: remove duplicate include

2020-08-26 Thread Chun-Kuang Hu
Hi, Wang Hai: Chun-Kuang Hu 於 2020年8月21日 週五 上午7:23寫道: > > Hi, Wang Hai: > > Wang Hai 於 2020年8月19日 週三 上午11:00寫道: > > > > Remove mtk_drm_ddp.h which is included more than once > > > > Reviewed-by: Chun-Kuang Hu > Applied to mediatek-drm-fixes [1], thank

Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-07 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年10月7日 週三 上午3:33寫道: > > From: CK Hu > > Actually, setting the registers for routing, use multiple 'if-else' for > different > routes, but this code would be more and more complicated while we > support more and more SoCs. Change that and use a table per S

Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-10 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年10月8日 週四 下午6:22寫道: > > Hi Enric and CK, > > On 06/10/2020 21:33, Enric Balletbo i Serra wrote: > > From: CK Hu > > > > Actually, setting the registers for routing, use multiple 'if-else' for > > different > > routes, but this code would be more and more com

Re: [v4 PATCH 0/2] fix scrolling of panel with small hfp or hbp

2020-10-12 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年10月10日 週六 下午3:09寫道: > > Changes since v3: > - Revert v2, for v2 will cause some bridge ic no output. the cause >the video linetime doesn't match display mode from get mode. > - Make sure the horizontal_frontporch_byte and horizontal_backporch_byte >are > 0.

[PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ

2020-09-27 Thread Chun-Kuang Hu
proprietary one to get the necessary data in callback function. Remove struct cmdq_client to access client instance data by struct mbox_client. Chun-Kuang Hu (4): soc / drm: mediatek: cmdq: Remove timeout handler in helper function mailbox / soc / drm: mediatek: Use mailbox rx_callback instead of

[PATCH 1/4] soc / drm: mediatek: cmdq: Remove timeout handler in helper function

2020-09-27 Thread Chun-Kuang Hu
For each client driver, its timeout handler need to dump hardware register or its state machine information, and their way to detect timeout are also different, so remove timeout handler in helper function and let client driver implement its own timeout handler. Signed-off-by: Chun-Kuang Hu

[PATCH 2/4] mailbox / soc / drm: mediatek: Use mailbox rx_callback instead of cmdq_task_cb

2020-09-27 Thread Chun-Kuang Hu
rx_callback is a standard mailbox callback mechanism and could cover the function of proprietary cmdq_task_cb, so use the standard one instead of the proprietary one. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 17 +-- drivers/mailbox/mtk-cmdq-mailbox.c

[PATCH 4/4] drm/mediatek: Detect CMDQ execution timeout

2020-09-27 Thread Chun-Kuang Hu
CMDQ is used to update display register in vblank period, so it should be execute in next vblank. If it fail to execute in next 2 vblank, tiemout happen. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion

[PATCH 3/4] mailbox / soc / drm: mediatek: Remove struct cmdq_client

2020-09-27 Thread Chun-Kuang Hu
mbox_client to get struct client_instance. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 35 drivers/soc/mediatek/mtk-cmdq-helper.c | 52 include/linux/mailbox/mtk-cmdq-mailbox.h | 1 - include/linux/soc/mediatek/mtk-cmdq.h

Re: [PATCH v5 10/13] soc: mediatek: cmdq: export finalize function

2020-05-25 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年5月25日 週一 下午4:38寫道: > > > > On 25/05/2020 02:23, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2020年5月17日 週日 上午2:22寫道: > >> > >> > >> > >> On 08/03/2020 11:52, Dennis YC

Re: [PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-09 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月4日 週一 下午10:14寫道: > > The mtk-dpi driver still uses the drm_encoder API which is now somehow > deprecated. We started to move all the Mediatek drivers to the drm_bridge API, > like we did for the mtk-dsi driver [1], this is another small step to be able

Re: [PATCH] drm/mediatek: eliminate the magic number in array size

2020-05-09 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年5月6日 週三 下午8:43寫道: > > Eiminate the magic number in array size, there macro defines in > hdmi.h. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang >

Re: [PATCH v2] drm/mediatek: cleanup coding style in mediatek a bit

2020-05-09 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年5月6日 週三 下午8:34寫道: > > This code change is to make code bit more readable. > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang > Signed-off-by: Bern

Re: [PATCH 1/3] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-05-05 Thread Chun-Kuang Hu
l be > named next_bridge. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/gpu/drm/mediatek/mtk_dpi.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/d

Re: [PATCH 2/3] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-05-05 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月4日 週一 下午10:14寫道: > > Convert mtk_dpi to a bridge driver with built-in encoder support for > compatibility with existing component drivers. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --- > >

Re: [PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-05-05 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月4日 週一 下午10:14寫道: > > The mtk_dpi driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --- > >

Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning

2020-05-05 Thread Chun-Kuang Hu
Hi, YueHaibing: Chun-Kuang Hu 於 2020年4月29日 週三 下午10:15寫道: > > Hi, YueHaibing: > > YueHaibing 於 2020年4月29日 週三 下午3:14寫道: > > > > WARNING: unmet direct dependencies detected for MTK_MMSYS > > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) &

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo Serra 於 2020年5月14日 週四 上午12:41寫道: > > Hi Chun-Kuang, > > Missatge de Enric Balletbo i Serra del > dia dv., 1 de maig 2020 a les 17:25: > > > > Use the drm_bridge_connector helper to create a connector for pipelines > > that use drm_bridge. This allows splitting connector

Re: [PATCH v5 10/13] soc: mediatek: cmdq: export finalize function

2020-05-24 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年5月17日 週日 上午2:22寫道: > > > > On 08/03/2020 11:52, Dennis YC Hsieh wrote: > > Export finalize function to client which helps append eoc and jump > > command to pkt. Let client decide call finalize or not. > > > > Signed-off-by: Dennis YC Hsieh > > Reviewed-by:

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月14日 週四 下午11:42寫道: > > Hi Chun-Kuang, > > On 14/5/20 16:28, Chun-Kuang Hu wrote: > > Hi, Enric: > > > > Enric Balletbo Serra 於 2020年5月14日 週四 上午12:41寫道: > >> > >> Hi Chun-Kuang, > >> > >&g

Re: [PATCH RESEND v9 18/18] media: platform: Add jpeg enc feature

2020-06-07 Thread Chun-Kuang Hu
Hi, Xia: Xia Jiang 於 2020年6月4日 週四 下午5:21寫道: > > Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg > decode and encode have great similarities with function operation. > > Signed-off-by: Xia Jiang > --- > v9: add member variable(struct v4l2_rect) in out_q structure for stori

Re: [PATCH v5 1/7] dt-bindings: mediatek: add mt7623 display-nodes

2020-08-27 Thread Chun-Kuang Hu
inux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Frank Wunderlich > Acked-by: Rob Herring > Reviewed-by: Chun-Kuang Hu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt| 2 +- > .../devicetree/bindings/display/mediatek/mediatek,dpi

Re: [PATCH v5 2/7] drm/mediatek: add ddp routing for mt7623

2020-08-27 Thread Chun-Kuang Hu
ext [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Frank Wunderlich > Reviewed-by: Chun-Kuang Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 23 +++ >

Re: [PATCH v5 5/7] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-27 Thread Chun-Kuang Hu
Agree with Matthias, so squash this patch into 4/7, and applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Regards, > Matthias > > > Signed-off-by: Jitao Shi &

Re: Aw: Re: [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701

2020-08-27 Thread Chun-Kuang Hu
Hi, Frank: Matthias Brugger 於 2020年8月27日 週四 下午10:28寫道: > > > > On 27/08/2020 15:41, Frank Wunderlich wrote: > > Hi Matthias, > > > > any opinions about the dts-changes? > > > > they look good to me. > > > maybe series except the tmds-Patch get merged...so i add it only to my own > > repo till we

Re: [PATCH v5 0/7] make hdmi work on bananapi-r2

2020-09-03 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年9月3日 週四 下午11:07寫道: > > Hi > > Any opinion about DTS Patches? Which maintainer will include it in tree? Is > any ack/review needed? According to maintainer list [1], the maintainer is ARM/Mediatek SoC support M: Matthias Brugger L: linux-arm-ker...@lists.infradead.org (m

Re: [PATCH v9 10/32] drm: mediatek: use common helper for a scatterlist contiguity check

2020-09-01 Thread Chun-Kuang Hu
Hi, Marek: Marek Szyprowski 於 2020年8月26日 週三 下午2:35寫道: > > Use common helper for checking the contiguity of the imported dma-buf and > do this check before allocating resources, so the error path is simpler. > Acked-by: Chun-Kuang Hu > Signed-off-by: Marek Szyprowski > ---

Re: [PATCH v9 11/32] drm: mediatek: use common helper for extracting pages array

2020-09-01 Thread Chun-Kuang Hu
to > sg_free_table(sgt) before its kfree(sgt)? Yes, we need another patch to fix that bug, But for this patch, Acked-by: Chun-Kuang Hu > > > Signed-off-by: Marek Szyprowski > > --- > > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 9 ++--- > > 1 file changed,

Re: [PATCH v5 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-09-02 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年8月23日 週日 上午9:48寫道: > > mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_hdmi_phy driver into phy driver folder. For this series, applied to mediatek-drm-next

Re: [PATCH 1/2] dt-bindings: clock: mediatek: add bindings for MT8167 clocks

2020-09-07 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年9月7日 週一 下午8:57寫道: > > Add binding documentation for topckgen, apmixedsys, infracfg, audsys, > imgsys, mfgcfg, mmsys, vdecsys on MT8167 SoC. Why don't you add compatible of "mediatek,mt8167-mmsys"? Regards, Chun-Kuang. > > Signed-off-by: Fabien Parent > --- >

Re: [PATCH v6 2/2] soc: mediatek: add mt6779 devapc driver

2020-08-17 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月17日 週一 下午12:02寫道: > > Hi Chun-Kuang, > > On Sat, 2020-08-15 at 11:03 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年8月13日 週四 上午11:33寫道: > > > > > > MediaTek bus fabric provides TrustZone security sup

Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-08-17 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年8月17日 週一 下午9:07寫道: > > horizontal_backporch_byte should be hbp * bpp - hbp extra bytes. > So remove the wrong subtraction 10. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > >

Re: [PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-30 Thread Chun-Kuang Hu
Hi, Chunfeng & Kishon: How do you feel about this patch? Regards, Chun-Kuang. Chun-Kuang Hu 於 2020年8月23日 週日 上午9:48寫道: > > From: CK Hu > > mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder

Re: [PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-30 Thread Chun-Kuang Hu
Hi, Chunfeng & Kishon: How do you feel about this patch? Regards, Chun-Kuang. Chun-Kuang Hu 於 2020年8月23日 週日 上午9:48寫道: > > Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to > drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' > inform

Re: [PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-31 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年8月31日 週一 上午9:48寫道: > > On Mon, 2020-08-31 at 07:03 +0800, Chun-Kuang Hu wrote: > > Hi, Chunfeng & Kishon: > > > > How do you feel about this patch? > It's fine to me, > > Reviewed-by: Chunfeng Yun > Could you giv

Re: [PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-31 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年8月31日 週一 上午9:50寫道: > > On Sun, 2020-08-23 at 09:48 +0800, Chun-Kuang Hu wrote: > > Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to > > drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' > > in

Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts > > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_drm_

Re: [PATCH v3 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-08-04 Thread Chun-Kuang Hu
e, so search > pipeline information to find out the correct possible crtc. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Stu Hsieh > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 42 + > drivers/gpu/drm/mediatek/mtk_

Re: [PATCH v3 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-04 Thread Chun-Kuang Hu
d in this case, so call > mtk_drm_find_possible_crtc_by_comp() to find out the correct possible > crtc. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++- > drivers/gpu/drm/mediatek/mtk_dsi.c

Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Ryder Lee > > Add display subsystem related device nodes for MT7623. > > Cc: CK Hu > Signed-off-by: chunhui dai > Signed-off-by: Bibby Hsieh > Signed-off-by: Ryder Lee > Signed-off-by: Frank Wunderlich > Tested-by: Frank Wunderl

Re: Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年8月4日 週二 下午10:44寫道: > > Hi, > > > Gesendet: Dienstag, 04. August 2020 um 16:34 Uhr > > Von: "Chun-Kuang Hu" > > > > -static const enum mtk_ddp_comp_id mt2712_mtk_ddp_main[] = { > > > +static enum mtk_ddp_comp_id mt2712

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-04 Thread Chun-Kuang Hu
Neal Liu 於 2020年8月4日 週二 上午10:19寫道: > > > On Tue, 2020-08-04 at 00:13 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年8月3日 週一 上午11:32寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Fri, 2020-07-31 at 23:03 +0800, Chu

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-04 Thread Chun-Kuang Hu
Neal Liu 於 2020年8月4日 週二 上午10:08寫道: > > On Tue, 2020-08-04 at 00:04 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年8月3日 週一 下午12:01寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Sat, 2020-08-01 at 08:12 +0800, Chun-Kua

Re: Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
ards Frank > > > > Gesendet: Dienstag, 04. August 2020 um 17:00 Uhr > > Von: "Chun-Kuang Hu" > > An: "Frank Wunderlich" > > > + mipi_tx0: mipi-dphy@1001 { > > > + compatible = "mediatek,mt7623-mipi-tx&quo

Re: [PATCH v4 2/6] drm/mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月5日 週三 上午12:56寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts Reviewed-by: Chun-Kuang Hu > >

Re: [PATCH v4 1/6] dt-bindings: mediatek: add mt7623 display-nodes

2020-08-04 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年8月5日 週三 上午12:56寫道: > > From: Frank Wunderlich > > mt7623 uses mt2701/mt8173 for drm, but have own compatibles Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Frank Wunderlich > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt

Re: [PATCH 1/2] dt-bindings: clock: mediatek: add bindings for MT8167 clocks

2020-09-07 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年9月8日 週二 上午12:05寫道: > > Hi Chun-Kuang, > > > Why don't you add compatible of "mediatek,mt8167-mmsys"? > > I forgot to remove 'mmsys' from the commit message. I decided to add > the documentation as part of the series that add support for MT8167 to > drivers/soc/med

<    1   2   3   4   5   >