Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_ddp_comp_init()

2020-09-07 Thread Chun-Kuang Hu
Hi Yu Kuai: Yu Kuai 於 2020年9月5日 週六 下午4:31寫道: > > if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have > a corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. > This patch looks good to me, but I find another thing r

Re: [PATCH v6 2/2] soc: mediatek: add mt6779 devapc driver

2020-08-15 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月13日 週四 上午11:33寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. >

Re: [PATCH v2 2/2] drm/mediatek: mtk_hdmi: add MT8167 support for HDMI

2020-10-13 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月14日 週三 上午2:19寫道: > > Add support for HDMI on MT8167. HDMI on MT8167 is similar to > MT8173/MT2701 execpt for the two registers: SYS_CFG1C and SYS_CFG20 > > Signed-off-by: Fabien Parent > --- > > Changelog: > v2: fix name of pdata structure > > drivers/gpu/drm

Re: [PATCH v2 2/2] drm/mediatek: mtk_hdmi: add MT8167 support for HDMI

2020-10-14 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月14日 週三 上午2:19寫道: > > Add support for HDMI on MT8167. HDMI on MT8167 is similar to > MT8173/MT2701 execpt for the two registers: SYS_CFG1C and SYS_CFG20 I think you should drop this series. According to Mediatek HDMI binding document [1], the second parameter o

Re: [PATCH] MAINTAINERS: change mediatek wiki page

2020-10-21 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年10月20日 週二 下午11:27寫道: > > From: Matthias Brugger > > The old wiki page unfortunately got lost by server crash. > The new wiki can be found on the kernel.org infrastructure > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Matthias Brugger > --- &g

Re: [PATCH 2/8] dt-bindings: display: mediatek: dsi: add documentation for MT8167 SoC

2020-10-21 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月21日 週三 上午1:43寫道: > > Add binding documentation for the MT8167 SoC. The SoC needs > an additional clock compared to the already supported SoC: mipi26m. > > Signed-off-by: Fabien Parent > --- > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt | 7

Re: [PATCH 4/8] drm/mediatek: dsi: add pdata variable to start clk in HS mode

2020-10-21 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月21日 週三 上午1:43寫道: > > On MT8167, DSI seems to work fine only if we start the clk in HS mode. > If we don't start the clk in HS but try to switch later to HS, the > display does not work. > > This commit adds a platform data variable to be used to start the > DSI

Re: [PATCH 1/2] dt-bindings: mediatek: mmsys: add mt1867 binding

2020-10-27 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月28日 週三 上午12:07寫道: > > Add binding documentation for MT8167 SoC. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Fabien Parent > --- > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.txt | 1 + > 1 file changed, 1 insert

Re: [PATCH 1/8] dt-bindings: display: mediatek: disp: add documentation for MT8167 SoC

2020-10-21 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月21日 週三 上午1:43寫道: > > Add binding documentation for the MT8167 SoC > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Fabien Parent > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt| 4 ++-- > 1 file changed, 2 inser

Re: [PATCH 3/8] drm/mediatek: add disp-color MT8167 support

2020-10-21 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月21日 週三 上午1:43寫道: > > Add support for disp-color on MT8167 SoC. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Fabien Parent > --- > drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +++ > 1 file changed, 7 insertions(+) > > d

Re: [PATCH 7/8] drm/mediatek: add DDP support for MT8167

2020-10-21 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月21日 週三 上午1:43寫道: > > Add DDP support for MT8167 SoC. > > Signed-off-by: Fabien Parent > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 50 ++ > 1 file changed, 50 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c >

Re: [PATCH v2 4/5] drm/mediatek: add DDP support for MT8167

2020-10-23 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月23日 週五 下午9:31寫道: > > Add DDP support for MT8167 SoC. Reviewed-by: Chun-Kuang Hu > Signed-off-by: Fabien Parent > --- > > Changelog: > > V2: don't set DDP_MUTEX_SOF_DSI{1,2,3} since they are not available on MT8167

Re: [PATCH v2 2/5] dt-bindings: display: mediatek: dsi: add documentation for MT8167 SoC

2020-10-23 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月23日 週五 下午9:31寫道: > > Add binding documentation for the MT8167 SoC. Reviewed-by: Chun-Kuang Hu In [1], Mediatek DPI binding document has been changed to yaml format, would you please also change this document to yaml? Ditto for mediatek,disp.txt. [1]

Re: [PATCH v2 5/5] drm/mediatek: Add support for main DDP path on MT8167

2020-10-23 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月23日 週五 下午9:31寫道: > > Add the main (DSI) drm display path for MT8167. > > Signed-off-by: Fabien Parent > --- > > Changelog: > > V2: No change > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 38 ++ > 1 file changed, 38 insertions(+) > > dif

Re: [PATCH v5 1/1] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-10-29 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年10月13日 週二 下午6:06寫道: > > Replace horizontal_backporch_byte with vm->hback_porch * bpp to aovid > flowing judgement negative number. > > if ((vm->hfront_porch * dsi_tmp_buf_bpp + horizontal_backporch_byte) > > data_phy_cycles * dsi->lanes + delta) > > Signed-off-

[PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers

2020-10-29 Thread Chun-Kuang Hu
Mediatek MIPI DSI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-10-29 Thread Chun-Kuang Hu
mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_mipi_dsi_phy driver into phy driver folder. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig

[PATCH 0/3] Move Mediatek MIPI DSI PHY driver from DRM folder to PHY folder

2020-10-29 Thread Chun-Kuang Hu
mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_mipi_dsi_phy driver into phy driver folder. Chun-Kuang Hu (3): drm/mediatek: Separate mtk_mipi_tx to an independent module phy: mediatek:

[PATCH 1/3] drm/mediatek: Separate mtk_mipi_tx to an independent module

2020-10-29 Thread Chun-Kuang Hu
mtk_mipi_tx is a part of mtk_drm module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig | 8 drivers/gpu/drm/mediatek/Makefile

Re: [PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-11-01 Thread Chun-Kuang Hu
+ Vinod: Hi, Chunfeng: Chunfeng Yun 於 2020年10月30日 週五 下午2:24寫道: > > On Thu, 2020-10-29 at 23:27 +0800, Chun-Kuang Hu wrote: > > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's > > more suitable to place a phy driver into phy driver folder, so mo

[PATCH v2] soc / drm: mediatek: cmdq: Remove timeout handler in helper function

2020-11-01 Thread Chun-Kuang Hu
For each client driver, its timeout handler need to dump hardware register or its state machine information, and their way to detect timeout are also different, so remove timeout handler in helper function and let client driver implement its own timeout handler. Signed-off-by: Chun-Kuang Hu

Re: [PATCH] soc: mediatek: cmdq: fixup possible timeout issue

2020-11-01 Thread Chun-Kuang Hu
Hi, Houlong: Houlong Wei 於 2020年10月22日 週四 下午5:55寫道: > > Fixes: 576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper") > > There may be possible timeout issue when lots of cmdq packets are > flushed to the same cmdq client. The necessary modifications are as > below. > 1.Adjust the timer timeout

[PATCH v5 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu tz_disabled is used to control mtk_hdmi output signal, but this variable is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move tz_disabled to mtk_hdmi where it's used. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_h

[PATCH v5 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-08-22 Thread Chun-Kuang Hu
phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu (1): MAINTAINERS: add files for Mediatek DRM drivers MAINTAINERS | 1 + drivers/gpu/drm/mediatek/Kconfig | 2 +- drivers/gpu/drm/mediatek/Makefile

[PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-22 Thread Chun-Kuang Hu
Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAIN

[PATCH v5 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is a part of mtk_hdmi module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig| 9

[PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kc

Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver

2020-07-09 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月9日 週四 下午5:13寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH] drm/mediatek: Optimize functions which do not need to return

2020-10-16 Thread Chun-Kuang Hu
better to just call > the inner function. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 27 +++ > 1 file changed, 7 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/mediat

Re: [PATCH v4 24/24] MAINTAINERS: Add entry for MediaTek IOMMU

2020-11-11 Thread Chun-Kuang Hu
Hi Yong: Yong Wu 於 2020年11月11日 週三 下午8:53寫道: > > I am the author of MediaTek iommu driver, and will to maintain and > develop it further. > Add myself to cover these items. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yong Wu > --- > MAINTAINERS | 9 + > 1

Re: [PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-11-16 Thread Chun-Kuang Hu
Hi, Vinod: Vinod Koul 於 2020年11月16日 週一 下午3:25寫道: > > On 02-11-20, 07:08, Chun-Kuang Hu wrote: > > + Vinod: > > > > Hi, Chunfeng: > > > > Chunfeng Yun 於 2020年10月30日 週五 下午2:24寫道: > > > > > > On Thu, 2020-10-29 at 23:27 +0800, Chun-Kuang

Re: [PATCH 00/11] Decouple Mediatek DRM sub driver

2020-11-16 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年11月16日 週一 上午7:33寫道: > > Chun-Kuang Hu 於 2020年11月3日 週二 上午8:34寫道: > > > > mtk ccorr is controlled by DRM and MDP [1]. In order to share > > mtk_ccorr driver for DRM and MDP, decouple Mediatek DRM sub driver > > which include mtk_ccorr, so MDP coul

Re: [PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-16 Thread Chun-Kuang Hu
Hi, Bilal: Bilal Wasim 於 2020年11月16日 週一 下午7:53寫道: > > Hi CK, > > On Mon, 16 Nov 2020 07:12:55 +0800 > Chun-Kuang Hu wrote: > > > Hi, Bilal: > > > > Bilal Wasim 於 2020年11月16日 週一 > > 上午3:25寫道: > > > > > > Hi CK, > > >

[RESEND PATCH 0/3] Move Mediatek MIPI DSI PHY driver from DRM folder to PHY folder

2020-11-16 Thread Chun-Kuang Hu
mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_mipi_dsi_phy driver into phy driver folder. Chun-Kuang Hu (3): drm/mediatek: Separate mtk_mipi_tx to an independent module phy: mediatek:

[RESEND PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers

2020-11-16 Thread Chun-Kuang Hu
Mediatek MIPI DSI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

[RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-11-16 Thread Chun-Kuang Hu
mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_mipi_dsi_phy driver into phy driver folder. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig

[RESEND PATCH 1/3] drm/mediatek: Separate mtk_mipi_tx to an independent module

2020-11-16 Thread Chun-Kuang Hu
mtk_mipi_tx is a part of mtk_drm module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig | 8 drivers/gpu/drm/mediatek/Makefile

Re: [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-11-17 Thread Chun-Kuang Hu
Hi, Vinod: Chunfeng Yun 於 2020年11月17日 週二 上午11:36寫道: > > Hi CK, > On Tue, 2020-11-17 at 07:14 +0800, Chun-Kuang Hu wrote: > > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's > > more suitable to place a phy driver into phy driver folder, so

Re: [RESEND PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers

2020-11-17 Thread Chun-Kuang Hu
Hi, Vinod: Chun-Kuang Hu 於 2020年11月17日 週二 上午7:14寫道: > > Mediatek MIPI DSI phy driver is moved from drivers/gpu/drm/mediatek to > drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' > information. > > Signed-off-by: Chun-Kuang Hu If you apply this pat

[PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-14 Thread Chun-Kuang Hu
y: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dsi.c | 53 ++ 1 file changed, 18 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 4a188a942c38..2a64fdaed9a7 100644 --- a

Re: [PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-14 Thread Chun-Kuang Hu
Hi, Bilal: Please help to test this patch on your Chromebook elm, thanks. Regards, Chun-Kuang Hu Chun-Kuang Hu 於 2020年11月15日 週日 上午8:14寫道: > > From: CK Hu > > Using vm->hfront_porch + vm->hback_porch to calculate > horizontal_backporch_byte would make

Re: [PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-15 Thread Chun-Kuang Hu
Hi, Bilal: Bilal Wasim 於 2020年11月16日 週一 上午3:25寫道: > > Hi CK, > > On Sun, 15 Nov 2020 08:53:24 +0800 > Chun-Kuang Hu wrote: > > > Hi, Bilal: > > > > Please help to test this patch on your Chromebook elm, thanks. > > > > Regards, > > Chun-Ku

Re: [PATCH 00/11] Decouple Mediatek DRM sub driver

2020-11-15 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年11月3日 週二 上午8:34寫道: > > mtk ccorr is controlled by DRM and MDP [1]. In order to share > mtk_ccorr driver for DRM and MDP, decouple Mediatek DRM sub driver > which include mtk_ccorr, so MDP could use this decoupled mtk_ccorr. Applied the whole series into mediatek

Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

2020-11-04 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年11月4日 週三 下午6:40寫道: > > Hi > > On 5/10/20 18:22, Enric Balletbo i Serra wrote: > > Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver") > > introduced the following build warning with W=1 > > > > drivers/gpu/drm/mediatek/mtk_dpi.c:530:39

Re: [PATCH 0/3] Move Mediatek MIPI DSI PHY driver from DRM folder to PHY folder

2020-11-09 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年10月29日 週四 下午11:27寫道: > > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_mipi_dsi_phy driver into phy driver folder. Applied the whole series into mediatek-

Re: [PATCH v2 5/5] drm/mediatek: Add support for main DDP path on MT8167

2020-11-09 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月23日 週五 下午9:31寫道: > > Add the main (DSI) drm display path for MT8167. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Fabien Parent > --- > > Changelog: > > V2: No change > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 38 +++

[PATCH 00/11] Decouple Mediatek DRM sub driver

2020-11-02 Thread Chun-Kuang Hu
o DRM driver Chun-Kuang Hu (2): drm/mediatek: Get CMDQ client register for all ddp component drm/mediatek: Use correct device pointer to get CMDQ client register drivers/gpu/drm/mediatek/mtk_disp_color.c | 86 ++--- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 69 drivers/gpu/drm/med

[PATCH 01/11] drm/mediatek: Get CMDQ client register for all ddp component

2020-11-02 Thread Chun-Kuang Hu
Only OVL, RDMA,and WDMA get CMDQ client register information, but all ddp component should work with CMDQ, so get this information for all ddp component. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 28 ++--- 1 file changed, 14 insertions(+), 14

[PATCH 04/11] drm/mediatek: Move regs info from struct mtk_ddp_comp to sub driver private data

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so data belonged to sub driver should be moved into sub driver private data so it could be used for multiple path. regs info is one of sub driver data, so move it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu

[PATCH 06/11] drm/mediatek: Use struct cmdq_client_reg to gather cmdq variable

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu struct cmdq_client_reg include subsys and offset, so use it to replace these two variable. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 24 ++--- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 4 ++-- 2 files

[PATCH 03/11] drm/mediatek: Move clk info from struct mtk_ddp_comp to sub driver private data

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so data belonged to sub driver should be moved into sub driver private data so it could be used for multiple path. clk info is one of sub driver data, so move it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu

[PATCH 11/11] drm/mediatek: Move mtk_ddp_comp_init() from sub driver to DRM driver

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so sub driver should not directly call DRM driver's function. Moving mtk_ddp_comp_init() from sub driver to DRM driver to achieve this. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/med

[PATCH 09/11] drm/mediatek: Register vblank callback function

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so sub driver should not directly call crtc function. crtc register callback function to sub driver to prevent sub driver directly call crtc function. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu

[PATCH 08/11] drm/mediatek: Change sub driver interface from mtk_ddp_comp to device

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so sub driver interface should get rid of display info. Using device instead of mtk_ddp_comp make interface general. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_color.c

[PATCH 10/11] drm/mediatek: DRM driver directly refer to sub driver's function

2020-11-02 Thread Chun-Kuang Hu
ned-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 23 +++--- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 69 ++ drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 68 +++--- drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 46 +--- drive

[PATCH 07/11] drm/mediatek: Move cmdq_reg info from struct mtk_ddp_comp to sub driver private data

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so data belonged to sub driver should be moved into sub driver private data so it could be used for multiple path. cmdq_reg info is one of sub driver data, so move it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu

[PATCH 05/11] drm/mediatek: Remove irq in struct mtk_ddp_comp

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu irq in struct mtk_ddp_comp is useless, so remove it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek

[PATCH 02/11] drm/mediatek: Use correct device pointer to get CMDQ client register

2020-11-02 Thread Chun-Kuang Hu
Some ddp component use mmsys device pointer to get CMDQ client register, this would get mmsys' CMDQ client register, so use each ddp component's device pointer to get. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 2 +- drivers/gpu/drm/mediatek/mtk_

Re: [PATCH v2 1/5] dt-bindings: display: mediatek: disp: add documentation for MT8167 SoC

2020-11-07 Thread Chun-Kuang Hu
chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > > > Signed-off-by: Fabien Parent > > Reviewed-by: Chun-Kuang Hu > > --- > > > > Changelog: > > > > V2: No change > > > > .../devicetree/bindings/display/mediatek/mediate

Re: [PATCH v2 3/5] drm/mediatek: add disp-color MT8167 support

2020-11-07 Thread Chun-Kuang Hu
> Signed-off-by: Fabien Parent > Reviewed-by: Chun-Kuang Hu > --- > > Changelog: > > V2: No change > > drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_color.c > b/d

Re: [PATCH v2 4/5] drm/mediatek: add DDP support for MT8167

2020-11-07 Thread Chun-Kuang Hu
Hi, Fabien: Chun-Kuang Hu 於 2020年10月23日 週五 下午11:45寫道: > > Hi, Fabien: > > Fabien Parent 於 2020年10月23日 週五 下午9:31寫道: > > > > Add DDP support for MT8167 SoC. > > Reviewed-by: Chun-Kuang Hu For this patch, applied to mediatek-drm-next [1], thanks. [1] https://git.k

Re: [PATCH] drm/mediatek: Optimize functions which do not need to return

2020-11-07 Thread Chun-Kuang Hu
Hi, Bernard: Chun-Kuang Hu 於 2020年10月17日 週六 上午10:50寫道: > > Bernard Zhao 於 2020年10月13日 週二 下午4:55寫道: > > > > Function mtk_hdmi_aud_set_input always return 0, no need to > > keep the return value. Functions mtk_hdmi_aud_enable_packet & > > mtk_hdmi_aud_on_o

Re: [PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers

2020-11-07 Thread Chun-Kuang Hu
+ Vinod: Hi, Chunfeng: Chun-Kuang Hu 於 2020年10月29日 週四 下午11:28寫道: > > Mediatek MIPI DSI phy driver is moved from drivers/gpu/drm/mediatek to > drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' > information. Would you like this patch? If so, you could giv

Re: [v2 PATCH] dt-bindings: display: mediatek: convert the dpi bindings to yaml

2020-11-07 Thread Chun-Kuang Hu
Hi, Jitao: Rob Herring 於 2020年9月24日 週四 上午4:15寫道: > > On Thu, 17 Sep 2020 15:33:05 +0800, Jitao Shi wrote: > > Convert display/mediatek/mediatek,dpi.txt to > > display/mediatek/mediatek,dpi.yaml > > and remove the old text bindings. > > > > Signed-off-by: Jitao Shi > > --- > > .../bindings/disp

Re: [v7, PATCH 2/7] mtk-mmsys: add mmsys private data

2020-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年7月23日 週四 上午10:05寫道: > > add mmsys private data > > Feature: drm/mediatek > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/Makefile | 1 + > drivers/soc/mediatek/mmsys/Makefile | 2 + > drivers/soc/mediatek/mmsys/mt2701-mmsys.c

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年7月25日 週六 上午11:32寫道: > > On Sat, 2020-07-25 at 07:24 +0800, Chun-Kuang Hu wrote: > > Hi Yongqiang: > > > > Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > > > > > This patch add support for mediatek SOC MT8183 > >

Re: [v7, PATCH 6/7] drm/mediatek: add fifo_size into rdma private data

2020-07-24 Thread Chun-Kuang Hu
The primary thing of this patch is to get fifo size from device tree. So you may modify title to show the primary thing. Yongqiang Niu 於 2020年7月23日 週四 上午10:12寫道: > > the fifo size of rdma in mt8183 is different. > rdma0 fifo size is 5k > rdma1 fifo size is 2k I would like the description to be "

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-27 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月27日 週一 上午11:06寫道: > > Hi Chun-Kuang, > > On Fri, 2020-07-24 at 23:55 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月24日 週五 下午2:55寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Fri

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-27 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年7月27日 週一 下午3:54寫道: > > On Sat, 2020-07-25 at 07:24 +0800, Chun-Kuang Hu wrote: > > Hi Yongqiang: > > > > Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > > > > > This patch add support for mediatek SOC MT8183 > >

Re: [PATCH v2 1/2] [media] mtk-mdp: add driver to probe mdp components

2020-07-20 Thread Chun-Kuang Hu
Hi, Eizan: Eizan Miyamoto 於 2020年5月6日 週三 下午4:41寫道: > > Broadly, this patch (1) adds a driver for various MTK MDP components to > go alongside the main MTK MDP driver, and (2) hooks them all together > using the component framework. > > (1) Up until now, the MTK MDP driver controls 8 devices in th

Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver

2020-07-15 Thread Chun-Kuang Hu
HI, Neal: Neal Liu 於 2020年7月9日 週四 下午5:13寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-28 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月28日 週二 上午11:52寫道: > > Hi Chun-Kuang, > > On Mon, 2020-07-27 at 22:47 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月27日 週一 上午11:06寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Fri

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-28 Thread Chun-Kuang Hu
Neal Liu 於 2020年7月29日 週三 上午10:10寫道: > > Hi Chun-Kuang, > > On Tue, 2020-07-28 at 23:35 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月28日 週二 上午11:52寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Mon

Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-07-04 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年5月18日 週一 下午7:23寫道: > > From: Matthias Brugger > > The driver will be loaded by via a platform device. So we > will need to get the device_node from the parent device. > Depending on this we will set the driver data. > As all this is done later already, just delete the call t

Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

2020-07-04 Thread Chun-Kuang Hu
Hi, Enric: Chun-Kuang Hu 於 2020年5月19日 週二 下午11:12寫道: > > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月19日 週二 > 下午5:40寫道: > > > > There are some `static const u8` variables that are not used, this > > triggers a warning building with `make W=1`, it is safe to r

Re: [PATCH] drm/mediatek: mtk_hdmi: Remove debug messages for function calls

2020-07-04 Thread Chun-Kuang Hu
Hi, Enric: Chun-Kuang Hu 於 2020年5月19日 週二 下午11:13寫道: > > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月19日 週二 > 下午5:41寫道: > > > > Equivalent information can be nowadays obtained using function tracer > > > > Reviewed-by: Chun-Kuang Hu Applied to medi

Re: [RESEND PATCH v4 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-07-04 Thread Chun-Kuang Hu
l be > named next_bridge. > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > Acked-by: Sam Ravnborg

Re: [RESEND PATCH v4 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-07-04 Thread Chun-Kuang Hu
nkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Enric Balletbo i Serra > Acked-by: Sam Ravnborg > Reviewed-by: Chun-Kuang Hu > --- > > Changes in v4: > - Remove double call to drm_encoder_init(). (Chun-Kuang Hu) > - Cleanup the encoder

Re: [RESEND PATCH v4 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-07-04 Thread Chun-Kuang Hu
nkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > Acked-by: Sam Ravnborg > Reviewed-by: Chun-Kuang Hu > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None

Re: [RESEND PATCH v4 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-07-04 Thread Chun-Kuang Hu
gt; Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > Acked-by: Sam Ravnborg > Reviewed-by: Chun-

Re: [RESEND PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-07-04 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年6月16日 週二 上午4:31寫道: > > Use the drm_bridge_connector helper to create a connector for pipelines > that use drm_bridge. This allows splitting connector operations across > multiple bridges when necessary, instead of having the last bridge in > the chain crea

Re: [PATCH v2 8/8] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api

2020-07-06 Thread Chun-Kuang Hu
Hi, Dennis: Dennis YC Hsieh 於 2020年7月6日 週一 下午3:20寫道: > > Add clear parameter to let client decide if > event should be clear to 0 after GCE receive it. > > Fixes: 2f965be7f9008 ("drm/mediatek: apply CMDQ control flow") I think this patch include two things, one is bug fix, another is changing in

Re: [v7, PATCH 1/7] drm/mediatek: move ddp component defint into mtk_mmsys.h

2020-07-23 Thread Chun-Kuang Hu
Yongqiang Niu 於 2020年7月23日 週四 下午6:06寫道: > > On Thu, 2020-07-23 at 11:34 +0200, Enric Balletbo Serra wrote: > > Hi Yongqian Niu, > > > > Thank you for your patch > > > > Missatge de Yongqiang Niu del dia dj., 23 > > de jul. 2020 a les 4:05: > > > > > > move ddp component defint into mtk_mmsys.h >

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-23 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月23日 週四 下午2:11寫道: > > Hi Chun-Kuang, > > On Wed, 2020-07-22 at 22:25 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月22日 週三 上午11:49寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Wed

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-24 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月24日 週五 下午2:55寫道: > > Hi Chun-Kuang, > > On Fri, 2020-07-24 at 00:32 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月23日 週四 下午2:11寫道: > > > > > > Hi Chun-Kuang, > > > > > > On Wed

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-24 Thread Chun-Kuang Hu
Hi Yongqiang: Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > This patch add support for mediatek SOC MT8183 > 1.ovl_2l share driver with ovl I think this is done in [1], [2], [3], this patch just add the support of mt8183-ovl and mt8183-ovl-2l. [1] https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-21 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月21日 週二 下午12:00寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. >

Re: [PATCH v3 2/2] soc: mediatek: add mtk-devapc driver

2020-07-22 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月22日 週三 上午11:49寫道: > > Hi Chun-Kuang, > > On Wed, 2020-07-22 at 07:21 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月21日 週二 下午12:00寫道: > > > > > > > > + > > > +/* > > >

Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver

2020-07-10 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月10日 週五 上午11:23寫道: > > Hi Chun-Kuang, > > Thanks for your review. > > On Thu, 2020-07-09 at 21:01 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月9日 週四 下午5:13寫道: > > > > > > MediaTek b

Re: [RESEND PATCH v2 1/2] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-09-09 Thread Chun-Kuang Hu
will be > named next_bridge. This is a DRM-bridge related patch, how do you think about it? Regards, Chun-Kuang. > > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v2: None > > drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++

Re: [RESEND PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-09-09 Thread Chun-Kuang Hu
. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v2: > - Maintain error message when attach to bridge fails. (Boris) > > drivers/gpu/drm/mediatek/mtk_dpi.c | 71 ++ > 1 file changed, 42 insertions(+

[PATCH] soc: mediatek: cmdq: Remove timeout handler in helper function

2020-09-20 Thread Chun-Kuang Hu
For each client driver, its timeout handler need to dump hardware register or its state machine information, so remove timeout handler in helper function and let client driver implement its own timeout handler. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3

Re: [PATCH] soc: mediatek: cmdq: Remove timeout handler in helper function

2020-09-21 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年9月21日 週一 下午4:53寫道: > > > > On 21/09/2020 01:42, Chun-Kuang Hu wrote: > > For each client driver, its timeout handler need to dump hardware register > > or its state machine information, so remove timeout handler in helper > >

Re: [RESEND PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-09-12 Thread Chun-Kuang Hu
Hi, Daniel Vetter 於 2020年9月10日 週四 下午1:48寫道: > > On Thu, Sep 10, 2020 at 06:35:21AM +0800, Chun-Kuang Hu wrote: > > Hi, Andrzej & Neil: > > > > Enric Balletbo i Serra 於 2020年8月26日 週三 > > 下午4:53寫道: > > > > > > > > Convert mt

Re: [PATCH v6 1/4] drm/mediatek: disable tmds on mt2701

2020-09-14 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年9月4日 週五 下午7:01寫道: > > From: chunhui dai > > Without that patch if you use specific resolutions like 1280x1024, > I can see distortion in the output. It seems as if the > frequency for updating the pixel of the image is out of sync. > > For initialization tmds n

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_ddp_comp_init()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月5日 週六 下午4:31寫道: > > if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have > a corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. > Reviewed-by: Chun-Kuang Hu &

Re: [PATCH] drm/mediatek: add exception handing in mtk_drm_probe() if component init fail

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月9日 週三 下午4:50寫道: > > mtk_ddp_comp_init() is called in a loop in mtk_drm_probe(), if it > fail, previous successive init component is not proccessed. > > Thus uninitialize valid component and put their device if component > init failed. Reviewed

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_drm_kms_init()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月11日 週五 下午7:22寫道: > > if of_find_device_by_node() succeed, mtk_drm_kms_init() doesn't have > a corresponding put_device(). Thus add jump target to fix the exception > handling for this function implementation. Reviewed-by: Chun-Kuang Hu > &

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_hdmi_dt_parse_pdata()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月11日 週五 下午7:22寫道: > > if of_find_device_by_node() succeed, mtk_drm_kms_init() doesn't have > a corresponding put_device(). Thus add jump target to fix the exception > handling for this function implementation. Reviewed-by: Chun-Kuang Hu > &

Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-06-30 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年7月1日 週三 上午5:02寫道: > > Hi Chun-Kuang, > > On 30/6/20 18:26, Chun-Kuang Hu wrote: > > Hi, Enric: > > > > Enric Balletbo i Serra 於 2020年6月30日 週二 > > 下午10:34寫道: > >> > >> Hi Sam, Chun-Kuan, > >

<    1   2   3   4   5   >