Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-12 Thread Cindy Lu
On Wed, Jan 13, 2021 at 11:38 AM Jason Wang wrote: > > > On 2021/1/12 下午1:36, Cindy Lu wrote: > > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > > this cb.private will finally use in vhost_vdpa_config_cb as > > vhost_vdpa. Fix this issue. &

Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-12 Thread Cindy Lu
On Tue, Jan 12, 2021 at 3:53 PM Greg KH wrote: > > On Tue, Jan 12, 2021 at 01:36:29PM +0800, Cindy Lu wrote: > > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > > this cb.private will finally use in vhost_vdpa_config_cb as > > vhost_vdpa. Fix t

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-11-30 Thread Cindy Lu
x5_core) NIC implementation. Instead, use a random > > > > > > generated MAC address. > > > > > > > > > > > > Suggested by: Cindy Lu > > > > > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 >

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-01 Thread Cindy Lu
On Mon, Nov 30, 2020 at 11:33 PM Michael S. Tsirkin wrote: > > On Mon, Nov 30, 2020 at 06:41:45PM +0800, Cindy Lu wrote: > > On Mon, Nov 30, 2020 at 5:33 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote: > > &g

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

2020-12-01 Thread Cindy Lu
On Tue, Dec 1, 2020 at 7:32 PM Michael S. Tsirkin wrote: > > On Tue, Dec 01, 2020 at 05:23:18PM +0800, Cindy Lu wrote: > > On Mon, Nov 30, 2020 at 11:33 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Nov 30, 2020 at 06:41:45PM +0800, Cindy Lu wrote: > >

[PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-26 Thread Cindy Lu
In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. this cb.private will finally use in vhost_vdpa_config_cb as vhost_vdpa. Fix this issue. Cc: sta...@vger.kernel.org Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") Signed-off-by: Cindy Lu --- dri

Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers

2020-05-18 Thread Cindy Lu
Hi ,Jason It works ok in the latest version of qemu vdpa code , So I think the patch is ok. Thanks Cindy On Wed, May 13, 2020 at 3:18 PM Jason Wang wrote: > > > On 2020/5/13 下午12:42, Zhu, Lingshan wrote: > > > > > > On 5/13/2020 12:12 PM, Jason Wang wrote: > >> > >> On 2020/5/12 下午4:00, Zhu

[PATCH v1] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Cindy Lu
in vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. this cb.private will finally use in vhost_vdpa_config_cb as vhost_vdpa.Fix this issue Signed-off-by: Cindy Lu --- drivers/vhost/vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b

[PATCH v2] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Cindy Lu
In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. this cb.private will finally use in vhost_vdpa_config_cb as vhost_vdpa. Fix this issue. Signed-off-by: Cindy Lu --- drivers/vhost/vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b

[PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Cindy Lu
In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. this cb.private will finally use in vhost_vdpa_config_cb as vhost_vdpa. Fix this issue. Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") Acked-by: Jason Wang Signed-off-by: Cindy Lu --- dri

Re: [RFC v1 3/8] vhost: Add 3 new uapi to support iommufd

2023-11-09 Thread Cindy Lu
Jason Wang 于2023年11月10日周五 10:32写道: > > On Wed, Nov 8, 2023 at 3:09 PM Jason Wang wrote: > > > > On Wed, Nov 8, 2023 at 2:39 PM Cindy Lu wrote: > > > > > > On Wed, Nov 8, 2023 at 11:03 AM Jason Wang wrote: > > > > > &

Re: [RFC v1 3/8] vhost: Add 3 new uapi to support iommufd

2023-11-07 Thread Cindy Lu
On Wed, Nov 8, 2023 at 11:03 AM Jason Wang wrote: > > On Tue, Nov 7, 2023 at 2:57 PM Cindy Lu wrote: > > > > On Mon, Nov 6, 2023 at 3:30 PM Jason Wang wrote: > > > > > > On Sat, Nov 4, 2023 at 1:17 AM Cindy Lu wrote: > > > > > > > >

Re: [RFC v1 0/8] vhost-vdpa: add support for iommufd

2024-01-11 Thread Cindy Lu
On Thu, Jan 11, 2024 at 6:25 AM Michael S. Tsirkin wrote: > > On Sat, Nov 04, 2023 at 01:16:33AM +0800, Cindy Lu wrote: > > > > Hi All > > This code provides the iommufd support for vdpa device > > This code fixes the bugs from the last version and also add the asid

Re: [RFC v1 8/8] iommu: expose the function iommu_device_use_default_domain

2023-11-07 Thread Cindy Lu
On Wed, Nov 8, 2023 at 11:04 AM Jason Wang wrote: > > On Tue, Nov 7, 2023 at 2:10 PM Cindy Lu wrote: > > > > On Mon, Nov 6, 2023 at 3:26 PM Jason Wang wrote: > > > > > > On Sat, Nov 4, 2023 at 1:18 AM Cindy Lu wrote: > > > > > > &

[PATCH v2 1/1] virtio-pci: Fix the crash that the vector was used after released.

2024-04-09 Thread Cindy Lu
d731 in kvm_vcpu_thread_fn (arg=0x560642f205e0) at ../accel/kvm/kvm-accel-ops.c:51 21 0x5606411949f4 in qemu_thread_start (args=0x560642f292b0) at ../util/qemu-thread-posix.c:541 22 0x7fc87148cdcd in start_thread (arg=) at pthread_create.c:442 23 0x7fc871512630 in clone3 () at ../sy

Re: [PATCH v2 0/1] virtio-pci: Fix the crash that the vector was used after released

2024-04-09 Thread Cindy Lu
Sorry, send to the wrong mail list, please ignore it On Wed, Apr 10, 2024 at 12:35 PM Cindy Lu wrote: > > During the booting process of the Vyatta image, the behavior of the > called function in qemu is as follows: > > 1. vhost_net_stop() was triggered by guest image .

[PATCH v2 0/1] virtio-pci: Fix the crash that the vector was used after released

2024-04-09 Thread Cindy Lu
et_stop(), So this step will not lost during this process. Change from V1 1.add the check for if using irqfd 2.remove the check for bool recovery, irqfd's user is enough to check status Cindy Lu (1): virtio-pci: Fix the crash that the vector was used after released. hw/v

Re: [PATCH v2 1/1] virtio-pci: Fix the crash that the vector was used after released.

2024-04-09 Thread Cindy Lu
Sorry, send to the wrong mail list, please ignore it On Wed, Apr 10, 2024 at 12:35 PM Cindy Lu wrote: > > When the guest triggers vhost_stop and then virtio_reset, the vector will the > IRQFD for this vector will be released and change to VIRTIO_NO_VECTOR. > After that, the

[PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-12 Thread Cindy Lu
Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_user/vduse_dev.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c index ef3c9681941e..2da659d5f4a8 100644 --- a/drivers/vdpa/vdpa_user

[PATCH v5 1/5] vduse: Add new ioctl VDUSE_DEV_GET_CONFIG

2024-04-12 Thread Cindy Lu
The ioctl VDUSE_DEV_GET_CONFIG is used by the Userspace App to get the device configuration space. Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_user/vduse_dev.c | 21 + include/uapi/linux/vduse.h | 3 +++ 2 files changed, 24 insertions(+) diff --git a/drivers/vdpa

[PATCH v5 2/5] vduse: Add new ioctl VDUSE_DEV_GET_STATUS

2024-04-12 Thread Cindy Lu
The ioctl VDUSE_DEV_GET_STATUS is used by the Userspace App to get the device status Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_user/vduse_dev.c | 7 +++ include/uapi/linux/vduse.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b

[PATCH v5 0/5] vduse: Add support for reconnection

2024-04-12 Thread Cindy Lu
the Documentation for vduse reconnection 2. merge the patch from Dan Carpenter vduse: Fix off by one in vduse_dev_mmap() 3. fix the wrong comment in the code Signed-off-by: Cindy Lu Cindy Lu (5): vduse: Add new ioctl VDUSE_DEV_GET_CONFIG vduse: Add new ioctl VDUSE_DEV_GET_STATUS vduse

[PATCH v5 4/5] vduse: Add file operation for mmap

2024-04-12 Thread Cindy Lu
Add the operation for mmap, This function will be used by the user space application to map the pages to the user space. Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_user/vduse_dev.c | 57 ++ 1 file changed, 57 insertions(+) diff --git a/drivers/vdpa/vdpa_user

[PATCH v5 5/5] Documentation: Add reconnect process for VDUSE

2024-04-12 Thread Cindy Lu
Add a document explaining the reconnect process, including what the Userspace App needs to do and how it works with the kernel. Signed-off-by: Cindy Lu --- Documentation/userspace-api/vduse.rst | 41 +++ 1 file changed, 41 insertions(+) diff --git a/Documentation

Re: [PATCH v5 5/5] Documentation: Add reconnect process for VDUSE

2024-04-17 Thread Cindy Lu
On Tue, Apr 16, 2024 at 11:46 AM Jason Wang wrote: > > On Fri, Apr 12, 2024 at 9:31 PM Cindy Lu wrote: > > > > Add a document explaining the reconnect process, including what the > > Userspace App needs to do and how it works with the kernel. > &g

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-23 Thread Cindy Lu
gt; > > > > > > On Thu, Apr 18, 2024 at 08:57:51AM +0800, Jason Wang wrote: > > > > > On Wed, Apr 17, 2024 at 5:29 PM Michael S. Tsirkin > > > > > wrote: > > > > > > > > > > >

Re: [PATCH v2] Documentation: Add reconnect process for VDUSE

2024-04-03 Thread Cindy Lu
On Fri, Mar 29, 2024 at 5:52 PM Michael S. Tsirkin wrote: > > On Fri, Mar 29, 2024 at 05:38:25PM +0800, Cindy Lu wrote: > > Add a document explaining the reconnect process, including what the > > Userspace App needs to do and how it works with the kernel. > > >

[PATCH v3] Documentation: Add reconnect process for VDUSE

2024-04-03 Thread Cindy Lu
Add a document explaining the reconnect process, including what the Userspace App needs to do and how it works with the kernel. Signed-off-by: Cindy Lu --- Documentation/userspace-api/vduse.rst | 41 +++ 1 file changed, 41 insertions(+) diff --git a/Documentation

Re: [PATCH v3] Documentation: Add reconnect process for VDUSE

2024-04-09 Thread Cindy Lu
On Mon, Apr 8, 2024 at 8:50 PM Michael S. Tsirkin wrote: > > On Mon, Apr 08, 2024 at 08:39:21PM +0800, Cindy Lu wrote: > > On Mon, Apr 8, 2024 at 3:40 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Apr 04, 2024 at 01:56:31PM +0800, Cindy Lu wrote: >

[PATCH v2] Documentation: Add reconnect process for VDUSE

2024-03-29 Thread Cindy Lu
Add a document explaining the reconnect process, including what the Userspace App needs to do and how it works with the kernel. Signed-off-by: Cindy Lu --- Documentation/userspace-api/vduse.rst | 41 +++ 1 file changed, 41 insertions(+) diff --git a/Documentation

Re: [PATCH v3] Documentation: Add reconnect process for VDUSE

2024-04-08 Thread Cindy Lu
On Mon, Apr 8, 2024 at 3:40 PM Michael S. Tsirkin wrote: > > On Thu, Apr 04, 2024 at 01:56:31PM +0800, Cindy Lu wrote: > > Add a document explaining the reconnect process, including what the > > Userspace App needs to do and how it works with the kernel. > > >

Re: [PATCH v3] vduse: Fix off by one in vduse_dev_mmap()

2024-02-28 Thread Cindy Lu
; --- > > v2: add array_index_nospec() > > v3: I accidentally corrupted v2. Try again. > > Thanks for fix this > > drivers/vdpa/vdpa_user/vduse_dev.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > Reviewed-by: Stefan Hajnoczi Reviewed-by: Cindy

[PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-10 Thread Cindy Lu
pa0 mac 00:11:22:33:44:55 root@L1# vdpa -jp dev config show vdpa0 { "config": { "vdpa0": { "mac": "00:11:22:33:44:55", "link ": "up", "link_announce ": false, "mtu&quo

[PATCH 2/2] vdpa_sim_net: Add the support of set mac address

2024-06-10 Thread Cindy Lu
Add the function to support setting the MAC address. For vdpa_sim_net, the driver will write the MAC address to the config space, and other devices can implement their own functions to support this. Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 18 +- 1 file

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-13 Thread Cindy Lu
On Wed, Jun 12, 2024 at 3:12 PM Michael S. Tsirkin wrote: > > On Tue, Jun 11, 2024 at 01:32:32PM +0800, Cindy Lu wrote: > > Add new UAPI to support the mac address from vdpa tool > > The patch does not do what commit log says. > Instead there's an internal API to set mac

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-13 Thread Cindy Lu
On Thu, Jun 13, 2024 at 2:59 PM Michael S. Tsirkin wrote: > > On Tue, Jun 11, 2024 at 01:32:32PM +0800, Cindy Lu wrote: > > Add new UAPI to support the mac address from vdpa tool > > Function vdpa_nl_cmd_dev_config_set_doit() will get the > > MAC address from th