Re: [PATCH] power: reset: at91-reset: enable I-cache for at91sam9260_reset

2018-10-16 Thread Claudiu.Beznea
Hi Jonas, On 07.10.2018 15:57, Jonas Danielsson wrote: > From: Jonas Danielsson > > This fixes a bug where our embedded system (AT91SAM9260 based) would > hang at reboot. At the most we managed 16 boot loops without a hang. > > With this patch applied the problem has not been observed and the

Re: [PATCH] power: reset: at91-reset: enable I-cache for at91sam9260_reset

2018-10-17 Thread Claudiu.Beznea
On 17.10.2018 15:17, Jonas Danielsson wrote: > On Tue, Oct 16, 2018 at 4:52 PM Alexander Stein > wrote: >> >> On Tuesday, October 16, 2018, 3:30:24 PM CEST claudiu.bez...@microchip.com >> wrote: >>> Hi Jonas, >>> >>> On 07.10.2018 15:57, Jonas Danielsson wrote: From: Jonas Danielsson

[PATCH 0/2] add PM functionality for act8945

2018-10-26 Thread Claudiu.Beznea
This series implements PM functionality for act8945 and use that support on sama5d2_xplained board. Boris Brezillon (2): regulator: act8945: Implement PM functionalities ARM: dts: at91: sama5d2_xplained: Add proper regulator states for suspend-to-mem

[PATCH 1/2] regulator: act8945: Implement PM functionalities

2018-10-26 Thread Claudiu.Beznea
From: Boris Brezillon The regulator supports a dedicated suspend mode. Implement the appropriate ->set_suspend_xx() hooks, add support for ->set_mode(), and provide basic PM ops functionalities to setup the regulator in a suspend state when the system is entering suspend. We also implement the

[PATCH 2/2] ARM: dts: at91: sama5d2_xplained: Add proper regulator states for suspend-to-mem

2018-10-26 Thread Claudiu.Beznea
From: Boris Brezillon When entering suspend-to-mem, all PMIC outputs are disabled except VDDIODDR which is put in power saving mode, and whose voltage is increased (probably to counter the poor accuracy of power saving mode). Signed-off-by: Boris Brezillon [claudiu.bez...@microchip.com: use

[PATCH 3/4] power: reset: at91-poweroff: check shdwc data structure at the beginning of probe

2018-11-05 Thread Claudiu.Beznea
Check at91_shdwc before continuing with probe since we want only one instance of this driver. Inspired from commit 9f1e44774be5 ("power: reset: at91-poweroff: do not procede if at91_shdwc is allocated"). Signed-off-by: Claudiu Beznea --- drivers/power/reset/at91-poweroff.c | 3 +++ 1 file

[PATCH 2/4] power: reset: at91-poweroff: move shdwc related data to one structure

2018-11-05 Thread Claudiu.Beznea
Move SHDWC realted data to only one structure to have them grouped. Inspired from commit 9be74f0d39c1 ("power: reset: at91-poweroff: make mpddrc_base part of struct shdwc"). Signed-off-by: Claudiu Beznea --- drivers/power/reset/at91-poweroff.c | 60 +++-- 1 file

[PATCH 1/4] power: reset: at91-poweroff: use one poweroff function for at91-poweroff

2018-11-05 Thread Claudiu.Beznea
Use only one poweroff function and adapt it to work for both scenarios (with LPDDR or not). The assignement of pm_power_off was moved at the end of probe after all initializations are OK. This patch adapt the idea from commit 4e018c1e9b05 ("power: reset: at91-poweroff: use only one poweroff

[PATCH 0/4] power: reset: at91-poweroff: cleanups

2018-11-05 Thread Claudiu.Beznea
Hi, This series includes cleanups for at91-poweroff.c similar to the one did for SAMA5D2 Xplained SHDWC on series at [1]. Changes were tested on SAMA5D3 Xplained, SAMA5D4 Xplained and AT91SAM9G35-EK boards. Thank you, Claudiu Beznea [1] https://www.spinics.net/lists/arm-kernel/msg673559.html

[PATCH 4/4] power: reset: at91-poweroff: remove at91_ramc_of_match

2018-11-05 Thread Claudiu.Beznea
Remove at91_ramc_of_match[] since it is not used anywhere in this code. Signed-off-by: Claudiu Beznea --- drivers/power/reset/at91-poweroff.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c index

Re: [PATCH] power: reset: at91-reset: enable I-cache for at91sam9260_reset

2018-10-26 Thread Claudiu.Beznea
On 19.10.2018 13:30, Jonas Danielsson wrote: > On Wed, Oct 17, 2018 at 3:10 PM wrote: >> >>> >>> We take the normal path of sys_reboot => kernel_restart => machine_restart >>> ... >>> >>> I added code to print the c1 register in different paths. And I-cache >>> is enabled. >>> So now I am

Re: [PATCH 2/4] power: reset: at91-poweroff: move shdwc related data to one structure

2018-11-07 Thread Claudiu.Beznea
Hi Alexandre, On 06.11.2018 23:09, Alexandre Belloni wrote: > Hi Claudiu, > > On 05/11/2018 11:14:26+, claudiu.bez...@microchip.com wrote: >> static int __init at91_poweroff_probe(struct platform_device *pdev) >> @@ -154,16 +160,22 @@ static int __init at91_poweroff_probe(struct >>

Re: [PATCH 1/2] regulator: act8945: Implement PM functionalities

2018-11-07 Thread Claudiu.Beznea
On 07.11.2018 16:53, Mark Brown wrote: > On Fri, Oct 26, 2018 at 04:19:48PM +, claudiu.bez...@microchip.com wrote: > >> +static unsigned int act8945a_of_map_mode(unsigned int mode) >> +{ >> +if (mode == ACT8945A_DCDC_MODE_POWER_SAVING) >> +return REGULATOR_MODE_STANDBY; >>

Re: [PATCH 2/4] power: reset: at91-poweroff: move shdwc related data to one structure

2018-12-06 Thread Claudiu.Beznea
Hi Sebastian, On 06.12.2018 00:40, Sebastian Reichel wrote: > Hi, > > On Wed, Nov 07, 2018 at 06:23:40PM +0100, Alexandre Belloni wrote: >> On 07/11/2018 14:54:17+, claudiu.bez...@microchip.com wrote: >>> Hi Alexandre, >>> >>> On 06.11.2018 23:09, Alexandre Belloni wrote: Hi Claudiu,

Re: [RFC PATCH] net: macb: Apply RXUBR workaround only to versions with errata

2018-11-29 Thread Claudiu.Beznea
On 28.11.2018 23:09, Brandon Streiff wrote: > On 11/23/2018 3:59 AM, Harini Katakam wrote: >> +/* Errata mask bits */ >> +#define MACB_ERRATA_RXLOCKUP0x0001 >> + >> /* LSO settings */ >> #define MACB_LSO_UFO_ENABLE 0x01 >> #define

[PATCH v2] power: reset: at91-poweroff: move shdwc related data to one structure

2018-12-06 Thread Claudiu.Beznea
From: Claudiu Beznea Move SHDWC realted data to only one structure to have them grouped. Inspired from commit 9be74f0d39c1 ("power: reset: at91-poweroff: make mpddrc_base part of struct shdwc"). Signed-off-by: Claudiu Beznea --- Changes in v2: - avoid allocate at91_shdwc and keep it static

[PATCH v2 1/5] regulator: act8945a-regulator: Implement PM functionalities

2018-11-27 Thread Claudiu.Beznea
From: Boris Brezillon The regulator supports a dedicated suspend mode. Implement the appropriate ->set_suspend_xx() hooks, add support for ->set_mode(), and provide basic PM ops functionalities to setup the regulator in a suspend state when the system is entering suspend. Signed-off-by: Boris

[PATCH v2 3/5] regulator: act8945a-regulator: add shutdown function

2018-11-27 Thread Claudiu.Beznea
From: Claudiu Beznea Implement shutdown method to make sure the PMIC will not enter the suspend state when the system is shutdown. This work is based on work done by Borris Brezillon on [1]. [1] https://www.spinics.net/lists/kernel/msg2942960.html Signed-off-by: Claudiu Beznea ---

[PATCH v2 4/5] ARM: dts: at91: sama5d2_xplained: Add proper regulator states for suspend-to-mem

2018-11-27 Thread Claudiu.Beznea
From: Boris Brezillon When entering suspend-to-mem, all PMIC outputs are disabled except VDDIODDR which is put in power saving mode, and whose voltage is increased (probably to counter the poor accuracy of power saving mode). Signed-off-by: Boris Brezillon [claudiu.bez...@microchip.com: use

[PATCH v2 0/5] add PM functionality for act8945a PMIC

2018-11-27 Thread Claudiu.Beznea
From: Claudiu Beznea This series implements PM functionality for act8945a PMIC and use that support on SAMA5D2 Xplained board. Changes in v2: - split patch 1/1 from previous series in 3 patches: one adding regmap, one adding pm functionality, one adding shutdown functionality - use dev_pm_ops

[PATCH v2 2/5] regulator: act8945a-regulator: fix line over 80 chars warning

2018-11-27 Thread Claudiu.Beznea
From: Claudiu Beznea Fix line over 80 chars checkpatch.pl warning. Signed-off-by: Claudiu Beznea --- drivers/regulator/act8945a-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c

[PATCH v2 5/5] regulator: add documentation for regulator modes and suspend states

2018-11-27 Thread Claudiu.Beznea
From: Claudiu Beznea Add documentation for regulator modes and suspend states. Signed-off-by: Claudiu Beznea --- .../bindings/regulator/act8945a-regulator.txt | 34 ++ 1 file changed, 34 insertions(+) diff --git

Re: [PATCH] net: macb: ignore tx_clk if MII is used

2021-01-21 Thread Claudiu.Beznea
Hi Michael, On 20.01.2021 21:43, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > If the MII interface is used, the PHY is the clock master, thus don't > set the clock rate. On Zynq-7000, this will prevent the following >

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-14 Thread Claudiu.Beznea
On 14.01.2021 12:25, Russell King - ARM Linux admin wrote: > > As I've said, if phylib/PHY driver is not restoring the state of the > PHY on resume from suspend-to-ram, then that's an issue with phylib > and/or the phy driver. In the patch I proposed in this thread the restoring is done in PHY

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-14 Thread Claudiu.Beznea
Hi, Rafael, Pavel, I recently posted a patch for re-configuring an ethernet PHY on its .resume() callback as this PHY is in a setup with SAMA7G5 SoC that supports a power saving mode (called backup). In this power saving mode most of the SoC devices' power is cut of (except the RAM + its

Re: [PATCH] net: macb: ignore tx_clk if MII is used

2021-01-22 Thread Claudiu.Beznea
On 21.01.2021 11:41, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Claudiu, > > Am 2021-01-21 10:19, schrieb claudiu.bez...@microchip.com: >> On 20.01.2021 21:43, Michael Walle wrote: >>> EXTERNAL EMAIL: Do not click

Re: [PATCH] net: macb: ignore tx_clk if MII is used

2021-01-22 Thread Claudiu.Beznea
On 22.01.2021 13:20, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Am 2021-01-22 10:10, schrieb claudiu.bez...@microchip.com: >> On 21.01.2021 11:41, Michael Walle wrote: >>> EXTERNAL EMAIL: Do not click links or open

Re: [PATCH v2 2/3] ARM: at91: pm: add per soc validation of pm modes

2020-08-04 Thread Claudiu.Beznea
On 04.08.2020 14:42, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hello, > > On 04/08/2020 14:07:37+0300, Claudiu Beznea wrote: >> void __init at91rm9200_pm_init(void) >> { >> + static const int modes[]

Re: [PATCH v2 2/3] ARM: at91: pm: add per soc validation of pm modes

2020-08-04 Thread Claudiu.Beznea
On 04.08.2020 18:08, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 04/08/2020 15:00:38+, claudiu.bez...@microchip.com wrote: >> >> >> On 04.08.2020 14:42, Alexandre Belloni wrote: >>> EXTERNAL EMAIL: Do not

Re: [PATCH] ARM: at91: pm: remove unnecessary at91sam9x60_idle

2020-08-05 Thread Claudiu.Beznea
On 04.08.2020 14:56, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > cpu_do_idle() is already the default action for arm_pm_idle, there is no > need to open code it. > > Signed-off-by: Alexandre Belloni Reviewed-by:

Re: [PATCH 2/3] ARM: at91: pm: add per soc validation of pm modes

2020-08-03 Thread Claudiu.Beznea
On 03.08.2020 11:34, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 03/08/2020 10:25:16+0300, Claudiu Beznea wrote: >> Not all SoCs supports all the PM mode. User may end up settings, >> e.g. backup mode, on a non

Re: [PATCH v3 2/2] ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller

2020-08-03 Thread Claudiu.Beznea
On 03.08.2020 11:18, Codrin Ciubotariu wrote: > The new SPDIF TX controller is a serial port compliant with the IEC- > 60958 standard. It also supports programmable User Data and Channel > Status fields. > > This IP is embedded in Microchip's sama7g5 SoC. > > Signed-off-by: Codrin Ciubotariu

Re: [PATCH v3 2/2] ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller

2020-08-03 Thread Claudiu.Beznea
On 03.08.2020 19:11, Codrin Ciubotariu - M19940 wrote: > On 03.08.2020 16:06, Claudiu Beznea - M18063 wrote: >> >> >> On 03.08.2020 11:18, Codrin Ciubotariu wrote: >>> The new SPDIF TX controller is a serial port compliant with the IEC- >>> 60958 standard. It also supports programmable User Data

Re: [PATCH v3 2/2] ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller

2020-08-03 Thread Claudiu.Beznea
On 03.08.2020 19:11, Codrin Ciubotariu - M19940 wrote: > On 03.08.2020 16:06, Claudiu Beznea - M18063 wrote: >> >> >> On 03.08.2020 11:18, Codrin Ciubotariu wrote: >>> The new SPDIF TX controller is a serial port compliant with the IEC- >>> 60958 standard. It also supports programmable User Data

Re: [PATCH net v3] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Claudiu.Beznea
Hi Charles, On 04.01.2021 12:38, Charles Keepax wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > macb_set_tx_clk were gated on the presence of this flag. > > - if (!clk) >

Re: [PATCH 2/3] cpufreq: sama7g5: add cpufreq driver

2021-01-05 Thread Claudiu.Beznea
On 05.01.2021 12:44, Viresh Kumar wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 05-01-21, 12:22, Claudiu Beznea wrote: >> Microchip SAMA7G5 devices supports runtime changes of CPU frequency. >> This is doable by changing CPUPLL

Re: [PATCH 3/3] power: reset: at91-sama5d2_shdwc: add support for sama7g5

2020-12-16 Thread Claudiu.Beznea
On 16.12.2020 15:45, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 16/12/2020 14:57:33+0200, Claudiu Beznea wrote: >> Add support for SAMA7G5 by adding proper struct reg_config structure >> and since SAMA7G5 is

Re: [PATCH 3/3] power: reset: at91-sama5d2_shdwc: add support for sama7g5

2020-12-16 Thread Claudiu.Beznea
On 16.12.2020 15:45, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 16/12/2020 14:57:33+0200, Claudiu Beznea wrote: >> Add support for SAMA7G5 by adding proper struct reg_config structure >> and since SAMA7G5 is

Re: [PATCH v4 06/11] clk: at91: clk-sam9x60-pll: allow runtime changes for pll

2020-11-18 Thread Claudiu.Beznea
On 18.11.2020 03:49, Stephen Boyd wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Quoting claudiu.bez...@microchip.com (2020-11-16 03:24:54) >> >> >> On 14.11.2020 23:14, Stephen Boyd wrote: >>> EXTERNAL EMAIL: Do not click links or

Re: [PATCH v4 06/11] clk: at91: clk-sam9x60-pll: allow runtime changes for pll

2020-11-16 Thread Claudiu.Beznea
On 14.11.2020 23:14, Stephen Boyd wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Quoting Claudiu Beznea (2020-11-06 01:46:23) >> diff --git a/drivers/clk/at91/clk-sam9x60-pll.c >> b/drivers/clk/at91/clk-sam9x60-pll.c >> index

Re: [PATCH v3 1/6] regulator: core: validate selector against linear_min_sel

2020-11-24 Thread Claudiu.Beznea
Hi Jon, On 24.11.2020 11:36, Jon Hunter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 13/11/2020 15:21, Claudiu Beznea wrote: >> There are regulators who's min selector is not zero. Selectors loops >> (looping b/w zero and

Re: [PATCH] clk: at91: sam9x60: remove atmel,osc-bypass support

2020-12-02 Thread Claudiu.Beznea
On 02.12.2020 14:58, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > The sam9x60 doesn't have the MOSCXTBY bit to enable the crystal oscillator > bypass. > > Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver") >

Re: [PATCH v6 00/11] clk: at91: clk-master: re-factor master clock

2020-11-27 Thread Claudiu.Beznea
I have just noticed that the title of this cover letter is wrong. It should have been: "clk: at91: adapt for dvfs" Please let me know if you want me to send a new version for this update. Thank you, Claudiu On 19.11.2020 17:43, Claudiu Beznea wrote: > Hi, > > SAMA7G5 is capable of DVFS. The

Re: [PATCH v3 1/6] regulator: core: validate selector against linear_min_sel

2020-11-25 Thread Claudiu.Beznea
On 24.11.2020 15:41, Jon Hunter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 24/11/2020 11:14, claudiu.bez...@microchip.com wrote: > > ... > >> I would say that a solution would be to have a new helper to retrieve the >>

Re: [PATCH v6 5/7] nfc: pn533: add UART phy driver

2019-08-26 Thread Claudiu.Beznea
Hi Lars, On 23.08.2019 13:06, Lars Poeschel wrote: > External E-Mail > > > On Thu, Aug 22, 2019 at 10:09:09AM +, claudiu.bez...@microchip.com wrote: >> Hi Lars, >> >> On 20.08.2019 15:03, Lars Poeschel wrote: >>> This adds the UART phy interface for the pn533 driver. >>> The pn533 driver

[PATCH 2/7] clk: at91: sckc: add support to free slow rc oscillator

2019-06-13 Thread Claudiu.Beznea
From: Claudiu Beznea Add support to free slow rc oscillator resources. Signed-off-by: Claudiu Beznea --- drivers/clk/at91/sckc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c index c1d7edd33416..492b139a7c15 100644 ---

[PATCH 3/7] clk: at91: sckc: add support to free slow clock osclillator

2019-06-13 Thread Claudiu.Beznea
From: Claudiu Beznea Add support to free slow clock oscillator resources. Signed-off-by: Claudiu Beznea --- drivers/clk/at91/sckc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c index 492b139a7c15..2a677c56f901 100644 ---

[PATCH 6/7] clk: at91: sckc: improve error path for sama5d4 sck registration

2019-06-13 Thread Claudiu.Beznea
From: Claudiu Beznea Improve error path for sama5d4 sck registration. Signed-off-by: Claudiu Beznea --- drivers/clk/at91/sckc.c | 43 --- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c

[PATCH 4/7] clk: at91: sckc: improve error path for sam9x5 sck register

2019-06-13 Thread Claudiu.Beznea
From: Claudiu Beznea Improve error path for sam9x5 slow clock registration. Signed-off-by: Claudiu Beznea --- drivers/clk/at91/sckc.c | 50 +++-- 1 file changed, 32 insertions(+), 18 deletions(-) diff --git a/drivers/clk/at91/sckc.c

[PATCH 1/7] clk: at91: sckc: add support to free slow oscillator

2019-06-13 Thread Claudiu.Beznea
From: Claudiu Beznea Add support to free slow oscillator resources. Signed-off-by: Claudiu Beznea --- drivers/clk/at91/sckc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c index 2c410f41b413..c1d7edd33416 100644 ---

[PATCH 5/7] clk: at91: sckc: remove unnecessary line

2019-06-13 Thread Claudiu.Beznea
From: Claudiu Beznea Remove unnecessary line. Signed-off-by: Claudiu Beznea --- drivers/clk/at91/sckc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c index a2b905c91085..c61b6c9ddb94 100644 --- a/drivers/clk/at91/sckc.c +++

[PATCH 0/7] clk: at91: sckc: improve error path

2019-06-13 Thread Claudiu.Beznea
From: Claudiu Beznea Hi, This series tries to improve error path for slow clock registrations by adding functions to free resources and using them on failures. It is created on top of patch series at [1]. Thank you, Claudiu Beznea [1]

[PATCH 7/7] clk: at91: sckc: use dedicated functions to unregister clock

2019-06-13 Thread Claudiu.Beznea
From: Claudiu Beznea Use at91 specific functions to free all resources in case of error. Signed-off-by: Claudiu Beznea --- drivers/clk/at91/sckc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c index

Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_sdio_probe

2020-08-25 Thread Claudiu.Beznea
On 20.08.2020 08:48, Dinghao Liu wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > When devm_clk_get() returns -EPROBE_DEFER, sdio_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 8692b047e86cf ("staging:

Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_bus_probe

2020-08-25 Thread Claudiu.Beznea
Hi Dinghao, On 20.08.2020 08:52, Dinghao Liu wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > When devm_clk_get() returns -EPROBE_DEFER, spi_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 854d66df74aed

Re: [PATCH v2 0/8] clk: at91: adapt for dvfs

2020-11-05 Thread Claudiu.Beznea
Hi, Please ignore this series for the moment as I will have to run few more tests on it. Sorry for the noise! Thank you, Claudiu Beznea On 04.11.2020 19:45, Claudiu Beznea wrote: > Hi, > > SAMA7G5 is capable of DVFS. The supported CPU clock frequencies could be > obtained from CPU PLL. The

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Claudiu.Beznea
On 13.01.2021 13:09, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 13.01.2021 10:29, claudiu.bez...@microchip.com wrote: >> Hi Heiner, >> >> On 08.01.2021 18:31, Heiner Kallweit wrote: >>> EXTERNAL EMAIL: Do not

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Claudiu.Beznea
Hi Heiner, On 08.01.2021 18:31, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 08.01.2021 16:45, Claudiu Beznea wrote: >> KSZ9131 is used in setups with SAMA7G5. SAMA7G5 supports a special >> power saving mode (backup

Re: [PATCH v2] pwm: atmel: Remove platform_device_id and use only dt bindings

2019-09-19 Thread Claudiu.Beznea
On 18.09.2019 17:57, Kamel Bouhara wrote: > Since commit 26202873bb51 ("avr32: remove support for AVR32 > architecture") there is no more user of platform_device_id and we > should only use dt bindings > > Signed-off-by: Kamel Bouhara Acked-by: Claudiu Beznea > --- > Changelog: > v1->v2 >

Re: [PATCH v3 2/4] clk: at91: sckc: add support to specify registers bit offsets

2019-05-20 Thread Claudiu.Beznea
On 18.05.2019 00:13, Alexandre Belloni wrote: > External E-Mail > > > On 16/05/2019 08:10:34+, claudiu.bez...@microchip.com wrote: @@ -69,10 +80,11 @@ static int clk_slow_osc_prepare(struct clk_hw *hw) void __iomem *sckcr = osc->sckcr; u32 tmp = readl(sckcr);

[PATCH v4 3/4] dt-bindings: clk: at91: add bindings for SAM9X60's slow clock controller

2019-05-21 Thread Claudiu.Beznea
From: Claudiu Beznea Add bindings for SAM9X60's slow clock controller. Signed-off-by: Claudiu Beznea Reviewed-by: Alexandre Belloni Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/clock/at91-clock.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v4 2/4] clk: at91: sckc: add support to specify registers bit offsets

2019-05-21 Thread Claudiu.Beznea
From: Claudiu Beznea Different IPs uses different bit offsets in registers for the same functionality, thus adapt the driver to support this. Signed-off-by: Claudiu Beznea --- drivers/clk/at91/sckc.c | 93 - 1 file changed, 61 insertions(+), 32

[PATCH v4 1/4] clk: at91: sckc: sama5d4 has no bypass support

2019-05-21 Thread Claudiu.Beznea
From: Claudiu Beznea The slow clock of SAMA5D4 has no bypass support thus remove it. Signed-off-by: Claudiu Beznea Acked-by: Alexandre Belloni --- drivers/clk/at91/sckc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c index

[PATCH v4 0/4] add slow clock support for SAM9X60

2019-05-21 Thread Claudiu.Beznea
From: Claudiu Beznea Hi, This series add slow clock support for SAM9X60. Apart from previous IPs, this one uses different offsets in control register for different functionalities. The series adapt current driver to work for all IPs using per IP configurations initialized at probe. Thank you,

[PATCH v4 4/4] clk: at91: sckc: add support for SAM9X60

2019-05-21 Thread Claudiu.Beznea
From: Claudiu Beznea Add support for SAM9X60's slow clock. Signed-off-by: Claudiu Beznea Acked-by: Alexandre Belloni --- drivers/clk/at91/sckc.c | 74 + 1 file changed, 74 insertions(+) diff --git a/drivers/clk/at91/sckc.c

[PATCH] net: macb: save/restore the remaining registers and features

2019-05-22 Thread Claudiu.Beznea
From: Claudiu Beznea SAMA5D2 SoC has a suspend mode where SoC's power is cut off. Due to this the registers content is lost after a suspend/resume cycle. The current suspend/resume implementation covers some of these registers. However there are few which were not treated (e.g. SCRT2 and USRIO).

Re: [PATCH 2/5] clocksource/drivers/timer-microchip-pit64b: add Microchip PIT64B support

2019-05-30 Thread Claudiu.Beznea
Hi Daniel, Taking into account the discussion on this tread and the fact that we have no answer from Rob on this topic (I'm talking about [1]), what do you think it would be best for this driver to be accepted the soonest? Would it be OK for you to mimic the approach done by:

Re: [PATCH 0/7] add support for clocksource/clockevent DT selection

2019-09-26 Thread Claudiu.Beznea
On 25.09.2019 20:19, Daniel Lezcano wrote: > External E-Mail > > > Hi Claudiu, > > On 10/09/2019 15:47, Claudiu Beznea wrote: >> Hi, >> >> This series adds support to permit the selection of clocksource/clockevent >> via DT. > > Thanks for the proposal and taking care of making some progress

Re: [PATCH] i2c: at91: Send bus clear command if SCL or SDA is down

2019-09-15 Thread Claudiu.Beznea
On 11.09.2019 12:58, Codrin Ciubotariu wrote: > External E-Mail > > > After a transfer timeout, some faulty I2C slave devices might hold down > the SCL or the SDA pins. We can generate a bus clear command, hoping that > the slave might release the pins. > > Signed-off-by: Codrin Ciubotariu

Re: [PATCH 0/7] add support for clocksource/clockevent DT selection

2019-10-02 Thread Claudiu.Beznea
Hi Daniel, Taking into account that Rob doesn't agree with the solution proposed in this series do you think there is a chance to merge this driver as is? If you have other suggestion I am open to try it. Thank you, Claudiu Beznea On 26.09.2019 11:42, Claudiu Beznea wrote: > > > On

Re: [PATCH 0/7] add support for clocksource/clockevent DT selection

2019-10-03 Thread Claudiu.Beznea
On 02.10.2019 16:35, Claudiu Beznea wrote: > Hi Daniel, > > Taking into account that Rob doesn't agree with the solution proposed in > this series do you think there is a chance to merge this driver as is? Sorry, I was talking here about the driver at [1]. [1]

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-04 Thread Claudiu.Beznea
Hi Kamel, On 02.10.2019 17:46, Kamel Bouhara wrote: > +static int at91_init_twi_recovery_info(struct platform_device *pdev, > +struct at91_twi_dev *dev) > +{ > + struct i2c_bus_recovery_info *rinfo = >rinfo; > + > + dev->pinctrl =

Re: [PATCH v6 4/7] nfc: pn533: Split pn533 init & nfc_register

2019-08-22 Thread Claudiu.Beznea
On 20.08.2019 15:03, Lars Poeschel wrote: > There is a problem in the initialisation and setup of the pn533: It > registers with nfc too early. It could happen, that it finished > registering with nfc and someone starts using it. But setup of the pn533 > is not yet finished. Bad or at least

Re: [PATCH v6 5/7] nfc: pn533: add UART phy driver

2019-08-22 Thread Claudiu.Beznea
Hi Lars, On 20.08.2019 15:03, Lars Poeschel wrote: > This adds the UART phy interface for the pn533 driver. > The pn533 driver can be used through UART interface this way. > It is implemented as a serdev device. > > Cc: Johan Hovold > Signed-off-by: Lars Poeschel > --- > Changes in v6: > -

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-07 Thread Claudiu.Beznea
On 04.10.2019 23:39, Uwe Kleine-König wrote: > External E-Mail > > > On Fri, Oct 04, 2019 at 09:35:23AM +, claudiu.bez...@microchip.com wrote: >> Hi Kamel, >> >> On 02.10.2019 17:46, Kamel Bouhara wrote: >>> +static int at91_init_twi_recovery_info(struct platform_device *pdev, >>> +

Re: [PATCH] clk: at91: add compatible for sam9x60

2019-10-09 Thread Claudiu.Beznea
Hi, On 08.10.2019 19:54, Alexandre Belloni wrote: > Hi, > > On 08/10/2019 19:46:26+0300, Claudiu Beznea wrote: >> Add compatible for SAM9X60's PMC. > > I think the commit log could be clearer and mention why this is needed > and the compatible string in sam9x60 is not sufficient. I had issues

Re: [PATCH 0/7] add support for clocksource/clockevent DT selection

2019-10-15 Thread Claudiu.Beznea
Hi Daniel, On 13.10.2019 21:16, Daniel Lezcano wrote: > Hi Claudiu, > > sorry for the delay, I was OoO again. No problem, thank you for your reply. > > On 03/10/2019 12:43, claudiu.bez...@microchip.com wrote: >> >> >> On 02.10.2019 16:35, Claudiu Beznea wrote: >>> Hi Daniel, >>> >>> Taking

Re: [PATCH] pinctrl: at91-pio4: implement .get_multiple and .set_multiple

2019-09-05 Thread Claudiu.Beznea
On 05.09.2019 17:13, Alexandre Belloni wrote: > + pr_err("ABE: %d %08x\n", bank, bits[word]); Is this needed?

Re: [PATCH] net: macb: free resources on failure path of at91ether_open()

2020-06-24 Thread Claudiu.Beznea
Please ignore this one! I'll send a v2. On 24.06.2020 10:26, Claudiu Beznea wrote: > DMA buffers were not freed on failure path of at91ether_open(). > Along with changes for freeing the DMA buffers the enable/disable > interrupt instructions were moved to at91ether_start()/at91ether_stop() >

Re: [PATCH 09/19] clk: at91: sckc: register slow_rc with accuracy option

2020-07-15 Thread Claudiu.Beznea
On 15.07.2020 14:24, Claudiu Beznea wrote: > Register slow rc with accuracy option. > > Fixes: 04bcc4275e601 ("clk: at91: sckc: add support for SAM9X60") > Signed-off-by: Claudiu Beznea > --- > drivers/clk/at91/sckc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 07/19] clk: at91: sam9x60-pll: use frac when setting frequency

2020-07-20 Thread Claudiu.Beznea
On 17.07.2020 12:12, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 15/07/2020 14:24:15+0300, Claudiu Beznea wrote: >> In commit a436c2a447e59 ("clk: at91: add sam9x60 PLL driver") >> the fractional part of PLL

Re: [PATCH 10/19] clk: at91: replace conditional operator with double logical not

2020-07-20 Thread Claudiu.Beznea
On 17.07.2020 18:07, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi, > > On 15/07/2020 14:24:18+0300, Claudiu Beznea wrote: >> Replace conditional operator with double logical not. > > I think you need to

Re: [PATCH v3 1/6] usb: gadget: udc: atmel: use of_find_matching_node_and_match

2020-07-23 Thread Claudiu.Beznea
On 22.07.2020 17:43, claudiu.bez...@microchip.com wrote: > > > On 22.07.2020 16:44, cristian.bir...@microchip.com wrote: >> From: Claudiu Beznea >> >> Instead of trying to match every possible compatible use >> of_find_matching_node_and_match() and pass the compatible array. >> >>

Re: [PATCH net-next v2 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-24 Thread Claudiu.Beznea
On 23.07.2020 21:59, Florian Fainelli wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 7/21/20 10:13 AM, Codrin Ciubotariu wrote: >> The MACB embeds an MDIO bus controller. For this reason, the PHY nodes >> were represented as

Re: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB

2020-07-22 Thread Claudiu.Beznea
On 21.07.2020 20:13, Codrin Ciubotariu wrote: > Adding the PHY nodes directly under the Ethernet node became deprecated, > so the aim of this patch series is to make MACB use an MDIO node as > container for MDIO devices. > This patch series starts with a small patch to use the device-managed >

Re: [PATCH v3 1/6] usb: gadget: udc: atmel: use of_find_matching_node_and_match

2020-07-22 Thread Claudiu.Beznea
On 22.07.2020 16:44, cristian.bir...@microchip.com wrote: > From: Claudiu Beznea > > Instead of trying to match every possible compatible use > of_find_matching_node_and_match() and pass the compatible array. > > Signed-off-by: Claudiu Beznea > --- > drivers/usb/gadget/udc/atmel_usba_udc.c

Re: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB

2020-07-23 Thread Claudiu.Beznea
On 22.07.2020 14:38, Codrin Ciubotariu - M19940 wrote: > On 22.07.2020 13:32, Claudiu Beznea - M18063 wrote: >> >> >> On 21.07.2020 20:13, Codrin Ciubotariu wrote: >>> Adding the PHY nodes directly under the Ethernet node became deprecated, >>> so the aim of this patch series is to make MACB use

Re: [PATCH 2/5] clocksource/drivers/timer-microchip-pit64b: add Microchip PIT64B support

2019-06-21 Thread Claudiu.Beznea
Hi Daniel, On 20.06.2019 11:53, Daniel Lezcano wrote: > Hi Claudiu, > > sorry for the late reply. No problem, I understand. > > > On 13/06/2019 16:12, claudiu.bez...@microchip.com wrote: >> Hi Daniel, >> >> On 31.05.2019 13:41, Daniel Lezcano wrote: >>> >>> Hi Claudiu, >>> >>> >>> On

Re: [PATCH v4 4/4] clk: at91: sckc: add support for SAM9X60

2019-06-27 Thread Claudiu.Beznea
On 26.06.2019 21:36, Stephen Boyd wrote: > Quoting claudiu.bez...@microchip.com (2019-05-21 03:11:33) >> From: Claudiu Beznea >> >> Add support for SAM9X60's slow clock. >> >> Signed-off-by: Claudiu Beznea >> Acked-by: Alexandre Belloni >> --- > > FYI, this patch is base64 encoded and causes

Re: [PATCH 0/7] clk: at91: sckc: improve error path

2019-06-27 Thread Claudiu.Beznea
On 27.06.2019 18:03, Stephen Boyd wrote: > External E-Mail > > > Quoting claudiu.bez...@microchip.com (2019-06-13 08:37:06) >> From: Claudiu Beznea >> >> Hi, >> >> This series tries to improve error path for slow clock registrations >> by adding functions to free resources and using them on

[PATCH] pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM

2019-06-05 Thread Claudiu.Beznea
From: Claudiu Beznea Add compatible string for SAM9X60 HLCDC's PWM. Signed-off-by: Claudiu Beznea Acked-by: Thierry Reding --- Hi Thierry, This patch was initially part of series at [1]. The rest of the patches in that series were taken though drm-misc-next. Only this one remained. [1]

Re: Re: [PATCH 2/5] clocksource/drivers/timer-microchip-pit64b: add Microchip PIT64B support

2019-06-13 Thread Claudiu.Beznea
Hi Daniel, On 31.05.2019 13:41, Daniel Lezcano wrote: > > Hi Claudiu, > > > On 30/05/2019 09:46, claudiu.bez...@microchip.com wrote: >> Hi Daniel, >> >> Taking into account the discussion on this tread and the fact that we have >> no answer from Rob on this topic (I'm talking about [1]), what

Re: [PATCH 0/7] clk: at91: sckc: improve error path

2019-06-20 Thread Claudiu.Beznea
Hi, On 18.06.2019 12:55, Alexandre Belloni wrote: > On 13/06/2019 15:37:06+, claudiu.bez...@microchip.com wrote: >> From: Claudiu Beznea >> >> Hi, >> >> This series tries to improve error path for slow clock registrations >> by adding functions to free resources and using them on failures.

Re: [PATCH 0/7] add support for clocksource/clockevent DT selection

2019-10-21 Thread Claudiu.Beznea
Hi Daniel, On 18.10.2019 23:24, Daniel Lezcano wrote: > Hi Claudiu, > > On 15/10/2019 11:23, claudiu.bez...@microchip.com wrote: > > [ ... ] > >> The timer clock source could be divided by MR.PRES + 1. >> >> So, I used the clock-frequency DT binding to let user choose the timer's >> frequency.

Re: [PATCH v6 1/2] net: macb: WoL support for GEM type of Ethernet controller

2020-07-13 Thread Claudiu.Beznea
Hi Nicolas, On 13.07.2020 13:05, nicolas.fe...@microchip.com wrote: > From: Nicolas Ferre > > Adapt the Wake-on-Lan feature to the Cadence GEM Ethernet controller. > This controller has different register layout and cannot be handled by > previous code. > We disable completely interrupts on

Re: [PATCH] of: of_mdio: count number of regitered phys

2020-07-01 Thread Claudiu.Beznea
Hi Andrew, Florian, On 30.06.2020 06:35, Florian Fainelli wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 6/29/2020 5:45 PM, Andrew Lunn wrote: >> On Mon, Jun 29, 2020 at 10:26:36AM +0300, Claudiu Beznea wrote: >>> In case

Re: [PATCH 2/2] clk: at91: main: do not continue if oscillators already prepared

2020-07-01 Thread Claudiu.Beznea
On 27.06.2020 00:03, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 25/06/2020 13:09:28+0300, Claudiu Beznea wrote: >> Return in clk_main_osc_prepare()/clk_main_rc_osc_prepare() if >> oscillators are already

Re: [PATCH v8 1/6] pwm: extend PWM framework with PWM modes

2019-02-13 Thread Claudiu.Beznea
On 06.02.2019 00:49, Thierry Reding wrote: > On Sat, Jan 05, 2019 at 10:05:22PM +0100, Uwe Kleine-König wrote: >> Hello, >> >> On Thu, Jan 03, 2019 at 01:29:44PM +, claudiu.bez...@microchip.com wrote: >>> From: Claudiu Beznea >>> >>> Add basic PWM modes: normal and complementary. These

Re: [PATCH v8 1/6] pwm: extend PWM framework with PWM modes

2019-02-13 Thread Claudiu.Beznea
On 06.02.2019 10:24, Uwe Kleine-König wrote: > Hello Thierry, > > On Wed, Feb 06, 2019 at 12:01:26AM +0100, Thierry Reding wrote: >> On Mon, Jan 07, 2019 at 11:10:40PM +0100, Uwe Kleine-König wrote: >>> On Mon, Jan 07, 2019 at 09:30:55AM +, claudiu.bez...@microchip.com >>> wrote: On

[PATCH 0/2] add slow clock support for SAM9X60

2019-02-14 Thread Claudiu.Beznea
From: Claudiu Beznea Hi, This series add slow clock support for SAM9X60. Apart from previous IPs, this one uses different offsets in control register for different functionalities. The series adapt current driver to work for all IPs using per IP configurations initialized at probe. Thank you,

  1   2   3   4   >