Re: [PATCH] perf evsel: fix NULL pointer deference when evsel-counts is NULL

On 23/01/13 22:02, Arnaldo Carvalho de Melo wrote: Em Mon, Jan 21, 2013 at 01:53:21PM +0900, Namhyung Kim escreveu: On Sat, 19 Jan 2013 16:36:54 +, Colin King wrote: From: Colin Ian King colin.k...@canonical.com __perf_evsel__read_on_cpu() only bails out with -ENOMEM if evsel-counts

[PATCH] USB: echi-dbgp: increase the controller wait time to come out of halt.

to wait ~450-950 microseconds. Signed-off-by: Colin Ian King colin.k...@canonical.com --- drivers/usb/early/ehci-dbgp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c index ee0ebac..89dcf15 100644 --- a/drivers/usb

Re: [PATCH] selftests: ipc: handle msgget failure return correctly

On 05/03/14 18:50, Guillaume Morin wrote: On 05 Mar 17:51, Colin King wrote: From: Colin Ian King colin.k...@canonical.com A failed msgget causes the test to return an uninitialised value in ret. Assign ret to -errno on error exit. Signed-off-by: Colin Ian King colin.k...@canonical.com

Re: [PATCH] x86, efi: print debug values in Kib not MB

On 30/07/14 15:48, Matt Fleming wrote: On Wed, 30 Jul, at 12:29:32AM, Borislav Petkov wrote: On Tue, Jul 29, 2014 at 01:09:21PM -0400, Prarit Bhargava wrote: The current debug print in EFI does [0.00] efi: mem84: type=3, attr=0xf, range=[0x645b5000-0x645fb000) (0MB)

Re: [PATCH][RESEND] static code analysis from cppcheck reports:

On 12/01/15 18:02, Geert Uytterhoeven wrote: On Mon, Jan 12, 2015 at 4:27 PM, Colin King colin.k...@canonical.com wrote: From: Colin Ian King colin.k...@canonical.com [drivers/video/fbdev/broadsheetfb.c:673]: (error) Memory leak: sector_buffer sector_buffer is not being kfree'd on each

Re: [PATCH] rtlwifi: ratelimit skb allocation failure message

On 10/02/15 13:48, Kalle Valo wrote: Eric Dumazet eric.duma...@gmail.com writes: On Tue, 2015-02-10 at 08:54 +, Colin King wrote: From: Colin Ian King colin.k...@canonical.com when running low on memory I noticed rtlwifi was producing a large quantity of repeated skb allocation

Re: [PATCH] pinctrl: sirf: fix typo in kernel warning on a bad interruot

On 28/02/15 20:38, Uwe Kleine-König wrote: Hello, is the typo in the Subject of your patch intentional? doh, no, my fail, I'll resend. Best regards Uwe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH][V3] ARM: pmu: fix memory leak due to early return not freeing irqs

On 18/05/15 14:27, Sudeep Holla wrote: On 18/05/15 13:57, Colin King wrote: From: Colin Ian King colin.k...@canonical.com Recent commit 338d9dd3e2ae (ARM: 8351/1: perf: don't warn about missing interrupt-affinity property for PPIs) introduced a memory leak of irqs on the Don't bother

Re: [PATCH] ARM: 8351/1: perf: fix memory leak on return

On 16/05/15 08:09, Ingo Molnar wrote: * Colin King colin.k...@canonical.com wrote: From: Colin Ian King colin.k...@canonical.com Recent commit 3b8786ff7a1b31645ae2c26a2ec32dbd42ac1094 (ARM: 8352/1: perf: Fix the pmu node name in warning message) introduced a memory leak of irqs

Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

On 31/05/15 23:15, Sergei Shtylyov wrote: Hello. On 06/01/2015 01:00 AM, Colin King wrote: From: Colin Ian King colin.k...@canonical.com If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer deference on req. Dereference, not deference. Shall I send v2

Re: [PATCH] drm/nouveau: usif_ioctl: ensure returns are initialized

On 01/07/15 18:12, Emil Velikov wrote: On 1 July 2015 at 17:56, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Jul 1, 2015 at 12:51 PM, Colin King colin.k...@canonical.com wrote: From: Colin Ian King colin.k...@canonical.com Various usif_ioctl helper functions do not initialize the return

Re: [PATCH] ALSA: Fix uninintialized error return

On 29/06/15 18:10, Takashi Iwai wrote: At Mon, 29 Jun 2015 17:10:22 +0100, Colin King wrote: From: Colin Ian King colin.k...@canonical.com Static analysis with cppcheck found the following error: [sound/core/init.c:118]: (error) Uninitialized variable: err ..this was introduced

Re: [PATCH] powerpc/pseries/hvcserver: don't memset pi_buff if it is null

commit message. > > Not that it's particularly meaningful for such a trivial fix, but FWIW : > > Reviewed-by: Daniel Axtens <d...@axtens.net> > > Regards, > Daniel > > Colin King <colin.k...@canonical.com> writes: > >> From: Colin Ian King <colin.k..

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

ch an unexpected issue in a standard way as opposed to just removing it and then hitting an issue with a null ptr deference. > >> Signed-off-by: Colin Ian King <colin.k...@canonical.com> >> --- >> drivers/ps3/ps3-vuart.c | 3 +-- >> 1 file changed, 1 insertion(+),

rhashtable concurrent writers issue, 4.2+

Hi, After testing with commit 7def0f952eccdd0edb3c504f4dab35ee0d3aba1f ("lib: fix data race in rhashtable_rehash_one") on the current 4.4-rc4 kernel, I believe I am still seeing race conditions that seem to bite concurrent readers. The reproducer is found in my stress-ng system stress tool:

Re: [Nouveau] [PATCH] drm/nouveau/iccsense: fix memory leak on default sensor->type case

lin > > 2016-06-02 12:28 GMT+02:00 Colin King <colin.k...@canonical.com>: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The default sensor->type case leaks memory allocated to rail. Fix >> this by free'ing rail before we conti

Re: [PATCH] mmc: sdhci-msm: fix spelling mistake: "Perpheral" -> "Peripheral"

On 23/06/16 12:39, Joe Perches wrote: > On Thu, 2016-06-23 at 10:52 +0100, Colin King wrote: >> trivial fix to spelling mistake in dev_err message > > Hello Colin. > > You are submitting a lot of these recently. > > Are you using a tool to find these? basically spell on some fancy kernel

Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"

On 23/06/16 20:23, Eli Billauer wrote: > This is getting increasingly embarrassing. I suppose a single patch, > fixing both silly mistakes (of mine), would be in place. > > Colin, would you prefer to submit a patch with both issues fixed > yourself, or should I take care of it? Eli, I don't mind

Re: [PATCH] tty/metag_da: initialize number_written to zero

On 07/02/16 07:41, Greg Kroah-Hartman wrote: > On Thu, Jan 28, 2016 at 06:48:17PM +0000, Colin Ian King wrote: >> On 27/01/16 11:42, James Hogan wrote: >>> Hi Colin, >>> >>> On Tue, Jan 26, 2016 at 11:37:25PM +, Colin King wrote: >>>>

Re: [PATCH] tty/metag_da: initialize number_written to zero

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 27/01/16 11:42, James Hogan wrote: > Hi Colin, > > On Tue, Jan 26, 2016 at 11:37:25PM +, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> number_written is not initialized, so it

Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

On 22/02/16 06:51, Alexander Stein wrote: > On Saturday 20 February 2016 22:10:27, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> passing rtl_stats by value is inefficient; the structure is over 300 >> bytes in size and generally j

Re: [PATCH] selinux: fix memory leak on node_ptr on error return path

On 22/03/16 21:35, Paul Moore wrote: > On Tue, Mar 22, 2016 at 4:28 PM, Serge E. Hallyn <se...@hallyn.com> wrote: >> Quoting Colin King (colin.k...@canonical.com): >>> From: Colin Ian King <colin.k...@canonical.com> >>> >>> node_ptr is no

Re: Q: why didn't GCC warn about this uninitialized variable?

On 03/03/16 12:19, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > >> Em Wed, Mar 02, 2016 at 02:21:27PM +0100, Peter Zijlstra escreveu: >>> On Wed, Mar 02, 2016 at 10:03:50AM -0300, Arnaldo Carvalho de Melo wrote: > Would not something like: > > sa =

Re: [PATCH] watchdog: trivial fix of spelling mistake on "allocate"

On 26/04/16 17:50, Guenter Roeck wrote: > On Mon, Apr 25, 2016 at 10:22:19PM -0700, Joe Perches wrote: >> On Mon, 2016-04-25 at 20:19 +0100, Colin King wrote: >>> fix spelling mistake, alloacate -> allocate >> [] >>> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c >> []

Re: [PATCH] x86/efi-bgrt: Switch all pr_err() to pr_debug() for invalid BGRT

On 30/04/16 23:35, Matt Fleming wrote: > (Adding Colin and Ricardo) > > On Wed, 27 Apr, at 01:23:55PM, Josh Boyer wrote: >> >> How is an end user supposed to see such a message and report it to the >> people that can fix it? They can't. So they report it in their >> distributions bug tracker

Re: [PATCH] net/ethoc: fix null dereference on error exit path

On 22/05/16 20:42, Max Filippov wrote: > Hi Colin, > > On Sun, May 22, 2016 at 08:08:18PM +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> priv is assigned to NULL however all the error exit paths to label 'free' >> d

Re: [PATCH] PM / clk: ensure we don't allocate a -ve size of count clks

On 16/04/16 13:52, Pavel Machek wrote: > On Sat 2016-04-16 13:50:03, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> It is entirely possible for of_count_phandle_wit_args to >> return a -ve error return value so we need to check for this

Re: [PATCH] x86/efi: initialize status to ensure garbage is not returned on small size

On 27/07/16 15:38, Matt Fleming wrote: > On Wed, 20 Jul, at 11:11:06AM, Colin Ian King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Although very unlikey, if size is too small or zero, then we end up with >> status not being set and returni

Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time

On 12/07/16 12:09, Sergei Shtylyov wrote: > On 7/12/2016 2:04 PM, Sergei Shtylyov wrote: > >>> From: Colin Ian King <colin.k...@canonical.com> >>> >>> According to the HPT366 data sheet, PCI config space dword 0x40-0x43 >>> bits 11:8 specify the pri

Re: [PATCH] [media] mb86a20s: remove redundant check if val is less than zero

On 15/07/16 16:20, Mauro Carvalho Chehab wrote: > Em Tue, 12 Jul 2016 10:30:51 +0100 > Colin King <colin.k...@canonical.com> escreveu: > >> From: Colin Ian King <colin.k...@canonical.com> >> >> The result of mb86a20s_readreg(state, 0x0a) & 0xf is always

Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time

On 12/07/16 12:27, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, July 12, 2016 12:16:19 PM Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> According to the HPT366 data sheet, PCI config space dword 0x40-0x43 &g

Re: [PATCH] devpts: fix null pointer dereference on failed memory allocation

On 26/06/16 19:29, Greg Kroah-Hartman wrote: > On Mon, Jun 20, 2016 at 03:40:27PM +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> An ENOMEM when creating a pair tty in tty_ldisc_setup causes a null >> pointer dereference in de

Re: powerpc/fadump: trivial fix of spelling mistake, clean up message

On 26/06/16 05:19, Michael Ellerman wrote: > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> trivial fix to spelling mistake "rgistration" and minor clean up >> of the printk error

Re: powerpc/fadump: trivial fix of spelling mistake, clean up message

On 27/06/16 12:20, Michael Ellerman wrote: > On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote: >> On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote: >>> On 26/06/16 05:19, Michael Ellerman wrote: >>>> On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:

Re: linux-next: build failure after merge of the powerpc tree

On 01/07/16 06:27, Stephen Rothwell wrote: > Hi all, > > After merging the powerpc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > arch/powerpc/kernel/fadump.c: In function 'fadump_invalidate_dump': > arch/powerpc/kernel/fadump.c:1014:2: error: expected ';' before

Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero

On 07/02/17 11:37, Dan Carpenter wrote: > On Tue, Feb 07, 2017 at 11:27:38AM +, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The check on rcode >= 0 is always true because rcode is unsigned >> and can never be less th

Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set

d) > 0 && vlan_tunnel_id_isrange(v_end, v) > 0) num_tinfos += 2; else num_tinfos += 1; } On 07/02/17 11:30, Nikolay Aleksandrov wrote: > On 07/02/17 11:56, Colin King wrote: >> From: Colin Ian K

Re: [PATCH] acpi: nfit: use %u format string specifier for unsigned ints

On 30/01/17 11:58, walter harms wrote: > > > Am 30.01.2017 12:25, schrieb Colin King: >> From: Colin Ian King <colin.k...@canonical.com> >> >> scrub_mode and scrub_count are both unsigned ints, however, the %d >> format string specifier is being use

Re: [PATCH] net: sctp: fix array overrun read on sctp_timer_tbl

On 20/01/17 13:10, Marcelo Ricardo Leitner wrote: > On Fri, Jan 20, 2017 at 01:01:57PM +, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The comparison on the timeout can lead to an array overrun >> read on sctp_timer_tbl be

Re: [PATCH] xfs: do not call xfs_buf_hash_destroy on a NULL pag

On 20/01/17 20:47, Darrick J. Wong wrote: > On Fri, Jan 20, 2017 at 01:26:12PM -0600, Eric Sandeen wrote: >> On 1/20/17 8:26 AM, Colin King wrote: >>> From: Colin Ian King <colin.k...@canonical.com> >>> >>> If pag cannot be allocated, the current er

re: sched: check negative err value to safe one level of indent

Jiro, A recent static analysis run with CoverityScan identified a potential change in functionality with your recent commit "sched: check negative err value to safe one level of indent" that landed in linux-next. The original path for case RTM_DELTFILTER would always goto errout, but your commit

drivers/staging/rtl8192u

Hi, Static analysis via CoverityScan picked up an issue in cmpk_handle_query_config_rx where the following operation on an u8 is clearly not correct: rx_query_cfg.cfg_action = (pmsg[4] & 0x8000) >> 31; The result of this operation is always zero. I suspect this should be:

re: sfc: process RX event inner checksum flags

Hi there, not sure if this is a bug, or intentional, but CoverityScan picked up a mismatch in arguments when calling efx_ef10_handle_rx_event_error() with commit "sfc: process RX event inner checksum flags" that landed in linux-next: CID 1402067 (#1 of 1): Arguments in wrong order

Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0

On 13/02/17 10:45, Felipe Balbi wrote: > > Hi, > > Colin King <colin.k...@canonical.com> writes: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The check for retval being less than zero is always true since >> retval equal to -EPIPE at

Re: [PATCH][V2] Smack: fix a dereference before null check on sock->sk

On 09/02/17 18:44, Casey Schaufler wrote: > On 2/9/2017 9:11 AM, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The initialisation of pointer ssp is from a dereference on sock->sk >> before sock-sk is null checked, hence there

Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int

On 16/01/17 15:45, Rob Herring wrote: > On Fri, Jan 13, 2017 at 3:06 PM, Colin King <colin.k...@canonical.com> wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> pin is an unsigned int and therefore can never be < 0 so >> this check is redu

re: rxrpc: Fix deadlock between call creation and sendmsg/recvmsg

I think the following part of the patch is problematic: call = rxrpc_find_call_by_user_ID(rx, user_call_ID); if (!call) { + ret = -EBADSLT; if (cmd != RXRPC_CMD_SEND_DATA) - return -EBADSLT; + goto

Re: [PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

On 26/02/17 18:52, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192de/

Re: [PATCH] ath10k: fix memory leak on caldata on error exit path

On 02/09/16 16:45, Valo, Kalle wrote: > Colin King <colin.k...@canonical.com> writes: > >> From: Colin Ian King <colin.k...@canonical.com> >> >> caldata is not being free'd on the error exit path, causing >> a memory leak. kfree it to fix the leak. &g

Re: [alsa-devel] [PATCH] ASoC: Intel: remove status, it is shadowing status of a higher scope

On 09/09/16 18:04, Pierre-Louis Bossart wrote: > On 9/9/16 2:09 AM, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The second declaration of status is shadowing the status of a higher >> scope. This uninitialized status

Re: [PATCH] powerpc/32: add missing \n at end of printk warning message

On 12/09/16 17:34, Joe Perches wrote: > On Mon, 2016-09-12 at 11:12 +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> The message is missing a \n, add it. > > Was this found via inspection or a tool? > grep

Re: [PATCH] regulator: da9055: remove null pointer check on array pdata->regulators

>> pdata->regulators >> >> From: Colin Ian King <colin.k...@canonical.com> >> >> pdata->regulators is an array of DA9052_MAX_REGULATORS struct >> regulator_init_data pointers hence cannot be null, so the null pointer >> check on pdata->regulato

Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage

On 13/09/16 13:46, Linus Walleij wrote: > On Tue, Sep 13, 2016 at 2:31 PM, Arnd Bergmann wrote: > >> Please try to avoid adding initializations in the local variable >> declaration, they just hide otherwise useful warnings when >> you get a function that actually does something

Re: [PATCH] mwifiex: fix memory leak on regd when chan is zero

On 15/09/16 18:10, Kalle Valo wrote: > Colin King <colin.k...@canonical.com> writes: > >> From: Colin Ian King <colin.k...@canonical.com> >> >> When chan is zero mwifiex_create_custom_regdomain does not kfree >> regd and we have a memory leak. Fix

Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text

On 12/09/16 15:33, Russell King - ARM Linux wrote: > On Mon, Sep 12, 2016 at 02:06:09PM +0100, Robin Murphy wrote: >> On 12/09/16 13:52, Colin King wrote: >>> From: Colin Ian King <colin.k...@canonical.com> >>> >>> A dev_warn message spans two lines and

Re: [PATCH][V2] mlxsw: spectrum: remove redundant check if err is zero

On 24/09/16 22:08, Ido Schimmel wrote: > On Sat, Sep 24, 2016 at 06:03:38PM -0700, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> There is an earlier check and return if err is non-zero, so >> the check to see if it is zero is redundant

Re: [PATCH] drm/amd/amdgpu: default to zero number of states if not enabled

On 06/10/16 19:32, Alex Deucher wrote: > On Thu, Oct 6, 2016 at 2:02 PM, Colin King <colin.k...@canonical.com> wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Currently, if adev->pp_enabled is false then the pp_stats_info data >> is not

Re: [PATCH] drm/amd/amdgpu: default to zero number of states if not enabled

On 06/10/16 20:04, Deucher, Alexander wrote: >> -Original Message- >> From: Colin Ian King [mailto:colin.k...@canonical.com] >> Sent: Thursday, October 06, 2016 3:04 PM >> To: Alex Deucher >> Cc: Deucher, Alexander; Koenig, Christian; David Airlie; Huang,

Re: [PATCH] drm/amdgpu: avoid out of bounds access on array interrupt_status_offsets

On 20/09/16 16:39, Alex Deucher wrote: > On Tue, Sep 20, 2016 at 11:16 AM, Colin King <colin.k...@canonical.com> wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The check for an out of bound index into array interrupt_status_offsets >>

Re: [PATCH] greybus: audio: ensure module is set to avoid crash on dev_err message

On 23/09/16 19:20, Vaibhav Agarwal wrote: > On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: >> On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote: >>> From: Colin Ian King <colin.k...@canonical.com> >>> &

Re: [PATCH] dmaengine: do not allow access outside of unmap_pool

On 23/08/16 10:24, Xulin Sun wrote: >>On Tue, May 17, 2016 at 01:00:46PM +0100, Colin King wrote: >>> From: Colin Ian King <colin.k...@canonical.com> >>> >>> When CONFIG_DMA_ENGINE_RAID is defined, unmap_pool[] is just 1 >>> element in size, howe

Re: [PATCH] perf probe: check if *ptr2 is zero and not ptr2

On 03/10/16 12:19, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 03, 2016 at 11:34:31AM +0100, Colin King escreveu: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Static anaylsis with cppcheck detected an incorrect comparison: >> [tools/perf/util/p

Re: [PATCH] iio: maxim_thermocouple: return -EINVAL on invalid read size

On 25/10/16 20:11, Lars-Peter Clausen wrote: > On 10/25/2016 09:04 PM, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> In the case that the read size is not 2 or 4 bytes >> then maxim_thermocouple_read is not initializing ret and >&

Re: [PATCH] ipc/sem: ensure we left shift a ULL rather than a 32 bit integer

On 28/10/16 20:21, Manfred Spraul wrote: > Hi Colin, > > On 10/28/2016 08:11 PM, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The left shift amount is sop->sem_num % 64, which is up to 63, so >> ensure we are shifting a UL

Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

On 24/10/16 23:20, Joe Perches wrote: > On Mon, 2016-10-24 at 15:13 -0700, Kees Cook wrote: >> On Mon, Oct 24, 2016 at 3:02 PM, Colin King <colin.k...@canonical.com> wrote: >>> From: Colin Ian King <colin.k...@canonical.com> >>> >>> tri

Re: [PATCH] ARC: return -EFAULT on failed access_ok for arc_usr_cmpxchg syscall

On 24/10/16 16:56, Vineet Gupta wrote: > On 10/24/2016 03:47 AM, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> arc_usr_cmpxchg currently returns an uninitialized value in ret >> on a failed access_ok call. Instead, return -EFAULT. &g

Re: [PATCH] cxgb4: fix memory leak on txq_info

On 25/11/16 21:10, David Miller wrote: > From: Colin King <colin.k...@canonical.com> > Date: Wed, 23 Nov 2016 11:02:44 + > >> From: Colin Ian King <colin.k...@canonical.com> >> >> Currently if txq_info->uldtxq cannot be allocated then >> tx

Re: [PATCH] drm/amd/powerplay: check if table_info is NULL before dereferencing it

, Ray; Nils Wallménius; Baoyou Xie; dri- >> de...@lists.freedesktop.org >> Cc: linux-kernel@vger.kernel.org >> Subject: [PATCH] drm/amd/powerplay: check if table_info is NULL before >> dereferencing it >> >> From: Colin Ian King <colin.k...@canonical.com> &

Re: [PATCH] staging: unisys: ix spelling mistake of "outstanding"

On 29/11/16 21:02, Greg Kroah-Hartman wrote: > On Tue, Nov 29, 2016 at 08:37:35PM +, Kershner, David A wrote: >> >> >>> -Original Message- >>> From: Colin King [mailto:colin.k...@canonical.com] >>> Sent: Tuesday, November 29, 2016 2:07 PM >>> To: Kershner, David A

Re: [RFC v2 4/5] rcu: Use for_each_leaf_node_cpu() in force_qs_rnp()

cpu_possible_mask. So replace the >>> for_each_leaf_node_possible_cpu() in force_qs_rnp() with >>> for_each_leaf_node_cpu() to save several checks. >>> >>> [Note we need to use "1UL << bit" instead of "1 << bit" to generate the >>> c

Re: [PATCH] btrfs: fix dereference on inode->i_sb before inode null check

On 16/12/16 15:03, Jeff Mahoney wrote: > On 12/16/16 7:20 AM, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> inode is being deferenced and then inode is checked to see if it >> is null, implying we potentially could have a null pointer d

Re: [PATCH] spi: armada-3700: fix unsigned compare than zero on irq

On 13/12/16 10:55, Romain Perier wrote: > Hello, > > Le 13/12/2016 à 11:28, Colin King a écrit : >> From: Colin Ian King <colin.k...@canonical.com> >> >> spi->irq is an unsigned integer hence the check if status is less than >> zero has no effect. Fix

Re: [PATCH] rcu: shift by 1UL rather than 1 to fix sign extension error

On 13/12/16 11:21, Boqun Feng wrote: > On Tue, Dec 13, 2016 at 10:56:46AM +, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> mask and bit are unsigned longs, so if bit is 31 we end up sign >> extending the 1 and mask e

Re: [PATCH] kcm: fix spelling mistake in Kconfig, "connectons"

On 13/12/16 17:30, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake "connectons" to "connections" in > Kconfig text. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- >

Re: [PATCH] rcu: shift by 1UL rather than 1 to fix sign extension error

On 14/12/16 14:42, Boqun Feng wrote: > On Tue, Dec 13, 2016 at 11:33:19AM +0000, Colin Ian King wrote: >> On 13/12/16 11:21, Boqun Feng wrote: >>> On Tue, Dec 13, 2016 at 10:56:46AM +, Colin King wrote: >>>> From: Colin Ian King <colin.k...@canonical.com>

Re: [PATCH] flow disector: check if arp_eth is null rather than arp

On 13/01/17 18:24, Eric Dumazet wrote: > On Fri, 2017-01-13 at 13:34 +, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> arp is being checked instead of arp_eth to see if the call to >> __skb_header_pointer failed. Fix this by ch

Re: [PATCH v1] scsi: ufs: fix arguments order some trace calls

On 11/01/17 00:48, Subhash Jadavani wrote: > Colin Ian King <colin.k...@canonical.com> reported that with > commit 7ff5ab473633 ("scsi: ufs: add tracing support") static analysis > is reporting that we may have swapped arguments on calls to: >

Re: [PATCH] [media] gp8psk: fix spelling mistake: "firmare" -> "firmware"

On 29/12/16 21:23, VDR User wrote: >> - err("firmare chunk size bigger than 64 bytes."); >> + err("firmware chunk size bigger than 64 bytes."); > > Yup. > >> -"HW don't support CMAC encrypiton, use software >> CMAC

Re: [PATCH][V2] qed: fix memory leak of a qed_spq_entry on error failure paths

On 21/12/16 13:29, Mintz, Yuval wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> A qed_spq_entry entry is allocated by qed_sp_init_request but is not kfree'd >> if an error occurs, causing a memory leak. Fix this by returning the >> previo

Re: [PATCH] input: synaptics-rmi4: check for null rmi_dev before it is dereferenced

On 20/12/16 21:22, Dmitry Torokhov wrote: > Hi Colin, > > On Tue, Dec 20, 2016 at 10:07:50AM +, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> rmi_dev is currently being dereferenced before it null checked, so we >> have a p

Re: [PATCH] usb: gadget: pch_udc: don't update td->next after it has been released to the pool

On 28/03/17 13:51, Felipe Balbi wrote: > > Hi, > > Colin King <colin.k...@canonical.com> writes: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Writing to td->next should be avoided after td has been freed using >> dma_po

Re: [PATCH] scsi: fcoe: sanity check string size for store_ctrl_mode option

On 22/03/17 19:39, Dan Carpenter wrote: > On Wed, Mar 22, 2017 at 02:01:37PM +, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Reading and writing to mode[count - 1] implies the count should not >> be less than 1 so add a sani

Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error

On 22/03/17 11:42, Jarkko Sakkinen wrote: > On Mon, Mar 20, 2017 at 02:23:36PM +, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The comparison of an out of range index into space->context_tbl is >> off-by-one and should be usin

Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'

On 03/04/17 10:20, Joe Perches wrote: > On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> trivial fix to spelling mistake in wl1271_warning error message >> >> Signed-off-by: Colin Ian King <co

Re: [PATCH] mm/migrate: check for null vma before dereferencing it

On 11/04/17 22:26, Andrew Morton wrote: > On Tue, 11 Apr 2017 13:51:02 +0100 Colin King <colin.k...@canonical.com> > wrote: > >> From: Colin Ian King <colin.k...@canonical.com> >> >> check if vma is null before dereferencing it, this avoiding any >> p

re: mtip32xx: add a status field to struct mtip_cmd

Hi, CoverityScan found an issue with the following part of the patch: - if (likely(!reserv)) - blk_mq_complete_request(rq, -ENODEV); - else if (test_bit(MTIP_PF_IC_ACTIVE_BIT, >port->flags)) { + if (likely(!reserv)) { + cmd->status = -ENODEV; +

Re: [PATCH] jffs2: fix spelling mistake: "requestied" -> "requested"

On 19/04/17 19:38, Brian Norris wrote: > On Wed, Apr 19, 2017 at 11:36:34AM -0700, Brian Norris wrote: >> s/an nonexistent/a nonexisten/ > > Ha, and of course a typo in my correction :) But at least I didn't make > that mistake in the real commit. Easily done :-/ > > Brian > Thanks Brian

Re: [PATCH] ASoC: Intel: Skylake: fix dereference before NULL check on ebus

On 19/04/17 14:32, Dan Carpenter wrote: > On Wed, Apr 19, 2017 at 01:16:13PM +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> ebus is being NULL checked however it is being dereferenced >> earlier on the assignment bus = ebus_to_h

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

able, like: > > *hist_count += i * (*hist_entry++); > > *hist_count += hist_entry[i]*i; As long as it gets fixed somehow, then I'm happy. Colin > > > re, > wh >>> >>> On 3/7/2017 22:30, Colin King wrote: >>>> From: Colin Ian King <colin.k...@ca

Re: [PATCH] iio: multiplexer: fix unsigned check with less than zero

On 08/03/17 08:59, Peter Rosin wrote: > On 2017-03-07 16:06, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Comparing a size_t with less than zero is always false as size_t >> is unsigned. The intent of the comparison w

Re: [PATCH] thunderbolt: fix incorrect value assigned to req->response_type

On 15/08/17 16:22, Dan Carpenter wrote: > On Tue, Aug 15, 2017 at 05:38:34PM +0300, Mika Westerberg wrote: >> On Tue, Aug 15, 2017 at 03:31:33PM +0100, Colin King wrote: >>> From: Colin Ian King <colin.k...@canonical.com> >>> >>> req->response_type

Re: [PATCH] reiserfs: fix spelling mistake: "tranasction" -> "transaction"

On 16/08/17 15:00, Jan Kara wrote: > On Wed 16-08-17 09:06:20, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Trivial fix to spelling mistake in reiserfs_warning message >> >> Signed-off-by: Colin Ian King <colin.k...@canonic

Re: [PATCH][V2] net/mlx4: fix spelling mistake: "availible" -> "available"

On 16/08/17 14:58, Leon Romanovsky wrote: > On Wed, Aug 16, 2017 at 02:42:50PM +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Trivial fix to spelling mistakes in the mlx4 driver. >> >> Signed-off-by: Colin Ian King <co

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

On 16/08/17 14:37, Laurentiu Tudor wrote: > On 08/16/2017 03:06 PM, Dan Carpenter wrote: >> On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: >>> From: Colin Ian King <colin.k...@canonical.com> >>> >>> The previous fix removed the equal to z

Re: [PATCH] netfilter: fix indent on in statements

On 15/08/17 10:45, Sergei Shtylyov wrote: > Hello! > > On 8/15/2017 9:50 AM, Colin King wrote: > >> From: Colin Ian King <colin.k...@canonical.com> >> >> The returns on some if statements are not indented correctly, > >s/in/if/ in the subject? Doh,

NACK: [PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static

On 12/08/17 23:00, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > The function btc8723b2ant_dac_swing is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'btc8723b2ant_

Re: [Nouveau] [PATCH] drm/nouveau: remove redundant null check on array mstm->msto

On 17/08/17 13:21, Emil Velikov wrote: > On 17 August 2017 at 11:37, Colin King <colin.k...@canonical.com> wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The check to see if mstm->msto is null is redundant because it is >> an

Re: [PATCH] mfd: rtsx: make arrays depth and cd_mask static const

On 17/07/17 11:46, Lee Jones wrote: > Please start the commit subject description with an uppercase char. > >> From: Colin Ian King <colin.k...@canonical.com> > > This is odd. How are you sending this patch Colin? git send-patch. Hrm. I'll check it out for next t

Re: [PATCH] staging: fbtft: make const array gamma_par_mask static

On 11/07/17 18:30, Greg Kroah-Hartman wrote: > On Tue, Jul 11, 2017 at 06:20:02PM +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Don't populate array gamma_par_mask on the stack but instead make it >> static. Makes the

Re: [PATCH] char/mwave: make some arrays static const to make object code smaller

On 10/07/17 16:28, Arnd Bergmann wrote: > On Mon, Jul 10, 2017 at 5:08 PM, Colin King <colin.k...@canonical.com> wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Don't populate arrays on the stack but make them static. Makes >> the obje

  1   2   3   4   5   6   7   8   9   >