[PATCH][next] dmaengine: dw-axi-dmac: remove redundant null check on desc

2021-02-03 Thread Colin King
From: Colin Ian King The pointer desc is being null checked twice, the second null check is redundant because desc has not been re-assigned between the checks. Remove the redundant second null check on desc. Addresses-Coverity: ("Logically dead code") Fixes: ef6fb2d6f1ab ("dmaengine: dw-axi-dmac

[PATCH][next] iommu/mediatek: Fix unsigned domid comparison with less than zero

2021-02-03 Thread Colin King
From: Colin Ian King Currently the check for domid < 0 is always false because domid is unsigned. Fix this by making it signed. Addresses-CoverityL ("Unsigned comparison against 0") Fixes: ab1d5281a62b ("iommu/mediatek: Add iova reserved function") Signed-off-by: Colin Ian King --- drivers/io

[PATCH][next] drm/nouveau/fifo/tu102: Fix potential array out of bounds access error

2021-02-03 Thread Colin King
From: Colin Ian King Currently the for_each_set_bit loop is iterating index engn from 0..31 and calls to tu102_fifo_recover_engn can potentiall access fifo->engine[engn] where engn is larger than the array engine (which is currently hard coded as 16 elements). Avoid any potential array out of bo

[PATCH] libertas: remove redundant initialization of variable ret

2021-01-28 Thread Colin King
From: Colin Ian King The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/wireless/marvell/li

[PATCH] iwlwifi: mvm: remove redundant initialization of variable phy_id

2021-01-28 Thread Colin King
From: Colin Ian King The variable phy_id is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/wireless/intel/i

[PATCH] media: drxj: remove redundant assignments to variable image_to_select

2021-01-28 Thread Colin King
From: Colin Ian King The variable image_to_select is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 2 +- 1 fi

[PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus

2021-01-28 Thread Colin King
From: Colin Ian King The variable rtstatu is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/wireless/realte

[PATCH] staging: net: wimax: i2400m: fw: remove redundant initialization of variable result

2021-01-28 Thread Colin King
From: Colin Ian King The variable result is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/wimax/i2400m

[PATCH] netfilter: nf_tables: remove redundant assignment of variable err

2021-01-28 Thread Colin King
From: Colin Ian King The variable err is being assigned a value that is never read, the same error number is being returned at the error return path via label err1. Clean up the code by removing the assignment. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- net/netfilt

[PATCH][next] net/mlx5e: Fix spelling mistake "channles" -> "channels"

2021-02-04 Thread Colin King
From: Colin Ian King There is a spelling mistake in a netdev_warn message. Fix it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/driver

[PATCH] net: dwc-xlgmac: Fix spelling mistake in function name

2021-02-04 Thread Colin King
From: Colin Ian King There is a spelling mistake in the function name alloc_channles_and_rings. Fix this by renaming it to alloc_channels_and_rings. Signed-off-by: Colin Ian King --- drivers/net/ethernet/synopsys/dwc-xlgmac-desc.c | 2 +- drivers/net/ethernet/synopsys/dwc-xlgmac-net.c | 2 +-

[PATCH][next][V2] iommu/mediatek: Fix unsigned domid comparison with less than zero

2021-02-04 Thread Colin King
From: Colin Ian King Currently the check for domid < 0 is always false because domid is unsigned. Fix this by casting domid to an int before making the comparison. Addresses-Coverity: ("Unsigned comparison against 0") Signed-off-by: Colin Ian King --- V2: cast domid rather than making it an in

[PATCH] media: platform: sti: make a const array static, makes object smaller

2021-02-04 Thread Colin King
From: Colin Ian King Don't populate the const array bws on the stack but instead it static. Makes the object code smaller by 8 bytes: Before: textdata bss dec hex filename 125044568 0 1707242b0 media/platform/sti/hva/hva-h264.o After: textdata bss

[PATCH][V2] media: platform: sti: make a const arrays static, makes object smaller

2021-02-04 Thread Colin King
From: Colin Ian King Don't populate the const arrays on the stack but instead it static. Makes the object code smaller by 8 bytes: Before: textdata bss dec hex filename 125044568 0 1707242b0 media/platform/sti/hva/hva-h264.o After: textdata bss

[PATCH] HID: lg-g15: make a const array static, makes object smaller

2021-02-04 Thread Colin King
From: Colin Ian King Don't populate the const array led_names on the stack but instead make it static. Makes the object code smaller by 79 bytes: Before: textdata bss dec hex filename 196867952 256 278946cf6 drivers/hid/hid-lg-g15.o After: textdata

[PATCH] phy: qcom-qmp: make a const array static, makes object smaller

2021-02-04 Thread Colin King
From: Colin Ian King Don't populate the const array cfg1_settings on the stack but instead make it static. Makes the object code smaller by 24 bytes: Before: textdata bss dec hex filename 73585 20240 64 93889 16ec1 drivers/phy/qualcomm/phy-qcom-qmp.o After: te

[PATCH] drm/mgag200: make a const array static, makes object smaller

2021-02-04 Thread Colin King
From: Colin Ian King Don't populate the const array m_div_val on the stack but instead make it static. Makes the object code smaller by 29 bytes: Before: textdata bss dechex filename 347364552 0 39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o After: textdata

[PATCH][V2] drm/mgag200: make a const array static, makes object smaller

2021-02-04 Thread Colin King
From: Colin Ian King Don't populate the const array m_div_val on the stack but instead make it static. Makes the object code smaller by 29 bytes: Before: textdata bss dechex filename 347364552 0 39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o After: textdata

[PATCH] drm/bridge: make a const array static, makes object smaller

2021-02-04 Thread Colin King
From: Colin Ian King Don't populate the const array frs_limits on the stack but instead make it static. Makes the object code smaller by 128 bytes: Before: textdata bss dec hex filename 248457440 64 323497e5d ./drivers/gpu/drm/bridge/tc358768.o After: text

[PATCH] fs/jfs: fix potential integer overflow on shift of a int

2021-02-05 Thread Colin King
From: Colin Ian King The left shift of int 32 bit integer constant 1 is evaluated using 32 bit arithmetic and then assigned to a signed 64 bit integer. In the case where l2nb is 32 or more this can lead to an overflow. Avoid this by shifting using the BIT_ULL macro instead. Addresses-Coverity:

[PATCH] mac80211: fix potential overflow when multiplying to u32 integers

2021-02-05 Thread Colin King
From: Colin Ian King The multiplication of the u32 variables tx_time and estimated_retx is performed using a 32 bit multiplication and the result is stored in a u64 result. This has a potential u32 overflow issue, so avoid this by casting tx_time to a u64 to force a 64 bit multiply. Addresses-Co

[PATCH][next] drm/i915/display: Fix spelling mistake "Couldnt" -> "Couldn't"

2021-02-09 Thread Colin King
From: Colin Ian King There is a spelling mistake in a drm_dbg message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/i

[PATCH] media: vivid: fix assignment of dev->fbuf_out_flags

2021-02-25 Thread Colin King
From: Colin Ian King Currently the chroma_flags and alpha_flags are being zero'd with a bit-wise mask and the following statement should be bit-wise or'ing in the new flag bits but instead is making a direct assignment. Fix this by using the |= operator rather than an assignment. Addresses-Cove

[PATCH] mt7601u: fix always true expression

2021-02-25 Thread Colin King
From: Colin Ian King Currently the expression ~nic_conf1 is always true because nic_conf1 is a u16 and according to 6.5.3.3 of the C standard the ~ operator promotes the u16 to an integer before flipping all the bits. Thus the top 16 bits of the integer result are all set so the expression is alw

[PATCH] ASoC: Intel: boards: sof-wm8804: add check for PLL setting

2021-02-26 Thread Colin King
From: Colin Ian King Currently the return from snd_soc_dai_set_pll is not checking for failure, this is the only driver in the kernel that ignores this, so it probably should be added for sake of completeness. Fix this by adding an error return check. Addresses-Coverity: ("Unchecked return valu

[PATCH] media: i2c: adp1653: fix error handling from a call to adp1653_get_fault

2021-02-26 Thread Colin King
From: Colin Ian King The error check on rval from the call to adp1653_get_fault currently returns if rval is non-zero. This appears to be incorrect as the following if statement checks for various bit settings in rval so clearly rval is expected to be non-zero at that point. Coverity flagged the

[PATCH] ALSA: ctxfi: cthw20k2: fix mask on conf to allow 4 bits

2021-02-26 Thread Colin King
From: Colin Ian King Currently the mask operation on variable conf is just 3 bits so the switch statement case value of 8 is unreachable dead code. The function daio_mgr_dao_init can be passed a 4 bit value, function dao_rsc_init calls it with conf set to: conf = (desc->msr & 0x7) | (desc->

[PATCH][next] w1_therm: remove redundant assignments to variable ret

2020-05-19 Thread Colin King
From: Colin Ian King The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/w1/slaves/w1_therm.c | 8

[PATCH][next] clocksource/drivers/timer-ti-dm: fix spelling mistake "detectt" -> "detect"

2020-05-19 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/clocksource/timer-ti-dm-systimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer

[PATCH] mt76: mt7915: fix a handful of spelling mistakes

2020-05-19 Thread Colin King
From: Colin Ian King There are some spelling mistakes in some literal strings. Fix these. Signed-off-by: Colin Ian King --- drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/de

[PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-07-30 Thread Colin King
From: Colin Ian King The null check on a failed workqueue create is currently null checking hdev->cq_wq rather than the pointer hdev->cq_wq[i] and so the test will never be true on a failed workqueue create. Fix this by checking hdev->cq_wq[i]. Addresses-Coverity: ("Dereference before null check

[PATCH] staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string

2020-05-21 Thread Colin King
From: Colin Ian King Currently HSD20_IPS is defined as "true" and will always result in a non-zero result even if it is defined as "false" because it is an array and that will never be zero. Fix this by defining it as an integer 1 rather than a literal string. Addessses-Coverity: ("Array compare

[PATCH] usb: gadget: lpc32xx_udc: don't dereference ep pointer before null check

2020-05-21 Thread Colin King
From: Colin Ian King Currently pointer ep is being dereferenced before it is null checked leading to a null pointer dereference issue. Fix this by only assigning pointer udc once ep is known to be not null. Also remove a debug message that requires a valid udc which may not be possible at that

[PATCH][next] media: atomisp: fix a handful of spelling mistakes

2020-05-21 Thread Colin King
From: Colin Ian King There are several spelling mistakes in various messages and literal strings. Fix these. Signed-off-by: Colin Ian King --- .../staging/media/atomisp/pci/base/refcount/src/refcount.c | 2 +- .../media/atomisp/pci/css_2401_system/host/csi_rx_private.h | 4 ++-- .../atomisp/p

[PATCH] perf bench: fix a couple of spelling mistakes in options text

2020-08-11 Thread Colin King
From: Colin Ian King There are a couple of spelling mistakes in the text. Fix these. Signed-off-by: Colin Ian King --- tools/perf/bench/find-bit-bench.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/bench/find-bit-bench.c b/tools/perf/bench/find-bit-bench.

[PATCH][next] cifs: fix double free error on share and prefix

2020-07-31 Thread Colin King
From: Colin Ian King Currently if the call dfs_cache_get_tgt_share fails we cannot fully guarantee that share and prefix are set to NULL and the next iteration of the loop can end up potentially double freeing these pointers. Since the semantics of dfs_cache_get_tgt_share are ambiguous for failur

[PATCH][next] staging: spmi: hisi-spmi-controller: fix spelling mistake "controlller" -> "controller"

2020-08-20 Thread Colin King
From: Colin Ian King There is a spelling mistake in the MODULE_ALIAS, fix it. Signed-off-by: Colin Ian King --- drivers/staging/hikey9xx/hisi-spmi-controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c b/drivers/staging

[PATCH] omapfb: fix spelling mistake "propert" -> "property"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/video/fbdev/omap2/omapfb/dss/venc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/venc.c b/drivers/video/fbdev/oma

[PATCH] drm/vmwgfx: fix spelling mistake "Cound" -> "Could"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in a DRM_ERROR message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgf

[PATCH] drm/amdgpu: fix spelling mistake "Falied" -> "Failed"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in a DRM_ERROR message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/a

[PATCH] drm/omap: fix spelling mistake "propert" -> "property"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/omapdrm/dss/venc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c index

[PATCH] macintosh: windfarm: fix spelling mistake "detatch" -> "detach"

2020-08-05 Thread Colin King
From: Colin Ian King There are spelling mistakes in DBG messages. Fix them. Signed-off-by: Colin Ian King --- drivers/macintosh/windfarm_lm75_sensor.c | 2 +- drivers/macintosh/windfarm_lm87_sensor.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/macintosh/windf

[PATCH][next] drm/amdgpu: fix spelling mistake "paramter" -> "parameter"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_warn message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amd

[PATCH] RDMA/usnic: fix spelling mistake "transistion" -> "transition"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in a usnic_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/infiniband/hw/usnic/usnic_ib_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_main.c b/drivers/infini

[PATCH] staging: ion: fix spelling mistake in function name "detatch" -> "detach"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in the function name ion_dma_buf_detatch. Fix it by removing the extraneous t. Signed-off-by: Colin Ian King --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/

[PATCH] RDMA/hns: fix spelling mistake "epmty" -> "empty"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_dbg message. Fix it. Signed-off-by: Colin Ian King --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hn

[PATCH] usb: gadget: fix spelling mistake "Dectected" -> "Detected"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in a literal string. Fix it. Signed-off-by: Colin Ian King --- drivers/usb/gadget/udc/fsl_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core

[PATCH] power: pm2301_charger: fix spelling mistake "chargind" -> "charging"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_dbg message. Fix it. Signed-off-by: Colin Ian King --- drivers/power/supply/pm2301_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/pm2301_charger.c b/drivers/power/supply/pm2301_charge

[PATCH][next] staging: wfx: fix a handful of spelling mistakes

2020-08-05 Thread Colin King
From: Colin Ian King There are various spelling mistakes in comments and error messages. Fix these. Signed-off-by: Colin Ian King --- drivers/staging/wfx/data_rx.c | 2 +- drivers/staging/wfx/data_tx.c | 2 +- drivers/staging/wfx/debug.c | 4 ++-- drivers/staging/wfx/hif_rx.c | 2 +- driver

[PATCH] drm/gma500: fix spelling mistake "pannel" -> "panel"

2020-08-05 Thread Colin King
From: Colin Ian King There a handful of spelling mistakes. fix them. Signed-off-by: Colin Ian King --- drivers/gpu/drm/gma500/mdfld_dsi_output.c | 4 ++-- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdf

[PATCH] media: atomisp: fix spelling mistake "unsupport" -> "unsupported"

2020-08-06 Thread Colin King
From: Colin Ian King There are spelling mistakes in some dev_err messages. Fix these. Signed-off-by: Colin Ian King --- drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c

[PATCH][next][V2] staging: wfx: fix a handful of spelling mistakes

2020-08-06 Thread Colin King
From: Colin Ian King There are various spelling mistakes in comments and error messages. Fix these. Signed-off-by: Colin Ian King --- V2: add in some more fixes as spotted by Randy Dunlap --- drivers/staging/wfx/data_rx.c | 2 +- drivers/staging/wfx/data_tx.c | 2 +- drivers/staging/wfx/debu

[PATCH] ALSA: usb: fix spelling mistake "buss" -> "bus"

2020-08-06 Thread Colin King
From: Colin Ian King There is a spelling mistake in a usb_audio_dbg debug message. Also replace "param" with "parameter". Fix these. Signed-off-by: Colin Ian King --- sound/usb/mixer_us16x08.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/mixer_us16x08.c b/soun

[PATCH][next] thermal: mediatek: remove redundant initialization of variables

2020-08-06 Thread Colin King
From: Colin Ian King There are several variables that are being initialized with values that are never read and the variables are being re-assigned later on. Remove the redundant initializations. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/thermal/mtk_thermal

[PATCH] net: hns3: fix spelling mistake "could'nt" -> "couldn't"

2020-08-06 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main

[PATCH] ath6kl: fix spelling mistake "initilisation" -> "initialization"

2020-08-06 Thread Colin King
From: Colin Ian King There is a spelling mistake in an ath6kl_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath6kl/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/a

[PATCH] can: grcan: fix spelling mistake "buss" -> "bus"

2020-08-06 Thread Colin King
From: Colin Ian King There is a spelling mistake in a netdev_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/net/can/grcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/grcan.c b/drivers/net/can/grcan.c index 378200b682fa..5d1f158431

[PATCH][V2] macintosh: windfarm: remove detatch debug containing spelling mistakes

2020-08-06 Thread Colin King
From: Colin Ian King There are spelling mistakes in two debug messages. As recommended by Wolfram Sang, these can be removed as there is plenty of debug in the driver core. Signed-off-by: Colin Ian King --- V2: remove the debug rather than fixing the spelling --- drivers/macintosh/windfarm_l

[PATCH] rtw88: fix spelling mistake: "unsupport" -> "unsupported"

2020-08-06 Thread Colin King
From: Colin Ian King There are some spelling mistakes in rtw_info messages. Fix these. Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 4 ++-- drivers/net/wireless/realtek/rtw88/rtw8822c.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH][next] vdpa/mlx5: fix memory allocation failure checks

2020-08-06 Thread Colin King
From: Colin Ian King The memory allocation failure checking for in and out is currently checking if the pointers are valid rather than the contents of what they point to. Hence the null check on failed memory allocations is incorrect. Fix this by adding the missing indirection in the check. Also

[PATCH] mmc: sdhci-pci-o2micro: fix spelling mistake "unsupport" -> "unsupported"

2020-08-06 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_info message. Fix it. Signed-off-by: Colin Ian King --- drivers/mmc/host/sdhci-pci-o2micro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c

[PATCH] wl1251, wlcore: fix spelling mistake "buld" -> "build"

2020-08-06 Thread Colin King
From: Colin Ian King There are spelling mistakes in warning messages. Fix these. Signed-off-by: Colin Ian King --- drivers/net/wireless/ti/wl1251/main.c | 2 +- drivers/net/wireless/ti/wlcore/cmd.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ti/

[PATCH] x86/resctrl: fix spelling mistake "Could't" -> "Couldn't"

2020-08-10 Thread Colin King
From: Colin Ian King There are spelling mistakes in pr_warn messages. Fix these. Signed-off-by: Colin Ian King --- arch/x86/kernel/cpu/resctrl/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c

[PATCH] RDMA/core: fix spelling mistake "Could't" -> "Couldn't"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_warn message. Fix it. Signed-off-by: Colin Ian King --- drivers/infiniband/core/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index 82bfee

[PATCH] ms_block: fix spelling mistake "doesn'" -> "doesn't"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in a debug message. Fix it. Signed-off-by: Colin Ian King --- drivers/memstick/core/ms_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c index d9ee8e3d

[PATCH] scsi: snic: fix spelling mistakes of "Queueing"

2020-08-10 Thread Colin King
From: Colin Ian King There are two different spelling mistakes of "Queueing" in error and debug messages. Fix these. Signed-off-by: Colin Ian King --- drivers/scsi/snic/snic_scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/snic/snic_scsi.c b/drivers/s

[PATCH] drivers: thermal: Kconfig: fix spelling mistake "acces" -> "access"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in the Kconfig text, fix it. Signed-off-by: Colin Ian King --- drivers/thermal/st/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/st/Kconfig b/drivers/thermal/st/Kconfig index 3c3b695cc3e9..58ece381956

[PATCH] USB: storage: isd200: fix spelling mistake "removeable" -> "removable"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in a usb_stor_dbg debug message. Fix it. Signed-off-by: Colin Ian King --- drivers/usb/storage/isd200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c index 89f5e33

[PATCH] scsi: bnx2fc: fix spelling mistake "couldnt" -> "couldn't"

2020-08-10 Thread Colin King
From: Colin Ian King There are spelling mistakes in various printk messages. Fix these. Signed-off-by: Colin Ian King --- drivers/scsi/bnx2fc/bnx2fc_io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c

[PATCH] scsi: csiostor: fix fix spelling mistake "couldnt" -> "couldn't"

2020-08-10 Thread Colin King
From: Colin Ian King There are spelling mistakes in two comments and a csio_err error message. Fix these. Signed-off-by: Colin Ian King --- drivers/scsi/csiostor/csio_scsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/s

[PATCH] regulator: fix spelling mistake "Cant" -> "Can't"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/regulator/fixed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index d54830e48b8d..142a70a89153

[PATCH] drm/i915/vlv_dsi_pll: fix spelling mistake "Cant" -> "Can't"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in a drm_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/vlv_dsi_pll.c b/drivers/gpu/drm/i915/dis

[PATCH] drm/vmwgfx: fix spelling mistake "Cant" -> "Can't"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in a DRM_ERROR message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c

[PATCH] ktest.pl: fix spelling mistake "Cant" -> "Can't"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in an error message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/ktest/ktest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index 917810fa4c85..08174

[PATCH] lpfc: fix spelling mistake "Cant" -> "Can't"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in an error message. Fix it. Signed-off-by: Colin Ian King --- drivers/scsi/lpfc/lpfc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index ae0a825

[PATCH] kvm: selftests: fix spelling mistake: "missmatch" -> "missmatch"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in an error message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/lib/sparsebit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/lib/sparsebit.c b/tools/testing/selftests

[PATCH] cpupowerutils: fix spelling mistake "dependant" -> "dependent"

2020-08-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in a message. Fix it. Signed-off-by: Colin Ian King --- tools/power/cpupower/debug/i386/intel_gsic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/power/cpupower/debug/i386/intel_gsic.c b/tools/power/cpupower/debug/i

[PATCH] of/address: check for invalid range.cpu_addr

2020-08-10 Thread Colin King
From: Colin Ian King Currently invalid CPU addresses are not being sanity checked resulting in SATA setup failure on a SynQuacer SC2A11 development machine. The original check was removed by and earlier commit, so add a sanity check back in to avoid this regression. Fixes: 7a8b64d17e35 ("of/addr

[PATCH][next] drm/amd/display: fix potential integer overflow when shifting 32 bit variable bl_pwm

2020-08-18 Thread Colin King
From: Colin Ian King The 32 bit unsigned integer bl_pwm is being shifted using 32 bit arithmetic and then being assigned to a 64 bit unsigned integer. There is a potential for a 32 bit overflow so cast bl_pwm to enforce a 64 bit shift operation to avoid this. Addresses-Coverity: ("unintentional

[PATCH] staging: kpc2000: kpc_dma: fix spelling mistake "for for" -> "for"

2020-08-18 Thread Colin King
From: Colin Ian King There are a couple of duplicated "for" spelling mistakes in dev_err error messages. Fix these. Signed-off-by: Colin Ian King --- drivers/staging/kpc2000/kpc_dma/fileops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dm

[PATCH][next] ath11k: fix spelling mistake "moniter" -> "monitor"

2020-08-19 Thread Colin King
From: Colin Ian King There is a spelling mistake in an ath11k_warn warning message. Fix it. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath11k/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wirel

[PATCH][next] soc: ti: omap-prm: fix spelling mistake "unusupported" -> "unsupported"

2020-08-19 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_warn warning. Fix it. Signed-off-by: Colin Ian King --- drivers/soc/ti/omap_prm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c index 980b04c38fd9..30862fc174ae

[PATCH][next] selinux: fix allocation failure check on newpolicy->sidtab

2020-08-19 Thread Colin King
From: Colin Ian King The allocation check of newpolicy->sidtab is null checking if newpolicy is null and not newpolicy->sidtab. Fix this. Addresses-Coverity: ("Logically dead code") Fixes: c7c556f1e81b ("selinux: refactor changing booleans") Signed-off-by: Colin Ian King --- security/selinux/s

[PATCH][next] ath11k: fix error check on return from call to ath11k_core_firmware_request

2020-08-19 Thread Colin King
From: Colin Ian King The call to ath11k_core_firmware_request is returning a pointer that can be set to an error code, however, this is not being checked. Instead ret is being incorrecly checked for the error return. Fix the error checking. Addresses-Coverity: ("Logically dead code") Fixes: 7b57

[PATCH][next] ath11k: fix missing error check on call to ath11k_pci_get_user_msi_assignment

2020-08-19 Thread Colin King
From: Colin Ian King The return error check on the call to ath11k_pci_get_user_msi_assignment is missing. If an error does occur, num_vectors is still set to zero and later on a division by zero can occur when variable vector is being calculated. Fix this by adding an error check after the call

[PATCH][next] ASoC: qcom: add missing out of memory check on drvdata->clks allocation

2020-08-19 Thread Colin King
From: Colin Ian King Currently drvdata->clks is not being checked for an allocation failure, leading to potential null pointer dereferencing. Fix this by adding a check and returning -ENOMEM if an error occurred. Addresses-Coverity: ("Dereference null return value") Fixes: 1220f6a76e77 ("ASoC: q

[PATCH][next] dm integrity: fix spelling mistake "flusing" -> "flushing"

2021-01-11 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dm_integrity_io_error error message. Fix it. Signed-off-by: Colin Ian King --- drivers/md/dm-integrity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c index 11c7c53

[PATCH][next] drm/amdgpu: Add missing BOOTUP_DEFAULT to profile_name[]

2021-01-11 Thread Colin King
From: Colin Ian King A recent change added a new BOOTUP_DEFAULT power profile mode to the PP_SMC_POWER_PROFILE enum but omitted updating the corresponding profile_name array. Fix this by adding in the missing BOOTUP_DEFAULT to profile_name[]. Addresses-Coverity: ("Out-of-bounds read") Fixes: c2

[PATCH][next] platform/surface: fix potential integer overflow on shift of a int

2021-01-11 Thread Colin King
From: Colin Ian King The left shift of int 32 bit integer constant 1 is evaluated using 32 bit arithmetic and then passed as a 64 bit function argument. In the case where func is 32 or more this can lead to an oveflow. Avoid this by shifting using the BIT_ULL macro instead. Addresses-Coverity:

[PATCH][next] hwmon: ltc2992: fix less than zero comparisons with an unsigned integer

2020-12-07 Thread Colin King
From: Colin Ian King There are several occurrances of a less than zero error check on a u32 unsigned integer. These will never be true. Fix this by making reg_value a plain int. Addresses-Coverity: ("Unsigned comparison against zero") Fixes: e126370240e0 ("hwmon: (ltc2992) Add support") Signed-o

[PATCH][next] seg6: fix unintentional integer overflow on left shift

2020-12-07 Thread Colin King
From: Colin Ian King Shifting the integer value 1 is evaluated using 32-bit arithmetic and then used in an expression that expects a unsigned long value leads to a potential integer overflow. Fix this by using the BIT macro to perform the shift to avoid the overflow. Addresses-Coverity: ("Uninit

[PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink_name

2020-12-07 Thread Colin King
From: Colin Ian King Currently in the case where dev->blk_symlink_name fails to be allocates the error return path attempts to set an end-of-string character to the unallocated dev->blk_symlink_name causing a null pointer dereference error. Fix this by returning with an explicity ENOMEM error (wh

[PATCH][next] drm/mediatek: avoid dereferencing a null hdmi_phy on an error message

2020-12-07 Thread Colin King
From: Colin Ian King Currently there is a null pointer check for hdmi_phy that implies it may be null, however a dev_err messages dereferences this potential null pointer. Avoid a null pointer dereference by only emitting the dev_err message if hdmi_phy is non-null. It is a moot point if the er

[PATCH] arch: fix spelling mistakes in Kconfig

2020-12-07 Thread Colin King
From: Colin Ian King There are a few spelling mistakes in the Kconfig comments and help text. Fix these. Signed-off-by: Colin Ian King --- arch/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/Kconfig b/arch/Kconfig index f7f246e68ff5..a52f8e8d16ad 10064

[PATCH] arch: fix spelling mistakes in Kconfig

2020-12-07 Thread Colin King
From: Colin Ian King There are a few spelling mistakes in the Kconfig comments and help text. Fix these. Signed-off-by: Colin Ian King --- arch/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/Kconfig b/arch/Kconfig index f7f246e68ff5..a52f8e8d16ad 10064

[PATCH] ixp4xx: fix spelling mistake in Kconfig "Devce" -> "Device"

2020-12-07 Thread Colin King
From: Colin Ian King There is spelling mistake in the prompt text in the Kconfig. Fix it. Signed-off-by: Colin Ian King --- arch/arm/mach-ixp4xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index f7211b5

[PATCH] powerpc: fix spelling mistake in Kconfig "seleted" -> "selected"

2020-12-07 Thread Colin King
From: Colin Ian King There is a spelling mistake in the help text of the Kconfig. Fix it. Signed-off-by: Colin Ian King --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 8fb61a285c76..4010bae52351 1006

[PATCH] net: sched: fix spelling mistake in Kconfig "trys" -> "tries"

2020-12-07 Thread Colin King
From: Colin Ian King There is a spelling mistake in the Kconfig help text. Fix it. Signed-off-by: Colin Ian King --- net/nfc/Kconfig | 2 +- net/sched/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/nfc/Kconfig b/net/nfc/Kconfig index 9b27599870e3..96b91674

[PATCH][next] media: i2c: fix spelling mistakes: "enpoint" -> "endpoint"

2021-01-13 Thread Colin King
From: Colin Ian King There are two spelling mistakes in dev_err messages. Fix these. Signed-off-by: Colin Ian King --- drivers/media/i2c/ov5648.c | 2 +- drivers/media/i2c/ov8865.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov5648.c b/drivers/media

[PATCH] soc: qcom: socinfo: Fix off-by-one array index bounds check

2021-01-18 Thread Colin King
From: Colin Ian King There is an off-by-one array index bounds check on array pmic_models. Fix this by checking using < rather than <= on the array size. Addresses-Coverity: ("Out-of-bounds read") Fixes: 734c78e7febf ("soc: qcom: socinfo: add info from PMIC models array") Signed-off-by: Colin Ia

<    5   6   7   8   9   10   11   12   13   14   >