[Vladimir - Sat, Mar 10, 2007 at 04:05:42PM +0300]
| Here's the problem:
| 1. Unpack the kernel sources, run make menuconfig.
| 2. Mark the necessary options.
| 3. Pick Save an alternate configuration file, enter a filename (e.g.
/root/kernelcfg)
| 4. Pick Exit.
| -5. Configurator exits
[Vladimir - Sat, Mar 10, 2007 at 04:05:42PM +0300]
| Here's the problem:
| 1. Unpack the kernel sources, run make menuconfig.
| 2. Mark the necessary options.
| 3. Pick Save an alternate configuration file, enter a filename (e.g.
/root/kernelcfg)
| 4. Pick Exit.
| -5. Configurator exits
[Jan Engelhardt - Sat, Mar 10, 2007 at 05:26:03PM +0100]
|
| On Mar 10 2007 19:06, Cyrill Gorcunov wrote:
| [Vladimir - Sat, Mar 10, 2007 at 04:05:42PM +0300]
| | Here's the problem:
| | 1. Unpack the kernel sources, run make menuconfig.
| | 2. Mark the necessary options.
| | 3. Pick Save
[Jan Engelhardt - Sat, Mar 10, 2007 at 05:50:56PM +0100]
| On Mar 10 2007 19:46, Vladimir wrote:
| On Mar 10 2007 19:06, Cyrill Gorcunov wrote:
| [Vladimir - Sat, Mar 10, 2007 at 04:05:42PM +0300]
| | Here's the problem:
| | 1. Unpack the kernel sources, run make menuconfig.
| | 2. Mark
[Jan Engelhardt - Sat, Mar 10, 2007 at 07:23:41PM +0100]
|
| On Mar 10 2007 20:50, Cyrill Gorcunov wrote:
|
| lets see to the following scenario:
|
| 1) I've taken a pure Linux kernel (no .config at all)
| 2) I started menuconfig, made a few changes and saved the file
[Jan Engelhardt - Sat, Mar 10, 2007 at 08:04:38PM +0100]
|
| On Mar 10 2007 21:50, Cyrill Gorcunov wrote:
|
| Actually, I always work with only .config file too... and the reason I
| wrote you is Vladimir's mail... so either menuconfig does not work as
| expected or users does not expect
[Sam Ravnborg - Sat, Mar 10, 2007 at 11:45:34PM +0100]
| On Sat, Mar 10, 2007 at 10:34:41PM +0100, Jan Engelhardt wrote:
|
| On Mar 10 2007 22:27, Sam Ravnborg wrote:
| On Sat, Mar 10, 2007 at 07:23:41PM +0100, Jan Engelhardt wrote:
|
| Whether the 'working config file path' should change
[Bodo Eggert - Sun, Mar 11, 2007 at 06:21:59AM +0100]
| Sam Ravnborg [EMAIL PROTECTED] wrote:
| On Sat, Mar 10, 2007 at 10:34:41PM +0100, Jan Engelhardt wrote:
| On Mar 10 2007 22:27, Sam Ravnborg wrote:
| On Sat, Mar 10, 2007 at 07:23:41PM +0100, Jan Engelhardt wrote:
|
| Whether the
[Sam Ravnborg - Sat, Mar 10, 2007 at 11:45:34PM +0100]
| On Sat, Mar 10, 2007 at 10:34:41PM +0100, Jan Engelhardt wrote:
|
| On Mar 10 2007 22:27, Sam Ravnborg wrote:
| On Sat, Mar 10, 2007 at 07:23:41PM +0100, Jan Engelhardt wrote:
|
| Whether the 'working config file path' should change
On 3/11/07, Sam Ravnborg [EMAIL PROTECTED] wrote:
[..snip..]
| To make the conversion we should consider renaming from
| current Load alternate to Open config file...
| and likewise Save alternate to Save config file as...
|
| Comments?
|
| Sam
[..snip...]
I think that is
[Sam Ravnborg - Sun, Mar 11, 2007 at 08:50:33PM +0100]
[... snipped ...]
| I would rather avoid adding the extra lines. In the
| 'office-suite' fashion I have cooked up a patch that specify
| the filename as part of the windows title.
|
| To make the conversion we should consider renaming from
On Sat, Feb 17, 2007 at 11:29:19PM +0200, Dan Aloni wrote:
| Hello,
|
| I'm running the x86_64 arch of Linux 2.6.20 on a Supermicro X6DH8-XG2
| board and I got this during boot:
|
| [248660.950695] device id = 2440
| [248660.950699] device id = 2480
| [248660.950703] device id = 24c0
|
No, that's portability bug... Need time for review ;)
Cyrill
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
On Sat, Feb 17, 2007 at 11:29:19PM +0200, Dan Aloni wrote:
| Hello,
|
| I'm running the x86_64 arch of Linux 2.6.20 on a Supermicro X6DH8-XG2
| board and I got this during boot:
|
| [248660.950695] device id = 2440
| [248660.950699] device id = 2480
| [248660.950703] device id = 24c0
|
On Sun, Feb 18, 2007 at 01:29:03PM +0200, Dan Aloni wrote:
| On Sun, Feb 18, 2007 at 01:42:22PM +0300, Cyrill Gorcunov wrote:
| Hi,
|
| here is a patch attached to the mail. You may test it. Actually
| I have no 64bit machine to test it and I'm worried about the
| patch accuracy. So
On Sun, Feb 18, 2007 at 07:49:34PM +0200, Dan Aloni wrote:
| Making window-phys u32 seems like a cleaner fix.
| (untested)
|
| With this fix it still looks somewhat broken:
|
Actually, Dan, I even don't know to do :( May be Andi know...
I think the problem is 'cause pci_read_config_word
On Sun, Feb 18, 2007 at 07:49:34PM +0200, Dan Aloni wrote:
| On Sun, Feb 18, 2007 at 06:13:38PM +0100, Andi Kleen wrote:
| [adding mtd maintainer]
|
| On Sunday 18 February 2007 11:42, Cyrill Gorcunov wrote:
| On Sat, Feb 17, 2007 at 11:29:19PM +0200, Dan Aloni wrote:
| | Hello
Hi, Dan
did you try setup forsed 8MB value on window-phys?
Cyrill
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
This patch prevents from NULL pointer usage if
workqueue creation failed.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
drivers/usb/misc/ftdi-elan.c | 24 +++-
1 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers
[Sam Ravnborg - Sun, Mar 11, 2007 at 08:50:33PM +0100]
| On Sun, Mar 11, 2007 at 01:07:23PM +0300, Cyrill Gorcunov wrote:
| [Sam Ravnborg - Sat, Mar 10, 2007 at 11:45:34PM +0100]
| | On Sat, Mar 10, 2007 at 10:34:41PM +0100, Jan Engelhardt wrote:
| |
| | On Mar 10 2007 22:27, Sam Ravnborg
This patch adds checking for allocated memory. Indents
and spaces are added to be familiar with the kernel
coding style.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/cris/kernel/profile.c | 81 ++--
1 files changed, 48 insertions(+), 33
Hi Ben,
you know the udf_fill_inode() in inode.c does not
check if memory allocation failed:
UDF_I_DATA(inode) = kmalloc(inode-i_sb-s_blocksize -
sizeof(struct extendedFileEntry), GFP_KERNEL);
so the question I have is - what kind of handler there
should be: just exit out from
This patch adds checking for allocated memory
which is used to hold AGP info. Also some whitespace
cleanup.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/alpha/kernel/core_marvel.c | 137 ---
1 files changed, 71 insertions(+), 66 deletions
This patch adds checking for allocated memory
which is used to hold AGP info. Also some whitespace
cleanup.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/alpha/kernel/core_titan.c | 99 +---
1 files changed, 52 insertions(+), 47 deletions
This patch adds checking of driver registration status
and if it fails release allocated resources.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
Pete, please review the patch and Ack it then.
drivers/usb/misc/ftdi-elan.c | 37 +++--
1 files changed
[Luiz Fernando N. Capitulino - Mon, Mar 26, 2007 at 03:43:57PM -0300]
|
| Hi Cyrill,
|
| Em Sun, 25 Mar 2007 11:27:33 +0400
| Cyrill Gorcunov [EMAIL PROTECTED] escreveu:
|
| | This patch adds checking of driver registration status
| | and if it fails release allocated resources
Pete, Luiz
what about this one?
Actually there is just a check for where is error coming from.
Maybe that is not the best solution but it allows us to reduce
the calls to 'printk' :)
P.S. Pete your patch is good but the message about
worqueue creation fail was to print even if we've
been
Hi,
from the function fs/udf/inode.c:udf_fill_inode -
...
UDF_I_DATA(inode) = kmalloc(inode-i_sb-s_blocksize - sizeof(struct
extendedFileEntry), GFP_KERNEL);
memcpy(UDF_I_DATA(inode), bh-b_data + sizeof(struct
extendedFileEntry), inode-i_sb-s_blocksize - sizeof(struct
On Mon, Feb 19, 2007 at 11:16:13PM +0200, Dan Aloni wrote:
| Cyrill Gorcunov wrote:
| Hi, Dan
|
| did you try setup forsed 8MB value on window-phys?
|
|
| Actually, I tried to force it at 4MB starting at 0xff80 since it
| made much sense looking at the e820 map. Or maybe I misunderstood
Btw, Dan
did it work on 32-bit compiled kernel?
Cyrill
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
On Thu, Feb 22, 2007 at 03:55:23PM -0800, Pete Zaitcev wrote:
| On Mon, 19 Feb 2007 21:15:49 +0300, Cyrill Gorcunov [EMAIL PROTECTED] wrote:
|
| +++ b/drivers/usb/misc/ftdi-elan.c
| @@ -57,9 +57,9 @@ module_param(distrust_firmware, bool, 0);
| MODULE_PARM_DESC(distrust_firmware, true
On Thu, Feb 22, 2007 at 11:57:38PM -0800, Pete Zaitcev wrote:
| On Fri, 23 Feb 2007 10:53:22 +0300, Cyrill Gorcunov [EMAIL PROTECTED] wrote:
|
| | -static struct workqueue_struct *status_queue;
| | +static struct workqueue_struct *status_queue = NULL;
|
| | You better drop this part
On Fri, Feb 23, 2007 at 05:43:37PM -0800, Pete Zaitcev wrote:
| On Fri, 23 Feb 2007 11:10:05 +0300, Cyrill Gorcunov [EMAIL PROTECTED] wrote:
|
| I may be wrong, but a lot of the kernel code have static pointers
| initialized to NULL with explicit manner... More over I always thought
This patch prevents from NULL pointer usage if
workqueue creation failed.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
Btw, Pete, you are right! C99 ANSI standart says that static pointer
if it not initialized explicitly has to be set to NULL by compiler ;)
Thanks a lot for comments
On Sat, Feb 24, 2007 at 01:46:44PM +0100, Oleg Verych wrote:
| From: Cyrill Gorcunov
| Newsgroups: gmane.linux.kernel
| Subject: bss zeroing ([PATCH] USB Elan FTDI: check for workqueue creation
v2)
| Date: Sat, 24 Feb 2007 10:41:15 +0300
| []
| Btw, Pete, you are right! C99 ANSI standart
On Mon, Feb 19, 2007 at 11:16:13PM +0200, Dan Aloni wrote:
| Cyrill Gorcunov wrote:
| Hi, Dan
|
| did you try setup forsed 8MB value on window-phys?
|
|
| Actually, I tried to force it at 4MB starting at 0xff80 since it
| made much sense looking at the e820 map. Or maybe I misunderstood
This patch adds checking for closed ROM window
on Intel ESB2 Southbridge.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
I made this patch looking into ichxrom.c from which
ESB2 driver has been derived. So review for the patch
is needed :) Actually a such checking takes a place
[Luiz Fernando N. Capitulino - Tue, Mar 27, 2007 at 01:28:39PM -0300]
| Em Tue, 27 Mar 2007 19:14:05 +0400
| Cyrill Gorcunov [EMAIL PROTECTED] escreveu:
|
| | Pete, Luiz
| |
| | what about this one?
| |
| | Actually there is just a check for where is error coming from.
| | Maybe
[Luiz Fernando N. Capitulino - Tue, Mar 27, 2007 at 02:29:04PM -0300]
| Em Tue, 27 Mar 2007 21:01:25 +0400
| Cyrill Gorcunov [EMAIL PROTECTED] escreveu:
|
| | [Luiz Fernando N. Capitulino - Tue, Mar 27, 2007 at 01:28:39PM -0300]
| | | Em Tue, 27 Mar 2007 19:14:05 +0400
| | | Cyrill Gorcunov
[Pete Zaitcev - Tue, Mar 27, 2007 at 10:51:16AM -0700]
| On Tue, 27 Mar 2007 19:14:05 +0400, Cyrill Gorcunov [EMAIL PROTECTED] wrote:
|
| --- a/drivers/usb/misc/ftdi-elan.c
| @@ -2903,7 +2903,7 @@ static struct usb_driver ftdi_elan_driver = {
| };
| static int __init ftdi_elan_init(void
Pete, Luiz
check this one please.
I've inspected ftdi-elan.c for style and as result
the solution I propose is just to add explicit
destroying of worqueues if usb_register failed.
And Pete, take a look - whoa! - I've renamed error labels :)
Cyrill
---
This patch adds checking of driver registration status
and release allocated resources if it failed.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
Pete, Ack it please
drivers/usb/misc/ftdi-elan.c | 18 +++---
1 files changed, 11 insertions(+), 7 deletions(-)
diff --git
Hi list,
in file mm/slab.c and routine kmem_cache_init() I found there
is no checking for allocated memory on line:
/* 4) Replace the bootstrap head arrays */
{
struct array_cache *ptr;
ptr = kmalloc(sizeof(struct arraycache_init), GFP_KERNEL);
[Pekka Enberg - Fri, Mar 30, 2007 at 02:55:26PM +0300]
| On 3/30/07, Heiko Carstens [EMAIL PROTECTED] wrote:
| in file mm/slab.c and routine kmem_cache_init() I found there
| is no checking for allocated memory on line:
|
|/* 4) Replace the bootstrap head arrays */
|{
|
[Cyrill Gorcunov - Mon, Jan 07, 2008 at 12:44:42AM +0300]
| [Davide Libenzi - Sat, Jan 05, 2008 at 01:35:25PM -0800]
| | On Sat, 5 Jan 2008, Peter Zijlstra wrote:
| |
| [...snip...]
| | I remember I talked with Arjan about this time ago. Basically, since 1)
| | you can drop an epoll fd inside
[Andi Kleen - Tue, Jan 08, 2008 at 05:40:15PM +0100]
|
| Here's a proposal for some useful code transformations the kernel janitors
| could do as opposed to running checkpatch.pl.
|
[...snip...]
| -Andi
|
|
got it, thanks
- Cyrill -
--
To unsubscribe from this list: send the
On Jan 10, 2008 2:37 AM, Paolo Ciarrocchi [EMAIL PROTECTED] wrote:
On 1/10/08, Andi Kleen [EMAIL PROTECTED] wrote:
I'm already cloning the branches; the problem is not getting conflicts etc.
when updating.
Isn't git pull --force what you are looking for?
Ciao,
--
Paolo
This patch converts ioctl call to unlocked_ioctl form with
explicit big-kernel-lock. Also it makes a bit of cleanup
converting miscdevice structure initialization to C99 form.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
Any comments are welcome.
This is untested code - i've no such chip
Thanks, Alexey for review, i'll make it updated tomorrow. (sorry for top-post)
On 1/14/08, Alexey Dobriyan [EMAIL PROTECTED] wrote:
On Sun, Jan 13, 2008 at 11:32:23PM +0300, Cyrill Gorcunov wrote:
This patch converts ioctl call to unlocked_ioctl form with
explicit big-kernel-lock. Also
Thanks Jiri. Will do that all tomorrow.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This patch converts ioctl call to unlocked_ioctl form. It's possible
due to rtl_lock spinlock protection.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
The patch is *not* tested but the patch does not bring _much_ changes
so it wouldn't break the compilation procedure.
If there is problem
[Jiri Slaby - Mon, Jan 14, 2008 at 04:59:22PM +0100]
On 01/14/2008 04:38 PM, Cyrill Gorcunov wrote:
Jiri, I mean rtc_open() is protected by spinlock+status from being
opened simultaneously by a few processes. *But* lets imagine the
following situation - this fd (file descriptor) is opened
[Jiri Slaby - Mon, Jan 14, 2008 at 05:27:00PM +0100]
On 01/14/2008 05:07 PM, Cyrill Gorcunov wrote:
Yes, process would be stopped, and not *just* stopped but could spend
all his cpu time-slice in attempt to get spinlock (espec if set time is
much longer than read), but if we use mutex here
This patch does remove trailing spaces from
source files.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/x86/ia32/fpu32.c | 46 ++--
arch/x86/ia32/ia32_aout.c | 38 +-
arch/x86/ia32/ia32_binfmt.c|2 +-
arch/x86/ia32/ia32_signal.c
() routine. It's possible the compiler is doing
the same but that is much better to remove the dead code explicitly.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/x86/ia32/fpu32.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/x86/ia32/fpu32.c b/arch/x86/ia32
The patch is just an addition to second one. So if you dont like it -
just drop it, if it do conflict with other patches - just drop it.
That simple :) what is the benefit of removing spaces? try to keep
your code clean i've read somwhere...
On 11/13/07, Andi Kleen [EMAIL PROTECTED] wrote:
On
This patch does fix potential NULL pointer dereference
that could take place inside of strcmp() if
of_get_property() call failed.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/powerpc/platforms/83xx/usb.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git
This patch adds usefull macro to iterate over a node childs.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
TODO: convert all for(...) cycles to this macro.
include/linux/of.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/of.h b/include/linux/of.h
Hi Ingo,
i'm quite sorry for annoying you with my stupid question but
i don't know whom to ask about lockdep hashes (you're the
author right?). Ingo look the code has
#define iterate_chain_key(key1, key2) \
(((key1) MAX_LOCKDEP_KEYS_BITS) ^ \
((key1) (64-MAX_LOCKDEP_KEYS_BITS))
tree.
Cyrill
---
From: Cyrill Gorcunov [EMAIL PROTECTED]
Subject: [PATCH] x86: cleanup pda.h to fulfil checkpatch
---
Checkpatch still does complain about
if (0) { T__ tmp__; tmp__ = (val)
I'm not sure if we need this line at all.
include/asm-x86/pda.h | 36
[Ingo Molnar - Mon, Dec 17, 2007 at 05:01:27PM +0100]
|
| * Cyrill Gorcunov [EMAIL PROTECTED] wrote:
|
| Checkpatch still does complain about
| if (0) { T__ tmp__; tmp__ = (val)
| I'm not sure if we need this line at all.
|
| that's a type-checking trick. It does not result in any
This patch does cleanup checkpatch warnings/errors on i387_32.c
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
Ingo this patch is over x86 tree so it could be applied without
hand-works I hope ;)
The old and new i387_32.s (asm listings) were checked with diff to be
identical so it's safe
This patch makes a tiny code cleanup over lockdep.c
according to checkpatch. Nothing serious - space
cleanup, noninline keyword moved in between of
storage class and type.
Signed-Off-By: Cyrill Gorcunov [EMAIL PROTECTED]
---
kernel/lockdep.c | 23 +--
1 files changed, 9
This is a cleanup patch set. It does convert for(...)/while(...) cycles
into appropriate for_each_...() macros calls.
The patch set is splitted up in idea to hold changes localy
to a specified platform.
Any comments are welcome.
Cyrill
-
To unsubscribe from this list: send the
From: Cyrill Gorcunov [EMAIL PROTECTED]
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/powerpc/sysdev/fsl_soc.c |7 +++
arch/powerpc/sysdev/mv64x60_dev.c | 24 ++--
arch/powerpc/sysdev/mv64x60_pci.c |4 ++--
arch/powerpc/sysdev/mv64x60_udbg.c
From: Cyrill Gorcunov [EMAIL PROTECTED]
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/powerpc/kernel/btext.c |2 +-
arch/powerpc/kernel/legacy_serial.c |8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/kernel/btext.c b/arch
From: Cyrill Gorcunov [EMAIL PROTECTED]
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/powerpc/platforms/82xx/pq2.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/82xx/pq2.c
b/arch/powerpc/platforms/82xx/pq2.c
index a497cba
From: Cyrill Gorcunov [EMAIL PROTECTED]
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/powerpc/platforms/celleb/scc_sio.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/celleb/scc_sio.c
b/arch/powerpc/platforms/celleb/scc_sio.c
From: Cyrill Gorcunov [EMAIL PROTECTED]
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/powerpc/platforms/powermac/low_i2c.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/powermac/low_i2c.c
b/arch/powerpc/platforms/powermac
[Udo van den Heuvel - Sat, Dec 01, 2007 at 12:00:53PM +0100]
| Hallo Cyrill,
|
| Cyrill Gorcunov wrote:
| | I made a do while loop doing make bzImage modules and a make clean.
| | Should be OK?
| |
|
| well, test the patch enveloped. if the bug is really heppens then
| BUG message should
[Udo van den Heuvel - Sat, Dec 01, 2007 at 01:47:06PM +0100]
| Cyrill Gorcunov wrote:
| [Udo van den Heuvel - Sat, Dec 01, 2007 at 12:00:53PM +0100]
| | I only had teh bug once, that was the reason for my post.
| | Since then the system has been busy, with intervals, doing kernel
| | compiles
[Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
| Hey.
|
| I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
| fairly confident it's current), and I'm getting an Oops when I try to
| load the iwl3945 driver. I've attached it as plain text.
|
| Hope this helps,
|
|
[Thomas Tuttle - Sun, Dec 02, 2007 at 12:46:01PM -0500]
| On Sun, 2 Dec 2007 19:43:16 +0300, Cyrill Gorcunov
| [EMAIL PROTECTED] said:
| [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
| | Hey.
| |
| | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
| | fairly
On 12/2/07, Thomas Tuttle [EMAIL PROTECTED] wrote:
On Sun, 2 Dec 2007 19:43:16 +0300, Cyrill Gorcunov
[EMAIL PROTECTED] said:
[Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
| Hey.
|
| I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
| fairly confident
This patch does fix missed mutex unlock. Please see it attached.
(Can't send it as a plain text patch - have only IE based mail access)
Cyrill
From: Cyrill Gorcunov [EMAIL PROTECTED]
Date: Mon, 3 Dec 2007 13:36:58 +0300
Subject: [PATCH] NET: mac80211 - fix missed mutex unlock
Signed-off
[Thomas Tuttle - Sun, Dec 02, 2007 at 12:46:01PM -0500]
| On Sun, 2 Dec 2007 19:43:16 +0300, Cyrill Gorcunov
| [EMAIL PROTECTED] said:
| [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
| | Hey.
| |
| | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
| | fairly
This patch does fix inappropriate memory freeing in case
of requested rate_control_ops was not found. In this case
the list head entity is going to be accidently wasted.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
net/mac80211/ieee80211_rate.c |2 +-
1 files changed, 1 insertions
Hi Thomas,
could you test this one please.
---
From: Cyrill Gorcunov [EMAIL PROTECTED]
Subject: [PATCH] iwlwifi3945/4965 - fix rate control algo reference leak
This patch does fix rate control algo reference leak in case
if network device has been failed to register. In this case
special flag
From: Cyrill Gorcunov [EMAIL PROTECTED]
This patch adds checking for possible NULL pointer dereference
if of_find_property() failed.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
I'm not sure about the message being printed in worst case.
Check please.
arch/sparc64/kernel/pci_sun4v.c
This patch does fix missed increment on counter
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
Sorry for that nonstandart patch submission - I've only access
to gmail with Internet Explorer on my work. If that is not OK - will resend
the patch today evening with mutt.
--- a/arc/powerpc
On 11/21/07, Cyrill Gorcunov [EMAIL PROTECTED] wrote:
This patch does fix missed increment on counter
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
Sorry for that nonstandart patch submission - I've only access
to gmail with Internet Explorer on my work. If that is not OK
From: Cyrill Gorcunov [EMAIL PROTECTED]
This patch adds simple increment on device interface counter
(it seems to be accidently missed)
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/powerpc/platforms/pasemi/electra_ide.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
From: Cyrill Gorcunov [EMAIL PROTECTED]
This patch does convert cyclic calls to of_find_compatible_node()
and of_find_node_by_type() into appropriate macroses. It does reduce
code a bit.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
WARNING: I've no PowerPC to test it - please reiew
[Olof Johansson - Thu, Nov 22, 2007 at 09:20:29AM -0600]
| On Wed, Nov 21, 2007 at 01:58:06PM +0300, Cyrill Gorcunov wrote:
| On 11/21/07, Cyrill Gorcunov [EMAIL PROTECTED] wrote:
| This patch does fix missed increment on counter
|
| Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED
From: Cyrill Gorcunov [EMAIL PROTECTED]
This patch does fix possible NULL pointer dereference
inside of strncmp() if of_get_property() failed.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/powerpc/platforms/chrp/setup.c | 23 +--
1 files changed, 13 insertions
On 11/23/07, Stephen Rothwell [EMAIL PROTECTED] wrote:
On Thu, 22 Nov 2007 22:54:23 +0300 Cyrill Gorcunov [EMAIL PROTECTED]
wrote:
This patch does fix possible NULL pointer dereference
inside of strncmp() if of_get_property() failed.
Thanks for this.
static void __init sio_init(void
Here is updated version
---
From: Cyrill Gorcunov [EMAIL PROTECTED]
This patch does fix possible NULL pointer dereference
inside of strncmp() if of_get_property() failed.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
arch/powerpc/platforms/chrp/setup.c | 13 +
1 files
[Udo van den Heuvel - Tue, Nov 27, 2007 at 04:23:05PM +0100]
| Cyrill Gorcunov wrote:
| On 11/24/07, Udo van den Heuvel [EMAIL PROTECTED] wrote:
| Rafael J. Wysocki wrote:
| On Saturday, 24 of November 2007, Udo van den Heuvel wrote:
| Hello,
|
| What happened in the attached messages
On 11/28/07, Michael Ellerman [EMAIL PROTECTED] wrote:
On Mon, 2007-11-26 at 10:46 +0300, Cyrill Gorcunov wrote:
This patch adds checking for NULL value returned to prevent possible
NULL pointer dereference.
Also two unneeded 'return' are removed.
Signed-off-by: Cyrill Gorcunov [EMAIL
On 11/28/07, Cyrill Gorcunov [EMAIL PROTECTED] wrote:
On 11/28/07, Michael Ellerman [EMAIL PROTECTED] wrote:
On Mon, 2007-11-26 at 10:46 +0300, Cyrill Gorcunov wrote:
This patch adds checking for NULL value returned to prevent possible
NULL pointer dereference.
Also two unneeded
on
my work now where I have no Linux machine)
Cyrill
---
From: Cyrill Gorcunov [EMAIL PROTECTED]
Subject: [PATCH] PPC: CELLEB - fix possible NULL pointer dereference
This patch adds checking for NULL returned value to
prevent possible NULL pointer dereference.
Signed-off-by: Cyrill Gorcunov [EMAIL
[Rene Herman - Wed, Dec 12, 2007 at 12:31:18AM +0100]
Good day.
Would some people on x86 (both 32 and 64) be kind enough to compile and run
the attached program? This is about testing how long I/O port access to
port 0x80 takes. It measures in CPU cycles so CPU speed is crucial in
Hi list,
by doing cleanup of arch/x86/boot/*.[ch] i found that
checkpatch does ignore obvious things. For example,
run it over edd.c showed only one warning:
---
[EMAIL PROTECTED] linux-2.6.git $ scripts/checkpatch.pl --file
arch/x86/boot/edd.c
WARNING: externs should be avoided in .c files
On Dec 26, 2007 2:48 AM, H. Peter Anvin [EMAIL PROTECTED] wrote:
Cyrill Gorcunov wrote:
Hi list,
by doing cleanup of arch/x86/boot/*.[ch] i found that
checkpatch does ignore obvious things. For example,
run it over edd.c showed only one warning:
BTW, is there someone who is already
[H. Peter Anvin - Wed, Dec 26, 2007 at 09:44:18AM -0800]
Cyrill Gorcunov wrote:
It's a quite true, sorry for this and thanks for the note. And Peter,
the line I marked
is not to be splitted even having additional spaces over math operators.
Look
orig:
mbr_base = (buf_base+sector_size-1
[Ingo Molnar - Sun, Dec 30, 2007 at 06:22:50PM +0100]
|
| * Cyrill Gorcunov [EMAIL PROTECTED] wrote:
|
| orig:
| mbr_base = (buf_base+sector_size-1) ~(sector_size-1);
| new (could be):
| mbr_base = (buf_base + sector_size - 1) ~(sector_size - 1);
|
| Is a new version that bad?
|
| it's
[Ingo Molnar - Sun, Dec 30, 2007 at 06:22:50PM +0100]
|
| * Cyrill Gorcunov [EMAIL PROTECTED] wrote:
|
| orig:
| mbr_base = (buf_base+sector_size-1) ~(sector_size-1);
| new (could be):
| mbr_base = (buf_base + sector_size - 1) ~(sector_size - 1);
|
| Is a new version that bad?
|
| it's
[H. Peter Anvin - Sun, Dec 30, 2007 at 12:27:15PM -0800]
Cyrill Gorcunov wrote:
Thanks Ingo, you're quite right! Next time i'll appear in list with real
(and hope usefull) patch ;)
Wonderful! I also *really* have to apologize for my short fuse earlier, it
was uncalled for.
-hpa
This patch eliminates most of code-style errors
discovered by checkpatch.pl on arch/x86/kernel/apm_32.c
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
Any comments are welcome
arch/x86/kernel/apm_32.c | 368 +-
1 files changed, 197 insertions
[Ingo Molnar - Tue, Jan 01, 2008 at 04:00:54PM +0100]
|
| * Cyrill Gorcunov [EMAIL PROTECTED] wrote:
|
| This patch eliminates most of code-style errors discovered by
| checkpatch.pl on arch/x86/kernel/apm_32.c
|
| looks good in principle, but the patch is not a NOP:
|
| textdata
1 - 100 of 2647 matches
Mail list logo
