[PATCH] Coccinelle: memdup: Fix typo in warning messages

2018-03-01 Thread Dafna Hirschfeld
Replace 'kmemdep' with 'kmemdup' in warning messages. Signed-off-by: Dafna Hirschfeld <daf...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> --- scripts/coccinelle/api/memdup.cocci | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/co

[PATCH] Coccinelle: memdup: Fix typo in warning messages

2018-03-01 Thread Dafna Hirschfeld
Replace 'kmemdep' with 'kmemdup' in warning messages. Signed-off-by: Dafna Hirschfeld Acked-by: Julia Lawall --- scripts/coccinelle/api/memdup.cocci | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/coccinelle/api/memdup.cocci b/scripts/coccinelle/api

Re: [PATCH v3 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-10-06 Thread Dafna Hirschfeld
Hi, Am 02.10.20 um 19:35 schrieb Ezequiel Garcia: Hi Maxime, Thanks to Dafna, I found the patch ^_^ The driver looks real good. Just a few comments below. Is the driver passing latest v4l2-compliance tests? On Tue, 22 Sep 2020 at 13:55, Maxime Chevallier wrote: Introduce a driver for

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-05 Thread Dafna Hirschfeld
Hi On 22.07.20 17:24, Tomasz Figa wrote: Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: Hi Laurent, On 16.08.19 02:13, Laurent Pinchart wrote: Hello Helen, Thank you for the patch. On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: [snip] +static

Re: [PATCH v3 2/9] media: vimc: Add get_frame callback

2020-10-02 Thread Dafna Hirschfeld
Hi, Am 20.08.20 um 17:36 schrieb Kieran Bingham: Hi Kaaira, On 19/08/2020 19:04, Kaaira Gupta wrote: In the process of making vimc compatible for multiple streams, we need to create a frame passing process such that two different entities can get the frame from a common entity. This isn't

Re: [PATCH v3 3/9] media: vimc: Add usage count to subdevices

2020-10-02 Thread Dafna Hirschfeld
Am 19.08.20 um 20:04 schrieb Kaaira Gupta: From: Niklas Söderlund Prepare for multiple video streams from the same sensor by adding a use counter to vimc_ent_device. The counter is increased for every s_stream(1) and decremented for every s_stream(0) call. The subdevice stream is not

Re: [PATCH v3 4/9] media: vimc: Separate starting stream from pipeline initialisation

2020-10-02 Thread Dafna Hirschfeld
Am 12.09.20 um 12:21 schrieb Kaaira Gupta: On Wed, Sep 02, 2020 at 10:56:46AM +0100, Kieran Bingham wrote: Hi Kaaira, Dafna, On 28/08/2020 21:37, Dafna Hirschfeld wrote: Hi, Am 21.08.20 um 23:01 schrieb Kaaira Gupta: Hi, On Fri, Aug 21, 2020 at 05:11:23PM +0200, Dafna Hirschfeld wrote

Re: [PATCH v3 0/3] media: rockchip: Introduce driver for Rockchip's camera interface

2020-10-02 Thread Dafna Hirschfeld
Am 02.10.20 um 18:31 schrieb Ezequiel Garcia: Hi Maxime, On Tue, 22 Sep 2020 at 13:55, Maxime Chevallier wrote: Hi everyone, This is the third iteration of the series introducing a driver for the PX30 camera interface. This was previously known as the "cif" driver in other iterations,

Re: [PATCH] media: staging: rkisp1: cap: refactor enable/disable stream to allow multistreaming

2020-10-16 Thread Dafna Hirschfeld
Hi, Am 15.10.20 um 21:57 schrieb Helen Koike: Allow streaming from self picture path and main picture path at the same time. Take care for s_stream() callbacks to not be called twice. When starting a stream, s_stream(true) shouldn't be called for the isp and the sensor if the other stream is

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-13 Thread Dafna Hirschfeld
Am 07.08.20 um 18:08 schrieb Dafna Hirschfeld: Hi Am 06.08.20 um 14:22 schrieb Tomasz Figa: On Thu, Aug 6, 2020 at 11:21 AM Dafna Hirschfeld wrote: Am 05.08.20 um 23:10 schrieb Dafna Hirschfeld: Hi On 22.07.20 17:24, Tomasz Figa wrote: Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM

Re: [PATCH] regmap: debugfs: potentially duplicate the name string of the config

2020-09-08 Thread Dafna Hirschfeld
Hi, thank you for the fast review, Am 08.09.20 um 17:35 schrieb Mark Brown: On Tue, Sep 08, 2020 at 05:28:59PM +0200, Dafna Hirschfeld wrote: In function regmap_debugfs_init the name of the regmap_config is assigned in a node of regmap_debugfs_early_list to be used later after regmap

[PATCH] regmap: debugfs: potentially duplicate the name string of the config

2020-09-08 Thread Dafna Hirschfeld
'. This fixes an error "debugfs: Directory 'dummy-' with parent 'regmap' already present!" where the name was freed in function of_syscon_register before it was accessed. Fixes: a52eaeb1898bc (regmap: debugfs: Fix a boot time crash with early regmap init) Signed-off-by: Dafna Hirschfeld --- dr

[PATCH] ASoC: core: Optionaly add the component driver name to the component name

2020-09-10 Thread Dafna Hirschfeld
_name' can receive the name of the component driver and concatenate it to the name of the debugfs directory for the component. Signed-off-by: Dafna Hirschfeld --- sound/soc/soc-core.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/sound/soc/soc-core.c b/sou

Re: [PATCH] media: staging: rkisp1: rsz: make const array static, makes object smaller

2020-10-20 Thread Dafna Hirschfeld
Hi, thanks, Am 20.10.20 um 16:46 schrieb Colin King: From: Colin Ian King Don't populate the const array dev_names on the stack but instead it static. Makes the object code smaller by 15 bytes. Before: text data bss dec hex filename 17091 2648 64

Re: [PATCH] media: staging: rkisp1: rsz: make const array static, makes object smaller

2020-10-20 Thread Dafna Hirschfeld
Am 20.10.20 um 17:29 schrieb David Laight: From: Colin King Sent: 20 October 2020 15:47 From: Colin Ian King Don't populate the const array dev_names on the stack but instead it static. Makes the object code smaller by 15 bytes. Before: text data bss dec hex

Re: [PATCH v2] media: staging: rkisp1: cap: refactor enable/disable stream to allow multistreaming

2020-10-26 Thread Dafna Hirschfeld
* first stream. While when the second is starting, do NOT -* force update because it also update the first one. -* -* The latter case would drop one more buf(that is 2) since -* there's not buf in shadow when the second FE received. This'

Re: [PATCH v2 1/5] docs: automarkup.py: Use new C roles in Sphinx 3

2020-10-30 Thread Dafna Hirschfeld
Hi Am 14.10.20 um 01:13 schrieb Nícolas F. R. A. Prado: While Sphinx 2 used a single c:type role for struct, union, enum and typedef, Sphinx 3 uses a specific role for each one. To keep backward compatibility, detect the Sphinx version and use the correct roles for that version. Signed-off-by:

Re: [PATCH] media: rockchip: rkisp1: Constify static structs

2020-11-20 Thread Dafna Hirschfeld
Am 19.11.20 um 23:18 schrieb Rikard Falkeborn: These 'ops' structs are never modified, so make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn Thanks! Reviewed-by: Dafna Hirschfeld --- drivers/media/platform/rockchip/rkisp1/rkisp1

Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-09-03 Thread Dafna Hirschfeld
Hi, Thank you for working on the patchset. Since there is only one module now, the section in the vimc Documentation regarding module params should be changed: In the file Documentation/media/v4l-drivers/vimc.rst The following text should be removed: ``` You should pass those arguments to each

[PATCH v4 0/2] add imx8mq nitrogen support - changes since v3

2019-08-19 Thread Dafna Hirschfeld
change log: patch 1: no changes patch 2: - gpio-key,wakeup -> source-wakeup - newline between property list and child nodes. - settting pinctrl nodes names to: "pinctrl_xxx: xxxgrp {" Gary Bisson (2): dt-bindings: arm: imx: add imx8mq nitrogen support arm64: dts: imx: Add i.mx8mq nitrogen8m

[PATCH v4 1/2] dt-bindings: arm: imx: add imx8mq nitrogen support

2019-08-19 Thread Dafna Hirschfeld
From: Gary Bisson The Nitrogen8M is an ARM based single board computer (SBC) designed to leverage the full capabilities of NXP’s i.MX8M Quad processor. Signed-off-by: Gary Bisson Signed-off-by: Troy Kisky [Dafna: porting vendor's code to mainline] Signed-off-by: Dafna Hirschfeld

[PATCH v4 2/2] arm64: dts: imx: Add i.mx8mq nitrogen8m basic dts support

2019-08-19 Thread Dafna Hirschfeld
From: Gary Bisson Add basic dts support for i.MX8MQ NITROGEN8M. Signed-off-by: Gary Bisson Signed-off-by: Troy Kisky [Dafna: porting vendor's code to mainline] Signed-off-by: Dafna Hirschfeld --- arch/arm64/boot/dts/freescale/Makefile| 1 + .../boot/dts/freescale/imx8mq

Re: [PATCH v4 1/2] dt-bindings: arm: imx: add imx8mq nitrogen support

2019-08-20 Thread Dafna Hirschfeld
On Mon, 2019-08-19 at 14:08 -0500, Rob Herring wrote: > On Mon, Aug 19, 2019 at 12:26 PM Dafna Hirschfeld > wrote: > > From: Gary Bisson > > > > The Nitrogen8M is an ARM based single board computer (SBC) > > designed to leverage the full capabilities of N

[PATCH 2/2] arm64: dts: imx: Add i.mx8mq nitrogen8m basic dts support

2019-07-24 Thread Dafna Hirschfeld
From: dafna Add basic dts support for i.MX8MQ NITROGEN8M. Signed-off-by: Gary Bisson Signed-off-by: Dafna Hirschfeld --- arch/arm64/boot/dts/freescale/Makefile | 1 + .../arm64/boot/dts/freescale/imx8mq-nitrogen8m.dts | 411 + 2 files changed, 412 insertions

[PATCH 1/2] dt-bindings: arm: imx: add imx8mq nitrogen support

2019-07-24 Thread Dafna Hirschfeld
i.MX 8Quad is a quad (4x) Cortex-A53 processor with powerful graphic and multimedia features. This patch adds Nitrogen8M board support. Signed-off-by: Gary Bisson Signed-off-by: Dafna Hirschfeld --- Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++ 1 file changed, 6 insertions

Re: [PATCH] MAINTAINERS: add Dafna Hirschfeld for rkisp1

2020-08-25 Thread Dafna Hirschfeld
Am 25.08.20 um 15:22 schrieb Helen Koike: Add Dafna Hirschfeld to rkisp1 maintainers list Signed-off-by: Helen Koike --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index deaafb617361c..3deb954b2bb5d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH v3 4/9] media: vimc: Separate starting stream from pipeline initialisation

2020-08-21 Thread Dafna Hirschfeld
Am 19.08.20 um 20:04 schrieb Kaaira Gupta: Separate the process of initialising pipeline array from starting streaming for all entities in path of a stream. This is needed because multiple streams can stream, but only one pipeline object is needed. Process frames only for those entities in a

[PATCH] arm64: dts: mt8173-elm: fix supported values for regulator-allowed-modes of da9211

2020-09-03 Thread Dafna Hirschfeld
: add mt8173 elm and hana board") Signed-off-by: Dafna Hirschfeld --- arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi index 1f

[PATCH] media: mtk-mdp: Fix Null pointer dereference when calling list_add

2020-08-28 Thread Dafna Hirschfeld
76fee0203f9898e5 ]--- Fixes: 86698b9505bbc ("media: mtk-mdp: convert mtk_mdp_dev.comp array to list") Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp

Re: [PATCH v3 4/9] media: vimc: Separate starting stream from pipeline initialisation

2020-08-28 Thread Dafna Hirschfeld
Hi, Am 21.08.20 um 23:01 schrieb Kaaira Gupta: Hi, On Fri, Aug 21, 2020 at 05:11:23PM +0200, Dafna Hirschfeld wrote: Am 19.08.20 um 20:04 schrieb Kaaira Gupta: Separate the process of initialising pipeline array from starting streaming for all entities in path of a stream. This is needed

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-06 Thread Dafna Hirschfeld
Am 05.08.20 um 23:10 schrieb Dafna Hirschfeld: Hi On 22.07.20 17:24, Tomasz Figa wrote: Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: Hi Laurent, On 16.08.19 02:13, Laurent Pinchart wrote: Hello Helen, Thank you for the patch. On Tue, Jul 30, 2019 at 03

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-07 Thread Dafna Hirschfeld
Hi, Am 06.08.20 um 14:08 schrieb Tomasz Figa: On Wed, Aug 5, 2020 at 11:10 PM Dafna Hirschfeld wrote: Hi On 22.07.20 17:24, Tomasz Figa wrote: Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: Hi Laurent, On 16.08.19 02:13, Laurent Pinchart wrote: Hello Helen

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-07 Thread Dafna Hirschfeld
Hi Am 06.08.20 um 14:22 schrieb Tomasz Figa: On Thu, Aug 6, 2020 at 11:21 AM Dafna Hirschfeld wrote: Am 05.08.20 um 23:10 schrieb Dafna Hirschfeld: Hi On 22.07.20 17:24, Tomasz Figa wrote: Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: Hi Laurent

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Dafna Hirschfeld
On 01.06.20 14:16, Kaaira Gupta wrote: On Fri, May 29, 2020 at 05:43:57PM +0200, Dafna Hirschfeld wrote: Hi, Thanks for the patch I don't know how real devices handle ARGB formats, I wonder if it should be the part of the debayer. Hi! qcam tries to support BA24 as it is one of the formats

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Dafna Hirschfeld
On 02.06.20 14:45, Laurent Pinchart wrote: Hello, On Tue, Jun 02, 2020 at 08:31:26AM -0300, Helen Koike wrote: On 6/2/20 8:24 AM, Kieran Bingham wrote: On 02/06/2020 11:55, Helen Koike wrote: On 6/2/20 7:52 AM, Dafna Hirschfeld wrote: On 01.06.20 14:16, Kaaira Gupta wrote: On Fri, May

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-05-29 Thread Dafna Hirschfeld
Hi, Thanks for the patch I don't know how real devices handle ARGB formats, I wonder if it should be the part of the debayer. On 28.05.20 20:57, Kaaira Gupta wrote: Running qcam for pixelformat 0x34324142 showed that vimc debayer does not support it. Hence, add the support for Alpha (255).

[PATCH v2 2/2] arm64: dts: imx: Add i.mx8mq nitrogen8m basic dts support

2019-07-25 Thread Dafna Hirschfeld
From: Gary Bisson Add basic dts support for i.MX8MQ NITROGEN8M. Signed-off-by: Gary Bisson Signed-off-by: Troy Kisky [Dafna: porting vendor's code to mainline] Signed-off-by: Dafna Hirschfeld --- arch/arm64/boot/dts/freescale/Makefile| 1 + .../boot/dts/freescale/imx8mq

[PATCH v2 1/2] dt-bindings: arm: imx: add imx8mq nitrogen support

2019-07-25 Thread Dafna Hirschfeld
From: Gary Bisson i.MX 8Quad is a quad (4x) Cortex-A53 processor with powerful graphic and multimedia features. This patch adds Nitrogen8M board support. Signed-off-by: Gary Bisson Signed-off-by: Troy Kisky [Dafna: porting vendor's code to mainline] Signed-off-by: Dafna Hirschfeld

[PATCH v3 1/2] dt-bindings: arm: imx: add imx8mq nitrogen support

2019-08-13 Thread Dafna Hirschfeld
From: Gary Bisson The Nitrogen8M is an ARM based single board computer (SBC) designed to leverage the full capabilities of NXP’s i.MX8M Quad processor. Signed-off-by: Gary Bisson Signed-off-by: Troy Kisky [Dafna: porting vendor's code to mainline] Signed-off-by: Dafna Hirschfeld

[PATCH v3 2/2] arm64: dts: imx: Add i.mx8mq nitrogen8m basic dts support

2019-08-13 Thread Dafna Hirschfeld
From: Gary Bisson Add basic dts support for i.MX8MQ NITROGEN8M. Signed-off-by: Gary Bisson Signed-off-by: Troy Kisky [Dafna: porting vendor's code to mainline] Signed-off-by: Dafna Hirschfeld --- arch/arm64/boot/dts/freescale/Makefile| 1 + .../boot/dts/freescale/imx8mq

Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-08-27 Thread Dafna Hirschfeld
On Tue, 2019-08-20 at 15:18 -0600, Shuah Khan wrote: > vimc uses Component API to split the driver into functional components. > The real hardware resembles a monolith structure than component and > component structure added a level of complexity making it hard to > maintain without adding any

Re: [PATCH] media: vimc: add configfs API to configure the topology

2019-08-10 Thread Dafna Hirschfeld
Hi, I will continue working on this patch that Helen started. Regarding the requirements, if an entity is removed, should all the links related to it also be removed? Also, should it be possible to create a link with entities that do not exist? The reason to keep links between non existing

Re: [PATCH v3 3/3] media: vimc: deb: Add support for {RGB,BGR,GBR}888 bus formats on source pad

2020-04-28 Thread Dafna Hirschfeld
hi, Thanks for the patches! On 28.04.20 01:03, Nícolas F. R. A. Prado wrote: Add support for RGB888_*, BGR888_* and GBR888_* media bus formats on the source pad of debayer subdevices. Co-developed-by: Vitor Massaru Iha Signed-off-by: Vitor Massaru Iha Signed-off-by: Nícolas F. R. A. Prado

Re: [PATCH v2] media: vimc: fla: Add virtual flash subdevice

2019-09-24 Thread Dafna Hirschfeld
Hi, On Sun, 2019-09-15 at 15:44 -0300, Lucas A. M. Magalhães wrote: > From: Lucas A. M. Magalhaes > > Add a virtual subdevice to simulate the flash control API. > Those are the supported controls: > v4l2-ctl -d /dev/v4l-subdev6 -L > Flash Controls > >led_mode 0x009c0901

Re: [PATCH v2] media: vimc: Enable set resolution at the scaler src pad

2019-09-24 Thread Dafna Hirschfeld
Hi, On Sun, 2019-09-15 at 18:35 -0300, Pedro Terra wrote: > Modify the scaler subdevice to accept setting the resolution of the source > pad (previously the source resolution would always be 3 times the sink for > both dimensions). Now any resolution can be set at src (even smaller ones) > and

Re: [PATCH v2 0/3] media: vimc: Allow multiple capture devices to use the same sensor

2020-07-28 Thread Dafna Hirschfeld
Hi On 28.07.20 13:39, Kaaira Gupta wrote: On Mon, Jul 27, 2020 at 02:54:30PM -0300, Helen Koike wrote: Hi, On 7/27/20 11:31 AM, Kieran Bingham wrote: Hi all, +Dafna for the thread discussion, as she's missed from the to/cc list. On 24/07/2020 13:21, Kaaira Gupta wrote: On Fri, Jul 24,

Re: [PATCH v2 3/3] media: vimc: Join pipeline if one already exists

2020-07-28 Thread Dafna Hirschfeld
On 24.07.20 14:02, Kaaira Gupta wrote: An output which is running is already part of a pipeline and trying to start a new pipeline is not possible. This prevents two capture devices from streaming at the same time. Instead of failing to start the second capture device allow it to join the

Re: [PATCH v2 0/3] media: vimc: Allow multiple capture devices to use the same sensor

2020-07-28 Thread Dafna Hirschfeld
On 28.07.20 14:07, Dafna Hirschfeld wrote: Hi On 28.07.20 13:39, Kaaira Gupta wrote: On Mon, Jul 27, 2020 at 02:54:30PM -0300, Helen Koike wrote: Hi, On 7/27/20 11:31 AM, Kieran Bingham wrote: Hi all, +Dafna for the thread discussion, as she's missed from the to/cc list. On 24/07/2020

Re: [PATCH v2 0/3] media: vimc: Allow multiple capture devices to use the same sensor

2020-07-29 Thread Dafna Hirschfeld
On 29.07.20 15:05, Kieran Bingham wrote: Hi Dafna, On 28/07/2020 15:00, Dafna Hirschfeld wrote: On 28.07.20 14:07, Dafna Hirschfeld wrote: Hi On 28.07.20 13:39, Kaaira Gupta wrote: On Mon, Jul 27, 2020 at 02:54:30PM -0300, Helen Koike wrote: Hi, On 7/27/20 11:31 AM, Kieran Bingham

Re: [PATCH v2 0/3] media: vimc: Allow multiple capture devices to use the same sensor

2020-07-29 Thread Dafna Hirschfeld
On 29.07.20 15:27, Kieran Bingham wrote: Hi Dafna, Kaaira, On 29/07/2020 14:16, Dafna Hirschfeld wrote: On 29.07.20 15:05, Kieran Bingham wrote: Hi Dafna, On 28/07/2020 15:00, Dafna Hirschfeld wrote: On 28.07.20 14:07, Dafna Hirschfeld wrote: Hi On 28.07.20 13:39, Kaaira Gupta

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-07-17 Thread Dafna Hirschfeld
Hi, On 11.07.20 13:04, Dafna Hirschfeld wrote: Hi Laurent, On 16.08.19 02:13, Laurent Pinchart wrote: Hello Helen, Thank you for the patch. On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: From: Jacob Chen Add the subdev driver for rockchip isp1. Signed-off-by: Jacob Chen

Re: [PATCH v7 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-07-05 Thread Dafna Hirschfeld
On Wed, Jul 3, 2019 at 9:11 PM Helen Koike wrote: > > From: Jacob Chen > > Add the subdev driver for rockchip isp1. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong Zhong > Signed-off-by: Jacob Chen > Signed-off-by: Eddie Cai > Signed-off-by: Jeffy Chen

Re: [PATCH v2 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-07-09 Thread Dafna Hirschfeld
hi, On 29.05.20 15:04, Maxime Chevallier wrote: Introduce a driver for the camera interface on some Rockchip platforms. This controller supports CSI2, Parallel and BT656 interfaces, but for now only the parallel interface could be tested, hence it's the only one that's supported in the first

Re: [PATCH v8 03/14] media: rkisp1: Add user space ABI definitions

2020-07-10 Thread Dafna Hirschfeld
On 15.08.19 20:46, Laurent Pinchart wrote: Hi Helen, Thank you ofor the patch. On Tue, Jul 30, 2019 at 03:42:45PM -0300, Helen Koike wrote: From: Jeffy Chen Add the header for userspace Signed-off-by: Jeffy Chen Signed-off-by: Jacob Chen [update for upstream] Signed-off-by: Helen

Re: [PATCH v8 03/14] media: rkisp1: Add user space ABI definitions

2020-07-10 Thread Dafna Hirschfeld
On 10.07.20 15:36, Laurent Pinchart wrote: Hi Dafna, On Fri, Jul 10, 2020 at 02:59:36PM +0200, Dafna Hirschfeld wrote: On 15.08.19 20:46, Laurent Pinchart wrote: On Tue, Jul 30, 2019 at 03:42:45PM -0300, Helen Koike wrote: From: Jeffy Chen Add the header for userspace Signed-off

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-07-11 Thread Dafna Hirschfeld
Hi Laurent, On 16.08.19 02:13, Laurent Pinchart wrote: Hello Helen, Thank you for the patch. On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: From: Jacob Chen Add the subdev driver for rockchip isp1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by:

Re: [PATCH v3 2/2] media: vimc: Add a control to display info on test image

2020-06-22 Thread Dafna Hirschfeld
On 21.06.20 22:32, Kaaira Gupta wrote: On Sat, Jun 20, 2020 at 12:05:28PM +0200, Dafna Hirschfeld wrote: Hi, thanks for the patch On 18.06.20 21:05, Kaaira Gupta wrote: Add a control in VIMC to display information such as the correct oder of colors for a given test pattern, brightness, hue

Re: [PATCH v3 2/2] media: vimc: Add a control to display info on test image

2020-06-20 Thread Dafna Hirschfeld
Hi, thanks for the patch On 18.06.20 21:05, Kaaira Gupta wrote: Add a control in VIMC to display information such as the correct oder of colors for a given test pattern, brightness, hue, saturation, contrast and, width and height at sensor over test image; and display that information.

Re: [PATCH v3 2/4] media: v4l2-common: add helper functions to call s_stream() callbacks

2020-05-21 Thread Dafna Hirschfeld
Hi On 15.04.20 03:30, Helen Koike wrote: Add v4l2_pipeline_stream_{enable,disable} helper functions to iterate through the subdevices in a given stream (i.e following links from sink to source) and call .s_stream() callback. Add stream_count on the subdevice object for simultaneous streaming

Re: [RFC PATCH] vimc: Add colors' order over test image

2020-06-08 Thread Dafna Hirschfeld
Hi, On 07.06.20 15:53, Kaaira Gupta wrote: Currently there is no method to know if the test image generated by vimc is correct (except for comparing it with a known 'correct' image). Add text over the test image, representing the correct order of colors. I have sent it as an RFC because we can

Re: [PATCH AUTOSEL 5.10 14/36] media: rkisp1: uapi: change hist_bins array type from __u16 to __u32

2021-02-09 Thread Dafna Hirschfeld
Am 08.02.21 um 21:46 schrieb Hans Verkuil: On 08/02/2021 18:57, Sasha Levin wrote: From: Dafna Hirschfeld [ Upstream commit 31f190e0ccac8b75d33fdc95a797c526cf9b149e ] Each entry in the array is a 20 bits value composed of 16 bits unsigned integer and 4 bits fractional part. So the type

Re: [RFC PATCH v6 01/11] media: v4l2-common: add normalized pixelformat field to struct v4l2_format_info

2021-02-10 Thread Dafna Hirschfeld
Hi! Am 14.01.21 um 19:07 schrieb Helen Koike: Add normalization to pixelformats, so we can fallback to it when using Ext API, and eliminating the handling of two variantes (M and non-M formats). Signed-off-by: Helen Koike --- Changes in v6: - New patch ---

Re: [RFC PATCH v6 02/11] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2021-02-10 Thread Dafna Hirschfeld
Hi, Am 14.01.21 um 19:07 schrieb Helen Koike: This is part of the multiplanar and singleplanar unification process. v4l2_ext_pix_format is supposed to work for both cases. We also add the concept of modifiers already employed in DRM to expose HW-specific formats (like tiled or compressed

[PATCH] MAINTAINERS: Add linux-mediatek ML for drm Mediatek drivers

2021-03-25 Thread Dafna Hirschfeld
Add the linux-mediatek mailing list to drm Mediatek drivers Signed-off-by: Dafna Hirschfeld --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e876927c60d..8260bc5afe66 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5963,6 +5963,7 @@ DRM DRIVERS

Re: [PATCH v2 2/3] drm/mediatek: Don't support hdmi connector creation

2021-03-30 Thread Dafna Hirschfeld
Hi, On 30.03.21 02:08, Laurent Pinchart wrote: Hi Dafna, Thank you for the patch. On Mon, Mar 29, 2021 at 05:36:31PM +0200, Dafna Hirschfeld wrote: commit f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") broke the display support for elm device since mtk

[PATCH v3 2/2] drm/mediatek: Don't support hdmi connector creation

2021-03-30 Thread Dafna Hirschfeld
eation optional") But with the difference that in mtk-hdmi only the option of not creating a connector is supported. Fixes: f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") Signed-off-by: Dafna Hirschfeld Reviewed-by: Laurent Pinchart --- drivers/gpu

[PATCH v3 0/2] drm/mediatek: Don't support hdmi connector creation

2021-03-30 Thread Dafna Hirschfeld
atch - now the first patch only moves the bridge ops to the atomic API while the replacement of the field 'conn' with the field '*curr_conn' is done in a new third patch. 2. in the function 'get_eld' use the current conn only if 'enabled = true'. Dafna Hirschfeld (2): drm/mediatek: Switch the hdmi

[PATCH v3 1/2] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-30 Thread Dafna Hirschfeld
rom the state. This patch switches the bridge to the atomic version to prepare access to the connector in later patches. Signed-off-by: Dafna Hirschfeld Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 23 +++ 1 file changed, 15 insertions(+), 8 deleti

[PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-03-30 Thread Dafna Hirschfeld
drm_bridge_funcs has a function called 'hpd_notify'. The function drm_bridge_hpd_notify does not call 'hpd_notify' but it calls 'hpd_cb'. This is rather confusing. Rename the function to fix this confusion. Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

[PATCH v2 2/3] drm/mediatek: Don't support hdmi connector creation

2021-03-29 Thread Dafna Hirschfeld
.c: commit ec971aaa6775 ("drm: bridge: dw-hdmi: Make connector creation optional") But with the difference that in mtk-hdmi only the option of not creating a connector is supported. Fixes: f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") Signed-off-by: Dafna Hi

[PATCH v2 1/3] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-29 Thread Dafna Hirschfeld
rom the state. This patch switches the bridge to the atomic version to prepare access to the connector in later patches. Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/

[PATCH v2 0/3] drm/mediatek: Don't support hdmi connector creation

2021-03-29 Thread Dafna Hirschfeld
e function 'get_eld' use the current conn only if 'enabled = true'. Dafna Hirschfeld (3): drm/mediatek: Switch the hdmi bridge ops to the atomic versions drm/mediatek: Don't support hdmi connector creation drm/mediatek: in struct mtk_hdmi, replace conn field with curr_conn ptr drivers/gpu/dr

[PATCH v2 3/3] drm/mediatek: in struct mtk_hdmi, replace conn field with curr_conn ptr

2021-03-29 Thread Dafna Hirschfeld
The mtk_hdmi does not support creating a bridge with a connector. Therefore the field 'conn' should be removed from the mtk_hdmi struct. It is replaced with a pointer curr_conn that points to the current connector which can be access through the global state. Signed-off-by: Dafna Hirschfeld

Re: [PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-04-07 Thread Dafna Hirschfeld
Hi On 06.04.21 14:40, Laurent Pinchart wrote: Hi Dafna, Thank you for the patch. On Tue, Mar 30, 2021 at 01:52:00PM +0200, Dafna Hirschfeld wrote: drm_bridge_funcs has a function called 'hpd_notify'. The function drm_bridge_hpd_notify does not call 'hpd_notify' but it calls 'hpd_cb

Re: [PATCH] media: rkisp1: rksip1-capture.c: Improve comments and fix typos

2021-04-20 Thread Dafna Hirschfeld
there should be a description for the abbreviation FE, as it is not described anywhere. I think it means frame end, right?. yes, this is Frame End. You can send a patch replacing "FE" with frame end if you like. Reviewed-by: Dafna Hirschfeld --- .../platform/rockchip/rkisp1/rkisp1-capture

Re: [PATCH] media: rkisp1: rkisp1-params.c: Fix typos

2021-04-20 Thread Dafna Hirschfeld
Hi, On 19.04.21 08:02, Sebastian Fricke wrote: s/when the camera active/when the camera is active/ s/thus not isr protection/thus no ISR protection/ Signed-off-by: Sebastian Fricke --- drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2] iommu/mediatek: always enable the clk on resume

2021-04-16 Thread Dafna Hirschfeld
it is already enabled by the resume. Fixes: c0b57581b73b ("iommu/mediatek: Add power-domain operation") Signed-off-by: Dafna Hirschfeld Reviewed-by: Yong Wu --- Chagnes since v1: remove the word 'commit' from 'Fixes' tag drivers/iommu/mtk_iommu.c | 19 --- 1 file

Re: [PATCH] iommu/mediatek: always enable the clk on resume

2021-04-16 Thread Dafna Hirschfeld
Hi, I sent v2, removing the word 'comment' from the 'Fixes' tag after a problem report from Stephen Rothwell, could you replace v1 with v2? Thanks, Dafna On 15.04.21 15:34, Joerg Roedel wrote: On Thu, Apr 08, 2021 at 02:28:42PM +0200, Dafna Hirschfeld wrote: drivers/iommu/mtk_iommu.c | 19

[PATCH] iommu/mediatek: always enable the clk on resume

2021-04-08 Thread Dafna Hirschfeld
it is already enabled by the resume. Fixes: commit c0b57581b73b ("iommu/mediatek: Add power-domain operation") Signed-off-by: Dafna Hirschfeld --- drivers/iommu/mtk_iommu.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/iommu/mtk

Re: linux-next: Fixes tag needs some work in the iommu tree

2021-04-16 Thread Dafna Hirschfeld
On 15.04.21 23:51, Stephen Rothwell wrote: Hi all, In commit af5247b169a0 ("iommu/mediatek: Always enable the clk on resume") Fixes tag Fixes: commit c0b57581b73b ("iommu/mediatek: Add power-domain operation") has these problem(s): - leading word 'commit' unexpected Hi, I'll