Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input controller

2015-10-22 Thread Damien Horsley
On 19/10/15 18:47, Mark Brown wrote: > On Mon, Oct 12, 2015 at 01:40:29PM +0100, Damien Horsley wrote: > >> +static inline u32 img_i2s_in_ch_disable(struct img_i2s_in *i2s, u32 chan) >> +{ >> +u32 reg; >> + >> +reg = img_i2s_in_ch_readl(i2s, c

Re: [alsa-devel] [PATCH V2 03/10] ASoC: img: Add binding document for I2S output controller

2015-10-22 Thread Damien Horsley
On 19/10/15 18:56, Mark Brown wrote: > On Mon, Oct 12, 2015 at 01:40:30PM +0100, Damien Horsley wrote: > >> +Optional Properties: > >> + - interrupts : Contains the I2S out interrupts. Depending on >> +the configuration, there may be no interrupts, one interrupt,

Re: [alsa-devel] [PATCH V2 06/10] ASoC: img: Add driver for parallel output controller

2015-10-22 Thread Damien Horsley
On 19/10/15 19:07, Mark Brown wrote: > On Mon, Oct 12, 2015 at 01:40:33PM +0100, Damien Horsley wrote: > >> +spin_lock_irqsave(&prl->lock, flags); >> +reg = img_prl_out_readl(prl, IMG_PRL_OUT_CTL); >> +ucontrol->value.integer.value[0] =

Re: [alsa-devel] [PATCH V2 08/10] ASoC: img: Add driver for SPDIF input controller

2015-10-22 Thread Damien Horsley
On 19/10/15 19:27, Mark Brown wrote: > On Mon, Oct 12, 2015 at 01:40:35PM +0100, Damien Horsley wrote: > >> +static int img_spdif_in_get_lock_acquire(struct snd_kcontrol *kcontrol, >> + struct snd_ctl_elem_value *ucontrol) >> +{ >> +

Re: [PATCH] dma: mdc: Correct terminate_all handling

2015-12-07 Thread Damien Horsley
On 05/12/15 08:43, Vinod Koul wrote: > On Mon, Nov 23, 2015 at 02:22:04PM +0000, Damien Horsley wrote: >> From: "Damien.Horsley" >> >> Use of the CANCEL bit in mdc_terminate_all creates an >> additional 'command done' to appear in the registers (in

Re: [alsa-devel] [PATCH 2/2] ASoC: pcm3168a: Add driver for pcm3168a codec

2015-11-30 Thread Damien Horsley
On 27/11/15 12:54, Mark Brown wrote: > On Tue, Nov 24, 2015 at 02:43:44PM +0000, Damien Horsley wrote: >> From: "Damien.Horsley" >> >> Add driver for Texas Instruments pcm3168a codec > > Please try to keep your CC lists reasonable - only CC people who h

Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC

2015-12-08 Thread Damien Horsley
On 25/11/15 12:47, Mark Brown wrote: > On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote: > >> +/* The mute state as set by alsa using the digital_mute callback */ >> +bool alsa_mute_state; >> +/* The mute state as set by the userspace mute

Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input controller

2015-10-27 Thread Damien Horsley
On 23/10/15 23:57, Mark Brown wrote: > On Thu, Oct 22, 2015 at 08:09:38PM +0100, Damien Horsley wrote: >> On 19/10/15 18:47, Mark Brown wrote: >>> On Mon, Oct 12, 2015 at 01:40:29PM +0100, Damien Horsley wrote: > >>> The APIs here all seem a bit odd - for e

Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input controller

2015-10-28 Thread Damien Horsley
On 28/10/15 01:04, Mark Brown wrote: > On Tue, Oct 27, 2015 at 01:55:27PM +0000, Damien Horsley wrote: >> On 23/10/15 23:57, Mark Brown wrote: > >>> Shouldn't we be doing that flush on stream close instead? If nothing >>> else the flush is going to discard

Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input controller

2015-10-29 Thread Damien Horsley
On 28/10/15 23:43, Mark Brown wrote: > On Wed, Oct 28, 2015 at 09:18:20PM +0000, Damien Horsley wrote: >> On 28/10/15 01:04, Mark Brown wrote: > >>>> I think it also makes sense to keep the blocks consistent with each >>>> other. The spdif (out and in), and p

Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio card

2016-01-28 Thread Damien Horsley
On 27/01/16 20:14, Mark Brown wrote: > On Wed, Jan 27, 2016 at 05:13:09PM +0000, Damien Horsley wrote: > >> audio_pll is referenced exclusively by the card device > > That one *may* be plausible. > >> i2s_mclk and dac_mclk can also be referenced by other devices

Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio card

2016-01-27 Thread Damien Horsley
On 27/01/16 14:57, Mark Brown wrote: > On Tue, Jan 26, 2016 at 02:34:26PM +0000, Damien Horsley wrote: > >> + - clock-names : Includes the following entries: >> +"audio_pll" The audio PLL >> +"i2s_mclk" The i2s reference cloc

Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio card

2016-01-27 Thread Damien Horsley
On 27/01/16 16:00, Mark Brown wrote: > On Wed, Jan 27, 2016 at 03:18:20PM +0000, Damien Horsley wrote: >> On 27/01/16 14:57, Mark Brown wrote: >>> On Tue, Jan 26, 2016 at 02:34:26PM +0000, Damien Horsley wrote: > >>>> + - clock-names : Includes the following