Re: [PATCH 1/3] zpool: extend API to match zsmalloc

ond retrieves the number of pages migrated due to compaction for > the whole time of this pool's existence and the third one returns > the huge class size. > > This API extension is done to align zpool API with zsmalloc API. > > Signed-off-by: Vitaly Wool Seems reasonable to me. Rev

Re: [PATCH] zswap: allow setting default status, compressor and allocator in Kconfig

On Fri, Oct 11, 2019 at 7:40 PM Maciej S. Szmigiero wrote: > > The compressed cache for swap pages (zswap) currently needs from 1 to 3 > extra kernel command line parameters in order to make it work: it has to be > enabled by adding a "zswap.enabled=1" command line parameter and if one > wants a

Re: [RFC v4] zswap: Add CONFIG_ZSWAP_IO_SWITCH to handle swap IO issue

On Tue, Oct 8, 2019 at 4:07 AM Hui Zhu wrote: > > This is the fourth version of this patch. The perious versions > are in [1], [2] and [3]. > > The parameters read_in_flight_limit and write_in_flight_limit were > replaced by io_switch_enabled_enabled in this verion to make this > function more

Re: [PATCH] powerpc/vio: use simple dummy struct device as bus parent

On Fri, Sep 27, 2019 at 2:19 PM Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 09:04:02AM -0400, Dan Streetman wrote: > > The dummy vio_bus_device creates the /sys/devices/vio directory, which > > contains real vio devices under it; since it represents itself a

Re: [PATCH] powerpc/vio: use simple dummy struct device as bus parent

On Sat, Sep 28, 2019 at 3:41 AM Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 03:48:49PM -0400, Dan Streetman wrote: > > On Fri, Sep 27, 2019 at 2:19 PM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Sep 27, 2019 at 09:04:02AM -0400, Da

Re: [PATCH] powerpc/vio: use simple dummy struct device as bus parent

On Fri, Sep 27, 2019 at 2:19 PM Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 09:04:02AM -0400, Dan Streetman wrote: > > The dummy vio_bus_device creates the /sys/devices/vio directory, which > > contains real vio devices under it; since it represents itself a

[PATCH] powerpc/vio: use simple dummy struct device as bus parent

in udevadm to ignore ENODEV errors, but the vio driver should still be fixed. This patch changes the arch/powerpc/platform/pseries/vio.c 'dummy' parent device into a real dummy device with no .bus, so its uevent file will stop returning ENODEV and simply do nothing and return 0. Signed-off-by: Dan

Re: [RFC v3] zswap: Add CONFIG_ZSWAP_IO_SWITCH to handle swap IO issue

On Mon, Sep 23, 2019 at 4:14 PM Dan Streetman wrote: > > On Sun, Sep 22, 2019 at 11:32 PM Hui Zhu wrote: > > > > This is the third version of this patch. The first and second version > > is in [1] and [2]. > > This verion is updated according to the commen

Re: [RFC v3] zswap: Add CONFIG_ZSWAP_IO_SWITCH to handle swap IO issue

On Sun, Sep 22, 2019 at 11:32 PM Hui Zhu wrote: > > This is the third version of this patch. The first and second version > is in [1] and [2]. > This verion is updated according to the comments from Randy Dunlap > in [3]. > > Currently, I use a VM that has 2 CPUs, 4G memory and 4G swap file. > I

Re: [PATCH/RFC] zswap: do not map same object twice

it slows things down for z3fold. > > Since there's hardly a point in unmapping a handle _that_ fast as > zswap_writeback_entry() does when it reads swpentry, the > suggestion is to keep the handle mapped till the end. LGTM > > Signed-off-by: Vitaly Wool Reviewed-by: Dan St

Re: [PATCH] zswap: Add CONFIG_ZSWAP_IO_SWITCH

gt; 79386 usecs to free memory > 2415919104 bytes / 20136015 usecs = 117167 KB/s > 4411 usecs to free memory > 1207959552 bytes / 1833403 usecs = 643419 KB/s > 70452 usecs to free memory > ... > killall usemem > ./usemem -a -n 1 $((7 * 1024 * 1024 * 1024)) > 8455716864

Re: Follow up on hid2hci: Fix udev rules for linux-4.14+

On Wed, Aug 28, 2019 at 1:59 PM Ville Syrjälä wrote: > > On Wed, Aug 28, 2019 at 08:50:51PM +0300, Ville Syrjälä wrote: > > On Wed, Aug 28, 2019 at 01:34:07PM -0400, Dan Streetman wrote: > > > It looks like this patch got lost at some point: > > > https://lore.ker

Follow up on hid2hci: Fix udev rules for linux-4.14+

It looks like this patch got lost at some point: https://lore.kernel.org/patchwork/patch/902126/#1138115 but it seems to still be a problem and I'd like to pull it into Ubuntu: https://bugs.launchpad.net/ubuntu/+source/bluez/+bug/1759836 Ville, did you ever follow up with a v2 for that patch

Re: [PATCH] zswap: ignore debugfs_create_dir() return value

On Tue, Jan 29, 2019 at 3:33 PM Greg Kroah-Hartman wrote: > > On Tue, Jan 29, 2019 at 02:46:30PM -0500, Dan Streetman wrote: > > On Tue, Jan 22, 2019 at 10:23 AM Greg Kroah-Hartman > > wrote: > > > > > > When calling debugfs functions, there is no need

Re: [PATCH] zswap: ignore debugfs_create_dir() return value

On Tue, Jan 22, 2019 at 10:23 AM Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Seth Jennings > Cc

Re: [PATCH v2] mm: fix z3fold warnings on CONFIG_SMP=n

On Thu, Sep 27, 2018 at 5:15 PM Alex Xu (Hello71) wrote: > > Spinlocks are always lockable on UP systems, even if they were just > locked. > > Cc: Dan Streetman I cc'ed Vitaly also, as this code is from him, but the change certainly looks correct to me. Acked-by: Dan Streetman

Re: [PATCH v2] mm: fix z3fold warnings on CONFIG_SMP=n

On Thu, Sep 27, 2018 at 5:15 PM Alex Xu (Hello71) wrote: > > Spinlocks are always lockable on UP systems, even if they were just > locked. > > Cc: Dan Streetman I cc'ed Vitaly also, as this code is from him, but the change certainly looks correct to me. Acked-by: Dan Streetman

Re: [PATCH] mm: fix z3fold warnings on CONFIG_SMP=n

On Thu, Sep 27, 2018 at 4:27 PM Alex Xu (Hello71) wrote: > > Spinlocks are always lockable on UP systems, even if they were just > locked. i think it would be much better to just use either assert_spin_locked() or just spin_is_locked(), instead of an #ifdef. > > Cc: Dan Streetma

Re: [PATCH] mm: fix z3fold warnings on CONFIG_SMP=n

On Thu, Sep 27, 2018 at 4:27 PM Alex Xu (Hello71) wrote: > > Spinlocks are always lockable on UP systems, even if they were just > locked. i think it would be much better to just use either assert_spin_locked() or just spin_is_locked(), instead of an #ifdef. > > Cc: Dan Streetma

Re: [PATCH v2] zswap: re-check zswap_is_full after do zswap_shrink

On Mon, Jun 25, 2018 at 4:08 AM Li Wang wrote: > > On 30 May 2018 at 20:53, Dan Streetman wrote: > > On Wed, May 30, 2018 at 6:39 AM, Li Wang wrote: > >> The '/sys/../zswap/stored_pages:' keep raising in zswap test with > >> "zswap.max_pool_percent=0"

Re: [PATCH v2] zswap: re-check zswap_is_full after do zswap_shrink

On Mon, Jun 25, 2018 at 4:08 AM Li Wang wrote: > > On 30 May 2018 at 20:53, Dan Streetman wrote: > > On Wed, May 30, 2018 at 6:39 AM, Li Wang wrote: > >> The '/sys/../zswap/stored_pages:' keep raising in zswap test with > >> "zswap.max_pool_percent=0"

Re: [PATCH v2] zswap: re-check zswap_is_full after do zswap_shrink

ent, and > not to compress/store if reach its limitaion. > > Signed-off-by: Li Wang Acked-by: Dan Streetman > Cc: Seth Jennings > Cc: Dan Streetman > Cc: Huang Ying > Cc: Yu Zhao > --- > mm/zswap.c | 9 + > 1 file changed, 9 insertions(+) > > dif

Re: [PATCH v2] zswap: re-check zswap_is_full after do zswap_shrink

ent, and > not to compress/store if reach its limitaion. > > Signed-off-by: Li Wang Acked-by: Dan Streetman > Cc: Seth Jennings > Cc: Dan Streetman > Cc: Huang Ying > Cc: Yu Zhao > --- > mm/zswap.c | 9 + > 1 file changed, 9 insertions(+) > > dif

Re: [PATCH RFC] zswap: reject to compress/store page if zswap_max_pool_percent is 0

On Tue, May 29, 2018 at 10:57 PM, Li Wang wrote: > Hi Dan, > > On Wed, May 30, 2018 at 5:14 AM, Dan Streetman wrote: >> >> On Thu, May 24, 2018 at 5:57 AM, Li Wang wrote: >> > The '/sys/../zswap/stored_pages:' keep raising in zswap test with >> &g

Re: [PATCH RFC] zswap: reject to compress/store page if zswap_max_pool_percent is 0

On Tue, May 29, 2018 at 10:57 PM, Li Wang wrote: > Hi Dan, > > On Wed, May 30, 2018 at 5:14 AM, Dan Streetman wrote: >> >> On Thu, May 24, 2018 at 5:57 AM, Li Wang wrote: >> > The '/sys/../zswap/stored_pages:' keep raising in zswap test with >> &g

Re: [PATCH RFC] zswap: reject to compress/store page if zswap_max_pool_percent is 0

wap_is_full(). If you're trying to fix that, then I would ack a patch that adds a second zswap_is_full() check after zswap_shrink() to make sure it's now under the max_pool_percent (or somehow otherwise fixes that behavior). > > Signed-off-by: Li Wang > Cc: Seth Jennings > Cc: Dan

Re: [PATCH RFC] zswap: reject to compress/store page if zswap_max_pool_percent is 0

wap_is_full(). If you're trying to fix that, then I would ack a patch that adds a second zswap_is_full() check after zswap_shrink() to make sure it's now under the max_pool_percent (or somehow otherwise fixes that behavior). > > Signed-off-by: Li Wang > Cc: Seth Jennings > Cc: Dan

Re: net: hang in unregister_netdevice: waiting for lo to become free

On Fri, May 11, 2018 at 5:19 AM, Dmitry Vyukov <dvyu...@google.com> wrote: > On Thu, May 10, 2018 at 12:23 PM, Dan Streetman <ddstr...@ieee.org> wrote: >>>>>>>> <tommi.t.rant...@nokia.com> wrote: >>>>>>>>> On 20.02.2018 18:26

Re: net: hang in unregister_netdevice: waiting for lo to become free

On Fri, May 11, 2018 at 5:19 AM, Dmitry Vyukov wrote: > On Thu, May 10, 2018 at 12:23 PM, Dan Streetman wrote: >>>>>>>> wrote: >>>>>>>>> On 20.02.2018 18:26, Neil Horman wrote: >>>>>>>>>> >>>>>

Re: net: hang in unregister_netdevice: waiting for lo to become free

On Thu, May 10, 2018 at 2:46 AM, Dmitry Vyukov <dvyu...@google.com> wrote: > On Mon, Apr 16, 2018 at 9:42 PM, Dan Streetman <ddstr...@ieee.org> wrote: >>>>>> On Wed, Feb 21, 2018 at 3:53 PM, Tommi Rantala >>>>>> <tommi.t.rant...@nokia.com&

Re: net: hang in unregister_netdevice: waiting for lo to become free

On Thu, May 10, 2018 at 2:46 AM, Dmitry Vyukov wrote: > On Mon, Apr 16, 2018 at 9:42 PM, Dan Streetman wrote: >>>>>> On Wed, Feb 21, 2018 at 3:53 PM, Tommi Rantala >>>>>> wrote: >>>>>>> On 20.02.2018 18:26, Neil Horman wrote: >&g

Re: net: hang in unregister_netdevice: waiting for lo to become free

On Mon, Apr 16, 2018 at 3:35 AM, Dmitry Vyukov <dvyu...@google.com> wrote: > On Fri, Apr 13, 2018 at 5:54 PM, Dmitry Vyukov <dvyu...@google.com> wrote: >> On Fri, Apr 13, 2018 at 2:43 PM, Dan Streetman <ddstr...@ieee.org> wrote: >>> On Thu, Apr 12,

Re: net: hang in unregister_netdevice: waiting for lo to become free

On Mon, Apr 16, 2018 at 3:35 AM, Dmitry Vyukov wrote: > On Fri, Apr 13, 2018 at 5:54 PM, Dmitry Vyukov wrote: >> On Fri, Apr 13, 2018 at 2:43 PM, Dan Streetman wrote: >>> On Thu, Apr 12, 2018 at 8:15 AM, Dmitry Vyukov wrote: >>>> On Wed, Feb 21, 2018 at 3:53

Re: net: hang in unregister_netdevice: waiting for lo to become free

On Thu, Apr 12, 2018 at 8:15 AM, Dmitry Vyukov wrote: > On Wed, Feb 21, 2018 at 3:53 PM, Tommi Rantala > wrote: >> On 20.02.2018 18:26, Neil Horman wrote: >>> >>> On Tue, Feb 20, 2018 at 09:14:41AM +0100, Dmitry Vyukov wrote: On Tue, Feb

Re: net: hang in unregister_netdevice: waiting for lo to become free

On Thu, Apr 12, 2018 at 8:15 AM, Dmitry Vyukov wrote: > On Wed, Feb 21, 2018 at 3:53 PM, Tommi Rantala > wrote: >> On 20.02.2018 18:26, Neil Horman wrote: >>> >>> On Tue, Feb 20, 2018 at 09:14:41AM +0100, Dmitry Vyukov wrote: On Tue, Feb 20, 2018 at 8:56 AM, Tommi Rantala wrote:

Re: [PATCH] crypto: nx-842: Delete an error message for a failed memory allocation in nx842_pseries_init()

is issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Dan Streetman <ddstr...@ieee.org> > --- > drivers/crypto/nx/nx-842-pseries.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletio

Re: [PATCH] crypto: nx-842: Delete an error message for a failed memory allocation in nx842_pseries_init()

d-off-by: Markus Elfring Reviewed-by: Dan Streetman > --- > drivers/crypto/nx/nx-842-pseries.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/nx/nx-842-pseries.c > b/drivers/crypto/nx/nx-842-pseries.c > index bf52cd1d7fca..6686997

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

ting THP before writing the page to swap device > > > if frontswap is enabled. To deal with the situation where frontswap > > > is enabled at runtime, whether the page is THP is checked before using > > > frontswap during swapping out too. > > > > > > Repo

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

he head page is saved. After swapping > > > in, tail pages will not be restored to its original contents, so cause > > > the memory corruption in the applications. > > > > > > This is fixed via splitting THP before writing the page to swap device > > > if

[PATCH] net: tcp: close sock if net namespace is exiting

Signed-off-by: Dan Streetman <ddstr...@canonical.com> --- include/net/net_namespace.h | 10 ++ net/ipv4/tcp.c | 3 +++ net/ipv4/tcp_timer.c| 15 +++ 3 files changed, 28 insertions(+) diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h

[PATCH] net: tcp: close sock if net namespace is exiting

Signed-off-by: Dan Streetman --- include/net/net_namespace.h | 10 ++ net/ipv4/tcp.c | 3 +++ net/ipv4/tcp_timer.c| 15 +++ 3 files changed, 28 insertions(+) diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index f8a84a2c2341

Re: [PATCH v3] zswap: only save zswap header when necessary

on), we'll have to add a driver->evictable bool to check here as well. But for now this is good, the zpools with driver->shrink do eviction, zsmalloc doesn't do eviction and won't have driver->shrink. Acked-by: Dan Streetman <ddstr...@ieee.org> Thanks! > >

Re: [PATCH v3] zswap: only save zswap header when necessary

ps; > + zpool->evictable = driver->shrink && ops && ops->evict; Since the ops->evict comes from zswap (and is never omitted), if we do restore zs_zpool_shrink() in the future to call the zsmalloc shrinker (and not do eviction), we'll have to add a driver->evi

Re: [PATCH] zswap: only save zswap header if zpool is shrinkable

On Tue, Jan 9, 2018 at 5:47 PM, Yu Zhao <yuz...@google.com> wrote: > On Tue, Jan 09, 2018 at 01:25:18PM -0500, Dan Streetman wrote: >> On Mon, Jan 8, 2018 at 5:51 PM, Yu Zhao <yuz...@google.com> wrote: >> > We waste sizeof(swp_entry_t) for zswap header when using

Re: [PATCH] zswap: only save zswap header if zpool is shrinkable

On Tue, Jan 9, 2018 at 5:47 PM, Yu Zhao wrote: > On Tue, Jan 09, 2018 at 01:25:18PM -0500, Dan Streetman wrote: >> On Mon, Jan 8, 2018 at 5:51 PM, Yu Zhao wrote: >> > We waste sizeof(swp_entry_t) for zswap header when using zsmalloc >> > as zpool driver because zsmall

Re: [PATCH] zswap: only save zswap header if zpool is shrinkable

to include the header info that zswap_writeback_entry (i.e. ops->evict) later needs, so yeah it does make more sense to call it zpool_evictable() and zpool->evictable. However, I think the function should still be zpool_shrink() and zpool->driver->shrink(), because it should be possible fo

Re: [PATCH] zswap: only save zswap header if zpool is shrinkable

ntry (i.e. ops->evict) later needs, so yeah it does make more sense to call it zpool_evictable() and zpool->evictable. However, I think the function should still be zpool_shrink() and zpool->driver->shrink(), because it should be possible for zs_pool_shrink() to call the normal zsmalloc shri

Re: [PATCH 2/2] mm/zswap: move `zswap_has_pool` to front of `if ()`

On Tue, Jan 2, 2018 at 5:03 AM, Joey Pabalinas wrote: > `zwap_has_pool` is a simple boolean, so it should be tested first > to avoid unnecessarily calling `strcmp()`. Test `zswap_has_pool` > first to take advantage of the short-circuiting behavior of && in >

Re: [PATCH 2/2] mm/zswap: move `zswap_has_pool` to front of `if ()`

On Tue, Jan 2, 2018 at 5:03 AM, Joey Pabalinas wrote: > `zwap_has_pool` is a simple boolean, so it should be tested first > to avoid unnecessarily calling `strcmp()`. Test `zswap_has_pool` > first to take advantage of the short-circuiting behavior of && in > `__zswap_param_set()`. > >

Re: [PATCH 1/2] mm/zswap: make type and compressor const

On Tue, Jan 2, 2018 at 5:03 AM, Joey Pabalinas wrote: > The characters pointed to by `zswap_compressor`, `type`, and `compressor` > aren't ever modified. Add const to the static variable and both parameters in > `zswap_pool_find_get()`, `zswap_pool_create()`, and

Re: [PATCH 1/2] mm/zswap: make type and compressor const

On Tue, Jan 2, 2018 at 5:03 AM, Joey Pabalinas wrote: > The characters pointed to by `zswap_compressor`, `type`, and `compressor` > aren't ever modified. Add const to the static variable and both parameters in > `zswap_pool_find_get()`, `zswap_pool_create()`, and `__zswap_param_set()` > >

Re: [PATCH v2] zswap: Update with same-value filled page feature

> Updated to clarify about zswap.same_filled_pages_enabled parameter. > > Updated zswap document with details on same-value filled > pages identification feature. > The usage of zswap.same_filled_pages_enabled module parameter > is explained. > > Signed-off-by: Srividya

Re: [PATCH v2] zswap: Update with same-value filled page feature

_enabled parameter. > > Updated zswap document with details on same-value filled > pages identification feature. > The usage of zswap.same_filled_pages_enabled module parameter > is explained. > > Signed-off-by: Srividya Desireddy Acked-by: Dan Streetman > --- > Documentation/

Re: [PATCH] zswap: Update with same-value filled page feature

On Wed, Nov 29, 2017 at 10:34 AM, Srividya Desireddy wrote: > From: Srividya Desireddy > Date: Wed, 29 Nov 2017 20:23:15 +0530 > Subject: [PATCH] zswap: Update with same-value filled page feature > > Updated zswap document with details on

Re: [PATCH] zswap: Update with same-value filled page feature

On Wed, Nov 29, 2017 at 10:34 AM, Srividya Desireddy wrote: > From: Srividya Desireddy > Date: Wed, 29 Nov 2017 20:23:15 +0530 > Subject: [PATCH] zswap: Update with same-value filled page feature > > Updated zswap document with details on same-value filled > pages identification feature. > The

Re: [PATCH] zswap: Same-filled pages handling

On Mon, Nov 20, 2017 at 6:46 PM, Andrew Morton wrote: > > On Wed, 18 Oct 2017 10:48:32 + Srividya Desireddy > wrote: > > > +/* Enable/disable handling same-value filled pages (enabled by default) */ > > +static bool

Re: [PATCH] zswap: Same-filled pages handling

On Mon, Nov 20, 2017 at 6:46 PM, Andrew Morton wrote: > > On Wed, 18 Oct 2017 10:48:32 + Srividya Desireddy > wrote: > > > +/* Enable/disable handling same-value filled pages (enabled by default) */ > > +static bool zswap_same_filled_pages_enabled = true; > >

Re: [PATCH] zswap: Same-filled pages handling

t; >>No. Use memset_l which is optimised for this specific job. > > I have tested this patch using memset_l() function in zswap_fill_page() on > x86 64-bit system with 2GB RAM. The performance remains same. > But, memset_l() funcion might be optimised in future. > @Seth Jen

Re: [PATCH] zswap: Same-filled pages handling

which is optimised for this specific job. > > I have tested this patch using memset_l() function in zswap_fill_page() on > x86 64-bit system with 2GB RAM. The performance remains same. > But, memset_l() funcion might be optimised in future. > @Seth Jennings/Dan Streetman: Should

Re: [PATCH] zswap: Same-filled pages handling

On Wed, Oct 18, 2017 at 5:31 PM, Timofey Titovets wrote: >> +static int zswap_is_page_same_filled(void *ptr, unsigned long *value) >> +{ >> + unsigned int pos; >> + unsigned long *page; >> + >> + page = (unsigned long *)ptr; >> + for (pos = 1; pos <

Re: [PATCH] zswap: Same-filled pages handling

On Wed, Oct 18, 2017 at 5:31 PM, Timofey Titovets wrote: >> +static int zswap_is_page_same_filled(void *ptr, unsigned long *value) >> +{ >> + unsigned int pos; >> + unsigned long *page; >> + >> + page = (unsigned long *)ptr; >> + for (pos = 1; pos < PAGE_SIZE /

Re: [PATCH] zswap: Same-filled pages handling

. That's a not-insignificant amount of time, but it's not huge. Considering that most systems will probably be swapping pages that aren't similar to the worst case (although I don't have any data to know that), I'd say the improvement is wo

Re: [PATCH] zswap: Same-filled pages handling

it's not huge. Considering that most systems will probably be swapping pages that aren't similar to the worst case (although I don't have any data to know that), I'd say the improvement is worth the possible worst-case performance impact. > > Signed-off-by: Srividya Desireddy Acked-by: Dan Streetman

Re: [PATCH] mm/zswap: constify struct kernel_param_ops uses

> > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Reviewed-by: Dan Streetman <ddstr...@ieee.org> > --- > mm/zswap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index d39581a..030fbf9 100644 >

Re: [PATCH] mm/zswap: constify struct kernel_param_ops uses

On Sat, Aug 26, 2017 at 1:41 PM, Arvind Yadav wrote: > kernel_param_ops are not supposed to change at runtime. All functions > working with kernel_param_ops provided by work > with const kernel_param_ops. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav R

Re: [PATCH 2/2] zpool: Use common error handling code in zpool_create_pool()

is function. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Dan Streetman <ddstr...@ieee.org> > --- > mm/zpool.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/zpool.c b/mm/zpool.c > index

Re: [PATCH 2/2] zpool: Use common error handling code in zpool_create_pool()

On Mon, Aug 14, 2017 at 7:16 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 14 Aug 2017 13:04:33 +0200 > > Add a jump target so that a bit of exception handling can be better reused > in this function. > > Signed-off-by: Markus Elfring Acked-by: Dan St

Re: [PATCH 1/2] zpool: Delete an error message for a failed memory allocation in zpool_create_pool()

is issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Dan Streetman <ddstr...@ieee.org> > --- > mm/zpool.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/zpool.c b/mm/zpool

Re: [PATCH 1/2] zpool: Delete an error message for a failed memory allocation in zpool_create_pool()

d-off-by: Markus Elfring Acked-by: Dan Streetman > --- > mm/zpool.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/zpool.c b/mm/zpool.c > index fd3ff719c32c..fe1943f7d844 100644 > --- a/mm/zpool.c > +++ b/mm/zpool.c > @@ -172,7 +172,6 @@ struct zpool *zpoo

Re: [PATCH v2] zswap: Zero-filled pages handling

On Thu, Jul 6, 2017 at 5:29 AM, Srividya Desireddy wrote: > On Wed, Jul 6, 2017 at 10:49 AM, Sergey Senozhatsky wrote: >> On (07/02/17 20:28), Seth Jennings wrote: >>> On Sun, Jul 2, 2017 at 9:19 AM, Srividya Desireddy >>> > Zswap is a cache which compresses the pages

Re: [PATCH v2] zswap: Zero-filled pages handling

On Thu, Jul 6, 2017 at 5:29 AM, Srividya Desireddy wrote: > On Wed, Jul 6, 2017 at 10:49 AM, Sergey Senozhatsky wrote: >> On (07/02/17 20:28), Seth Jennings wrote: >>> On Sun, Jul 2, 2017 at 9:19 AM, Srividya Desireddy >>> > Zswap is a cache which compresses the pages that are being swapped out

Re: [PATCH 3/3] zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare()

is issue was detected by using the Coccinelle software. > > Link: > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Dan Streetman <ddstr...@ieee.org&g

Re: [PATCH 3/3] zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare()

> > Link: > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring Acked-by: Dan Streetman > --- > mm/zswap.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswa

Re: [PATCH 2/3] zswap: Improve a size determination in zswap_frontswap_init()

parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Dan Streetman <ddstr...@ieee.org> > --- >

Re: [PATCH 2/3] zswap: Improve a size determination in zswap_frontswap_init()

ize > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring Acked-by: Dan Streetman > --- > mm/zswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 18d8e871

Re: [PATCH 1/3] zswap: Delete an error message for a failed memory allocation in zswap_pool_create()

is issue was detected by using the Coccinelle software. > > Link: > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Dan Streetman <ddstr...@ieee.org&

Re: [PATCH 1/3] zswap: Delete an error message for a failed memory allocation in zswap_pool_create()

> > Link: > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring Acked-by: Dan Streetman > --- > mm/zswap.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswa

Re: [PATCH] crypto/nx: Update MAINTAINERS entry for 842 compression

On Sat, Apr 1, 2017 at 1:25 PM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote: > [PATCH] crypto/nx: Update MAINTAINERS entry for 842 compression > > Signed-off-by: Haren Myneni <ha...@us.ibm.com> Acked-by: Dan Streetman <ddstr...@ieee.org> > > --- > MAI

Re: [PATCH] crypto/nx: Update MAINTAINERS entry for 842 compression

On Sat, Apr 1, 2017 at 1:25 PM, Haren Myneni wrote: > [PATCH] crypto/nx: Update MAINTAINERS entry for 842 compression > > Signed-off-by: Haren Myneni Acked-by: Dan Streetman > > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

On Fri, Mar 24, 2017 at 9:33 PM, Boris Ostrovsky wrote: > >> >> I think we can all agree that the *ideal* situation would be, for the >> balloon driver to not immediately hotplug memory so it can add 11 more >> pages, so maybe I just need to figure out why the balloon

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

On Fri, Mar 24, 2017 at 9:33 PM, Boris Ostrovsky wrote: > >> >> I think we can all agree that the *ideal* situation would be, for the >> balloon driver to not immediately hotplug memory so it can add 11 more >> pages, so maybe I just need to figure out why the balloon driver >> thinks it needs 11

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

On Fri, Mar 24, 2017 at 5:10 PM, Konrad Rzeszutek Wilk <konrad.w...@oracle.com> wrote: > On Fri, Mar 24, 2017 at 04:34:23PM -0400, Dan Streetman wrote: >> On Wed, Mar 22, 2017 at 10:13 PM, Boris Ostrovsky >> <boris.ostrov...@oracle.com> wrote: >> > >> &g

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

On Fri, Mar 24, 2017 at 5:10 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 24, 2017 at 04:34:23PM -0400, Dan Streetman wrote: >> On Wed, Mar 22, 2017 at 10:13 PM, Boris Ostrovsky >> wrote: >> > >> > >> > On 03/22/2017 05:16 PM, Dan Streetman wrote: >

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

On Wed, Mar 22, 2017 at 10:13 PM, Boris Ostrovsky <boris.ostrov...@oracle.com> wrote: > > > On 03/22/2017 05:16 PM, Dan Streetman wrote: >> >> I have a question about a problem introduced by this commit: >> c275a57f5ec3056f732843b11659d892235faff7 >> &q

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

On Wed, Mar 22, 2017 at 10:13 PM, Boris Ostrovsky wrote: > > > On 03/22/2017 05:16 PM, Dan Streetman wrote: >> >> I have a question about a problem introduced by this commit: >> c275a57f5ec3056f732843b11659d892235faff7 >> "xen/balloon: Set balloon's initial

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

On Thu, Mar 23, 2017 at 3:56 AM, Juergen Gross <jgr...@suse.com> wrote: > On 23/03/17 03:13, Boris Ostrovsky wrote: >> >> >> On 03/22/2017 05:16 PM, Dan Streetman wrote: >>> I have a question about a problem introduced by this commit: >>> c275a57f5ec3

Re: maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

On Thu, Mar 23, 2017 at 3:56 AM, Juergen Gross wrote: > On 23/03/17 03:13, Boris Ostrovsky wrote: >> >> >> On 03/22/2017 05:16 PM, Dan Streetman wrote: >>> I have a question about a problem introduced by this commit: >>> c275a57f5ec3056f732843b11659d8922

maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

I have a question about a problem introduced by this commit: c275a57f5ec3056f732843b11659d892235faff7 "xen/balloon: Set balloon's initial state to number of existing RAM pages" It changed the xen balloon current_pages calculation to start with the number of physical pages in the system, instead

maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

I have a question about a problem introduced by this commit: c275a57f5ec3056f732843b11659d892235faff7 "xen/balloon: Set balloon's initial state to number of existing RAM pages" It changed the xen balloon current_pages calculation to start with the number of physical pages in the system, instead

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 16, 2017 at 12:33 PM, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: >> >> >> setting the ASYNC bit makes it synchronous? that seems backwards...? > > You set the ASYNC bit in the ma

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 16, 2017 at 12:33 PM, Herbert Xu wrote: > On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: >> >> >> setting the ASYNC bit makes it synchronous? that seems backwards...? > > You set the ASYNC bit in the mask and leave it clear in the type.

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 9, 2017 at 4:39 AM, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: >> >> It looks like the crypto_scomp interface is buried under >> include/crypto/internal/scompress.h, however that's e

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 9, 2017 at 4:39 AM, Herbert Xu wrote: > On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: >> >> It looks like the crypto_scomp interface is buried under >> include/crypto/internal/scompress.h, however that's exactly what zswap >> should be usin

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Mon, Feb 27, 2017 at 9:40 AM, Mahipal Reddy <mahipalreddy2...@gmail.com> wrote: > Hi Dan, > Thanks for your reply. > > On Sat, Feb 25, 2017 at 3:51 AM, Dan Streetman <ddstr...@ieee.org> wrote: >> On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa >&g

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Mon, Feb 27, 2017 at 9:40 AM, Mahipal Reddy wrote: > Hi Dan, > Thanks for your reply. > > On Sat, Feb 25, 2017 at 3:51 AM, Dan Streetman wrote: >> On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa >> wrote: >>> This adds support for kernel's new crypto a

Re: [PATCH] zswap: Zero-filled pages handling

On Wed, Mar 8, 2017 at 6:47 AM, Srividya Desireddy <srividya...@samsung.com> wrote: > > On Sat, Mar 4, 2017 at 02:55 AM, Dan Streetman <ddstr...@ieee.org> wrote: >> On Sat, Feb 25, 2017 at 12:18 PM, Sarbojit Ganguly >> <unixman.linux...@gmail.com> wrote: >&g

Re: [PATCH] zswap: Zero-filled pages handling

On Wed, Mar 8, 2017 at 6:47 AM, Srividya Desireddy wrote: > > On Sat, Mar 4, 2017 at 02:55 AM, Dan Streetman wrote: >> On Sat, Feb 25, 2017 at 12:18 PM, Sarbojit Ganguly >> wrote: >>> On 25 February 2017 at 20:12, Srividya Desireddy >>> wrote: >>>&

Re: [PATCH] zswap: Zero-filled pages handling

On Sat, Feb 25, 2017 at 12:18 PM, Sarbojit Ganguly wrote: > On 25 February 2017 at 20:12, Srividya Desireddy > wrote: >> From: Srividya Desireddy >> Date: Thu, 23 Feb 2017 15:04:06 +0530 >> Subject: [PATCH] zswap:

Re: [PATCH] zswap: Zero-filled pages handling

On Sat, Feb 25, 2017 at 12:18 PM, Sarbojit Ganguly wrote: > On 25 February 2017 at 20:12, Srividya Desireddy > wrote: >> From: Srividya Desireddy >> Date: Thu, 23 Feb 2017 15:04:06 +0530 >> Subject: [PATCH] zswap: Zero-filled pages handling your email is base64-encoded; please send plain text

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa wrote: > This adds support for kernel's new crypto acomp/scomp framework > to zswap. I don't understand the point of this, zswap can't compress pages asynchronously, so what benefit do we get from using the async crypto

  1   2   3   4   5   6   7   8   9   10   >