Re: [PATCH v3] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

> callback > sched_cpu_activate() hence it may not be observable by sched_setaffinity() if > it is called immediately after uevent. > > Out of line uevent can be avoided if we will ensure that cpuset_hotplug_work > has run to completion using cpuset_wait_for_hotplug() after onlining th

Re: [PATCH v2] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

Alexey Klimov writes: > The first section of comment seems problematic to me with regards to such > move: > > * As this needs to hold the cpu maps lock it's impossible > * to call device_offline() because that ends up calling > * cpu_down()

Re: [PATCH] selftests/bpf: fix warning comparing pointer to 0

On 3/18/21 2:55 AM, Jiapeng Chong wrote: Fix the following coccicheck warning: ./tools/testing/selftests/bpf/progs/fentry_test.c:76:15-16: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- tools/testing/selftests/bpf/progs/fentry_test.c | 4 ++-- 1

Re: [PATCH bpf-next v2] bpf: Simplify expression for identify bpf mem type

t think it's worth it, especially given it's not in (highly) performance critical code. Thanks, Daniel

Re: [PATCH] drm: Few typo fixes

On Thu, Mar 18, 2021 at 04:07:39PM +0530, Bhaskar Chowdhury wrote: > > s/instatiated/instantiated/ > s/unreference/unreferenced/ > > Signed-off-by: Bhaskar Chowdhury Queued for 5.13 in drm-misc-next, thanks for your patch. -Daniel > --- > drivers/gpu/drm/drm_property

Re: [RESEND 00/53] Rid GPU from W=1 warnings

On Wed, Mar 17, 2021 at 9:32 PM Daniel Vetter wrote: > > On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote: > > > > On Thu, 11 Mar 2021, Lee Jones wrote: > > > > > On Thu, 11 Mar 2021, Daniel Vetter wrote: > > > > > > > On Mon, Mar 08, 2021

[PATCH] drm/radeon/ttm: Fix memory leak userptr pages

If userptr pages have been pinned but not bounded, they remain uncleared. Signed-off-by: Daniel Gomez --- drivers/gpu/drm/radeon/radeon_ttm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index

Re: [PATCH] drm/amdgpu/ttm: Fix memory leak userptr pages

On Thu, 18 Mar 2021 at 08:49, Christian König wrote: > > Am 17.03.21 um 17:08 schrieb Daniel Gomez: > > If userptr pages have been pinned but not bounded, > > they remain uncleared. > > > > Signed-off-by: Daniel Gomez > > Good catch, not sure if that can eve

Re: [PATCH 4/4] sched/cpuacct: Make user/system times in cpuacct.stat more precise

Andrey Ryabinin writes: > static int cpuacct_stats_show(struct seq_file *sf, void *v) > { ... > for_each_possible_cpu(cpu) { > u64 *cpustat = per_cpu_ptr(ca->cpustat, cpu)->cpustat; > > - val[CPUACCT_STAT_USER] += cpustat[CPUTIME_USER]; > -

Re: [PATCH 3/4] sched/cpuacct: fix user/system in shown cpuacct.usage*

Andrey Ryabinin writes: > cpuacct has 2 different ways of accounting and showing user > and system times. > > The first one uses cpuacct_account_field() to account times > and cpuacct.stat file to expose them. And this one seems to work ok. > > The second one is uses cpuacct_charge() function

Re: [PATCH] MIPS/bpf: Enable bpf_probe_read{, str}() on MIPS again

t;) Signed-off-by: Tiezhu Yang Thomas, I presume you pick this up via mips tree (with typos fixed)? Or do you want us to route the fix via bpf with your ACK? (I'm fine either way.) Thanks, Daniel

Re: [PATCH 2/4] cgroup: Fix 'usage_usec' time in root's cpu.stat

_usec looks ok now. Reviewed-by: Daniel Jordan Tested-by: Daniel Jordan

Re: [PATCH 1/4] cputime,cpuacct: Include guest time in user time in cpuacct.stat

Andrey Ryabinin writes: > cpuacct.stat in no-root cgroups shows user time without guest time > included int it. This doesn't match with user time shown in root > cpuacct.stat and /proc//stat. Yeah, that's inconsistent. > Make account_guest_time() to add user time to cgroup's cpustat to > fix

Re: [RESEND 00/53] Rid GPU from W=1 warnings

On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote: > > On Thu, 11 Mar 2021, Lee Jones wrote: > > > On Thu, 11 Mar 2021, Daniel Vetter wrote: > > > > > On Mon, Mar 08, 2021 at 09:19:32AM +, Lee Jones wrote: > > > > On Fri, 05 Mar 2021, Roland Scheidegge

[PATCH] drm/amdgpu/ttm: Fix memory leak userptr pages

If userptr pages have been pinned but not bounded, they remain uncleared. Signed-off-by: Daniel Gomez --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu

Re: [PATCH] kernel: debug: Ordinary typo fixes in the file gdbstub.c

len = strlen(s); > > - /* 'O'utput */ > + /* 'Output */ This is not a typo. It is showing that the 'O' being writing into the message buffer is a mnemonic and describing what it expands to. Other changes look good, please can you resend with this one removed? Danie

Re: [PATCH 1/2] csky: Enable generic clockevent broadcast

state. But many other architectures(powerpc, mips, > arm, hexagon, openrisc, sh) have supported the infrastructure to > deal with Power Management issues. > > Signed-off-by: Guo Ren > Cc: Arnd Bergmann > Cc: Thomas Gleixner > Cc: Daniel Lezcano > --- Acked-by: Daniel Lezca

[GIT PULL] thermal fixes for v5.12

Hi Linus, please consider pulling this single fix for the thermal framework. Thanks -- Daniel The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: ssh://g

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

On Fri, Mar 12, 2021 at 4:24 PM Mark Brown wrote: > > On Fri, Mar 12, 2021 at 02:37:30PM +0200, Daniel Baluta wrote: > > On Fri, Mar 12, 2021 at 1:59 PM Mark Brown wrote: > > > > No, just the opposite! If there's an explict name configured why do you > > >

Re: [PATCH 2/3] media/videobuf1|2: Mark follow_pfn usage as unsafe

On Wed, Mar 17, 2021 at 8:22 AM Christoph Hellwig wrote: > On Tue, Mar 16, 2021 at 04:52:44PM +0100, Daniel Vetter wrote: > > My understanding is mostly, but with some objections. And I kinda > > don't want to let this die in a bikeshed and then not getting rid of > > f

Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings

"heying (H)" writes: > Thank you for your reply. > > > 在 2021/3/17 11:04, Daniel Axtens 写道: >> Hi He Ying, >> >> Thank you for this patch. >> >> I'm not sure what the precise rules for Fixes are, but I wonder if this >> should have: >

Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings

e commits that added the entry_flush and uaccess_flush symbols. Perhaps one for rfi_flush too but I'm not sure what commit introduced that. Kind regards, Daniel > warning: symbol 'rfi_flush' was not declared. > warning: symbol 'entry_flush' was not declared. > warning: symbol 'uaccess_flush'

Re: [PATCH] libbpf: avoid inline hint definition from 'linux/stddef.h'

On 3/16/21 10:34 PM, Andrii Nakryiko wrote: On Tue, Mar 16, 2021 at 2:01 PM Daniel Borkmann wrote: On 3/14/21 6:38 PM, Pedro Tammela wrote: Linux headers might pull 'linux/stddef.h' which defines '__always_inline' as the following: #ifndef __always_inline #define __always_inline

Re: [PATCH] libbpf: avoid inline hint definition from 'linux/stddef.h'

On 3/14/21 6:38 PM, Pedro Tammela wrote: Linux headers might pull 'linux/stddef.h' which defines '__always_inline' as the following: #ifndef __always_inline #define __always_inline __inline__ #endif This becomes an issue if the program picks up the 'linux/stddef.h' definition as

Re: [PATCH v2] bpf: Fix memory leak in copy_process()

On 3/15/21 9:58 AM, qiang.zh...@windriver.com wrote: From: Zqiang nit: I presume it should be s/Zqiang/Qiang Zhang/ as real name for 'From' instead of abbreviation? The syzbot report a memleak follow: BUG: memory leak unreferenced object 0x888101b41d00 (size 120): comm

Re: [net-next PATCH v7 04/16] of: mdio: Refactor of_phy_find_device()

-audio.ko INSTALL sound/usb/snd-usbmidi-lib.ko INSTALL sound/xen/snd_xen_front.ko DEPMOD 5.12.0-rc3-9-g1fda33bf463d depmod: ERROR: Cycle detected: fwnode_mdio -> of_mdio -> fwnode_mdio depmod: ERROR: Found 2 modules in dependency cycles! ~~~ Kconfig can be found here: https://gist.gi

Re: [PATCH 2/3] media/videobuf1|2: Mark follow_pfn usage as unsafe

On Tue, Mar 16, 2021 at 4:46 PM Christoph Hellwig wrote: > > On Tue, Mar 16, 2021 at 04:33:02PM +0100, Daniel Vetter wrote: > > The media model assumes that buffers are all preallocated, so that > > when a media pipeline is running we never miss a deadline because the > >

[PATCH 3/3] mm: unexport follow_pfn

Jason Gunthorpe Cc: Cornelia Huck Cc: Peter Xu Cc: Alex Williamson Cc: linux...@kvack.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-me...@vger.kernel.org Cc: k...@vger.kernel.org Signed-off-by: Daniel Vetter --- include/linux/mm.h | 2 -- mm/

[PATCH 2/3] media/videobuf1|2: Mark follow_pfn usage as unsafe

rt io userptr operations on io memory"). Acked-by: Tomasz Figa Acked-by: Hans Verkuil Signed-off-by: Daniel Vetter Cc: Jason Gunthorpe Cc: Kees Cook Cc: Dan Williams Cc: Andrew Morton Cc: John Hubbard Cc: Jérôme Glisse Cc: Jan Kara Cc: Dan Williams Cc: linux...@kvack.org Cc: lin

[PATCH 1/3] mm: Add unsafe_follow_pfn

u_notifier, and that's all _GPL stuff. Signed-off-by: Daniel Vetter Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Kees Cook Cc: Dan Williams Cc: Andrew Morton Cc: John Hubbard Cc: Jérôme Glisse Cc: Jan Kara Cc: Dan Williams Cc: linux...@kvack.org Cc: linux-arm-ker...@lists.infradead.org Cc: lin

[PATCH 0/3] switch to unsafe_follow_pfn

Assuming no objections I'd like to lande these three patches in my topic branch for 5.13, for sufficient amounts of testing in linux-next before the merge window. Ack/review especially on the two mm patches very much thought after. Cheers, Daniel Daniel Vetter (3): mm: Add unsafe_follow_pfn

Re: [PATCH] thermal: power_allocator: using round the division when re-divvying up power

On 15/03/2021 10:51, Lukasz Luba wrote: > > > On 3/15/21 8:25 AM, gao.yunxi...@gmail.com wrote: >> From: "jeson.gao" >> >> The division is used directly in re-divvying up power, the decimal >> part will >> be discarded, devices will get less than the extra_actor_power - 1. >> if using round the

Re: [syzbot] upstream boot error: WARNING in vkms_vblank_simulate

On Fri, Mar 12, 2021 at 05:10:43PM +0100, Dmitry Vyukov wrote: > On Fri, Mar 12, 2021 at 3:22 PM Daniel Vetter wrote: > > > > On Fri, Mar 12, 2021 at 11:46:27AM +0100, Dmitry Vyukov wrote: > > > On Fri, Mar 12, 2021 at 11:26 AM syzbot > > > wrote: > > &g

Re: [PATCH 3/3] RFC: dma-buf: Add an API for importing and exporting sync files (v5)

On Mon, Mar 15, 2021 at 10:11 PM Jason Ekstrand wrote: > > On Wed, Sep 30, 2020 at 4:55 AM Daniel Vetter wrote: > > > > On Wed, Sep 30, 2020 at 11:39:06AM +0200, Michel Dänzer wrote: > > > On 2020-03-17 10:21 p.m., Jason Ekstrand wrote: > > > > Explicit s

Re: [PATCH] backlight: qcom-wled: Use sink_addr for sync toggle

Shamoun > Signed-off-by: Konrad Dybcio > Signed-off-by: Marijn Suijten LGTM, although an acked-by from Kiran would be nice to have: Reviewed-by: Daniel Thompson Daniel. > --- > drivers/video/backlight/qcom-wled.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH 1/1] media: i2c: Add support for ov5693 sensor

Hi Laurent On 14/03/2021 23:29, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Fri, Mar 12, 2021 at 10:32:39AM +, Daniel Scally wrote: >> The OV5693 is a 5 Mpx CMOS image sensor, connected via MIPI CSI-2. The >> chip is capable of

[ANNOUNCE] 4.4.261-rt218

: https://www.kernel.org/pub/linux/kernel/v4.x/linux-4.4.tar.xz https://www.kernel.org/pub/linux/kernel/v4.x/patch-4.4.261.xz https://www.kernel.org/pub/linux/kernel/projects/rt/4.4/patch-4.4.261-rt218.patch.xz Enjoy! Daniel

Re: [PATCH v2] bpf: Fix memory leak in copy_process()

On 3/15/21 9:18 AM, qiang.zh...@windriver.com wrote: From: Zqiang Hello Zqiang, please resend this patch with b...@vger.kernel.org in Cc, so it actually reaches the rest of BPF community for review, thanks! The syzbot report a memleak follow: BUG: memory leak unreferenced object

Re: [PATCH v2 4/5] thermal/drivers/cpuidle_cooling: Use device name instead of auto-numbering

On 15/03/2021 04:07, Viresh Kumar wrote: > On 12-03-21, 18:03, Daniel Lezcano wrote: >> Currently the naming of a cooling device is just a cooling technique >> followed by a number. When there are multiple cooling devices using >> the same technique, it is impossibl

Re: [PATCH 1/1] media: i2c: Add support for ov5693 sensor

Hi Jacopo, thanks for the review On 14/03/2021 10:40, Jacopo Mondi wrote: >> +#define OV5693_REG_CHIP_ID_H0x300A >> +#define OV5693_REG_CHIP_ID_L0x300B > Please use lower case letters in hex identifiers Will do >> + >> +/* Miscellaneous */ >>

Re: [PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

On 14/03/2021 13:47, Ido Schimmel wrote: > On Sun, Mar 14, 2021 at 12:13:29PM +0100, Daniel Lezcano wrote: >> We want to have any kind of name for the cooling devices as we do no >> longer want to rely on auto-numbering. Let's replace the cooling >> device's fixed ar

[PATCH v3 5/5] thermal/drivers/cpufreq_cooling: Remove unused list

There is a list with the purpose of grouping the cpufreq cooling device together as described in the comments but actually it is unused, the code evolved since 2012 and the list was no longer needed. Delete the remaining unused list related code. Signed-off-by: Daniel Lezcano Reviewed

[PATCH v3 4/5] thermal/drivers/cpuidle_cooling: Use device name instead of auto-numbering

thermal-idle-2 thermal-idle-3 etc ... The 'thermal' prefix is redundant with the subsystem namespace. This patch removes the 'thermal prefix and changes the number by the device name. So the naming above becomes: idle-cpu0 idle-cpu1 idle-cpu2 idle-cpu3 etc ... Signed-off-by: Daniel Lezcano

[PATCH v3 2/5] thermal/drivers/cpufreq_cooling: Use device name instead of auto-numbering

etc ... The 'thermal' prefix is redundant with the subsystem namespace. This patch removes the 'thermal' prefix and changes the number by the device name. So the naming above becomes: cpufreq-cpu0 cpufreq-cpu4 etc ... Signed-off-by: Daniel Lezcano Acked-by: Viresh Kumar Reviewed-by: Lukasz

[PATCH v3 3/5] thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering

etc ... The 'thermal' prefix is redundant with the subsystem namespace. This patch removes the 'thermal' prefix and changes the number by the device name. So the naming above becomes: devfreq-500.gpu devfreq-1d84000.ufshc etc ... Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba

[PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

path at the same time as we have to rollback the allocations in case of error. Tested with a dummy device having the name: "Llanfairpwllgwyngyllgogerychwyrndrobwantysiliogogogoch" A village on the island of Anglesey (Wales), known to have the longest name in Europe. Signed-off-

Re: [PATCH v2 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

Hi Ido, On 14/03/2021 10:53, Ido Schimmel wrote: > On Fri, Mar 12, 2021 at 06:03:12PM +0100, Daniel Lezcano wrote: >> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c >> index 996c038f83a4..9ef8090eb645 100644 >> --- a/drivers/thermal/thermal_co

Re: [PATCH 2/2] PCI: Revoke mappings like devmem

On Sat, Mar 13, 2021 at 10:57 PM Bjorn Helgaas wrote: > > [+cc Krzysztof, Pali, Oliver] > > On Thu, Feb 04, 2021 at 05:58:31PM +0100, Daniel Vetter wrote: > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > > the region") /dev/kmem

[PATCH 1/2] powercap/drivers/dtpm: Export the symbols for the modules

The DTPM framework provides a generic API to register devices which power capable. The devices may be compiled as modules while the framework is not. Export the necessary API to let the drivers register themselves. Signed-off-by: Daniel Lezcano --- drivers/powercap/dtpm.c | 8 1 file

[PATCH 2/2] powercap/drivers/dtpm: Allow dtpm node device creation through configfs

m:0:0/dtpm:0:0:1/power Signed-off-by: Daniel Lezcano --- drivers/powercap/Kconfig | 8 + drivers/powercap/Makefile| 1 + drivers/powercap/dtpm_configfs.c | 247 +++ include/linux/dtpm.h | 2 + 4 files changed, 258 insertions(+) c

Re: [PATCH v2 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

On 12/03/2021 19:49, Lukasz Luba wrote: > > > On 3/12/21 5:03 PM, Daniel Lezcano wrote: >> We want to have any kind of name for the cooling devices as we do no >> longer want to rely on auto-numbering. Let's replace the cooling >> device's fixed array by a c

Re: [PATCH -tip v2 00/10] kprobes: Fix stacktrace with kretprobes

gt; > In this version I merged the ORC unwinder fix for kretprobe which discussed > in the > previous thread. [3/10] is updated according to the Miroslav's comment. > [4/10] is > updated for simplify the code. [5/10]-[9/10] are discussed in the previsous > tread > and are i

[PATCH v2 4/5] thermal/drivers/cpuidle_cooling: Use device name instead of auto-numbering

thermal-idle-2 thermal-idle-3 etc ... The 'thermal' prefix is redundant with the subsystem namespace. This patch removes the 'thermal prefix and changes the number by the device name. So the naming above becomes: idle-cpu0 idle-cpu1 idle-cpu2 idle-cpu3 etc ... Signed-off-by: Daniel Lezcano

[PATCH v2 3/5] thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering

etc ... The 'thermal' prefix is redundant with the subsystem namespace. This patch removes the 'thermal' prefix and changes the number by the device name. So the naming above becomes: devfreq-500.gpu devfreq-1d84000.ufshc etc ... Signed-off-by: Daniel Lezcano --- V2: - Removed idr.h

[PATCH v2 5/5] thermal/drivers/cpufreq_cooling: Remove unused list

There is a list with the purpose of grouping the cpufreq cooling device together as described in the comments but actually it is unused, the code evolved since 2012 and the list was no longer needed. Delete the remaining unused list related code. Signed-off-by: Daniel Lezcano --- drivers

[PATCH v2 2/5] thermal/drivers/cpufreq_cooling: Use device name instead of auto-numbering

etc ... The 'thermal' prefix is redundant with the subsystem namespace. This patch removes the 'thermal' prefix and changes the number by the device name. So the naming above becomes: cpufreq-cpu0 cpufreq-cpu4 etc ... Signed-off-by: Daniel Lezcano Acked-by: Viresh Kumar Reviewed-by: Lukasz

[PATCH v2 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

path at the same time as we have to rollback the allocations in case of error. Tested with a dummy device having the name: "Llanfairpwllgwyngyllgogerychwyrndrobwantysiliogogogoch" A village on the island of Anglesey (Wales), known to have the longest name in Europe. Signed-off-

Re: [PATCH 2/3] thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering

On 12/03/2021 12:15, Lukasz Luba wrote: > > > On 3/10/21 11:45 AM, Daniel Lezcano wrote: >> Currently the naming of a cooling device is just a cooling technique >> followed by a number. When there are multiple cooling devices using >> the same technique, it is imp

Re: [syzbot] upstream boot error: WARNING in vkms_vblank_simulate

f we can process less than 1 hrtimer per vblank (standard every 16ms) then we scream, because things go very wrong with the simulated hw. And the hrtimer is really not that big, all the expensive processing is pushed to worker, where we have code to handle if it falls back too much. So either patch

Re: [PATCH v2] fb_defio: Remove custom address_space_operations

use the gpu buffers. If we can track directly in the gpu buffers, maybe even as some kind of overlay over the vma, we could avoid that copy. Otoh no one cares about fbcon performance, so *shrug*. Cheers, Daniel > --- > v2: Delete local variable definitions > driv

[PATCH v4 4/5] powercap/drivers/dtpm: Use container_of instead of a private data field

allocating the device specific dtpm structure. The dtpm_init() is provided instead. Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/powercap/dtpm.c | 27 ++ drivers/powercap/dtpm_cpu.c | 46 ++--- include/linux/dtpm.h| 3

[PATCH v4 5/5] powercap/drivers/dtpm: Scale the power with the load

ange: ~$ ~/dhrystone -t 1 -l 1& ~$ cat /sys/devices/virtual/powercap/dtpm/dtpm:0/dtpm:0:1/constraint_0_max_power_uw 113 ~$ ~/dhrystone -t 2 -l 1& ~$ cat /sys/devices/virtual/powercap/dtpm/dtpm:0/dtpm:0:1/constraint_0_max_power_uw 226 Signed-off-by: Daniel Lezcano Reviewe

[PATCH v4 3/5] powercap/drivers/dtpm: Simplify the dtpm table

-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/powercap/dtpm.c | 4 ++-- drivers/powercap/dtpm_cpu.c | 4 +++- include/linux/dtpm.h| 22 +- 3 files changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/powercap/dtpm.c b/drivers/powercap

[PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

to reflect their purpose. Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- V4: - Fixed typo in the commit log V2: - Fixed error code path by dropping lock --- drivers/powercap/dtpm.c | 161 ++-- drivers/powercap/dtpm_cpu.c | 4 +- include/linux

[PATCH v4 1/5] powercap/drivers/dtpm: Encapsulate even more the code

-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- V4: - Replaced s/sprintf/snprintf/ for the dtpm node name V2: - Updated the changelog with the CPU node not being removed - Commented the cpu hotplug callbacks to explain why there are two callbacks - Changed 'upt_power_uw' to 'update_power_uw

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

On Fri, Mar 12, 2021 at 1:59 PM Mark Brown wrote: > > On Fri, Mar 12, 2021 at 12:59:29PM +0200, Daniel Baluta wrote: > > On Fri, Mar 12, 2021 at 12:50 PM Mark Brown wrote: > > > > If an explicit name has been provided why would we override it with an > > > autog

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

On Fri, Mar 12, 2021 at 12:50 PM Mark Brown wrote: > > On Fri, Mar 12, 2021 at 10:32:54AM +0200, Daniel Baluta wrote: > > On Tue, Mar 9, 2021 at 5:38 PM Mark Brown wrote: > > > > > + if (!dai_link->platforms->of_node) > > > > +

Re: [PATCH v2] irqchip/irq-mst: Support polarity configuration

t. The main thing I didn't want was filtering out edge interrupts entirely as that breaks using edge interrupts with gpios i.e. using gpiomon. With the changes to set the polarity it can now detect rising or falling edge gpio events. :) Thanks, Daniel

[PATCH 0/1] Add support for OV5693 Sensor

at library (at least, at time of writing) are supported. Daniel Scally (1): media: i2c: Add support for ov5693 sensor MAINTAINERS|7 + drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov5693.c | 1585 +++

[PATCH 1/1] media: i2c: Add support for ov5693 sensor

mandatory, optional and recommended V4L2 controls for maximum compatibility with libcamera. Signed-off-by: Daniel Scally --- MAINTAINERS|7 + drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov5693.c | 1585

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

On Tue, Mar 9, 2021 at 5:38 PM Mark Brown wrote: > > On Tue, Mar 09, 2021 at 10:23:28AM +0200, Daniel Baluta wrote: > > From: Daniel Baluta > > > > Platform may be specified by either name or OF node but not > > both. > > > > For OF node platforms (e

Re: [PATCH]] drm/amdgpu/gfx9: add gfxoff quirk

On Thu, 11 Mar 2021 at 17:10, Alex Deucher wrote: > > On Thu, Mar 11, 2021 at 10:02 AM Alexandre Desnoyers wrote: > > > > On Thu, Mar 11, 2021 at 2:49 PM Daniel Gomez wrote: > > > > > > On Thu, 11 Mar 2021 at 10:09, Daniel Gomez wrote: > > > > &g

[PATCH v4 1/2] kunit: support failure from dynamic analysis tools

[15:19:34] not ok 1 - example_simple_test Co-developed-by: Daniel Latypov Signed-off-by: Daniel Latypov Signed-off-by: Uriel Guajardo Reviewed-by: Alan Maguire --- include/kunit/test-bug.h | 30 ++ lib/kunit/test.c | 39 +++ 2 files

[PATCH v4 2/2] kunit: ubsan integration

() as well, so there's some slight duplication, but it also ensures an error is recorded in the debugfs entry for the running KUnit test. Print a shorter version of the message to make it less spammy. Co-developed-by: Daniel Latypov Signed-off-by: Daniel Latypov Signed-off-by: Uriel Guajardo

[PATCH v4 0/2] kunit: fail tests on UBSAN errors

v1 by Uriel is here: [1]. Since it's been a while, I've dropped the Reviewed-By's. It depended on commit 83c4e7a0363b ("KUnit: KASAN Integration") which hadn't been merged yet, so that caused some kerfuffle with applying them previously and the series was reverted. This revives the series but

[PATCH v2] block: Suppress uevent for hidden device when removed

to the system. KERNEL[95481.571887] remove /devices/virtual/nvme-fabrics/ctl/nvme5/nvme0c5n1 (block) Let's suppress the uevents for GENHD_FL_HIDDEN by not enabling the uevents at all. Signed-off-by: Daniel Wagner --- This version behaves in the same way as v1, that is I don't see any

Re: [PATCH]] drm/amdgpu/gfx9: add gfxoff quirk

On Thu, 11 Mar 2021 at 10:09, Daniel Gomez wrote: > > On Wed, 10 Mar 2021 at 18:06, Alex Deucher wrote: > > > > On Wed, Mar 10, 2021 at 11:37 AM Daniel Gomez wrote: > > > > > > Disabling GFXOFF via the quirk list fixes a hardware lockup in > > &g

Re: [RESEND 00/53] Rid GPU from W=1 warnings

gain (they are queued up for 5.13 in drm-misc-next, I checked that). Sorry for the confusion here. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/radeon: fix copy of uninitialized variable back to userspace

. If it does I think the only difference would be errno userspace sees (aside from the stack garbage, which we could also emulate). Switching to return 0; is easy. So no worries this would be a problem :-) -Daniel > > Christian. > > > --- > > drivers/gpu/drm/radeon/rade

Re: [PATCH 04/44] vgacon: comment on vga_rolled_over

ernel.org I think Greg volunteered to take care of these ... Also my brain is toast and I'm not even close to ready to grok vc code to review this properly :-/ Cheers, Daniel > --- > drivers/video/console/vgacon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: KMSAN: kernel-infoleak in compat_drm_wait_vblank

> > Memory access of size 16 starts at 88814ffe3c98 > > Data copied to user address 2100 > > ===== > > compat_drm_wait_vblank would need to initialize > > req.reply.tval_usec = req32.reply.tval_usec; > > before calling drm_ioctl_kernel, since it's not aliased by any > req.request.* member, and drm_wait_vblank_ioctl doesn't always write to > it. I've fixed this in commit e926c474ebee404441c838d18224cd6f246a71b7 Author: Daniel Vetter Date: Mon Feb 22 11:06:43 2021 +0100 drm/compat: Clear bounce structures Or at least tried to. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v2] irqchip/irq-mst: Support polarity configuration

something we can handle (not IRQ_TYPE_EDGE_BOTH) and maybe if the fiq controller can only do edge interrupts level types should return -EINVAL? Thanks, Daniel

Re: [RESEND PATCH v5 2/4] arm64: dts: rk3399: Add dfi and dmc nodes.

On 09/03/2021 12:42, Johan Jonker wrote: > Hi Daniel, > > (This is a generic dtsi. How about cooling and dmc ??) Yeah, I will add it after. I need to figure out the right dynamic power coefficient from the different places around (android / chromeos / etc...). Any help for that i

Re: [RESEND PATCH v5 2/4] arm64: dts: rk3399: Add dfi and dmc nodes.

On 09/03/2021 12:42, Johan Jonker wrote: > Hi Daniel, > > Some comments. Have a look if it's useful or that you disagree with. > > New nodes should be verifiable if possible. > Especially with so many properties. > Could you convert rockchip-dfi.txt and rk3399_dm

Re: [PATCH v2] dt-bindings: timer: renesas,cmt: add r8a779a0 CMT support

On 11/03/2021 10:09, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter |

Re: [PATCH] thermal: Fix spelling mistake "disabed" -> "disabled"

On 11/03/2021 10:30, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a comment, fix it. > > Signed-off-by: Colin Ian King > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro:

Re: [PATCH v3 1/5] powercap/drivers/dtpm: Encapsulate even more the code

On 11/03/2021 11:15, Lukasz Luba wrote: > Hi Daniel, > > On 3/10/21 11:02 AM, Daniel Lezcano wrote: >> In order to increase the self-encapsulation of the dtpm generic code, >> the following changes are adding a power update ops to the dtpm >> ops. That allows the ge

Re: [PATCH v2] nvme-tcp: Check if request has started before processing it

Hi Sagi, On Fri, Mar 05, 2021 at 11:57:30AM -0800, Sagi Grimberg wrote: > Daniel, again, there is nothing specific about this to nvme-tcp, > this is a safeguard against a funky controller (or a different > bug that is hidden by this). As far I can tell, the main difference between

Re: [PATCH]] drm/amdgpu/gfx9: add gfxoff quirk

On Wed, 10 Mar 2021 at 18:06, Alex Deucher wrote: > > On Wed, Mar 10, 2021 at 11:37 AM Daniel Gomez wrote: > > > > Disabling GFXOFF via the quirk list fixes a hardware lockup in > > Ryzen V1605B, RAVEN 0x1002:0x15DD rev 0x83. > > > > Signed-off-by: Dani

Re: [PATCH -tip 0/5] kprobes: Fix stacktrace in kretprobes

On Thu, Mar 11, 2021 at 12:55:09AM +0900, Masami Hiramatsu wrote: > Hi Josh and Daniel, <...> > commit aa452d999b524b1851f69cc947be3e1a2f3ca1ec > Author: Masami Hiramatsu > Date: Sat Mar 6 08:34:51 2021 +0900 > > x86/unwind/orc: Fixup kretprobe trampoline

Re: [PATCH v2 04/15] powerpc/uaccess: Remove __get/put_user_inatomic()

can be used in atomic parts > of the code, therefore __get/put_user_inatomic() have become useless. > > Remove __get_user_inatomic() and __put_user_inatomic(). > This makes much more sense, thank you! Simplifying uaccess.h is always good to me :) Reviewed-by: Daniel Axtens Kind

Re: [PATCH v2 03/15] powerpc/align: Convert emulate_spe() to user_access_begin

ains that this is CamelCase, which seems like a checkpatch problem. Efault_{read,write} seem like good labels to me. (You don't need to change anything, I just like to check the checkpatch results when reviewing a patch.) > + user_read_access_end(); > + return -EFAULT; > + > +Efault_write: > + user_write_access_end(); > + return -EFAULT; > } > #endif /* CONFIG_SPE */ > With the user_write_access_begin change: Reviewed-by: Daniel Axtens Kind regards, Daniel

Re: [PATCH v2 01/15] powerpc/uaccess: Remove __get_user_allowed() and unsafe_op_wrap()

Hi Christophe, Thanks for the answers to my questions on v1. This all looks good to me. Reviewed-by: Daniel Axtens Kind regards, Daniel > Those two macros have only one user which is unsafe_get_user(). > > Put everything in one place and remove them. > > Signed-off-by: C

[PATCH]] drm/amdgpu/gfx9: add gfxoff quirk

Disabling GFXOFF via the quirk list fixes a hardware lockup in Ryzen V1605B, RAVEN 0x1002:0x15DD rev 0x83. Signed-off-by: Daniel Gomez --- This patch is a continuation of the work here: https://lkml.org/lkml/2021/2/3/122 where a hardware lockup was discussed and a dma_fence deadlock was provoke

Re: [PATCH v10 0/8] Add support for ipq8064 tsens

On 10/03/2021 14:32, Thara Gopinath wrote: > > > On 3/10/21 7:19 AM, Daniel Lezcano wrote: >> >> Hi Ansuel, >> >> On 17/02/2021 20:40, Ansuel Smith wrote: >>> This patchset convert msm8960 to reg_filed, use int_common instead >>> of a cu

Re: [PATCH v2 1/3] dt-bindings/timer: ingenic: Add compatible strings for JZ4760(B)

On 08/03/2021 22:23, Paul Cercueil wrote: > Add compatible strings to support the system timer, clocksource, OST, > watchdog and PWM blocks of the JZ4760 and JZ4760B SoCs. > > Newer SoCs which behave like the JZ4760 or JZ4760B now see their > compatible string require a fallback compatible string

Re: [PATCH v2] thermal: thermal_of: fix error return code of thermal_of_populate_bind_params()

On 10/03/2021 13:24, Jia-Ju Bai wrote: > When kcalloc() returns NULL to __tcbp or of_count_phandle_with_args() > returns zero or -ENOENT to count, no error return code of > thermal_of_populate_bind_params() is assigned. > To fix these bugs, ret is assigned with -ENOMEM and -ENOENT in these >

Re: [PATCH v10 0/8] Add support for ipq8064 tsens

t from the maintainer / reviewer of the sensor. Given it is based on Amit's work, I can assume they are correct. I added Thara in Cc hoping she has time to review the changes. If nobody complains with the series, I'll merge them in the next days Thanks -- Daniel -- <http://www.linaro.org/&g

Re: [PATCH] thermal: thermal_of: fix error return code of thermal_of_populate_bind_params()

a cooling_device property with at least one device\n"); goto end; } Mind to send a patch fixing both ? Thanks -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog

[PATCH 2/3] thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering

etc ... The 'thermal' prefix is redundant with the subsystem namespace. This patch removes the 'thermal prefix and changes the number by the device name. So the naming above becomes: devfreq-500.gpu devfreq-1d84000.ufshc etc ... Signed-off-by: Daniel Lezcano --- drivers/thermal

<    1   2   3   4   5   6   7   8   9   10   >