On Thu, Feb 28, 2019 at 12:09 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Feb 27, 2019 at 03:19:17PM -0700, Daniel Kurtz wrote:
> > In cases such as xhci_abort_cmd_ring(), xhci_handshake() is called with
> > a spin lock held (and local interrupts disabled) with a huge 5 second
>
t's replace the open coded io polling loop with one from
iopoll.h that uses a loop timed with the more presumably reliable ktime
infrastructure.
Signed-off-by: Daniel Kurtz
---
drivers/usb/host/xhci.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/driv
On Wed, Dec 5, 2018 at 4:28 AM Mark Brown wrote:
>
> On Wed, Dec 05, 2018 at 10:21:04AM +, Adam Thomson wrote:
>
> > If the previous I2C access failed, how can we be sure that the write back
> > to HW
> > of 0xFF even succeeds? More importantly these error returns won't
> > necessarily
> >
On Wed, Dec 5, 2018 at 4:28 AM Mark Brown wrote:
>
> On Wed, Dec 05, 2018 at 10:21:04AM +, Adam Thomson wrote:
>
> > If the previous I2C access failed, how can we be sure that the write back
> > to HW
> > of 0xFF even succeeds? More importantly these error returns won't
> > necessarily
> >
Hi Akshu,
On Mon, Oct 29, 2018 at 1:39 AM Agrawal, Akshu wrote:
>
> During simultaneous running of playback and capture, we
> got hit by incorrect value write on common register. This was due
> to race condition between 2 streams.
> Fixing this by locking the common register access.
Nice
Hi Akshu,
On Mon, Oct 29, 2018 at 1:39 AM Agrawal, Akshu wrote:
>
> During simultaneous running of playback and capture, we
> got hit by incorrect value write on common register. This was due
> to race condition between 2 streams.
> Fixing this by locking the common register access.
Nice
emporarily disabled IRQ and
incorrectly disable it while trying to modify some other register bits.
Fixes: 4c1de0414a1340 pinctrl/amd: poll InterruptEnable bits in enable_irq
Signed-off-by: Daniel Kurtz
---
drivers/pinctrl/pinctrl-amd.c | 33 +++--
1 file changed, 23 insertions(+)
emporarily disabled IRQ and
incorrectly disable it while trying to modify some other register bits.
Fixes: 4c1de0414a1340 pinctrl/amd: poll InterruptEnable bits in enable_irq
Signed-off-by: Daniel Kurtz
---
drivers/pinctrl/pinctrl-amd.c | 33 +++--
1 file changed, 23 insertions(+)
hu Agrawal
Reviewed-by: Daniel Kurtz
> ---
> sound/soc/amd/acp-da7219-max98357a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/acp-da7219-max98357a.c
> b/sound/soc/amd/acp-da7219-max98357a.c
> index cf2f648..55d7f61 100644
> --- a
hu Agrawal
Reviewed-by: Daniel Kurtz
> ---
> sound/soc/amd/acp-da7219-max98357a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/acp-da7219-max98357a.c
> b/sound/soc/amd/acp-da7219-max98357a.c
> index cf2f648..55d7f61 100644
> --- a
On Tue, Aug 21, 2018 at 12:55 AM Akshu Agrawal wrote:
>
> We support dual channel, 48Khz. This constraint was set only for
> da7219. It is being extended to DMIC and MAX98357a.
>
> Signed-off-by: Akshu Agrawal
Reviewed-by: Daniel Kurtz
> ---
> sound/soc/amd/acp-da
On Tue, Aug 21, 2018 at 12:53 AM Akshu Agrawal wrote:
>
> System clk provided in ST soc can be set to:
> 48Mhz, non-spread
> 25Mhz, spread
> To get accurate rate, we need it to set it at non-spread
> option which is 48Mhz.
>
> Signed-off-by: Akshu Agrawal
R
On Tue, Aug 21, 2018 at 12:55 AM Akshu Agrawal wrote:
>
> We support dual channel, 48Khz. This constraint was set only for
> da7219. It is being extended to DMIC and MAX98357a.
>
> Signed-off-by: Akshu Agrawal
Reviewed-by: Daniel Kurtz
> ---
> sound/soc/amd/acp-da
On Tue, Aug 21, 2018 at 12:53 AM Akshu Agrawal wrote:
>
> System clk provided in ST soc can be set to:
> 48Mhz, non-spread
> 25Mhz, spread
> To get accurate rate, we need it to set it at non-spread
> option which is 48Mhz.
>
> Signed-off-by: Akshu Agrawal
R
These two are the only write-able bits in this byte.
Therefore, it should be safe to just write these bits back as a byte
access without any additional locking.
Signed-off-by: Daniel Kurtz
---
drivers/pinctrl/pinctrl-amd.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
These two are the only write-able bits in this byte.
Therefore, it should be safe to just write these bits back as a byte
access without any additional locking.
Signed-off-by: Daniel Kurtz
---
drivers/pinctrl/pinctrl-amd.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
. Calling regulator_get_voltage() on a dummy
regulator just returns -EINVAL, in which case the DA7219 is always set up
to use the default VDDIO voltage range of 2.5-3.6V.
Provide a new device property to let such systems specify a different
VDDIO if needed (e.g., 1.8V).
Signed-off-by: Daniel Kurtz
-
. Calling regulator_get_voltage() on a dummy
regulator just returns -EINVAL, in which case the DA7219 is always set up
to use the default VDDIO voltage range of 2.5-3.6V.
Provide a new device property to let such systems specify a different
VDDIO if needed (e.g., 1.8V).
Signed-off-by: Daniel Kurtz
-
. Calling regulator_get_voltage() on a dummy
regulator just returns -EINVAL, in which case the DA7219 is always set up
to use the default VDDIO voltage range of 2.5-3.6V.
Provide a new device property to let such systems specify a different
VDDIO if needed (e.g., 1.8V).
Signed-off-by: Da
. Calling regulator_get_voltage() on a dummy
regulator just returns -EINVAL, in which case the DA7219 is always set up
to use the default VDDIO voltage range of 2.5-3.6V.
Provide a new device property to let such systems specify a different
VDDIO if needed (e.g., 1.8V).
Signed-off-by: Da
Hi Daniel,
On Tue, Jul 17, 2018 at 6:30 AM Daniel Drake wrote:
>
> On Mon, Jul 16, 2018 at 7:57 PM, Daniel Kurtz wrote:
> > Commit 6afb10267c1692 ("pinctrl/amd: fix masking of GPIO interrupts")
> > changed to the clearing of interrupt status bits to a RMW in a criti
Hi Daniel,
On Tue, Jul 17, 2018 at 6:30 AM Daniel Drake wrote:
>
> On Mon, Jul 16, 2018 at 7:57 PM, Daniel Kurtz wrote:
> > Commit 6afb10267c1692 ("pinctrl/amd: fix masking of GPIO interrupts")
> > changed to the clearing of interrupt status bits to a RMW in a criti
From: Akshu Agrawal
DA7219's VDDIO for our platform need to be configured for 1.8V.
Hence we register a fixed 1.8V voltage regulator in the machine driver.
Change-Id: I65fd93e1dd37c3e0d38265b4b1492ea53b93afd4
Signed-off-by: Akshu Agrawal
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/Kconfig
From: Akshu Agrawal
DA7219's VDDIO for our platform need to be configured for 1.8V.
Hence we register a fixed 1.8V voltage regulator in the machine driver.
Change-Id: I65fd93e1dd37c3e0d38265b4b1492ea53b93afd4
Signed-off-by: Akshu Agrawal
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/Kconfig
Sound machine drivers tend to live in modules. Sometimes such a machine
driver needs to register a fixed regulator to provide to a codec.
Export regulator_register_always_on() such that this is possible.
Change-Id: I2906f96df278b5fa65d40d3a777bf6d3d91841d2
Signed-off-by: Daniel Kurtz
Sound machine drivers tend to live in modules. Sometimes such a machine
driver needs to register a fixed regulator to provide to a codec.
Export regulator_register_always_on() such that this is possible.
Change-Id: I2906f96df278b5fa65d40d3a777bf6d3d91841d2
Signed-off-by: Daniel Kurtz
ive on both" to just the edge trigger case, and
refactor a bit to make the logic more readable.
Change-Id: Id7775ae4cb61d193fa7fbb83967a8c5a7cdd0de6
Signed-off-by: Daniel Kurtz
---
drivers/pinctrl/pinctrl-amd.c | 14 +++---
drivers/pinctrl/pinctrl-amd.h | 4
2 files changed, 11
ive on both" to just the edge trigger case, and
refactor a bit to make the logic more readable.
Change-Id: Id7775ae4cb61d193fa7fbb83967a8c5a7cdd0de6
Signed-off-by: Daniel Kurtz
---
drivers/pinctrl/pinctrl-amd.c | 14 +++---
drivers/pinctrl/pinctrl-amd.h | 4
2 files changed, 11
q().
Note: Is it possible that this bug was the source of the interrupt storm
on Ryzen when using chained interrupts before commit ba714a9c1dea85
("pinctrl/amd: Use regular interrupt instead of chained")?
Signed-off-by: Daniel Kurtz
---
drivers/pinctrl/pinctrl-amd.c | 3 ++-
1 file changed
These two are the only write-able bits in this byte.
Therefore, it should be safe to just write these bits back as a byte
access without any additional locking.
Signed-off-by: Daniel Kurtz
---
drivers/pinctrl/pinctrl-amd.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git
These two are the only write-able bits in this byte.
Therefore, it should be safe to just write these bits back as a byte
access without any additional locking.
Signed-off-by: Daniel Kurtz
---
drivers/pinctrl/pinctrl-amd.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git
q().
Note: Is it possible that this bug was the source of the interrupt storm
on Ryzen when using chained interrupts before commit ba714a9c1dea85
("pinctrl/amd: Use regular interrupt instead of chained")?
Signed-off-by: Daniel Kurtz
---
drivers/pinctrl/pinctrl-amd.c | 3 ++-
1 file changed
It is always correct to subtract out the starting bytescount value. Even
in the case of 2^64 byte rollover (292 Million Years in the future
@ 48000 Hz) the math still works out.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
It is always correct to subtract out the starting bytescount value. Even
in the case of 2^64 byte rollover (292 Million Years in the future
@ 48000 Hz) the math still works out.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
anyway, disable it to save quite a few unnecessary interrupts.
The real "work" (calling snd_pcm_period_elapsed()) is done when transfer
from ACP to SYSRAM is complete.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 15 ---
1 file changed, 15 deletions(-)
diff --g
anyway, disable it to save quite a few unnecessary interrupts.
The real "work" (calling snd_pcm_period_elapsed()) is done when transfer
from ACP to SYSRAM is complete.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 15 ---
1 file changed, 15 deletions(-)
diff --g
ay/capture
repeated samples after the upstream circular DMA channel has already
stopped.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-d
ay/capture
repeated samples after the upstream circular DMA channel has already
stopped.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-d
, so remove this unnecessary code.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index 4665ae12e74e4..e6f85f2e5ac2a 100644
--- a/sound/soc/amd/acp-pcm
, so remove this unnecessary code.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index 4665ae12e74e4..e6f85f2e5ac2a 100644
--- a/sound/soc/amd/acp-pcm
On capture, audio data is first copied from I2S to ACP memory, and then
to SYSRAM. For each step the channel number increases, so the names in
the driver were wrong.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 24
sound/soc/amd/acp.h | 8
Now that the I2S channel names are fixed, and DMA data flow order is
consistent (ch1 then ch2), we can simplify channel start order:
start the upstream channel and then the downstream channel for both
playback and capture cases.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 9
On capture, audio data is first copied from I2S to ACP memory, and then
to SYSRAM. For each step the channel number increases, so the names in
the driver were wrong.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 24
sound/soc/amd/acp.h | 8
Now that the I2S channel names are fixed, and DMA data flow order is
consistent (ch1 then ch2), we can simplify channel start order:
start the upstream channel and then the downstream channel for both
playback and capture cases.
Signed-off-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c | 9
period granularity on hw pointer.
> Signed-off-by: Akshu Agrawal <akshu.agra...@amd.com>
Reviewed-by: Daniel Kurtz <djku...@chromium.org>
Tested-by: Daniel Kurtz <djku...@chromium.org>
> ---
> sound/soc/amd/acp-pcm-dma.c | 72
+++-
n hw pointer.
> Signed-off-by: Akshu Agrawal
Reviewed-by: Daniel Kurtz
Tested-by: Daniel Kurtz
> ---
> sound/soc/amd/acp-pcm-dma.c | 72
+++--
> 1 file changed, 10 insertions(+), 62 deletions(-)
> diff --git a/sound/soc/amd/acp-pcm-dma.c b/s
andler will create MMIO mappings to access the
> clock registers and enable the clock driver to expose the clock
> for use of drivers which will connect to it.
> Signed-off-by: Akshu Agrawal <akshu.agra...@amd.com>
Reviewed-by: Daniel Kurtz <djku...@chromium.org>
> ---
>
gs to access the
> clock registers and enable the clock driver to expose the clock
> for use of drivers which will connect to it.
> Signed-off-by: Akshu Agrawal
Reviewed-by: Daniel Kurtz
> ---
> v2: Submitted with dependent patch, removed unneeded kfree for
devm_kzalloc
>
On Wed, May 9, 2018 at 4:01 AM Akshu Agrawal <akshu.agra...@amd.com> wrote:
> Stoney SoC provides oscout clock. This clock can support 25Mhz and
> 48Mhz of frequency.
> The clock is available for general system use.
> Signed-off-by: Akshu Agrawal <akshu.agra...@amd.com&
On Wed, May 9, 2018 at 4:01 AM Akshu Agrawal wrote:
> Stoney SoC provides oscout clock. This clock can support 25Mhz and
> 48Mhz of frequency.
> The clock is available for general system use.
> Signed-off-by: Akshu Agrawal
Reviewed-by: Daniel Kurtz
> ---
> v2: config chan
On Thu, May 3, 2018 at 10:35 PM Agrawal, Akshu <akshu.agra...@amd.com>
wrote:
> On 5/3/2018 10:10 PM, Daniel Kurtz wrote:
> > On Thu, May 3, 2018 at 1:33 AM Mukunda,Vijendar <
vijendar.muku...@amd.com>
> > wrote:
> >
> >
> >
> >> On Thursda
On Thu, May 3, 2018 at 10:35 PM Agrawal, Akshu
wrote:
> On 5/3/2018 10:10 PM, Daniel Kurtz wrote:
> > On Thu, May 3, 2018 at 1:33 AM Mukunda,Vijendar <
vijendar.muku...@amd.com>
> > wrote:
> >
> >
> >
> >> On Thursday 03 May 2018 11:13 AM, Dani
current code of handling of mclk in the driver is usable only by DT.
> The device_property (though ACPI specific) makes this code, a common
> code for DT and ACPI based devices.
> https://www.kernel.org/doc/Documentation/acpi/DSD-properties-rules.txt
> "Still, for the sake of code re-use, it may make sense to provide as
> much of the configuration data as possible in the form of device
> properties and complement that with an ACPI-specific mechanism suitable
> for the use case at hand.."
This sounds like a pretty reasonable justification for addressing the issue
using DSD to me.
For what its worth, you can add:
Reviewed-by: Daniel Kurtz <djku...@chromium.org>
> Thanks,
> Akshu
only by DT.
> The device_property (though ACPI specific) makes this code, a common
> code for DT and ACPI based devices.
> https://www.kernel.org/doc/Documentation/acpi/DSD-properties-rules.txt
> "Still, for the sake of code re-use, it may make sense to provide as
> much of the configuration data as possible in the form of device
> properties and complement that with an ACPI-specific mechanism suitable
> for the use case at hand.."
This sounds like a pretty reasonable justification for addressing the issue
using DSD to me.
For what its worth, you can add:
Reviewed-by: Daniel Kurtz
> Thanks,
> Akshu
On Thu, May 3, 2018 at 1:33 AM Mukunda,Vijendar <vijendar.muku...@amd.com>
wrote:
> On Thursday 03 May 2018 11:13 AM, Daniel Kurtz wrote:
> > Some checkpatch nits below...
> >
> > On Tue, May 1, 2018 at 2:53 PM Vijendar Mukunda <
vijendar.muku...@amd.com>
On Thu, May 3, 2018 at 1:33 AM Mukunda,Vijendar
wrote:
> On Thursday 03 May 2018 11:13 AM, Daniel Kurtz wrote:
> > Some checkpatch nits below...
> >
> > On Tue, May 1, 2018 at 2:53 PM Vijendar Mukunda <
vijendar.muku...@amd.com>
> > wrote:
> >
> >&
Some checkpatch nits below...
On Tue, May 1, 2018 at 2:53 PM Vijendar Mukunda
wrote:
> With in ACP, There are three I2S controllers can be
> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
> Default enabled I2S controller instance is I2S SP.
> This patch provides
Some checkpatch nits below...
On Tue, May 1, 2018 at 2:53 PM Vijendar Mukunda
wrote:
> With in ACP, There are three I2S controllers can be
> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
> Default enabled I2S controller instance is I2S SP.
> This patch provides required changes to support
> Signed-off-by: Akshu Agrawal <akshu.agra...@amd.com>
> Signed-off-by: Vijendar Mukunda <vijendar.muku...@amd.com>
Reviewed-by: Daniel Kurtz <djku...@chromium.org>
> ---
> sound/soc/amd/acp-da7219-max98357a.c | 5 ++---
> 1 file changed, 2 insertions(+)
: Vijendar Mukunda
Reviewed-by: Daniel Kurtz
> ---
> sound/soc/amd/acp-da7219-max98357a.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> diff --git a/sound/soc/amd/acp-da7219-max98357a.c
b/sound/soc/amd/acp-da7219-max98357a.c
> index 6495eed..fa5ad5b 100644
> --- a/
jendar.muku...@amd.com>
Reviewed-by: Daniel Kurtz <djku...@chromium.org>
> ---
> sound/soc/amd/acp-da7219-max98357a.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> diff --git a/sound/soc/amd/acp-da7219-max98357a.c
b/sound/soc/amd/acp-da7219-max98357a.c
>
On Thu, Apr 26, 2018 at 5:18 AM Vijendar Mukunda
wrote:
> From: Akshu Agrawal
> Marking snd_soc_ops instances const
> Signed-off-by: Akshu Agrawal
> Signed-off-by: Vijendar Mukunda
Reviewed-by: Daniel Kurtz
> ---
> sound/soc/amd/acp-da7219-max98357a.c | 6 +++---
>
Hi Vijendar,
On Thu, Apr 26, 2018 at 5:14 AM Vijendar Mukunda
wrote:
> Added dma configuration parameters to rtd structure.
> Moved dma configuration parameters intialization to
> hw_params callback.
> Removed hard coding in prepare and trigger callbacks.
>
Hi Vijendar,
On Thu, Apr 26, 2018 at 5:14 AM Vijendar Mukunda
wrote:
> Added dma configuration parameters to rtd structure.
> Moved dma configuration parameters intialization to
> hw_params callback.
> Removed hard coding in prepare and trigger callbacks.
> Signed-off-by: Vijendar Mukunda
>
On Thu, Apr 26, 2018 at 5:16 AM Vijendar Mukunda
wrote:
> Added pte offset variable in audio_substream_data structure.
> Added Stoney related PTE offset macros in acp header file.
> Modified hw_params callback to assign the pte offset value
> based on asic_type.
>
On Thu, Apr 26, 2018 at 5:16 AM Vijendar Mukunda <vijendar.muku...@amd.com>
wrote:
> Added sram bank variable to audio_substream_data structure.
> Signed-off-by: Vijendar Mukunda <vijendar.muku...@amd.com>
Move initialization to acp_dma_open(), otherwise this is:
Reviewed-by:
On Thu, Apr 26, 2018 at 5:16 AM Vijendar Mukunda
wrote:
> Added pte offset variable in audio_substream_data structure.
> Added Stoney related PTE offset macros in acp header file.
> Modified hw_params callback to assign the pte offset value
> based on asic_type.
> Signed-off-by: Vijendar
On Thu, Apr 26, 2018 at 5:16 AM Vijendar Mukunda
wrote:
> Added sram bank variable to audio_substream_data structure.
> Signed-off-by: Vijendar Mukunda
Move initialization to acp_dma_open(), otherwise this is:
Reviewed-by: Daniel Kurtz
> ---
> sound/soc/amd/acp-pc
Hi Vijendar,
On Thu, Apr 26, 2018 at 5:15 AM Vijendar Mukunda <vijendar.muku...@amd.com>
wrote:
> Removed separate byte count variables for playback and capture.
> Signed-off-by: Vijendar Mukunda <vijendar.muku...@amd.com>
Reviewed-by: Daniel Kurtz <djku...@chromium.org&
Hi Vijendar,
On Thu, Apr 26, 2018 at 5:15 AM Vijendar Mukunda
wrote:
> Removed separate byte count variables for playback and capture.
> Signed-off-by: Vijendar Mukunda
Reviewed-by: Daniel Kurtz
> ---
> sound/soc/amd/acp-pcm-dma.c | 19 +--
> soun
Please fix the small indentation nits, otherwise this one is:
Reviewed-by: Daniel Kurtz <djku...@chromium.org>
> ---
> sound/soc/amd/acp-pcm-dma.c | 36 +++-
> sound/soc/amd/acp.h | 2 ++
> 2 files changed, 17 insertions(+), 21 deletio
Reviewed-by: Daniel Kurtz
> ---
> sound/soc/amd/acp-pcm-dma.c | 36 +++-
> sound/soc/amd/acp.h | 2 ++
> 2 files changed, 17 insertions(+), 21 deletions(-)
> diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
> in
On Mon, Apr 23, 2018 at 9:03 PM Vijendar Mukunda
wrote:
> From: Akshu Agrawal
> hw_param can be called multiple times and thus we can have
> more clk enable. The clk may not get diabled due to refcounting.
> startup/shutdown ensures single clk
On Mon, Apr 23, 2018 at 9:03 PM Vijendar Mukunda
wrote:
> From: Akshu Agrawal
> hw_param can be called multiple times and thus we can have
> more clk enable. The clk may not get diabled due to refcounting.
> startup/shutdown ensures single clk enable/disable call.
> Signed-off-by: Akshu
Hi Vijendar,
On Mon, Apr 23, 2018 at 9:02 PM Vijendar Mukunda
wrote:
> Added dma configuration parameters in audio_substream_data
> structure. Moved dma configuration parameters initialization
> to dma hw params callback.
> Removed separate byte count variables for
Hi Vijendar,
On Mon, Apr 23, 2018 at 9:02 PM Vijendar Mukunda
wrote:
> Added dma configuration parameters in audio_substream_data
> structure. Moved dma configuration parameters initialization
> to dma hw params callback.
> Removed separate byte count variables for playback and capture.
>
Hi Vijendar,
On Wed, Apr 18, 2018 at 5:02 AM Vijendar Mukunda
wrote:
> With in ACP, There are three I2S controllers can be
> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
> Default enabled I2S controller instance is I2S SP.
> This patch provides required changes to
Hi Vijendar,
On Wed, Apr 18, 2018 at 5:02 AM Vijendar Mukunda
wrote:
> With in ACP, There are three I2S controllers can be
> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
> Default enabled I2S controller instance is I2S SP.
> This patch provides required changes to support I2S BT
>
3509] 880107d4dd00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
fc
[6.613509]
==
Fixes: 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for stoney/cz")
Signed-off-by: Daniel Kurtz <djku...@chromium.org
3509] 880107d4dd00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
fc
[6.613509]
==
Fixes: 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for stoney/cz")
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/amd
using pointer array")
e4a9ea5ee7c8 ("tracing: Replace trace_event struct array with pointer array")
Let's use this same "array of pointers to structs" approach for
EARLYCON_TABLE.
Fixes: 99492c39f39f ("earlycon: Fix __earlycon_table stride")
Signed-off-by: Dani
using pointer array")
e4a9ea5ee7c8 ("tracing: Replace trace_event struct array with pointer array")
Let's use this same "array of pointers to structs" approach for
EARLYCON_TABLE.
Fixes: 99492c39f39f ("earlycon: Fix __earlycon_table stride")
Signed-off-by: Da
0 specific tuning for HS200, and otherwise
call back to the standard sdhci_execute_tuning().
Signed-off-by: Daniel Kurtz <djku...@chromium.org>
---
drivers/mmc/host/sdhci-pci-core.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/
0 specific tuning for HS200, and otherwise
call back to the standard sdhci_execute_tuning().
Signed-off-by: Daniel Kurtz
---
drivers/mmc/host/sdhci-pci-core.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pci-core.c
b/driver
Hi Jeffy,
Sorry for delayed response.
On Mon, Mar 26, 2018 at 1:58 AM JeffyChen <jeffy.c...@rock-chips.com> wrote:
> Hi Daniel,
> Thanks for your reply.
> On 03/26/2018 02:31 PM, Daniel Kurtz wrote:
> >> >+struct rk_iommudata {
> >> >+ struct r
Hi Jeffy,
Sorry for delayed response.
On Mon, Mar 26, 2018 at 1:58 AM JeffyChen wrote:
> Hi Daniel,
> Thanks for your reply.
> On 03/26/2018 02:31 PM, Daniel Kurtz wrote:
> >> >+struct rk_iommudata {
> >> >+ struct rk_iommu *iommu;
> >> >
> + .of_xlate = rk_iommu_of_xlate,
> };
> static int rk_iommu_probe(struct platform_device *pdev)
> @@ -1178,6 +1119,8 @@ static int rk_iommu_probe(struct platform_device
*pdev)
> goto err_unprepare_clocks;
> iommu_device_set_ops(>iommu, _iommu_ops);
> + iommu_device_set_fwnode(>iommu, >of_node->fwnode);
> +
> err = iommu_device_register(>iommu);
> if (err)
> goto err_remove_sysfs;
> @@ -1250,6 +1193,8 @@ static int __init rk_iommu_init(void)
> }
> subsys_initcall(rk_iommu_init);
> +IOMMU_OF_DECLARE(rk_iommu_of, "rockchip,iommu");
> +
> MODULE_DESCRIPTION("IOMMU API for Rockchip");
> MODULE_AUTHOR("Simon Xue <x...@rock-chips.com> and Daniel Kurtz <
djku...@chromium.org>");
> MODULE_ALIAS("platform:rockchip-iommu");
> --
> 2.11.0
.remove_device = rk_iommu_remove_device,
> .iova_to_phys = rk_iommu_iova_to_phys,
> + .device_group = generic_device_group,
> .pgsize_bitmap = RK_IOMMU_PGSIZE_BITMAP,
> + .of_xlate = rk_iommu_of_xlate,
> };
> static int rk_iommu_probe(struct
On Fri, Mar 23, 2018 at 7:34 AM Greg Kroah-Hartman <
gre...@linuxfoundation.org> wrote:
> On Tue, Mar 20, 2018 at 11:57:10AM -0600, Daniel Kurtz wrote:
> > The __earlycon_table lives in a special "__earlycon_table" section. The
> > contents of this table are added
On Fri, Mar 23, 2018 at 7:34 AM Greg Kroah-Hartman <
gre...@linuxfoundation.org> wrote:
> On Tue, Mar 20, 2018 at 11:57:10AM -0600, Daniel Kurtz wrote:
> > The __earlycon_table lives in a special "__earlycon_table" section. The
> > contents of this table are added
using pointer array")
e4a9ea5ee7c8 ("tracing: Replace trace_event struct array with pointer array")
Let's use this same "array of pointers to structs" approach for
EARLYCON_TABLE.
Fixes: 99492c39f39f ("earlycon: Fix __earlycon_table stride")
Signed-of
using pointer array")
e4a9ea5ee7c8 ("tracing: Replace trace_event struct array with pointer array")
Let's use this same "array of pointers to structs" approach for
EARLYCON_TABLE.
Fixes: 99492c39f39f ("earlycon: Fix __earlycon_table stride")
Signed-off-by:
using pointer array")
e4a9ea5ee7c8 ("tracing: Replace trace_event struct array with pointer array")
Let's use this same "array of pointers to structs" approach for
EARLYCON_TABLE.
Change-Id: Ic42c4db0c8b034fa6aa2bf02eef0fdc159478ac4
Fixes: 99492c39f39f ("earl
using pointer array")
e4a9ea5ee7c8 ("tracing: Replace trace_event struct array with pointer array")
Let's use this same "array of pointers to structs" approach for
EARLYCON_TABLE.
Change-Id: Ic42c4db0c8b034fa6aa2bf02eef0fdc159478ac4
Fixes: 99492c39f39f ("earlycon:
alignment using pointer array")
e4a9ea5ee7c8 ("tracing: Replace trace_event struct array with pointer array")
Let's use this same "array of pointers to structs" approach for
EARLYCON_TABLE.
Fixes: 99492c39f39f ("earlycon: Fix __earlycon_table stride")
Signed-of
alignment using pointer array")
e4a9ea5ee7c8 ("tracing: Replace trace_event struct array with pointer array")
Let's use this same "array of pointers to structs" approach for
EARLYCON_TABLE.
Fixes: 99492c39f39f ("earlycon: Fix __earlycon_table stride")
Signed-off-by:
alignment using pointer array")
e4a9ea5ee7c8 ("tracing: Replace trace_event struct array with pointer array")
Let's use this same "array of pointers to structs" approach for
EARLYCON_TABLE.
Fixes: 99492c39f39f ("earlycon: Fix __earlycon_table stride")
Signed-of
alignment using pointer array")
e4a9ea5ee7c8 ("tracing: Replace trace_event struct array with pointer array")
Let's use this same "array of pointers to structs" approach for
EARLYCON_TABLE.
Fixes: 99492c39f39f ("earlycon: Fix __earlycon_table stride")
Signed-
s is a fix that should hopefully fix a kbuild error that
seems to be triggered by Patch 2.
Daniel Kurtz (2):
serial: sh-sci: Remove __initdata attribute for struct 'port_cfg'
earlycon: Use a pointer table to fix __earlycon_table stride
drivers/of/fdt.c | 7 +--
drivers/
s is a fix that should hopefully fix a kbuild error that
seems to be triggered by Patch 2.
Daniel Kurtz (2):
serial: sh-sci: Remove __initdata attribute for struct 'port_cfg'
earlycon: Use a pointer table to fix __earlycon_table stride
drivers/of/fdt.c | 7 +--
drivers/
1 - 100 of 894 matches
Mail list logo