Re: [PATCH] drm/rockchip: fix dma_alloc_attrs() error check

2015-01-20 Thread Daniel Kurtz
Mark: did you get a chance to fixup the "Reported-by" line? It's not a bit deal if you didn't. Dave: did you pick up this pull request? Did Mark request properly? On Fri, Jan 9, 2015 at 12:01 PM, Daniel Kurtz wrote: > On Wed, Jan 7, 2015 at 5:27 PM, Daniel Kurtz wrote: >&

Re: [PATCH] drm/rockchip: fix dma_alloc_attrs() error check

2015-01-20 Thread Daniel Kurtz
Mark: did you get a chance to fixup the Reported-by line? It's not a bit deal if you didn't. Dave: did you pick up this pull request? Did Mark request properly? On Fri, Jan 9, 2015 at 12:01 PM, Daniel Kurtz djku...@chromium.org wrote: On Wed, Jan 7, 2015 at 5:27 PM, Daniel Kurtz djku

Re: [PATCH v2] thermal: rockchip: make temperature reporting much more accurate

2015-01-18 Thread Daniel Kurtz
Hi Caesar, Some drive-by review comments inline... On Mon, Jan 19, 2015 at 7:55 AM, Caesar Wang wrote: > In general, the kernel should report temperature readings exactly as > reported by the hardware. The cpu / gpu thermal driver works in 5 degree > increments,but we ought to do more accurate.

Re: [PATCH v2] thermal: rockchip: make temperature reporting much more accurate

2015-01-18 Thread Daniel Kurtz
Hi Caesar, Some drive-by review comments inline... On Mon, Jan 19, 2015 at 7:55 AM, Caesar Wang w...@rock-chips.com wrote: In general, the kernel should report temperature readings exactly as reported by the hardware. The cpu / gpu thermal driver works in 5 degree increments,but we ought to

Re: [PATCH v3] drm/panel: Add support for AUO b101ean01 panel

2015-01-16 Thread Daniel Kurtz
On Fri, Jan 16, 2015 at 11:14 AM, Daniel Kurtz wrote: > > On Fri, Jan 16, 2015 at 10:36 AM, huang lin wrote: > > The AUO b101ean01 panel is a 10.1" 1280x800 panel, > > which can be supported by the simple panel driver. > > > > Signed-off-by: huang li

Re: [PATCH v3] drm/panel: Add support for AUO b101ean01 panel

2015-01-16 Thread Daniel Kurtz
On Fri, Jan 16, 2015 at 11:14 AM, Daniel Kurtz djku...@chromium.org wrote: On Fri, Jan 16, 2015 at 10:36 AM, huang lin h...@rock-chips.com wrote: The AUO b101ean01 panel is a 10.1 1280x800 panel, which can be supported by the simple panel driver. Signed-off-by: huang lin h...@rock

Re: [PATCH v3] drm/panel: Add support for AUO b101ean01 panel

2015-01-15 Thread Daniel Kurtz
On Fri, Jan 16, 2015 at 10:36 AM, huang lin wrote: > The AUO b101ean01 panel is a 10.1" 1280x800 panel, > which can be supported by the simple panel driver. > > Signed-off-by: huang lin Reviewed-by: Daniel Kurtz > > --- > > Changes in v3: > - changed moving

Re: [PATCH v3] drm/panel: Add support for AUO b101ean01 panel

2015-01-15 Thread Daniel Kurtz
On Fri, Jan 16, 2015 at 10:36 AM, huang lin h...@rock-chips.com wrote: The AUO b101ean01 panel is a 10.1 1280x800 panel, which can be supported by the simple panel driver. Signed-off-by: huang lin h...@rock-chips.com Reviewed-by: Daniel Kurtz djku...@chromium.org --- Changes in v3

Re: [PATCH v2] drm/panel: Add support for AUO b101ean01 panel

2015-01-14 Thread Daniel Kurtz
b/drivers/gpu/drm/panel/panel-simple.c > @@ -392,6 +392,29 @@ static const struct panel_desc auo_b116xw03 = { > }, > }; > > +static const struct drm_display_mode auo_b101ean01_mode = { Perhaps you missed my last review where I suggested moving the definitions for auo_b101ean0

Re: [PATCH v2] drm/panel: Add support for AUO b101ean01 panel

2015-01-14 Thread Daniel Kurtz
is Reviewed-by: Daniel Kurtz djku...@chromium.org + .clock = 72500, + .hdisplay = 1280, + .hsync_start = 1280 + 147, + .hsync_end = 1280 + 147 + 32, + .htotal = 1280 + 147 + 32 + 21, + .vdisplay = 800, + .vsync_start = 800 + 4, + .vsync_end = 800 + 4

[PATCH] drm/rockchip: Only alloc a kmap for fbdev gem object

2015-01-11 Thread Daniel Kurtz
(s), which may be written in-kernel by fbcon. Signed-off-by: Daniel Kurtz --- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 - drivers/gpu/drm/rockchip/rockchip_drm_gem.h | 3 ++- 3 files changed, 15 insertions(+), 7

[PATCH] drm/rockchip: Only alloc a kmap for fbdev gem object

2015-01-11 Thread Daniel Kurtz
(s), which may be written in-kernel by fbcon. Signed-off-by: Daniel Kurtz djku...@chromium.org --- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 - drivers/gpu/drm/rockchip/rockchip_drm_gem.h | 3 ++- 3 files changed

Re: [PATCH] drm/rockchip: fix dma_alloc_attrs() error check

2015-01-08 Thread Daniel Kurtz
On Wed, Jan 7, 2015 at 5:27 PM, Daniel Kurtz wrote: > dma_alloc_attrs() returns NULL if it cannot allocate a dma buffer (or > mapping), not a negative error code. > > Rerported-by: Pawel Osciak Oops! I just noticed that this is spelled wrong. Should be "Reported-by".

Re: [PATCH] drm/panel: Add support for AUO b101ean01 panel

2015-01-08 Thread Daniel Kurtz
Hi hl, Thanks for submitting this patch. On Fri, Jan 9, 2015 at 9:47 AM, huang lin wrote: > > The AUO b101ean01 panel is a 10.1" 1280x800 panel, > which can be supported by the simple panel driver. > > Signed-off-by: huang lin > > --- > > drivers/gpu/drm/panel/panel-simple.c | 26

Re: [PATCH] drm/panel: Add support for AUO b101ean01 panel

2015-01-08 Thread Daniel Kurtz
Hi hl, Thanks for submitting this patch. On Fri, Jan 9, 2015 at 9:47 AM, huang lin h...@rock-chips.com wrote: The AUO b101ean01 panel is a 10.1 1280x800 panel, which can be supported by the simple panel driver. Signed-off-by: huang lin h...@rock-chips.com ---

Re: [PATCH] drm/rockchip: fix dma_alloc_attrs() error check

2015-01-08 Thread Daniel Kurtz
On Wed, Jan 7, 2015 at 5:27 PM, Daniel Kurtz djku...@chromium.org wrote: dma_alloc_attrs() returns NULL if it cannot allocate a dma buffer (or mapping), not a negative error code. Rerported-by: Pawel Osciak posc...@chromium.org Oops! I just noticed that this is spelled wrong. Should

[PATCH] drm/rockchip: fix dma_alloc_attrs() error check

2015-01-07 Thread Daniel Kurtz
dma_alloc_attrs() returns NULL if it cannot allocate a dma buffer (or mapping), not a negative error code. Rerported-by: Pawel Osciak Signed-off-by: Daniel Kurtz --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH] drm/rockchip: fix dma_alloc_attrs() error check

2015-01-07 Thread Daniel Kurtz
dma_alloc_attrs() returns NULL if it cannot allocate a dma buffer (or mapping), not a negative error code. Rerported-by: Pawel Osciak posc...@chromium.org Signed-off-by: Daniel Kurtz djku...@chromium.org --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 9 +++-- 1 file changed, 3 insertions

Re: [PATCH v18 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-10 Thread Daniel Kurtz
Hi Andy, This driver adds HDMI to rockchip/drm. The fact that rockchip's hdmi uses dw_hdmi is an implementation detail. I do not think that the names used for rk3288-hdmi should include "dw" in them. See inline for what I mean... On Thu, Dec 4, 2014 at 10:34 PM, Andy Yan wrote: > Rockchip

Re: [PATCH v18 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-10 Thread Daniel Kurtz
Hi Andy, This driver adds HDMI to rockchip/drm. The fact that rockchip's hdmi uses dw_hdmi is an implementation detail. I do not think that the names used for rk3288-hdmi should include dw in them. See inline for what I mean... On Thu, Dec 4, 2014 at 10:34 PM, Andy Yan andy@rock-chips.com

Re: [PATCH v15 0/3] Add drm driver for Rockchip Socs

2014-12-04 Thread Daniel Kurtz
On Tue, Dec 2, 2014 at 1:31 AM, Heiko Stübner wrote: > Hi Mark, > > Am Dienstag, 2. Dezember 2014, 17:13:20 schrieb Mark Yao: >> This a series of patches is a DRM Driver for Rockchip Socs, add support >> for vop devices. Future patches will add additional encoders/connectors, >> such as eDP,

Re: [PATCH v15 0/3] Add drm driver for Rockchip Socs

2014-12-04 Thread Daniel Kurtz
On Tue, Dec 2, 2014 at 1:31 AM, Heiko Stübner he...@sntech.de wrote: Hi Mark, Am Dienstag, 2. Dezember 2014, 17:13:20 schrieb Mark Yao: This a series of patches is a DRM Driver for Rockchip Socs, add support for vop devices. Future patches will add additional encoders/connectors, such as

Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs

2014-11-27 Thread Daniel Kurtz
On Thu, Nov 27, 2014 at 2:08 AM, Mark yao wrote: > > On 2014年11月27日 10:12, Dave Airlie wrote: >>> Hi Dave >>> Do you mean that I need send you a branch, based on drm-next, merge >>> with >>> iommu tree and rockchip drm? >> >> Yes, grab drm-next, git pull the arm/rockchip branch

Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs

2014-11-27 Thread Daniel Kurtz
On Thu, Nov 27, 2014 at 2:08 AM, Mark yao mark@rock-chips.com wrote: On 2014年11月27日 10:12, Dave Airlie wrote: Hi Dave Do you mean that I need send you a branch, based on drm-next, merge with iommu tree and rockchip drm? Yes, grab drm-next, git pull the arm/rockchip branch from

Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-15 Thread Daniel Kurtz
On Fri, Nov 14, 2014 at 7:13 PM, Zubair Lutfullah Kakakhel wrote: > > > On 14/11/14 11:08, Andy Yan wrote: >> >> On 2014年11月14日 18:55, Zubair Lutfullah Kakakhel wrote: >>> >>> On 14/11/14 10:53, Andy Yan wrote: Hi ZubairLK: Thanks for your review. On 2014年11月14日 18:19, Zubair

Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-15 Thread Daniel Kurtz
On Fri, Nov 14, 2014 at 7:13 PM, Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com wrote: On 14/11/14 11:08, Andy Yan wrote: On 2014年11月14日 18:55, Zubair Lutfullah Kakakhel wrote: On 14/11/14 10:53, Andy Yan wrote: Hi ZubairLK: Thanks for your review. On 2014年11月14日 18:19, Zubair

Re: [PATCH v11 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-14 Thread Daniel Kurtz
yte register width access > drm: bridge/dw_hdmi: add mode_valid support > drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done > drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare > dt-bindings: Add documentation for rockchip dw hdmi > drm: bri

Re: [PATCH v11 02/12] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter

2014-11-14 Thread Daniel Kurtz
->ddc) { > dev_dbg(hdmi->dev, "failed to read ddc node\n"); > + of_node_put(ddc_node); > + return -EPROBE_DEFER; > + } Nit: You could move "of_node_put()" above &quo

Re: [PATCH v11 01/12] staging: imx-drm: imx-hdmi: make checkpatch happy

2014-11-14 Thread Daniel Kurtz
all arms of this statement > + if (hdmi->hdmi_data.video_mode.mdvi) > [...] > + else { > [...] > > Signed-off-by: Andy Yan Reviewed-by: Daniel Kurtz > > --- > > Changes in v11: None > Changes in v10: None > Changes in v9: None > Changes in v8: None

Re: [PATCH v11 01/12] staging: imx-drm: imx-hdmi: make checkpatch happy

2014-11-14 Thread Daniel Kurtz
+ if (hdmi-hdmi_data.video_mode.mdvi) [...] + else { [...] Signed-off-by: Andy Yan andy@rock-chips.com Reviewed-by: Daniel Kurtz djku...@chromium.org --- Changes in v11: None Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6

Re: [PATCH v11 02/12] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter

2014-11-14 Thread Daniel Kurtz
); + of_node_put(ddc_node); + return -EPROBE_DEFER; + } Nit: You could move of_node_put() above if (!hdmi-ddc), and not need it in two places. Either way, this one is: Reviewed-by: Daniel Kurtz djku...@chromium.org of_node_put(ddc_node); } else

Re: [PATCH v11 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-14 Thread Daniel Kurtz
: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare dt-bindings: Add documentation for rockchip dw hdmi drm: bridge/dw_hdmi: add rockchip rk3288 support Yakir Yang (1): drm: bridge/dw_hdmi: convert dw-hdmi to drm_bridge mode Patch 1 2 are: Reviewed-by: Daniel Kurtz djku

Re: [PATCH v11 2/3] power-domain: rockchip: add power doamin driver

2014-11-13 Thread Daniel Kurtz
Caesar, One more little nit: The title of this patch has a typo: doamin -> domain Thanks, -Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 2/3] power-domain: rockchip: add power doamin driver

2014-11-13 Thread Daniel Kurtz
On Thu, Nov 13, 2014 at 6:01 AM, Caesar Wang wrote: > In order to meet high performance and low power requirements, a power > management unit is designed or saving power when RK3288 in low power mode. > The RK3288 PMU is dedicated for managing the power ot the whole chip. > > Signed-off-by: Jack

Re: [PATCH v11 2/3] power-domain: rockchip: add power doamin driver

2014-11-13 Thread Daniel Kurtz
On Thu, Nov 13, 2014 at 6:01 AM, Caesar Wang caesar.w...@rock-chips.com wrote: In order to meet high performance and low power requirements, a power management unit is designed or saving power when RK3288 in low power mode. The RK3288 PMU is dedicated for managing the power ot the whole chip.

Re: [PATCH v11 2/3] power-domain: rockchip: add power doamin driver

2014-11-13 Thread Daniel Kurtz
Caesar, One more little nit: The title of this patch has a typo: doamin - domain Thanks, -Dan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v7 1/3] iommu/rockchip: rk3288 iommu driver

2014-11-02 Thread Daniel Kurtz
nodes for "iommus" property - store platform device pointer as group iommudata - Check for existence of iommu group instead of relying on a dev_get_drvdata() to return NULL for a NULL device. v7: - fixup some strings. - In rk_iommu_disable_paging() # and % were

[PATCH v7 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-11-02 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue Reviewed-by: Heiko Stuebner --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v7 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-11-02 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- arch/arm/boot/dts

[PATCH v7 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-11-02 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com Reviewed-by: Heiko Stuebner he...@sntech.de --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26

[PATCH v7 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-11-02 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x

[PATCH v7 1/3] iommu/rockchip: rk3288 iommu driver

2014-11-02 Thread Daniel Kurtz
device pointer as group iommudata - Check for existence of iommu group instead of relying on a dev_get_drvdata() to return NULL for a NULL device. v7: - fixup some strings. - In rk_iommu_disable_paging() # and % were reversed. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed

[PATCH v6 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-27 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- arch/arm/boot/dts

[PATCH v6 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-27 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/iommu/rockchip,iommu.txt

[PATCH v6 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-27 Thread Daniel Kurtz
device tree nodes for "iommus" property - store platform device pointer as group iommudata - Check for existence of iommu group instead of relying on a dev_get_drvdata() to return NULL for a NULL device. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue Reviewed-b

Re: [PATCH v5 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-27 Thread Daniel Kurtz
On Mon, Oct 27, 2014 at 4:32 AM, Heiko Stübner wrote: > Hi Daniel, > > Am Freitag, 24. Oktober 2014, 15:33:47 schrieb Daniel Kurtz: > > [...] > >> +static int rk_iommu_attach_device(struct iommu_domain *domain, >> + struct device *dev)

Re: [PATCH v5 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-27 Thread Daniel Kurtz
On Mon, Oct 27, 2014 at 4:32 AM, Heiko Stübner he...@sntech.de wrote: Hi Daniel, Am Freitag, 24. Oktober 2014, 15:33:47 schrieb Daniel Kurtz: [...] +static int rk_iommu_attach_device(struct iommu_domain *domain, + struct device *dev) +{ + struct rk_iommu

[PATCH v6 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-27 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation

[PATCH v6 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-27 Thread Daniel Kurtz
platform device pointer as group iommudata - Check for existence of iommu group instead of relying on a dev_get_drvdata() to return NULL for a NULL device. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com Reviewed-by: Grant Grundler grund

[PATCH v6 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-27 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x

[PATCH v5 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-24 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/iommu/rockchip,iommu.txt

[PATCH v5 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-24 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- arch/arm/boot/dts

[PATCH v5 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-24 Thread Daniel Kurtz
efore point to the same page table. Thus, the iommu domain maintains a list of iommu devices which are attached. This driver relies on the iommu core to ensure that all devices have detached before destroying a domain. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue Reviewed-by: Grant G

[PATCH v5 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-24 Thread Daniel Kurtz
, the iommu domain maintains a list of iommu devices which are attached. This driver relies on the iommu core to ensure that all devices have detached before destroying a domain. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com Reviewed-by: Grant Grundler grund

[PATCH v5 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-24 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x

[PATCH v5 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-24 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation

Re: [PATCH 0/3] Rockchip IOMMU driver and devicetree bindings

2014-10-23 Thread Daniel Kurtz
On Wed, Oct 22, 2014 at 11:20 PM, Joerg Roedel wrote: > On Wed, Oct 01, 2014 at 06:20:40PM +0800, Daniel Kurtz wrote: >> Add a driver and devicetree bindings for the IOMMU found in Rockchip RK3288 >> SoCs. >> >> Daniel Kurtz (3): >> iommu/rockchip: rk3288 iom

Re: [PATCH 0/3] Rockchip IOMMU driver and devicetree bindings

2014-10-23 Thread Daniel Kurtz
On Wed, Oct 22, 2014 at 11:20 PM, Joerg Roedel j...@8bytes.org wrote: On Wed, Oct 01, 2014 at 06:20:40PM +0800, Daniel Kurtz wrote: Add a driver and devicetree bindings for the IOMMU found in Rockchip RK3288 SoCs. Daniel Kurtz (3): iommu/rockchip: rk3288 iommu driver dt-bindings: iommu

Re: [PATCH v5 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-16 Thread Daniel Kurtz
On Tue, Oct 14, 2014 at 4:02 PM, Daniel Kurtz wrote: > The rk3288 has several iommus. Each iommu belongs to a single master > device. There is one device (ISP) that has two slave iommus, but that > case is not yet supported by this driver. > > At subsys init, the iommu driver r

Re: [PATCH v5 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-16 Thread Daniel Kurtz
On Tue, Oct 14, 2014 at 4:02 PM, Daniel Kurtz djku...@chromium.org wrote: The rk3288 has several iommus. Each iommu belongs to a single master device. There is one device (ISP) that has two slave iommus, but that case is not yet supported by this driver. At subsys init, the iommu driver

[PATCH v5 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-14 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/iommu/rockchip,iommu.txt

[PATCH v5 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-14 Thread Daniel Kurtz
efore point to the same page table. Thus, the iommu domain maintains a list of iommu devices which are attached. This driver relies on the iommu core to ensure that all devices have detached before destroying a domain. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue Reviewed-by: Grant G

[PATCH v5 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-14 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- arch/arm/boot/dts

[PATCH v4 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-14 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/iommu/rockchip,iommu.txt

[PATCH v4 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-14 Thread Daniel Kurtz
efore point to the same page table. Thus, the iommu domain maintains a list of iommu devices which are attached. This driver relies on the iommu core to ensure that all devices have detached before destroying a domain. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue Reviewed-by: Grant G

[PATCH v4 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-14 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- arch/arm/boot/dts

Re: [PATCH v3 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-14 Thread Daniel Kurtz
On Tue, Oct 14, 2014 at 6:33 AM, Heiko Stübner wrote: > Hi Daniel, > > Am Samstag, 11. Oktober 2014, 02:30:48 schrieb Daniel Kurtz: >> Add device nodes for the VOP iommus. >> Device nodes for other iommus will be added in later patches. >> >> The iommu no

Re: [PATCH v3 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-14 Thread Daniel Kurtz
On Tue, Oct 14, 2014 at 6:33 AM, Heiko Stübner he...@sntech.de wrote: Hi Daniel, Am Samstag, 11. Oktober 2014, 02:30:48 schrieb Daniel Kurtz: Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property

[PATCH v4 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-14 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x

[PATCH v4 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-14 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation

[PATCH v4 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-14 Thread Daniel Kurtz
, the iommu domain maintains a list of iommu devices which are attached. This driver relies on the iommu core to ensure that all devices have detached before destroying a domain. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com Reviewed-by: Grant Grundler grund

[PATCH v5 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-14 Thread Daniel Kurtz
, the iommu domain maintains a list of iommu devices which are attached. This driver relies on the iommu core to ensure that all devices have detached before destroying a domain. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com Reviewed-by: Grant Grundler grund

[PATCH v5 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-14 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x

[PATCH v5 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-14 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation

[PATCH v3 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-10 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- arch/arm/boot/dts

[PATCH v3 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-10 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/iommu/rockchip,iommu.txt

[PATCH v3 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-10 Thread Daniel Kurtz
put spinlocks together - Reword comment in map/unmap about > 4MB mappings Changes in v3: - select ARM_DMA_USE_IOMMU Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue Reviewed-by: Grant Grundler Reviewed-by: Stéphane Marchesin --- drivers/iommu/Kconfig | 12 + drivers/iommu/Makef

[PATCH v3 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-10 Thread Daniel Kurtz
/unmap about 4MB mappings Changes in v3: - select ARM_DMA_USE_IOMMU Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com Reviewed-by: Grant Grundler grund...@chromium.org Reviewed-by: Stéphane Marchesin marc...@chromium.org --- drivers/iommu/Kconfig

[PATCH v3 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-10 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation

[PATCH v3 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-10 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x

[PATCH v2 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-07 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- arch/arm/boot/dts

[PATCH v2 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-07 Thread Daniel Kurtz
put spinlocks together - Reword comment in map/unmap about > 4MB mappings Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue Reviewed-by: Grant Grundler Reviewed-by: Stéphane Marchesin --- drivers/iommu/Kconfig | 11 + drivers/iommu/Makefile |

[PATCH v2 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-07 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/iommu/rockchip,iommu.txt

[PATCH v2 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-07 Thread Daniel Kurtz
/unmap about 4MB mappings Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com Reviewed-by: Grant Grundler grund...@chromium.org Reviewed-by: Stéphane Marchesin marc...@chromium.org --- drivers/iommu/Kconfig | 11 + drivers/iommu/Makefile

[PATCH v2 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-07 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation

[PATCH v2 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-07 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x

[PATCH 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-01 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- arch/arm/boot/dts

[PATCH 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-01 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/iommu/rockchip,iommu.txt

[PATCH 0/3] Rockchip IOMMU driver and devicetree bindings

2014-10-01 Thread Daniel Kurtz
Add a driver and devicetree bindings for the IOMMU found in Rockchip RK3288 SoCs. Daniel Kurtz (3): iommu/rockchip: rk3288 iommu driver dt-bindings: iommu: Add documentation for rockchip iommu ARM: dts: rk3288: add VOP iommu nodes .../devicetree/bindings/iommu/rockchip,iommu.txt | 26

[PATCH 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-01 Thread Daniel Kurtz
efore point to the same page table. Thus, the iommu domain maintains a list of iommu devices which are attached. This driver relies on the iommu core to ensure that all devices have detached before destroying a domain. Signed-off-by: Daniel Kurtz Signed-off-by: Simon Xue --- drivers/iommu

[PATCH 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-01 Thread Daniel Kurtz
, the iommu domain maintains a list of iommu devices which are attached. This driver relies on the iommu core to ensure that all devices have detached before destroying a domain. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com --- drivers/iommu/Kconfig

[PATCH 0/3] Rockchip IOMMU driver and devicetree bindings

2014-10-01 Thread Daniel Kurtz
Add a driver and devicetree bindings for the IOMMU found in Rockchip RK3288 SoCs. Daniel Kurtz (3): iommu/rockchip: rk3288 iommu driver dt-bindings: iommu: Add documentation for rockchip iommu ARM: dts: rk3288: add VOP iommu nodes .../devicetree/bindings/iommu/rockchip,iommu.txt | 26

[PATCH 2/3] dt-bindings: iommu: Add documentation for rockchip iommu

2014-10-01 Thread Daniel Kurtz
Add binding documentation for Rockchip IOMMU. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x...@rock-chips.com --- .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation

[PATCH 3/3] ARM: dts: rk3288: add VOP iommu nodes

2014-10-01 Thread Daniel Kurtz
Add device nodes for the VOP iommus. Device nodes for other iommus will be added in later patches. The iommu nodes use the #iommu-cells property as described in: Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Simon Xue x

Re: [RESENT PATCH v7 1/3] drm: rockchip: Add basic drm driver

2014-09-28 Thread Daniel Kurtz
Hi Mark, More review comments inline... (sorry for the delay) On Fri, Sep 26, 2014 at 6:55 PM, Mark Yao wrote: > From: Mark yao > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark Yao > Signed-off-by: Daniel Kurtz > Ac

Re: [RESENT PATCH v7 1/3] drm: rockchip: Add basic drm driver

2014-09-28 Thread Daniel Kurtz
-chips.com Signed-off-by: Daniel Kurtz djku...@chromium.org Acked-by: Daniel Vetter dan...@ffwll.ch Reviewed-by: Rob Clark robdcl...@gmail.com --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API

Re: [PATCH] drm/exynos/fbdev: set smem_len for fbdev

2014-09-25 Thread Daniel Kurtz
On Thu, Sep 25, 2014 at 5:32 PM, Geert Uytterhoeven wrote: > On Sun, Aug 24, 2014 at 4:50 PM, Daniel Kurtz wrote: >> Commit [0] stopped setting fix.smem_start and fix.smem_len when creating >> the fbdev. >> >> [0] 2f1eab8d8ab59e799f7d51d62410b398607a7bc3 >> drm

Re: [PATCH] drm/exynos/fbdev: set smem_len for fbdev

2014-09-25 Thread Daniel Kurtz
On Thu, Sep 25, 2014 at 5:32 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Sun, Aug 24, 2014 at 4:50 PM, Daniel Kurtz djku...@chromium.org wrote: Commit [0] stopped setting fix.smem_start and fix.smem_len when creating the fbdev. [0] 2f1eab8d8ab59e799f7d51d62410b398607a7bc3 drm

Re: [PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-24 Thread Daniel Kurtz
Hi Mark, Please review comments inline... On Wed, Sep 24, 2014 at 10:12 AM, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao > --- > Changes in v2: > - use the component framework to defer main drm driver probe > until all

Re: [PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-24 Thread Daniel Kurtz
Hi Mark, Please review comments inline... On Wed, Sep 24, 2014 at 10:12 AM, Mark yao mark@rock-chips.com wrote: This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao mark@rock-chips.com --- Changes in v2: - use the component framework to

<    3   4   5   6   7   8   9   >