On Mon, Feb 05, 2018 at 04:49:35PM +, mario.limoncie...@dell.com wrote:
> > -Original Message-
> > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com]
> > Sent: Sunday, February 4, 2018 8:28 AM
> > To: Pali Rohár
> > Cc: Limonciello, Mario ; Dar
us_get_device(handle, ) != 0)
> - return AE_OK;
> -
> - if (acpi_match_device_ids(dev, ids) == 0)
> - if (acpi_create_platform_device(dev, NULL))
> - dev_info(>dev,
> - "intel-vbtn: created platform device\n");
> -
> - return AE_OK;
> -}
> -
> -static int __init intel_vbtn_init(void)
> -{
> - acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
> - ACPI_UINT32_MAX, check_acpi_dev, NULL,
> - (void *)intel_vbtn_ids, NULL);
> -
> - return platform_driver_register(_vbtn_pl_driver);
> -}
> -module_init(intel_vbtn_init);
> -
> -static void __exit intel_vbtn_exit(void)
> -{
> - platform_driver_unregister(_vbtn_pl_driver);
> -}
> -module_exit(intel_vbtn_exit);
> +module_acpi_driver(intel_vbtn_driver);
> --
> 2.15.1
>
>
--
Darren Hart
VMware Open Source Technology Center
eturn AE_OK;
> -
> - if (acpi_match_device_ids(dev, ids) == 0)
> - if (acpi_create_platform_device(dev, NULL))
> - dev_info(>dev,
> - "intel-vbtn: created platform device\n");
> -
> - return AE_OK;
> -}
> -
> -static int __init intel_vbtn_init(void)
> -{
> - acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
> - ACPI_UINT32_MAX, check_acpi_dev, NULL,
> - (void *)intel_vbtn_ids, NULL);
> -
> - return platform_driver_register(_vbtn_pl_driver);
> -}
> -module_init(intel_vbtn_init);
> -
> -static void __exit intel_vbtn_exit(void)
> -{
> - platform_driver_unregister(_vbtn_pl_driver);
> -}
> -module_exit(intel_vbtn_exit);
> +module_acpi_driver(intel_vbtn_driver);
> --
> 2.15.1
>
>
--
Darren Hart
VMware Open Source Technology Center
On Wed, Jan 31, 2018 at 09:55:13PM +, Vadim Pasternak wrote:
> Add hotplug platform driver un-registration in case regmap cache
> synchronization failed. In such case hotplug platform driver registration
> should be rolled back.
Queued up, thanks Vadim.
--
Darren Hart
VMware Op
On Wed, Jan 31, 2018 at 09:55:13PM +, Vadim Pasternak wrote:
> Add hotplug platform driver un-registration in case regmap cache
> synchronization failed. In such case hotplug platform driver registration
> should be rolled back.
Queued up, thanks Vadim.
--
Darren Hart
VMware Op
On Wed, Jan 31, 2018 at 08:59:20PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 31, 2018 at 8:50 PM, Darren Hart <dvh...@infradead.org> wrote:
> > On Wed, Jan 31, 2018 at 07:54:06PM +0200, Andy Shevchenko wrote:
> >> Some headers are not needed since the driver can be buil
On Wed, Jan 31, 2018 at 08:59:20PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 31, 2018 at 8:50 PM, Darren Hart wrote:
> > On Wed, Jan 31, 2018 at 07:54:06PM +0200, Andy Shevchenko wrote:
> >> Some headers are not needed since the driver can be built as module.
> >> Re
n.
> So, it looks similar to some extent and I have no objection on that
> kind of approach.
Late to the party it seems, but FWIW:
I don't see a significant advantage of a global buffer. It doesn't *need* to be
global, and the locking just adds complexity. The heap solution seems much
preferable to me.
--
Darren Hart
VMware Open Source Technology Center
o some extent and I have no objection on that
> kind of approach.
Late to the party it seems, but FWIW:
I don't see a significant advantage of a global buffer. It doesn't *need* to be
global, and the locking just adds complexity. The heap solution seems much
preferable to me.
--
Darren Hart
VMware Open Source Technology Center
On Wed, Jan 31, 2018 at 07:54:07PM +0200, Andy Shevchenko wrote:
> Replace License short header by SPDX identifier.
>
> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
Reviewed-by: Darren Hart (VMware) <dvh...@infradead.org>
> ---
> drivers/pla
On Wed, Jan 31, 2018 at 07:54:07PM +0200, Andy Shevchenko wrote:
> Replace License short header by SPDX identifier.
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Darren Hart (VMware)
> ---
> drivers/platform/x86/intel-vbtn.c | 12 +---
> 1 file changed,
s case,
the implicit includes are reasonable expectations as they are tightly
coupled with the parent include.
Reviewed-by: Darren Hart (VMware) <dvh...@infradead.org>
>
> While here, sort headers alphabetically.
>
> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.
s case,
the implicit includes are reasonable expectations as they are tightly
coupled with the parent include.
Reviewed-by: Darren Hart (VMware)
>
> While here, sort headers alphabetically.
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/platform/x86/intel-vbtn.c | 8 +++--
On Fri, Jan 26, 2018 at 03:41:17PM -0800, Darren Hart wrote:
> On Fri, Jan 26, 2018 at 04:59:32PM +, Vadim Pasternak wrote:
> >
> >
> > > -Original Message-
> > > From: Darren Hart [mailto:dvh...@infradead.org]
> > > Sent: Thursday, January 2
On Fri, Jan 26, 2018 at 03:41:17PM -0800, Darren Hart wrote:
> On Fri, Jan 26, 2018 at 04:59:32PM +, Vadim Pasternak wrote:
> >
> >
> > > -Original Message-
> > > From: Darren Hart [mailto:dvh...@infradead.org]
> > > Sent: Thursday, January 2
On Fri, Jan 26, 2018 at 04:59:32PM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Thursday, January 25, 2018 11:47 PM
> > To: Vadim Pasternak <vad...@mellanox.com>
&g
On Fri, Jan 26, 2018 at 04:59:32PM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Thursday, January 25, 2018 11:47 PM
> > To: Vadim Pasternak
> > Cc: andy.shevche...@gmail.co
+ },
> + },
> + {
> .ident = "Dell Computer Corporation",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
> --
> 2.13.6
>
>
--
Darren Hart
VMware Open Source Technology Center
> .ident = "Dell Computer Corporation",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
> --
> 2.13.6
>
>
--
Darren Hart
VMware Open Source Technology Center
ding this patch here:
https://github.com/dvhart/linux-pdx86/tree/review-dvhart-mellanox-v11
(also on the original repo at infradead which appears to be back up and running,
just giving it time before switching back 100%)
--
Darren Hart
VMware Open Source Technology Center
tps://github.com/dvhart/linux-pdx86/tree/review-dvhart-mellanox-v11
(also on the original repo at infradead which appears to be back up and running,
just giving it time before switching back 100%)
--
Darren Hart
VMware Open Source Technology Center
turn if adapter number is
> + * negative. It could be in case hotplug event is not associated with
First sentence repeated twice. I've corrected this.
--
Darren Hart
VMware Open Source Technology Center
er is
> + * negative. It could be in case hotplug event is not associated with
First sentence repeated twice. I've corrected this.
--
Darren Hart
VMware Open Source Technology Center
uture patches.
...
> +
> static int
> mlxplat_mlxcpld_reg_read(void *context, unsigned int reg, unsigned int *val)
> {
> @@ -317,6 +384,10 @@ static const struct regmap_config
> mlxplat_mlxcpld_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
> .max_register = 255,
uture patches.
...
> +
> static int
> mlxplat_mlxcpld_reg_read(void *context, unsigned int reg, unsigned int *val)
> {
> @@ -317,6 +384,10 @@ static const struct regmap_config
> mlxplat_mlxcpld_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
> .max_register = 255,
, the comment is totally
unrelated to this change. I've made this change.
--
Darren Hart
VMware Open Source Technology Center
, the comment is totally
unrelated to this change. I've made this change.
--
Darren Hart
VMware Open Source Technology Center
not
checked elsewhere? Keeping the dev_err messages?
>
> Signed-off-by: Vadim Pasternak <vad...@mellanox.com>
> Acked-by: Andy Shevchenko <andy.shevche...@gmail.com>
> [dvhart: refactored into smaller functional changes]
> Signed-off-by: Darren Hart (VMware) <dvh..
not
checked elsewhere? Keeping the dev_err messages?
>
> Signed-off-by: Vadim Pasternak
> Acked-by: Andy Shevchenko
> [dvhart: refactored into smaller functional changes]
> Signed-off-by: Darren Hart (VMware)
> ---
> drivers/platform/mellanox/mlxreg-hotplug.c | 7 +--
>
his initially, but if we
avoid some of these nasty exploits (and the real harm they enable), then yeah,
this is worth fixing userspace which is relying on undefined behavior.
I'd still like to out why various distros are sending garbage to uadd2 for
network setup (but that's another topic).
--
Darren Hart
VMware Open Source Technology Center
his initially, but if we
avoid some of these nasty exploits (and the real harm they enable), then yeah,
this is worth fixing userspace which is relying on undefined behavior.
I'd still like to out why various distros are sending garbage to uadd2 for
network setup (but that's another topic).
--
Darren Hart
VMware Open Source Technology Center
On Tue, Jan 23, 2018 at 04:37:43PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 23, 2018 at 3:27 PM, Darren Hart <dvh...@infradead.org> wrote:
> > On Tue, Jan 23, 2018 at 06:33:38PM +, Alberto Ponces wrote:
> >> Add touchscreen platform data for the Teclast X3 Plus ta
On Tue, Jan 23, 2018 at 04:37:43PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 23, 2018 at 3:27 PM, Darren Hart wrote:
> > On Tue, Jan 23, 2018 at 06:33:38PM +, Alberto Ponces wrote:
> >> Add touchscreen platform data for the Teclast X3 Plus tablet.
> >>
>
>
> > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> > ---
> > drivers/mfd/ab8500-debugfs.c| 14 --
>
> Acked-by: Lee Jones <lee.jo...@linaro.org>
Thanks Andy,
Acked-by: Darren Hart (VMware) <dvh...@infradead.org>
--
Darren Hart
VMware Open Source Technology Center
>
> > Signed-off-by: Andy Shevchenko
> > ---
> > drivers/mfd/ab8500-debugfs.c| 14 --
>
> Acked-by: Lee Jones
Thanks Andy,
Acked-by: Darren Hart (VMware)
--
Darren Hart
VMware Open Source Technology Center
future: Author signoff goes first, then reviewers, then committer.
--
Darren Hart
VMware Open Source Technology Center
then committer.
--
Darren Hart
VMware Open Source Technology Center
b.com/dvhart/linux-pdx86/tree/review-dvhart-mellanox-v10
And send me any changes strictly on top of that.
Are you anticipating any additional changes beyond those in this version?
--
Darren Hart
VMware Open Source Technology Center
nd send me any changes strictly on top of that.
Are you anticipating any additional changes beyond those in this version?
--
Darren Hart
VMware Open Source Technology Center
On Tue, Jan 23, 2018 at 06:04:37PM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Tuesday, January 23, 2018 6:13 AM
> > To: Vadim Pasternak <vad...@mellanox.com>
&g
On Tue, Jan 23, 2018 at 06:04:37PM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Tuesday, January 23, 2018 6:13 AM
> > To: Vadim Pasternak
> > Cc: andy.shevche...@gmail.co
mmit/4f0057fc3da29c04e2cefca9dc5b17577b3e4988
Vadim, please respond to my questions re the individual patches, and I'll
increment the patches in the above branch before pushing this up to testing.
--
Darren Hart
VMware Open Source Technology Center
mmit/4f0057fc3da29c04e2cefca9dc5b17577b3e4988
Vadim, please respond to my questions re the individual patches, and I'll
increment the patches in the above branch before pushing this up to testing.
--
Darren Hart
VMware Open Source Technology Center
efined in
spinlock.h, so it needs to be included.
I've updated this in my branch...
--
Darren Hart
VMware Open Source Technology Center
efined in
spinlock.h, so it needs to be included.
I've updated this in my branch...
--
Darren Hart
VMware Open Source Technology Center
ting in a local branch currently.
I need you to respond to the question above re the create call, but I'll make
the change myself.
--
Darren Hart
VMware Open Source Technology Center
ting in a local branch currently.
I need you to respond to the question above re the create call, but I'll make
the change myself.
--
Darren Hart
VMware Open Source Technology Center
t; /* Offset of event and mask registers from status register */
> -#define MLXCPLD_HOTPLUG_EVENT_OFF1
> -#define MLXCPLD_HOTPLUG_MASK_OFF 2
> -#define MLXCPLD_HOTPLUG_AGGR_MASK_OFF1
> +#define MLXREG_HOTPLUG_EVENT_OFF 1
> +#define MLXREG_HOTPLUG_MASK_OFF 2
t; -#define MLXCPLD_HOTPLUG_MASK_OFF 2
> -#define MLXCPLD_HOTPLUG_AGGR_MASK_OFF1
> +#define MLXREG_HOTPLUG_EVENT_OFF 1
> +#define MLXREG_HOTPLUG_MASK_OFF 2
> +#define MLXREG_HOTPLUG_AGGR_MASK_OFF 1
This, and much of what follows, is an additional change from the move, but it is
not called out in the changelog. I've added a note to the changelog about
renaming from MLXCPLD to MLXREG.
No need to resend.
--
Darren Hart
VMware Open Source Technology Center
On Mon, Jan 22, 2018 at 07:49:46PM -0800, Darren Hart wrote:
> On Wed, Jan 17, 2018 at 06:21:56PM +, Vadim Pasternak wrote:
> > +#define MLXREG_CORE_LABEL_MAX_SIZE 32
> > +
> > /**
> > * struct mlxreg_hotplug_device - I2C device data:
> > + *
>
On Mon, Jan 22, 2018 at 07:49:46PM -0800, Darren Hart wrote:
> On Wed, Jan 17, 2018 at 06:21:56PM +, Vadim Pasternak wrote:
> > +#define MLXREG_CORE_LABEL_MAX_SIZE 32
> > +
> > /**
> > * struct mlxreg_hotplug_device - I2C device data:
> > + *
>
On Wed, Jan 17, 2018 at 06:21:56PM +, Vadim Pasternak wrote:
> Restructure mlxreg header for unification of hotplug item definitions.
>
> Unify hotplug items to allow any kind of item (power controller, fan
> eeprom, psu eeprom, asic health) in common way.
>
> Use a hardware independent
On Wed, Jan 17, 2018 at 06:21:56PM +, Vadim Pasternak wrote:
> Restructure mlxreg header for unification of hotplug item definitions.
>
> Unify hotplug items to allow any kind of item (power controller, fan
> eeprom, psu eeprom, asic health) in common way.
>
> Use a hardware independent
On Tue, Jan 16, 2018 at 08:24:15PM +0100, Hans de Goede wrote:
> Some versions of the Trekstor Surftab 7.0 ship with a newer BIOS which uses
> different DMI strings.
>
> Signed-off-by: Hans de Goede <hdego...@redhat.com>
Thanks Hans, queued.
--
Darren Hart
VMware Open Source Technology Center
On Tue, Jan 16, 2018 at 08:24:15PM +0100, Hans de Goede wrote:
> Some versions of the Trekstor Surftab 7.0 ship with a newer BIOS which uses
> different DMI strings.
>
> Signed-off-by: Hans de Goede
Thanks Hans, queued.
--
Darren Hart
VMware Open Source Technology Center
On Tue, Jan 16, 2018 at 05:50:44PM -0800, Darren Hart wrote:
> On Tue, Jan 16, 2018 at 08:06:33AM +, Vadim Pasternak wrote:
> >
> >
> > > -Original Message-
> > > From: Darren Hart [mailto:dvh...@infradead.org]
> > > Sent: Tuesday, January
On Tue, Jan 16, 2018 at 05:50:44PM -0800, Darren Hart wrote:
> On Tue, Jan 16, 2018 at 08:06:33AM +, Vadim Pasternak wrote:
> >
> >
> > > -Original Message-
> > > From: Darren Hart [mailto:dvh...@infradead.org]
> > > Sent: Tuesday, January
On Tue, Jan 16, 2018 at 08:06:18AM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Tuesday, January 16, 2018 5:43 AM
> > To: Vadim Pasternak <vad...@mellanox.com>
&g
On Tue, Jan 16, 2018 at 08:06:18AM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Tuesday, January 16, 2018 5:43 AM
> > To: Vadim Pasternak
> > Cc: andy.shevche...@gmail.co
On Tue, Jan 16, 2018 at 08:06:33AM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Tuesday, January 16, 2018 5:43 AM
> > To: Vadim Pasternak <vad...@mellanox.com>
&g
On Tue, Jan 16, 2018 at 08:06:33AM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Tuesday, January 16, 2018 5:43 AM
> > To: Vadim Pasternak
> > Cc: andy.shevche...@gmail.co
On Mon, Jan 15, 2018 at 07:46:06PM -0800, Darren Hart wrote:
> On Mon, Jan 15, 2018 at 07:42:09PM -0800, Darren Hart wrote:
> > To follow this email, are two patches which are minor incremental
> > cleanups, which I'd appreciate your review of before I push them to
> >
On Mon, Jan 15, 2018 at 07:46:06PM -0800, Darren Hart wrote:
> On Mon, Jan 15, 2018 at 07:42:09PM -0800, Darren Hart wrote:
> > To follow this email, are two patches which are minor incremental
> > cleanups, which I'd appreciate your review of before I push them to
> >
On Mon, Jan 15, 2018 at 07:45:11PM -0800, Darren Hart wrote:
> On Mon, Jan 15, 2018 at 07:42:09PM -0800, Darren Hart wrote:
> > To follow this email, are two patches which are minor incremental
> > cleanups, which I'd appreciate your review of before I push them to
> >
On Mon, Jan 15, 2018 at 07:45:11PM -0800, Darren Hart wrote:
> On Mon, Jan 15, 2018 at 07:42:09PM -0800, Darren Hart wrote:
> > To follow this email, are two patches which are minor incremental
> > cleanups, which I'd appreciate your review of before I push them to
> >
On Mon, Jan 15, 2018 at 07:42:09PM -0800, Darren Hart wrote:
> To follow this email, are two patches which are minor incremental
> cleanups, which I'd appreciate your review of before I push them to
> testing.
>From ccfc9b138034b5ccd89da1d938e9241eaeb4dabf Mon Sep 17 00:00:00 200
On Mon, Jan 15, 2018 at 07:42:09PM -0800, Darren Hart wrote:
> To follow this email, are two patches which are minor incremental
> cleanups, which I'd appreciate your review of before I push them to
> testing.
>From ccfc9b138034b5ccd89da1d938e9241eaeb4dabf Mon Sep 17 00:00:00 200
On Mon, Jan 15, 2018 at 07:42:09PM -0800, Darren Hart wrote:
> To follow this email, are two patches which are minor incremental
> cleanups, which I'd appreciate your review of before I push them to
> testing.
>From 2c5d26ee913e0f5f7d13c559d85e8da7e4ddcdab Mon Sep 17 00:00:00 200
On Mon, Jan 15, 2018 at 07:42:09PM -0800, Darren Hart wrote:
> To follow this email, are two patches which are minor incremental
> cleanups, which I'd appreciate your review of before I push them to
> testing.
>From 2c5d26ee913e0f5f7d13c559d85e8da7e4ddcdab Mon Sep 17 00:00:00 200
quite some time now - can you provide some more detail about how the changes
included in this patch are needed to make this driver build on ARM?
Thanks,
--
Darren Hart
VMware Open Source Technology Center
ck
everything that is going on. Incremental changes lead to better code review,
fewer unintentional changes, and better code overall.
--
Darren Hart
VMware Open Source Technology Center
quite some time now - can you provide some more detail about how the changes
included in this patch are needed to make this driver build on ARM?
Thanks,
--
Darren Hart
VMware Open Source Technology Center
ck
everything that is going on. Incremental changes lead to better code review,
fewer unintentional changes, and better code overall.
--
Darren Hart
VMware Open Source Technology Center
FORM
> tristate "Mellanox Technologies platform support"
> - depends on X86_64
This seems like it would be more appropriately applied to 2/3 as this patch is
supposed to be just about the renaming of the files, methods, and defines from
CPLD to reg, and the creation of the mellanox platform.
Any reason this needs to be in this patch?
--
Darren Hart
VMware Open Source Technology Center
ifferent patch, and we can move forward with this.
To follow this email, are two patches which are minor incremental
cleanups, which I'd appreciate your review of before I push them to
testing.
--
Darren Hart
VMware Open Source Technology Center
ifferent patch, and we can move forward with this.
To follow this email, are two patches which are minor incremental
cleanups, which I'd appreciate your review of before I push them to
testing.
--
Darren Hart
VMware Open Source Technology Center
upport"
> - depends on X86_64
This seems like it would be more appropriately applied to 2/3 as this patch is
supposed to be just about the renaming of the files, methods, and defines from
CPLD to reg, and the creation of the mellanox platform.
Any reason this needs to be in this patch?
--
Darren Hart
VMware Open Source Technology Center
On Mon, Jan 15, 2018 at 10:21:33PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 15, 2018 at 10:15 PM, Darren Hart <dvh...@infradead.org> wrote:
> > On Wed, Jan 10, 2018 at 03:12:48PM +0800, kbuild test robot wrote:
>
> >>ERROR: "ia64_delay_loop" [d
On Mon, Jan 15, 2018 at 10:21:33PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 15, 2018 at 10:15 PM, Darren Hart wrote:
> > On Wed, Jan 10, 2018 at 03:12:48PM +0800, kbuild test robot wrote:
>
> >>ERROR: "ia64_delay_loop" [drivers/spi/spi-thunde
shouldn't be changing that.
>
> This also makes all platform/x86/ drivers consistent w.r.t depending on
> INPUT instead of selecting it.
>
> Signed-off-by: Randy Dunlap <rdun...@infradead.org>
> Cc: Darren Hart <dvh...@infradead.org>
> Cc: Andy Shevchenko <a...
>
> This also makes all platform/x86/ drivers consistent w.r.t depending on
> INPUT instead of selecting it.
>
> Signed-off-by: Randy Dunlap
> Cc: Darren Hart
> Cc: Andy Shevchenko
> Cc: platform-driver-...@vger.kernel.org
Thanks Randy, queued.
--
Darren Hart
VMware Open Source Technology Center
sing. Please
correct and resubmit.
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
Darren Hart
VMware Open Source Technology Center
sing. Please
correct and resubmit.
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
Darren Hart
VMware Open Source Technology Center
repository at:
git://git.infradead.org/linux-platform-drivers-x86.git
tags/platform-drivers-x86-v4.15-4
for you to fetch changes up to 98b8e4e5c17bf87c1b18ed929472051dab39878c:
platform/x86: wmi: Call acpi_wmi_init() later (2018-01-08 10:47:48 -0800)
Thanks,
Darren Hart
VMware Open Source
repository at:
git://git.infradead.org/linux-platform-drivers-x86.git
tags/platform-drivers-x86-v4.15-4
for you to fetch changes up to 98b8e4e5c17bf87c1b18ed929472051dab39878c:
platform/x86: wmi: Call acpi_wmi_init() later (2018-01-08 10:47:48 -0800)
Thanks,
Darren Hart
VMware Open Source
ted-by: Jonathan McDowell <nood...@earth.li>
> > > Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
> >
> > Guys, this fixes a crash on boot.
> >
> > If there are no concerns/objections I will just take it through the ACPI
> > tree.
>
> Note that I first started seeing it in v4.9 so would ideally hit the
> appropriate stable trees too.
Thanks, I'll take care of that.
--
Darren Hart
VMware Open Source Technology Center
s a crash on boot.
> >
> > If there are no concerns/objections I will just take it through the ACPI
> > tree.
>
> Note that I first started seeing it in v4.9 so would ideally hit the
> appropriate stable trees too.
Thanks, I'll take care of that.
--
Darren Hart
VMware Open Source Technology Center
that it would be worth the effort.
Henrique, I'm going to stop there and let you chime in if you feel
differently about any of the above.
--
Darren Hart
VMware Open Source Technology Center
that it would be worth the effort.
Henrique, I'm going to stop there and let you chime in if you feel
differently about any of the above.
--
Darren Hart
VMware Open Source Technology Center
e are no concerns/objections I will just take it through the ACPI tree.
Queued up and running through tests now. I'll have it in for-next as soon as
those complete assuming to issues.
--
Darren Hart
VMware Open Source Technology Center
by: Jonathan McDowell
> > Signed-off-by: Rafael J. Wysocki
>
> Guys, this fixes a crash on boot.
>
> If there are no concerns/objections I will just take it through the ACPI tree.
Queued up and running through tests now. I'll have it in for-next as soon as
those complete assuming to issues.
--
Darren Hart
VMware Open Source Technology Center
On Tue, Jan 02, 2018 at 04:49:43PM -0800, Joe Perches wrote:
> On Tue, 2018-01-02 at 16:10 -0800, Darren Hart wrote:
> > > > Leave those pr_ messages alone, please,
> []
> > Andy and Henrique raised a few reasons why these patches should not be
> > accepted:
> &g
On Tue, Jan 02, 2018 at 04:49:43PM -0800, Joe Perches wrote:
> On Tue, 2018-01-02 at 16:10 -0800, Darren Hart wrote:
> > > > Leave those pr_ messages alone, please,
> []
> > Andy and Henrique raised a few reasons why these patches should not be
> > accepted:
> &g
bit);
> 30488704 drivers/platform/x86/mlxcpld-hotplug.c Vadim Pasternak
> 2016-10-20 333 else
> 86a4f473 drivers/platform/mellanox/mlxreg-hotplug.c Vadim Pasternak
> 2017-12-18 334 mlxreg_hotplug_dev_disable(item +
> bit)
bit);
> 30488704 drivers/platform/x86/mlxcpld-hotplug.c Vadim Pasternak
> 2016-10-20 333 else
> 86a4f473 drivers/platform/mellanox/mlxreg-hotplug.c Vadim Pasternak
> 2017-12-18 334 mlxreg_hotplug_dev_disable(item +
> bit);
> 3
or this
reason.
So it isn't that we place a low value on coding style guidelines, but
rather we place higher value on not perturbing code we can't fully test
without a demonstrable functional reasons to do so.
Thanks,
--
Darren Hart
VMware Open Source Technology Center
or this
reason.
So it isn't that we place a low value on coding style guidelines, but
rather we place higher value on not perturbing code we can't fully test
without a demonstrable functional reasons to do so.
Thanks,
--
Darren Hart
VMware Open Source Technology Center
f linus/master
doesn't work as the review-* branches *will* rebase frequently.
Exceptions exist of course, and this patch is just fine - just for
future reference.
Andy pushed his changes to testing already, so this is no longer
dependent on his review queue. I have applied to review-dvhart, will go
to testi
e frequently.
Exceptions exist of course, and this patch is just fine - just for
future reference.
Andy pushed his changes to testing already, so this is no longer
dependent on his review queue. I have applied to review-dvhart, will go
to testing shortly.
Thank you Paul.
--
Darren Hart
VMware Open Source Technology Center
ed this series on top of the review-andy branch for easy merging,
OK, will leave this to andy to pull in then.
--
Darren Hart
VMware Open Source Technology Center
301 - 400 of 3303 matches
Mail list logo
