Code-wise, that looks good to me now. I also don't have ARM handy to
validate though - but it looks correct.
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
Thanks,
Darren.
On Thu, Dec 14, 2017 at 05:40:50PM -0800, Wanpeng Li wrote:
From: Wanpeng Li <wanpeng...@hotmail.com&g
Hi,
I'm wondering about the change to trace_kvm_mmio() here, since it
doesn't appear to be changing the use of it in
virt/kvm/arm/mmio.c, e.g:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/virt/kvm/arm/mmio.c#n114
which seems to be still using it with a data value
com>
Cc: Anthoine Bourgeois <anthoine.bourge...@blade-group.com>
Signed-off-by: Wanpeng Li <wanpen...@tencent.com>
With those changes (or similar):
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
---
arch/x86/kvm/x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
("x86/retpoline: Fill return stack buffer on vmexit")
Signed-off-by: Darren Kenny <darren.ke...@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
---
arch/x86/include/asm/nospec-branch.h
@kernel.org>
Cc: Greg KH <gre...@linuxfoundation.org>
Cc: Paolo Bonzini <pbonz...@redhat.com>
Cc: Ashok Raj <ashok@intel.com>
Reviewed-by: Paolo Bonzini <pbonz...@redhat.com>
Signed-off-by: KarimAllah Ahmed <karah...@amazon.de>
Signed-off-by: David Woodhouse <d...@
-off-by: KarimAllah Ahmed <karah...@amazon.de>
Signed-off-by: David Woodhouse <d...@amazon.co.uk>
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
---
v6:
- got rid of save_spec_ctrl_on_exit
- introduce msr_write_intercepted
v5:
- Also check for X86_FEATURE_SPEC_CTRL for the m
oodhouse <d...@amazon.co.uk>
Cc: Greg KH <gre...@linuxfoundation.org>
Cc: Andy Lutomirski <l...@kernel.org>
Cc: Ashok Raj <ashok@intel.com>
Signed-off-by: KarimAllah Ahmed <karah...@amazon.de>
Signed-off-by: David Woodhouse <d...@amazon.co.uk>
Reviewed-by: Da
On Fri, Feb 02, 2018 at 11:42:12PM +, David Woodhouse wrote:
On Fri, 2018-02-02 at 19:12 +, Darren Kenny wrote:
Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
("x86/retpoline: Fill return stack buffer on vmexit")
Signed-off-by: Darren Kenny <darren.ke.
Please ignore this, didn't realise it had been already applied - guess I
looked in the wrong place.
Thanks,
Darren.
On Mon, Feb 05, 2018 at 11:02:20AM +, Darren Kenny wrote:
Fixes a comment in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
("x86/retpoline: Fill return stack b
Fixes a comment in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
("x86/retpoline: Fill return stack buffer on vmexit")
While the original name was "IBRS All The Time" (IBRS_ATT),
the publicly documented name is IBRS_ALL, we should be using that.
Signed-off-by: Dar
-by: David Woodhouse <d...@amazon.co.uk>
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
---
arch/x86/kernel/cpu/intel.c | 4
1 file changed, 4 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 319bf98..f73b814 100644
--- a/arch/x86/kernel
On Fri, Feb 09, 2018 at 02:29:27PM +, David Woodhouse wrote:
On Fri, 2018-02-09 at 14:10 +, Darren Kenny wrote:
According to the latest microcode update from Intel (on Feb 8, 2018) on
Skylake we should be using the microcode revisions 0xC2***, so we need
to remove that from
According to the latest microcode update from Intel (on Feb 8, 2018) on
Skylake we should be using the microcode revisions 0xC2***, so we need
to remove that from the blacklist now.
Signed-off-by: Darren Kenny <darren.ke...@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@o
().
Signed-off-by: Sonny Rao <sonny...@chromium.org>
Reviewed-by: Darren Kenny <darren.ke...@oracle.com>
All the other callers of this function already appear to assume that
it is an unsigned int.
Thanks,
Darren.
---
drivers/vhost/vhost.c | 2 +-
drivers/vhost/vhost.h | 4 ++--
2 f
Hi Jason,
On Tue, Mar 27, 2018 at 11:47:22AM +0800, Jason Wang wrote:
We tried to remove vq poll from wait queue, but do not check whether
or not it was in a list before. This will lead double free. Fixing
this by checking poll->wqh to make sure it was in a list.
This text seems at odds with
eue to make sure it won't be freed twice.
Cc: Darren Kenny <darren.ke...@oracle.com>
Reported-by: syzbot+c0272972b01b872e6...@syzkaller.appspotmail.com
Fixes: 2b8b328b61c79 ("vhost_net: handle polling errors when setting backend")
Signed-off-by: Jason Wang <jasow...@redhat.com&
On Thu, Mar 01, 2018 at 04:13:36PM +0100, Borislav Petkov wrote:
From: Borislav Petkov <b...@suse.de>
... where they belong.
No functionality change.
Signed-off-by: Borislav Petkov <b...@suse.de>
Cc: k...@vger.kernel.org
Seems like the right place to put them.
Reviewed-by:
().
Signed-off-by: Sonny Rao
Reviewed-by: Darren Kenny
All the other callers of this function already appear to assume that
it is an unsigned int.
Thanks,
Darren.
---
drivers/vhost/vhost.c | 2 +-
drivers/vhost/vhost.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Hi Jason,
On Tue, Mar 27, 2018 at 11:47:22AM +0800, Jason Wang wrote:
We tried to remove vq poll from wait queue, but do not check whether
or not it was in a list before. This will lead double free. Fixing
this by checking poll->wqh to make sure it was in a list.
This text seems at odds with
eue to make sure it won't be freed twice.
Cc: Darren Kenny
Reported-by: syzbot+c0272972b01b872e6...@syzkaller.appspotmail.com
Fixes: 2b8b328b61c79 ("vhost_net: handle polling errors when setting backend")
Signed-off-by: Jason Wang
Reviewed-by: Darren Kenny
---
Changes from V1:
- twe
it as 'Lower timer frequency
limit to 200ms'?
Reported-by: Anthoine Bourgeois
Suggested-by: Paolo Bonzini
Cc: Paolo Bonzini
Cc: Radim Krčmář
Cc: Anthoine Bourgeois
Signed-off-by: Wanpeng Li
With those changes (or similar):
Reviewed-by: Darren Kenny
---
arch/x86/kvm/x86.c | 2 +-
1
Hi,
I'm wondering about the change to trace_kvm_mmio() here, since it
doesn't appear to be changing the use of it in
virt/kvm/arm/mmio.c, e.g:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/virt/kvm/arm/mmio.c#n114
which seems to be still using it with a data value
Code-wise, that looks good to me now. I also don't have ARM handy to
validate though - but it looks correct.
Reviewed-by: Darren Kenny
Thanks,
Darren.
On Thu, Dec 14, 2017 at 05:40:50PM -0800, Wanpeng Li wrote:
From: Wanpeng Li
Reported by syzkaller:
BUG: KASAN: stack-out-of-bounds
Bonzini
Cc: Ashok Raj
Reviewed-by: Paolo Bonzini
Signed-off-by: KarimAllah Ahmed
Signed-off-by: David Woodhouse
Reviewed-by: Darren Kenny
---
arch/x86/kvm/cpuid.c | 2 +-
arch/x86/kvm/vmx.c | 15 +++
arch/x86/kvm/x86.c | 1 +
3 files changed, 17 insertions(+), 1 deletion
: Dan Williams
Cc: Jun Nakajima
Cc: Paolo Bonzini
Cc: David Woodhouse
Cc: Greg KH
Cc: Andy Lutomirski
Cc: Ashok Raj
Signed-off-by: KarimAllah Ahmed
Signed-off-by: David Woodhouse
Reviewed-by: Darren Kenny
---
v6:
- got rid of save_spec_ctrl_on_exit
- introduce msr_write_intercepted
v5
-off-by: KarimAllah Ahmed
Signed-off-by: David Woodhouse
Reviewed-by: Darren Kenny
---
v5:
- Add SPEC_CTRL to direct_access_msrs.
---
arch/x86/kvm/svm.c | 59 ++
1 file changed, 59 insertions(+)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm
Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
("x86/retpoline: Fill return stack buffer on vmexit")
Signed-off-by: Darren Kenny
Reviewed-by: Konrad Rzeszutek Wilk
---
arch/x86/include/asm/nospec-branch.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
On Fri, Feb 02, 2018 at 11:42:12PM +, David Woodhouse wrote:
On Fri, 2018-02-02 at 19:12 +, Darren Kenny wrote:
Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
("x86/retpoline: Fill return stack buffer on vmexit")
Signed-off-by: Darren Kenny
Reviewed-
Please ignore this, didn't realise it had been already applied - guess I
looked in the wrong place.
Thanks,
Darren.
On Mon, Feb 05, 2018 at 11:02:20AM +, Darren Kenny wrote:
Fixes a comment in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
("x86/retpoline: Fill return stack b
On Thu, Mar 01, 2018 at 04:13:36PM +0100, Borislav Petkov wrote:
From: Borislav Petkov
... where they belong.
No functionality change.
Signed-off-by: Borislav Petkov
Cc: k...@vger.kernel.org
Seems like the right place to put them.
Reviewed-by: Darren Kenny
---
arch/x86/include/asm
-by: David Woodhouse
Reviewed-by: Darren Kenny
---
arch/x86/kernel/cpu/intel.c | 4
1 file changed, 4 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 319bf98..f73b814 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -123,8
Fixes a comment in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
("x86/retpoline: Fill return stack buffer on vmexit")
While the original name was "IBRS All The Time" (IBRS_ATT),
the publicly documented name is IBRS_ALL, we should be using that.
Signed-off-by: Da
> (EPC) sections")
> Signed-off-by: Sami Tolvanen
Makes sense.
Reviewed-by: Darren Kenny
> ---
> arch/x86/kernel/cpu/sgx/main.c | 14 +-
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/sgx/main.c b/arch/x86/kernel/cpu/sg
s that set the upper limit for possible
>VMA permissions. Not respecting this can cause #GP's to be emitted.
>
> Cc: linux...@kvack.org
> Cc: Andrew Morton
> Cc: Matthew Wilcox
> Acked-by: Jethro Beekman
> Signed-off-by: Sean Christopherson
> Co-developed-by: Jarkko Sakkine
by: Jethro Beekman
> Tested-by: Haitao Huang
> Tested-by: Chunyang Hui
> Tested-by: Jordan Hand
> Tested-by: Nathaniel McCallum
> Tested-by: Seth Moore
Tested-by: Darren Kenny
Reviewed-by: Darren Kenny
> Co-developed-by: Sean Christopherson
> Signed-off-by: Sean Christoph
function
> implicitly calls ENCLS[EREMOVE], which will return the page to the
> uninitialized state (i.e. not required from caller part).
>
> Acked-by: Jethro Beekman
> Co-developed-by: Sean Christopherson
> Signed-off-by: Sean Christopherson
> Signed-off-by: Jarkko Sakkin
On Thursday, 2020-07-16 at 16:52:46 +03, Jarkko Sakkinen wrote:
> Add kernel parameter to disable Intel SGX kernel support.
>
> Tested-by: Sean Christopherson
> Reviewed-by: Sean Christopherson
> Signed-off-by: Jarkko Sakkinen
Reviewed-by: Darren Kenny
> ---
> Docu
kov
> Acked-by: Jethro Beekman
> Signed-off-by: Sean Christopherson
> Co-developed-by: Jarkko Sakkinen
> Signed-off-by: Jarkko Sakkinen
Reviewed-by: Darren Kenny
> ---
> arch/x86/include/asm/cpufeatures.h | 1 +
> arch/x86/include/asm/msr-index.h | 7 +++
>
n
> Tested-by: Haitao Huang
> Tested-by: Chunyang Hui
> Tested-by: Jordan Hand
> Tested-by: Nathaniel McCallum
> Tested-by: Seth Moore
Tested-by: Darren Kenny
Reviewed-by: Darren Kenny
> Co-developed-by: Sean Christopherson
> Signed-off-by: Sean Christopherson
> C
d-by: Jethro Beekman
> Suggested-by: Andy Lutomirski
> Signed-off-by: Jarkko Sakkinen
Reviewed-by: Darren Kenny
> ---
> arch/x86/include/uapi/asm/sgx.h | 11
> arch/x86/kernel/cpu/sgx/driver.c | 18
> arch/x86/kernel/cpu/sgx/driver.h | 2 ++
> arch/
> Signed-off-by: Sean Christopherson
> Co-developed-by: Serge Ayoun
> Signed-off-by: Serge Ayoun
> Co-developed-by: Jarkko Sakkinen
> Signed-off-by: Jarkko Sakkinen
Reviewed-by: Darren Kenny
> ---
> arch/x86/Kconfig | 17 +++
> arch/x86/kernel/cpu/Ma
he enclave,
> which was invalidated).
>
> [1] Intel SDM: 36.5.1 Enclave Page Cache Map (EPCM)
>
> Acked-by: Jethro Beekman
> Signed-off-by: Sean Christopherson
> Signed-off-by: Jarkko Sakkinen
Reviewed-by: Darren Kenny
> ---
> arch/x86/include/asm/traps.h | 14 ++
be mapped to the
> address range of an enclave.
>
> Acked-by: Jethro Beekman
> Tested-by: Jethro Beekman
> Tested-by: Haitao Huang
> Tested-by: Chunyang Hui
> Tested-by: Jordan Hand
> Tested-by: Nathaniel McCallum
> Tested-by: Seth Moore
Tested-by: Darren Kenny
Reviewed-by: Da
-off-by: Sean Christopherson
> Co-developed-by: Jarkko Sakkinen
> Signed-off-by: Jarkko Sakkinen
Reviewed-by: Darren Kenny
> ---
> arch/x86/kernel/cpu/feat_ctl.c | 32 +++-
> 1 file changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x
s are described in:
>
> Intel SDM: 37.6 INTEL® SGX DATA STRUCTURES OVERVIEW
>
> Acked-by: Jethro Beekman
> Signed-off-by: Jarkko Sakkinen
Reviewed-by: Darren Kenny
> ---
> arch/x86/kernel/cpu/sgx/arch.h | 343 +
> 1 file changed, 343 inser
ration
>
> Reviewed-by: Borislav Petkov
> Acked-by: Jethro Beekman
> Signed-off-by: Sean Christopherson
> Co-developed-by: Jarkko Sakkinen
Reviewed-by: Darren Kenny
> Signed-off-by: Jarkko Sakkinen
> ---
> arch/x86/include/asm/cpufeature.h| 5 +++--
> arch/x8
value.
>
> Acked-by: Jethro Beekman
> Tested-by: Jethro Beekman
> Tested-by: Haitao Huang
> Tested-by: Chunyang Hui
> Tested-by: Jordan Hand
> Tested-by: Nathaniel McCallum
> Tested-by: Seth Moore
Tested-by: Darren Kenny
Reviewed-by: Darren Kenny
> Co-de
layer generates the correct
> input/output annotations based on the number of operands for each leaf
> function.
>
> ENCLS leaf functions are documented in
>
> Intel SDM: 36.6 ENCLAVE INSTRUCTIONS AND INTEL®
Tested-by: Darren Kenny
>
> Acked-by: Jethro Beekman
> Co-de
Hi Jarkko,
Just a couple of nits below...
On Monday, 2020-06-01 at 10:52:09 +03, Jarkko Sakkinen wrote:
> In order to provide a mechanism for devilering provisoning rights:
TYPO: s/devilering/delivering/?
>
> 1. Add a new device file /dev/sgx/provision that works as a token for
>allowing
According to the latest microcode update from Intel (on Feb 8, 2018) on
Skylake we should be using the microcode revisions 0xC2***, so we need
to remove that from the blacklist now.
Signed-off-by: Darren Kenny
Reviewed-by: Konrad Rzeszutek Wilk
Tested-by: Konrad Rzeszutek Wilk
---
arch/x86
On Fri, Feb 09, 2018 at 02:29:27PM +, David Woodhouse wrote:
On Fri, 2018-02-09 at 14:10 +, Darren Kenny wrote:
According to the latest microcode update from Intel (on Feb 8, 2018) on
Skylake we should be using the microcode revisions 0xC2***, so we need
to remove that from
Commit-ID: af189c95a371b59f493dbe0f50c0a09724868881
Gitweb: https://git.kernel.org/tip/af189c95a371b59f493dbe0f50c0a09724868881
Author: Darren Kenny <darren.ke...@oracle.com>
AuthorDate: Fri, 2 Feb 2018 19:12:20 +
Committer: Thomas Gleixner <t...@linutronix.de>
CommitDate
Commit-ID: af189c95a371b59f493dbe0f50c0a09724868881
Gitweb: https://git.kernel.org/tip/af189c95a371b59f493dbe0f50c0a09724868881
Author: Darren Kenny
AuthorDate: Fri, 2 Feb 2018 19:12:20 +
Committer: Thomas Gleixner
CommitDate: Fri, 2 Feb 2018 23:13:57 +0100
x86/speculation: Fix
53 matches
Mail list logo
