Re: RFD: Kernel release numbering

2005-03-02 Thread Dave Jones
On Wed, Mar 02, 2005 at 03:44:58PM -0800, Linus Torvalds wrote: I think a better approach, and one which is already working out well in practice, is to put more intrusive features into -mm first, and only migrate them into 2.6.x when they have 'stabilized'. That wouldn't change. But

Re: RFD: Kernel release numbering

2005-03-02 Thread Dave Jones
On Wed, Mar 02, 2005 at 04:00:46PM -0800, Linus Torvalds wrote: I would not keep regular driver updates from a 2.6.even thing. Then the notion of it being stable is bogus, given how many regressions the last few kernels have brought in drivers. Moving from 2.6.9 - 2.6.10 broke ALSA, USB,

Re: RFD: Kernel release numbering

2005-03-02 Thread Dave Jones
On Wed, Mar 02, 2005 at 04:58:30PM -0800, David S. Miller wrote: The problem is people don't test until 2.6.whatever-final goes out. Nothing will change that. And the day Linus releases we always get a pile of missing MODULE_EXPORT() type bug reports that are one liner fixes. Those

Re: RFD: Kernel release numbering

2005-03-02 Thread Dave Jones
On Wed, Mar 02, 2005 at 05:20:49PM -0800, Andrew Morton wrote: Dave Jones [EMAIL PROTECTED] wrote: So what was broken with the 2.6.8.1 type of 'hotfix kernel' release ? That's an alternative, of course. But that _is_ a branch, and does need active forward- and (mainly) backward

Re: RFD: Kernel release numbering

2005-03-02 Thread Dave Jones
On Wed, Mar 02, 2005 at 02:21:38PM -0800, Linus Torvalds wrote: This is an idea that has been brewing for some time: Andrew has mentioned it a couple of times, I've talked to some people about it, and today Davem sent a suggestion along similar lines to me for 2.6.12. Namely that we

Re: RFD: Kernel release numbering

2005-03-02 Thread Dave Jones
On Wed, Mar 02, 2005 at 07:10:47PM -0800, Randy.Dunlap wrote: For it to truly be a stable kernel, the only patches I'd expect to drivers would be ones fixing blindingly obvious bugs. No cleanups. No new functionality. I'd even question new hardware support if it wasn't just a PCI ID

Re: RFD: Kernel release numbering

2005-03-02 Thread Dave Jones
On Wed, Mar 02, 2005 at 08:38:12PM -0800, Andrew Morton wrote: Dave Jones [EMAIL PROTECTED] wrote: On Wed, Mar 02, 2005 at 04:00:46PM -0800, Linus Torvalds wrote: I would not keep regular driver updates from a 2.6.even thing. Then the notion of it being stable is bogus

Re: RFD: Kernel release numbering

2005-03-03 Thread Dave Jones
On Thu, Mar 03, 2005 at 12:53:53AM -0800, Greg KH wrote: And sometimes, people really want those big fixes, and they switch to using the bk-usb patchset, or the bk-scsi patchset. That happens a lot for when distros work to stabilize their release kernels. For those that have no intention

Re: RFD: Kernel release numbering

2005-03-03 Thread Dave Jones
On Thu, Mar 03, 2005 at 12:07:59PM -0500, Bill Rugolsky Jr. wrote: IMHO, Jeff Garzik has made two very useful points in this thread: 1. The number of changesets flowing towards the Linus kernel is accelerating, so the kernel developers should be trying to accelerate the merging

Re: RFD: Kernel release numbering

2005-03-03 Thread Dave Jones
On Thu, Mar 03, 2005 at 01:09:01PM -0800, Andrew Morton wrote: [*] I don't know any details of the /proc incompatibility which davej mentions, and I'd like to. That sounds like a screw-up. We changed the format of /proc/slabinfo. Running slabtop threw up an error message complaining

Re: [PATCH] trivial fix for 2.6.11 raid6 compilation on ppc w/ Altivec

2005-03-03 Thread Dave Jones
On Thu, Mar 03, 2005 at 02:45:15PM -0800, Greg KH wrote: On Fri, Mar 04, 2005 at 09:30:22AM +1100, Paul Mackerras wrote: Jeff Garzik writes: Rene Rebe wrote: Hi, --- linux-2.6.11/drivers/md/raid6altivec.uc.vanilla2005-03-02 16:44:56.407107752 +0100 +++

Re: 2.6.11-rc2-mm1

2005-01-24 Thread Dave Jones
On Mon, Jan 24, 2005 at 12:56:58PM +0100, Brice Goglin wrote: X does not work anymore when using DRI on my Compaq Evo N600c (Radeon Mobility M6 LY). My XFree 4.3 (from Debian testing) with DRI uses drm and radeon kernel modules. My fault. I'm looking into it. Drop the agpgart-bk update

Re: 2.6.11-rc2-mm1

2005-01-24 Thread Dave Jones
On Mon, Jan 24, 2005 at 01:52:58PM -0500, Dave Jones wrote: On Mon, Jan 24, 2005 at 12:56:58PM +0100, Brice Goglin wrote: X does not work anymore when using DRI on my Compaq Evo N600c (Radeon Mobility M6 LY). My XFree 4.3 (from Debian testing) with DRI uses drm and radeon kernel

Re: memory leak in 2.6.11-rc2

2005-01-24 Thread Dave Jones
On Tue, Jan 25, 2005 at 02:19:24PM +1100, Andrew Tridgell wrote: The problem I've hit now is a severe memory leak. I have applied the patch from Linus for the leak in free_pipe_info(), and still I'm leaking memory at the rate of about 100Mbyte/minute. I've tested with both 2.6.11-rc2 and

Re: [PATCH 4/29] x86-i8259-shutdown

2005-01-24 Thread Dave Jones
On Mon, Jan 24, 2005 at 10:32:50PM -0500, Len Brown wrote: On Wed, 2005-01-19 at 02:31, Eric W. Biederman wrote: From: Eric W. Biederman [EMAIL PROTECTED] This patch disables interrupt generation from the legacy pic on reboot. Now that there is a sys_device class it should not be

Re: 2.6.11-rc2-mm1

2005-01-25 Thread Dave Jones
On Mon, Jan 24, 2005 at 10:31:53PM +0100, Brice Goglin wrote: Dave Jones a écrit : Here's the most obvious bug fixed. There still seems to be something wrong however. It only successfully boots 50% of the time for me, (it reboots when starting X otherwise), and when it does boot, I get

Re: 2.6.11-rc2-mm1

2005-01-25 Thread Dave Jones
On Tue, Jan 25, 2005 at 08:58:31PM +0100, Brice Goglin wrote: Dave Jones a écrit : This is needed too on top of -mm1. diff -Nru a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c --- a/drivers/char/agp/generic.c2005-01-25 14:34:24 -05:00 +++ b/drivers/char/agp/generic.c

Remove sched.h inclusion from module.h

2005-01-25 Thread Dave Jones
,yesconfig,noconfig # # Signed-off-by: Dave Jones [EMAIL PROTECTED] # diff -Nru a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c --- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c 2005-01-26 01:36:57 -05:00 +++ b/arch/i386/kernel/cpu/cpufreq/acpi

Re: don't let mmap allocate down to zero

2005-01-26 Thread Dave Jones
On Wed, Jan 26, 2005 at 09:09:27PM -0800, William Lee Irwin III wrote: On Wed, Jan 26, 2005 at 11:18:08AM -0500, Rik van Riel wrote: With some programs the 2.6 kernel can end up allocating memory at address zero, for a non-MAP_FIXED mmap call! This causes problems with some programs

Re: Patch 1/6 introduce sysctl

2005-01-27 Thread Dave Jones
On Thu, Jan 27, 2005 at 08:11:20PM +0100, Ingo Molnar wrote: so, i'm glad to report, it's a non-issue. Sometimes developers want to disable randomisation during development (quick'n'easy hacks get quicker and easier - e.g. if you watch an address within gdb), so having the capability for

Re: 2.6.10-ac11 announcement?

2005-01-31 Thread Dave Jones
On Tue, Feb 01, 2005 at 12:02:49AM +0100, Rafael J. Wysocki wrote: Nothing terribly exciting here security wise but various bugs for problems people have been hitting that are now fixed upstream, and also the ULi tulip variant should now work. If you are running IPv6 you may well want

ppc32 MMCR0_PMXE saga.

2005-02-02 Thread Dave Jones
. Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.10/include/asm-ppc/reg.h~ 2005-02-02 23:28:14.0 -0500 +++ linux-2.6.10/include/asm-ppc/reg.h 2005-02-02 23:28:36.0 -0500 @@ -333,6 +333,7 @@ #define MMCR0_PMC2_CYCLES 0x1 #define MMCR0_PMC2_ITLB0x7

ibmveth inlining failure.

2005-02-02 Thread Dave Jones
Yet another ppc64 build failure.. Move the function before its first usage, and the failure goes away. Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.10/drivers/net/ibmveth.c~ 2005-01-12 16:03:14.0 -0500 +++ linux-2.6.10/drivers/net/ibmveth.c 2005-01-12 16:03:37.0

fix matroxfb ppc compile.

2005-02-02 Thread Dave Jones
Code references these vars even though they don't exist. Untested other than compile test. Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.10/drivers/video/matrox/matroxfb_base.c~ 2005-01-27 20:06:10.0 -0500 +++ linux-2.6.10/drivers/video/matrox/matroxfb_base.c 2005-01-27

Re: AMD thunderbird oops

2001-06-26 Thread Dave Jones
are not available. regards, Dave. -- | Dave Jones.http://www.suse.de/~davej | SuSE Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: Machine check exception? (2.4.6+SMP+VIA)

2001-07-08 Thread Dave Jones
On Sun, 8 Jul 2001, Alan Cox wrote: Only -ac has K7 MCE enabled right now - also MCE is not guaranteed to catch problems. Actually you merged that with Linus a few revisions back iirc. regards, Dave. -- | Dave Jones.http://www.suse.de/~davej | SuSE Labs - To unsubscribe from

Re: Machine check exception? (2.4.6+SMP+VIA)

2001-07-08 Thread Dave Jones
. -- | Dave Jones.http://www.suse.de/~davej | SuSE Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] use mmiowb in via-rhine

2005-01-19 Thread Dave Jones
On Wed, Jan 19, 2005 at 12:22:20PM -0800, Matt Mackall wrote: Use the generic PCI memory barrier. Test-compiled. This can't be right. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: bk/drivers/net/via-rhine.c ===

Re: [PATCH RFC] agp_backend: remove drm_agp_t inter_module_foo V1 [1/1]

2005-01-19 Thread Dave Jones
On Wed, Jan 19, 2005 at 06:38:32PM -0800, Chris Wedgwood wrote: What extremely obvious thing am I missing which prevents up from kill drm_agp_t and the inter_module_register, etc. code that goes with it? Gar, this is the 3rd copy of this patch I've got. I wanted the dust to settle on the

Re: Typo in [AGPGART] i915GM support patch

2005-01-20 Thread Dave Jones
On Thu, Jan 20, 2005 at 05:46:22PM +0100, Marco Cipullo wrote: - if (agp_bridge-dev-device == PCI_DEVICE_ID_INTEL_82915G_HB) + if (agp_bridge-dev-device == PCI_DEVICE_ID_INTEL_82915G_HB || + agp_bridge-dev-device == PCI_DEVICE_ID_INTEL_82915G_HB) gtt_entries = MB(48) - KB(size);

Re: [PATCH][RFC]: Clean up resource allocation in i8042 driver

2005-01-21 Thread Dave Jones
On Fri, Jan 21, 2005 at 10:14:46AM -0500, Prarit Bhargava wrote: Signed-off-by: Prarit Bhargava [EMAIL PROTECTED] = i8042.c 1.71 vs edited = --- 1.71/drivers/input/serio/i8042.c2005-01-03 08:11:49 -05:00 +++ edited/i8042.c 2005-01-21 10:02:20 -05:00 @@ -696,7 +696,10

Remove easily user-triggerable BUG from generic_setlease

2012-07-13 Thread Dave Jones
[126749.833905] [811e1876] sys_fcntl+0x1c6/0x810 [126749.834800] [8134b4ae] ? trace_hardirqs_on_thunk+0x3a/0x3f [126749.835687] [81691d2d] system_call_fastpath+0x1a/0x1f Signed-off-by: Dave Jones da...@redhat.com diff --git a/fs/locks.c b/fs/locks.c index 814c51d..fce6238

Re: Remove easily user-triggerable BUG from generic_setlease

2012-07-13 Thread Dave Jones
On Fri, Jul 13, 2012 at 10:47:43AM -0700, Linus Torvalds wrote: On Fri, Jul 13, 2012 at 10:35 AM, Dave Jones da...@redhat.com wrote: This can be trivially triggered from userspace by passing in something unexpected. Argh. It looks like it would be harmless (apart from the noise

3.5-rc6 futex_wait_requeue_pi oops.

2012-07-13 Thread Dave Jones
Looks like calling futex() with garbage makes things unhappy. Dave [ 673.054286] BUG: unable to handle kernel NULL pointer dereference at 0028 [ 673.055292] IP: [810d665e] __lock_acquire+0x5e/0x1ae0 [ 673.056225] PGD 1107c8067 PUD 11079c067 PMD 0 [ 673.057224]

Re: 3.5-rc6 futex_wait_requeue_pi oops.

2012-07-13 Thread Dave Jones
On Fri, Jul 13, 2012 at 09:11:57PM +0200, Thomas Gleixner wrote: On Fri, 13 Jul 2012, Dave Jones wrote: On Fri, Jul 13, 2012 at 08:47:38PM +0200, Thomas Gleixner wrote: On Fri, 13 Jul 2012, Dave Jones wrote: Looks like calling futex() with garbage makes things unhappy

Re: 3.5-rc6 futex_wait_requeue_pi oops.

2012-07-13 Thread Dave Jones
On Fri, Jul 13, 2012 at 01:27:41PM -0700, Darren Hart wrote: I'm returning from a family vacation just now, I'll have a closer look on Monday. It seems to me we recently had some futex lockdep annotations go in, any chance those are somehow involved? So we have a real user of the futex

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-13 Thread Dave Jones
On Fri, Jul 13, 2012 at 01:37:41PM -0700, Linus Torvalds wrote: The point I'm slowly getting to is that I would actually love to have *distro* Kconfig-files, where the distribution would be able to say These are the minimums I *require* to work. As long as you don't mind these being added

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-13 Thread Dave Jones
On Fri, Jul 13, 2012 at 11:50:25PM +0200, Paul Bolle wrote: But just removing all the certainly unused macros probably wouldn't have made a noticeable difference to anyone using those defconfig files anyway. My point is that I don't think there's many people actually using them. (maybe

Re: 3.5-rc6 configfs BUG_ON

2012-07-15 Thread Dave Jones
On Sun, Jul 15, 2012 at 01:58:46PM -0700, Joel Becker wrote: Call Trace: [811ec74f] d_kill+0xaf/0x120 [811ec8a2] dput+0xe2/0x1d0 [811dfaea] path_put+0x1a/0x30 [811d9705] vfs_fstatat+0x55/0x70 [811d973e] vfs_lstat+0x1e/0x20

Re: BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 on 3.5-rc6

2012-07-16 Thread Dave Jones
On Sat, Jul 14, 2012 at 09:18:04PM +0545, devendra.aaru wrote: On Sat, Jul 14, 2012 at 8:07 PM, richard -rw- weinberger richard.weinber...@gmail.com wrote: On Sat, Jul 14, 2012 at 2:11 PM, devendra.aaru devendra.a...@gmail.com wrote: 3.5-rc6 with git head at fdb1335a82e. (from

Re: 3.5-rc6 dentry related GPF

2012-07-16 Thread Dave Jones
On Mon, Jul 16, 2012 at 10:32:18PM +0100, Al Viro wrote: On Wed, Jul 11, 2012 at 12:10:12PM -0700, Linus Torvalds wrote: rdi = 54415541e5894855 which looks like some odd corrupted ASCII to me (UH\211\345AUAT) but that makes no sense either. It makes a lot of sense as

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dave Jones
On Wed, Jul 18, 2012 at 05:25:14PM +0300, Dan Carpenter wrote: Hi Darren, The patch 52400ba94675: futex: add requeue_pi functionality from Apr 3, 2009, leads to the following warning: kernel/futex.c:2373 futex_wait_requeue_pi() error: potential NULL dereference 'pi_mutex'. This

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dave Jones
...@linux.intel.com CC: Dave Jones da...@redhat.com CC: Dan Carpenter dan.carpen...@oracle.com CC: Thomas Gleixner t...@linutronix.de diff --git a/kernel/futex.c b/kernel/futex.c index e2b0fb9..05018bf 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -2370,7 +2370,7 @@ static int

Re: [PATCH] SUNRPC: Prevent kernel stack corruption on long values of flush

2012-07-18 Thread Dave Jones
On Wed, Jul 18, 2012 at 04:00:49PM -0400, Jim Rees wrote: You could use something like: char tbuf[sizeof (unsigned long) * 24 / 10 + 1 + 2]; /* + 2 for final \n\0 */ since there are roughly 10 bits for every 3 decimal digits. But I'm obviously confused, because I don't

WARNING: at kernel/watchdog.c:245 watchdog_overflow_callback+0x98/0xc0()

2013-04-17 Thread Dave Jones
Slightly old kernel, but likely still relevant judging by recent commits. Hit an oom condition while fuzz testing, but what's interesting is what happened immediately afterwards.. (the lockup) Could this just be that the kernel was so busy recovering from swapping etc that watchdog perceived that

Re: ext4 object already free.

2013-04-05 Thread Dave Jones
On Fri, Apr 05, 2013 at 12:25:53PM +0200, Jan Kara wrote: [ 93.672257] [812c2da9] sys_msgctl+0x139/0x400 [ 93.674641] [816c5d4d] ? retint_swapgs+0xe/0x13 [ 93.677056] [810b6c55] ? trace_hardirqs_on_caller+0x115/0x1a0 [ 93.679626] [8134b39e]

Re: [PATCH] checkpatch: Warn on comparisons to true and false

2013-04-10 Thread Dave Jones
On Wed, Apr 10, 2013 at 03:57:51PM -0700, Andrew Morton wrote: On Tue, 09 Apr 2013 20:17:14 -0700 Joe Perches j...@perches.com wrote: Comparisons of A to true and false are better written as A and !A. Bleat a message on use. hm. I'm counting around 1,100 instances of ==

print out hardware name modules list when we encounter bad page tables.

2013-04-11 Thread Dave Jones
Given we have been seeing a lot of reports of page table corruption for a while now, perhaps if we print out the hardware name, and list of modules loaded, we might see some patterns emerging. Signed-off-by: Dave Jones da...@redhat.com diff -durpN '--exclude-from=/home/davej/.exclude' /home

ext4 object already free.

2013-03-29 Thread Dave Jones
Just hit this very quickly after boot while fuzzing. (top of tree is 0776ce03b1348d39ba3035ea3ee3d268a42912ce) [ 93.602628] = [ 93.603689] BUG kmalloc-64 (Not tainted): Object already free [ 93.604441]

Re: ipc,sem: sysv semaphore scalability

2013-03-29 Thread Dave Jones
On Tue, Mar 26, 2013 at 12:43:09PM -0700, Andrew Morton wrote: On Tue, 26 Mar 2013 15:28:52 -0400 Dave Jones da...@redhat.com wrote: On Thu, Mar 21, 2013 at 02:10:58PM -0700, Andrew Morton wrote: Whichever way we go, we should get a wiggle on - this has been hanging around

Re: ipc,sem: sysv semaphore scalability

2013-03-29 Thread Dave Jones
On Fri, Mar 29, 2013 at 11:00:27AM -0700, Linus Torvalds wrote: On Fri, Mar 29, 2013 at 9:17 AM, Dave Jones da...@redhat.com wrote: Now that I have that reverted, I'm not seeing msgrcv traces any more, but I've started seeing this.. general protection fault: [#1] PREEMPT SMP

Re: ipc,sem: sysv semaphore scalability

2013-03-29 Thread Dave Jones
On Tue, Mar 26, 2013 at 12:43:09PM -0700, Andrew Morton wrote: On Tue, 26 Mar 2013 15:28:52 -0400 Dave Jones da...@redhat.com wrote: On Thu, Mar 21, 2013 at 02:10:58PM -0700, Andrew Morton wrote: Whichever way we go, we should get a wiggle on - this has been hanging around

Re: ipc,sem: sysv semaphore scalability

2013-03-29 Thread Dave Jones
On Fri, Mar 29, 2013 at 11:43:25AM -0700, Linus Torvalds wrote: On Fri, Mar 29, 2013 at 9:17 AM, Dave Jones da...@redhat.com wrote: Now that I have that reverted, I'm not seeing msgrcv traces any more, but I've started seeing this.. general protection fault: [#1] PREEMPT SMP

3.9-rc4 Nouveau/DRM lockdep trace

2013-04-02 Thread Dave Jones
I see this on boot on one my systems.. == [ INFO: possible circular locking dependency detected ] 3.9.0-0.rc4.git0.1.fc19.x86_64 #1 Not tainted --- dhclient-script/350 is trying to acquire

Re: ipc,sem: sysv semaphore scalability

2013-04-02 Thread Dave Jones
On Tue, Apr 02, 2013 at 03:53:01PM -0400, Sasha Levin wrote: On 04/02/2013 01:52 PM, Linus Torvalds wrote: On Tue, Apr 2, 2013 at 9:08 AM, Sasha Levin sasha.le...@oracle.com wrote: By just playing with the 'msgsz' parameter with MSG_COPY set. Hmm. Looking closer, I suspect you're

Re: [PATCH] sysfs: check if one entry has been removed before freeing

2013-04-02 Thread Dave Jones
On Wed, Apr 03, 2013 at 10:58:23AM +0800, Ming Lei wrote: diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index 1bf016b..328ef9b 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c @@ -268,6 +268,13 @@ void release_sysfs_dirent(struct sysfs_dirent * sd) */ parent_sd =

Re: 3.9-rc1 NULL pointer crash at find_pid_ns

2013-03-14 Thread Dave Jones
On Sat, Mar 09, 2013 at 07:51:46AM -0800, Paul E. McKenney wrote: On Sat, Mar 09, 2013 at 04:01:41PM +0800, Li Zefan wrote: [ . . . ] This way, ptr is executed exactly once, and the check and the hlist_entry() are both using the same value. I just played with trinity, and

Re: SLUB + UML : WARNING: at mm/page_alloc.c:2386

2013-03-14 Thread Dave Jones
On Thu, Mar 14, 2013 at 09:58:31PM +0100, Toralf Förster wrote: On 03/14/2013 09:51 PM, richard -rw- weinberger wrote: Can you please re-run with the attached patch. I'm wondering how much memory is requested. From reading the source I'd say it must be less than PAGE_SIZE. But such a

Re: ipc/testmsg GPF.

2013-03-15 Thread Dave Jones
On Tue, Mar 12, 2013 at 03:02:36PM -0700, Andrew Morton wrote: On Mon, 11 Mar 2013 15:03:22 -0400 Peter Hurley pe...@hurleysoftware.com wrote: On Mon, 2013-03-11 at 14:26 -0400, Dave Jones wrote: { I just hit this again on rc2 which looks like it has the fixes

Re: [Intel-gfx] [PATCH] drm/i915: Sanity check incoming ioctl data for a NULL pointer

2013-03-17 Thread Dave Jones
On Sun, Mar 17, 2013 at 08:50:03PM +0100, Daniel Vetter wrote: Doesn't that mean that we need these checks everywhere? Or at least a fixup in drm core proper? And I think we need to add trinity to our test setup eventually ;-) Note that trinity's ioctl fuzzing is still very new (added

ext4_block_to_path block max warning.

2013-03-18 Thread Dave Jones
Not sure what I did to trigger this, but it's happened a few times while fuzzing syscalls. Rebooted and fscked, didn't find anything wrong. Dave [ 5084.436288] EXT4-fs warning (device sda1): ext4_block_to_path:105: block 1874853625 max in inode 34 [ 5167.723925] EXT4-fs warning

Re: ext4_block_to_path block max warning.

2013-03-19 Thread Dave Jones
On Tue, Mar 19, 2013 at 08:22:44AM -0400, Theodore Ts'o wrote: On Mon, Mar 18, 2013 at 11:35:55PM -0400, Dave Jones wrote: Not sure what I did to trigger this, but it's happened a few times while fuzzing syscalls. Rebooted and fscked, didn't find anything wrong. [ 5084.436288

cpu offline causes backtrace from cmci_rediscover

2013-03-19 Thread Dave Jones
offlining a CPU in 3.9-rc3 gets me this trace.. numa_remove_cpu cpu 1 node 0: mask now 0,2-3 smpboot: CPU 1 is now offline BUG: using smp_processor_id() in preemptible [] code: cpu-offline.sh/10591 caller is cmci_rediscover+0x6a/0xe0 Pid: 10591, comm: cpu-offline.sh Not tainted

trinity fuzz-tester mailing list.

2013-03-20 Thread Dave Jones
I've been getting enough private mail about the trinity fuzz-tester that there needs to be some coordination between people patching the same code etc. To this end, there's now a mailing list.. Send a mail with 'subscribe trinity' in the body to majord...@vger.kernel.org to subscribe. My

VFS deadlock ?

2013-03-21 Thread Dave Jones
Al, Linus, I've seen this happen a few times recently.. I have a bunch of trinity processes that run for a few hours, and then eventually all those processes end up spinning waiting on each other. The stack traces always seem to look like this.. Does this look like a real kernel deadlock, or

Re: VFS deadlock ?

2013-03-21 Thread Dave Jones
On Thu, Mar 21, 2013 at 01:15:08PM -0700, Linus Torvalds wrote: On Thu, Mar 21, 2013 at 12:29 PM, Al Viro v...@zeniv.linux.org.uk wrote: #0 oddity aside, that looks very much like directory aliased by two different dentries. Try to add BUG_ON(p1-d_inode == p2-d_inode);

Re: VFS deadlock ?

2013-03-21 Thread Dave Jones
On Thu, Mar 21, 2013 at 07:21:46PM +, Al Viro wrote: On Thu, Mar 21, 2013 at 03:06:53PM -0400, Dave Jones wrote: Al, Linus, trinity-child2 D 880110b3a7e0 5448 7669 1 0x0004 [sits in rename(), trying to grab -i_mutex on a parent] Showing all locks held

Re: VFS deadlock ?

2013-03-21 Thread Dave Jones
On Thu, Mar 21, 2013 at 01:32:45PM -0700, Linus Torvalds wrote: On Thu, Mar 21, 2013 at 1:26 PM, Dave Jones da...@redhat.com wrote: those are qstr's, so I used d_name.name, right ? Yup. And if you want to, you could do p1-d_parent-d_name.name too, just to make things obvious. It's

Re: VFS deadlock ?

2013-03-21 Thread Dave Jones
On Thu, Mar 21, 2013 at 08:47:04PM +, Al Viro wrote: On Thu, Mar 21, 2013 at 04:36:39PM -0400, Dave Jones wrote: at some point during the fuzz run, this happened.. Mar 20 15:20:41 kernel: [ 7578.784674] fuse init (API version 7.21) Mar 20 15:20:41 systemd[1]: Mounting FUSE

Re: VFS deadlock ?

2013-03-21 Thread Dave Jones
On Thu, Mar 21, 2013 at 09:26:17PM +, Al Viro wrote: On Thu, Mar 21, 2013 at 02:18:15PM -0700, Linus Torvalds wrote: On Thu, Mar 21, 2013 at 2:02 PM, Dave Jones da...@redhat.com wrote: here we go... WARNING: at fs/namei.c:2335 lock_rename+0x156/0x160() p1=irda p2=irda

Re: VFS deadlock ?

2013-03-21 Thread Dave Jones
On Thu, Mar 21, 2013 at 02:18:15PM -0700, Linus Torvalds wrote: On Thu, Mar 21, 2013 at 2:02 PM, Dave Jones da...@redhat.com wrote: here we go... WARNING: at fs/namei.c:2335 lock_rename+0x156/0x160() p1=irda p2=irda Ok, good. I ssupect it's /proc or /sys, we do have

Re: VFS deadlock ?

2013-03-21 Thread Dave Jones
On Thu, Mar 21, 2013 at 06:12:56PM -0400, Dave Jones wrote: On Thu, Mar 21, 2013 at 02:18:15PM -0700, Linus Torvalds wrote: On Thu, Mar 21, 2013 at 2:02 PM, Dave Jones da...@redhat.com wrote: here we go... WARNING: at fs/namei.c:2335 lock_rename+0x156/0x160() p1=irda

Re: VFS deadlock ?

2013-03-21 Thread Dave Jones
On Thu, Mar 21, 2013 at 03:53:13PM -0700, Linus Torvalds wrote: On Thu, Mar 21, 2013 at 3:12 PM, Dave Jones da...@redhat.com wrote: it's not just irda fwiw.. p1=rpc p2=rpc p1parent=net p2parent=net Ok, good. The only rpc/irda that has something in common is /proc/net

Re: [PATCH] cpufreq/intel_pstate: Add function to check that all MSR's are valid

2013-03-22 Thread Dave Jones
On Fri, Mar 22, 2013 at 01:40:49AM +0100, Rafael J. Wysocki wrote: On Thursday, March 21, 2013 01:08:03 AM Rafael J. Wysocki wrote: On Wednesday, March 20, 2013 11:28:49 AM Dirk Brandewie wrote: On 03/20/2013 11:28 AM, Rafael J. Wysocki wrote: On Wednesday, March 20, 2013 09:17:24 AM

Re: [CFT] Re: VFS deadlock ?

2013-03-22 Thread Dave Jones
On Thu, Mar 21, 2013 at 10:33:27PM -0700, Linus Torvalds wrote: Ok, that's kind of ugly, but shouldn't be a correctness issue. It should still work - just cycle through inodes quite aggressivelydue to no longer re-using them - so I suspect Dave could test it (with the extra line removed I

Re: ipc/testmsg GPF.

2013-03-25 Thread Dave Jones
On Mon, Mar 11, 2013 at 03:03:22PM -0400, Peter Hurley wrote: On Mon, 2013-03-11 at 14:26 -0400, Dave Jones wrote: On Fri, Mar 08, 2013 at 07:27:01PM -0500, Peter Hurley wrote: On Thu, 2013-03-07 at 16:38 -0500, Dave Jones wrote: general protection fault: [#1

Re: ipc/testmsg GPF.

2013-03-25 Thread Dave Jones
On Mon, Mar 25, 2013 at 02:28:53PM -0400, Peter Hurley wrote: bad news: Turns out my recent testing where I thought your patches fixed this was incorrect. I had excluded fuzz testing of msgrcv, so it was never getting exercised. I think you might have applied the wrong series. See

Re: ipc,sem: sysv semaphore scalability

2013-03-26 Thread Dave Jones
On Thu, Mar 21, 2013 at 02:10:58PM -0700, Andrew Morton wrote: Whichever way we go, we should get a wiggle on - this has been hanging around for too long. Dave, do you have time to determine whether reverting 88b9e456b1649722673ff (ipc: don't allocate a copy larger than max) fixes things

Re: BUG at kmem_cache_alloc

2013-03-26 Thread Dave Jones
On Tue, Mar 26, 2013 at 05:32:27AM -0400, CAI Qian wrote: Still running and will update ASAP. One thing I noticed was that trinity threw out this error before the kernel crash. BUG!: CHILD (pid:28825) GOT REPARENTED! parent pid:19380. Watchdog pid:19379 BUG!:

Yet another pipe related oops.

2013-03-27 Thread Dave Jones
On Tue, Mar 12, 2013 at 01:09:16PM -0700, Linus Torvalds wrote: On Tue, Mar 12, 2013 at 12:43 PM, Al Viro v...@zeniv.linux.org.uk wrote: Umm... How about the following, then? I think it makes the whole thing simpler and saner... NOTE: this got only a light beating and we'd just

Re: BUG at kmem_cache_alloc

2013-03-28 Thread Dave Jones
On Thu, Mar 28, 2013 at 03:49:37AM -0400, CAI Qian wrote: While reproducing this, it triggered something else with SLUB_DEBUG_ON. CAI Qian [87295.499233] general protection fault: [#1] SMP [87295.500228] Modules linked in: binfmt_misc fuse tun cmtp kernelcapi rfcomm bnep hidp

Re: pipe_release oops.

2013-03-08 Thread Dave Jones
On Thu, Mar 07, 2013 at 04:21:13PM -0800, Linus Torvalds wrote: On Thu, Mar 7, 2013 at 2:36 PM, Dave Jones da...@redhat.com wrote: The hits keep on coming.. [ 255.609172] BUG: unable to handle kernel NULL pointer dereference at 0064 [ 255.610393] IP

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Wed, Mar 06, 2013 at 09:16:45PM -0500, Dave Jones wrote: kernel BUG at fs/namei.c:1441! invalid opcode: [#1] PREEMPT SMP Modules linked in: bnep vmw_vsock_vmci_transport vmw_vmci vsock fuse l2tp_ppp l2tp_core hidp 8021q garp mrp llc2 netrom phonet bridge dlci stp caif_socket

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 10:51:03AM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 7:04 AM, Dave Jones da...@redhat.com wrote: Managed to trigger this one from a different path.. kernel BUG at fs/namei.c:1439! Call Trace: [811c973e] path_lookupat+0x71e/0x740

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 02:18:04PM -0500, Dave Jones wrote: On Fri, Mar 08, 2013 at 10:51:03AM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 7:04 AM, Dave Jones da...@redhat.com wrote: Managed to trigger this one from a different path.. kernel BUG at fs/namei.c:1439

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 02:20:42PM -0500, Dave Jones wrote: I'll turn off DEBUG_PAGEALLOC again, so I can get the RIP and figure out which deref it is. Wait, it has to be that path-dentry-d_name.name. The other derefs are the same as before. I changed it to do this.. diff --git

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 11:47:54AM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 11:36 AM, Dave Jones da...@redhat.com wrote: I changed it to do this.. diff --git a/fs/namei.c b/fs/namei.c index 961bc12..c1ca29e 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -689,8

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 02:41:19PM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 1:04 PM, Dave Jones da...@redhat.com wrote: queue up the sad trombone noises. One of the things trinity passes syscalls is a page of deformed unicode. Apparently this page is so fucked up

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 06:07:34PM -0500, Dave Jones wrote: parent seems to be a pointer to \0. Ignore that last part, it's wrong. Dave -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 03:20:40PM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 3:07 PM, Dave Jones da...@redhat.com wrote: Ok, got something more meaningful out of the lookup_slow trace. [ 66.082984] parent-dname.name (06b6b6b6b6b6b6b) [ 66.083637] parent

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 03:28:01PM -0800, Linus Torvalds wrote: Oh, btw, I'm assuming you're testing current git like you usually do. yes. If so, just to humor me, can you try plain 3.8 (or 3.8.2 or whatever the current stable kernel is). Because while the oopses may be due to your

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 03:28:01PM -0800, Linus Torvalds wrote: Oh, btw, I'm assuming you're testing current git like you usually do. If so, just to humor me, can you try plain 3.8 (or 3.8.2 or whatever the current stable kernel is). Because while the oopses may be due to your

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 03:45:37PM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 3:30 PM, Dave Jones da...@redhat.com wrote: [ 100.729401] nd-last.name = (\xffd2.W._.N..\xfffe.\xff80.^N.?.\xffe4.E.8.g.\xffd2.N.\xffb6.^G.\xfff1.\xffcc.U.\xffda

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 04:02:02PM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 3:55 PM, Dave Jones da...@redhat.com wrote: That one was printed out with %s Ok, so those random pathnames you generate? They're funky. I just did a test with just a page of 'A's, and got the same

Re: ipc/testmsg GPF.

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 07:27:01PM -0500, Peter Hurley wrote: [ +Andrew Morton ] On Thu, 2013-03-07 at 16:38 -0500, Dave Jones wrote: Trying to reproduce that nd_jump_link trace, but I keep hitting other bugs instead. It's like whackamole. Except these are even more annoying than

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 07:19:17PM -0500, Dave Jones wrote: On Fri, Mar 08, 2013 at 04:02:02PM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 3:55 PM, Dave Jones da...@redhat.com wrote: That one was printed out with %s Ok, so those random pathnames you generate

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 05:18:29PM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 4:36 PM, Dave Jones da...@redhat.com wrote: Ok, it's definitly the 'append something on the end of a valid pathname' changeset. 'something' can be anything it seems. Ok. so maybe the way

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 06:08:52PM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 6:03 PM, Dave Jones da...@redhat.com wrote: existing pathname + 'a' = fine. existing pathname + '/' + 'a' = boom. Good. Looks like if I do this.. if (isdigit(newpath[len

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 09:26:23PM -0500, Dave Jones wrote: On Fri, Mar 08, 2013 at 06:08:52PM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 6:03 PM, Dave Jones da...@redhat.com wrote: existing pathname + 'a' = fine. existing pathname + '/' + 'a' = boom

Re: BUG_ON(nd-inode != parent-d_inode);

2013-03-08 Thread Dave Jones
On Fri, Mar 08, 2013 at 09:56:31PM -0500, Dave Jones wrote: On Fri, Mar 08, 2013 at 09:26:23PM -0500, Dave Jones wrote: On Fri, Mar 08, 2013 at 06:08:52PM -0800, Linus Torvalds wrote: On Fri, Mar 8, 2013 at 6:03 PM, Dave Jones da...@redhat.com wrote: existing pathname

<    1   2   3   4   5   6   7   8   9   10   >