Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Dave Young wrote: > +static int __spi_master_match(struct device *dev, void *data) > +{ > +   struct spi_master *m; > +   u16 *bus_num = (u16 *)data; That's "void *data" so "u16 *bus_num = data" is preferred. -- To unsubscribe from this list: send the line

Re: [PATCH 1/6] driver-core : add class iteration api

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Dave Young wrote: > > +/** > + * class_for_each_device - device iterator > + * @class: the class we're iterating > + * @data: data for the callback > + * @fn: function to be called for each device > + * > + * Iterate over @class's list of devices, and call

Re: [patch/rfc 2.6.24-rc8-git] genirq: partial lockdep fixes

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Peter Zijlstra wrote: > > On Fri, 2008-01-18 at 14:29 -0800, David Brownell wrote: > > EXPERIMENTAL and incomplete patch to make LOCKDEP behave better in > > the face of irq chaining, by annotating irqs with a lock_class which > > ca

Re: [patch/rfc 2.6.24-rc8-git] genirq: partial lockdep fixes

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Peter Zijlstra wrote: On Fri, 2008-01-18 at 14:29 -0800, David Brownell wrote: EXPERIMENTAL and incomplete patch to make LOCKDEP behave better in the face of irq chaining, by annotating irqs with a lock_class which can reflect that hierarchy. This is too

Re: [PATCH 1/6] driver-core : add class iteration api

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Dave Young wrote: +/** + * class_for_each_device - device iterator + * @class: the class we're iterating + * @data: data for the callback + * @fn: function to be called for each device + * + * Iterate over @class's list of devices, and call @fn for

Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Dave Young wrote: +static int __spi_master_match(struct device *dev, void *data) +{ +   struct spi_master *m; +   u16 *bus_num = (u16 *)data; That's void *data so u16 *bus_num = data is preferred. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Dave Young wrote: Convert to use the class iteration api. Signed-off-by: Dave Young [EMAIL PROTECTED] Ack. --- drivers/spi/spi.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff -upr linux/drivers/spi/spi.c

[patch/rfc 2.6.24-rc8-git] genirq: partial lockdep fixes

2008-01-18 Thread David Brownell
EXPERIMENTAL and incomplete patch to make LOCKDEP behave better in the face of irq chaining, by annotating irqs with a lock_class which can reflect that hierarchy. This version of the patch is incomplete in at least two respects: - There's no spin_lock_irq_nested() primitive, so that locking

Re: [PATCH] AT91: correct at91sam9263ek LCD power gpio pin

2008-01-17 Thread David Brownell
On Thursday 17 January 2008, Nicolas Ferre wrote: >  static void at91_lcdc_power_control(int on) >  { > if (on) > -   at91_set_gpio_value(AT91_PIN_PD12, 0);  /* power up */ > +   at91_set_gpio_value(AT91_PIN_PA30, 1);  /* power up */ > else > -   

Re: 2.6.23-git Kconfig regression

2008-01-17 Thread David Brownell
On Thursday 17 January 2008, Jan Beulich wrote: > >This stuff isn't for "distro" kernels; it's for embedded > >environments of the "only this hardware exists" sort. > >Space matters, and having small code matters.  Nobody has > >been interested enough in an "embedded distro" model to > >provide

Re: 2.6.23-git Kconfig regression

2008-01-17 Thread David Brownell
On Thursday 17 January 2008, Jan Beulich wrote: This stuff isn't for distro kernels; it's for embedded environments of the only this hardware exists sort. Space matters, and having small code matters.  Nobody has been interested enough in an embedded distro model to provide patches enabling

Re: 2.6.23-git Kconfig regression

2008-01-16 Thread David Brownell
On Wednesday 16 January 2008, Jan Beulich wrote: > >>> Randy Dunlap <[EMAIL PROTECTED]> 20.10.07 05:21 >>> > > Sorry for only now getting back to this. > > >On Fri, 19 Oct 2007 19:55:35 -0700 Randy Dunlap wrote: > > > ... > > I'm pretty convinced that drivers/usb/gadget/Kconfig isn't really >

Re: 2.6.23-git Kconfig regression

2008-01-16 Thread David Brownell
On Wednesday 16 January 2008, Jan Beulich wrote: Randy Dunlap [EMAIL PROTECTED] 20.10.07 05:21 Sorry for only now getting back to this. On Fri, 19 Oct 2007 19:55:35 -0700 Randy Dunlap wrote: ... I'm pretty convinced that drivers/usb/gadget/Kconfig isn't really written properly:

Re: [RFC] libusb / in-kernel usb driver criteria

2008-01-11 Thread David Brownell
> > > So, to get the ball rolling, here are some factors that IMHO > > > help decide in which side to implement a driver: > > > > > > - if the driver ties a hardware device to an existing > > >in-kernel interface (network, block, serial, bluetooth, > > >video4linux, etc.), it should

Re: [RFC] libusb / in-kernel usb driver criteria

2008-01-11 Thread David Brownell
So, to get the ball rolling, here are some factors that IMHO help decide in which side to implement a driver: - if the driver ties a hardware device to an existing in-kernel interface (network, block, serial, bluetooth, video4linux, etc.), it should probably be implemented

[patch 2.6.24-rc7] remove obsolete /sys/devices/.../power/state docs

2008-01-09 Thread David Brownell
The /sys/devices/.../power/state files have been gone for a while now, but I just noticed some documentation that still refers to them. (Fortunately described as DEPRECATED and WILL REMOVE). Time to remove that obsolete documentation too ... Signed-off-by: David Brownell <[EMAIL PROTEC

[patch 2.6.24-rc7] remove obsolete /sys/devices/.../power/state docs

2008-01-09 Thread David Brownell
The /sys/devices/.../power/state files have been gone for a while now, but I just noticed some documentation that still refers to them. (Fortunately described as DEPRECATED and WILL REMOVE). Time to remove that obsolete documentation too ... Signed-off-by: David Brownell [EMAIL PROTECTED

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread David Brownell
On Monday 07 January 2008, Greg KH wrote: > Most of the non-driver core code should be converted to not use the > lock in the class at all.  They should use a local lock instead. Or better yet, that yet-to-be-written class_for_each_instance() iterator ... :) -- To unsubscribe from this list:

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread David Brownell
On Monday 07 January 2008, Greg KH wrote: Most of the non-driver core code should be converted to not use the lock in the class at all.  They should use a local lock instead. Or better yet, that yet-to-be-written class_for_each_instance() iterator ... :) -- To unsubscribe from this list: send

Re: [linux-pm][PATCH] base: Change power/wakeup output from "" to "unsupported" if wakeup feature isn't supported by a device

2008-01-06 Thread David Brownell
On Sunday 06 January 2008, Yi Yang wrote: > > > How about not changing a userland-visible interface gratuitously? > > "empty" can't tell a user the state of wakeup of a device, so it is > necessary to change it. Words don't say anything at all in isolation. For example, here the current

Re: [linux-pm][PATCH] base: Change power/wakeup output from to unsupported if wakeup feature isn't supported by a device

2008-01-06 Thread David Brownell
On Sunday 06 January 2008, Yi Yang wrote: How about not changing a userland-visible interface gratuitously? empty can't tell a user the state of wakeup of a device, so it is necessary to change it. Words don't say anything at all in isolation. For example, here the current tristate

Re: [patch 2.6.24-rc6-mm 4/9] gpiolib: avr32 at32ap platform support

2008-01-05 Thread David Brownell
On Saturday 05 January 2008, Haavard Skinnemoen wrote: > On Sat, 5 Jan 2008 12:10:56 -0800 > David Brownell <[EMAIL PROTECTED]> wrote: > > > From: David Brownell <[EMAIL PROTECTED]> > > > > Teach AVR32 to use the "GPIO Library" when exposing its G

Re: [patch 2.6.24-rc6-mm 3/9] gpiolib: update Documentation/gpio.txt

2008-01-05 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Update Documentation/gpio.txt, primarily to include the new "gpiolib" infrastructure. Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- Incorporates cleanup as suggested by Sam Ravnborg. Documen

Re: [patch 2.6.24-rc6-mm 4/9] gpiolib: avr32 at32ap platform support

2008-01-05 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Teach AVR32 to use the "GPIO Library" when exposing its GPIOs, so that signals on external chips (like GPIO expanders) can easily be used. This mostly reorganizes some existing logic, with two minor changes in behavior: - The PSR re

Re: [patch 2.6.24-rc6-mm 6/9] gpiolib: pcf857x i2c gpio expander support

2008-01-05 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> This is a new-style I2C driver for most common 8 and 16 bit I2C based "quasi-bidirectional" GPIO expanders: pcf8574 or pcf8575, and several compatible models (mostly faster, supporting I2C at up to 1 MHz). The driver exposes the GP

Re: [patch 2.6.24-rc6-mm 2/9] gpiolib: add gpio provider infrastructure

2008-01-05 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Provide new implementation infrastructure that platforms may choose to use when implementing the GPIO programming interface. Platforms can update their GPIO support to use this. In many cases the incremental cost to access a non-inlined GPIO

Re: [patch 2.6.24-rc6-mm 1/9] gpiolib: add drivers/gpio directory

2008-01-05 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Add an empty drivers/gpio directory for gpiolib infrastructure and GPIO expanders. It will be populated by later patches. This won't be the only place to hold such gpio_chip code. Many external chips add a few GPIOs as secondary functio

Re: [patch 2.6.24-rc6-mm 5/9] gpiolib: pxa platform support

2008-01-05 Thread David Brownell
easier to hook up GPIOs provided by external chips like ASICs and CPLDs. Signed-off-by: Philipp Zabel <[EMAIL PROTECTED]> Signed-off-by: David Brownell <[EMAIL PROTECTED]> Acked-by: Russell King <[EMAIL PROTECTED]> --- Incorporates minor cleanup suggested by Sam Ravn

Re: [patch 2.6.24-rc6-mm 8/9] gpiolib: pca9539 i2c gpio expander support

2008-01-05 Thread David Brownell
has no current known users). This is faster and simpler; it uses 16-bit register access, and cache the OUTPUT and DIRECTION registers for fast access Signed-off-by: eric miao <[EMAIL PROTECTED]> Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- Incorporates cleanups noted by Jean Delvare

Re: [PATCH 4/5] USB Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm

2008-01-05 Thread David Brownell
> --- 23.a/arch/arm/Kconfig > +++ 23.b/arch/arm/Kconfig > @@ -1049,6 +1049,8 @@ source "drivers/hid/Kconfig" > > source "drivers/usb/Kconfig" > > +source "drivers/usb/gadget/Kconfig" > + > source "drivers/mmc/Kconfig" > > source "drivers/rtc/Kconfig" > Better IMO to include such

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-05 Thread David Brownell
On Saturday 05 January 2008, Al Boldi wrote: > +comment "NOTE: USB_STORAGE selects SCSI, but 'SCSI disk support' may" > +comment "also be needed; see USB_STORAGE Help for more information" > + >  config USB_STORAGE_DEBUG Better ... but wouldn't something like comment "You probably also

Re: [patch 2.6.24-rc6-mm 8/9] gpiolib: pca9539 i2c gpio expander support

2008-01-05 Thread David Brownell
). This is faster and simpler; it uses 16-bit register access, and cache the OUTPUT and DIRECTION registers for fast access Signed-off-by: eric miao [EMAIL PROTECTED] Signed-off-by: David Brownell [EMAIL PROTECTED] --- Incorporates cleanups noted by Jean Delvare. drivers/gpio/Kconfig| 10 + drivers

Re: [PATCH 4/5] USB Kconfig: Source drivers/usb/gadget/Kconfig for ARCH=arm

2008-01-05 Thread David Brownell
--- 23.a/arch/arm/Kconfig +++ 23.b/arch/arm/Kconfig @@ -1049,6 +1049,8 @@ source drivers/hid/Kconfig source drivers/usb/Kconfig +source drivers/usb/gadget/Kconfig + source drivers/mmc/Kconfig source drivers/rtc/Kconfig Better IMO to include such updates with the patch that

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-05 Thread David Brownell
On Saturday 05 January 2008, Al Boldi wrote: +comment NOTE: USB_STORAGE selects SCSI, but 'SCSI disk support' may +comment also be needed; see USB_STORAGE Help for more information +  config USB_STORAGE_DEBUG Better ... but wouldn't something like comment You probably also need to

Re: [patch 2.6.24-rc6-mm 3/9] gpiolib: update Documentation/gpio.txt

2008-01-05 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Update Documentation/gpio.txt, primarily to include the new gpiolib infrastructure. Signed-off-by: David Brownell [EMAIL PROTECTED] --- Incorporates cleanup as suggested by Sam Ravnborg. Documentation/gpio.txt | 133

Re: [patch 2.6.24-rc6-mm 4/9] gpiolib: avr32 at32ap platform support

2008-01-05 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Teach AVR32 to use the GPIO Library when exposing its GPIOs, so that signals on external chips (like GPIO expanders) can easily be used. This mostly reorganizes some existing logic, with two minor changes in behavior: - The PSR registers are used instead

Re: [patch 2.6.24-rc6-mm 6/9] gpiolib: pcf857x i2c gpio expander support

2008-01-05 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] This is a new-style I2C driver for most common 8 and 16 bit I2C based quasi-bidirectional GPIO expanders: pcf8574 or pcf8575, and several compatible models (mostly faster, supporting I2C at up to 1 MHz). The driver exposes the GPIO signals using

Re: [patch 2.6.24-rc6-mm 1/9] gpiolib: add drivers/gpio directory

2008-01-05 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Add an empty drivers/gpio directory for gpiolib infrastructure and GPIO expanders. It will be populated by later patches. This won't be the only place to hold such gpio_chip code. Many external chips add a few GPIOs as secondary functionality (such as MFD

Re: [patch 2.6.24-rc6-mm 5/9] gpiolib: pxa platform support

2008-01-05 Thread David Brownell
to hook up GPIOs provided by external chips like ASICs and CPLDs. Signed-off-by: Philipp Zabel [EMAIL PROTECTED] Signed-off-by: David Brownell [EMAIL PROTECTED] Acked-by: Russell King [EMAIL PROTECTED] --- Incorporates minor cleanup suggested by Sam Ravnborg. arch/arm/Kconfig

Re: [patch 2.6.24-rc6-mm 2/9] gpiolib: add gpio provider infrastructure

2008-01-05 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Provide new implementation infrastructure that platforms may choose to use when implementing the GPIO programming interface. Platforms can update their GPIO support to use this. In many cases the incremental cost to access a non-inlined GPIO should be less

Re: [patch 2.6.24-rc6-mm 4/9] gpiolib: avr32 at32ap platform support

2008-01-05 Thread David Brownell
On Saturday 05 January 2008, Haavard Skinnemoen wrote: On Sat, 5 Jan 2008 12:10:56 -0800 David Brownell [EMAIL PROTECTED] wrote: From: David Brownell [EMAIL PROTECTED] Teach AVR32 to use the GPIO Library when exposing its GPIOs, so that signals on external chips (like GPIO expanders

Re: [linux-pm][PATCH] base: Change power/wakeup output from "" to "unsupported" if wakeup feature isn't supported by a device

2008-01-04 Thread David Brownell
> This patch changes empty output to "unsupported" in order that a user knows > wakeup feature isn't supported by this device when he/she > 'cat /sys/devices/.../power/wakeup', please consider to apply, thanks. I don't much like this patch. Not just for the technical reasons mentioned in my

Re: [linux-pm][PATCH] base: Change power/wakeup output from "" to "unsupported" if wakeup feature isn't supported by a device

2008-01-04 Thread David Brownell
> > This patch changes empty output to "unsupported" in order that a user knows > > wakeup feature isn't supported by this device when he/she > > 'cat /sys/devices/.../power/wakeup', please consider to apply, > > thanks. > > What about simply removing "wakuep" file if wakeup is not supported? It

Re: [linux-pm][PATCH] base: Change power/wakeup output from to unsupported if wakeup feature isn't supported by a device

2008-01-04 Thread David Brownell
This patch changes empty output to unsupported in order that a user knows wakeup feature isn't supported by this device when he/she 'cat /sys/devices/.../power/wakeup', please consider to apply, thanks. I don't much like this patch. Not just for the technical reasons mentioned in my previous

Re: [linux-pm][PATCH] base: Change power/wakeup output from to unsupported if wakeup feature isn't supported by a device

2008-01-04 Thread David Brownell
This patch changes empty output to unsupported in order that a user knows wakeup feature isn't supported by this device when he/she 'cat /sys/devices/.../power/wakeup', please consider to apply, thanks. What about simply removing wakuep file if wakeup is not supported? It may not *stay*

Re: [patch 2.6.24-rc6-mm 8/9] gpiolib: pca9539 i2c gpio expander support

2008-01-03 Thread David Brownell
Le 02 Janvier 2008, Jean Delvare a écrit: > > Hi David, hi Eric, > > Le 29/12/2007, "David Brownell" <[EMAIL PROTECTED]> a écrit: > >From: eric miao <[EMAIL PROTECTED]> > > > >This adds a new-style I2C driver with basic s

Re: [patch 2.6.24-rc6-mm 8/9] gpiolib: pca9539 i2c gpio expander support

2008-01-03 Thread David Brownell
Le 02 Janvier 2008, Jean Delvare a écrit: Hi David, hi Eric, Le 29/12/2007, David Brownell [EMAIL PROTECTED] a écrit: From: eric miao [EMAIL PROTECTED] This adds a new-style I2C driver with basic support for the sixteen bit PCA9539 GPIO expanders. ... Random

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Bryan Wu wrote: > B.T.W, 2 questions about the MUSB driver: > 1. What's the plan for mainline merge of the whole MUSB driver? maybe > I can cleanup current Blackfin ports to you guys. It might as well merge in 2.6.25-early. It'll be easier to integrate patches that

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Robin Getz wrote: > On Wed 2 Jan 2008 13:47, David Brownell pondered: > > On Wednesday 02 January 2008, Robin Getz wrote: > > > From: Robin Getz <[EMAIL PROTECTED]> > > > > > > Allow embedded developers to turn support for U

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Alan Stern wrote: > > > The transaction translators in external high speed hubs require > > hosts to issue particular USB transactions.  If the host controller > > doesn't implement the that split transaction support, then it won't > > be supporting external hubs. >

Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Ingo Molnar wrote: > > then please provide a kernel config option for the new driver to take > over 10:135 too. There's nothing worse to the adoption of new kernel > features necessiating user-space attention. I've got several images of > old distros that i dont

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Alan Stern wrote: > On Wed, 2 Jan 2008, Mike Frysinger wrote: > > > perhaps the code size is arguable as to whether it really matters. > > the reason we want it is that we have a USB host controller that will > > not work with USB hubs, so we want to make sure the

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Mike Frysinger wrote: > > > > > > Allow embedded developers to turn support for USB Hubs off even if they > > > have a > > > full root hub. This saves the overhead (RAM and Flash size). > > > > ISTR that it won't save very much code though ... the Linux USB > > stack

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Felipe Balbi wrote: >The problem I see here is that my only > "user" is musb driver, currently only available on linux-omap git tree. > > Maybe it's time to send it to mainline, what do you think Dave? Probably time, yes. ISTR the main open issues are on

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Alan Stern wrote: >  BTW, I don't recall ever seeing Tony's patch announced on > linux-usb or linux-usb-devel.  Did I simply miss it? I think he didn't post it. I got some questions from him at one point, which I answered, but as I recall he decided for some

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Robin Getz wrote: > From: Robin Getz <[EMAIL PROTECTED]> > > Allow embedded developers to turn support for USB Hubs off even if they have > a > full root hub. This saves the overhead (RAM and Flash size). ISTR that it won't save very much code though ... the Linux

Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-02 Thread David Brownell
> > It'd need to have some NTP sync solution for RTC_LIB devices, but > > ISTR the gentime stuff still assumes an update_persistent_clock() > > that doesn't sleep ... and hence can't be used with I2C based RTCs. > > I still believe NTP sync stuff should be done outside of the kernel. > given the

Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-02 Thread David Brownell
> > > shouldnt we provide a Kconfig way of replacing dev 10:135 with the > > > new driver's 254:0 device? (while keeping all the current modes of > > > operation as well, of course.) It's all supposed to be 100% ioctl > > > ABI compatible with the old driver, right? > > > > It's not compatible

Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-02 Thread David Brownell
(Alessandro Zummo Cc:-ed too -- RTC subsystem maintainer) > * Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > Well, we have the following test script in the userland suspend > > package that is supposed to work right now: > > > > #!/bin/bash > > date > > cd /sys/class/rtc/rtc0 > > echo $((

Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-02 Thread David Brownell
(Alessandro Zummo Cc:-ed too -- RTC subsystem maintainer) * Rafael J. Wysocki [EMAIL PROTECTED] wrote: Well, we have the following test script in the userland suspend package that is supposed to work right now: #!/bin/bash date cd /sys/class/rtc/rtc0 echo $(( $(cat since_epoch)

Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-02 Thread David Brownell
shouldnt we provide a Kconfig way of replacing dev 10:135 with the new driver's 254:0 device? (while keeping all the current modes of operation as well, of course.) It's all supposed to be 100% ioctl ABI compatible with the old driver, right? It's not compatible enough to fake

Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-02 Thread David Brownell
It'd need to have some NTP sync solution for RTC_LIB devices, but ISTR the gentime stuff still assumes an update_persistent_clock() that doesn't sleep ... and hence can't be used with I2C based RTCs. I still believe NTP sync stuff should be done outside of the kernel. given the mean

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Robin Getz wrote: From: Robin Getz [EMAIL PROTECTED] Allow embedded developers to turn support for USB Hubs off even if they have a full root hub. This saves the overhead (RAM and Flash size). ISTR that it won't save very much code though ... the Linux USB

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Alan Stern wrote:  BTW, I don't recall ever seeing Tony's patch announced on linux-usb or linux-usb-devel.  Did I simply miss it? I think he didn't post it. I got some questions from him at one point, which I answered, but as I recall he decided for some

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Felipe Balbi wrote: The problem I see here is that my only user is musb driver, currently only available on linux-omap git tree. Maybe it's time to send it to mainline, what do you think Dave? Probably time, yes. ISTR the main open issues are on host

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Mike Frysinger wrote: Allow embedded developers to turn support for USB Hubs off even if they have a full root hub. This saves the overhead (RAM and Flash size). ISTR that it won't save very much code though ... the Linux USB stack structures all

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Alan Stern wrote: On Wed, 2 Jan 2008, Mike Frysinger wrote: perhaps the code size is arguable as to whether it really matters. the reason we want it is that we have a USB host controller that will not work with USB hubs, so we want to make sure the system

Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Ingo Molnar wrote: then please provide a kernel config option for the new driver to take over 10:135 too. There's nothing worse to the adoption of new kernel features necessiating user-space attention. I've got several images of old distros that i dont want

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Robin Getz wrote: On Wed 2 Jan 2008 13:47, David Brownell pondered: On Wednesday 02 January 2008, Robin Getz wrote: From: Robin Getz [EMAIL PROTECTED] Allow embedded developers to turn support for USB Hubs off even if they have a full root hub

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Alan Stern wrote: The transaction translators in external high speed hubs require hosts to issue particular USB transactions.  If the host controller doesn't implement the that split transaction support, then it won't be supporting external hubs. So in

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Bryan Wu wrote: B.T.W, 2 questions about the MUSB driver: 1. What's the plan for mainline merge of the whole MUSB driver? maybe I can cleanup current Blackfin ports to you guys. It might as well merge in 2.6.25-early. It'll be easier to integrate patches that

Re: 2.6.24-rc6-mm1 (build problem: gpio_keys)

2007-12-31 Thread David Brownell
On Monday 31 December 2007, Randy Dunlap wrote: > CC drivers/input/keyboard/gpio_keys.o > In file included from > /local/linsrc/linux-2.6.24-rc6-mm1/drivers/input/keyboard/gpio_keys.c:27: > include2/asm/gpio.h:4:18: error: gpio.h: No such file or directory Find whatever broken patch

Re: 2.6.24-rc6-mm1 (build problem: gpio_keys)

2007-12-31 Thread David Brownell
On Monday 31 December 2007, Randy Dunlap wrote: CC drivers/input/keyboard/gpio_keys.o In file included from /local/linsrc/linux-2.6.24-rc6-mm1/drivers/input/keyboard/gpio_keys.c:27: include2/asm/gpio.h:4:18: error: gpio.h: No such file or directory Find whatever broken patch selected

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2007-12-29 Thread David Brownell
On Saturday 29 December 2007, Alan Stern wrote: > lockdep warns whenever a task acquires a mutex while holding another > mutex of the same kind (that is, the same member in another structure > of the same type).  But there are lots of places where the kernel needs > to acquire dev->sem for one

Re: [patch 2.6.24-rc6-mm 2/9] gpiolib: add gpio provider infrastructure

2007-12-29 Thread David Brownell
notations. Heck, /usr/include is full of them... - Dave CUT HERE Minor gpiolib.c cleanup: remove most #ifdefs for CONFIG_FS. Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- drivers/gpio/gpiolib.c | 22 +++--- 1 file changed, 11 insertions(+), 1

Re: [patch 2.6.24-rc6-mm 1/9] gpiolib: add drivers/gpio directory

2007-12-29 Thread David Brownell
t - Descend into drivers/gpio unconditionally, letting the Makefile sort out the differences - Use "ccflags-$(CONGIF_DEBUG_GPIO) += -DDEBUG" instead of those ugly (but traditional) conditionals. Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- arch/arm/Kconf

Re: [patch 2.6.24-rc6-mm 1/9] gpiolib: add drivers/gpio directory

2007-12-29 Thread David Brownell
- Use ccflags-$(CONGIF_DEBUG_GPIO) += -DDEBUG instead of those ugly (but traditional) conditionals. Signed-off-by: David Brownell [EMAIL PROTECTED] --- arch/arm/Kconfig |4 +- arch/avr32/Kconfig |2 +- drivers/Makefile |2 +- drivers/gpio/Kconfig

Re: [patch 2.6.24-rc6-mm 2/9] gpiolib: add gpio provider infrastructure

2007-12-29 Thread David Brownell
CUT HERE Minor gpiolib.c cleanup: remove most #ifdefs for CONFIG_FS. Signed-off-by: David Brownell [EMAIL PROTECTED] --- drivers/gpio/gpiolib.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) --- at91.orig/drivers/gpio/gpiolib.c +++ at91/drivers/gpio

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2007-12-29 Thread David Brownell
On Saturday 29 December 2007, Alan Stern wrote: lockdep warns whenever a task acquires a mutex while holding another mutex of the same kind (that is, the same member in another structure of the same type).  But there are lots of places where the kernel needs to acquire dev-sem for one device

[patch 2.6.24-rc6-mm 9/9] gpiolib: deprecate obsolete pca9539 driver

2007-12-28 Thread David Brownell
From: eric miao <[EMAIL PROTECTED]> Use drivers/gpio/pca9539.c instead. Signed-off-by: eric miao <[EMAIL PROTECTED]> Acked-by: Ben Gardner <[EMAIL PROTECTED]> Acked-by: Jean Delvare <[EMAIL PROTECTED]> Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- Document

[patch 2.6.24-rc6-mm 7/9] gpiolib: mcp23s08 spi gpio expander support

2007-12-28 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Basic driver for 8-bit SPI based MCP23S08 GPIO expander, without support for IRQs or the shared chipselect mechanism. Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- drivers/gpio/Kconfig |7 drivers/gpio/Makefile

[patch 2.6.24-rc6-mm 8/9] gpiolib: pca9539 i2c gpio expander support

2007-12-28 Thread David Brownell
ses 16-bit register access, and caches the OUTPUT and DIRECTION registers for fast access. Signed-off-by: eric miao <[EMAIL PROTECTED]> Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- drivers/gpio/Kconfig| 10 + drivers/gpio/Makefile |

[patch 2.6.24-rc6-mm 5/9] gpiolib: pxa platform support

2007-12-28 Thread David Brownell
ASICs and CPLDs, as used on various product and developer boards. Signed-off-by: Philipp Zabel <[EMAIL PROTECTED]> Signed-off-by: David Brownell <[EMAIL PROTECTED]> Acked-by: Russell King <[EMAIL PROTECTED]> --- arch/arm/Kconfig|1 arch/arm/mach-pxa/Makefil

[patch 2.6.24-rc6-mm 6/9] gpiolib: pcf857x i2c gpio expander support

2007-12-28 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> This is a new-style I2C driver for most common 8 and 16 bit I2C based "quasi-bidirectional" GPIO expanders: pcf8574 or pcf8575, and several compatible models (mostly faster, supporting I2C at up to 1 MHz). The driver exposes the GP

[patch 2.6.24-rc6-mm 3/9] gpiolib: update Documentation/gpio.txt

2007-12-28 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Update Documentation/gpio.txt, primarily to include the new optional "gpiolib" implementation infrastructure. Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- Documentation/gpio.txt | 133 +++

[patch 2.6.24-rc6-mm 4/9] gpiolib: avr32 at32ap platform support

2007-12-28 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Teach AVR32 to use the "GPIO Library" when exposing its GPIOs, so that signals on external chips (like GPIO expanders) can easily be used. This mostly just reorganizes some existing logic, with two minor changes in behavior: - The PSR re

[patch 2.6.24-rc6-mm 2/9] gpiolib: add gpio provider infrastructure

2007-12-28 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Provide new implementation infrastructure that platforms may choose to use to support the GPIO programming interface. Platforms can update current GPIO support to use this. In many cases the incremental cost to access a non-inlined GPIO should b

[patch 2.6.24-rc6-mm 1/9] gpiolib: add drivers/gpio directory

2007-12-28 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Add an empty drivers/gpio directory for gpiolib infrastructure and GPIO expanders. It is populated by subsequent patches. This won't be the only place to hold such gpio_chip code. Many external chips add a few GPIOs as secondary functio

[patch 2.6.24-rc6-mm 0/9] updated gpiolib patchset

2007-12-28 Thread David Brownell
This patchset is intended to replace the ones currently in the MM tree: generic-gpio-gpio_chip-support.patch generic-gpio-gpio_chip-support-fix.patch generic-gpio-gpio_chip-support-gpiolib-locking-simplified.patch avr32-uses-gpio_chip.patch

Re: [PATCH 11/12] spi : Use mutex instead of semaphore in driver core

2007-12-28 Thread David Brownell
On Friday 28 December 2007, Dave Young wrote: > Signed-off-by: Dave Young <[EMAIL PROTECTED]> ACK ... if the driver core is changing, this is obvious. > --- > drivers/spi/spi.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff -upr linux/drivers/spi/spi.c

Re: [PATCH 11/12] spi : Use mutex instead of semaphore in driver core

2007-12-28 Thread David Brownell
On Friday 28 December 2007, Dave Young wrote: Signed-off-by: Dave Young [EMAIL PROTECTED] ACK ... if the driver core is changing, this is obvious. --- drivers/spi/spi.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -upr linux/drivers/spi/spi.c

[patch 2.6.24-rc6-mm 1/9] gpiolib: add drivers/gpio directory

2007-12-28 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Add an empty drivers/gpio directory for gpiolib infrastructure and GPIO expanders. It is populated by subsequent patches. This won't be the only place to hold such gpio_chip code. Many external chips add a few GPIOs as secondary functionality (such as MFD

[patch 2.6.24-rc6-mm 2/9] gpiolib: add gpio provider infrastructure

2007-12-28 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Provide new implementation infrastructure that platforms may choose to use to support the GPIO programming interface. Platforms can update current GPIO support to use this. In many cases the incremental cost to access a non-inlined GPIO should be less than

[patch 2.6.24-rc6-mm 3/9] gpiolib: update Documentation/gpio.txt

2007-12-28 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Update Documentation/gpio.txt, primarily to include the new optional gpiolib implementation infrastructure. Signed-off-by: David Brownell [EMAIL PROTECTED] --- Documentation/gpio.txt | 133 - 1 file changed

[patch 2.6.24-rc6-mm 4/9] gpiolib: avr32 at32ap platform support

2007-12-28 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Teach AVR32 to use the GPIO Library when exposing its GPIOs, so that signals on external chips (like GPIO expanders) can easily be used. This mostly just reorganizes some existing logic, with two minor changes in behavior: - The PSR registers are used

[patch 2.6.24-rc6-mm 5/9] gpiolib: pxa platform support

2007-12-28 Thread David Brownell
and CPLDs, as used on various product and developer boards. Signed-off-by: Philipp Zabel [EMAIL PROTECTED] Signed-off-by: David Brownell [EMAIL PROTECTED] Acked-by: Russell King [EMAIL PROTECTED] --- arch/arm/Kconfig|1 arch/arm/mach-pxa/Makefile |2 arch/arm/mach

[patch 2.6.24-rc6-mm 0/9] updated gpiolib patchset

2007-12-28 Thread David Brownell
This patchset is intended to replace the ones currently in the MM tree: generic-gpio-gpio_chip-support.patch generic-gpio-gpio_chip-support-fix.patch generic-gpio-gpio_chip-support-gpiolib-locking-simplified.patch avr32-uses-gpio_chip.patch

[patch 2.6.24-rc6-mm 6/9] gpiolib: pcf857x i2c gpio expander support

2007-12-28 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] This is a new-style I2C driver for most common 8 and 16 bit I2C based quasi-bidirectional GPIO expanders: pcf8574 or pcf8575, and several compatible models (mostly faster, supporting I2C at up to 1 MHz). The driver exposes the GPIO signals using

[patch 2.6.24-rc6-mm 7/9] gpiolib: mcp23s08 spi gpio expander support

2007-12-28 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Basic driver for 8-bit SPI based MCP23S08 GPIO expander, without support for IRQs or the shared chipselect mechanism. Signed-off-by: David Brownell [EMAIL PROTECTED] --- drivers/gpio/Kconfig |7 drivers/gpio/Makefile|1 drivers

[patch 2.6.24-rc6-mm 8/9] gpiolib: pca9539 i2c gpio expander support

2007-12-28 Thread David Brownell
, and caches the OUTPUT and DIRECTION registers for fast access. Signed-off-by: eric miao [EMAIL PROTECTED] Signed-off-by: David Brownell [EMAIL PROTECTED] --- drivers/gpio/Kconfig| 10 + drivers/gpio/Makefile |1 drivers/gpio/pca9539.c | 264

<    1   2   3   4   5   6   7   8   9   10   >