Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-14 Thread David Miller
From: "Westergreen, Dalon" Date: Tue, 14 Jul 2020 18:51:15 + > I don't think this is necessary, i think just having a module parameter > meets our needs. I don't see a need for the value to change on a per > interface basis. This was primarily used during testing / bringup. Please no modul

Re: [PATCH] wan: Replace HTTP links with HTTPS ones

2020-07-13 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 22:48:12 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] pcnet32: switch from 'pci_' to 'dma_' API

2020-07-13 Thread David Miller
From: Christophe JAILLET Date: Mon, 13 Jul 2020 22:18:45 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GPF_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] amd8111e: switch from 'pci_' to 'dma_' API

2020-07-13 Thread David Miller
From: Christophe JAILLET Date: Mon, 13 Jul 2020 21:55:03 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GPF_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] net: wan: cosa: Replace HTTP links with HTTPS ones

2020-07-13 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 19:34:47 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] net: jme: Replace HTTP links with HTTPS ones

2020-07-13 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 19:24:39 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] net: ethernet: Replace HTTP links with HTTPS ones

2020-07-13 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 19:14:29 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] net: phy: fix mdio-mscc-miim build

2020-07-13 Thread David Miller
From: Bartosz Golaszewski Date: Mon, 13 Jul 2020 17:12:07 +0200 > From: Bartosz Golaszewski > > PHYLIB is not selected by mdio-mscc-miim but it uses mdio devres helpers. > Explicitly select MDIO_DEVRES in this driver's Kconfig entry. > > Reported-by: kernel test robot > Fixes: 1814cff26739 ("

Re: [PATCH] isdn/capi: Replace HTTP links with HTTPS ones

2020-07-13 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 16:30:54 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [net-next PATCH 0/2] Interrupt handler support for NPA and NIX in

2020-07-13 Thread David Miller
Networking patches must be submitted to net...@vger.kernel.org in order to be reviewed and considered. Thank you.

Re: [PATCH net-next] net: ipa: fix kerneldoc comments

2020-07-13 Thread David Miller
From: Alex Elder Date: Mon, 13 Jul 2020 07:24:18 -0500 > This commit affects comments (and in one case, whitespace) only. > > Throughout the IPA code, return statements are documented using > "@Return:", whereas they should use "Return:" instead. Fix these > mistakes. > > In function definitio

Re: [PATCH] usb: hso: Fix debug compile warning on sparc32

2020-07-13 Thread David Miller
From: Geert Uytterhoeven Date: Mon, 13 Jul 2020 13:05:13 +0200 > On sparc32, tcflag_t is "unsigned long", unlike on all other > architectures, where it is "unsigned int": > > drivers/net/usb/hso.c: In function ‘hso_serial_set_termios’: > include/linux/kern_levels.h:5:18: warning: format

Re: [PATCH] atm: Replace HTTP links with HTTPS ones

2020-07-13 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 12:24:18 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] arch/sparc: Replace HTTP links with HTTPS ones

2020-07-13 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 11:53:51 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] WAN: Replace HTTP links with HTTPS ones

2020-07-13 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 11:33:23 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] [NET] AX.25 Kconfig: Replace HTTP links with HTTPS ones

2020-07-13 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 11:02:51 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH net-next] rtnetlink: Fix memory(net_device) leak when ->newlink fails

2020-07-13 Thread David Miller
From: Weilong Chen Date: Mon, 13 Jul 2020 15:55:28 +0800 > When vlan_newlink call register_vlan_dev fails, it might return error > with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should > free the memory. But currently rtnl_newlink only free the memory which > state is NETREG_UNINITIA

Re: [PATCH] [DCCP]: Replace HTTP links with HTTPS ones

2020-07-13 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 13 Jul 2020 09:51:08 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] net: skge: switch from 'pci_' to 'dma_' API

2020-07-12 Thread David Miller
From: Christophe JAILLET Date: Sat, 11 Jul 2020 22:35:18 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GPF_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] net: sky2: switch from 'pci_' to 'dma_' API

2020-07-12 Thread David Miller
From: Christophe JAILLET Date: Sat, 11 Jul 2020 22:49:44 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GPF_ with a correct flag. > It has been compile tested. > > W

[GIT] Networking

2020-07-10 Thread David Miller
It's been about two weeks since the last batch of fixes, and it shows as we clock in here at 146 non-merge commits: 1) Restore previous behavior of CAP_SYS_ADMIN wrt. loading networking BPF programs, from Maciej Żenczykowski. 2) Fix dropped broadcasts in mac80211 code, from Seevalamuthu Maria

Re: [PATCH net-next v3 0/7] Add devlink-health support for devlink ports

2020-07-10 Thread David Miller
From: Moshe Shemesh Date: Fri, 10 Jul 2020 15:25:06 +0300 > Implement support for devlink health reporters on per-port basis. Series applied, thank you.

Re: [PATCH v5 0/5] net: macb: Wake-on-Lan magic packet fixes and GEM handling

2020-07-10 Thread David Miller
From: Date: Fri, 10 Jul 2020 14:46:40 +0200 > Here is a split series to fix WoL magic-packet on the current macb driver. > Only > fixes in this one based on current net/master. Series applied, thank you.

Re: [PATCH] ipv6: Support more than 32 MIFS

2020-07-09 Thread David Miller
From: Mark Tomlinson Date: Fri, 10 Jul 2020 11:27:34 +1200 > As background to this patch, we have MAXMIFS set to 1025 in our kernel. This patch is pointless without that adjustment, so it really doesn't belong upstream until you tackle the whole entire problem and therefore make the limit able t

Re: [PATCH] net: phy: mscc: fix ptr_ret.cocci warnings

2020-07-09 Thread David Miller
From: kernel test robot Date: Fri, 10 Jul 2020 00:06:18 +0800 > From: kernel test robot > > drivers/net/phy/mscc/mscc_ptp.c:1496:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci >

Re: [PATCH][next] net: systemport: fix double shift of a vlan_tci by VLAN_PRIO_SHIFT

2020-07-09 Thread David Miller
From: Colin King Date: Wed, 8 Jul 2020 19:37:23 +0100 > From: Colin Ian King > > Currently the u16 skb->vlan_tci is being right shifted twice by > VLAN_PRIO_SHIFT, once in the macro skb_vlan_tag_get_pri and explicitly > by VLAN_PRIO_SHIFT afterwards. The combined shift amount is larger than >

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add serdes read/write dynamic debug

2020-07-09 Thread David Miller
From: Chris Healy Date: Thu, 9 Jul 2020 11:43:18 -0700 > Add deb_dbg print statements in both serdes_read and serdes_write > functions. > > Signed-off-by: Chris Healy Please just use tracepoints or similar for this.

Re: [PATCH net] ethtool: fix genlmsg_put() failure handling in ethnl_default_dumpit()

2020-07-09 Thread David Miller
From: Michal Kubecek Date: Thu, 9 Jul 2020 12:11:50 +0200 (CEST) > If the genlmsg_put() call in ethnl_default_dumpit() fails, we bail out > without checking if we already have some messages in current skb like we do > with ethnl_default_dump_one() failure later. Therefore if existing messages >

Re: [PATCH] net: enetc: use eth_broadcast_addr() to assign broadcast

2020-07-09 Thread David Miller
From: Xu Wang Date: Thu, 9 Jul 2020 06:48:55 + > This patch is to use eth_broadcast_addr() to assign broadcast address > insetad of memset(). > > Signed-off-by: Xu Wang Applied to net-next, thanks.

Re: [PATCH net-next] bonding: don't need RTNL for ipsec helpers

2020-07-08 Thread David Miller
From: Jarod Wilson Date: Wed, 8 Jul 2020 18:58:49 -0400 > The bond_ipsec_* helpers don't need RTNL, and can potentially get called > without it being held, so switch from rtnl_dereference() to > rcu_dereference() to access bond struct data. > > Lightly tested with xfrm bonding, no problems foun

Re: [PATCH net-next] bonding: deal with xfrm state in all modes and add more error-checking

2020-07-08 Thread David Miller
From: Jarod Wilson Date: Wed, 8 Jul 2020 13:46:31 -0400 > It's possible that device removal happens when the bond is in non-AB mode, > and addition happens in AB mode, so bond_ipsec_del_sa() never gets called, > which leaves security associations in an odd state if bond_ipsec_add_sa() > then get

Re: [PATCH net-next 0/2] net: phy: Uninline PHY ethtool statistics

2020-07-08 Thread David Miller
From: Florian Fainelli Date: Wed, 8 Jul 2020 09:46:23 -0700 > Now that we have introduced ethtool_phy_ops we can uninline those > operations and move them back into phy.c where they belong. Since those > functions are used by DSA, we need to continue exporting those symbols. > > It might be pos

Re: [PATCH] net: ethernet: mtk_eth_soc: fix mtu warning

2020-07-08 Thread David Miller
From: Frank Wunderlich Date: Wed, 8 Jul 2020 17:46:34 +0200 > From: René van Dorst > > in recent Kernel-Versions there are warnings about incorrect MTU-Size > like these: > > mt7530 mdio-bus:00: nonfatal error -95 setting MTU on port x > eth0: mtu greater than device maximum > mtk_soc_eth 1b1

Re: [PATCH net] net: atlantic: fix ip dst and ipv6 address filters

2020-07-08 Thread David Miller
From: Alexander Lobakin Date: Wed, 8 Jul 2020 17:17:10 +0300 > From: Dmitry Bogdanov > > This patch fixes ip dst and ipv6 address filters. > There were 2 mistakes in the code, which led to the issue: > * invalid register was used for ipv4 dst address; > * incorrect write order of dwords for ipv

Re: [PATCH] Replace HTTP links with HTTPS ones: ATMEL MACB ETHERNET DRIVER

2020-07-08 Thread David Miller
From: "Alexander A. Klimov" Date: Wed, 8 Jul 2020 12:35:19 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

2020-07-08 Thread David Miller
From: "Ooi, Joyce" Date: Wed, 8 Jul 2020 15:24:00 +0800 > +int msgdma_pref_initialize(struct altera_tse_private *priv) > +{ > + int i; > + struct msgdma_pref_extended_desc *rx_descs; > + struct msgdma_pref_extended_desc *tx_descs; > + dma_addr_t rx_descsphys; > + dma_addr_t t

Re: [PATCH net-next] net: dsa: loop: Print when registration is successful

2020-07-08 Thread David Miller
From: Florian Fainelli Date: Tue, 7 Jul 2020 21:45:13 -0700 > We have a number of error conditions that can lead to the driver not > probing successfully, move the print when we are sure > dsa_register_switch() has suceeded. This avoids repeated prints in case > of probe deferral for instance. >

Re: [PATCH] drivers/net/wan/x25_asy: Fix to make it work

2020-07-08 Thread David Miller
From: Xie He Date: Tue, 7 Jul 2020 21:37:54 -0700 > This driver is not working because of problems of its receiving code. > This patch fixes it to make it work. > > When the driver receives an LAPB frame, it should first pass the frame > to the LAPB module to process. After processing, the LAPB

Re: [PATCH net-next] net: sfp: add error checking with sfp_irq_name

2020-07-07 Thread David Miller
From: Chris Healy Date: Tue, 7 Jul 2020 13:32:05 -0700 > Add error checking with sfp_irq_name before use. > > Signed-off-by: Chris Healy Applied.

Re: [PATCH][next] net/sched: Use fallthrough pseudo-keyword

2020-07-07 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 7 Jul 2020 12:21:38 -0500 > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/htm

Re: [PATCH] Replace HTTP links with HTTPS ones: GRETH 10/100/1G Ethernet MAC device driver

2020-07-07 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 6 Jul 2020 22:50:18 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH] Replace HTTP links with HTTPS ones: X.25 network layer

2020-07-07 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 6 Jul 2020 22:50:30 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH v2 net] net: qed: fix buffer overflow on ethtool -d

2020-07-07 Thread David Miller
From: Alexander Lobakin Date: Mon, 6 Jul 2020 12:25:53 +0300 > When generating debug dump, driver firstly collects all data in binary > form, and then performs per-feature formatting to human-readable if it > is supported. > > For ethtool -d, this is roughly incorrect for two reasons. First of a

Re: [PATCH][next] bnx2x: fix spelling mistake "occurd" -> "occurred"

2020-07-07 Thread David Miller
From: Colin King Date: Mon, 6 Jul 2020 13:12:40 +0100 > From: Colin Ian King > > There are spelling mistakes in various literal strings. Fix these. > > Signed-off-by: Colin Ian King Applied, thanks.

Re: [PATCH net-next v2 0/3] net: ethtool: Untangle PHYLIB dependency

2020-07-07 Thread David Miller
From: Florian Fainelli Date: Sun, 5 Jul 2020 21:27:55 -0700 > This patch series untangles the ethtool netlink dependency with PHYLIB > which exists because the cable test feature calls directly into PHY > library functions. The approach taken here is to introduce > ethtool_phy_ops function point

Re: [PATCH net v2] bridge: mcast: Fix MLD2 Report IPv6 payload length check

2020-07-07 Thread David Miller
From: Linus Lüssing Date: Sun, 5 Jul 2020 21:10:17 +0200 > Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs pointer in > igmp3/mld2 report handling") introduced a bug in the IPv6 header payload > length check which would potentially lead to rejecting a valid MLD2 Report: > > The check

Re: [PATCH net-next] net: phy: add a Kconfig option for mdio_devres

2020-07-07 Thread David Miller
From: Bartosz Golaszewski Date: Sun, 5 Jul 2020 11:55:47 +0200 > From: Bartosz Golaszewski > > If phylib is built as a module and CONFIG_MDIO_DEVICE is 'y', the > mdio_device and mdio_bus code will be in the phylib module, not in the > kernel image. Meanwhile we build mdio_devres depending on

Re: [PATCH] net: sky2: initialize return of gm_phy_read

2020-07-07 Thread David Miller
From: t...@redhat.com Date: Fri, 3 Jul 2020 06:33:59 -0700 > From: Tom Rix > > clang static analysis flags this garbage return > > drivers/net/ethernet/marvell/sky2.c:208:2: warning: Undefined or garbage > value returned to caller [core.uninitialized.UndefReturn] > return v; >

Re: [PATCH v2 0/2] smsc: use generic power management

2020-07-07 Thread David Miller
From: Vaibhav Gupta Date: Fri, 3 Jul 2020 08:31:36 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from smsc ethernet drivers. > > The callbacks performing suspend() and resume() operations ar

Re: [PATCH net-next] mvpp2: fix pointer check

2020-07-07 Thread David Miller
From: Matteo Croce Date: Tue, 7 Jul 2020 15:19:13 +0200 > From: Matteo Croce > > priv->page_pool is an array, so comparing against it will always return true. > Do a meaningful check by checking priv->page_pool[0] instead. > While at it, clear the page_pool pointers on deallocation, or when an

Re: [PATCH] net: usb: qmi_wwan: add support for Quectel EG95 LTE modem

2020-07-07 Thread David Miller
From: AceLan Kao Date: Tue, 7 Jul 2020 16:14:45 +0800 > Add support for Quectel Wireless Solutions Co., Ltd. EG95 LTE modem > > T: Bus=01 Lev=01 Prnt=01 Port=02 Cnt=02 Dev#= 5 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=2c7c ProdID=0195 Rev=03.1

Re: [PATCH net-next] sun/niu: add __maybe_unused attribute to PM functions

2020-07-07 Thread David Miller
From: Vaibhav Gupta Date: Tue, 7 Jul 2020 13:11:22 +0530 > The upgraded .suspend() and .resume() throw > "defined but not used [-Wunused-function]" warning for certain > configurations. > > Mark them with "__maybe_unused" attribute. > > Compile-tested only. > > Fixes: b0db0cc2f695 ("sun/niu:

Re: [PATCH] net: atlantic: Add support for firmware v4

2020-07-07 Thread David Miller
From: Alexander Lobakin Date: Tue, 7 Jul 2020 11:46:57 +0300 > From: Kai-Heng Feng > Date: Tue, 7 Jul 2020 14:38:28 +0800 > >> We have a new ethernet card that is supported by the atlantic driver: >> 01:00.0 Ethernet controller [0200]: Aquantia Corp. AQC107 NBase-T/IEEE >> 802.3bz Etherne

Re: [PATCH net-next v3] net: sfp: Unique GPIO interrupt names

2020-07-07 Thread David Miller
From: Chris Healy Date: Mon, 6 Jul 2020 18:27:07 -0700 > From: Chris Healy > > Dynamically generate a unique GPIO interrupt name, based on the > device name and the GPIO name. For example: > > 103: 0 sx1503q 12 Edge sff2-los > 104: 0 sx1503q 13 Edge sff2-tx-

Re: [PATCH net 0/3] net: ipa: fix warning-reported errors

2020-07-07 Thread David Miller
From: Alex Elder Date: Mon, 6 Jul 2020 18:10:07 -0500 > Building the kernel with W=1 produces numerous warnings for the IPA > code. Some of those warnings turn out to flag real problems, and > this series fixes them. The first patch fixes the most important > ones, but the second and third are

Re: [PATCH net-next] net: systemport: Add support for VLAN transmit acceleration

2020-07-07 Thread David Miller
From: Florian Fainelli Date: Mon, 6 Jul 2020 14:29:39 -0700 > SYSTEMPORT is capable of performing VLAN transmit acceleration, support > that by configuring it appropriately, providing the VLAN ID and PCP/DEI > where necessary. > > Signed-off-by: Florian Fainelli Applied, thanks Florian.

Re: [PATCH] Replace HTTP links with HTTPS ones: IPv*

2020-07-06 Thread David Miller
From: "Alexander A. Klimov" Date: Mon, 6 Jul 2020 19:38:50 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH net-next 0/9] net: qed/qede: W=1 C=1 warnings cleanup

2020-07-06 Thread David Miller
From: Alexander Lobakin Date: Mon, 6 Jul 2020 18:38:12 +0300 > This set cleans qed/qede build log under W=1 C=1 with GCC 8 and > sparse 0.6.2. The only thing left is "context imbalance -- unexpected > unlock" in one of the source files, which will be issued later during > the refactoring cycles.

Re: [PATCH] net/amd: Remove needless assignment and the extra brank lines

2020-07-06 Thread David Miller
From: Tang Bin Date: Mon, 6 Jul 2020 22:47:01 +0800 > The variable 'err = -ENODEV;' in au1000_probe() is > duplicate, so remove redundant one. And remove the > extra blank lines in the file au1000_eth.c > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Applied to net-next, thanks.

Re: [PATCH net-next] selftests: mptcp: capture pcap on both sides

2020-07-06 Thread David Miller
From: Matthieu Baerts Date: Mon, 6 Jul 2020 14:44:08 +0200 > When investigating performance issues that involve latency / loss / > reordering it is useful to have the pcap from the sender-side as it > allows to easier infer the state of the sender's congestion-control, > loss-recovery, etc. > >

Re: [PATCH net 0/4] net: hns3: fixes for -net

2020-07-06 Thread David Miller
From: Huazhong Tan Date: Mon, 6 Jul 2020 19:25:58 +0800 > There are some fixes about reset issue and a use-after-free > of self-test. Series applied, thank you.

Re: [PATCH net-next 02/12] bridge: uapi: mrp: Extend MRP attributes for MRP interconnect

2020-07-06 Thread David Miller
From: Horatiu Vultur Date: Mon, 6 Jul 2020 11:18:32 +0200 > +struct br_mrp_in_state { > + __u16 in_id; > + __u32 in_state; > +}; Put the __u32 first then the __u16. > +struct br_mrp_in_role { > + __u16 in_id; > + __u32 ring_id; > + __u32 in_role; > + __u32 i_ifindex; > +

Re: [PATCH net-next 01/12] switchdev: mrp: Extend switchdev API for MRP Interconnect

2020-07-06 Thread David Miller
From: Horatiu Vultur Date: Mon, 6 Jul 2020 11:18:31 +0200 > +/* SWITCHDEV_OBJ_ID_IN_TEST_MRP */ > +struct switchdev_obj_in_test_mrp { > + struct switchdev_obj obj; > + /* The value is in us and a value of 0 represents to stop */ > + u32 interval; > + u8 max_miss; > + u32 in_id

Re: [PATCH v1 0/3] ethernet: sun: use generic power management

2020-07-06 Thread David Miller
From: Vaibhav Gupta Date: Mon, 6 Jul 2020 14:27:43 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from sun ethernet drivers. > > The callbacks performing suspend() and resume() operations are

Re: [PATCH v2] drivers/net/wan/lapbether: Fixed the value of hard_header_len

2020-07-06 Thread David Miller
From: Xie He Date: Sun, 5 Jul 2020 17:45:21 -0700 > When this driver transmits data, > first this driver will remove a pseudo header of 1 byte, > then the lapb module will prepend the LAPB header of 2 or 3 bytes, > then this driver will prepend a length field of 2 bytes, > then the under

Re: [PATCH v2 0/2] qlogic: use generic power management

2020-07-04 Thread David Miller
From: Vaibhav Gupta Date: Thu, 2 Jul 2020 22:31:41 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from qlogic ethernet drivers. > > The callbacks performing suspend() and resume() operations

Re: [PATCH net-next v2 1/2] net: dsa: microchip: split adjust_link() in phylink_mac_link_{up|down}()

2020-07-04 Thread David Miller
From: Codrin Ciubotariu Date: Thu, 2 Jul 2020 18:17:23 +0300 > The DSA subsystem moved to phylink and adjust_link() became deprecated in > the process. This patch removes adjust_link from the KSZ DSA switches and > adds phylink_mac_link_up() and phylink_mac_link_down(). > > Signed-off-by: Codrin

Re: [PATCH net-next v2 2/2] net: dsa: microchip: remove unused private members

2020-07-04 Thread David Miller
From: Codrin Ciubotariu Date: Thu, 2 Jul 2020 18:17:24 +0300 > Private structure members live_ports, on_ports, rx_ports, tx_ports are > initialized but not used anywhere. Let's remove them. > > Suggested-by: Russell King > Signed-off-by: Codrin Ciubotariu Applied.

Re: [PATCH net] hinic: fix sending mailbox timeout in aeq event work

2020-07-04 Thread David Miller
From: Luo bin Date: Sat, 4 Jul 2020 15:32:43 +0800 > When sending mailbox in the work of aeq event, another aeq event > will be triggered. because the last aeq work is not exited and only > one work can be excuted simultaneously in the same workqueue, mailbox > sending function will return failur

Re: [PATCH] drivers/net/wan/lapbether: Fixed the value of hard_header_len

2020-07-04 Thread David Miller
From: Xie He Date: Fri, 3 Jul 2020 22:12:46 -0700 > When transmitting data from upper layers or from AF_PACKET sockets, > this driver will first remove a pseudo header of 1 byte, > then the lapb module will prepend the LAPB header of 2 or 3 bytes, > then this driver will prepend a length f

Re: [PATCH 0/7] Documentation: networking: eliminate doubled words

2020-07-04 Thread David Miller
From: Randy Dunlap Date: Fri, 3 Jul 2020 15:41:08 -0700 > Drop all duplicated words in Documentation/networking/ files. Series applied, thanks Randy.

Re: [PATCH net-next v2 0/5] mvpp2: XDP support

2020-07-03 Thread David Miller
From: Matteo Croce Date: Thu, 2 Jul 2020 16:12:39 +0200 > From: Matteo Croce > > From: Matteo Croce > > Add XDP support to mvpp2. This series converts the driver to the > page_pool API for RX buffer management, and adds native XDP support. > > XDP support comes with extack error reporting a

Re: [PATCH net-next 0/2] net: ipa: fix HOLB timer register use

2020-07-03 Thread David Miller
From: Alex Elder Date: Fri, 3 Jul 2020 16:23:33 -0500 > The function ipa_reg_init_hol_block_timer_val() generates the value > to write into the HOL_BLOCK_TIMER endpoint configuration register, > to represent a given timeout value (in microseconds). It only > supports a timer value of 0 though,

Re: [PATCH net] net: qed: prevent buffer overflow when collecting debug data

2020-07-03 Thread David Miller
From: Alexander Lobakin Date: Fri, 3 Jul 2020 12:02:58 +0300 > When generating debug dump, driver firstly collects all data in binary > form, and then performs per-feature formatting to human-readable if it > is supported. > The size of the new formatted data is often larger than the raw's. This

Re: [PATCH net-next] net: bcmgenet: Allow changing carrier from user-space

2020-07-03 Thread David Miller
From: Florian Fainelli Date: Thu, 2 Jul 2020 21:57:00 -0700 > The GENET driver interfaces with internal MoCA interface as well as > external MoCA chips like the BCM6802/6803 through a fixed link > interface. It is desirable for the mocad user-space daemon to be able to > control the carrier stat

Re: [PATCH][next] xen-netfront: remove redundant assignment to variable 'act'

2020-07-02 Thread David Miller
From: Colin King Date: Thu, 2 Jul 2020 15:22:23 +0100 > From: Colin Ian King > > The variable act is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value

Re: [PATCH] MAINTAINERS: net: macb: add Claudiu as co-maintainer

2020-07-02 Thread David Miller
From: Date: Thu, 2 Jul 2020 15:00:21 +0200 > From: Nicolas Ferre > > I would like that Claudiu becomes co-maintainer of the Cadence macb > driver. He's already participating to lots of reviews and enhancements > to this driver and knows the different versions of this controller. > > Signed-off

Re: [PATCH net-next 0/4] net: ipa: simplify endpoint programming

2020-07-02 Thread David Miller
From: Alex Elder Date: Thu, 2 Jul 2020 06:25:33 -0500 > Add tests to functions so they don't update undefined endpoint > registers, rather than requiring the caller to avoid calling them. > > Move the call to a workaround function required when suspending > inside the function that puts an endp

Re: [PATCH net] net: dsa: microchip: set the correct number of ports

2020-07-02 Thread David Miller
From: Codrin Ciubotariu Date: Thu, 2 Jul 2020 12:44:50 +0300 > The number of ports is incorrectly set to the maximum available for a DSA > switch. Even if the extra ports are not used, this causes some functions > to be called later, like port_disable() and port_stp_state_set(). If the > driver d

Re: [PATCH net-next v2 0/4] net: macb: few code cleanups

2020-07-02 Thread David Miller
From: Claudiu Beznea Date: Thu, 2 Jul 2020 12:05:57 +0300 > Patches in this series cleanup a bit macb code. ... Series applied, thanks.

Re: [PATCH net-next v3 0/3] bridge: mrp: Add support for getting the status

2020-07-02 Thread David Miller
From: Horatiu Vultur Date: Thu, 2 Jul 2020 10:13:04 +0200 > This patch series extends the MRP netlink interface to allow the userspace > daemon to get the status of the MRP instances in the kernel. > > v3: > - remove misleading comment > - fix to use correctly the RCU > > v2: > - fix spar

Re: [PATCH] net: sched: Allow changing default qdisc to FQ-PIE

2020-07-01 Thread David Miller
From: Danny Lin Date: Wed, 1 Jul 2020 16:01:52 -0700 > Similar to fq_codel and the other qdiscs that can set as default, > fq_pie is also suitable for general use without explicit configuration, > which makes it a valid choice for this. > > This is useful in situations where a painless out-of-t

Re: [PATCH net-next] bonding: allow xfrm offload setup post-module-load

2020-07-01 Thread David Miller
From: Jarod Wilson Date: Tue, 30 Jun 2020 14:49:41 -0400 > At the moment, bonding xfrm crypto offload can only be set up if the bonding > module is loaded with active-backup mode already set. We need to be able to > make this work with bonds set to AB after the bonding driver has already > been l

Re: [PATCH net-next v2 0/5] net: ipa: endpoint configuration updates

2020-07-01 Thread David Miller
From: Alex Elder Date: Tue, 30 Jun 2020 08:32:59 -0500 > This series updates code that configures IPA endpoints. The changes > made mainly affect access to registers that are valid only for RX, or > only for TX endpoints. > > The first three patches avoid writing endpoint registers if they are

Re: [PATCH net-next v2 0/3] net: ipa: small improvements

2020-07-01 Thread David Miller
From: Alex Elder Date: Tue, 30 Jun 2020 07:58:43 -0500 > This series contains two patches that improve the error output > that's reported when an error occurs while changing the state of a > GSI channel or event ring. The first ensures all such error > conditions report an error, and the second

Re: [PATCH net-next 0/3] net: ipa: simple refactorizations

2020-07-01 Thread David Miller
From: Alex Elder Date: Mon, 29 Jun 2020 16:55:20 -0500 > This series makes three small changes to some endpoint configuration > code. The first uses a constant to represent the frequency of an > internal clock used for timers in the IPA. The second modifies a > limit used so it matches Qualcomm

Re: [PATCH v2 00/11] net: ethernet: use generic power management

2020-07-01 Thread David Miller
From: Vaibhav Gupta Date: Wed, 1 Jul 2020 22:20:46 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from net ethernet drivers. > > The callbacks performing suspend() and resume() operations are

Re: [PATCH] net/packet: remove redundant initialization of variable err

2020-07-01 Thread David Miller
From: Colin King Date: Wed, 1 Jul 2020 16:04:33 +0100 > From: Colin Ian King > > The variable err is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused valu

Re: [PATCH net-next 2/4] net: macb: use hweight_long() to count set bits in queue_mask

2020-07-01 Thread David Miller
From: Claudiu Beznea Date: Wed, 1 Jul 2020 16:08:49 +0300 > @@ -3482,8 +3482,6 @@ static void macb_probe_queues(void __iomem *mem, > unsigned int *queue_mask, ... > + *num_queues = hweight_long(*queue_mask); queue_mask is not a long, it is an unsinged int, theref

Re: [PATCH net v1] hinic: fix passing non negative value to ERR_PTR

2020-07-01 Thread David Miller
From: Luo bin Date: Wed, 1 Jul 2020 11:16:33 +0800 > get_dev_cap and set_resources_state functions may return a positive > value because of hardware failure, and the positive return value > can not be passed to ERR_PTR directly. > > Fixes: 7dd29ee12865 ("hinic: add sriov feature support") > Sign

Re: [PATCH net] net: qrtr: Fix an out of bounds read qrtr_endpoint_post()

2020-06-30 Thread David Miller
From: Dan Carpenter Date: Tue, 30 Jun 2020 14:46:15 +0300 > This code assumes that the user passed in enough data for a > qrtr_hdr_v1 or qrtr_hdr_v2 struct, but it's not necessarily true. If > the buffer is too small then it will read beyond the end. > > Reported-by: Manivannan Sadhasivam > Re

Re: [PATCH net-next 1/2] amd8111e: Mark PM functions as __maybe_unused

2020-06-30 Thread David Miller
From: Nathan Chancellor Date: Tue, 30 Jun 2020 14:00:33 -0700 > In certain configurations without power management support, the > following warnings happen: > > ../drivers/net/ethernet/amd/amd8111e.c:1623:12: warning: > 'amd8111e_resume' defined but not used [-Wunused-function] > 1623 | static

Re: [PATCH net-next 2/2] pcnet32: Mark PM functions as __maybe_unused

2020-06-30 Thread David Miller
From: Nathan Chancellor Date: Tue, 30 Jun 2020 14:00:34 -0700 > In certain configurations without power management support, the > following warnings happen: > > ../drivers/net/ethernet/amd/pcnet32.c:2928:12: warning: > 'pcnet32_pm_resume' defined but not used [-Wunused-function] > 2928 | static

Re: [PATCH v2] net: qrtr: free flow in __qrtr_node_release

2020-06-30 Thread David Miller
From: Carl Huang Date: Tue, 30 Jun 2020 14:52:51 +0800 > The flow is allocated in qrtr_tx_wait, but not freed when qrtr node > is released. (*slot) becomes NULL after radix_tree_iter_delete is > called in __qrtr_node_release. The fix is to save (*slot) to a > vairable and then free it. > > This

Re: [PATCH v2 00/10] net: improve devres helpers

2020-06-30 Thread David Miller
From: Bartosz Golaszewski Date: Mon, 29 Jun 2020 14:03:36 +0200 > From: Bartosz Golaszewski > > So it seems like there's no support for relaxing certain networking devres > helpers to not require previously allocated structures to also be managed. > However the way mdio devres variants are impl

Re: [PATCH] net: cxgb4: fix return error value in t4_prep_fw

2020-06-30 Thread David Miller
From: Li Heng Date: Mon, 29 Jun 2020 18:49:51 +0800 > t4_prep_fw goto bye tag with positive return value when something > bad happened and which can not free resource in adap_init0. > so fix it to return negative value. > > Fixes: 16e47624e76b ("cxgb4: Add new scheme to update T4/T5 firmware") >

Re: [PATCH net-next 0/6] net: qed/qede: license cleanup

2020-06-30 Thread David Miller
From: Alexander Lobakin Date: Mon, 29 Jun 2020 14:05:06 +0300 > QLogic QED drivers source code is dual licensed under > GPL-2.0/BSD-3-Clause. > > Correct already existing but wrong SPDX tags to match the actual > license. > Remove the license boilerplates and replace them with the correct > SPDX

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-30 Thread David Miller
From: Alex Elder Date: Tue, 30 Jun 2020 17:41:44 -0500 > My point was to try to isolate the damage done to the IPA device and > driver, rather than killing the system. Excellent, then we are both on the same page.

Re: [PATCH v4 21/26] mm/sparc64: Use general page fault accounting

2020-06-30 Thread David Miller
From: Peter Xu Date: Tue, 30 Jun 2020 16:45:56 -0400 > Use the general page fault accounting by passing regs into handle_mm_fault(). > It naturally solve the issue of multiple page fault accounting when page fault > retry happened. > > CC: David S. Miller > CC: sparcli...@vger.kernel.org > Sign

Re: [PATCH v4 20/26] mm/sparc32: Use general page fault accounting

2020-06-30 Thread David Miller
From: Peter Xu Date: Tue, 30 Jun 2020 16:45:53 -0400 > Use the general page fault accounting by passing regs into handle_mm_fault(). > It naturally solve the issue of multiple page fault accounting when page fault > retry happened. > > CC: David S. Miller > CC: sparcli...@vger.kernel.org > Sign

<    4   5   6   7   8   9   10   11   12   13   >