Re: [parisc-linux] [patch 15/23] Add cmpxchg_local to parisc

2007-08-29 Thread David Miller
From: Grant Grundler [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 23:59:55 -0600 [davem: patch for you at the bottom to Documentation/atomic_ops.txt ] Looks fine to me. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: RFC: issues concerning the next NAPI interface

2007-08-29 Thread David Miller
From: Jan-Bernd Themann [EMAIL PROTECTED] Date: Wed, 29 Aug 2007 09:10:15 +0200 In the end I want to reduce the CPU utilization. And one way to do that is LRO which also works only well if there are more then just a very few packets to aggregate. So at least our driver (eHEA) would benefit

Re: XFS Fails Quality Assurance Tests on ARM

2007-08-30 Thread David Miller
From: Byron Bradley [EMAIL PROTECTED] Date: Fri, 31 Aug 2007 03:12:46 + (UTC) Anybody got any ideas of how we fix this? I don't know how much testing XFS gets on ARM, but one thing that some ARM chips have is D-cache aliasing problems and one thing XFS uses a lot is virtual remapping of

Re: ifconfig changing a routing table?

2007-08-30 Thread David Miller
From: Dan Stromberg [EMAIL PROTECTED] Date: Fri, 31 Aug 2007 03:55:53 + (UTC) I'm not accustomed to ifconfig changing the routing table. Is this normal? Every time you enable an IP address on an interface, the kernel creates a route to that subnet which gets likewise deleted when you

Re: [PATCH] Remove write-only variable from pktgen_thread

2007-08-30 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 29 Aug 2007 14:33:56 -0700 Pavel Emelianov [EMAIL PROTECTED] wrote: | The pktgen_thread.pid is set to current-pid and is never used | after this. So remove this at all. | | Found during isolating the explicit pid/tgid usage. | | Signed-off-by: Pavel

Re: [PATCH] [374/2many] MAINTAINERS - PCNET32 NETWORK DRIVER

2007-08-13 Thread David Miller
Ok, 374 patches is just rediculious. So many patches eats up an enormous amount of mailing list resources, and for these patches in particular there are few reasons to split them up at all. The fact that the split up landed you at 300+ patches is a very good indication of that. - To unsubscribe

Re: [PATCH] [374/2many] MAINTAINERS - PCNET32 NETWORK DRIVER

2007-08-13 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Sun, 12 Aug 2007 23:46:49 -0700 I tried to send 1 patch over the last couple of days. Unfortunately, it's 100KB and disappears into the void. The posting limit is 400K for linux-kernel, netdev, and one or two of the other lists. - To unsubscribe from

Re: [PATCH 2.6.23] cxgb3 - Fix dev-priv usage

2007-08-13 Thread David Miller
From: Divy Le Ray [EMAIL PROTECTED] Date: Mon, 13 Aug 2007 12:33:04 -0700 From: Divy Le Ray [EMAIL PROTECTED] cxgb3 used netdev_priv() and dev-priv for different purposes. In 2.6.23, netdev_priv() == dev-priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in

Re: lmbench ctxsw regression with CFS

2007-08-13 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Mon, 13 Aug 2007 20:00:38 -0700 Guys, repeat after me: context switch is not a fast path. Take that benchmark and set fire to it. Nothing in this world is so absolute :-) Regardless of the value of lat_ctx, we should thank it for showing that

Re: linux kernel 2.6.18-20 bug: rcu_read_unlock in __sock_create

2007-08-15 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 15 Aug 2007 16:33:35 +0800 [NET]: Fix unbalanced rcu_read_unlock in __sock_create The recent RCU work created an unbalanced rcu_read_unlock in __sock_create. This patch fixes that. Reported by oleg 123. Signed-off-by: Herbert Xu [EMAIL

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-15 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 16:56:17 -0400 All this is currently checked into the 'eflags' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git But when everybody is happy with it, IMO we should get it into net-2.6.24.git, as it

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-16 Thread David Miller
From: Tom Tucker [EMAIL PROTECTED] Date: Thu, 16 Aug 2007 08:43:11 -0500 Isn't RDMA _part_ of the software net stack within Linux? It very much is not so. When using RDMA you lose the capability to do packet shaping, classification, and all the other wonderful networking facilities you've

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-17 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Fri, 17 Aug 2007 12:52:39 -0700 When using RDMA you lose the capability to do packet shaping, classification, and all the other wonderful networking facilities you've grown to love and use over the years. Same thing with TSO and LRO and who

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-17 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Fri, 17 Aug 2007 16:31:07 -0700 When using RDMA you lose the capability to do packet shaping, classification, and all the other wonderful networking facilities you've grown to love and use over the years. Same thing with TSO

Re: [PATCH] i386: optimize memset of 6 and 8 bytes

2007-08-17 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 17 Aug 2007 20:31:39 -0700 On Fri, 17 Aug 2007 18:57:00 -0700 Arjan van de Ven [EMAIL PROTECTED] wrote: On Fri, 2007-08-17 at 18:54 -0700, Stephen Hemminger wrote: On Fri, 17 Aug 2007 18:49:34 -0700 Arjan van de Ven [EMAIL

SLUB bug on sparc64

2007-08-17 Thread David Miller
Hi Christoph, When I force SLUB debugging on sparc64, it barfs on early bootup while making the sysfs nodes. Removing the BUG()'s on the sysfs error returns, and adding some tracing I captured the log below. BTW, I would recommending removing the BUG() calls, they serve only to force someone

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-18 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Fri, 17 Aug 2007 22:23:01 -0700 Also, looking at the complexity and bug-fixing effort that go into making TSO work vs the really pretty small gain it gives also makes part of me wonder whether the noble proclamations about maintainability are always

Re: [PATCH] missing return in bridge sysfs code

2007-08-18 Thread David Miller
From: Al Viro [EMAIL PROTECTED] Date: Sun, 19 Aug 2007 04:51:26 +0100 Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: David S. Miller [EMAIL PROTECTED] Thanks for catching this Al. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP portsfrom the host TCP port space.

2007-08-19 Thread David Miller
From: Sean Hefty [EMAIL PROTECTED] Date: Sun, 19 Aug 2007 00:01:07 -0700 Millions of Infiniband ports are in operation today. Over 25% of the top 500 supercomputers use Infiniband. The formation of the OpenFabrics Alliance was pushed and has been continuously funded by an RDMA customer - the

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCPportsfrom the host TCP port space.

2007-08-19 Thread David Miller
From: Felix Marti [EMAIL PROTECTED] Date: Sun, 19 Aug 2007 10:33:31 -0700 I know that you don't agree that TSO has drawbacks, as outlined by Roland, but its history showing something else: the addition of TSO took a fair amount of time and network performance was erratic for multiple kernel

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCPportsfrom the host TCP port space.

2007-08-19 Thread David Miller
From: Felix Marti [EMAIL PROTECTED] Date: Sun, 19 Aug 2007 12:49:05 -0700 You're not at all addressing the fact that RDMA does solve the memory BW problem and stateless offload doesn't. It does, I just didn't retort to your claims because they were so blatantly wrong. - To unsubscribe from

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCPportsfrom the host TCP port space.

2007-08-19 Thread David Miller
From: Andi Kleen [EMAIL PROTECTED] Date: 20 Aug 2007 01:27:35 +0200 Felix Marti [EMAIL PROTECTED] writes: what benefits does the TSO infrastructure give the non-TSO capable devices? It improves performance on software queueing devices between guests and hypervisors. This is a more and

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCPportsfrom the host TCP port space.

2007-08-19 Thread David Miller
From: Felix Marti [EMAIL PROTECTED] Date: Sun, 19 Aug 2007 17:32:39 -0700 [ Why do you put that [Felix Marti] everywhere you say something? It's annoying and superfluous. The quoting done by your mail client makes clear who is saying what. ] Hmmm, interesting... I guess it is impossible to

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCPportsfrom the host TCP port space.

2007-08-19 Thread David Miller
From: Felix Marti [EMAIL PROTECTED] Date: Sun, 19 Aug 2007 17:47:59 -0700 [Felix Marti] Please stop using this to start your replies, thank you. David and Herbert, so you agree that the userkernel space memory copy overhead is a significant overhead and we want to enable zero-copy in both

Re: possible endless loop in PROM initialization

2007-08-20 Thread David Miller
From: Markus Dahms [EMAIL PROTECTED] Date: Mon, 20 Aug 2007 09:59:49 +0200 I could track down the issue to the function __prom_nextprop() in arch/sparc/prom/tree.c, but I am now looking for the definition of prom_nodeops-no_nextprop() without success. When we boot the firmware provides a

Re: SLUB bug on sparc64

2007-08-20 Thread David Miller
From: Christoph Lameter [EMAIL PROTECTED] Date: Mon, 20 Aug 2007 11:34:52 -0700 (PDT) On Fri, 17 Aug 2007, David Miller wrote: When I force SLUB debugging on sparc64, it barfs on early bootup while making the sysfs nodes. Removing the BUG()'s on the sysfs error returns, and adding some

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-21 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 20 Aug 2007 18:16:54 -0700 And direct data placement really does give you a factor of two at least, because otherwise you're stuck receiving the data in one buffer, looking at some of the data at least, and then figuring out where to copy it.

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Mon, 20 Aug 2007 22:46:47 -0700 (PDT) Ie a barrier() is likely _cheaper_ than the code generation downside from using volatile. Assuming GCC were ever better about the code generation badness with volatile that has been discussed here, I much

Re: [PATCH] IRDA: Avoid a label defined but not used warning in irda_init()

2007-08-21 Thread David Miller
From: Jesper Juhl [EMAIL PROTECTED] Date: Fri, 17 Aug 2007 23:22:33 +0200 Hi, Easily avoidable compiler warnings bug me. Building irmod without CONFIG_SYSCTL currently results in : net/irda/irmod.c:132: warning: label 'out_err_2' defined but not used But that can easily be avoided

Re: [PATCH 2.6.22.3] ppp: fix output buffer size in ppp_decompress_frame

2007-08-21 Thread David Miller
From: Konstantin Sharlaimov [EMAIL PROTECTED] Date: Fri, 17 Aug 2007 20:45:51 +1100 This patch addresses the issue with osize too small errors in mppe encryption. The patch fixes the issue with wrong output buffer size being passed to ppp decompression routine. Signed-off-by: Konstantin

Re: + git-net-fix-export.patch added to -mm tree

2007-08-21 Thread David Miller
From: [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 16:03:06 -0700 Subject: git-net fix export From: Andrew Morton [EMAIL PROTECTED] Must be silly season or something. Cc: David S. Miller [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] I've applied this to net-2.6.24,

Re: 2.6.23-rc2 cross compile regressions (alpha,sparc,xtensa)

2007-08-06 Thread David Miller
From: Jan Dittmer [EMAIL PROTECTED] Date: Mon, 06 Aug 2007 09:31:55 +0200 sparc/defconfig: CC init/main.o In file included from include/linux/proc_fs.h:5, from init/main.c:14: include/linux/fs.h:848: warning: `struct flock' declared inside parameter list

Re: IPsec IPv4 over IPv6 Problem: No route to host

2007-08-06 Thread David Miller
You'll get a better response to your report by sending it to the network developer list, [EMAIL PROTECTED], rather than here. Thank you. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Error message from device_rename in drivers/base/core.c

2007-08-07 Thread David Miller
From: Larry Finger [EMAIL PROTECTED] Date: Tue, 07 Aug 2007 23:17:23 -0500 I am getting the following error message from drivers/base/core.c: net eth1: device_rename: sysfs_create_symlink failed (-17) Upon investigation, the call generating the error is renaming 'eth1' to 'eth1'. The

Re: Error message from device_rename in drivers/base/core.c

2007-08-07 Thread David Miller
From: Larry Finger [EMAIL PROTECTED] Date: Tue, 07 Aug 2007 23:52:34 -0500 Yes, it is most likely coming from udev. Do you know who maintains udev? Google didn't give an answer in the first two pages. I may be mis-remembering but I thought Greg KH was at the helm at least at one point. - To

Re: [patch] ipvs: force read of atomic_t in while loop

2007-08-08 Thread David Miller
From: Heiko Carstens [EMAIL PROTECTED] Date: Wed, 8 Aug 2007 11:33:00 +0200 Just saw this while grepping for atomic_reads in a while loops. Maybe we should re-add the volatile to atomic_t. Not sure. I think whatever the choice, it should be done consistently on every architecture. It's just

Re: [PATCH] make atomic_t volatile on all architectures

2007-08-08 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 09 Aug 2007 09:03:27 +0800 Such loops should always use something like cpu_relax() which comes with a barrier. This is an excellent point. And it needs to be weighed with the error prone'ness Andrew mentioned. There probably is a middle ground

Re: [PATCH] flush icache before set_pte() on ia64 take9 [2/2] flush icache at set_pte

2007-08-08 Thread David Miller
From: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Date: Thu, 9 Aug 2007 13:57:21 +0900 Changelog v8 - v9. - removed sync_icache_dcache(). - modified set_pte() rather than adding new complexed macro. Old stories - For synching icache and dcache before set_pte(), I added a new macro for ia64,

Re: [PATCH 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-08-09 Thread David Miller
From: Jan-Bernd Themann [EMAIL PROTECTED] Date: Fri, 3 Aug 2007 14:41:14 +0200 I think this patch could be the final version for now. It has been tested on two platforms (power and x86_64) and works very well. I checked in the LRO patch and the two sample driver ports to net-2.6.24, thanks! -

Re: [PATCH 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-08-09 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Thu, 09 Aug 2007 02:31:11 -0400 Either way, I'll want you to push to Linus before I do, when the next merge window opens. No problem. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-09 Thread David Miller
From: Sean Hefty [EMAIL PROTECTED] Date: Thu, 09 Aug 2007 14:40:16 -0700 Steve Wise wrote: Any more comments? Does anyone have ideas on how to reserve the port space without using a struct socket? How about we just remove the RDMA stack altogether? I am not at all kidding. If you guys

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 10:47:10 +0900 (JST) I disagree. It is bad to remove existing interface. Ditto for other patches. I think perhaps you misunderstand what Eric is doing. sys_sysctl() isn't working properly for these cases and it is both a

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread David Miller
From: Ben Greear [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:24 -0700 Jeff Garzik wrote: This patch copies Auke in adding NETIF_F_LRO. Is that just for temporary merging, or does the net core really not touch it at all? Because, logically, if NETIF_F_LRO exists nowhere else but

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread David Miller
From: Ben Greear [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 15:40:02 -0700 For GSO on output, is there a generic fallback for any driver that does not specifically implement GSO? Absolutely, in fact that's mainly what it's there for. I don't think there is any issue. The knob is there via

Re: [git patches] net driver updates

2007-10-09 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 9 Oct 2007 21:03:26 -0400 Please pull from the 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive these changes: Pulled and pushed back out, thanks Jeff! - To unsubscribe

Re: [Linux-usb-users] OHCI root_port_reset() deadly loop...

2007-10-09 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Tue, 09 Oct 2007 15:00:40 -0700 (PDT) From: David Brownell [EMAIL PROTECTED] Date: Tue, 9 Oct 2007 14:43:54 -0700 Does it resolve the problem you observed? I will definitely give the patch a try and report back. My tests look really good

Re: PROBLEM: skb_clone SMP race?

2007-10-10 Thread David Miller
From: Santiago Font Arquer [EMAIL PROTECTED] Date: Wed, 10 Oct 2007 10:37:57 +0200 I'm studying the implementation of sk_buff and I think there's a possible race condition in skb_clone (2.6.22.9) The code is: Please discuss networking code on [EMAIL PROTECTED] which is where the

Re: Crypto Update for 2.6.24

2007-10-10 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 10 Oct 2007 11:17:29 +0800 Here is the crypto update for 2.6.24: Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git or master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git I've integrated

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-10-10 Thread David Miller
From: Sean Hefty [EMAIL PROTECTED] Date: Wed, 10 Oct 2007 14:01:07 -0700 The hack to use a socket and bind it to claim the port was just for demostrating the idea. The correct solution, IMO, is to enhance the core low level 4-tuple allocation services to be more generic (eg: not be

Re: + git-net-fix-qeth_main.patch added to -mm tree

2007-10-11 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 02:03:27 -0700 Subject: git-net: fix qeth_main.c From: Andrew Morton [EMAIL PROTECTED] drivers/s390/net/qeth_main.c: In function 'qeth_hard_header_parse': drivers/s390/net/qeth_main.c:6584: error: 'dev' undeclared (first use in this function)

Re: [PATCH net-2.6.24] remove bogus qeth type check

2007-10-11 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 13:24:58 -0700 Not sure why this crept in with hard-header-ops change. Just kill it. Need to start doing cross-compiles for s390... Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] I commited Andrews's fix for this more than

Re: [PATCH net-2.6.24] remove bogus qeth type check

2007-10-11 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 13:24:58 -0700 [ SOrry, I just noticed this was different... ] Not sure why this crept in with hard-header-ops change. Just kill it. Need to start doing cross-compiles for s390... Signed-off-by: Stephen Hemminger [EMAIL

Re: [2.6 patch] esp_scsi.c: remove __dev{init,exit}

2007-10-11 Thread David Miller
From: Rob Landley [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 17:47:02 -0500 On Thursday 11 October 2007 10:35:20 am Adrian Bunk wrote: Since scsi_esp_{,un}register() are EXPORT_SYMBOL'ed, these functions (and the functions they use) can't be __dev{init,exit}. Based on a bug report by Rob

Re: [PATCH net-2.6.24] remove bogus qeth type check

2007-10-11 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 13:24:58 -0700 Not sure why this crept in with hard-header-ops change. Just kill it. Need to start doing cross-compiles for s390... Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/s390/net/qeth_main.c

Re: [PATCH net-2.6.24] remove bogus qeth type check

2007-10-11 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 17:52:24 -0700 On Thu, 11 Oct 2007 17:24:54 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: With the way you set up headerops in the driver, the only way to preserve the ARPHRD_IEEE802_TR guard, is to keep the test

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 18:08:52 -0700 This will get the batch of changes queued up for the 2.6.24 merge window (although I still have a few more things to merge later, once Dave Miller's networking tree has landed too): Roland are you absolutely sure this

Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 19:21:06 -0700 I'm not sure what you mean. During the 2.6.23 cycle I've been sending any patches that potentially could conflict with the net-2.6 tree to you and Jeff so that you can merge them upstream via your tree. Or do you

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 19:58:04 -0700 (PDT) On Thu, 11 Oct 2007, David Miller wrote: Even if you're confident there won't be merge issues, could you just wait for the net-2.6 stuff to go in first? I pulled the net stuff first, and merged

Re: [GIT PATCH] USB patches for 2.6.23

2007-10-12 Thread David Miller
From: Greg KH [EMAIL PROTECTED] Date: Fri, 12 Oct 2007 15:12:45 -0700 Alan Stern (44): ... USB: mutual exclusion for EHCI init and port resets Greg, if you haven't already, please consider queueing this one up for -stable too. Thanks! - To unsubscribe from this list: send the line

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread David Miller
From: Komuro [EMAIL PROTECTED] Date: Sun, 14 Oct 2007 07:36:58 +0900 Dear David The patch [TCP]: Set initial_ssthresh default to zero in Cubic and BIC. is not very safe. With this patch, ftp-transfer stops in my system. (vsftpd-2.0.5-8) Please revert this patch. No, I will not

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Sat, 13 Oct 2007 15:52:11 -0700 (PDT) From: Komuro [EMAIL PROTECTED] Date: Sun, 14 Oct 2007 07:36:58 +0900 BTW, even my reply didn't reach him, nifty.com reports user unknown for him. I really, truly, suspect therefore that he has other kinds

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread David Miller
From: Komuro [EMAIL PROTECTED] Date: Sun, 14 Oct 2007 10:02:45 +0900 Dear David Actually, tcp_sk(sk)-snd_ssthresh is not initialized, if initial_ssthresh is 0. Komuro, every single email I sent to you bounces with user unknown, I bet it is some spam filter or similar that doesn't like the

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread David Miller
From: Komuro [EMAIL PROTECTED] Date: Sun, 14 Oct 2007 13:28:51 +0900 Dear David Komuro, every single email I sent to you bounces with user unknown, I bet it is some spam filter or similar that doesn't like the fact that I lack reverse DNS. From mailing-list-archive, I can read your

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread David Miller
From: Komuro [EMAIL PROTECTED] Date: Sun, 14 Oct 2007 13:53:56 +0900 Sorry, my mailer's mail-address setting is wrong. Thank you for fixing this :-) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: drivers/net/niu.c: possible array overflows

2007-10-15 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Sun, 14 Oct 2007 19:50:24 +0200 The Coverity checker spotted the following in drivers/net/niu.c: Thanks for the report Adrian, I'll fix it like this: commit 503211a947ab13fb44d920f78f1e19057efc277f Author: David S. Miller [EMAIL PROTECTED] Date: Mon

Re: Don't leak 'listeners' in netlink_kernel_create()

2007-10-15 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sun, 14 Oct 2007 16:30:06 -0600 Jesper Juhl [EMAIL PROTECTED] writes: From: Jesper Juhl [EMAIL PROTECTED] Subject: Don't leak 'listeners' in netlink_kernel_create() The Coverity checker spotted that we'll leak the storage allocated

Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-15 Thread David Miller
From: Noriaki TAKAMIYA [EMAIL PROTECTED] Date: Mon, 15 Oct 2007 12:37:49 +0900 (JST) On Sun, 14 Oct 2007 19:52:12 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: The Coverity checker spotted that we have already oops'ed if dst was NULL. Since dst being NULL doesn't seem to be

Re: WARNING: at net/core/dev.c:2161 net_rx_action()

2007-10-15 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Mon, 15 Oct 2007 13:24:30 +0200 got this warning with Linus' latest -git tree: WARNING: at net/core/dev.c:2161 net_rx_action() [80564db4] net_rx_action+0xce/0x186 [8011ba98] __do_softirq+0x6c/0xcf [8011bb2d] do_softirq+0x32/0x36

Re: [PATCH] ipv4: kernel panic when only one unsecured port available

2007-10-15 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Mon, 15 Oct 2007 12:49:19 -0700 This code has recently been reworked, but from my reading, that divide-by-zero can still occur. And given that the numbers in /proc/sys/net/ipv4/ip_local_port_range are inclusive, the arithmetic in

Re: [Linux-usb-users] OHCI root_port_reset() deadly loop...

2007-10-15 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Tue, 09 Oct 2007 21:35:07 -0700 (PDT) From: David Miller [EMAIL PROTECTED] Date: Tue, 09 Oct 2007 15:00:40 -0700 (PDT) From: David Brownell [EMAIL PROTECTED] Date: Tue, 9 Oct 2007 14:43:54 -0700 Does it resolve the problem you observed

Re: WARNING: at net/core/dev.c:2161 net_rx_action()

2007-10-15 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 00:03:57 +0200 * David Miller [EMAIL PROTECTED] wrote: From: Ingo Molnar [EMAIL PROTECTED] Date: Mon, 15 Oct 2007 13:24:30 +0200 got this warning with Linus' latest -git tree: WARNING: at net/core/dev.c:2161

Re: WARNING: at net/core/dev.c:2161 net_rx_action()

2007-10-15 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 00:07:20 +0200 looking at the dev.c code - can napi_struct-weight be zero legitimately? If yes then the 0 gets passed to the driver and the driver would return 1 - violating the assertion. I touched upon this in another reply. For

Re: [patch] forcedeth: fix the NAPI poll function

2007-10-15 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 00:30:09 +0200 Subject: forcedeth: fix the NAPI poll function From: Ingo Molnar [EMAIL PROTECTED] fix the forcedeth NAPI poll function to not emit this warning: [ 186.635916] WARNING: at net/core/dev.c:2166 net_rx_action() [

Re: [Linux-usb-users] OHCI root_port_reset() deadly loop...

2007-10-15 Thread David Miller
From: David Brownell [EMAIL PROTECTED] Date: Mon, 15 Oct 2007 16:39:10 -0700 Bad news, even with the rwsem after a lot more testing I can still trigger the hang in ohci_hub_control() :-( I think we need to go back to considering the total serialization approach to this problem. We

Re: [Linux-usb-users] OHCI root_port_reset() deadly loop...

2007-10-16 Thread David Miller
From: Alan Stern [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 11:23:58 -0400 (EDT) Unfortunately that simply isn't possible. No matter what you do, the user can always unload ehci-hcd and then load it back in again. Yes we can, by making OHCI and EHCI one module with a top-level dispatch. If

Re: [Linux-usb-users] OHCI root_port_reset() deadly loop...

2007-10-16 Thread David Miller
From: Alan Stern [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 11:23:58 -0400 (EDT) Do you have any idea _where_ in ohci_hub_control the hang still occurs? Is it the same unbounded reset loop? Yes, with post status stuck at 0x111 Does the patch below satisfy both Davids? No, there are no

Re: ioctl32: Unknown cmd

2007-10-16 Thread David Miller
From: Arnd Bergmann [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 21:50:35 +0200 The one point where it is expected to have changed now is when you try to do these ioctls on something that is not a block device. Are you sure that the files you tried them on were created correctly? Many many many

Re: linux-2.6.23-git3: Many sysfs-related warnings in dmesg

2007-10-16 Thread David Miller
From: Greg KH [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 14:37:30 -0700 Kay, are we doing something wrong in userspace when renaming wireless devices such that we can overlap names? It does it for all network devices, I see this ugly message on every single system I have from Fedora foo to RHEL

suspicious ALSA empty commit

2007-10-16 Thread David Miller
While scanning over today's updates in Linus's tree, I noticed the following commit has no changes, and this does not appear to be intentional. Someone should check it out. commit e31b6656a81d6332cdf6af17d38a0573128a6aac Author: Krzysztof Helt [EMAIL PROTECTED] Date: Tue Oct 16 14:54:58 2007

Re: suspicious ALSA empty commit

2007-10-16 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 16:26:43 -0700 (PDT) Git shouldn't even allow such commits to be generated, although you can force it by using the low-level functionality (eg using git commit-tree directly for doing things like importing) That would be useful,

Re: [PATCH 2/3] dma: redefine dma_flags_set/get_*() for sn-ia64

2007-10-16 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 20:29:04 -0700 So we take an `enum data_direction' and then wedge it into a word alongside some extra flags? Can we do something nicer than that? Yes, I discussed this last time around, this type abuse stinks and it's confusing. -

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 09:21:49 +0200 On Wed, Oct 17 2007, FUJITA Tomonori wrote: Commit 2c941a204070ab32d92d40318a3196a7fb994c00 looks incomplete. The helper functions like prepare_sg() need to support sg chaining too. Thanks Tomo, applied. I'll get

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 01:33:25 -0700 (PDT) sg_next() gives you a NULL after the last entry, but tests have been changed to compare against sg_last() which is likely not what we want for those checks. This of course isn't true, ignore me as I'm still

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 10:45:28 +0200 Righto, it's invalid to call sg_next() on the last entry! Unfortunately, that's what the sparc64 code wanted to do, this transformation in the sparc64 sg chaining patch is not equilavent: - struct scatterlist

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: FUJITA Tomonori [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 18:24:01 +0900 On Wed, 17 Oct 2007 11:16:29 +0200 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Oct 17 2007, David Miller wrote: I would suggest that other sg_last() uses be audited for the same bug. Agree. Only libata

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 11:16:29 +0200 On Wed, Oct 17 2007, David Miller wrote: From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 10:45:28 +0200 Righto, it's invalid to call sg_next() on the last entry! Unfortunately, that's what

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 12:58:40 +0200 The problem is that you cannot zero the entire sg entry, because then you'd potentially overwrite the chain pointer. I'd propose just adding a sg_dma_address(sg) = 0; sg_dma_len(sg) = 0; there for

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 13:01:42 +0200 Actually, just clearing AFTER sg_next() would be fine, since we know that is not a link entry. Duh... Yes and I'm running a kernel successfully with this fix. Jens, please also add the following on top of Fujita-san's

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 13:11:46 +0200 On Wed, Oct 17 2007, David Miller wrote: Jens, please also add the following on top of Fujita-san's most recent sparc64 patch and we should be good to go. Awesome, thanks. And sorry for messing up sparc64. Don't

Re: [PATCH 1/4] fix endianness bug in l2cap_sock_listen()

2007-07-29 Thread David Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Fri, 27 Jul 2007 16:41:18 +0200 We loop through psm values, calling __l2cap_get_sock_by_addr(psm, ...) until we get NULL; then we set -psm of our socket to htobs(psm). IOW, we find unused psm value and put it into our socket. So far, so good,

Re: [PATCH 2/4] l2cap: endianness annotations

2007-07-29 Thread David Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Fri, 27 Jul 2007 16:41:21 +0200 no code changes, just documenting existing types Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: Marcel Holtmann [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 3/4] pass (host-endian) cmd length as explicit argument to l2cap_conf_req()

2007-07-29 Thread David Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Fri, 27 Jul 2007 16:41:22 +0200 Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: Marcel Holtmann [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH 4/4] l2cap: don't mangle cmd.len

2007-07-29 Thread David Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Fri, 27 Jul 2007 16:41:26 +0200 Since nobody uses it after we convert it to host-endian, no need to do that at all. At that point l2cap is endian-clean. Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: Marcel Holtmann [EMAIL

Re: TCP SACK issue, hung connection, tcpdump included

2007-07-29 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sun, 29 Jul 2007 11:26:00 +0300 (EEST) Is this reproducable? Can you somehow verify that the packets CLIENT is sending are indeed received by the SERVER...? One possibility is drops due to checksum errors on the receiver, this tends to pop up from

Re: [SPARC32] NULL pointer derefference

2007-07-29 Thread David Miller
From: Mark Fortescue [EMAIL PROTECTED] Date: Mon, 30 Jul 2007 03:18:42 +0100 (BST) Unfortunatly Sparc32 sun4c low level memory management apears to be incompatible with commit b6a2fea39318e43fee84fa7b0b90d68bed92d2ba mm: variable length argument support. For some reason, this commit

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Mon, 30 Jul 2007 12:17:58 -0400 David, thoughts on merging? I'm not We could stick this into your tree or mine. Whether yours or mine, I would like to keep the driver and net-core patches together in the same git tree. No objections and I'll stick

Re: [PATCH] IPv6: ipv6_addr_type() doesn't know about RFC4193 addresses

2007-07-30 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 13:34:52 -0500 (CDT) In article [EMAIL PROTECTED] (at Wed, 25 Jul 2007 19:49:09 -0400), Dave Johnson [EMAIL PROTECTED] says: ipv6_addr_type() doesn't check for 'Unique Local IPv6 Unicast Addresses' (RFC4193) and

Re: [PATCH] SCTP: IPv4 mapped addr not returned in SCTPv6 accept()

2007-07-30 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Thu, 26 Jul 2007 16:49:40 -0400 Feel free to clean it up and submit both patches. Ping? Somebody? - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [2.6 patch] make pktgen.c:get_ipsec_sa() static and non-inline

2007-07-30 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Sun, 29 Jul 2007 16:58:40 +0200 Non-static inline code usually doesn't makes sense. In this case making is static and non-inline is the correct solution. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied, thanks Adrian. - To unsubscribe from

Re: [2.6 patch] make nf_ct_ipv6_skip_exthdr() static

2007-07-30 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Sun, 29 Jul 2007 16:58:46 +0200 nf_ct_ipv6_skip_exthdr() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

<    8   9   10   11   12   13   14   15   16   17   >