Re: [patch 0/7] [RFC] SLUB: Improve allocpercpu to reduce per cpu access overhead

2007-11-01 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Thu, 01 Nov 2007 00:01:18 -0700 (PDT) From: Christoph Lameter [EMAIL PROTECTED] Date: Wed, 31 Oct 2007 21:16:59 -0700 (PDT) Index: linux-2.6/mm/allocpercpu.c === --- linux-2.6.orig

Re: [Linux-usb-users] OHCI root_port_reset() deadly loop...

2007-10-17 Thread David Miller
From: Alan Stern [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 11:51:57 -0400 (EDT) + break; + } + if (limit_1 0) { + ohci_warn(ohci, Root port outer-loop reset timeout, + now[%04x] reset_done[%04x]\n, + now,

Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

2007-10-17 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 17:44:38 -0700 On Wed, 17 Oct 2007 17:14:39 -0700 Shannon Nelson [EMAIL PROTECTED] wrote: + tx-callback = (void *)ioat_dma_test_callback; and when I remove this cast I get drivers/dma/ioat_dma.c: In function

Re: [bug] ata subsystem related crash with latest -git

2007-10-17 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 18:07:19 -0700 (PDT) sg_next() - as it stands now - never actually looks at the SG that its argument points to: it explicitly *only* looks at the next one. That's the bug. If sg_next() looked at the actual *current* sg entry, we

Re: [bug] ata subsystem related crash with latest -git

2007-10-17 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 18:36:34 -0700 (PDT) Although I also wonder whether we want one global per-arch ARCH_HAS_SG_CHAIN It's there because the DMA mapping support code for a platform has to be converted to handle these chains and audited to make sure

Re: [PATCH] pfkey: sending an SADB_GET responds with an SADB_GET

2007-10-17 Thread David Miller
From: Charles Hardin [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 14:36:10 -0700 Kernel needs to respond to an SADB_GET with the same message type to conform to the RFC 2367 Section 3.1.5 I can't apply this: 1) We need you to provide an appropriate Signed-off-by: line in the changelog of your

Re: [PATCH] Videopix Frame Grabber: Convert device_lock_sem to mutex

2007-10-17 Thread David Miller
From: Matthias Kaehlcke [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 19:18:52 +0200 Videopix Frame Grabber: Convert the semaphore device_lock_sem to the mutex API Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe

Re: Virtual Netdevice

2007-10-17 Thread David Miller
From: rajashok [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 22:10:43 -0700 (PDT) we are trying to to integrate our ipsec onto linux 2.6 kernel Why not use the already existing 2.6.x kernel IPSEC stack? It works quite well. And for this reason, it is unlikely you will get much help on these mailing

Re: [PATCH/RFA] sch_generic: fix carrier-on bug?

2007-10-18 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 16 Oct 2007 17:55:55 -0400 While looking at a net driver with the following construct, if (!netif_carrier_ok(dev)) netif_carrier_on(dev); it stuck me that the netif_carrier_ok() check was redundant, since

Re: [RFC] remove netpoll receive code

2007-10-18 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 13:21:31 -0700 I propose that we take out all the whole netpoll rx path. If/when kgdb gets submitted a better and alternative receive path can be added. I would like to kill the RX side handling of netpoll too, but I don't think

Re: [patch] PCI: disable MSI on more ATI NorthBridges

2007-10-18 Thread David Miller
From: Shane Huang [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 17:14:36 +0800 More ATI North Bridges like RS780 can't do MSI like its predecessors in linux. Disable MSIs on them. Signed-off-by: Shane Huang [EMAIL PROTECTED] Can we get some detail as to why these north bridges have to have MSI

Re: [patch] PCI: disable MSI on more ATI NorthBridges

2007-10-18 Thread David Miller
From: Shane Huang [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 18:37:59 +0800 Hi Miller: Thank you for your response. The reason why MSIs of these northbridges do not work is still under further debug, we are NOT able to tell its hardware issue or software issue at this time. But enablement

Re: ip_frag_reasm() can return uninitialized variable

2007-10-18 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 12:52:03 +0200 Since commit 1706d58763c36133d7fce6cc78b1444fd40db28c ip_frag_reasm() can return the value of an uninitialized variable: I have a fix for this in my net-2.6 tree, thanks Adrian. - To unsubscribe from this list: send the

Re: [bug] ata subsystem related crash with latest -git

2007-10-18 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 10:21:45 +0200 I like it. Basically the only real change is using bit 2 as a termination point, so we avoid going beyond the end of the sgtable. Here's a starting point, it actually booted for me in the first go (boggle). Only x86 so

Re: [bug] block subsystem related crash with latest -git

2007-10-18 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 12:55:17 +0200 Things have progressed a lot since, see my recent posting based on Davem's proposal. Will post another patch soonish, that is also tested. One core issue here is that we need to decide whether this thing to be iterated

Re: [bug] ata subsystem related crash with latest -git

2007-10-18 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 13:57:02 +0200 Thanks a lot, Dave! The patch is a monster right now, I'll work on splitting it into a 3-step process. Any arch help is greatly appreciated. I have some other bits that my compile hit, such as some things in the crypto

Re: [bug] ata subsystem related crash with latest -git

2007-10-18 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 14:15:47 +0200 On Thu, Oct 18 2007, Jens Axboe wrote: On Thu, Oct 18 2007, David Miller wrote: From: Jens Axboe [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 13:57:02 +0200 Thanks a lot, Dave! The patch is a monster right now

Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()

2007-10-18 Thread David Miller
From: Olof Johansson [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 21:29:47 -0500 So, looks like rcu_dereference() returned NULL. I don't know the filter code at all, but it seems like it might be a valid case? sk_detach_filter() seems to handle a NULL sk_filter, at least. So, this needs

Re: broken PCNET32 in 2.6.24 requires experimental PCNET32_NAPI?

2007-10-18 Thread David Miller
From: Erez Zadok [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 00:33:09 -0400 Call Trace: [c0102bc2] show_trace_log_lvl+0x1a/0x2f [c0102c72] show_stack_log_lvl+0x9b/0xa3 [c0102e2e] show_registers+0x1b4/0x285 [c0102fff] die+0x100/0x21d [c010a72f] do_page_fault+0x434/0x515 [c026a40a]

Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()

2007-10-19 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 11:37:02 +0400 David Miller wrote: From: Olof Johansson [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 21:29:47 -0500 So, looks like rcu_dereference() returned NULL. I don't know the filter code at all, but it seems like

Re: [2.6.23] tasks stuck in running state?

2007-10-19 Thread David Miller
From: Chuck Ebbert [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 18:18:08 -0400 On 10/19/2007 06:03 PM, Jeff Garzik wrote: [EMAIL PROTECTED] misc-2.6]$ strace -p8484 Process 8484 attached - interrupt to quit [sits there, chewing up CPU grepping a 47-line header file] And sysrq-p is pretty

Re: [NET]: Fix possible dev_deactivate race condition

2007-10-18 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 13:36:24 +0800 [NET]: Fix possible dev_deactivate race condition The function dev_deactivate is supposed to only return when all outstanding transmissions have completed. Unfortunately it is possible for store operations in the

Re: [PATCH] Make advansys depend on CONFIG_VIRT_TO_BUS

2007-10-18 Thread David Miller
From: Stephen Rothwell [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 15:04:31 +1000 At least for now. Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] Acked-by: David S. Miller [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [2.6.23] tasks stuck in running state?

2007-10-21 Thread David Miller
From: Chuck Ebbert [EMAIL PROTECTED] Date: Sun, 21 Oct 2007 11:59:14 -0400 IIRC -mm had something like this but it was buggy because we were sending IPIs to each processor asking them to print their state. What's buggy about this? :-) That's exactly how it work(ed) on sparc64. - To

Re: atm: panic when loading clip 2nd time

2007-10-21 Thread David Miller
From: Randy Dunlap [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 18:02:36 -0700 From: Randy Dunlap [EMAIL PROTECTED] net/atm/clip.c crashes the kernel if it (module) is loaded, removed, and then loaded again. Its exit call to neigh_table_clear() should destroy the cache after freeing it.

[PATCH]: Fix IDE host_flags regression.

2007-10-22 Thread David Miller
Bart, please test your changes. Thank you. [IDE]: Expand hwif-host_flags so that it fits new flags. This fixes regressions added by: 238e4f142c33bb34440cc64029dde7b9fbc4e65f Signed-off-by: David S. Miller [EMAIL PROTECTED] diff --git a/include/linux/ide.h b/include/linux/ide.h index

Re: [patch] PCI: disable MSI on more ATI NorthBridges

2007-10-22 Thread David Miller
From: Krzysztof Halasa [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 01:40:18 +0200 Jeff Garzik [EMAIL PROTECTED] writes: In general it is documented that INTX_DISABLE should apply only to INTx# so devices that disable MSI based on that bit are out of spec. The wording is: 10: This bit

Re: [PATCH 09/10] Change table chaining layout

2007-10-22 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Mon, 22 Oct 2007 14:47:38 -0700 (PDT) On Mon, 22 Oct 2007, Alan Cox wrote: Still doesn't answer the rather more important question - why not just stick a NULL on the end instead of all the nutty hacks ? You still do need one bit for the

Re: [patch] PCI: disable MSI on more ATI NorthBridges

2007-10-22 Thread David Miller
From: Daniel Barkalow [EMAIL PROTECTED] Date: Mon, 22 Oct 2007 17:31:04 -0400 (EDT) It's likewise documented (although maybe arguable in wording) that the device shouldn't send legacy interrupts if MSI is in use, regardless of INTX_DISABLE, but this also happens in the field. I think that

Re: [PATCH 1/2] irq_flags_t: intro and core annotations

2007-10-22 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Mon, 22 Oct 2007 16:47:16 -0400 Let me add to the chorus of voices: I continually see two cases where real bugs crop up: 1) hacker uses spin_lock_irq() in incorrect context (where it is not safe to do a blind enable/disable) 2) hacker uses

Re: Add ACCUSYS RAID driver for Linux i386/x86-64

2007-10-22 Thread David Miller
From: Peter Chan [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 09:45:48 +0800 Add linux-scsi and linux-kernel in mail group. Please do not post your driver as a RAR attachment, not only are most Linux folks not familiar with this archive format, it is also an attachment type rejected by just about

IDE crash...

2007-10-23 Thread David Miller
I'm debugging a blk_rq_map_sg() crash that i'm getting on sparc64 as root is mounted over IDE. I think I know what is happening now. The IDE sg table is allocated and initialized like this in drivers/ide/ide-probe.c: x = kmalloc(sizeof(struct scatterlist) * nents, GFP_XXX);

Re: IDE crash...

2007-10-23 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 09:09:33 +0200 Eh this wont work, it's the wrong entry... Here's a temporary work-around. diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c index c89f0d3..108202b 100644 --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c

Re: IDE crash...

2007-10-23 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 09:23:59 +0200 On Tue, Oct 23 2007, David Miller wrote: From: Jens Axboe [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 09:09:33 +0200 Eh this wont work, it's the wrong entry... Here's a temporary work-around. diff --git

[PATCH]: Genericizing iova.[ch]

2007-10-23 Thread David Miller
I would like to potentially move the sparc64 IOMMU code over to using the nice new drivers/pci/iova.[ch] code for free area management.. In order to do that we have to detach the IOMMU page size assumptions which only really need to exist in the intel-iommu.[ch] code. This patch attempts to

Re: [patch] PCI: disable MSI on more ATI NorthBridges

2007-10-23 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 06:01:17 -0400 David Miller wrote: My suggestion is: ... Sounds good to me also. Ok, it seems I've sort-of self-nominated myself to implement this so I'll try to work on it tomorrow :-) - To unsubscribe from this list: send the line

Re: IDE crash...

2007-10-23 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 12:57:11 +0200 On Tue, Oct 23 2007, FUJITA Tomonori wrote: BTW, we avoid calling sg_init_table() for every I/O request due to Jens' trick. And Jens will remove the code to clear sg_dma_len/addr in blk_rq_map_sg(). So sparc64 iommu

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 16:40:01 -0400 Sorry, I disagree. Just as with e100, if there is a clear way the user can recover their setup -- and Adam says his was effective -- I don't see why we should be denying users the ability to use their own hardware.

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread David Miller
From: Kok, Auke [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 14:01:21 -0700 We help everyone out, and if you merge this patch you will prevent users from getting to us for support in the first place. If using the bad eeprom has to be explicitly enabled by the user, your argument holds no water.

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread David Miller
From: Dave Jones [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 17:20:26 -0400 Indeed. This is a common enough problem that not including it causes more pain than its worth. I have two affected boxes myself that I actually thought the hardware was dead before I tried ajax's patch. People aren't

Re: [GIT PATCH] final SCSI pieces for the merge window

2007-10-23 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 18:06:51 -0400 James Bottomley wrote: On Tue, 2007-10-23 at 17:09 -0400, Jeff Garzik wrote: James Bottomley wrote: This should be the final SCSI updates; it's mainly just a few accessor completion updates and two driver merges

Re: [PATCH 11/12] NET: fix subqueue bugs

2007-10-23 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 18:36:46 -0400 (EDT) net/sched/sch_prio.c: In function $,1rx(Bprio_dequeue$,1ry(B: net/sched/sch_prio.c:139: warning: passing argument 2 of $,1rx(Bnetif_subqueue_stopped$,1ry(B makes pointer from integer without a cast

[SPARC64]: SG build fix.

2007-10-23 Thread David Miller
Jens could you queue up this obvious typo build fix for me? Thanks! Signed-off-by: David S. Miller [EMAIL PROTECTED] diff --git a/arch/sparc64/kernel/iommu_common.c b/arch/sparc64/kernel/iommu_common.c index b70324e..efd5dff 100644 --- a/arch/sparc64/kernel/iommu_common.c +++

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-10-23 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 21:03:36 -0400 I'm wondering if there is a way to avoid adding if (!is_valid_ether_addr(dev-dev_addr)) return -EINVAL; to every ethernet driver's -open() hook. The first idea I get is: 1) Create

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-10-23 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 22:20:30 -0400 David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 21:03:36 -0400 I'm wondering if there is a way to avoid adding if (!is_valid_ether_addr(dev-dev_addr)) return

Re: [patch] PCI: disable MSI on more ATI NorthBridges

2007-10-23 Thread David Miller
From: Shane Huang [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 18:56:03 +0800 Also I wonder why the USB MSI patch is not added into kernel at last? Will it lead to other bugs? Probably someone just needs to be more vocal and active in pushing it to the USB subsystem maintainer(s). I've even had

Re: [patch] PCI: disable MSI on more ATI NorthBridges

2007-10-23 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 03:06:22 -0700 (PDT) Ok, it seems I've sort-of self-nominated myself to implement this so I'll try to work on it tomorrow :-) I have a working implementation, fully tested on a machine with Tigon3 ethernet chips that have the quirk

[PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks.

2007-10-23 Thread David Miller
The forthcoming patches are also available from: kernel.org:/pub/scm/linux/kernel/git/davem/msiquirk-2.6.git and clean up the handling of the common quirk wherein setting INTX_DISABLE will mistakedly disable MSI generation for some devices. For devices without that problem, we want to

[PATCH 1/4]: Revert PCI: disable MSI by default on systems with Serverworks HT1000 chips

2007-10-23 Thread David Miller
This reverts commit e3008dedff4bdc96a5f67224cd3d8d12237082a0. The real bug was an INTX issue in the tg3 ethernet chip, and cured by commit c129d962a66c76964954a98b38586ada82cf9381 Signed-off-by: David S. Miller [EMAIL PROTECTED] --- drivers/pci/quirks.c|1 - include/linux/pci_ids.h |

[PATCH 2/4]: [PCI]: Add MSI quirk for ServerWorks HT1000 PCIX bridge.

2007-10-23 Thread David Miller
This is the fix for the following problem: https://bugzilla.redhat.com/show_bug.cgi?id=227657 The bnx2 device 5706 complains about MSI not working behind a ServerWorks HT1000 PCIX bridge. An earlier commit to fix the problem: e3008dedff4bdc96a5f67224cd3d8d12237082a0: PCI: disable MSI by

[PATCH 3/4]: [PCI]: Add quirk for devices which disable MSI when INTX_DISABLE is set.

2007-10-23 Thread David Miller
A reasonably common problem with some devices is that they will disable MSI generation when the INTX_DISABLE bit is set in the PCI_COMMAND register. Quirk this explicitly, guarding the pci_intx() calls in msi.c with this quirk indication. The first entries for this quirk are for 5714 and 5780

[PATCH 4/4]: [PCI]: Add MSI INTX_DISABLE quirks for ATI SB700/800 SATA and IXP SB400 USB

2007-10-23 Thread David Miller
Signed-off-by: David S. Miller [EMAIL PROTECTED] --- drivers/pci/quirks.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 591eaa4..5795a3d 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c

Re: [PATCH] Unlock before return in p9_mux_poll_start

2007-10-23 Thread David Miller
From: Roel Kluin [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 03:16:41 +0200 commit 9f822afc65cc094c905901f9d92bf25042f9ed22 Author: Roel Kluin [EMAIL PROTECTED] Date: Tue Oct 23 03:15:55 2007 +0200 Unlock before return in p9_mux_poll_start Signed-off-by: Roel Kluin [EMAIL

Re: [PATCH 4/5] NET: Make ts_recent_stamp unsigned

2007-10-23 Thread David Miller
From: Chuck Lever [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 11:44:28 -0400 The get_seconds() function returns an unsigned long. To prevent incorrect comparison results between values saved in ts_recent_stamp and later invocations of get_seconds(), change the type of ts_recent_stamp to match

Re: [PATCH 3/5] NET: Treat the sign of the result of skb_headroom() consistently

2007-10-23 Thread David Miller
From: Chuck Lever [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 11:44:23 -0400 In some places, the result of skb_headroom() is compared to an unsigned integer, and in others, the result is compared to a signed integer. Make the comparisons consistent and correct. Signed-off-by: Chuck Lever

Re: [PATCH 5/5] NET: Remove unneeded implicit type case when calling tcp_minshall_update()

2007-10-23 Thread David Miller
From: Chuck Lever [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 11:44:33 -0400 The tcp_minshall_update() function is called in exactly one place, and is passed an unsigned integer for the mss_len argument. Make the sign of the argument match the sign of the passed variable in order to eliminate an

Re: [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks.

2007-10-23 Thread David Miller
From: Daniel Barkalow [EMAIL PROTECTED] Date: Wed, 24 Oct 2007 00:58:45 -0400 (EDT) I'm not sure all of the pci_intx() calls in msi.c should be skipped when the quirk applies; I think some of them might be there so that the legacy interrupt won't be delivered while MSI is turned off (since

Re: [PATCH 3/4]: [PCI]: Add quirk for devices which disable MSI when INTX_DISABLE is set.

2007-10-23 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 21:59:39 -0700 David Miller wrote: +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM, + PCI_DEVICE_ID_TIGON3_5780, + quirk_msi_intx_disable_bug); +DECLARE_PCI_FIXUP_FINAL

Re: [PATCH 3/4]: [PCI]: Add quirk for devices which disable MSI when INTX_DISABLE is set.

2007-10-23 Thread David Miller
From: Michael Ellerman [EMAIL PROTECTED] Date: Wed, 24 Oct 2007 15:30:21 +1000 That looks like 6 hunks doing exactly the same thing? What about creating a pci_intx_quirked() (or something) that checks the flag and then does/or does not call pci_intx(). Good idea, I'll add that to the patch. -

[SPARC64]: More SG build fixes

2007-10-23 Thread David Miller
diff --git a/arch/sparc64/kernel/ldc.c b/arch/sparc64/kernel/ldc.c index c8313cb..217478a 100644 --- a/arch/sparc64/kernel/ldc.c +++ b/arch/sparc64/kernel/ldc.c @@ -2121,7 +2121,7 @@ int ldc_map_sg(struct ldc_channel *lp, state.nc = 0; for (i = 0; i num_sg; i++) -

Re: [ANNOUNCE] Btrfs v0.12 released

2008-02-10 Thread David Miller
From: Chris Mason [EMAIL PROTECTED] Date: Wed, 6 Feb 2008 12:00:13 -0500 So, here's v0.12. I couldn't even make a filesystem on sparc64 without the following patch. The first problem is that these SETGET macros lose typing information, and therefore can't see the 'packed' attribute and

Re: Netfilter fixes to 2.6.24-git

2008-02-10 Thread David Miller
From: Jan Engelhardt [EMAIL PROTECTED] Date: Sun, 10 Feb 2008 22:02:35 +0100 (CET) I have been unable to reach the netfilter and net maintainers the past week regarding inclusion of patches, but most importantly a group of fixes at [0]-[3]. I am kind of at a loss here but to turn up the

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-11 Thread David Miller
From: Greg KH [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 21:53:12 -0800 Where do you fix this up at? I can send a patch for the IB tree, but Roland can't put it in his tree, and I can't put it in my tree, it needs to go _after_ both of our trees. Totally agreed. The fact is there are

Re: [git pull for -mm] CPU isolation extensions (updated2)

2008-02-11 Thread David Miller
From: Nick Piggin [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 17:41:21 +1100 stop machine is used for more than just module loading and unloading. I don't think you can just disable it. Right, in particular it is used for CPU hotplug. -- To unsubscribe from this list: send the line unsubscribe

Re: [ANNOUNCE] Btrfs v0.12 released

2008-02-11 Thread David Miller
From: Chris Mason [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 08:42:20 -0500 The kernel is actually worse, because the set/get macros are more complex. Some live in ctree.h like in the progs, but the nasty ones live in struct-funcs.c This is really problematic, because you've got these things

Re: [git patches] net driver updates

2008-02-11 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 12:05:16 -0500 Mostly fixes, a few cleanups (generally assisting fixes), and an exception for PS3 wireless because it had been posted, reviewed and acked for a while, just not committed. Please pull from 'upstream-davem' branch of

Re: more iommu sg merging fallout

2008-02-11 Thread David Miller
From: FUJITA Tomonori [EMAIL PROTECTED] Date: Thu, 07 Feb 2008 10:38:01 +0900 Great, thanks! SPARC IOMMUs use bitmap for the free area management like POWER IOMMUs so it could use lib/iommu-helper as POWER does. Please look at Linus's current tree, I believe I have things in a working state,

BTRFS partition usage...

2008-02-11 Thread David Miller
Filesystems like ext2 put their superblock 1 block into the partition in order to avoid overwriting disk labels and other uglies. UFS does this too, as do several others. One of the few exceptions I've been able to find is XFS. This is a real issue on sparc where the default sun disk labels

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-11 Thread David Miller
From: Arjan van de Ven [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 21:17:51 -0800 this is why you need specific trees for just the API change API trees don't work, just like other changes they will have interdependencies on things like fixups, cleanups, etc. This is why, with the networking,

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-11 Thread David Miller
From: Theodore Tso [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 00:11:36 -0500 __deprecate the old one, Deprecate is garbage, shit hangs around in the tree forever and people just turn off the warnings. Clean sweeps work much better, albeit with some merge pain, we'll cope. -- To unsubscribe from

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread David Miller
From: Paul E. McKenney [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 17:27:41 -0800 On Mon, Feb 11, 2008 at 04:59:54PM -0800, Stephen Hemminger wrote: Eliminate warnings when rcu_assign_pointer is used with unsigned long. It is reasonable to use RCU with non-pointer values so allow it for general

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 16:59:54 -0800 linux-kernel added to CC:, any change to generic kernel infrastructure should be posted there Eliminate warnings when rcu_assign_pointer is used with unsigned long. It is reasonable to use RCU with non-pointer

Re: [PATCH]intel-iommu batched iotlb flushes

2008-02-12 Thread David Miller
From: Muli Ben-Yehuda [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 10:52:56 +0200 The streaming DMA-API was designed to conserve IOMMU mappings for machines where IOMMU mappings are a scarce resource, and is a poor fit for a modern IOMMU such as VT-d with a 64-bit IO address space (or even an

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 23:21:39 -0800 (PST) Filesystems like ext2 put their superblock 1 block into the partition in order to avoid overwriting disk labels and other uglies. UFS does this too, as do several others. One of the few exceptions I've been

CRC32C big endian bugs...

2008-02-12 Thread David Miller
The CRC32C implementation in the btrfs progs is different from the one in the kernel, so obviously nothing can possibly work on big-endian. This is getting less and less fun by the minute, I simply wanted to test btrfs on Niagara :-/ Here is a patch to fix that: ---

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Chris Mason [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 08:49:34 -0500 So, if Btrfs starts zeroing at 1k, will that be acceptable for you? Sure. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

BTRFS only works with PAGE_SIZE = 4K

2008-02-12 Thread David Miller
From: Chris Mason [EMAIL PROTECTED] Date: Wed, 6 Feb 2008 12:00:13 -0500 So, here's v0.12. Any page size larger than 4K will not work with btrfs. All of the extent stuff assumes that PAGE_SIZE = sectorsize. I confirmed this by forcing mkfs.btrfs to use an 8K sectorsize on sparc64 and I was

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
in the history? It also totally screws the commit statistics, wiping me and John and the committers we have preserved out, replacing everybody's committer with David Miller. I am well aware of this downside, sorry. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH]intel-iommu batched iotlb flushes

2008-02-12 Thread David Miller
From: mark gross [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 07:54:48 -0800 Something could be done: we could enable drivers to have DMA-pools they manage that get mapped and are re-used. I would rather the DMA-pools be tied to PID's that way any bad behavior would be limited to the address

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Jan Engelhardt [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 16:04:52 +0100 (CET) I still don't like the idea of btrfs trying to be smarter than a user who can partition up his system according to (a) his likes (b) system or hardware requirements or recommendations to align the

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 10:48:38 -0800 (PST) On Tue, 12 Feb 2008, James Bottomley wrote: Yes ... I don't do that ... Like I said, I only rebase for an actual conflict. And this is how things should work. And if conflicts happen every day, what

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Greg KH [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 11:15:53 -0800 On Tue, Feb 12, 2008 at 10:26:53AM -0800, Linus Torvalds wrote: We absolutely MUST NOT have the mindset that cross-subsystem conflicts happen all the time. They usually don't, by virtue of our current development

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 10:59:00 -0800 (PST) That sure as hell would put the pain on API changes solidly where it belongs. If a person does a driver API change and does all the work to sweep the entire tree updating all the drivers, doesn't it penalize

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 10:26:53 -0800 (PST) We absolutely MUST NOT have the mindset that cross-subsystem conflicts happen all the time. Perhaps not, but self-conflicts are the bigger issue for the networking. If I (or Jeff or John) push a bug fix to

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: James Bottomley [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 12:24:42 -0600 Hm ... I think net is a counter example to this. Rebases certainly work for them. The issue, I thought, was around the policy of rebasing and how often. I see the question as being one of who creates the

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 16:44:47 -0800 (PST) gitk --merge ... This is something where I actually think git could and should do better: git has the capability to act as more of a quilt replacement, but because it wasn't part of the original

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 16:37:42 -0800 Well there's a case in point. rcupdate.h is not a part of networking, and it is random tree-wandering like this which causes me problems and which will cause Stephen problems. Now, I don't know which tree owns

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Jan Engelhardt [EMAIL PROTECTED] Date: Wed, 13 Feb 2008 00:42:56 +0100 (CET) On Feb 12 2008 15:38, David Miller wrote: I still don't like the idea of btrfs trying to be smarter than a user who can partition up his system according to (a) his likes (b) system or hardware

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 11:36:24 -0500 Rebasing is low impact only if you don't have git downstream people. Otherwise, you're just treating it as a useful quilt clone, really. Understood. One of the key operations that I'm interested in is removing things

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Jan Engelhardt [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 15:21:52 +0100 (CET) For sparc you could have something like startlbaendlba type sda10 2 1 Boot sda22 58 3 Whole disk

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 17:41:19 -0800 (PST) Trust me, you don't know how good you have it. I know, preserving history is valuable. I'll take up the various suggestions and try working a little differently this time around. We'll see how well it works. --

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 17:31:10 -0800 (PST) You don't see the problems as much, because you merge probably only about a tenth of the volume I merge, and you can keep track of the subsystem more. Good point. Now how do I remove a bogus commit for a tree

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 18:06:13 -0800 So perhaps a better workflow would be keep the linux-next trees all messy, and then each developer can consolidate, rebase, join and drop things prior to sending their individual trees to Linus. We could do that, but

Re: [PATCH 4/4] hlist_for_each_entry_continue simplification

2008-02-12 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 16:50:46 -0800 All the users of hlist_for_each_entry_continue had to intialize pos before use; change API so pos is a pure temporary variable which matches the usage of other _for_each_entry routines. Signed-off-by:

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 16:53:50 -0800 (PST) The fact is, that outlying code is where we have all the bulk of the code, and it's also where we have all those developers who aren't on the inside track. So we should help the outliers, not the core code.

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 12:07:07 -0800 (PST) On Tue, 12 Feb 2008, J. Bruce Fields wrote: But the author is still preserved, right? Why do you need the committer name to be preserved? (I'm not denying that there could be reasons, I'm just

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 16:49:46 -0800 (PST) Btw, on that note: if some quilt user can send an annotated history file of their quilt usage, it's something that git really can do, and I'll see if I can merge (or rather, coax Junio to merge) the relevant

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 16:47:26 -0800 My usual way of fixing these things when they pop up is to just move the offending addition to some random position other than end-of-list. I must have done this hundreds of times and as yet I don't think anyone has

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Chris Mason [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 09:35:20 -0500 From my point of view, 0 is a bad idea because it is very likely to conflict with other things. Starting at 0 is a bad idea because otherwise you'll waste significant chunks of your disk on Sparc because of reasons I've

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Jan Engelhardt [EMAIL PROTECTED] Date: Tue, 12 Feb 2008 15:00:20 +0100 (CET) Something looks wrong here. Why would btrfs need to zero at all? So that existing superblocks on the partition won't be interpreted as correct by other filesystems. It's a safety measure many mkfs programs use.

<    3   4   5   6   7   8   9   10   11   12   >