Re: [Xen-devel] [PATCH v2 2/4] xen/xenbus: Update xenbus event channel on resume

2015-05-01 Thread David Vrabel
On 29/04/15 22:10, Boris Ostrovsky wrote: After a resume the hypervisor/tools may change xenbus event channel number. We should re-query it. Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [Xen-devel] [PATCH v2 1/4] xen/events: Clear cpu_evtchn_mask before resuming

2015-05-01 Thread David Vrabel
On 29/04/15 22:10, Boris Ostrovsky wrote: When a guest is resumed, the hypervisor may change event channel assignments. If this happens and the guest uses 2-level events it is possible for the interrupt to be claimed by wrong VCPU since cpu_evtchn_mask bits may be stale. This can happen even

Re: [Xen-devel] [PATCH 1/4] xen/events: Clear cpu_evtchn_mask before resuming

2015-04-29 Thread David Vrabel
On 29/04/15 17:54, Boris Ostrovsky wrote: > On 04/29/2015 12:32 PM, David Vrabel wrote: >> On 28/04/15 19:29, Boris Ostrovsky wrote: >>> On 04/28/2015 12:28 PM, David Vrabel wrote: >>>> >>>> From the commit log the evtchn_2l_resume() fucntion t

Re: [Xen-devel] [PATCH 1/4] xen/events: Clear cpu_evtchn_mask before resuming

2015-04-29 Thread David Vrabel
On 28/04/15 19:29, Boris Ostrovsky wrote: > On 04/28/2015 12:28 PM, David Vrabel wrote: >> On 28/04/15 16:52, Boris Ostrovsky wrote: >>> When a guest is resumed, the hypervisor may change event channel >>> assignments. If this happens and the guest uses 2-leve

Re: [Xen-devel] [PATCH v3] xen: Suspend ticks on all CPUs during suspend

2015-04-29 Thread David Vrabel
On 28/04/15 23:46, Boris Ostrovsky wrote: > Commit 77e32c89a711 ("clockevents: Manage device's state separately for > the core") decouples clockevent device's modes from states. With this > change when a Xen guest tries to resume, it won't be calling its > set_mode op which needs to be done on

Re: [Xen-devel] [PATCH v3] xen: Suspend ticks on all CPUs during suspend

2015-04-29 Thread David Vrabel
On 28/04/15 23:46, Boris Ostrovsky wrote: Commit 77e32c89a711 (clockevents: Manage device's state separately for the core) decouples clockevent device's modes from states. With this change when a Xen guest tries to resume, it won't be calling its set_mode op which needs to be done on each VCPU

Re: [Xen-devel] [PATCH 1/4] xen/events: Clear cpu_evtchn_mask before resuming

2015-04-29 Thread David Vrabel
On 29/04/15 17:54, Boris Ostrovsky wrote: On 04/29/2015 12:32 PM, David Vrabel wrote: On 28/04/15 19:29, Boris Ostrovsky wrote: On 04/28/2015 12:28 PM, David Vrabel wrote: From the commit log the evtchn_2l_resume() fucntion that's added sounds like it fixes the problem on its own

Re: [Xen-devel] [PATCH 1/4] xen/events: Clear cpu_evtchn_mask before resuming

2015-04-29 Thread David Vrabel
On 28/04/15 19:29, Boris Ostrovsky wrote: On 04/28/2015 12:28 PM, David Vrabel wrote: On 28/04/15 16:52, Boris Ostrovsky wrote: When a guest is resumed, the hypervisor may change event channel assignments. If this happens and the guest uses 2-level events it is possible for the interrupt

Re: [Xen-devel] [PATCH 2/4] xen/xenbus: Update xenbus event channel on resume

2015-04-28 Thread David Vrabel
On 28/04/15 16:52, Boris Ostrovsky wrote: > After a resume the hypervisor/tools may change xenbus event > channel number. We should re-query it. [...] > @@ -793,6 +818,9 @@ static int __init xenbus_init(void) > goto out_error; > } > > + if (!xen_initial_domain()) > +

Re: [Xen-devel] [PATCH 1/4] xen/events: Clear cpu_evtchn_mask before resuming

2015-04-28 Thread David Vrabel
On 28/04/15 16:52, Boris Ostrovsky wrote: > When a guest is resumed, the hypervisor may change event channel > assignments. If this happens and the guest uses 2-level events it > is possible for the interrupt to be claimed by wrong VCPU since > cpu_evtchn_mask bits may be stale. This can happen

Re: [Xen-devel] [PATCH 4/4] xen/events: Set irq_info->evtchn before binding the channel to CPU in __startup_pirq()

2015-04-28 Thread David Vrabel
On 28/04/15 16:52, Boris Ostrovsky wrote: > .. because bind_evtchn_to_cpu(evtchn, cpu) will map evtchn to > 'info' and pass 'info' down to xen_evtchn_port_bind_to_cpu(). Reviewed-by: David Vrabel David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

Re: [Xen-devel] [PATCH 3/4] xen/console: Update console event channel on resume

2015-04-28 Thread David Vrabel
On 28/04/15 16:52, Boris Ostrovsky wrote: > After a resume the hypervisor/tools may change console event > channel number. We should re-query it. Reviewed-by: David Vrabel David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [Xen-devel] [PATCH 4/4] xen/events: Set irq_info-evtchn before binding the channel to CPU in __startup_pirq()

2015-04-28 Thread David Vrabel
On 28/04/15 16:52, Boris Ostrovsky wrote: .. because bind_evtchn_to_cpu(evtchn, cpu) will map evtchn to 'info' and pass 'info' down to xen_evtchn_port_bind_to_cpu(). Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [Xen-devel] [PATCH 3/4] xen/console: Update console event channel on resume

2015-04-28 Thread David Vrabel
On 28/04/15 16:52, Boris Ostrovsky wrote: After a resume the hypervisor/tools may change console event channel number. We should re-query it. Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [Xen-devel] [PATCH 1/4] xen/events: Clear cpu_evtchn_mask before resuming

2015-04-28 Thread David Vrabel
On 28/04/15 16:52, Boris Ostrovsky wrote: When a guest is resumed, the hypervisor may change event channel assignments. If this happens and the guest uses 2-level events it is possible for the interrupt to be claimed by wrong VCPU since cpu_evtchn_mask bits may be stale. This can happen even

Re: [Xen-devel] [PATCH 2/4] xen/xenbus: Update xenbus event channel on resume

2015-04-28 Thread David Vrabel
On 28/04/15 16:52, Boris Ostrovsky wrote: After a resume the hypervisor/tools may change xenbus event channel number. We should re-query it. [...] @@ -793,6 +818,9 @@ static int __init xenbus_init(void) goto out_error; } + if (!xen_initial_domain()) +

Re: [Xen-devel] [PATCH] xen: Suspend ticks on all CPUs during suspend

2015-04-27 Thread David Vrabel
On 08/04/15 19:53, Boris Ostrovsky wrote: > Commit 77e32c89a711 ("clockevents: Manage device's state separately for > the core") decouples clockevent device's modes from states. With this > change when a Xen guest tries to resume, it won't be calling its > set_mode op which needs to be done on

Re: [Xen-devel] [PATCH] xen: Suspend ticks on all CPUs during suspend

2015-04-27 Thread David Vrabel
On 08/04/15 19:53, Boris Ostrovsky wrote: Commit 77e32c89a711 (clockevents: Manage device's state separately for the core) decouples clockevent device's modes from states. With this change when a Xen guest tries to resume, it won't be calling its set_mode op which needs to be done on each VCPU

Re: [PATCH] xen: Add __GFP_DMA flag when xen_swiotlb_init gets free pages on ARM

2015-04-23 Thread David Vrabel
On 23/04/15 10:47, Stefano Stabellini wrote: > Make sure that xen_swiotlb_init allocates buffers that are DMA capable > when at least one memblock is available below 4G. Otherwise we assume > that all devices on the SoC can cope with >4G addresses. This commit message must explain why the PFNs

Re: [PATCH] xen: Add __GFP_DMA flag when xen_swiotlb_init gets free pages on ARM

2015-04-23 Thread David Vrabel
On 23/04/15 10:47, Stefano Stabellini wrote: Make sure that xen_swiotlb_init allocates buffers that are DMA capable when at least one memblock is available below 4G. Otherwise we assume that all devices on the SoC can cope with 4G addresses. This commit message must explain why the PFNs (IPAs)

Re: [PATCH] [RFC] x86/cpu: Fix SMAP check in PVOPS environments

2015-04-20 Thread David Vrabel
uests on Broadwell hardware. The BUG_ON() is consistent for an individual > build, but not consistent for all builds. It has also been a sitting timebomb > since SMAP support was introduced. > > Use native_save_fl() instead, which will obtain an accurate view of the AC >

Re: [Xen-devel] [PATCH] xen: Add __GFP_DMA flag when xen_swiotlb_init gets free pages.

2015-04-20 Thread David Vrabel
On 20/04/15 12:07, Chen Baozi wrote: > On Mon, Apr 20, 2015 at 11:53:47AM +0100, David Vrabel wrote: >> On 20/04/15 11:48, Chen Baozi wrote: >>> Make sure that xen_swiotlb_init allocates buffers that is DMA capable. >>> >>> Signed-off-by: Chen Baozi >&g

Re: [Xen-devel] [PATCH] xen: Add __GFP_DMA flag when xen_swiotlb_init gets free pages.

2015-04-20 Thread David Vrabel
On 20/04/15 12:07, Chen Baozi wrote: On Mon, Apr 20, 2015 at 11:53:47AM +0100, David Vrabel wrote: On 20/04/15 11:48, Chen Baozi wrote: Make sure that xen_swiotlb_init allocates buffers that is DMA capable. Signed-off-by: Chen Baozi baoz...@gmail.com --- drivers/xen/swiotlb-xen.c | 3

Re: [PATCH] [RFC] x86/cpu: Fix SMAP check in PVOPS environments

2015-04-20 Thread David Vrabel
. The BUG_ON() is consistent for an individual build, but not consistent for all builds. It has also been a sitting timebomb since SMAP support was introduced. Use native_save_fl() instead, which will obtain an accurate view of the AC flag. Reviewed-by: David Vrabel david.vra...@citrix.com David

[GIT PULL] xen: features and fixes for 4.1-rc0

2015-04-16 Thread David Vrabel
changed, 1246 insertions(+), 694 deletions(-) Dan Carpenter (1): xen/mce: fix up xen_late_init_mcelog() error handling David Vrabel (2): xen: unify foreign GFN map/unmap for auto-xlated physmap guests xen/privcmd: improve performance of MMAPBATCH_V2 Jan Beulich (1): xen-pciback:

[GIT PULL] xen: features and fixes for 4.1-rc0

2015-04-16 Thread David Vrabel
(+), 694 deletions(-) Dan Carpenter (1): xen/mce: fix up xen_late_init_mcelog() error handling David Vrabel (2): xen: unify foreign GFN map/unmap for auto-xlated physmap guests xen/privcmd: improve performance of MMAPBATCH_V2 Jan Beulich (1): xen-pciback: also support

Re: linux-next: build failure after merge of the xen-tip tree

2015-04-15 Thread David Vrabel
On 13/04/15 09:36, Bob Liu wrote: > Hi Stephen, > > On 04/13/2015 04:09 PM, Stephen Rothwell wrote: >> Hi all, >> >> After merging the xen-tip tree, today's linux-next build (x86_64 >> allmodconfig) >> failed like this: >> >> drivers/char/tpm/xen-tpmfront.c: In function 'setup_ring': >>

Re: linux-next: build failure after merge of the xen-tip tree

2015-04-15 Thread David Vrabel
On 13/04/15 09:36, Bob Liu wrote: Hi Stephen, On 04/13/2015 04:09 PM, Stephen Rothwell wrote: Hi all, After merging the xen-tip tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/char/tpm/xen-tpmfront.c: In function 'setup_ring':

Re: [Xen-devel] [Patch V2 08/15] xen: find unused contiguous memory area

2015-04-09 Thread David Vrabel
case such an area is found reserve it at once as this will be > required to be done in any case. Reviewed-by: David Vrabel David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [Xen-devel] [Patch V2 11/15] xen: check for initrd conflicting with e820 map

2015-04-09 Thread David Vrabel
On 09/04/2015 07:55, Juergen Gross wrote: > Check whether the initrd is placed at a location which is conflicting > with the target E820 map. If this is the case relocate it to a new > area unused up to now and compliant to the E820 map. Reviewed-by: David Vrabel David -- To unsubsc

Re: [Xen-devel] [Patch V2 09/15] xen: check for kernel memory conflicting with memory layout

2015-04-09 Thread David Vrabel
On 09/04/2015 07:55, Juergen Gross wrote: > Checks whether the pre-allocated memory of the loaded kernel is in > conflict with the target memory map. If this is the case, just panic > instead of run into problems later, as there is nothing we can do > to repair this situation. Review

Re: [Xen-devel] [Patch V2 10/15] xen: check pre-allocated page tables for conflict with memory map

2015-04-09 Thread David Vrabel
On 09/04/2015 07:55, Juergen Gross wrote: > Check whether the page tables built by the domain builder are at > memory addresses which are in conflict with the target memory map. > If this is the case just panic instead of running into problems > later. > > Signed-off-by: Juergen Gross > --- >

Re: [Xen-devel] [Patch V2 07/15] xen: check memory area against e820 map

2015-04-09 Thread David Vrabel
-573,6 +573,29 @@ static unsigned long __init > xen_count_remap_pages(unsigned long max_pfn) > return extra; > } > > +bool __init xen_chk_e820_reserved(phys_addr_t start, phys_addr_t size) Can you rename this to xen_is_e280_reserved(). Otherwise, Reviewed-by: David Vr

Re: [Xen-devel] [Patch V2 03/15] xen: don't build mfn tree if tools don't need it

2015-04-09 Thread David Vrabel
On 09/04/15 07:55, Juergen Gross wrote: > In case the Xen tools indicate they don't need the p2m 3 level tree > as they support the virtual mapped linear p2m list, just omit building > the tree. Reviewed-by: David Vrabel David -- To unsubscribe from this list: send the line "uns

Re: [Xen-devel] [Patch V2 02/15] xen: save linear p2m list address in shared info structure

2015-04-09 Thread David Vrabel
count which is changed prior > to and after each mapping change of the p2m list. Reading the > generation count the Xen tools can detect changes of the mappings > and re-read the p2m list eventually. Reviewed-by: David Vrabel David -- To unsubscribe from this list: send the line &quo

Re: [Xen-devel] [Patch V2 01/15] xen: sync with xen headers

2015-04-09 Thread David Vrabel
On 09/04/15 07:55, Juergen Gross wrote: > Use the newest headers from the xen tree to get some new structure > layouts. Reviewed-by: David Vrabel David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [Xen-devel] [Patch V2 03/15] xen: don't build mfn tree if tools don't need it

2015-04-09 Thread David Vrabel
On 09/04/15 07:55, Juergen Gross wrote: In case the Xen tools indicate they don't need the p2m 3 level tree as they support the virtual mapped linear p2m list, just omit building the tree. Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from this list: send the line

Re: [Xen-devel] [Patch V2 09/15] xen: check for kernel memory conflicting with memory layout

2015-04-09 Thread David Vrabel
On 09/04/2015 07:55, Juergen Gross wrote: Checks whether the pre-allocated memory of the loaded kernel is in conflict with the target memory map. If this is the case, just panic instead of run into problems later, as there is nothing we can do to repair this situation. Reviewed-by: David

Re: [Xen-devel] [Patch V2 07/15] xen: check memory area against e820 map

2015-04-09 Thread David Vrabel
xen_count_remap_pages(unsigned long max_pfn) return extra; } +bool __init xen_chk_e820_reserved(phys_addr_t start, phys_addr_t size) Can you rename this to xen_is_e280_reserved(). Otherwise, Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from this list

Re: [Xen-devel] [Patch V2 02/15] xen: save linear p2m list address in shared info structure

2015-04-09 Thread David Vrabel
is changed prior to and after each mapping change of the p2m list. Reading the generation count the Xen tools can detect changes of the mappings and re-read the p2m list eventually. Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from this list: send the line unsubscribe

Re: [Xen-devel] [Patch V2 08/15] xen: find unused contiguous memory area

2015-04-09 Thread David Vrabel
reserve it at once as this will be required to be done in any case. Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [Xen-devel] [Patch V2 10/15] xen: check pre-allocated page tables for conflict with memory map

2015-04-09 Thread David Vrabel
On 09/04/2015 07:55, Juergen Gross wrote: Check whether the page tables built by the domain builder are at memory addresses which are in conflict with the target memory map. If this is the case just panic instead of running into problems later. Signed-off-by: Juergen Gross jgr...@suse.com

Re: [Xen-devel] [Patch V2 01/15] xen: sync with xen headers

2015-04-09 Thread David Vrabel
On 09/04/15 07:55, Juergen Gross wrote: Use the newest headers from the xen tree to get some new structure layouts. Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [Xen-devel] [Patch V2 11/15] xen: check for initrd conflicting with e820 map

2015-04-09 Thread David Vrabel
On 09/04/2015 07:55, Juergen Gross wrote: Check whether the initrd is placed at a location which is conflicting with the target E820 map. If this is the case relocate it to a new area unused up to now and compliant to the E820 map. Reviewed-by: David Vrabel david.vra...@citrix.com David

Re: [Xen-devel] [PATCH v15 12/15] pvqspinlock, x86: Enable PV qspinlock for Xen

2015-04-08 Thread David Vrabel
On 07/04/15 03:55, Waiman Long wrote: > This patch adds the necessary Xen specific code to allow Xen to > support the CPU halting and kicking operations needed by the queue > spinlock PV code. This basically looks the same as the version I wrote, except I think you broke it. > +static void

Re: [Xen-devel] [PATCH v15 12/15] pvqspinlock, x86: Enable PV qspinlock for Xen

2015-04-08 Thread David Vrabel
On 07/04/15 03:55, Waiman Long wrote: This patch adds the necessary Xen specific code to allow Xen to support the CPU halting and kicking operations needed by the queue spinlock PV code. This basically looks the same as the version I wrote, except I think you broke it. +static void

[GIT PULL] xen: regression fixes for 4.0-rc6

2015-04-02 Thread David Vrabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git stable/for-linus-4.0-rc6-tag xen: regression fixes for 4.0-rc6 - - Fix two regressions in the balloon driver's use of memory hotplug when used

[GIT PULL] xen: regression fixes for 4.0-rc6

2015-04-02 Thread David Vrabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git stable/for-linus-4.0-rc6-tag xen: regression fixes for 4.0-rc6 - - Fix two regressions in the balloon driver's use of memory hotplug when used

Re: [PATCH v2] x86: Factor out common CPU initialization code

2015-04-01 Thread David Vrabel
1e ("x86/asm/entry: Replace this_cpu_sp0() with > current_top_of_stack() > to x86_32") to 32-bit Xen PV guests. Reviewed-by: David Vrabel David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@

Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-04-01 Thread David Vrabel
On 26/03/15 12:16, Bob Liu wrote: > There are several place using gnttab async unmap and wait for > completion, so move the common code to a function > gnttab_unmap_refs_async_wait_completion(). > [...] > + > +int gnttab_unmap_refs_async_wait_completion(struct gntab_unmap_queue_data* > item)

Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-04-01 Thread David Vrabel
On 30/03/15 01:03, Bob Liu wrote: > > On 03/28/2015 08:44 AM, Konrad Rzeszutek Wilk wrote: >> On Thu, Mar 26, 2015 at 04:32:45PM +0100, Roger Pau Monné wrote: >>> El 26/03/15 a les 13.16, Bob Liu ha escrit: There are several place using gnttab async unmap and wait for completion, so

Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-04-01 Thread David Vrabel
On 26/03/15 12:16, Bob Liu wrote: There are several place using gnttab async unmap and wait for completion, so move the common code to a function gnttab_unmap_refs_async_wait_completion(). [...] + +int gnttab_unmap_refs_async_wait_completion(struct gntab_unmap_queue_data* item) This name

Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-04-01 Thread David Vrabel
On 30/03/15 01:03, Bob Liu wrote: On 03/28/2015 08:44 AM, Konrad Rzeszutek Wilk wrote: On Thu, Mar 26, 2015 at 04:32:45PM +0100, Roger Pau Monné wrote: El 26/03/15 a les 13.16, Bob Liu ha escrit: There are several place using gnttab async unmap and wait for completion, so move the common

Re: [PATCH v2] x86: Factor out common CPU initialization code

2015-04-01 Thread David Vrabel
: Replace this_cpu_sp0() with current_top_of_stack() to x86_32) to 32-bit Xen PV guests. Reviewed-by: David Vrabel david.vra...@citrix.com David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [Xen-devel] [Patch V2 0/2] xen: fix regressions regarding memory hotplug in pv domains

2015-03-23 Thread David Vrabel
On 20/03/15 12:55, Juergen Gross wrote: > Fix some regressions introduced in 3.16 and 3.19. Applied to stable/for-linus-4.0 and tagged for stable, thanks. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [Xen-devel] [Patch V2 1/2] xen: prepare p2m list for memory hotplug

2015-03-23 Thread David Vrabel
On 23/03/15 14:29, Juergen Gross wrote: > On 03/23/2015 01:46 PM, David Vrabel wrote: >> On 20/03/15 12:55, Juergen Gross wrote: >>> Commit 054954eb051f35e74b75a566a96fe756015352c8 ("xen: switch to linear >>> virtual mapped sparse p2m list") introduced a regre

Re: [Xen-devel] [Patch V2 1/2] xen: prepare p2m list for memory hotplug

2015-03-23 Thread David Vrabel
On 20/03/15 12:55, Juergen Gross wrote: > Commit 054954eb051f35e74b75a566a96fe756015352c8 ("xen: switch to linear > virtual mapped sparse p2m list") introduced a regression regarding to > memory hotplug for a pv-domain: as the virtual space for the p2m list > is allocated for the to be expected

Re: [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-23 Thread David Vrabel
On 20/03/15 13:46, Daniel Kiper wrote: > On Fri, Mar 20, 2015 at 01:55:39PM +0100, Juergen Gross wrote: >> Commit 25b884a83d487fd62c3de7ac1ab5549979188482 ("x86/xen: set >> regions above the end of RAM as 1:1") introduced a regression. >> > > Should not we fill everything above "maxmem" with >

Re: [Xen-devel] [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-23 Thread David Vrabel
s which were added via memory hotplug to >> a pv domain, the pages must be "invalid" instead of "identity" in the >> p2m list before they can be added. >> >> Suggested-by: David Vrabel >> Signed-off-by: Juergen Gross >> --- >> drivers/xe

Re: [Xen-devel] [Patch V2 1/2] xen: prepare p2m list for memory hotplug

2015-03-23 Thread David Vrabel
On 20/03/15 12:55, Juergen Gross wrote: Commit 054954eb051f35e74b75a566a96fe756015352c8 (xen: switch to linear virtual mapped sparse p2m list) introduced a regression regarding to memory hotplug for a pv-domain: as the virtual space for the p2m list is allocated for the to be expected memory

Re: [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-23 Thread David Vrabel
On 20/03/15 13:46, Daniel Kiper wrote: On Fri, Mar 20, 2015 at 01:55:39PM +0100, Juergen Gross wrote: Commit 25b884a83d487fd62c3de7ac1ab5549979188482 (x86/xen: set regions above the end of RAM as 1:1) introduced a regression. Should not we fill everything above maxmem with

Re: [Xen-devel] [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-23 Thread David Vrabel
, the pages must be invalid instead of identity in the p2m list before they can be added. Suggested-by: David Vrabel david.vra...@citrix.com Signed-off-by: Juergen Gross jgr...@suse.com --- drivers/xen/balloon.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers

Re: [Xen-devel] [Patch V2 1/2] xen: prepare p2m list for memory hotplug

2015-03-23 Thread David Vrabel
On 23/03/15 14:29, Juergen Gross wrote: On 03/23/2015 01:46 PM, David Vrabel wrote: On 20/03/15 12:55, Juergen Gross wrote: Commit 054954eb051f35e74b75a566a96fe756015352c8 (xen: switch to linear virtual mapped sparse p2m list) introduced a regression regarding to memory hotplug for a pv

Re: [Xen-devel] [Patch V2 0/2] xen: fix regressions regarding memory hotplug in pv domains

2015-03-23 Thread David Vrabel
On 20/03/15 12:55, Juergen Gross wrote: Fix some regressions introduced in 3.16 and 3.19. Applied to stable/for-linus-4.0 and tagged for stable, thanks. David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [Xen-devel] [PATCH 0/9] qspinlock stuff -v15

2015-03-19 Thread David Vrabel
be a way to disable QUEUE_SPINLOCKS when supported by the arch, is this intentional? If so, the existing ticketlock code could go. David 8<-- x86/xen: paravirt support for qspinlocks Provide the wait and kick ops necessary for paravirt-aware queue spinlocks. Signed-o

Re: [Xen-devel] [PATCH 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-19 Thread David Vrabel
On 19/03/15 17:19, Juergen Gross wrote: > On 03/19/2015 05:18 PM, David Vrabel wrote: >> On 19/03/15 14:31, Juergen Gross wrote: >>> Commit 25b884a83d487fd62c3de7ac1ab5549979188482 ("x86/xen: set >>> regions above the end of RAM as 1:1") introduced a regress

Re: [Xen-devel] [PATCH 1/2] xen: prepare p2m list for memory hotplug

2015-03-19 Thread David Vrabel
On 19/03/15 17:16, Juergen Gross wrote: > On 03/19/2015 05:18 PM, David Vrabel wrote: >> On 19/03/15 14:31, Juergen Gross wrote: >>> Commit 054954eb051f35e74b75a566a96fe756015352c8 ("xen: switch to linear >>> virtual mapped sparse p2m list") introduced a regre

Re: [Xen-devel] [PATCH 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-19 Thread David Vrabel
On 19/03/15 14:31, Juergen Gross wrote: > Commit 25b884a83d487fd62c3de7ac1ab5549979188482 ("x86/xen: set > regions above the end of RAM as 1:1") introduced a regression. > > To be able to add memory pages which were added via memory hotplug to > a pv domain, the pages must be "invalid" instead of

Re: [Xen-devel] [PATCH 1/2] xen: prepare p2m list for memory hotplug

2015-03-19 Thread David Vrabel
On 19/03/15 14:31, Juergen Gross wrote: > Commit 054954eb051f35e74b75a566a96fe756015352c8 ("xen: switch to linear > virtual mapped sparse p2m list") introduced a regression regarding to > memory hotplug for a pv-domain: as the virtual space for the p2m list > is allocated for the to be expected

Re: [Xen-devel] [PATCH 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-19 Thread David Vrabel
On 19/03/15 17:19, Juergen Gross wrote: On 03/19/2015 05:18 PM, David Vrabel wrote: On 19/03/15 14:31, Juergen Gross wrote: Commit 25b884a83d487fd62c3de7ac1ab5549979188482 (x86/xen: set regions above the end of RAM as 1:1) introduced a regression. To be able to add memory pages which were

Re: [Xen-devel] [PATCH 1/2] xen: prepare p2m list for memory hotplug

2015-03-19 Thread David Vrabel
On 19/03/15 17:16, Juergen Gross wrote: On 03/19/2015 05:18 PM, David Vrabel wrote: On 19/03/15 14:31, Juergen Gross wrote: Commit 054954eb051f35e74b75a566a96fe756015352c8 (xen: switch to linear virtual mapped sparse p2m list) introduced a regression regarding to memory hotplug for a pv

Re: [Xen-devel] [PATCH 0/9] qspinlock stuff -v15

2015-03-19 Thread David Vrabel
to disable QUEUE_SPINLOCKS when supported by the arch, is this intentional? If so, the existing ticketlock code could go. David 8-- x86/xen: paravirt support for qspinlocks Provide the wait and kick ops necessary for paravirt-aware queue spinlocks. Signed-off-by: David

Re: [Xen-devel] [PATCH 1/2] xen: prepare p2m list for memory hotplug

2015-03-19 Thread David Vrabel
On 19/03/15 14:31, Juergen Gross wrote: Commit 054954eb051f35e74b75a566a96fe756015352c8 (xen: switch to linear virtual mapped sparse p2m list) introduced a regression regarding to memory hotplug for a pv-domain: as the virtual space for the p2m list is allocated for the to be expected memory

Re: [Xen-devel] [PATCH 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-19 Thread David Vrabel
On 19/03/15 14:31, Juergen Gross wrote: Commit 25b884a83d487fd62c3de7ac1ab5549979188482 (x86/xen: set regions above the end of RAM as 1:1) introduced a regression. To be able to add memory pages which were added via memory hotplug to a pv domain, the pages must be invalid instead of identity

Re: [Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-16 Thread David Vrabel
On 11/03/15 13:52, Jan Beulich wrote: > It's not clear to me why only the enabling operation got handled so > far. Applied to devel/for-linus-4.1, thanks. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [Xen-devel] [PATCH V2 3/3] xen: support suspend/resume in pvscsi frontend

2015-03-16 Thread David Vrabel
On 17/02/15 07:02, Juergen Gross wrote: > Up to now the pvscsi frontend hasn't supported domain suspend and > resume. When a domain with an assigned pvscsi device was suspended > and resumed again, it was not able to use the device any more: trying > to do so resulted in hanging processes. > >

Re: [Xen-devel] [PATCH V2 2/3] xen: scsiback: add LUN of restored domain

2015-03-16 Thread David Vrabel
On 17/02/15 07:02, Juergen Gross wrote: > When a xen domain is being restored the LUN state of a pvscsi device > is "Connected" and not "Initialising" as in case of attaching a new > pvscsi LUN. > > This must be taken into account when adding a new pvscsi device for > a domain as otherwise the

Re: [Xen-devel] [PATCH v4] xen-scsiback: define a pr_fmt macro with xen-pvscsi

2015-03-16 Thread David Vrabel
On 10/03/15 20:49, Tao Chen wrote: > Add the {xen-pvscsi: } prefix in pr_fmt and remove DPRINTK, then > replace all DPRINTK with pr_debug. > > Also fixed up some comments just as eliminate redundant whitespace > and format the code. > > These will make the code easier to read. Applied to

Re: [Xen-devel] [PATCH 0/9] qspinlock stuff -v15

2015-03-16 Thread David Vrabel
On 16/03/15 13:16, Peter Zijlstra wrote: > Hi Waiman, > > As promised; here is the paravirt stuff I did during the trip to BOS last > week. > > All the !paravirt patches are more or less the same as before (the only real > change is the copyright lines in the first patch). > > The paravirt

Re: [Xen-devel] [PATCH 0/9] qspinlock stuff -v15

2015-03-16 Thread David Vrabel
On 16/03/15 13:16, Peter Zijlstra wrote: Hi Waiman, As promised; here is the paravirt stuff I did during the trip to BOS last week. All the !paravirt patches are more or less the same as before (the only real change is the copyright lines in the first patch). The paravirt stuff is

Re: [Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-16 Thread David Vrabel
On 11/03/15 13:52, Jan Beulich wrote: It's not clear to me why only the enabling operation got handled so far. Applied to devel/for-linus-4.1, thanks. David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [Xen-devel] [PATCH V2 3/3] xen: support suspend/resume in pvscsi frontend

2015-03-16 Thread David Vrabel
On 17/02/15 07:02, Juergen Gross wrote: Up to now the pvscsi frontend hasn't supported domain suspend and resume. When a domain with an assigned pvscsi device was suspended and resumed again, it was not able to use the device any more: trying to do so resulted in hanging processes. Support

Re: [Xen-devel] [PATCH V2 2/3] xen: scsiback: add LUN of restored domain

2015-03-16 Thread David Vrabel
On 17/02/15 07:02, Juergen Gross wrote: When a xen domain is being restored the LUN state of a pvscsi device is Connected and not Initialising as in case of attaching a new pvscsi LUN. This must be taken into account when adding a new pvscsi device for a domain as otherwise the pvscsi LUN

Re: [Xen-devel] [PATCH v4] xen-scsiback: define a pr_fmt macro with xen-pvscsi

2015-03-16 Thread David Vrabel
On 10/03/15 20:49, Tao Chen wrote: Add the {xen-pvscsi: } prefix in pr_fmt and remove DPRINTK, then replace all DPRINTK with pr_debug. Also fixed up some comments just as eliminate redundant whitespace and format the code. These will make the code easier to read. Applied to

[GIT PULL] xen: bug fixes for 4.0-rc3

2015-03-13 Thread David Vrabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git stable/for-linus-4.0-rc3-tag xen: bug fixes for 4.0-rc3 - - Fix a PV regression in 3.19. - - Fix a dom0 crash on hosts with large numbers of

[GIT PULL] xen: bug fixes for 4.0-rc3

2015-03-13 Thread David Vrabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git stable/for-linus-4.0-rc3-tag xen: bug fixes for 4.0-rc3 - - Fix a PV regression in 3.19. - - Fix a dom0 crash on hosts with large numbers of

Re: [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread David Vrabel
On 11/03/15 14:42, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 11, 2015 at 01:52:00PM +, Jan Beulich wrote: >> It's not clear to me why only the enabling operation got handled so >> far. > > Reviewed-by: Konrad Rzeszutek Wilk With no reports that this actually fixes anything, do we want this

Re: [Xen-devel] [PATCH 1/2] xen-pciback: limit guest control of command register

2015-03-11 Thread David Vrabel
On 11/03/15 13:51, Jan Beulich wrote: > Otherwise the guest can abuse that control to cause e.g. PCIe > Unsupported Request responses (by disabling memory and/or I/O decoding > and subsequently causing [CPU side] accesses to the respective address > ranges), which (depending on system

Re: [Xen-devel] [PATCH 1/2] xen-pciback: limit guest control of command register

2015-03-11 Thread David Vrabel
On 11/03/15 13:51, Jan Beulich wrote: Otherwise the guest can abuse that control to cause e.g. PCIe Unsupported Request responses (by disabling memory and/or I/O decoding and subsequently causing [CPU side] accesses to the respective address ranges), which (depending on system configuration)

Re: [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread David Vrabel
On 11/03/15 14:42, Konrad Rzeszutek Wilk wrote: On Wed, Mar 11, 2015 at 01:52:00PM +, Jan Beulich wrote: It's not clear to me why only the enabling operation got handled so far. Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com With no reports that this actually fixes anything,

Re: [PATCH 1/1] x86/fpu: math_state_restore() should not blindly disable irqs

2015-03-06 Thread David Vrabel
On 06/03/15 15:36, Oleg Nesterov wrote: > On 03/06, David Vrabel wrote: >> >> On 06/03/15 14:01, Oleg Nesterov wrote: >> >>> Not sure I understand it correctly after the first quick look, but >>> >>> 1. It conflicts with the recent changes in tip/

Re: [PATCH 1/1] x86/fpu: math_state_restore() should not blindly disable irqs

2015-03-06 Thread David Vrabel
d_fpu_begin() is >>>not nice too. It will do __save_init_fpu() and this overwrites >>>->fpu.state too. >>> >>> Starting from v4.0 it does kernel_fpu_disable(), but the older kernels >>> do not. >>> >>> Ingo, this code is

Re: [Xen-devel] [PATCH] xen: avoid NULL pointer dereference in dom0 on large machines

2015-03-06 Thread David Vrabel
On 26/02/15 05:52, Juergen Gross wrote: > Using the pvops kernel a NULL pointer dereference was detected on a > large machine (144 processors) when booting as dom0 in > evtchn_fifo_unmask() during assignment of a pirq. > > The event channel in question was the first to need a new entry in >

[PATCHv4] x86, fpu: remove the logic of non-eager fpu mem allocation at the first usage

2015-03-06 Thread David Vrabel
later allocate during the first usage of FPU. So this free/allocate might be slower for some workloads. c. math_state_restore() is called from multiple places and it is error pone if the caller expects interrupts to be disabled throughout the execution of math_state_restore(). Can lead to subtle bug

Re: [PATCH 1/1] x86/fpu: math_state_restore() should not blindly disable irqs

2015-03-06 Thread David Vrabel
() is not nice too. It will do __save_init_fpu() and this overwrites -fpu.state too. Starting from v4.0 it does kernel_fpu_disable(), but the older kernels do not. Ingo, this code is really horrible and fragile. We need to cleanup it step-by-step, imho. How about the patch from David Vrabel

[PATCHv4] x86, fpu: remove the logic of non-eager fpu mem allocation at the first usage

2015-03-06 Thread David Vrabel
and the code complexity introducing subtle bugs is not worth it. So remove the logic of non-eager fpu mem allocation at the first usage. Signed-off-by: Suresh Siddha sbsid...@gmail.com Signed-off-by: David Vrabel david.vra...@citrix.com --- v4: - add __ref to fpu_init() which needs to allocate the fpu

Re: [Xen-devel] [PATCH] xen: avoid NULL pointer dereference in dom0 on large machines

2015-03-06 Thread David Vrabel
On 26/02/15 05:52, Juergen Gross wrote: Using the pvops kernel a NULL pointer dereference was detected on a large machine (144 processors) when booting as dom0 in evtchn_fifo_unmask() during assignment of a pirq. The event channel in question was the first to need a new entry in

Re: [PATCH 1/1] x86/fpu: math_state_restore() should not blindly disable irqs

2015-03-06 Thread David Vrabel
On 06/03/15 15:36, Oleg Nesterov wrote: On 03/06, David Vrabel wrote: On 06/03/15 14:01, Oleg Nesterov wrote: Not sure I understand it correctly after the first quick look, but 1. It conflicts with the recent changes in tip/x86/fpu 2. fpu_ini() initializes current-thread.fpu.state

Re: [PATCH tip/core/rcu 02/20] x86: Use common outgoing-CPU-notification code

2015-03-04 Thread David Vrabel
On 04/03/15 14:55, Boris Ostrovsky wrote: > > In the meantime, it turned out that HVM guests are broken by this patch > (with our without changes that we've been discussing), because HVM CPUs > die with > > static void xen_hvm_cpu_die(unsigned int cpu) > { > xen_cpu_die(cpu); >

Re: [Xen-devel] [PATCH 3/4] usb: Introduce Xen pvUSB backend

2015-03-04 Thread David Vrabel
On 04/03/15 14:09, Juergen Gross wrote: > > The main question whether it is worth to consider this alternative is > the performance aspect. Does anyone have an idea which USB devices would > typically be used via pvusb? I'd suspect memory sticks and USB disks > and perhaps webcams being the most

<    4   5   6   7   8   9   10   11   12   13   >