Address some trivial leaks.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
tools/perf/builtin-lock.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index d318862..7784347 100644
--- a/tools/perf
While this could be seen as personal taste, there really isn't any
reason for being so stingy printing the lock name. Furthermore, some
symbol names are really just too long, and cutting them at 16 characters
doesn't help at all.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
tools/perf
: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.017 MB perf.data (~724 samples) ]
./perf lock report
Segmentation fault (core dumped)
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
tools/perf/builtin-lock.c | 68 +--
1 file changed
The report_lock_*_event() functions return -1 when lock_stat_findnew(),
thread_stat_findnew() or get_seq() return NULL. These functions only return
this value when failing to allocate memory, this return -ENOMEM instead.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
tools/perf/builtin
is generated by a non perf-lock command.
Patch 5 and 6 are cosmetic changes.
Patch 7 allows the tool to report the average wait times.
Thanks!
Davidlohr Bueso (7):
perf lock: remove dead code
perf lock: return proper code in report_lock_*_event
perf lock: plug some memleaks
perf lock: redo
No need for break statements after goto jumps.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
tools/perf/builtin-lock.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index ee33ba2..148f7e2 100644
--- a/tools/perf/builtin
From: Vineet Gupta vineet.gup...@synopsys.com
Date: Fri, Aug 30, 2013 at 4:46 AM
Subject: Re: ipc-msg broken again on 3.11-rc7?
To: sedat.di...@gmail.com sedat.di...@gmail.com
Cc: linus Torvalds torva...@linux-foundation.org, Davidlohr Bueso
davidlohr.bu...@hp.com, linux-next linux-n
On Mon, 2013-09-02 at 12:10 +0200, Karel Zak wrote:
On Mon, Aug 05, 2013 at 10:21:09PM -0700, Davidlohr Bueso wrote:
+typedef struct _gpt_record {
+u8 boot_indicator; /* unused by EFI, set to 0x80 for bootable
*/
+u8 start_head; /* unused by EFI, pt
On Wed, 2013-07-03 at 09:44 +0200, Sedat Dilek wrote:
On Wed, Jul 3, 2013 at 12:34 AM, a...@linux-foundation.org wrote:
The mm-of-the-moment snapshot 2013-07-02-15-32 has been uploaded to
http://www.ozlabs.org/~akpm/mmotm/
mmotm-readme.txt says
README for mm-of-the-moment:
On Thu, 2013-07-04 at 13:00 +0200, Thomas Gleixner wrote:
On Thu, 4 Jul 2013, Alex Shi wrote:
We find some benchmarks drop a lot on tip/sched/core on many Intel boxes,
like oltp, tbench, hackbench etc. and bisected the commit 5d33b883ae
cause this regression. Due to this commit, the
On Tue, 2013-07-09 at 10:30 +0800, Michael Wang wrote:
Hi, Davidlohr
Thanks for the testing :)
On 07/09/2013 02:59 AM, Davidlohr Bueso wrote:
[snip]
OK, I'll apply the patches, we'll see what happens. If there significant
fallout we'll immediately have more information anyway
Hi Eric,
On Fri, 2013-09-20 at 14:08 -0400, Eric Paris wrote:
Note that Linus suggested a good alternative to patches 1 and 3: use
kfree_rcu() and delay the freeing of the security structure. I would
much prefer that approach to doing security checks with the lock held,
but I want to
On Sat, 2013-09-21 at 11:58 -0700, Linus Torvalds wrote:
On Sat, Sep 21, 2013 at 11:30 AM, Davidlohr Bueso davidl...@hp.com wrote:
IPC uses security_xxx_free() at two levels: for freeing the structure
(ie: shm_destroy()) and cleaning up upon error when creating the
structure (ie: newseg
On Mon, 2013-09-23 at 09:54 -0700, Linus Torvalds wrote:
On Sun, Sep 22, 2013 at 11:42 PM, Davidlohr Bueso davidl...@hp.com wrote:
More importantly, it's wrong. You do the call_rcu() unconditionally,
but it might not be the last use! You need to do it with the same
logic ipc_rcu_putref
On Tue, 2013-09-24 at 15:22 -0700, Tim Chen wrote:
We have incorporated various suggestions from Ingo for version 5 of this
patchset
and will like to have it merged if there are no objections.
In this patchset, we introduce two categories of optimizations to read
write semaphore. The
easily for rwsem.
Signed-off-by: Tim Chen tim.c.c...@linux.intel.com
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
include/linux/mcslock.h | 58
+++
kernel/mutex.c | 58
On Thu, 2013-09-26 at 13:23 -0700, Jason Low wrote:
On Thu, 2013-09-26 at 13:06 -0700, Davidlohr Bueso wrote:
On Thu, 2013-09-26 at 12:27 -0700, Jason Low wrote:
On Wed, Sep 25, 2013 at 3:10 PM, Tim Chen tim.c.c...@linux.intel.com
wrote:
We will need the MCS lock code for doing
On Thu, 2013-09-26 at 11:58 -0700, tip-bot for Masoud Sharbiani wrote:
Commit-ID: b5eafc6f07c95e9f3dd047e72737449cb03c9956
Gitweb: http://git.kernel.org/tip/b5eafc6f07c95e9f3dd047e72737449cb03c9956
Author: Masoud Sharbiani msharbi...@twitter.com
AuthorDate: Thu, 26 Sep 2013 10:30:43
On Thu, 2013-09-26 at 14:09 -0700, Jason Low wrote:
On Thu, 2013-09-26 at 13:40 -0700, Davidlohr Bueso wrote:
On Thu, 2013-09-26 at 13:23 -0700, Jason Low wrote:
On Thu, 2013-09-26 at 13:06 -0700, Davidlohr Bueso wrote:
On Thu, 2013-09-26 at 12:27 -0700, Jason Low wrote:
On Wed, Sep
On Fri, 2013-09-27 at 12:28 -0700, Linus Torvalds wrote:
On Fri, Sep 27, 2013 at 12:00 PM, Waiman Long waiman.l...@hp.com wrote:
On a large NUMA machine, it is entirely possible that a fairly large
number of threads are queuing up in the ticket spinlock queue to do
the wakeup operation.
Hi Manfred,
On Fri, 2013-09-27 at 07:45 +0200, Manfred Spraul wrote:
Hi Davidlohr,
On 09/16/2013 05:04 AM, Davidlohr Bueso wrote:
This fixes a race in shmat() between finding the msq and
actually attaching the segment, as another thread can delete shmid
underneath us if we are preempted
On Fri, 2013-09-27 at 16:54 -0700, Jason Low wrote:
On Fri, Sep 27, 2013 at 4:01 PM, Paul E. McKenney
paul...@linux.vnet.ibm.com wrote:
Yep. The previous lock holder's smp_wmb() won't keep either the compiler
or the CPU from reordering things for the new lock holder. They could for
On Sat, 2013-09-28 at 11:55 -0700, Linus Torvalds wrote:
On Sat, Sep 28, 2013 at 12:41 AM, Ingo Molnar mi...@kernel.org wrote:
Yeah, I fully agree. The reason I'm still very sympathetic to Tim's
efforts is that they address a regression caused by a mechanic
mutex-rwsem conversion:
On Sun, 2013-09-29 at 16:26 -0700, Linus Torvalds wrote:
On Sun, Sep 29, 2013 at 4:06 PM, Davidlohr Bueso davidl...@hp.com wrote:
Btw, I really hate that thing. I think we should turn it back into a
spinlock. None of what it protects needs a mutex or an rwsem.
The same should apply
Hi Manfred,
On Mon, 2013-09-30 at 11:13 +0200, Manfred Spraul wrote:
After acquiring the semlock spinlock, the operations must test that the
array is still valid.
- semctl() and exit_sem() would walk stale linked lists (ugly, but should
be ok: all lists are empty)
- semtimedop() would
Ingo, any chance of picking this up? Thanks!
On Fri, 2013-06-28 at 13:13 -0700, Davidlohr Bueso wrote:
From: Davidlohr Bueso davidlohr.bu...@hp.com
Upon entering the slowpath, we immediately attempt to acquire the lock
by checking if it is already unlocked. If we are lucky enough
this from the rwsem optimistic spinning thread.
Acked-by: Davidlohr Bueso davidlohr.bu...@hp.com
---
kernel/mutex.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/mutex.c b/kernel/mutex.c
index ff05f4b..7ff48c5 100644
--- a/kernel/mutex.c
+++ b/kernel/mutex.c
On Fri, 2013-07-19 at 17:14 +1000, David Gibson wrote:
On Thu, Jul 18, 2013 at 05:42:35PM +0900, Joonsoo Kim wrote:
On Wed, Jul 17, 2013 at 12:50:25PM -0700, Davidlohr Bueso wrote:
From: David Gibson da...@gibson.dropbear.id.au
At present, the page fault path for hugepages
On Sun, 2013-07-21 at 00:02 +0800, Xiaotian Feng wrote:
On Sat, Jul 20, 2013 at 9:13 PM, Fengguang Wu fengguang...@intel.com wrote:
Greetings,
I got the below dmesg and the first bad commit is
commit c5d0282a0405b0a81fa3390e4230e4cbb3ced7a2
Author: Davidlohr Bueso davidlohr.bu
No remaining users, we now use ipc_obtain_object_check().
Signed-off-by: Davidlohr Bueso davidlohr.bu...@hp.com
---
ipc/util.c | 16
ipc/util.h | 1 -
2 files changed, 17 deletions(-)
diff --git a/ipc/util.c b/ipc/util.c
index 9f6aa30..e829da9 100644
--- a/ipc/util.c
+++ b/ipc
-by: Davidlohr Bueso davidlohr.bu...@hp.com
---
ipc/shm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ipc/shm.c b/ipc/shm.c
index 59f2194..c7ee2f6 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -1288,8 +1288,7 @@ SYSCALL_DEFINE1(shmdt, char __user *, shmaddr)
#else /* CONFIG_MMU
Applies on top of linux-next (20130719), please consider them
for 3.12. Very straightforward patchset:
Patch 1: always check the return of find_vma in shmdt(2)
Patch 2-4: remove now mostly unused functions from the previous
cleanups and optimizations.
Davidlohr Bueso (4):
ipc, shm
This function was replaced by a the lockless shm_obtain_object_check(),
and no longer has any users.
Signed-off-by: Davidlohr Bueso davidlohr.bu...@hp.com
---
ipc/shm.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/ipc/shm.c b/ipc/shm.c
index c7ee2f6..9ffc563 100644
--- a/ipc
After previous cleanups and optimizations, this function is no longer
heavily used and we don't have a good reason to keep it. Update the
few remaining callers and get rid of it.
Signed-off-by: Davidlohr Bueso davidlohr.bu...@hp.com
---
ipc/namespace.c | 3 ++-
ipc/util.c | 6 --
ipc
On Thu, 2014-06-05 at 09:22 +0200, Peter Zijlstra wrote:
On Wed, Jun 04, 2014 at 04:56:50PM -0400, Andev wrote:
On Wed, Jun 4, 2014 at 4:38 PM, Pranith Kumar pran...@gatech.edu wrote:
remove a redundant comparision
Signed-off-by: Pranith Kumar bobby.pr...@gmail.com
---
On Thu, 2014-06-05 at 10:54 -0700, Davidlohr Bueso wrote:
On Thu, 2014-06-05 at 09:22 +0200, Peter Zijlstra wrote:
On Wed, Jun 04, 2014 at 04:56:50PM -0400, Andev wrote:
On Wed, Jun 4, 2014 at 4:38 PM, Pranith Kumar pran...@gatech.edu wrote:
remove a redundant comparision
Signed
...@redhat.com
Signed-off-by: Peter Zijlstra pet...@infradead.org
---
Reviewed-by: Davidlohr Bueso davidl...@hp.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
Patch 1 adds a much needed CONFIG_RWSEM_SPIN_ON_OWNER option.
Patch 2 is a quick fix to disable optimistic spinning on PA-RISC.
Thanks!
Davidlohr Bueso (2):
locking/rwsem: Add CONFIG_RWSEM_SPIN_ON_OWNER
locking/rwsem: Disable optimistic spinning for PA-RISC
include/linux/rwsem.h | 4
Just like with mutexes (CONFIG_MUTEX_SPIN_ON_OWNER),
encapsulate the dependencies for rwsem optimistic spinning.
No logical changes here as it continues to depend on both
SMP and the XADD algorithm variant.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
include/linux/rwsem.h | 4
PA-RISC's cmpxchg is not save against normal stores and the code used
for optimistic spinning is known broken because of this.
Disable for now.
[Changelog from PeterZ]
Reported-by: Mikulas Patocka mpato...@redhat.com
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
kernel/Kconfig.locks | 2
On Fri, 2014-06-06 at 10:13 -0700, Jason Low wrote:
On Fri, 2014-06-06 at 08:55 -0700, Davidlohr Bueso wrote:
Just like with mutexes (CONFIG_MUTEX_SPIN_ON_OWNER),
encapsulate the dependencies for rwsem optimistic spinning.
No logical changes here as it continues to depend on both
SMP
On Fri, 2014-06-06 at 19:56 +0200, Peter Zijlstra wrote:
On Fri, Jun 06, 2014 at 01:53:01PM -0400, Pranith Kumar wrote:
On Fri, Jun 6, 2014 at 3:35 AM, Peter Zijlstra pet...@infradead.org wrote:
Now in general, I don't particularly like such superfluous changes, so
unless you can show
On Fri, 2014-06-06 at 11:12 -0700, Davidlohr Bueso wrote:
On Fri, 2014-06-06 at 10:13 -0700, Jason Low wrote:
On Fri, 2014-06-06 at 08:55 -0700, Davidlohr Bueso wrote:
Just like with mutexes (CONFIG_MUTEX_SPIN_ON_OWNER),
encapsulate the dependencies for rwsem optimistic spinning
user.
8--
From: Davidlohr Bueso davidl...@hp.com
Date: Fri, 6 Jun 2014 12:15:03 -0700
Subject: [PATCH v3 1/2] locking/rwsem: Add CONFIG_RWSEM_SPIN_ON_OWNER
Just like with mutexes (CONFIG_MUTEX_SPIN_ON_OWNER),
encapsulate the dependencies for rwsem optimistic
On Wed, 2014-05-07 at 07:27 +0200, Michael Kerrisk (man-pages) wrote:
On 05/07/2014 12:08 AM, Davidlohr Bueso wrote:
On Tue, 2014-05-06 at 22:40 +0200, Michael Kerrisk (man-pages) wrote:
Hi Davidlohr,
On Tue, May 6, 2014 at 10:06 PM, Davidlohr Bueso davidl...@hp.com wrote:
On Fri, 2014
This is useful in the future and allows users to
better understand the reasoning behind the changes.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
include/uapi/linux/shm.h | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/include/uapi/linux/shm.h b/include
On Wed, 2014-05-07 at 22:52 +0200, Fabian Frederick wrote:
Initialize vmpressure_win in vmstat using
calculate_normal_threshold() based on each zone/cpu * SWAP_CLUSTER_SIZE
Value refreshed through cpu notifier and exposed in read-only through
/sys/kernel
You need to describe the problem,
On Fri, 2014-05-09 at 10:44 +0200, Michael Kerrisk (man-pages) wrote:
On Wed, May 7, 2014 at 9:17 PM, Davidlohr Bueso davidl...@hp.com wrote:
This is useful in the future and allows users to
better understand the reasoning behind the changes.
Signed-off-by: Davidlohr Bueso davidl
On Sat, 2014-05-10 at 12:03 +0200, Manfred Spraul wrote:
Somehow TAB$ was overlooked in the last round of whitespace
cleanups.
Do that now, before making further changes.
No big deal, but this patch could easily be included in the the second
patch instead on its own. Thanks.
--
To unsubscribe
On Wed, 2014-06-11 at 11:34 +0200, Petr Mládek wrote:
On Tue 2014-06-10 18:04:45, Luis R. Rodriguez wrote:
From: Luis R. Rodriguez mcg...@suse.com
The default size of the ring buffer is too small for machines
with a large amount of CPUs under heavy load. What ends up
happening when
- not syncing: Kernel exception
Signed-off-by: Steven Miao real...@gmail.com
Acked-by: Davidlohr Bueso davidl...@hp.com
Sorry for the late reply. I'm glad we're getting the vmacache tested on
nommu systems -- something I hadn't been able to do.
--
To unsubscribe from this list: send the line
much point
in attempting all of the above expensive operations. In this patch, we only
attempt the above trylock operations if the mutex is unlocked.
Signed-off-by: Jason Low jason.l...@hp.com
This is significantly cleaner than the v1 patch.
Reviewed-by: Davidlohr Bueso davidl...@hp.com
On Wed, 2014-06-11 at 11:37 -0700, Jason Low wrote:
Upon entering the slowpath in __mutex_lock_common(), we try once more to
acquire the mutex. We only try to acquire if (lock-count = 0). However,
what we actually want here is to try to acquire if the mutex is unlocked
(lock-count == 1).
On Thu, 2014-06-12 at 23:40 +0400, Wahib Faizi wrote:
Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c.
Sorry but unless bundled with something more meaningful, I really don't
see the value in these changes. I certainly don't want to discourage
folks or anything, but just
On Thu, 2014-06-12 at 13:35 -0700, Greg Kroah-Hartman wrote:
On Thu, Jun 12, 2014 at 01:25:34PM -0700, Davidlohr Bueso wrote:
On Thu, 2014-06-12 at 23:40 +0400, Wahib Faizi wrote:
Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c.
Sorry but unless bundled
to an expected value.
Cc: Michal Hocko mho...@suse.cz
Cc: Petr Mladek pmla...@suse.cz
Cc: Andrew Morton a...@linux-foundation.org
Cc: Joe Perches j...@perches.com
Cc: Arun KS arunks.li...@gmail.com
Cc: Kees Cook keesc...@chromium.org
Cc: Davidlohr Bueso davidl...@hp.com
Cc: Chris Metcalf cmetc
...@dvhart.com
Cc: Davidlohr Bueso davidl...@hp.com
Cc: Kees Cook k...@outflux.net
Cc: w...@chromium.org
Link: http://lkml.kernel.org/r/20140611204237.361836...@linutronix.de
Signed-off-by: Thomas Gleixner t...@linutronix.de
---
V2: Fixed the brown paperbag bug of V1
I confirm this v2 fixes
On Fri, 2014-06-13 at 13:44 -0700, Luis R. Rodriguez wrote:
On Fri, Jun 13, 2014 at 1:36 PM, Davidlohr Bueso davidl...@hp.com wrote:
On Fri, 2014-06-13 at 11:28 -0700, Luis R. Rodriguez wrote:
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 7228258..3f3356b 100644
On Fri, 2014-06-13 at 11:28 -0700, Luis R. Rodriguez wrote:
+ /*
+ * If you set log_buf_len=n kernel parameter LOG_CPU_MIN_BUF_SHIFT will
+ * be ignored. LOG_CPU_MIN_BUF_SHIFT is a proactive measure for large
+ * systems. With a LOG_BUF_SHIFT of 18 and LOG_CPU_MIN_BUF_SHIFT
Andrew had put this patch in -next for a while, and Stephen Rothwell was
able to trigger some warnings: https://lkml.org/lkml/2014/5/19/627
8
From: Davidlohr Bueso davidl...@hp.com
Subject: [PATCH] rwsem: Fix warnings
On Tue, 2014-05-20 at 07:36 +1000, Stephen Rothwell wrote:
Hi,
On Mon, 19 May 2014 08:13:16 -0700 Davidlohr Bueso davidl...@hp.com wrote:
On Mon, 2014-05-19 at 18:13 +1000, Stephen Rothwell wrote:
Hi Andrew,
After merging the akpm tree, today's linux-next build (arm
On Mon, 2014-05-19 at 14:47 -0700, Davidlohr Bueso wrote:
Andrew had put this patch in -next for a while, and Stephen Rothwell was
able to trigger some warnings: https://lkml.org/lkml/2014/5/19/627
8
From: Davidlohr Bueso davidl
So if given the choice between the 2, I think checking
!CONFIG_RWSEM_GENERIC_SPINLOCK is better just because we use that to
decide the implementation/structure layout.
Yeah, I suspect this is more suitable as well. Thanks.
8-
From: Davidlohr Bueso
On Tue, 2014-05-20 at 18:43 +0200, Fabian Frederick wrote:
Replace while blocksize;shift by ilog2
Fabian, please start getting into the habit of improving your
changelogs. Unlike a lot of OSS projects, the kernel community (usually)
takes pride in having good ones. You send a number of patches
From: Davidlohr Bueso davidl...@hp.com
Our mutexes have gone a long ways since the original implementation
back in 2005/2006. However, the mutex-design.txt document is still
stuck in the past, to the point where most of the information there
is practically useless and, more important, simply
On Wed, 2014-05-21 at 09:37 -0700, Tim Chen wrote:
On Tue, 2014-05-20 at 18:15 -0700, Joe Perches wrote:
On Tue, 2014-05-20 at 14:04 -0700, Tim Chen wrote:
On Tue, 2014-05-20 at 13:59 -0700, Tim Chen wrote:
On Tue, 2014-05-20 at 13:51 -0700, Jason Low wrote:
On Tue, May 20, 2014 at
On Wed, 2014-05-21 at 12:02 -0700, Tim Chen wrote:
On Wed, 2014-05-21 at 10:41 -0700, Davidlohr Bueso wrote:
From: Davidlohr Bueso davidl...@hp.com
Our mutexes have gone a long ways since the original implementation
back in 2005/2006. However, the mutex-design.txt document is still
On Wed, 2014-05-21 at 14:16 -0700, Jason Low wrote:
On Wed, 2014-05-21 at 10:41 -0700, Davidlohr Bueso wrote:
From: Davidlohr Bueso davidl...@hp.com
+ The MCS lock (proposed by Mellor-Crummey and Scott) is a simple
spinlock
+ with the desirable properties of being fair
From: Davidlohr Bueso davidl...@hp.com
Our mutexes have gone a long ways since the original implementation
back in 2005/2006. However, the mutex-design.txt document is still
stuck in the past, to the point where most of the information there
is practically useless and, more important, simply
Update the lock to i_mmap_rwsem throughout the kernel.
All changes are in comments and documentation.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
include/linux/mmu_notifier.h | 2 +-
kernel/events/uprobes.c | 2 +-
mm/filemap.c | 10 +-
mm/hugetlb.c
The i_mmap_mutex is a close cousin of the anon vma lock,
both protecting similar data, one for file backed pages
and the other for anon memory. To this end, this lock can
also be a rwsem.
This conversion is straightforward. For now, all users take
the write lock.
Signed-off-by: Davidlohr Bueso
Similarly to rmap_walk_anon() and collect_procs_anon(),
there is opportunity to share the lock in rmap_walk_file()
and collect_procs_file() for file backed pages.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
include/linux/fs.h | 10 ++
mm/memory-failure.c | 4 ++--
mm/rmap.c
!
Davidlohr Bueso (5):
mm,fs: introduce helpers around i_mmap_mutex
mm: use new helper functions around the i_mmap_mutex
mm: convert i_mmap_mutex to rwsem
mm/rmap: share the i_mmap_rwsem
mm: rename leftover i_mmap_mutex
fs/hugetlbfs/inode.c | 14 +++---
fs/inode.c
Convert all open coded mutex_lock/unlock calls to the
i_mmap_[lock/unlock]_write() helpers.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
fs/hugetlbfs/inode.c| 4 ++--
kernel/events/uprobes.c | 4 ++--
kernel/fork.c | 4 ++--
mm/filemap_xip.c| 4 ++--
mm/hugetlb.c
Various parts of the kernel acquire and release this mutex,
so add i_mmap_lock_write() and immap_unlock_write() helper
functions that will encapsulate this logic. The next patch
will make use of these.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
include/linux/fs.h | 10 ++
1 file
On Thu, 2014-05-15 at 06:20 +0200, Manfred Spraul wrote:
Hi Davidlohr,
On 05/14/2014 09:50 PM, Davidlohr Bueso wrote:
Do you have any preferences? I can cook up a patch if you think that
this merits Linux having MSGTQL.
MSGTQL means a global counter - therefore zero scalability. That's
-by: Davidlohr Bueso davidl...@hp.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Sun, 2014-05-18 at 07:53 +0200, Manfred Spraul wrote:
On 05/13/2014 10:27 PM, Davidlohr Bueso wrote:
When specifying the MSG_NOERROR flag, receivers can avoid returning
error (E2BIG) and just truncate the message text, if it is too large.
Currently, this logic is only respected when
Hi Manfred,
On Sun, 2014-05-18 at 09:58 +0200, Manfred Spraul wrote:
Hi Andrew,
I've applied the changes recommended by Michael and Davidlohr - and I don't
have any open points on my list, either.
Please keep the review/ack tags that are collected upon different
versions of the patchset.
On Fri, 2014-05-16 at 14:47 +0200, Michael Kerrisk (man-pages) wrote:
Hi Davidlohr,
On 05/15/2014 05:46 PM, Davidlohr Bueso wrote:
On Thu, 2014-05-15 at 06:20 +0200, Manfred Spraul wrote:
Hi Davidlohr,
On 05/14/2014 09:50 PM, Davidlohr Bueso wrote:
Do you have any preferences? I can
Hi Stephen,
On Mon, 2014-05-19 at 18:13 +1000, Stephen Rothwell wrote:
Hi Andrew,
After merging the akpm tree, today's linux-next build (arm
multi_v7_defconfig) produced these warnings:
ipc/ipcns_notifier.c:22:8: warning: excess elements in struct initializer
[enabled by default]
On Mon, 2014-05-19 at 12:48 -0700, Andrew Morton wrote:
On Mon, 19 May 2014 08:13:16 -0700 Davidlohr Bueso davidl...@hp.com wrote:
Presumably a result of commit fe2038c57c03 (rwsem: Support optimistic
spinning).
If CONFIG_SMP, we add two new fields to the rwsem structure
(include
From: Davidlohr Bueso davidl...@hp.com
Our mutexes have gone a long ways since the original implementation
back in 2005/2006. However, the mutex-design.txt document is still
stuck in the past, to the point where most of the information there
is practically useless and, more important, simply
ping? Andrew any chance of getting this in -next?
On Thu, 2014-05-22 at 20:33 -0700, Davidlohr Bueso wrote:
This patchset extends the work started by Ingo Molnar in late 2012,
optimizing the anon-vma mutex lock, converting it from a exclusive mutex
to a rwsem, and sharing the lock for read
()
- refactor zram_set_obj_size() to make it readable
- add comments
Signed-off-by: Weijie Yang weijie.y...@samsung.com
Reviewed-by: Davidlohr Bueso davidl...@hp.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
From: Davidlohr Bueso davidl...@hp.com
Our mutexes have gone a long ways since the original implementation
back in 2005/2006. However, the mutex-design.txt document is still
stuck in the past, to the point where most of the information there
is practically useless and, more important, simply
: Davidlohr Bueso davidlohr.bu...@hp.com
Acked-by: Davidlohr Bueso davidl...@hp.com
With some minor suggestions below.
Cc: Michael Kerrisk mtk.manpa...@gmail.com
---
ipc/sem.c | 12
1 file changed, 12 insertions(+)
diff --git a/ipc/sem.c b/ipc/sem.c
index 9106321..3cc2f7b6
On Mon, 2014-05-26 at 12:35 -0700, Hugh Dickins wrote:
On Thu, 22 May 2014, Davidlohr Bueso wrote:
Similarly to rmap_walk_anon() and collect_procs_anon(),
there is opportunity to share the lock in rmap_walk_file()
and collect_procs_file() for file backed pages.
And lots of other places
On Mon, 2014-05-26 at 12:16 -0700, Hugh Dickins wrote:
On Sat, 24 May 2014, Konstantin Khlebnikov wrote:
CROSS_MEMORY_ATTACH and mm/process_vm_access.c seems misnamed and
misplaced.
Actually it's a kind of IPC and it has no more relation to MM than
sys_read().
This patch moves code
On Sat, 2014-05-10 at 12:03 +0200, Manfred Spraul wrote:
Hi all,
According to the man page of semop(), semzcnt or semncnt are increased
exactly for the operation that couldn't proceed.
The Linux implementation always tried to be clever and to increase the
counters
for all operations
On Mon, 2014-05-12 at 14:15 +0900, Minchan Kim wrote:
On Sat, May 10, 2014 at 02:10:08PM +0800, Weijie Yang wrote:
On Thu, May 8, 2014 at 2:24 PM, Minchan Kim minc...@kernel.org wrote:
On Wed, May 07, 2014 at 11:52:59PM +0900, Joonsoo Kim wrote:
Most popular use of zram is the in-memory
expected this patch to actually come after the
count_* refactoring.
Signed-off-by: Manfred Spraul manf...@colorfullife.com
Reviewed-by: Davidlohr Bueso davidl...@hp.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On Sat, 2014-05-10 at 12:03 +0200, Manfred Spraul wrote:
count_semzcnt and count_semncnt are more of less identical.
The patch creates a single function that either counts the number of tasks
waiting for zero or waiting due to a decrease operation.
This is a nice cleanup.
Signed-off-by:
On Mon, 2014-05-12 at 20:22 +0200, Fabian Frederick wrote:
On Mon, 12 May 2014 09:55:37 +0200
Michal Hocko mho...@suse.cz wrote:
On Sat 10-05-14 08:52:17, Fabian Frederick wrote:
This patch addresses TODO featuring in original version :
This is the 3rd version of the patch and I
On Mon, 2014-05-12 at 20:45 +, Thomas Gleixner wrote:
We happily allow userspace to declare a random kernel thread to be the
owner of a user space PI futex.
Found while analysing the fallout of Dave Jones syscall fuzzer.
Signed-off-by: Thomas Gleixner t...@linutronix.de
Cc:
sleep.
Signed-off-by: Manfred Spraul manf...@colorfullife.com
Acked-by: Davidlohr Bueso davidl...@hp.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2014-05-12 at 09:44 +0200, Michael Kerrisk (man-pages) wrote:
Hi Davidlohr,
On Sun, May 11, 2014 at 10:46 PM, Davidlohr Bueso davidl...@hp.com wrote:
On Fri, 2014-05-09 at 10:44 +0200, Michael Kerrisk (man-pages) wrote:
On Wed, May 7, 2014 at 9:17 PM, Davidlohr Bueso davidl
The need for volatile is not obvious, document it.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
ipc/msg.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/ipc/msg.c b/ipc/msg.c
index c2cdb5b..956cd65 100644
--- a/ipc/msg.c
+++ b/ipc/msg.c
@@ -42,9 +42,7
a full queue.
This applies on top of linux-next-20140513. Furthermore, it passes
all LTP test cases, please consider for 3.16.
Thanks!
Davidlohr Bueso (5):
ipc,msg: use current-state helpers
ipc,msg: move some msgq ns code around
ipc,msg: always respect MSG_NOERROR
ipc,msg: document volatile
Call __set_current_state() instead of assigning
the new state directly.
Signed-off-by: Davidlohr Bueso davidl...@hp.com
---
ipc/msg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ipc/msg.c b/ipc/msg.c
index 7ed1ef3..5a8489b 100644
--- a/ipc/msg.c
+++ b/ipc/msg.c
401 - 500 of 4799 matches
Mail list logo
