Re: [PATCH 4/4] rtc: isl1208: add support for isl1219 with hwmon for tamper detection

2018-01-30 Thread Denis OSTERLAND
> > binding is added with an short example. > > > > Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> > > Signed-off-by: Denis Osterland <denis.osterl...@diehl.com> > > --- > >  .../rtc/{intersil,isl1208.txt => isil,is

Re: [PATCH 4/4] rtc: isl1208: add support for isl1219 with hwmon for tamper detection

2018-01-30 Thread Denis OSTERLAND
Am Dienstag, den 30.01.2018, 11:27 +0100 schrieb Alexandre Belloni: > On 29/01/2018 at 13:59:19 -0800, Guenter Roeck wrote: > > > > On Wed, Jan 24, 2018 at 10:03:33AM +0100, Michael Grzeschik wrote: > > [ ... ] > > > > > > > > > > > > > > > > > + > > > > > diff --git

Re: [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-02-14 Thread Denis OSTERLAND
Am Mittwoch, den 14.02.2018, 21:26 +0100 schrieb Alexandre Belloni: > On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote: > > > > From: Denis Osterland <denis.osterl...@diehl.com> > > > > After successful > > sr = isl1208_i2c_set_regs(client, 0,

Re: [PATCH v4 1/5] rtc: sysfs: facilitate attribute add to rtc device

2018-07-18 Thread Denis OSTERLAND
Hello, thanks for your comments. Am Mittwoch, den 18.07.2018, 09:25 +0200 schrieb Alexandre Belloni: > Hello, > > On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote: > >  > > + > > +static size_t rtc_group_count(struct rtc_device *rtc) > > +{ > I don't feel

Re: [PATCH v4 5/5] rtc: isl1219: add device tree docu

2018-07-18 Thread Denis OSTERLAND
Hello, Am Mittwoch, den 18.07.2018, 09:38 +0200 schrieb Alexandre Belloni: > Hi, > > On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote: > >  > > + > > +Optional properties: > > + > > + - "interrupt-names": list which may contains "ir

[PATCH v5 1/5] rtc: sysfs: facilitate attribute add to rtc device

2018-07-24 Thread Denis OSTERLAND
From: Denis Osterland This patches addresses following problem: rtc_allocate_device devm_device_add_group <-- kernel oops / null pointer, because sysfs entry does not yet exist rtc_register_device rc = devm_device_add_group if (rc) return rc; <-- for

[PATCH v5 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-24 Thread Denis OSTERLAND
occurred. Signed-off-by: Michael Grzeschik Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c | 131 -- 1 file changed, 124 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index 1a2c38cc0178..3150ebdcb179

[PATCH v5 3/5] rtc: isl1208: Add "evdet" interrupt source for isl1219.

2018-07-24 Thread Denis OSTERLAND
From: Denis Osterland Add support for "evdet" named interrupt source. The check if i2c client irq matches evdet irq is needed for the case that there is only one interrupt named "evdet". In this case i2c client code handles this like an unnamed interrupt souce and assigns th

[PATCH v5 5/5] rtc: isl1219: add device tree docu

2018-07-24 Thread Denis OSTERLAND
From: Denis Osterland The devicetree documentation for the ISL1219 device tree binding is added with an short example. It is not a trivial device, because it supports two interrupt sources. Signed-off-by: Denis Osterland --- .../devicetree/bindings/rtc/isil,isl1219.txt | 29

[PATCH v5 0/5] rtc: isl1208: fixes, documentation and isl1219 support

2018-07-24 Thread Denis OSTERLAND
se kcalloc - return error if device is already registered - include helper functions into rtc_add_groups Michael Grzeschik (1): rtc: isl1208: add support for isl1219 with tamper detection Denis Osterland (4): rtc: sysfs: facilitate attribute add to rtc device rtc: isl1208: Add "e

[PATCH v5 4/5] rtc: isl1208: set ev-evienb bit from device tree

2018-07-24 Thread Denis OSTERLAND
From: Denis Osterland Add support to disable event in pull-up. Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index 0812a14c2d5c

Re: [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-18 Thread Denis OSTERLAND
Hi, Am Mittwoch, den 18.07.2018, 10:13 +0200 schrieb Alexandre Belloni: > On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote: > >  > > + if (id->driver_data == TYPE_ISL1219) { > > + rc = ISL1219_REG_EV_EVEN; > > + rc = i2c_smbus_write_byte_d

[PATCH v4 1/5] rtc: sysfs: facilitate attribute add to rtc device

2018-07-10 Thread Denis OSTERLAND
From: Denis Osterland This patches addresses following problem: rtc_allocate_device devm_device_add_group <-- kernel oops / null pointer, because sysfs entry does not yet exist rtc_register_device rc = devm_device_add_group if (rc) return rc; <-- for

[PATCH v4 5/5] rtc: isl1219: add device tree docu

2018-07-10 Thread Denis OSTERLAND
From: Denis Osterland The devicetree documentation for the ISL1219 device tree binding is added with an short example. It is not a trivial device, because it supports two interrupt souces. Signed-off-by: Denis Osterland --- .../devicetree/bindings/rtc/isil,isl1219.txt | 29

[PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-10 Thread Denis OSTERLAND
occurred. Signed-off-by: Michael Grzeschik Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c | 131 -- 1 file changed, 124 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index 1a2c38cc0178..bb189fe6744a

[PATCH v4 3/5] rtc: isl1208: Add "evdet" interrupt source for isl1219.

2018-07-10 Thread Denis OSTERLAND
From: Denis Osterland Add support for "evdet" named interrupt source. The check if i2c client irq matches evdet irq is needed for the case that there is only one interrupt named "evdet". In this case i2c client code handles this like an unnamed interrupt souce and assigns th

[PATCH v4 4/5] rtc: isl1208: set ev-evienb bit from device tree

2018-07-10 Thread Denis OSTERLAND
From: Denis Osterland Add support to disable event in pull-up. Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index bbe08c1ab9f3..2f18ee3c615a 100644

[PATCH v4 0/5] rtc: isl1208: fixes, documentation and isl1219 support

2018-07-10 Thread Denis OSTERLAND
tm before convert and use unsigned long long cased value. Add device-tree flag to disable event in pull-up to maximize battery life time. Michael Grzeschik (1): rtc: isl1208: add support for isl1219 with tamper detection Denis Osterland (4): rtc: sysfs: facilitate attribute add to rtc

Re: [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-10 Thread Denis OSTERLAND
o build test ERROR on v4.18-rc4 next-20180709] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Denis-OSTERLAND/rtc-isl1208-fixes-documentation-and-isl1219-support/20180710-181709

Re: [PATCH v4 5/5] rtc: isl1219: add device tree docu

2018-07-12 Thread Denis OSTERLAND
Am Mittwoch, den 11.07.2018, 09:16 -0600 schrieb Rob Herring: > On Tue, Jul 10, 2018 at 09:44:15AM +0000, Denis OSTERLAND wrote: > > > > From: Denis Osterland > > > > The devicetree documentation for the ISL1219 device tree > > binding is added with an s

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-08 Thread Denis OSTERLAND
Am Mittwoch, den 07.03.2018, 11:47 +0100 schrieb Alexandre Belloni: > > > > + > > > > + tv64.tv_sec = rtc_tm_to_time64(); > > > Why not using an unsigned long long directly here? time64_t is not the > > > correct type. > > Do you mean timespec64 is not the correct type here? > > Then yes,

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-07 Thread Denis OSTERLAND
Am Dienstag, den 06.03.2018, 21:42 +0100 schrieb Alexandre Belloni: > On 05/03/2018 at 10:43:52 +0000, Denis OSTERLAND wrote: > > > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1219.txt > > b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt >

Re: [PATCH v2 2/4] rtc: isl1208: switch to rtc_register_device

2018-03-04 Thread Denis OSTERLAND
elloni/rtc-next] > [also build test ERROR on v4.16-rc3 next-20180302] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Denis-OSTERLAND/rtc-isl1208-fixes-documentation-an

[PATCH v3 4/4] rtc: isl1208: Add "evdet" interrupt source for isl1219.

2018-03-05 Thread Denis OSTERLAND
From: Denis Osterland <denis.osterl...@diehl.com> Add support for "evdet" named interrupt source. The check if i2c client irq matches evdet irq is needed for the case that there is only one interrupt named "evdet". In this case i2c client code handles this like

[PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-05 Thread Denis OSTERLAND
curred, or is empty, if none occurred. The devicetree documentation for the ISL1219 device tree binding is added with an short example. It is not a trivial device, because it supports two interrupt souces. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> Signed-off-by: Den

[PATCH v3 1/4] rtc: isl1208: enable interrupt after context preparation

2018-03-05 Thread Denis OSTERLAND
probe function. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> Signed-off-by: Denis Osterland <denis.osterl...@diehl.com> --- drivers/rtc/rtc-isl1208.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/rtc/rtc-i

[PATCH v3 0/4] rtc: isl1208: fixes, documentation and isl1219 support

2018-03-05 Thread Denis OSTERLAND
of the two possible interrupt sources for isl1219. Support "evdet" named interrupt souce. Michael Grzeschik (2): rtc: isl1208: enable interrupt after context preparation rtc: isl1208: add support for isl1219 with tamper detection Denis Osterland (2): rtc: isl1208: switch to rtc_regis

[PATCH v3 2/4] rtc: isl1208: switch to rtc_register_device

2018-03-05 Thread Denis OSTERLAND
From: Denis Osterland <denis.osterl...@diehl.com> Fix possible race condition. It is not allowed to return with an error code after RTC is registered. Suggested-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Signed-off-by: Denis Osterland <denis.osterl...@dieh

[PATCH v2 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-02-28 Thread Denis OSTERLAND
curred, or is empty, if none occurred. The devicetree documentation for the ISL1219 device tree binding is added with an short example. It is not a trivial device, because it supports two interrupt souces. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> Signed-off-by: Den

[PATCH v2 2/4] rtc: isl1208: switch to rtc_register_device

2018-02-28 Thread Denis OSTERLAND
From: Denis Osterland <denis.osterl...@diehl.com> Fix possible race condition. It is not allowed to return with an error code after RTC is registered. Suggested-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Signed-off-by: Denis Osterland <denis.osterl...@dieh

[PATCH v2 1/4] rtc: isl1208: enable interrupt after context preparation

2018-02-28 Thread Denis OSTERLAND
probe function. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> Signed-off-by: Denis Osterland <denis.osterl...@diehl.com> --- drivers/rtc/rtc-isl1208.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/rtc/rtc-i

[PATCH v2 0/4] rtc: isl1208: fixes, documentation and isl1219 support

2018-02-28 Thread Denis OSTERLAND
rupt souce. Michael Grzeschik (2): rtc: isl1208: enable interrupt after context preparation rtc: isl1208: add support for isl1219 with tamper detection Denis Osterland (2): rtc: isl1208: switch to rtc_register_device rtc: isl1208: Add "evdet" interrupt source for isl1219. .../devicetr

[PATCH v2 4/4] rtc: isl1208: Add "evdet" interrupt source for isl1219.

2018-02-28 Thread Denis OSTERLAND
From: Denis Osterland <denis.osterl...@diehl.com> Add support for "evdet" named interrupt source. The check if i2c client irq matches evdet irq is needed for the case that there is only one interrupt named "evdet". In this case i2c client code handles this like

[PATCH] rtc: isl1208: access i2c client via rtc parent

2018-09-28 Thread Denis OSTERLAND
From: Denis Osterland The move of atrim, dtrim usr sysfs properties from i2c device to rtc device require to access them via dev->parent. This patch also aligns timestamp0. Fixes: 03df75dd03301307ec578ccd4e8c1c0117b8e65c Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c |

Re: rtc: isl1208: avoid possible sysfs race

2018-09-25 Thread Denis OSTERLAND
Hi, just for clarification: This changes user-space representation from /sys/class/rtc/rtcN/device/{atrim,dtrim,usr} to /sys/class/rtc/rtcN/{atrim,dtrim,usr} and fixes the "mistake made back in 2006" you mention in https://patchwork.ozlabs.org/patch/881397/ correct? Regards Denis Am Samstag,

Re: [PATCH] rtc: isl1208: access i2c client via rtc parent

2018-09-28 Thread Denis OSTERLAND
Am Freitag, den 28.09.2018, 14:04 +0200 schrieb Alexandre Belloni: > Hello, >  > Oh right, I actually had that but somehow, I stashed the patch instead > of squashing it. > > If that is fine for you, I'll fold that in the original patch (I'll ad > your SoB). > > Sounds good. Regards Denis

[PATCH v2 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-02-28 Thread Denis OSTERLAND
occurred. The devicetree documentation for the ISL1219 device tree binding is added with an short example. It is not a trivial device, because it supports two interrupt souces. Signed-off-by: Michael Grzeschik Signed-off-by: Denis Osterland --- .../devicetree/bindings/rtc/isil,isl1219.txt | 28

[PATCH v2 4/4] rtc: isl1208: Add "evdet" interrupt source for isl1219.

2018-02-28 Thread Denis OSTERLAND
From: Denis Osterland Add support for "evdet" named interrupt source. The check if i2c client irq matches evdet irq is needed for the case that there is only one interrupt named "evdet". In this case i2c client code handles this like an unnamed interrupt souce and assigns th

[PATCH v2 0/4] rtc: isl1208: fixes, documentation and isl1219 support

2018-02-28 Thread Denis OSTERLAND
rupt souce. Michael Grzeschik (2): rtc: isl1208: enable interrupt after context preparation rtc: isl1208: add support for isl1219 with tamper detection Denis Osterland (2): rtc: isl1208: switch to rtc_register_device rtc: isl1208: Add "evdet" interrupt source for isl1219. .../devicetr

[PATCH v2 2/4] rtc: isl1208: switch to rtc_register_device

2018-02-28 Thread Denis OSTERLAND
From: Denis Osterland Fix possible race condition. It is not allowed to return with an error code after RTC is registered. Suggested-by: Alexandre Belloni Signed-off-by: Denis Osterland Reviewed-by: Michael Grzeschik --- drivers/rtc/rtc-isl1208.c | 8 1 file changed, 4 insertions

[PATCH v2 1/4] rtc: isl1208: enable interrupt after context preparation

2018-02-28 Thread Denis OSTERLAND
Grzeschik Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index c8b4953..a13a4ba 100644 --- a/drivers/rtc/rtc-isl1208.c +++ b

Re: [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-02-14 Thread Denis OSTERLAND
Am Mittwoch, den 14.02.2018, 21:26 +0100 schrieb Alexandre Belloni: > On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote: > > > > From: Denis Osterland > > > > After successful > > sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN);

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-08 Thread Denis OSTERLAND
Am Mittwoch, den 07.03.2018, 11:47 +0100 schrieb Alexandre Belloni: > > > > + > > > > + tv64.tv_sec = rtc_tm_to_time64(); > > > Why not using an unsigned long long directly here? time64_t is not the > > > correct type. > > Do you mean timespec64 is not the correct type here? > > Then yes,

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-07 Thread Denis OSTERLAND
Am Dienstag, den 06.03.2018, 21:42 +0100 schrieb Alexandre Belloni: > On 05/03/2018 at 10:43:52 +0000, Denis OSTERLAND wrote: > > > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1219.txt > > b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt >

Re: [PATCH v2 2/4] rtc: isl1208: switch to rtc_register_device

2018-03-04 Thread Denis OSTERLAND
elloni/rtc-next] > [also build test ERROR on v4.16-rc3 next-20180302] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Denis-OSTERLAND/rtc-isl1208-fixes-documentation-an

[PATCH v3 4/4] rtc: isl1208: Add "evdet" interrupt source for isl1219.

2018-03-05 Thread Denis OSTERLAND
From: Denis Osterland Add support for "evdet" named interrupt source. The check if i2c client irq matches evdet irq is needed for the case that there is only one interrupt named "evdet". In this case i2c client code handles this like an unnamed interrupt souce and assigns th

[PATCH v3 1/4] rtc: isl1208: enable interrupt after context preparation

2018-03-05 Thread Denis OSTERLAND
Grzeschik Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index c8b4953..a13a4ba 100644 --- a/drivers/rtc/rtc-isl1208.c +++ b

[PATCH v3 0/4] rtc: isl1208: fixes, documentation and isl1219 support

2018-03-05 Thread Denis OSTERLAND
of the two possible interrupt sources for isl1219. Support "evdet" named interrupt souce. Michael Grzeschik (2): rtc: isl1208: enable interrupt after context preparation rtc: isl1208: add support for isl1219 with tamper detection Denis Osterland (2): rtc: isl1208: switch to rtc_regis

[PATCH v3 2/4] rtc: isl1208: switch to rtc_register_device

2018-03-05 Thread Denis OSTERLAND
From: Denis Osterland Fix possible race condition. It is not allowed to return with an error code after RTC is registered. Suggested-by: Alexandre Belloni Signed-off-by: Denis Osterland Reviewed-by: Michael Grzeschik --- drivers/rtc/rtc-isl1208.c | 8 1 file changed, 4 insertions

[PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-05 Thread Denis OSTERLAND
occurred. The devicetree documentation for the ISL1219 device tree binding is added with an short example. It is not a trivial device, because it supports two interrupt souces. Signed-off-by: Michael Grzeschik Signed-off-by: Denis Osterland --- .../devicetree/bindings/rtc/isil,isl1219.txt | 28

Re: [PATCH 4/4] rtc: isl1208: add support for isl1219 with hwmon for tamper detection

2018-01-30 Thread Denis OSTERLAND
> > binding is added with an short example. > > > > Signed-off-by: Michael Grzeschik > > Signed-off-by: Denis Osterland > > --- > >  .../rtc/{intersil,isl1208.txt => isil,isl1208.txt} |  18 +- > >  Documentation/hwmon/sysfs-interface|   7 + &

Re: [PATCH 4/4] rtc: isl1208: add support for isl1219 with hwmon for tamper detection

2018-01-30 Thread Denis OSTERLAND
Am Dienstag, den 30.01.2018, 11:27 +0100 schrieb Alexandre Belloni: > On 29/01/2018 at 13:59:19 -0800, Guenter Roeck wrote: > > > > On Wed, Jan 24, 2018 at 10:03:33AM +0100, Michael Grzeschik wrote: > > [ ... ] > > > > > > > > > > > > > > > > > + > > > > > diff --git

[PATCH v4 4/5] rtc: isl1208: set ev-evienb bit from device tree

2018-07-10 Thread Denis OSTERLAND
From: Denis Osterland Add support to disable event in pull-up. Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index bbe08c1ab9f3..2f18ee3c615a 100644

[PATCH v4 0/5] rtc: isl1208: fixes, documentation and isl1219 support

2018-07-10 Thread Denis OSTERLAND
tm before convert and use unsigned long long cased value. Add device-tree flag to disable event in pull-up to maximize battery life time. Michael Grzeschik (1): rtc: isl1208: add support for isl1219 with tamper detection Denis Osterland (4): rtc: sysfs: facilitate attribute add to rtc

[PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-10 Thread Denis OSTERLAND
occurred. Signed-off-by: Michael Grzeschik Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c | 131 -- 1 file changed, 124 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index 1a2c38cc0178..bb189fe6744a

[PATCH v4 3/5] rtc: isl1208: Add "evdet" interrupt source for isl1219.

2018-07-10 Thread Denis OSTERLAND
From: Denis Osterland Add support for "evdet" named interrupt source. The check if i2c client irq matches evdet irq is needed for the case that there is only one interrupt named "evdet". In this case i2c client code handles this like an unnamed interrupt souce and assigns th

[PATCH v4 1/5] rtc: sysfs: facilitate attribute add to rtc device

2018-07-10 Thread Denis OSTERLAND
From: Denis Osterland This patches addresses following problem: rtc_allocate_device devm_device_add_group <-- kernel oops / null pointer, because sysfs entry does not yet exist rtc_register_device rc = devm_device_add_group if (rc) return rc; <-- for

[PATCH v4 5/5] rtc: isl1219: add device tree docu

2018-07-10 Thread Denis OSTERLAND
From: Denis Osterland The devicetree documentation for the ISL1219 device tree binding is added with an short example. It is not a trivial device, because it supports two interrupt souces. Signed-off-by: Denis Osterland --- .../devicetree/bindings/rtc/isil,isl1219.txt | 29

Re: [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-10 Thread Denis OSTERLAND
o build test ERROR on v4.18-rc4 next-20180709] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Denis-OSTERLAND/rtc-isl1208-fixes-documentation-and-isl1219-support/20180710-181709

Re: [PATCH v4 1/5] rtc: sysfs: facilitate attribute add to rtc device

2018-07-18 Thread Denis OSTERLAND
Hello, thanks for your comments. Am Mittwoch, den 18.07.2018, 09:25 +0200 schrieb Alexandre Belloni: > Hello, > > On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote: > >  > > + > > +static size_t rtc_group_count(struct rtc_device *rtc) > > +{ > I don't feel

Re: [PATCH v4 5/5] rtc: isl1219: add device tree docu

2018-07-18 Thread Denis OSTERLAND
Hello, Am Mittwoch, den 18.07.2018, 09:38 +0200 schrieb Alexandre Belloni: > Hi, > > On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote: > >  > > + > > +Optional properties: > > + > > + - "interrupt-names": list which may contains "ir

Re: [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-18 Thread Denis OSTERLAND
Hi, Am Mittwoch, den 18.07.2018, 10:13 +0200 schrieb Alexandre Belloni: > On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote: > >  > > + if (id->driver_data == TYPE_ISL1219) { > > + rc = ISL1219_REG_EV_EVEN; > > + rc = i2c_smbus_write_byte_d

[PATCH] rtc: isl1208: access i2c client via rtc parent

2018-09-28 Thread Denis OSTERLAND
From: Denis Osterland The move of atrim, dtrim usr sysfs properties from i2c device to rtc device require to access them via dev->parent. This patch also aligns timestamp0. Fixes: 03df75dd03301307ec578ccd4e8c1c0117b8e65c Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c |

Re: [PATCH] rtc: isl1208: access i2c client via rtc parent

2018-09-28 Thread Denis OSTERLAND
Am Freitag, den 28.09.2018, 14:04 +0200 schrieb Alexandre Belloni: > Hello, >  > Oh right, I actually had that but somehow, I stashed the patch instead > of squashing it. > > If that is fine for you, I'll fold that in the original patch (I'll ad > your SoB). > > Sounds good. Regards Denis

[PATCH v5 1/5] rtc: sysfs: facilitate attribute add to rtc device

2018-07-24 Thread Denis OSTERLAND
From: Denis Osterland This patches addresses following problem: rtc_allocate_device devm_device_add_group <-- kernel oops / null pointer, because sysfs entry does not yet exist rtc_register_device rc = devm_device_add_group if (rc) return rc; <-- for

[PATCH v5 0/5] rtc: isl1208: fixes, documentation and isl1219 support

2018-07-24 Thread Denis OSTERLAND
se kcalloc - return error if device is already registered - include helper functions into rtc_add_groups Michael Grzeschik (1): rtc: isl1208: add support for isl1219 with tamper detection Denis Osterland (4): rtc: sysfs: facilitate attribute add to rtc device rtc: isl1208: Add "e

[PATCH v5 4/5] rtc: isl1208: set ev-evienb bit from device tree

2018-07-24 Thread Denis OSTERLAND
From: Denis Osterland Add support to disable event in pull-up. Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index 0812a14c2d5c

[PATCH v5 3/5] rtc: isl1208: Add "evdet" interrupt source for isl1219.

2018-07-24 Thread Denis OSTERLAND
From: Denis Osterland Add support for "evdet" named interrupt source. The check if i2c client irq matches evdet irq is needed for the case that there is only one interrupt named "evdet". In this case i2c client code handles this like an unnamed interrupt souce and assigns th

[PATCH v5 5/5] rtc: isl1219: add device tree docu

2018-07-24 Thread Denis OSTERLAND
From: Denis Osterland The devicetree documentation for the ISL1219 device tree binding is added with an short example. It is not a trivial device, because it supports two interrupt sources. Signed-off-by: Denis Osterland --- .../devicetree/bindings/rtc/isil,isl1219.txt | 29

[PATCH v5 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-24 Thread Denis OSTERLAND
occurred. Signed-off-by: Michael Grzeschik Signed-off-by: Denis Osterland --- drivers/rtc/rtc-isl1208.c | 131 -- 1 file changed, 124 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index 1a2c38cc0178..3150ebdcb179

Re: [PATCH v4 5/5] rtc: isl1219: add device tree docu

2018-07-12 Thread Denis OSTERLAND
Am Mittwoch, den 11.07.2018, 09:16 -0600 schrieb Rob Herring: > On Tue, Jul 10, 2018 at 09:44:15AM +0000, Denis OSTERLAND wrote: > > > > From: Denis Osterland > > > > The devicetree documentation for the ISL1219 device tree > > binding is added with an s

Re: rtc: isl1208: avoid possible sysfs race

2018-09-25 Thread Denis OSTERLAND
Hi, just for clarification: This changes user-space representation from /sys/class/rtc/rtcN/device/{atrim,dtrim,usr} to /sys/class/rtc/rtcN/{atrim,dtrim,usr} and fixes the "mistake made back in 2006" you mention in https://patchwork.ozlabs.org/patch/881397/ correct? Regards Denis Am Samstag,

[PATCH v7 0/3] leds: pwm: add support for default-state device

2020-07-31 Thread Denis Osterland-Heim
v6 -> v7: apply comments from Jacek refactore default state read to separate function and use it in leds-gpio and leds-pwm @Pavel I hope that it is okay to keep your acked-by on 2/3, the logic is the same but with switch, in favour of if

[PATCH v7 2/3] leds: pwm: add support for default-state device property

2020-07-31 Thread Denis Osterland-Heim
This patch adds support for "default-state" devicetree property, which allows to defer pwm init to first use of led. This allows to configure the PWM early in bootloader to let the LED blink until an application in Linux userspace sets something different. Signed-off-by: Denis Oste

[PATCH v7 3/3] leds: pwm: add reference to common leds for default-state

2020-07-31 Thread Denis Osterland-Heim
The default-state is now supported for PWM leds. Signed-off-by: Denis Osterland-Heim Acked-by: Jacek Anaszewski Acked-by: Pavel Machek Acked-by: Rob Herring --- Documentation/devicetree/bindings/leds/leds-pwm.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree

[PATCH v7 1/3] leds: move default_state read from fwnode to core

2020-07-31 Thread Denis Osterland-Heim
This patch introduces a new function to read initial default_state from fwnode. Signed-off-by: Denis Osterland-Heim --- drivers/leds/led-core.c | 15 +++ drivers/leds/leds-gpio.c | 12 ++-- drivers/leds/leds.h | 1 + include/linux/leds.h | 12 +--- 4 files

Re: [PATCH v6 1/2] leds: pwm: add support for default-state device property

2020-07-22 Thread Denis Osterland-Heim
der to let the LED > > blink until an application in Linux userspace sets something different. > > > > Signed-off-by: Denis Osterland-Heim > > Acked-by: Jacek Anaszewski > > +#define LEDS_PWM_DEFSTATE_OFF 0 > > +#define LEDS_PWM_DEFSTATE_ON 1 >

[PATCH v6 1/2] leds: pwm: add support for default-state device property

2020-07-12 Thread Denis Osterland-Heim
This patch adds support for "default-state" devicetree property, which allows to defer pwm init to first use of led. This allows to configure the PWM early in bootloader to let the LED blink until an application in Linux userspace sets something different. Signed-off-by: Denis Oste

[PATCH v6 2/2] leds: pwm: add reference to common leds for default-state

2020-07-12 Thread Denis Osterland-Heim
The default-state is now supported for PWM leds. Signed-off-by: Denis Osterland-Heim Acked-by: Jacek Anaszewski Acked-by: Pavel Machek Acked-by: Rob Herring --- Documentation/devicetree/bindings/leds/leds-pwm.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree

[PATCH v6 0/2] leds: pwm: add support for default-state device

2020-07-12 Thread Denis Osterland-Heim
v5 -> v6: tested the rebase to v5.8-rc2 based for-next .../devicetree/bindings/leds/leds-pwm.txt | 2 + drivers/leds/leds-pwm.c| 54 +++--- 2 files changed, 50 insertions(+), 6 deletions(-) Message-Id:

Re: [PATCH v3 2/3] leds: pwm: add support for default-state device property

2020-06-08 Thread Denis Osterland-Heim
Hi Jacek, is your ack still valid for the new versions of the patch-set? Due to the changes I made, I am not sure. Regards, Denis Am Dienstag, den 17.03.2020, 21:43 +0100 schrieb Jacek Anaszewski: > Hi Denis, > > On 3/16/20 9:24 PM, Denis Osterland-Heim wrote: > > Hi Jacek, >