n-cryptographic checksum such as CRC-32 is sufficient to detect such
> inadvertent deviations.
>
> Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory
> map
>by md5 digest")
>
> Signed-off-by: Chris von Recklinghausen
> -
yang Zhang
Signed-off-by: Haiyang Zhang
Co-developed-by: Shachar Raindel
Signed-off-by: Shachar Raindel
Signed-off-by: Dexuan Cui
---
drivers/net/hyperv/netvsc_drv.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/
. This version (v8)
posts them in 2 separate patches, as suggested by Stephen Hemminger.
Please refer to "[PATCH v8 net-next 2/2]" for the history of v1~v7.
Thanks,
Dexuan
Dexuan Cui (2):
hv_netvsc: Make netvsc/VF binding check both MAC and serial number
net: mana: Add a driver for Micro
> From: Stephen Hemminger
> Sent: Friday, April 16, 2021 11:09 AM
> ...
> On Fri, 16 Apr 2021 17:58:45 +0000
> Dexuan Cui wrote:
>
> > > >
> > > > This probably should be a separate patch.
> > > > I think it is trying to address the
> From: Haiyang Zhang
> Sent: Friday, April 16, 2021 10:11 AM
> > From: Stephen Hemminger
> > > ...
> > > @@ -2319,8 +2320,17 @@ static struct net_device
> > *get_netvsc_byslot(const struct net_device *vf_netdev)
> > > if (!ndev_ctx->vf_alloc)
> > > continue;
> > >
>
> From: Stephen Hemminger
> Sent: Thursday, April 15, 2021 2:15 PM
> > ...
> > + netif_carrier_off(ndev);
> > +
> > + get_random_bytes(apc->hashkey, MANA_HASH_KEY_SIZE);
>
> Current practice for network drivers is to use netdev_rss_key_fill() for this.
Will change to netdev_rss_key_fill().
> From: Jakub Kicinski
> Sent: Thursday, April 15, 2021 10:44 AM
> ...
> On Wed, 14 Apr 2021 22:45:19 -0700 Dexuan Cui wrote:
> > + buf = dma_alloc_coherent(gmi->dev, length, _handle,
> > +GFP_KERNEL | __GFP_ZERO);
>
> No need
> From: Jakub Kicinski
> Sent: Tuesday, April 13, 2021 12:03 PM
>
> On Mon, 12 Apr 2021 19:35:09 -0700 Dexuan Cui wrote:
> > + apc->port_st_save = apc->port_is_up;
> > + apc->port_is_up = false;
> > + apc->start_remove = true;
> > +
>
> From: Jakub Kicinski
> Sent: Monday, April 12, 2021 11:21 AM
> ...
> On Sun, 11 Apr 2021 19:34:55 -0700 Dexuan Cui wrote:
> > + for (i = 0; i < ANA_INDIRECT_TABLE_SIZE; i++)
> > + apc->indir_table[i] = i % apc->num_queues;
>
>
> From: Haiyang Zhang
> Sent: Monday, April 12, 2021 7:40 AM
> > From: Andrew Lunn
> > Sent: Monday, April 12, 2021 8:32 AM
> > > ...
> > > + /* At most num_online_cpus() + 1 interrupts are used. */
> > > + msix_index = queue->eq.msix_index;
> > > + if (WARN_ON(msix_index > num_online_cpus()))
>
> From: Leon Romanovsky
> Sent: Monday, April 12, 2021 12:46 AM
> To: Dexuan Cui
> > ...
> > +#define ANA_MAJOR_VERSION 0
> > +#define ANA_MINOR_VERSION 1
> > +#define ANA_MICRO_VERSION 1
>
> Please don't introduce drier versions.
This is not the usu
> From: Andrew Lunn
> Sent: Thursday, April 8, 2021 5:30 PM
> To: Stephen Hemminger
> ...
> > Linux kernel doesn't do namespaces in the code, so every new driver needs
> > to worry about global symbols clashing
>
> This driver is called mana, yet the code uses ana. It would be good to
> resolve
> From: David Miller
> Sent: Thursday, April 8, 2021 5:41 PM
> > ...
> > In the driver code, all the structs/unions marked by __packed are used to
> > talk with the hardware, so I think __packed is necessary here?
>
> It actually isan't in many cases, check with and without the __packed
>
> From: David Miller
> Sent: Thursday, April 8, 2021 4:46 PM
> ...
> > +struct gdma_msg_hdr {
> > + u32 hdr_type;
> > + u32 msg_type;
> > + u16 msg_version;
> > + u16 hwc_msg_id;
> > + u32 msg_size;
> > +} __packed;
> > +
> > +struct gdma_dev_id {
> > + union {
> > + struct
> From: Stephen Hemminger
> Sent: Thursday, April 8, 2021 9:52 AM
Thanks all for your input! We'll make the below changes as suggested:
Microsoft Azure Network Device ==> Microsoft Network Devices
Drop the default m
validated ==> supported
We'll also fix some warnings reported by "kernel test
> From: Leon Romanovsky
> Sent: Wednesday, April 7, 2021 5:45 AM
> > >
> > > BTW, you don't need to write { 0 }, the {} is enough.
> >
> > Thanks for the suggestion! I'll use {0} in v2.
>
> You missed the point, "{ 0 }" change to be "{}" without 0.
Got it. Will make the suggested change.
FWIW,
> From: Leon Romanovsky
> Sent: Wednesday, April 7, 2021 1:10 AM
>
> <...>
>
> > +int gdma_verify_vf_version(struct pci_dev *pdev)
> > +{
> > + struct gdma_context *gc = pci_get_drvdata(pdev);
> > + struct gdma_verify_ver_req req = { 0 };
> > + struct gdma_verify_ver_resp resp = { 0 };
>
> From: Leon Romanovsky
> Sent: Wednesday, April 7, 2021 1:15 AM
> > ...
> > int gdma_test_eq(struct gdma_context *gc, struct gdma_queue *eq)
> > {
> > struct gdma_generate_test_event_req req = { 0 };
> > struct gdma_general_resp resp = { 0 };
>
> BTW, you don't need to write { 0
> From: kernel test robot
> Sent: Tuesday, April 6, 2021 6:31 PM
> ...
> Hi Dexuan,
> I love your patch! Perhaps something to improve:
>
> All warnings (new ones prefixed by >>):
>
>drivers/pci/controller/pci-hyperv.c: In function 'hv_irq_unmask':
>
> From: Andrew Lunn
> Sent: Tuesday, April 6, 2021 6:08 PM
> To: Dexuan Cui
>
> > +static int gdma_query_max_resources(struct pci_dev *pdev)
> > +{
> > + struct gdma_context *gc = pci_get_drvdata(pdev);
> > + struct gdma_general_req req = { 0 };
> >
> From: Chris von Recklinghausen
> Sent: Thursday, April 1, 2021 9:42 AM
> To: a...@kernel.org; s...@redhat.com; raf...@kernel.org; Dexuan Cui
> ; linux...@vger.kernel.org;
> linux-cry...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH v2 1/1] use cr
> From: Eric Biggers
> Sent: Monday, March 29, 2021 6:26 PM
> ...
> It looks like your userspace is using tcrypt.ko to request that the kernel
> test
> "ofb(aes)", but your kernel doesn't have CONFIG_CRYPTO_OFB enabled so the
> test fails as expected.
Hi Eric,
Thanks for the explanation! Yes,
Hi,
MD5 was marked incompliant with FIPS in 2009:
a3bef3a31a19 ("crypto: testmgr - Skip algs not flagged fips_allowed in fips
mode")
a1915d51e8e7 ("crypto: testmgr - Mark algs allowed in fips mode")
But hibernation_e820_save() is still using MD5, and fails in FIPS mode
due to the 2018 patch:
Hi all,
The v5.12.0-rc5 kernel (1e43c377a79f) panics with fips=1.
Please refer to the below panic call-trace. The kernel config file and
the full kernel messages are also attached.
Is this a known issue?
Thanks,
-- Dexuan
Starting dracut pre-udev hook...
[7.260424] alg: self-tests
ace. Add a comment explaining why the code is written this
> way.
>
> Signed-off-by: Shachar Raindel
> Signed-off-by: Haiyang Zhang
> ---
Reviewed-by: Dexuan Cui
> From: James Morse
> Sent: Tuesday, February 9, 2021 10:15 AM
> To: Dexuan Cui
> Cc: Rafael J. Wysocki ; linux-a...@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-hyp...@vger.kernel.org; Michael Kelley
> ; Leandro Pereira
> Subject: Re: How can a userspace progr
> From: Rafael J. Wysocki
> Sent: Friday, February 5, 2021 5:06 AM
> To: Dexuan Cui
> Cc: linux-a...@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-hyp...@vger.kernel.org; Michael Kelley
> Subject: Re: How can a userspace program tell if the system supports the ACPI
&
> From: Paul E. McKenney
> Sent: Thursday, November 26, 2020 3:55 PM
> To: Dexuan Cui
> Cc: boqun.f...@gmail.com; Ingo Molnar ;
> r...@vger.kernel.org; vkuznets ; Michael Kelley
> ; linux-kernel@vger.kernel.org
> Subject: Re: kdump always hangs in rcu_barrier() -
) when CONFIG_HZ=1000
(rather than CONFIG_HZ=250) is used.
Fix the issue by moving hv_stimer_alloc() to a later place where the
LAPIC timer is initialized.
Fixes: 4df4cb9e99f8 ("x86/hyperv: Initialize clockevents earlier in CPU
onlining")
Signed-off-by: Dexuan Cui
---
arch/x86/hyperv/hv_i
> From: Andy Shevchenko
> Sent: Saturday, January 9, 2021 12:52 AM
>>
>> Hi Rafael, Len, and all,
>> Can you please take a look at the v2 patch?
>>
>> The Linux mainline has been broken for several weeks when it
>> runs as a guest on Hyper-V, so we'd like this to be fixed ASAP,
>> as more
> From: Dexuan Cui
> Sent: Thursday, January 7, 2021 11:24 PM
> ...
> Linux VM on Hyper-V crashes with the latest mainline:
> ...
>
> Changes in v2:
> strlcpy -> kstrdup_const. Thanks Rafael J. Wysocki!
> Change commit log accordingly.
Hi Rafael, Len, and a
t() to initialize it.
Signed-off-by: Dexuan Cui
---
Changes in v2:
strlcpy -> kstrdup_const. Thanks Rafael J. Wysocki!
Change commit log accordingly.
drivers/acpi/internal.h | 2 +-
drivers/acpi/scan.c | 14 +-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git
> From: Rafael J. Wysocki
> Sent: Thursday, January 7, 2021 5:48 AM
> > > > Linux VM on Hyper-V crashes with the latest mainline:
> > > > ...
> The root cause is a VM issue AFAICS, though.
Yes.
> It doesn't look like the right fix to me, though.
>
> The problem appears to be that the string
toolstack support for a VM. Currently there is
no easy and reliable way for the userspace to detect the presence of
the state (see https://lkml.org/lkml/2020/12/11/1097). Add
/sys/bus/vmbus/hibernation for this purpose.
Signed-off-by: Dexuan Cui
---
This v3 is similar to v1, and the changes
> From: Michael Kelley
> Sent: Wednesday, January 6, 2021 9:38 AM
> From: Dexuan Cui
> Sent: Tuesday, December 22, 2020 4:12 PM
> >
> > When a Linux VM runs on Hyper-V, if the host toolstack doesn't support
> > hibernation for the VM (this happens on old Hyper-V
> From: Wei Liu
> Sent: Wednesday, January 6, 2021 8:24 AM
> To: Dexuan Cui
> >
> > That said, I don't know if there is any hard rule in regard of
> > the timing here. If there is, then v5.12 is OK to me. :-)
> >
>
> By the time you posted this (Dec 22),
toolstack support for a VM. Currently there is
no easy and reliable way for the userspace to detect the presence of
the state (see https://lkml.org/lkml/2020/12/11/1097). Add
/sys/bus/vmbus/supported_features for this purpose.
Signed-off-by: Dexuan Cui
---
Change in v2:
Added a "V
> From: Wei Liu
> Sent: Tuesday, January 5, 2021 4:58 AM
> > ...
> > Documentation/ABI/stable/sysfs-bus-vmbus | 7 +++
> > drivers/hv/vmbus_drv.c | 20
>
> > 2 files changed, 27 insertions(+)
> >
> > diff --git
> From: Michael Kelley
> Sent: Tuesday, December 22, 2020 5:56 AM
> From: Dexuan Cui
> Sent: Thursday, December 17, 2020
> 8:08 PM
> >
> > Linux VM on Hyper-V crashes with the latest mainline:
> > ...
> > --- a/drivers/acpi/scan.c
> > +++ b/dr
> From: Pavel Machek
> Sent: Monday, December 21, 2020 11:08 AM
>
> On Sat 2020-12-12 01:20:30, Dexuan Cui wrote:
> > Hi all,
> > It looks like Linux can hibernate even if the system does not support the
> > ACPI
> > S4 state, as long as the system can
> From: Dexuan Cui
> Sent: Wednesday, December 23, 2020 12:27 PM
> ...
> The warning only repros if there are more than 1 node, and it only prints once
> for the first vCPU of the second node (i.e. node #1).
A correction: if I configure the 32 vCPUs evenly into 4 nodes, I get t
> From: Lai Jiangshan
> Sent: Wednesday, December 23, 2020 7:02 AM
> >
> > Hi,
> > I tested this patchset on today's tip.git's master branch
> > (981316394e35 ("Merge branch 'locking/urgent'")).
> >
> > Every time the kernel boots with 32 CPUs (I'm running the Linux VM on
> > Hyper-V), I get the
toolstack support for a VM. Currently there is
no easy and reliable way for the userspace to detect the presence of
the state (see https://lkml.org/lkml/2020/12/11/1097). Add
/sys/bus/vmbus/supported_features for this purpose.
Signed-off-by: Dexuan Cui
---
Documentation/ABI/stable/sysfs-bus
> From: Valentin Schneider
> Sent: Tuesday, December 22, 2020 5:40 AM
> To: Dexuan Cui
> Cc: mi...@redhat.com; pet...@infradead.org; juri.le...@redhat.com;
> vincent.guit...@linaro.org; dietmar.eggem...@arm.com;
> rost...@goodmis.org; bseg...@google.com; mgor...@suse.de;
>
Hi,
I'm running a Linux VM with the recent mainline (48342fc07272, 12/20/2020) on
Hyper-V.
When I test hibernation, the VM can easily hit the below BUG_ON during the
resume
procedure (I estimate this can repro about 1/5 of the time). BTW, my VM has 40
vCPUs.
I can't repro the BUG_ON with
ypercall page and cause panic. The workaround
"hv_hypercall_pg = NULL;" in hyperv_cleanup() is unreliabe. Move
hyperv_cleanup() to a better place.
Signed-off-by: Dexuan Cui
---
Changes in v2:
Improved the commit log as Michael Kelley suggested.
No change to v1 other
> From: Michael Kelley
> Sent: Monday, December 21, 2020 7:36 PM
> ...
> Since we don't *need* to do this, I think it might be less risky to just leave
> the code "as is". But I'm OK either way.
Ok, then I'll leave it as is in v2.
Thanks,
-- Dexuan
> From: Michael Kelley
> Sent: Monday, December 21, 2020 3:33 PM
> From: Dexuan Cui
> Sent: Sunday, December 20, 2020 2:30 PM
> >
> > Currently the kexec kernel can panic or hang due to 2 causes:
> >
> > 1) hv_cpu_die() is not called upon kexec, so the hypervi
try to access the hypercall page and cause panic. The workaround
"hv_hypercall_pg = NULL;" in hyperv_cleanup() can't work reliably.
Move hyperv_cleanup() to the right place.
Signed-off-by: Dexuan Cui
---
arch/x86/hyperv/hv_init.c | 4
arch/x86/include/asm/mshyperv.h | 2 ++
arch/x8
> From: Dexuan Cui
> Sent: Thursday, December 17, 2020 8:08 PM
>
> Linux VM on Hyper-V crashes with the latest mainline:
> ...
> This is because of the recent buffer overflow detection in the
> commit 6a39e62abbaf ("lib: string.h: detect intra-object overflow in fo
irmware by Hyper-V, and AFAIK the ID string "HYPER_V_GEN_COUNTER_V1"
is never used by Linux VM on Hyper-V, so let's just truncate the string to
fix the panic.
Signed-off-by: Dexuan Cui
---
drivers/acpi/scan.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/s
NCHRONOUS. Change
> the
> global variable vmscsi_size_delta to per-synthetic-IDE/SCSI-device.
>
> Suggested-by: Dexuan Cui
> Signed-off-by: Andrea Parri (Microsoft)
> Cc: "James E.J. Bottomley"
> Cc: "Martin K. Petersen"
> Cc: linux-s...@vger.kernel.org
Reviewed-by: Dexuan Cui
s E.J. Bottomley"
> Cc: "Martin K. Petersen"
> Cc: linux-s...@vger.kernel.org
Reviewed-by: Dexuan Cui
around, i.e., to underestimate for Win7
> and older but to use the exact value for Win8 and newer.
>
> Suggested-by: Dexuan Cui
> Signed-off-by: Andrea Parri (Microsoft)
> Cc: "James E.J. Bottomley"
> Cc: "Martin K. Petersen"
> Cc: linux-s...@vger.kernel.org
Reviewed-by: Dexuan Cui
> From: Peter Zijlstra
> Sent: Wednesday, December 16, 2020 2:59 AM
> ...
> So I think the reason your above module doesn't work, while the one in
> vmx_init() does work (for 5.10) should be fixed by the completely
> untested below.
>
> I've no clue about 5.4 and no desire to investigate. That's
Hi,
The below init_module() prints "foo: false". This is strange since
static_branch_enable() is called before the static_branch_unlikely().
This strange behavior happens to v5.10 and an old v5.4 kernel.
If I remove the "__init" marker from the init_module() function, then
I get the expected
Hi all,
It looks like Linux can hibernate even if the system does not support the ACPI
S4 state, as long as the system can shut down, so "cat /sys/power/state"
always contains "disk", unless we specify the kernel parameter "nohibernate"
or we use LOCKDOWN_HIBERNATION.
In some scenarios IMO it can
> From: Thomas Gleixner
> Sent: Wednesday, December 2, 2020 1:56 AM
>
> On Tue, Dec 01 2020 at 16:45, Dexuan Cui wrote:
> > The commit f36a74b9345a itself is good, but it causes a panic in a
> > Linux VM that runs on a Hyper-V host that doesn't have the 15-bit
>
The following commit has been merged into the x86/apic branch of tip:
Commit-ID: 26ab12bb9d96133b7880141d68b5e01a8783de9d
Gitweb:
https://git.kernel.org/tip/26ab12bb9d96133b7880141d68b5e01a8783de9d
Author:Dexuan Cui
AuthorDate:Tue, 01 Dec 2020 16:45:10 -08:00
Committer
/iommu/hyperv-iommu.c) can not be found. Fix the panic by
properly claiming the only I/O APIC emulated by Hyper-V.
Cc: David Woodhouse
Cc: Vitaly Kuznetsov
Fixes: f36a74b9345a ("x86/ioapic: Use I/O-APIC ID for finding irqdomain, not
index")
Signed-off-by: Dexuan Cui
---
drivers/iommu/hype
> From: Paul E. McKenney
> Sent: Thursday, November 26, 2020 1:42 PM
>
> > > Another possibility is that rcu_state.gp_kthread is non-NULL, but that
> > > something else is preventing RCU grace periods from completing, but in
> >
> > It looks like somehow the scheduling is not working here: in
> From: Paul E. McKenney
> Sent: Thursday, November 26, 2020 7:47 AM
> ...
> The rcu_segcblist_n_cbs() function returns non-zero because something
> invoked call_rcu() some time previously. The ftrace facility (or just
> a printk) should help you work out where that call_rcu() is located.
> From: Dexuan Cui
> Sent: Monday, November 16, 2020 7:40 PM
> > diff --git a/arch/x86/kernel/kexec-bzimage64.c
> > b/arch/x86/kernel/kexec-bzimage64.c
> > index 57c2ecf43134..ce831f9448e7 100644
> > --- a/arch/x86/kernel/kexec-bzimage64.c
> > +++ b/arch/x86/ke
Hi,
I happened to hit a kdump hang issue in a Linux VM running on some
Hyper-V host. Please see the attached log: the kdump kernel always hangs,
even if I configure only 1 virtual CPU to the VM.
I firstly hit the issue in RHEL 8.3's 4.18.x kernel, but later I found that
the latest upstream
Hi Wei Liu,
Please do not pick up this patch, because actually MMIO VRAM can not work
with fb_deferred_io.
Previously I didn't test Xorg -- sorry. As soon as I tested it, I got the below
warning and the Xorg program ternimated immediately:
[ 28.148432] WARNING: CPU: 19 PID: 1410 at
: hyperv_fb: Use physical memory for fb on
HyperV Gen 1 VMs.")
Cc: Wei Hu
Cc: Boqun Feng
Signed-off-by: Dexuan Cui
---
This patch changes drivers/video/fbdev/Kconfig, but I hope this can
still go through the Hyper-V tree
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/l
("drivers/video: add Hyper-V Synthetic Video Frame Buffer
Driver")
Tested-by: Boqun Feng
Signed-off-by: Dexuan Cui
---
Hi Wei Liu, can you please pick this up into the hyperv/linux.git tree's
hyperv-fixes branch? I really hope this patch can be in v5.10 since it
fixes a longstanding is
> From: Kairui Song
> Sent: Wednesday, October 14, 2020 2:24 AM
> To: linux-kernel@vger.kernel.org
>
> kexec_file_load now just reuse the old boot_params.screen_info.
> But if drivers have change the hardware state, boot_param.screen_info
> could contain invalid info.
>
> For example, the video
The following commit has been merged into the x86/apic branch of tip:
Commit-ID: d981059e13ffa9ed03a73472e932d070323bd057
Gitweb:
https://git.kernel.org/tip/d981059e13ffa9ed03a73472e932d070323bd057
Author:Dexuan Cui
AuthorDate:Mon, 02 Nov 2020 17:11:36 -08:00
Committer
> From: David Woodhouse
> Sent: Tuesday, November 3, 2020 12:03 AM
> > +/*
> > + * If ms_hyperv_msi_ext_dest_id() returns true,
> > hyperv_prepare_irq_remapping()
> > + * returns -ENODEV and the Hyper-V IOMMU driver is not used; instead, the
> > + * generic support of the 15-bit APIC ID is used:
> From: Dexuan Cui
> Sent: Monday, November 2, 2020 5:12 PM
>
> ...
Hi tglx,
Now this patch is in the x86/apic branch, which is great! Thanks for the
quick action! But the third line of the below paragraph of the commit log
is missing... Sorry I just realized I should have
The following commit has been merged into the x86/apic branch of tip:
Commit-ID: af2abc92c5ddf5fc5a2036bc106c4d9a80a4d5f7
Gitweb:
https://git.kernel.org/tip/af2abc92c5ddf5fc5a2036bc106c4d9a80a4d5f7
Author:Dexuan Cui
AuthorDate:Mon, 02 Nov 2020 17:11:36 -08:00
Committer
> From: Dexuan Cui
> Sent: Monday, November 2, 2020 5:12 PM
Sorry I forgot to mention that this patch is based on tip.git's x86/apic branch.
Thanks,
-- Dexuan
t support the Extended Dest ID, nothing
changes with this commit: Linux VM is still able to bring up the CPUs with
>255 APIC IDs with the help of hyperv-iommu.c, but IOAPIC interrupts still
can not go to such CPUs, and the kdump kernel still can not work properly
on such CPUs.
Signed-off-by: Dexuan Cui
-
> From: Thomas Gleixner
> Sent: Tuesday, October 6, 2020 11:58 AM
> > ...
> > I pass through an MSI-X-capable PCI device to the Linux VM (which has
> > only 1 virtual CPU), and the below code does *not* report any error
> > (i.e. pci_alloc_irq_vectors_affinity() returns 2, and request_irq()
> >
Hi all,
I'm running a single-CPU Linux VM on Hyper-V. The Linux kernel is v5.9-rc7
and I have CONFIG_NR_CPUS=256.
The Hyper-V Host (Version 17763-10.0-1-0.1457) provides a guest firmware,
which always reports 128 Local APIC entries in the ACPI MADT table. Here
only the first Local APIC entry's
he irqdata data structure in migrate_one_irq() ->
irq_do_set_affinity() -> hv_set_affinity(), so later when the VM
resumes, hv_pci_restore_msi_state() is able to correctly restore
the interrupt with the correct affinity.
Fixes: ac82fc832708 ("PCI: hv: Add hibernation support")
Revi
> From: Lorenzo Pieralisi
> Sent: Thursday, October 1, 2020 3:13 AM
> > ...
> > I mean this is a Hyper-V specific problem, so IMO we should fix the
> > pci-hyperv driver rather than change the PCI device drivers, which
> > work perfectly on a physical machine and on other hypervisors.
> > Also
> From: Lorenzo Pieralisi
> Sent: Monday, September 28, 2020 3:43 AM
>
> [+MarcZ - this patch needs IRQ maintainers vetting]
Sure. Hi MarkZ, please also review the patch. Thanks!
> On Tue, Sep 08, 2020 at 04:17:59PM -0700, Dexuan Cui wrote:
> > Hyper-V doesn't trap and
> From: Dexuan Cui
> Sent: Tuesday, September 8, 2020 4:18 PM
>
> Hyper-V doesn't trap and emulate the accesses to the MSI/MSI-X registers,
> and we must use hv_compose_msi_msg() to ask Hyper-V to create the IOMMU
> Interrupt Remapping Table Entries. This is not an issue
the panic path gets hung forever. Add a timeout of 10 seconds to prevent
> this.
>
> Fixes: 415719160de3 ("Drivers: hv: vmbus: avoid scheduling in interrupt
> context in vmbus_initiate_unload()")
> Signed-off-by: Michael Kelley
Reviewed-by: Dexuan Cui
VF NIC has been resumed.
Fixes: 19162fd4063a ("hv_netvsc: Fix hibernation for mlx5 VF driver")
Signed-off-by: Dexuan Cui
---
drivers/net/hyperv/netvsc_drv.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drive
The previous change "hv_netvsc: Switch the data path at the right time
during hibernation" adds the call of netvsc_vf_changed() upon
NETDEV_CHANGE, so it's necessary to avoid the duplicate call and message
when the VF is brought UP or DOWN.
Signed-off-by: Dexuan Cui
---
drivers/
drivers can no longer
receive MSI/MSI-X interrupts after hibernation.
Fixes: ac82fc832708 ("PCI: hv: Add hibernation support")
Signed-off-by: Dexuan Cui
Reviewed-by: Jake Oshins
---
Changes in v2:
Fixed a typo in the comment in hv_irq_unmask. Thanks to Michael!
Added Jake'
> From: Michael Kelley
> Sent: Tuesday, September 8, 2020 1:49 PM
> > @@ -2635,6 +2632,15 @@ static int netvsc_resume(struct hv_device *dev)
> > netvsc_devinfo_put(device_info);
> > net_device_ctx->saved_netvsc_dev_info = NULL;
> >
> > + /* A NIC driver (e.g. mlx5) may keep the VF
> From: Michael Kelley
> Sent: Tuesday, September 8, 2020 2:16 PM
> > @@ -1211,6 +1211,21 @@ static void hv_irq_unmask(struct irq_data *data)
> > pbus = pdev->bus;
> > hbus = container_of(pbus->sysdata, struct hv_pcibus_device, sysdata);
> >
> > + if (hbus->state == hv_pcibus_removing)
in
netvsc_suspend()/resume() ndev_ctx->vf_netdev is NULL for mlx4.
Fixes: 0efeea5fb153 ("hv_netvsc: Add the support of hibernation")
Signed-off-by: Dexuan Cui
---
Changes in v2 (Thanks Jakub Kicinski ):
Added coments in the changelog and the code about the implicit
data p
> From: Thomas Gleixner
> Sent: Friday, July 17, 2020 6:03 AM
> [...]
Hi, I'm very sorry for this extremely late reply -- I was sidetracked by
something
else and I just had a chance to revisit the issue. Thank you tglx for the
comments
and suggestions, which I think are reasonable. I realized
> From: Jakub Kicinski
> Sent: Saturday, September 5, 2020 4:27 PM
> [...]
> On Fri, 4 Sep 2020 19:52:18 -0700 Dexuan Cui wrote:
> > mlx5_suspend()/resume() keep the network interface, so during hibernation
> > netvsc_unregister_vf() and netvsc_register_vf() a
quot;)
Signed-off-by: Dexuan Cui
---
drivers/hv/vmbus_drv.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 910b6e90866c..946d0aba101f 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -2382,7 +2382
drivers can no longer
receive MSI/MSI-X interrupts after hibernation.
Fixes: ac82fc832708 ("PCI: hv: Add hibernation support")
Cc: Jake Oshins
Signed-off-by: Dexuan Cui
---
drivers/pci/controller/pci-hyperv.c | 44 +
1 file changed, 44 insertions(+)
diff --git
->vf_netdev is NULL for mlx4.
Fixes: 0efeea5fb153 ("hv_netvsc: Add the support of hibernation")
Signed-off-by: Dexuan Cui
---
drivers/net/hyperv/netvsc_drv.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv
).
The patch adds the __init tag for flat_acpi_madt_oem_check() and
physflat_acpi_madt_oem_check() to avoid a warning seen with "make W=1":
flat_acpi_madt_oem_check() accesses cmdline_apic, which has a __initdata
tag.
Fixes: 7b38725318f4 ("x86: remove subarchitecture support
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of Dexuan Cui
> Sent: Monday, June 15, 2020 10:42 AM
> > >
> > > Hi hch,
> > > The patch is merged into the mainine recently, but unluckily we noticed
> > > a warning with CONFIG_DEBUG_WX=y
>
> From: Vitaly Kuznetsov
> Sent: Monday, June 15, 2020 1:35 AM
> Dexuan Cui writes:
>
> >> From: linux-hyperv-ow...@vger.kernel.org
> >> On Behalf Of Andy Lutomirski
> >> Sent: Tuesday, April 7, 2020 2:01 PM
> >> > On Apr 7, 2020, at 12:38
> From: Dexuan Cui
> Sent: Sunday, May 31, 2020 9:49 AM
> To: t...@linutronix.de; mi...@redhat.com; rdun...@infradead.org;
> b...@alien8.de; h...@zytor.com; x...@kernel.org; pet...@infradead.org;
> alli...@lohutok.net; alexios.zav...@intel.com; gre...@linuxfoundation.org;
&g
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of Andy Lutomirski
> Sent: Tuesday, April 7, 2020 2:01 PM
> To: Christoph Hellwig
> Cc: vkuznets ; x...@kernel.org;
> linux-hyp...@vger.kernel.org; linux-kernel@vger.kernel.org; KY Srinivasan
> ; Stephen Hemminger ;
> Andy Lutomirski ; Peter
> From: Denis Efremov
> Sent: Friday, June 5, 2020 1:00 AM
> To: Dexuan Cui ; Michael Kelley
>
> Cc: Denis Efremov ; James E . J . Bottomley
> ; Martin K . Petersen ;
> linux-hyp...@vger.kernel.org; Linux SCSI List ;
> Linux Kernel Mailing List
> Subject: [PATCH] s
> From: Dexuan Cui
> Sent: Thursday, June 4, 2020 2:50 PM
>
> > > Can you please make a v2 patch for it and Cc my corporate email "decui"
> > > (in
> > To)?
> >
> > Yes, of course. Could I add "Suggested-by"?
> >
> >
> From: Denis Efremov
> Sent: Thursday, June 4, 2020 2:43 PM
> >
> > Hi Denis,
> > When I added the function storvsc_suspend() several months ago, somehow
> > I forgot to remove the unnecessary memset(). Sorry!
> >
> > The buffer is recreated in storvsc_resume() -> storvsc_connect_to_vsp() ->
> >
1 - 100 of 1347 matches
Mail list logo
