Re: [PATCH 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard

2013-09-16 Thread Dmitry Torokhov
On Mon, Sep 16, 2013 at 04:56:03PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Monday, September 16, 2013 8:06 AM > > To: KY Srinivasan > > Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; >

Re: [PATCH 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard

2013-09-16 Thread Dmitry Torokhov
On Mon, Sep 16, 2013 at 03:52:18PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > > Sent: Monday, September 16, 2013 8:20 AM > > To: KY Srinivasan > > Cc: gre...@linuxfoundati

Re: [PATCH 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard

2013-09-16 Thread Dmitry Torokhov
On Mon, Sep 16, 2013 at 06:29:45PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > > Sent: Monday, September 16, 2013 10:10 AM > > To: KY Srinivasan > > Cc: Dan Carpenter; o...@a

Re: [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support

2013-09-17 Thread Dmitry Torokhov
Hi Zubair, On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote: > + > + ret = devm_request_threaded_irq(indio_dev->dev.parent, > + irq, > + pollfunc_th, pollfunc_bh, > + flags, indio_dev->name, > +

Re: [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support

2013-09-18 Thread Dmitry Torokhov
On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote: > > > "Zubair Lutfullah :" wrote: > >On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote: > >> Hi Zubair, > >> > >> On Tue, Sep 17, 2013 at 09:44:07AM +0500,

Re: [PATCH] Input: i8042 - i8042_flush fix for a full 8042 buffer

2013-09-18 Thread Dmitry Torokhov
R_SIZE) as a sign of absence of the controller. Let's change i8042 to return success/error instead and make sure we do not return error prematurely. Signed-off-by: Andrey Moiseev Signed-off-by: Dmitry Torokhov --- drivers/input/serio/i8042.c | 23 ++- 1 file changed, 14 i

Re: [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support

2013-09-18 Thread Dmitry Torokhov
On Wed, Sep 18, 2013 at 05:12:02PM +0100, Jonathan Cameron wrote: > > > Dmitry Torokhov wrote: > >On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote: > >> > >> > >> "Zubair Lutfullah :" wrote: > >> >On Tue, Sep

Re: [PATCH 2/2] uinput: Support injecting multiple events in one write() call

2013-09-18 Thread Dmitry Torokhov
Hi Ryan, On Wed, Sep 18, 2013 at 08:55:44AM +1000, Ryan Mallon wrote: > Rework the code in uinput_inject_event so that it matches the code in > evdev_write and allows injecting more than one event, or zero events. After some thinking I went back to the original version of your patch. For justific

Re: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard

2013-09-18 Thread Dmitry Torokhov
ech Pavlik for helping me with the > details of the AT keyboard driver. I would also like to thank > Dan Carpenter and > Dmitry Torokhov for their detailed review of this > driver. > > I have addressed all the comments of Dan and Dmitry in this version of > the patch This

Re: [PATCH 2/2] uinput: Support injecting multiple events in one write() call

2013-09-18 Thread Dmitry Torokhov
Ryan Mallon wrote: >On 19/09/13 05:48, Dmitry Torokhov wrote: > >> Hi Ryan, >> >> On Wed, Sep 18, 2013 at 08:55:44AM +1000, Ryan Mallon wrote: >>> Rework the code in uinput_inject_event so that it matches the code >in >>> evdev_write and allows i

Re: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard

2013-09-19 Thread Dmitry Torokhov
On Wed, Sep 18, 2013 at 11:27:51PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > > Sent: Wednesday, September 18, 2013 2:01 PM > > To: KY Srinivasan > > Cc: gre...@linuxfoundati

Re: [PATCH 3.12-rc1] USB: input: cm109.c: Convert high volume dev_err() to dev_err_ratelimited()

2013-09-19 Thread Dmitry Torokhov
bugs/1222850 This input device can get into a state that produces a high volume of device status errors. Attempt to throttle these error messages such that the kernel log is not flooded. Cc: Dmitry Torokhov Signed-off-by: Tim Gardner Signed-off-by: Dmitry Torokhov --- drivers/input/m

Re: [PATCH] Input: atmel_tscadcc - update to devm_* API

2013-09-20 Thread Dmitry Torokhov
Hi Manish, On Mon, Sep 16, 2013 at 08:22:58PM +0530, Manish Badarkhe wrote: > static int atmel_tsadcc_remove(struct platform_device *pdev) > { > struct atmel_tsadcc *ts_dev = platform_get_drvdata(pdev); > - struct resource *res; > - > - free_irq(ts_dev->irq, ts_dev); > > in

Re: [PATCH] VMCI: fix to pass correct device identity to free_irq()

2013-09-05 Thread Dmitry Torokhov
On Fri, Sep 06, 2013 at 02:39:28PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > free_irq() expects the same device identity that was passed to > corresponding request_irq(), otherwise the IRQ is not freed. > > Signed-off-by: Wei Yongjun Acked-by: Dmitry Torokhov >

Re: [GIT] HID for 3.12 merge window

2013-09-06 Thread Dmitry Torokhov
On Sat, Sep 07, 2013 at 12:51:27AM +0200, David Herrmann wrote: > Hi > > On Fri, Sep 6, 2013 at 11:59 PM, Markus Trippelsdorf > wrote: > > On 2013.09.06 at 23:50 +0200, David Herrmann wrote: > >> Hi > >> > >> On Fri, Sep 6, 2013 at 10:20 PM, Markus Trippelsdorf > >> wrote: > >> > On 2013.09.06 a

Re: [GIT] HID for 3.12 merge window

2013-09-06 Thread Dmitry Torokhov
Linus Torvalds wrote: >On Fri, Sep 6, 2013 at 2:50 PM, David Herrmann >wrote: >> Hi >> >> On Fri, Sep 6, 2013 at 10:20 PM, Markus Trippelsdorf >>> >>> commit 61e00655e9cb82e034eb72b95a51072e718d14a7 >>> Author: David Herrmann >>> Date: Mon Aug 26 19:14:46 2013 +0200 >>> >>> Input: intr

Re: [GIT] HID for 3.12 merge window

2013-09-06 Thread Dmitry Torokhov
On Fri, Sep 06, 2013 at 06:00:29PM -0700, Linus Torvalds wrote: > On Fri, Sep 6, 2013 at 5:58 PM, Dmitry Torokhov > wrote: > > > > The patch still had problems so I'd revert it and wii bits and try again > > later. > > Ok. Mind giving me a list of commits, s

[git pull] Input updates for 3.12-rc0

2013-09-06 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. You will get a new driver for slidebar on Ideapad laptops and a b

Re: [GIT] HID for 3.12 merge window

2013-09-07 Thread Dmitry Torokhov
David Herrmann wrote: >Hi > >On Sat, Sep 7, 2013 at 11:20 AM, Benjamin Tissoires > wrote: >> >> >> On 07/09/13 10:57, David Herrmann wrote: >>> Hi >>> >>> On Sat, Sep 7, 2013 at 10:24 AM, Benjamin Tissoires I'm not particularly in favor of adding semantic between ABS_MISC >and ABS_MT_SLO

Re: [PATCH 1/2] input: ti_am335x_tsc: Enable shared IRQ for TSC

2013-09-09 Thread Dmitry Torokhov
t (or for > Dmitry to take it himself?) I completely agree with Jonathan, more elegant handling would be nice but current one will do for now. Since most of the work on the driver is going through IIO tree I think it would make sense for this patch to go through it as well. Acked-by: Dmitry T

Re: [PATCH 2/2] uinput: Use input_inject_event in uinput_inject_event

2013-09-10 Thread Dmitry Torokhov
Hi Ryan, On Wed, Sep 11, 2013 at 09:32:53AM +1000, Ryan Mallon wrote: > Call input_inject_event rather than input_event in uinput_inject_event. This > mirrors the behaviour of evdev_write. input_inject_event will ignore the > injected event if the uinput input device has been grabbed for exclusive

Re: [PATCH 1/2] uinput: Support injecting multiple events in one write() call

2013-09-10 Thread Dmitry Torokhov
Hi Ryan, On Wed, Sep 11, 2013 at 09:32:52AM +1000, Ryan Mallon wrote: > Rework the code in uinput_inject_event so that it matches the code in > evdev_write and allows injecting more than one event, or zero events. > > Signed-off-by: Ryan Mallon > --- > drivers/input/misc/uinput.c | 14 +++

Re: [PATCH] HID: Correct the USB IDs for the new Macbook Air 6

2013-09-03 Thread Dmitry Torokhov
id is for ISO, not ANSI, which should have the missing > > number 0x0290. This patchs moves the three numbers accordingly, fixing > > the problem. > > > > Cc: Dmitry Torokhov > > Reported-and-tested-by: Ian Munsie > > Tested-by: Linus G Thiel > > Signe

Re: input: i8042 possible bug

2013-09-03 Thread Dmitry Torokhov
On Tue, Sep 03, 2013 at 09:39:10PM +0400, Andrey Moiseev wrote: > Here is an extract from drivers/input/serio/i8042.c: > > > > static int i8042_flush(void) > > { > > unsigned long flags; > > unsigned char data, str; > > int i = 0; > > > > spin_lock_irqsave(&i8042_lock, flags); > >

Re: [PATCH] input: allow SERIO=m even without EXPERT=y

2013-09-03 Thread Dmitry Torokhov
On Tue, Sep 03, 2013 at 06:25:28PM +0200, Tom Gundersen wrote: > On Tue, Sep 3, 2013 at 5:02 PM, Matthew Garrett wrote: > > On Mon, Sep 02, 2013 at 08:47:10PM +0200, Tom Gundersen wrote: > >> There is plenty of consumer hardware (e.g., mac books) that does not use > >> AT keyboards or PS/2 mice. I

Re: Input: 8042 - only one i8042_filter

2013-09-22 Thread Dmitry Torokhov
Hi Andrey, On Sat, Sep 21, 2013 at 10:48:21AM +0400, Andrey Moiseev wrote: > Is it ok that in /drivers/input/serio/i8042.c it's allowed to install > only one i8042_filter? Theoretically, there may be several different > devices that need their drivers to install i8042_filter, to eat out > some dev

Re: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard

2013-09-23 Thread Dmitry Torokhov
On Monday, September 23, 2013 11:08:12 PM Olaf Hering wrote: > On Wed, Sep 18, Dmitry Torokhov wrote: > > This looks much better. Could you tell me if the patch below (on top of > > yours) still works? > > The help text is slightly incorrect, its a dash not underscore:

Re: [PATCH v3 08/14] Input: twl4030-vibra: Support for DT booted kernel

2012-09-06 Thread Dmitry Torokhov
evice_node *node) > +{ > + if (pdata && pdata->coexist) > + return true; > + > +#ifdef CONFIG_OF > + if (of_find_node_by_name(node, "codec")) > + return true; > +#endif In patch 6 you added a stub for of_find_node_by_nam

Re: [PATCH v3 16/20] HID: Only dump input if someone is listening

2012-09-10 Thread Dmitry Torokhov
On Monday, September 10, 2012 10:49:13 PM Jiri Kosina wrote: > On Mon, 10 Sep 2012, Henrik Rydberg wrote: > > > how do you want to handle this? I am fine with all the HID changes. So > > > either I can take it through my tree and add your Sigoff to the Input > > > patches (if you are fine with thos

Re: [ebeam PATCH v2 1/2] hid: Blacklist eBeam devices

2012-10-10 Thread Dmitry Torokhov
Jiri, Are you OK with this change? Yann, Is the device usable at all with generic HID driver? If it isn't then maybe we should blacklist it unconditionally? Thanks. On Sat, Oct 06, 2012 at 03:14:46PM +0200, Yann Cantin wrote: > > Signed-off-by: Yann Cantin > --- > drivers/hid/hid-core.c |

Re: [PATCH 07/10] input: Enable STMPE keypad driver for Device Tree

2012-10-10 Thread Dmitry Torokhov
keypad->rows |= 1 << row; keypad->cols |= 1 << col; } } } BTW, am I supposed to merge it or ack it? Thanks! > > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Acked-by: Linus Walleij > Signed-off-b

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Dmitry Torokhov
On Friday, November 30, 2012 09:09:21 AM Greg KH wrote: > On Fri, Nov 30, 2012 at 08:47:46AM -0800, Andy King wrote: > > I didn't get the resend either, so it seems our corporate mail really is > > eating messages. Lovely. > > > > > > > +#define IOCTLCMD(_cmd) IOCTL_VMCI_ ## _cmd > > > > > > > >

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Dmitry Torokhov
On Friday, November 30, 2012 10:39:18 AM Greg KH wrote: > On Fri, Nov 30, 2012 at 09:20:41AM -0800, Dmitry Torokhov wrote: > > On Friday, November 30, 2012 09:09:21 AM Greg KH wrote: > > > On Fri, Nov 30, 2012 at 08:47:46AM -0800, Andy King wrote: > > > > I didn&

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Dmitry Torokhov
On Friday, November 30, 2012 10:57:55 AM Greg KH wrote: > On Fri, Nov 30, 2012 at 10:45:44AM -0800, Dmitry Torokhov wrote: > > However you snipped the rest of my reply: do we really need to renumber > > ioctls? There is no benefit for the driver as its ioctl handler does > >

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-30 Thread Dmitry Torokhov
On Friday, November 30, 2012 12:44:06 PM Greg KH wrote: > On Fri, Nov 30, 2012 at 12:09:40PM -0800, Dmitry Torokhov wrote: > > On Friday, November 30, 2012 10:57:55 AM Greg KH wrote: > > > On Fri, Nov 30, 2012 at 10:45:44AM -0800, Dmitry Torokhov wrote: > > > > Howe

Re: [PATCH v2 0/1] Input: xpad - Implement wireless controller LED setting and fix connect time LED setting

2012-11-30 Thread Dmitry Torokhov
ris Moeller This patch removes the non-functional bulk output URB method for setting XBox360 Wireless Controller player number indicators on controller activation, and replaces it with a functional IRQ output URB method. It also implements the LED command control for

Re: [PATCH v3 0/4] Cypress PS/2 Trackpad driver

2012-12-02 Thread Dmitry Torokhov
Hi Kamal, On Thu, Nov 29, 2012 at 01:57:57PM -0800, Kamal Mostafa wrote: > This driver, submitted on behalf of Cypress Semiconductor Corporation and > additional contributors, provides support for the Cypress PS/2 Trackpad. > > This [PATCH v3] version differs from my previous submitted version[1]

Re: [PATCH v2 0/1] Input: xpad - Implement wireless controller LED setting and fix connect time LED setting

2012-12-02 Thread Dmitry Torokhov
On Fri, Nov 30, 2012 at 08:13:29PM -0800, Chris Moeller wrote: > On Fri, 30 Nov 2012 14:30:23 -0800 > Dmitry Torokhov wrote: > > > Hi Chris, > > > > On Friday, November 30, 2012 01:54:06 PM Chris Moeller wrote: > > > I've submitted versions of this with

Re: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-03 Thread Dmitry Torokhov
On Mon, Dec 03, 2012 at 08:45:20AM +0100, Henrik Rydberg wrote: > > +/* > > + * reset trackpad device to standard relative mode. > > + * This is also the defalut mode when trackpad powered on. > > + */ > > +static void cypress_reset(struct psmouse *psmouse) > > +{ > > + struct cytp_data *cytp = p

Re: [PATCH 1/1] Input: STMicroelectronics multi touch capacitive touchscreen ftk

2012-12-03 Thread Dmitry Torokhov
Hi Li, On Tue, Dec 04, 2012 at 08:32:05AM +0800, Li Wu wrote: > Thanks Felipe for the nice comments. > > I have consolidated most of your comments to a new version, but I am not > sure how should I send it out. > > I am using git send-email from shell command, then shall I just send out > the pa

Re: [PATCH 1/2] Input: xpad - Minor coding style errors fixed.

2012-12-03 Thread Dmitry Torokhov
On Sat, Dec 01, 2012 at 11:36:19PM -0800, Guillermo A. Amaral wrote: > From: "Guillermo A. Amaral" > > Fixed a few minor coding style issues in xpad driver. Applied both, thanks Guillermo. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [PATCH v2 1/1] Input: STMicroelectronics multi touch capacitive touchscreen ftk

2012-12-04 Thread Dmitry Torokhov
Hi Li, On Tue, Dec 04, 2012 at 06:26:29AM -0500, Li Wu wrote: > +STM FTK TOUCHSCREEN DRIVER > +M: Li Wu > +L: device-drivers-de...@blackfin.uclinux.org > +W: http://www.st.com > +S: Supported > +F: drivers/input/touchscreen/ftk.c > + > + You have an extra blank line here

Re: [PATCH v2] ARM: eukrea_mbimx27-baseboard - use stock get_pendown_state() in ads7846

2012-12-04 Thread Dmitry Torokhov
On Tue, Nov 27, 2012 at 01:03:56AM -0800, Dmitry Torokhov wrote: > The default implementation matches exactly our custom one so we can switch > to using the default one. As a bonus the driver will take care of setting > GPIO line for us. > > Signed-off-by: Dmitry Torokhov Eric,

Re: [PATCH 1/2] Input: xpad - Minor coding style errors fixed.

2012-12-04 Thread Dmitry Torokhov
On Mon, Dec 03, 2012 at 11:28:36PM -0800, Guillermo A. Amaral wrote: > On Mon, Dec 03, 2012 at 09:24:00PM -0800, Dmitry Torokhov wrote: > > On Sat, Dec 01, 2012 at 11:36:19PM -0800, Guillermo A. Amaral wrote: > > > From: "Guillermo A. Amaral" > > > > >

Re: [PATCH] Input: serio - Add ARC PS/2 driver

2012-10-17 Thread Dmitry Torokhov
Hi Mischa, On Wed, Oct 17, 2012 at 12:10:19PM +0200, Mischa Jonker wrote: > This adds support for the PS/2 block that is used in various ARC FPGA > platforms. > Thank you for making changes. A few more comments below. > Signed-off-by: Mischa Jonker > --- > drivers/input/serio/Kconfig |9

Re: weird use-after-free bug in module_put

2012-10-19 Thread Dmitry Torokhov
Hi Dave, On Fri, Oct 19, 2012 at 11:34:52AM -0400, Dave Jones wrote: > On Fri, Oct 19, 2012 at 10:43:51AM -0400, Dave Jones wrote: > > I've hit this twice in the last two days while fuzz testing. > > (Both times on i686 only, my x86-64 tests aren't hitting it > > for some reason). > > > > B

Re: [PATCH 5/5] xen-kbdfront: handle backend CLOSED without CLOSING

2012-10-19 Thread Dmitry Torokhov
tek Wilk > > --- > > Cc: linux-in...@vger.kernel.org > > Cc: Dmitry Torokhov > > Hey Dmitry, > > Should I prep a git pull for you for this or are you OK giving > an Ack for me to put this patch in my git pull for Linus? Sure, please merge with the rest through your

Re: weird use-after-free bug in module_put

2012-10-19 Thread Dmitry Torokhov
On Fri, Oct 19, 2012 at 06:09:51PM +0100, Al Viro wrote: > On Fri, Oct 19, 2012 at 09:33:18AM -0700, Dmitry Torokhov wrote: > > > We are now removing instance of character device corresponding to input > > device when input device disappears. > > > > Ah, I know...

Re: weird use-after-free bug in module_put

2012-10-19 Thread Dmitry Torokhov
On Fri, Oct 19, 2012 at 06:50:46PM +0100, Al Viro wrote: > On Fri, Oct 19, 2012 at 10:36:39AM -0700, Dmitry Torokhov wrote: > > On Fri, Oct 19, 2012 at 06:09:51PM +0100, Al Viro wrote: > > > On Fri, Oct 19, 2012 at 09:33:18AM -0700, Dmitry Torokhov wrote: > > >

Re: [PATCH 1/2] Input: matrix-keypad - remove const from pointer to array of gpios

2012-10-19 Thread Dmitry Torokhov
On Fri, Oct 19, 2012 at 12:36:12PM +0530, AnilKumar Ch wrote: > Remove const from pointer to array of gpios in matrix_keypad_platform_data > struct. This is required if we update row_gpios and col_gpios based on > device tree data. Then don't. Set them up via non-const aliases instead. Thanks. -

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-20 Thread Dmitry Torokhov
On Tue, Oct 16, 2012 at 08:35:56PM -0700, Arve Hjønnevåg wrote: > On Fri, Oct 5, 2012 at 12:48 PM, Mathieu Poirier > wrote: > > On 12-10-05 12:16 PM, Dmitry Torokhov wrote: > >> On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: > >&

[PATCH 2/2] Input: fix use-after-free introduced with dynamic minor changes

2012-10-21 Thread Dmitry Torokhov
that it will stay pinned until character device is freed. Also, now that parent structure is pinned while character device exists we do not need to pin and unpin it every time user opens or closes it. Reported-by: Dave Jones Signed-off-by: Dmitry Torokhov --- drivers/input/evdev.c| 3

[PATCH 1/2] char_dev: allow setting up and pinning parent devices

2012-10-21 Thread Dmitry Torokhov
object is freed. To achieve this allow setting a "parent" device for character devices and pin them when doing cdev_add() and unpin when last reference to cdev structure is being released. Signed-off-by: Dmitry Torokhov --- Sorry, messed up the first attempt to send... So, how about

Re: [PATCH 1/2] char_dev: allow setting up and pinning parent devices

2012-10-21 Thread Dmitry Torokhov
On Sun, Oct 21, 2012 at 08:39:28AM +0100, Al Viro wrote: > On Sun, Oct 21, 2012 at 12:24:30AM -0700, Dmitry Torokhov wrote: > > In certain cases (for example when a cdev structure is embedded into > > another object whose lifetime is controlled by a separate device object) > >

[PATCH 2/2] Input: fix use-after-free introduced with dynamic minor changes

2012-10-21 Thread Dmitry Torokhov
that it will stay pinned until character device is freed. Also, now that parent structure is pinned while character device exists we do not need to pin and unpin it every time user opens or closes it. Reported-by: Dave Jones Signed-off-by: Dmitry Torokhov --- drivers/input/evdev.c| 3

[PATCH 1/2] char_dev: pin parent kobject

2012-10-21 Thread Dmitry Torokhov
. To achieve this let's pin kobject's parent when doing cdev_add() and unpin when last reference to cdev structure is being released. Signed-off-by: Dmitry Torokhov --- OK, so it looks like cdev kobject's parent is unused so we can just have users set themselves as parents of chara

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-22 Thread Dmitry Torokhov
iguration; maybe when instantiating platform device? Thanks. > > Cc: Felipe Balbi > Cc: Dmitry Torokhov > Signed-off-by: Sourav Poddar > --- > v1->v2 > - Added "PROBE_DEFER" check > drivers/input/keyboard/omap4-keypad.c | 11 +++ > 1 files ch

Re: [PATCH v1] Support Elan Touchscreen eKTF product.

2012-10-22 Thread Dmitry Torokhov
On Mon, Oct 22, 2012 at 11:47:42AM +0800, Jian-Jhong Ding wrote: > Scott Liu writes: > > + > > +struct mt_device { > > + struct mt_slot curdata; /* placeholder of incoming data */ > > + __u8 num_received; /* how many contacts we received */ > > + __u8 num_expected; /* expected last

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-05 Thread Dmitry Torokhov
Hi Benson, On Wed, Dec 05, 2012 at 04:48:19PM -0800, Benson Leung wrote: > This patch introduces a driver for Cypress All Points Addressable > I2C Trackpad, including the ones in 2012 Samsung Chromebooks. > > This device is compatible with MT protocol type B, providing identifiable > contacts. >

Re: [PATCH v5 1/3] input: increase struct ps2dev cmdbuf[] to 8 bytes

2012-12-05 Thread Dmitry Torokhov
Hi Kamal, On Wed, Dec 05, 2012 at 04:16:14PM -0800, Kamal Mostafa wrote: > Cypress PS/2 Trackpad (drivers/input/mouse/cypress_ps2.c) needs > this larger cmdbuf[] to handle 8-byte packet responses. > > Signed-off-by: Kamal Mostafa I will apply this patch so you do not need to resend it with cypr

Re: [PATCH v5 3/3] input: Cypress PS/2 Trackpad link into psmouse-base

2012-12-05 Thread Dmitry Torokhov
Hi Kamal, On Wed, Dec 05, 2012 at 04:16:16PM -0800, Kamal Mostafa wrote: > From: Dudley Du > > Original code contributed by Dudley Du (Cypress Semiconductor Corporation), > modified by Kamal Mostafa. > > BugLink: http://launchpad.net/bugs/978807 Please fold it into the cypress_ps2 patch, they

Re: [PATCH v5 2/3] input: Cypress PS/2 Trackpad psmouse driver

2012-12-06 Thread Dmitry Torokhov
Hi Kamal, On Wed, Dec 05, 2012 at 04:16:15PM -0800, Kamal Mostafa wrote: > From: Dudley Du > > Input/mouse driver for Cypress PS/2 Trackpad. > > Original code contributed by Dudley Du (Cypress Semiconductor Corporation), > modified by Kamal Mostafa and Kyle Fazzari. > > BugLink: http://launchp

Re: [PATCH v6] Cypress PS/2 Trackpad driver

2012-12-10 Thread Dmitry Torokhov
On Mon, Dec 10, 2012 at 06:13:59PM +0100, Henrik Rydberg wrote: > > > > +config MOUSE_PS2_CYPRESS > > > > + bool "Cypress PS/2 mouse protocol extension" if EXPERT > > > > > > Why EXPERT here? > > > > > > > + default y > > > > > > Should it really be default y here? > > > > > > This

[PATCH] Input: matrix-keymap - provide proper module license

2012-12-10 Thread Dmitry Torokhov
ff-by: Florian Fainelli CC: sta...@vger.kernel.org Signed-off-by: Dmitry Torokhov --- Hi Linus, Please apply before 3.8 final if possible. Sending directly as my normal branch has some extra stuff in it... Thanks, Dmitry drivers/input/matrix-keymap.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [PATCH v4 09/14] Input: introduce EV_MSC Timestamp

2012-11-14 Thread Dmitry Torokhov
ff-by: Benjamin Tissoires > Reviewed-by: Henrik Rydberg Acked-by: Dmitry Torokhov I take it will go through Jiri's tree, right? > --- > Documentation/input/event-codes.txt | 11 +++ > include/linux/input.h | 1 + > 2 files changed, 12 insertions(+) &g

Re: [RFC] staging: ste_rmi4: merge into the main kernel tree

2012-11-14 Thread Dmitry Torokhov
Hi Alexandra, On Wed, Nov 14, 2012 at 05:40:12PM +, Alexandra Chin wrote: > Hi Henrik and all, > > As I know, currently there is no synaptics RMI4 touchscreen driver in the > main tree. In order to support our customers effectively, is it able to merge > staging ste_rmi4 driver into the main

Re: [PATCH] input: fix input-mt kernel-doc warning

2012-11-14 Thread Dmitry Torokhov
On Thu, Nov 08, 2012 at 06:56:09PM +0100, Henrik Rydberg wrote: > Hi Dmitry, > > > > > From: Randy Dunlap > > > > > > > > Fix new kernel-doc warning in input-mt.c: > > > > > > > > Warning(drivers/input/input-mt.c:38): No description found for > > > > parameter 'flags' > > > > > > Thanks for t

Re: [RFC] staging: ste_rmi4: merge into the main kernel tree

2012-11-14 Thread Dmitry Torokhov
On Thu, Nov 15, 2012 at 02:56:45AM +, Alexandra Chin wrote: > Hi Dmitry, > > > > As I know, currently there is no synaptics RMI4 touchscreen driver in the > > > main tree. In order to support our customers effectively, is it able to > > > merge > > > staging ste_rmi4 driver into the main kern

Re: Why Cypress does not upstream its trackpad driver?

2012-11-07 Thread Dmitry Torokhov
Hi David, On Wednesday, November 07, 2012 06:30:11 PM David Solda wrote: > Kamal, > > My name is Dave Solda and I would be happy to answer any other questions > that you have. Troy's response is correct however as in order to support > the default Linux mouse class, our firmware would also have t

Re: [PATCH 1/3] input: spear-keyboard: Use devm_*() routines

2012-11-08 Thread Dmitry Torokhov
Hi Viresh, On Thu, Nov 08, 2012 at 07:10:47PM +0530, Viresh Kumar wrote: > This patch frees spear-keyboard driver from tension of freeing resources :) > devm_* derivatives of multiple routines are used while allocating resources, > which would be freed automatically by kernel. It also breaks the

Re: [PATCH] input: fix input-mt kernel-doc warning

2012-11-08 Thread Dmitry Torokhov
On Wed, Nov 07, 2012 at 08:46:17PM +0100, Henrik Rydberg wrote: > Hi Randy, > > > From: Randy Dunlap > > > > Fix new kernel-doc warning in input-mt.c: > > > > Warning(drivers/input/input-mt.c:38): No description found for parameter > > 'flags' > > Thanks for the patch. It seemed reasonable to

Re: [PATCH 1/3] input: spear-keyboard: Use devm_*() routines

2012-11-08 Thread Dmitry Torokhov
On Fri, Nov 09, 2012 at 08:06:29AM +0530, Viresh Kumar wrote: > On 8 November 2012 22:08, Dmitry Torokhov wrote: > > On Thu, Nov 08, 2012 at 07:10:47PM +0530, Viresh Kumar wrote: > > It also breaks the error unwinding/removal of the driver as it frees > > input device while

Re: [PATCH v3 12/13] HID: introduce Scan Time

2012-11-09 Thread Dmitry Torokhov
Hi Benjamin, On Wed, Nov 07, 2012 at 05:37:35PM +0100, Benjamin Tissoires wrote: > Win 8 digitizer devices provides the actual scan time computed by the > hardware itself. The value is global to the frame and is not specific > to the multitouch protocol (though only touch, not pen, should use it >

Re: [PATCH 1/3] input: stmpe-keyboard: Use devm_*() routines

2012-11-09 Thread Dmitry Torokhov
Hi Viresh, On Fri, Nov 09, 2012 at 08:57:48PM +0530, Viresh Kumar wrote: > This patch frees stmpe-keyboard driver from tension of freeing resources :) > devm_* derivatives of multiple routines are used while allocating resources, > which would be freed automatically by kernel. > > Signed-off-by:

Re: [PATCH 2/3] input: stmpe-ts: Use devm_*() routines

2012-11-10 Thread Dmitry Torokhov
Hi Viresh, On Fri, Nov 09, 2012 at 10:34:35PM +0530, Viresh Kumar wrote: > On 9 November 2012 20:57, Viresh Kumar wrote: > > This patch frees stmpe-ts driver from tension of freeing resources :) > > devm_* derivatives of multiple routines are used while allocating resources, > > which would be fr

Re: [PATCH 2/3] input: stmpe-ts: Use devm_*() routines

2012-11-10 Thread Dmitry Torokhov
On Sat, Nov 10, 2012 at 01:34:33PM +0530, Viresh Kumar wrote: > On 10 November 2012 13:33, Viresh Kumar wrote: > > On 10 November 2012 13:30, Dmitry Torokhov > > wrote: > >> Sometimes your mailer does wrap long lines, please make sure to turn it > >> off for

Re: [PATCH] input: vt8500: Add power button keypad driver

2012-12-30 Thread Dmitry Torokhov
Hi Tony, On Mon, Dec 31, 2012 at 11:01:02AM +1300, Tony Prisk wrote: > This patch adds support for the Power Button keypad found on > Wondermedia netbooks/tablets. > > A keymap property is exposed to allowing defining the key > event to be generated when the power button is pressed. > > Signed-o

Re: [PATCH] input: vt8500: Add power button keypad driver

2012-12-30 Thread Dmitry Torokhov
On Mon, Dec 31, 2012 at 12:44:31PM +1300, Tony Prisk wrote: > > > > + status = readl(pmc_base + 0x14); > > > + udelay(100); > > > + writel(status, pmc_base + 0x14); > > > + > > > + if (status & BIT(14)) { > > > + if (!power_button_pressed) { > > > > No need to do this check. > > > The ha

Re: [PATCH v2] input: vt8500: Add power button keypad driver

2012-12-31 Thread Dmitry Torokhov
Hi Tony, On Mon, Dec 31, 2012 at 03:04:59PM +1300, Tony Prisk wrote: > This patch adds support for the Power Button keypad found on > Wondermedia netbooks/tablets. > > Signed-off-by: Tony Prisk > --- > v2: > Remove devicetree binding for keycode > Add dependency on OF in Kconfig > Move static va

Re: [PATCH 1/2] timer: vt8500: Move system timer to clocksource

2013-01-02 Thread Dmitry Torokhov
On Thu, Jan 03, 2013 at 04:25:09PM +1300, Tony Prisk wrote: > +static void __init vt8500_timer_init(void) > +{ > + struct device_node *np; > + int timer_irq; > + > + np = of_find_matching_node(NULL, vt8500_timer_ids); > + if (!np) { > + pr_err("%s: Timer description miss

[git pull] Input updates for 3.8-rc2

2013-01-04 Thread Dmitry Torokhov
: - Christophe TORDEUX (1): Input: sentelic - only report position of first finger as ST coordinates Dmitry Torokhov (1): Input: gpio_keys - defer probing if GPIO probing is deferred Gabor Juhos (1): Input: gpio_keys_polled - defer probing if GPIO probing is deferred

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-05 Thread Dmitry Torokhov
Hi Laxman, On Sat, Jan 05, 2013 at 01:15:08PM +0530, Laxman Dewangan wrote: > Use devm_* for memory, clock, input device allocation. This reduces > code for freeing these resources. > > Signed-off-by: Laxman Dewangan > --- > Changes from V1: > None > > drivers/input/keyboard/tegra-kbc.c | 93

Re: [PATCH] drivers/input/keyboard/lm8323.c: fix incorrect left shift

2013-01-05 Thread Dmitry Torokhov
On Sat, Jan 05, 2013 at 02:09:05PM -0500, Nickolai Zeldovich wrote: > In drivers/input/keyboard/lm8323.c, INT_PWM1 is already a bitmask, > not the bit number, so shifting by INT_PWM1 is incorrect. > > Signed-off-by: Nickolai Zeldovich Applied, thank you Nickolai. > --- > drivers/input/keyboard

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-05 Thread Dmitry Torokhov
On Sat, Jan 05, 2013 at 04:50:58PM +0530, Laxman Dewangan wrote: > HI Dmitry, > Thanks for quick review. > > I will take care of your comment in next version. Some have my answer. > > > On Saturday 05 January 2013 01:36 PM, Dmitry Torokhov wrote: > >Hi Laxman, > &

Re: [PATCH 5/5] Input: Add ChromeOS EC keyboard driver

2012-12-19 Thread Dmitry Torokhov
On Wed, Dec 19, 2012 at 12:57:22PM +, Grant Likely wrote: > On Fri, 14 Dec 2012 17:43:31 -0800, Dmitry Torokhov > wrote: > > On Saturday, December 15, 2012 01:13:45 AM Grant Likely wrote: > > > On Wed, 12 Dec 2012 13:33:48 -0800, Simon Glass wrote: > > >

Re: [PATCH 01/01] Input multitouch: fix horizontal two-finger-scrolling on Sentelic touchpads

2012-12-19 Thread Dmitry Torokhov
On Thu, Dec 20, 2012 at 12:09:45AM +0100, Christophe TORDEUX wrote: > From: Christophe TORDEUX > > Apply the following change to the Sentelic touchpad driver: > report only the position of the first finger as absolute non-MT > coordinates, instead of reporting both fingers alternatively. Actual

Re: [PATCH] RFC: input: Extend matrix-keypad device tree binding

2012-12-20 Thread Dmitry Torokhov
Hi Simon, On Thu, Dec 20, 2012 at 12:23:58PM -0800, Simon Glass wrote: > > For the key repeat feature, we need to set this after the input device > is registered. So we would need to add a matrix_keypad_setup_input() or > similar to be called by the driver after input_register_device(). I am > le

Re: [PATCH 17/25] wm97xx: don't use [delayed_]work_pending()

2012-12-23 Thread Dmitry Torokhov
ng tests from wm97xx. Instead of testing > work_pending(), use the return value of queue_work() to decide whether > to disable IRQ or not. > > Only compile tested. > > Signed-off-by: Tejun Heo > Cc: Mark Brown > Cc: Liam Girdwood > Cc: linux-in...@vger.kernel.org &g

Re: [RFC] staging: ste_rmi4: merge into the main kernel tree

2012-11-15 Thread Dmitry Torokhov
Hi Linus, On Thu, Nov 15, 2012 at 06:41:26PM +0100, Linus Walleij wrote: > On Thu, Nov 15, 2012 at 7:43 AM, Dmitry Torokhov > wrote: > > > In this case you need to enumerate the benefits of this driver over > > unified driver and show why the unified driver can't be

Re: [RFC] staging: ste_rmi4: merge into the main kernel tree

2012-11-16 Thread Dmitry Torokhov
On Friday, November 16, 2012 09:02:30 AM Alexandra Chin wrote: > Hi Dmitry, > > > > > Please have Greg commit the patch that Henrik reviewed to staging and > > > > then work with Christopher Heiny group on getting the full featured > > > > driver into mainline. > > Thanks for your reminding, fina

Re: 3.7-rc3: mouses stopped working

2012-11-18 Thread Dmitry Torokhov
> > Yes, it works for me properly (testing with rc4+, 1b42fc4 more precisely). > Even after disconnect/reconnect cycle of USB mouse, I am getting events > properly from /dev/input/mice (frankly I am surprised that you noticed ... > Xorg has been using evdev driver for ages already b

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-11-18 Thread Dmitry Torokhov
from the keyreset driver submitted by Arve Hjønnevåg in the Android kernel. Signed-off-by: Mathieu Poirier Signed-off-by: Dmitry Torokhov --- drivers/tty/sysrq.c | 114 +++ 1 file changed, 114 insertions(+) diff --git a/drivers/tty/sysrq.c b/dr

Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option

2012-11-19 Thread Dmitry Torokhov
On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > it as on option code paths that check CONFIG_HOTPLUG will removed > along with the attributes __devexit_p, __devexit, __devinitconst, and > __devinitdata. > > I'

Re: [PATCH 2/2] input: Cypress PS/2 Trackpad link into psmouse-base

2012-11-19 Thread Dmitry Torokhov
Hi Kamal, On Mon, Nov 19, 2012 at 03:30:37PM -0800, Kamal Mostafa wrote: > @@ -321,6 +323,13 @@ static irqreturn_t psmouse_interrupt(struct serio *serio, > if (psmouse->state <= PSMOUSE_RESYNCING) > goto out; > > + /* For Cypress Trackpad to read some special data more th

Re: [PATCH 3/3] input:stmpe-ts:Initialize the phys field for input device

2012-11-19 Thread Dmitry Torokhov
On Tue, Nov 20, 2012 at 12:28:08PM +0530, Viresh Kumar wrote: > On 9 November 2012 20:57, Viresh Kumar wrote: > > From: Vipul Kumar Samar > > > > Signed-off-by: Vipul Kumar Samar > > --- > > drivers/input/touchscreen/stmpe-ts.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/driv

Re: [PATCH 2/3] Input: spear-keyboard: Add clk_{un}prepare() support

2012-11-20 Thread Dmitry Torokhov
On Tue, Nov 20, 2012 at 01:26:29PM +0530, Viresh Kumar wrote: > On 12 November 2012 11:27, Viresh Kumar wrote: > > On 8 November 2012 19:10, Viresh Kumar wrote: > >> From: Vipul Kumar Samar > >> > >> clk_{un}prepare is mandatory for platforms using common clock framework. > >> Because > >> for

[PATCH 2/3] CLK: uninline clk_prepare_enable() and clk_disable_unprepare()

2012-11-20 Thread Dmitry Torokhov
We'll need to invoke clk_disable_unprepare() via a pointer in our devm_* conversion so let's uninline the pair. Signed-off-by: Dmitry Torokhov --- drivers/clk/clk.c | 23 +++ include/linux/clk.h | 53 +++-- 2 fil

[PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare()

2012-11-20 Thread Dmitry Torokhov
We'll need to invoke clk_unprepare() via a pointer in our devm_* conversion so let's uninline the pair. Signed-off-by: Dmitry Torokhov --- drivers/clk/clk.c | 4 include/linux/clk.h | 68 + 2 files changed, 36 inserti

[RFC/PATCH 0/3] CLK: add more devm_* APIs

2012-11-20 Thread Dmitry Torokhov
Hi, When looking at recent driver conversions to managed resources (devm_*) there is no devm_clk_prepare() and similar functions, which forces mixing of 2 resource management styles (managed/classic) in the same driver, which is not great. This patch series adds more devm_* managed APIs to the CL

[PATCH 3/3] CLK: add more managed APIs

2012-11-20 Thread Dmitry Torokhov
(); - devm_clk_enable()/devm_clk_disable(); - devm_clk_preapre_enable()/devm_clk_diable_unprepare(). Signed-off-by: Dmitry Torokhov --- drivers/clk/clk-devres.c | 91 +++- include/linux/clk.h | 105 +++ 2 files changed, 177

<    1   2   3   4   5   6   7   8   9   10   >