Re: [RFC/PATCH 0/3] CLK: add more devm_* APIs

2012-11-20 Thread Dmitry Torokhov
On Tue, Nov 20, 2012 at 09:34:45AM +, Russell King - ARM Linux wrote: > On Tue, Nov 20, 2012 at 01:22:16AM -0800, Dmitry Torokhov wrote: > > Hi, > > > > When looking at recent driver conversions to managed resources (devm_*) > > there > > is no devm_clk_prepa

Re: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare()

2012-11-20 Thread Dmitry Torokhov
On Tue, Nov 20, 2012 at 09:32:42AM +, Russell King - ARM Linux wrote: > On Tue, Nov 20, 2012 at 01:22:17AM -0800, Dmitry Torokhov wrote: > > We'll need to invoke clk_unprepare() via a pointer in our devm_* > > conversion so let's uninline the pair. > > NAK. Thi

Re: [PATCH] Input: trackpoint - Optimize trackpoint init to use power-on reset

2013-04-16 Thread Dmitry Torokhov
Hi Shawn, On Tue, Apr 09, 2013 at 02:53:44PM -0700, Shawn Nematbakhsh wrote: > Hi Dmitry, > > Thanks for the review. Comments in-line. > > On Wed, Mar 27, 2013 at 10:32 PM, Dmitry Torokhov > wrote: > > Hi Shawn, > > > > On Tue, Mar 26, 2013 at 12:36

[git pull] Input updates for 3.9-rc7

2013-04-19 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive 2 more small fixups to the wacom driver. Changelog: - Ping Cheng (2): Input: wacom

Re: [PATCH 2/2] acer-wmi: add Acer Aspire 5750G to video vendor list but keep acpi video driver

2013-04-22 Thread Dmitry Torokhov
the backlight interface of acpi/video. > > Reference: bko#35622 > https://bugzilla.kernel.org/show_bug.cgi?id=35622 > > Tested-by: Andrzej Krentosz > Cc: Carlos Corbacho > Cc: Matthew Garrett > Cc: Dmitry Torokhov > Cc: Corentin Chary > Cc: Rafael J. W

Re: [PATCH 1/2] acpi: video: add function to support unregister backlight

2013-04-22 Thread Dmitry Torokhov
On Mon, Apr 22, 2013 at 08:39:15PM +0800, Chun-Yi Lee wrote: > From: "Lee, Chun-Yi" > +static acpi_status > +find_video_unregister_backlight(acpi_handle handle, u32 lvl, void *context, > + void **rv) > +{ > + struct acpi_device *acpi_dev; > + struct acpi_video_b

Re: [PATCH] input: egalax_ts: remove bogus OF dependency

2013-04-23 Thread Dmitry Torokhov
On Tue, Apr 23, 2013 at 02:09:17PM +0300, Artem Bityutskiy wrote: > There are platforms using this driver which do not have OF. However, commit > ae495e844a77344fdaedbb2ad97d925d096e9f0d added a Kconfig dependency on OF and > broke OF-less setups. > > Signed-off-by: Artem Bityutskiy > Cc: sta...@

Re: eGalax touchscreen regression

2013-04-23 Thread Dmitry Torokhov
il.com: Make driver depend on CONFIG_OF as it is > now required.] > > Acked-by Zhang Jiejing > Reviewed-by: Shawn Guo > Signed-off-by: Hui Wang > Signed-off-by: Dmitry Torokhov > > the eGalax driver now requires OF. For us this is a regression because > we d

Re: [PATCH V2 4/5] input: pxa27x-keypad: remove the unused members at platform data

2013-06-17 Thread Dmitry Torokhov
On Monday, June 17, 2013 03:10:27 PM Arnd Bergmann wrote: > On Sunday 05 May 2013 23:04:07 Chao Xie wrote: > > Now pxa27x-keypad make use matrix_keymap for matrix keyes, so > > remove the unused members in platform data. > > > > Signed-off-by: Chao Xie > > --- > > > > include/linux/platform_dat

[git pull] Input updates for 3.10-rc4

2013-06-04 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem: just a 2 small driver fixups here. Changelog: - Eric Mi

Re: [PATCH 10/53] Input: atmel_mxt_ts - Add memory access interface via sysfs

2013-06-05 Thread Dmitry Torokhov
Hi Nick, On Wednesday, June 05, 2013 06:37:03 PM Nick Dyer wrote: > Atmel maXTouch chips can be addressed via an "Object Based Protocol" which > defines how i2c registers are mapped to different functions within the > chips. This interface exposes the register map and allows user-space > utilities

Re: [PATCH 10/53] Input: atmel_mxt_ts - Add memory access interface via sysfs

2013-06-05 Thread Dmitry Torokhov
On Wednesday, June 05, 2013 07:45:04 PM Nick Dyer wrote: > Dmitry Torokhov wrote: > > On Wednesday, June 05, 2013 06:37:03 PM Nick Dyer wrote: > >> Atmel maXTouch chips can be addressed via an "Object Based Protocol" > >> which > >> defines how i

Re: [PATCH 10/53] Input: atmel_mxt_ts - Add memory access interface via sysfs

2013-06-05 Thread Dmitry Torokhov
On Wed, Jun 05, 2013 at 09:31:39PM +0100, Nick Dyer wrote: > Dmitry Torokhov wrote: > >> We have made a deliberate choice to implement this via sysfs rather than > >> debugfs since it needs to work on devices that don't have debugfs enabled. > > > >

Re: Atmel updates to atmel_mxt_ts touch controller driver - v5 Daniel Kurtz , Henrik Rydberg , Joonyoung Shim , alan.bow...@atmel.co

2013-06-06 Thread Dmitry Torokhov
On Wed, Jun 05, 2013 at 06:36:53PM +0100, Nick Dyer wrote: > The following patches are an updated series of patches to the atmel_mxt_ts > touch driver. They should apply cleanly to input/next. > > This is a combined patchset, I've been working to merge my changes with the > changes from the Chromi

Re: Atmel updates to atmel_mxt_ts touch controller driver - v5 Daniel Kurtz , Henrik Rydberg , Joonyoung Shim , alan.bow...@atmel.co

2013-06-06 Thread Dmitry Torokhov
On Thu, Jun 06, 2013 at 03:40:47PM -0400, Yufeng Shen wrote: > On Thu, Jun 6, 2013 at 3:18 PM, Dmitry Torokhov > wrote: > > > On Wed, Jun 05, 2013 at 06:36:53PM +0100, Nick Dyer wrote: > > > The following patches are an updated series of patches to the > > atmel_m

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-05-31 Thread Dmitry Torokhov
Hi Hebbar, On Fri, May 31, 2013 at 03:43:00PM +0530, Hebbar Gururaja wrote: > By optionally putting the pins into sleep state in the suspend [or in > runtime_suspend] callback we can accomplish two things. > - One is to minimize current leakage from pins and thus save power, > - second, we can pre

Re: [PATCH] Add TI-Nspire keypad support

2013-06-02 Thread Dmitry Torokhov
t; +#define KEYPAD_INT 0x08 > +#define KEYPAD_INTMSK0x0C > + > +#define KEYPAD_DATA 0x10 > +#define KEYPAD_GPIO 0x30 > + > +#define KEYPAD_UNKNOWN_INT 0x40 > +#define KEYPAD_UNKNOWN_INT_STS 0x44 > + > +#define KEYPAD_BITMAS

[git pull] Input updates for 3.10-rc4

2013-06-23 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. You will get a few small fixups for cyttsp, wacom and xpad driver

Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

2013-06-09 Thread Dmitry Torokhov
Hi Manish, On Tue, May 21, 2013 at 02:24:17PM +0530, Vishwanathrao Badarkhe, Manish wrote: > Add device tree based support for TI's tps6507x touchscreen. > > Tested on da850-evm. > > Signed-off-by: Vishwanathrao Badarkhe, Manish > --- > Changes since V2: > - Removed unnecessary code. > - Upda

Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

2013-06-10 Thread Dmitry Torokhov
Manish, On Mon, Jun 10, 2013 at 10:23:16AM +, Vishwanathrao Badarkhe, Manish wrote: > Hi Dmitry, > > On Mon, Jun 10, 2013 at 11:34:42, Dmitry Torokhov wrote: > > Hi Manish, > > > > On Tue, May 21, 2013 at 02:24:17PM +0530, Vishwanathrao Badarkhe, Manish >

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Dmitry Torokhov
Hi Samuel, On Tue, Jun 11, 2013 at 04:23:58PM +0200, Samuel Ortiz wrote: > Hi Sebastian, > > On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior wrote: > > I believe the whole thing should go via the MFD tree. It touches also > > input & iio subsystem. I collected ACKs where I got

[git pull] Input updates for 3.11-rc0

2013-07-04 Thread Dmitry Torokhov
flush queues during EVIOCGKEY-like ioctls Dmitry Torokhov (8): Input: pxa27x-keypad - convert to using SIMPLE_DEV_PM_OPS Input: pxa27x-keypad - make platform data const Input: tps6507x-ts - use bool for booleans Input: tps6507x-ts - remove vref from platform data Input: tps

Re: [PATCH 22/51] Input: atmel_mxt_ts - Add shutdown function

2013-07-06 Thread Dmitry Torokhov
Hi Nick, On Thu, Jun 27, 2013 at 01:48:57PM +0100, Nick Dyer wrote: > Signed-off-by: Nick Dyer > Acked-by: Benson Leung Why is this needed? Thanks. > --- > drivers/input/touchscreen/atmel_mxt_ts.c |8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/input/touchscreen/

Re: [PATCH 26/51] Input: atmel_mxt_ts - Move input device init into separate function

2013-07-06 Thread Dmitry Torokhov
On Thu, Jun 27, 2013 at 01:49:01PM +0100, Nick Dyer wrote: > Signed-off-by: Nick Dyer So before we allocated input device before requesting IRQ, now we fo it afterwards so there is moment where the interrupt is requested and not disabled and input device is not allocated yet. Is it possible for i

Re: [PATCH v2 1/2] input: document gamepad API and add extra keycodes

2013-06-26 Thread Dmitry Torokhov
0x130 > +#define BTN_SOUTH0x130 Could we do: #define BTN_SOUTH 0x130 #define BTN_A BTN_SOUTH so that it is clear that BTN_A, BTN_B, etc are legacy definitions and not an accidental typos that need their own key codes. Otherwise: Acke

Re: [PATCH 0/2] Support for 2013 Macbook Air

2013-06-30 Thread Dmitry Torokhov
On Sun, Jun 30, 2013 at 09:04:44PM +0200, rydb...@euromail.se wrote: > Hi Dmitry, Jiri, > > Please find enclosed two patches yielding support for the > MacbookAir6,2. As usual, there is one HID and one Input patch. Given > the closeness to the merge window, I suppose we could backport this to > 3.

Re: [PATCH 28/29] drivers/input/{keyboard,serio}: simplify use of devm_ioremap_resource

2013-08-15 Thread Dmitry Torokhov
On Wed, Aug 14, 2013 at 04:51:02PM +0530, Viresh Kumar wrote: > On Wed, Aug 14, 2013 at 4:33 PM, Julia Lawall wrote: > > From: Julia Lawall > > > > Remove unneeded error handling on the result of a call to > > platform_get_resource when the value is passed to devm_ioremap_resource. > > > > Move t

Re: [PATCH v5 1/1] input: ideapad_slidebar: new input driver

2013-08-15 Thread Dmitry Torokhov
Hi Andrey, On Mon, Aug 12, 2013 at 02:23:23PM +0400, Andrey Moiseev wrote: > v5: __initconst goes after var name > > ideapad_slidebar is a new driver which enables slidebars on some > Lenovo IdeaPad laptops (the slidebars work with SlideNav/Desktop > Navigator under Windows) > > Fixes this: http

Re: Atmel updates to atmel_mxt_ts touch controller driver - v6

2013-08-15 Thread Dmitry Torokhov
On Thu, Aug 15, 2013 at 04:55:57PM +0100, Nick Dyer wrote: > rydb...@euromail.se wrote: > > First: thanks for the patches and you work on this driver. > > Thank you for your time in looking at these changes. > > > Now, I don't swear much, but I would like to emphasize line 161 of > > Documentatio

Re: [PATCH v6 1/1] input: ideapad_slidebar: new input driver

2013-08-15 Thread Dmitry Torokhov
Hi Andrey, On Thu, Aug 15, 2013 at 07:06:39PM +0400, Andrey Moiseev wrote: > v6: fixed things addressed by Dmitry Torokhov to v5 (quoted message goes > below the patch) Thank you for making chnages, however I have still more comments. > > ideapad_slidebar is a new driver w

Re: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-29 Thread Dmitry Torokhov
On Monday, July 29, 2013 09:04:41 PM Felipe Balbi wrote: > Hi, > > On Mon, Jul 29, 2013 at 07:45:09PM +0300, Illia Smyrnov wrote: > > Enable/disable IRQ wake in suspend/resume handlers > > to make the keypad wakeup capable. > > > > Signed-off-by: Illia Smyrnov > > --- > > > > drivers/input/key

Re: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-29 Thread Dmitry Torokhov
On Monday, July 29, 2013 10:13:24 PM Felipe Balbi wrote: > Hi, > > On Mon, Jul 29, 2013 at 11:59:45AM -0700, Dmitry Torokhov wrote: > > > > @@ -439,12 +444,50 @@ static const struct of_device_id > > > > omap_keypad_dt_match[] = {> > > > > >

Re: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-29 Thread Dmitry Torokhov
On Monday, July 29, 2013 11:36:05 PM Felipe Balbi wrote: > Hi, > > On Mon, Jul 29, 2013 at 12:59:23PM -0700, Dmitry Torokhov wrote: > > > > > > @@ -439,12 +444,50 @@ static const struct of_device_id > > > > > > omap_keypad_dt_match[] = {>

Re: [PATCH 1/2] input: ti_tsc: Enable shared IRQ for TSC

2013-08-05 Thread Dmitry Torokhov
On Sun, Aug 04, 2013 at 12:08:11PM +0100, Jonathan Cameron wrote: > On 07/27/13 00:51, Zubair Lutfullah wrote: > > From: "Patil, Rachna" > > > > Touchscreen and ADC share the same IRQ line from parent MFD core. > > Previously only Touchscreen was interrupt based. > > With continuous mode support

Re: [PATCH 1/2] input: ti_tsc: Enable shared IRQ for TSC

2013-08-05 Thread Dmitry Torokhov
On Mon, Aug 05, 2013 at 06:02:02PM +0100, Zubair Lutfullah : wrote: > On Mon, Aug 05, 2013 at 09:12:56AM -0700, Dmitry Torokhov wrote: > > > > Touchscreen and ADC share the same IRQ line from parent MFD core. > > > > Previously only Touchscreen was interrupt based. &

Re: [PATCH v7 1/1] input: ideapad_slidebar: new input driver

2013-08-20 Thread Dmitry Torokhov
Hi Andrey, On Fri, Aug 16, 2013 at 10:58:45AM +0400, Andrey Moiseev wrote: > v7: fixed things addressed by Dmitry Torokhov to v7 (quoted message goes > below the patch) > This looks almost perfect, I have just one question: > +static bool slidebar_i8042_filter(unsigned char da

Re: [PATCH] mc13xxx-ts: use zero as default value if no pdata was defined

2013-08-20 Thread Dmitry Torokhov
On Tue, Aug 20, 2013 at 11:34:32AM +0200, Michael Grzeschik wrote: > On Tue, Aug 20, 2013 at 03:34:33AM +0200, Samuel Ortiz wrote: > > Hi Michael, > > > > On Tue, Aug 13, 2013 at 02:14:30PM +0200, Michael Grzeschik wrote: > > > In case of devicetree, we currently don't have a way to append pdata f

Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

2013-08-21 Thread Dmitry Torokhov
Hi Manish, On Tue, Aug 20, 2013 at 12:25:32PM +0530, Manish Badarkhe wrote: > Hi Prabhakar, > > On Tue, Aug 20, 2013 at 11:44 AM, Prabhakar Lad > > > > All the three above properties as per the documentation above > > are optional, but the code here makes them required property. > > May be what

Re: [PATCH v2 1/1] input: ideapad_slidebar: new input driver

2013-08-07 Thread Dmitry Torokhov
Hi Andrey, On Wed, Aug 07, 2013 at 03:25:34PM +0400, Andrey Moiseev wrote: > +/* Keyboard handler */ > +static irq_handler_t kbd_irq_handler(int irq, void *dev_id, > +struct pt_regs *regs) > +{ > +/* Scancodes: e03b on move, bb on release */ > +int scancode = inb(0x60);

Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

2013-08-08 Thread Dmitry Torokhov
On Thu, Aug 08, 2013 at 10:41:20PM +0530, Laxman Dewangan wrote: > On Wednesday 07 August 2013 12:58 AM, Stephen Warren wrote: > >(CC'ing DT bindings maintainers too, hence quoting a bit of the patch) > > > >On 08/06/2013 08:12 AM, Laxman Dewangan wrote: > >>Many of Key device tree bindings uses th

Re: [ 37/72] Input: bcm5974 - add support for the 2013 MacBook Air

2013-07-18 Thread Dmitry Torokhov
Greg, On Thu, Jul 18, 2013 at 10:25:54PM -0700, Greg Kroah-Hartman wrote: > 3.10-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Dmitry Torokhov Any chance you could change this to read "Henrik Rydberg"? My imp

Re: [PATCH][v3.2.y][v3.5.y][3.8.y] Input: elantech - fix for newer hardware versions (v7)

2013-07-19 Thread Dmitry Torokhov
Hi Joseph, On Fri, Jul 19, 2013 at 05:50:25PM -0400, Joseph Salisbury wrote: > Hello, > > Please consider including upstream commit > 9eebed7de660c0b5ab129a9de4f89d20b60de68c in the next v3.2.y, v3.5.y and > v3.8.y releases. > > It was included upstream as of v3.11-rc1. It has been tested and

Re: [ 37/72] Input: bcm5974 - add support for the 2013 MacBook Air

2013-07-21 Thread Dmitry Torokhov
On Sunday, July 21, 2013 06:42:03 PM Greg Kroah-Hartman wrote: > On Thu, Jul 18, 2013 at 10:44:45PM -0700, Greg Kroah-Hartman wrote: > > On Thu, Jul 18, 2013 at 10:40:40PM -0700, Dmitry Torokhov wrote: > > > Greg, > > > > > > On Thu, Jul 18, 2013 at 10:25:

Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

2013-08-12 Thread Dmitry Torokhov
On Thu, Aug 08, 2013 at 11:25:27AM -0600, Stephen Warren wrote: > On 08/08/2013 11:13 AM, Dmitry Torokhov wrote: > > On Thu, Aug 08, 2013 at 10:41:20PM +0530, Laxman Dewangan wrote: > >> On Wednesday 07 August 2013 12:58 AM, Stephen Warren wrote: > >>> (CC'ing

Re: [PATCH] mc13xxx-ts: use zero as default value if no pdata was defined

2013-08-13 Thread Dmitry Torokhov
Hi Michael, On Tue, Aug 13, 2013 at 02:14:30PM +0200, Michael Grzeschik wrote: > In case of devicetree, we currently don't have a way to append pdata for > the touchscreen. The current approach is to bail out in that case. > This patch makes it possible to probe the touchscreen without pdata > and

Re: [PATCH V2 0/5] input: pxa27x-keypad: enhancement and device tree support

2013-05-14 Thread Dmitry Torokhov
Hi Chao, On Mon, May 13, 2013 at 04:02:07PM +0800, Chao Xie wrote: > hi, dmitry > What is your idea about these patches? > Do i need add someone else to review them? > No, they look good, give me a couple more days but I should apply them. I am going to fold the first 4 into one patch though. >

Re: [PATCH] input: cros_ec_keyb_clear_keyboard() depends on CONFIG_PM_SLEEP

2013-05-14 Thread Dmitry Torokhov
but not used > > > > Move the definition of cros_ec_keyb_clear_keyboard() inside the section > > protected by #ifdef CONFIG_PM_SLEEP to fix this. > > > > Signed-off-by: Geert Uytterhoeven > > Acked-by: Simon Glass Acked-by: Dmitry Torokhov Could you please f

Re: [PATCH] Input: MT - handle semi-mt devices in core

2013-04-07 Thread Dmitry Torokhov
On Sun, Apr 07, 2013 at 09:41:32PM +0200, Henrik Rydberg wrote: > Most semi-mt drivers use the slots in a manual way, but really only > need to treat the finger count manually. With this patch, a semi-mt > driver may use the input-mt core for everything else. > > Signed-off-by: Henrik Rydberg Ap

[git pull] Input updates for 3.9-rc0

2013-05-01 Thread Dmitry Torokhov
): Input: add support for GRLIB APBPS2 PS/2 Keyboard/Mouse Dmitry Torokhov (7): devres: allow adding custom actions to the stack Input: auo-pixcir-ts - switch to using managed resources Input: add new keycodes for passenger control units Input: add IMS Passenger Control Unit

Re: Lenovo Yoga 13 touchpad regression

2013-05-07 Thread Dmitry Torokhov
On Tuesday, May 07, 2013 04:02:40 PM H. Peter Anvin wrote: > On 05/07/2013 11:43 AM, H. Peter Anvin wrote: > > What is really bizarre is that some time today the touchpad > > spontaneously started to work. However, after a reboot it no longer > > worked again. This is on 3.8.11. The keycode spew

Re: [PATCH 1/6] input: pxa27x-keypad: copy members of platform data to device private data

2013-04-24 Thread Dmitry Torokhov
Hi Chao, On Tue, Apr 23, 2013 at 11:20:28PM -0400, Chao Xie wrote: > Original driver will directly use platform data when driver is > running. > In fact, the platform data may be freed after system is bootup, This statement is not correct, the platform data should be never be freed, otherwise one

Re: [PATCH] VSOCK: Fix misc device registration

2013-04-24 Thread Dmitry Torokhov
90 > [ 405.470690] sysfs: cannot create duplicate filename '/dev/char/10:54' > > Always set vsock_device.minor to MISC_DYNAMIC_MINOR before we > register. > > Cc: "David S. Miller" > Cc: Andy King > Cc: Dmitry Torokhov > Cc: Reilly Grant > Cc: net

Re: eGalax touchscreen regression

2013-04-26 Thread Dmitry Torokhov
On Fri, Apr 26, 2013 at 06:09:05PM +0300, Artem Bityutskiy wrote: > On Fri, 2013-04-26 at 16:59 +0200, Arnd Bergmann wrote: > > On Wednesday 24 April 2013 12:03:13 Artem Bityutskiy wrote: > > > On Tue, 2013-04-23 at 08:40 -0700, Dmitry Torokhov wrote: > > > > >

Re: [NEW DRIVER V4 0/7] DA9058 PMIC - please comment on this new driver

2013-04-12 Thread Dmitry Torokhov
On Friday, April 12, 2013 02:05:29 PM Anthony Olech wrote: > This is submission attempt number 4 to have this driver included in > the linux kernel source tree. This is the driver for the Dialog DA9058. > > The DA9058 is a low power Power Management Integrated Circuit with extra > functionality. I

Re: [PATCH] input: Export matrix_keypad_parse_of_params()

2013-04-15 Thread Dmitry Torokhov
ms" > [drivers/input/keyboard/cros_ec_keyb.ko] undefined! > > Reported-by: Randy Dunlap > Signed-off-by: Michal Marek Acked-by: Dmitry Torokhov This is coming through some other tree though so you 'll have to track it down. Thanks. > --- > drivers/input/matrix-keymap.c

[git pull] Input updates for 3.9-rc7

2013-04-15 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive 2 small fixups to the Wacom driver. Changelog: - Jason Gerecke (2): Input: wacom -

Re: Regmap and register ranges

2013-05-17 Thread Dmitry Torokhov
On Fri, May 17, 2013 at 09:50:25PM +0100, Mark Brown wrote: > On Fri, May 17, 2013 at 09:24:30AM -0700, Dmitry Torokhov wrote: > > > I am looking at regmap and I wonder if I am missing something with the > > way it checks if a window crosses another range boundary or if a >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-20 Thread Dmitry Torokhov
> You Acked that commit :( > > > > At a glance, the only way to drive the vmw_vmci device is through > > net/vmw_vsock/vmci_transport.c, so without NET it's useless? But let's > > keep it neat anyway. This was compiletested with CONFIG_VMCI, > > CON

[git pull] Input updates for 3.10-rc2

2013-05-23 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. You will get a few fixups to Wacom and eGalax touchscreen driver.

Re: [PATCH 1/7] input: ep93xx_keypad: Pass correct pointer to free_irq()

2013-05-23 Thread Dmitry Torokhov
On Mon, May 20, 2013 at 10:49:00AM -0500, H Hartley Sweeten wrote: > On Monday, May 20, 2013 7:51 AM, Lars-Peter Clausen wrote: > > free_irq() expects the same pointer that was passed to request_irq(), > > otherwise > > the IRQ is not freed. > > > > > Cc: H Hartley Sweeten > > Signed-off-by: L

Re: [PATCH] Input: trackpoint - Optimize trackpoint init to use power-on reset

2013-03-27 Thread Dmitry Torokhov
Hi Shawn, On Tue, Mar 26, 2013 at 12:36:41PM -0700, Shawn Nematbakhsh wrote: > The trackpoint driver sets various parameter default values, all of > which happen to be power-on defaults (Source: IBM TrackPoint Engineering > Specification, Version 4.0. Also confirmed by empirical data). > > By sen

Re: [PATCH 1/1] Input: mma8450 - fix signed 12bits to 32bits conversion

2013-03-27 Thread Dmitry Torokhov
Hi Seb, On Wed, Mar 27, 2013 at 09:17:43AM +0100, seb wrote: > Event value is wrong. Should be in range -2048 to 2047, but is in range 0 to > 4095. > Use int8_t to int conversion and remove 0xfff mask. > > Signed-off-by: seb > --- > drivers/input/misc/mma8450.c | 15 ++- > 1 file

Re: [PATCH 1/1] Input: mma8450 - fix signed 12bits to 32bits conversion

2013-03-28 Thread Dmitry Torokhov
On Thu, Mar 28, 2013 at 08:36:52AM +0100, Sebastien Royen wrote: > Hi Dmitry > > 2013/3/28 Dmitry Torokhov > > > > Hi Seb, > > > > On Wed, Mar 27, 2013 at 09:17:43AM +0100, seb wrote: > > > Event value is wrong. Should be in range -2048 to 2047, but is i

Re: [PATCH 1/1] Input: mma8450 - fix signed 12bits to 32bits conversion

2013-03-31 Thread Dmitry Torokhov
On Thu, Mar 28, 2013 at 03:16:29PM +0100, Sebastien Royen wrote: > From: seb > > Event value is wrong. Should be in range -2048 to 2047, but is in range 0 to > 4095. > Use s8 to int conversion and remove 0xfff mask. > > Signed-off-by: Sebastien Royen Applied, thank you Sebastien. > --- > dr

Re: [PATCH] Input: arc_ps2 - add support for device tree

2013-03-31 Thread Dmitry Torokhov
On Thu, Mar 28, 2013 at 10:46:26AM +0100, Mischa Jonker wrote: > Add match table for device tree binding and dts binding doc. > > Signed-off-by: Mischa Jonker Applied, thank you Mischa. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: [PATCH V2] input: keyboard: tegra: support for defining row/columns based on SoC

2013-03-31 Thread Dmitry Torokhov
On Wed, Mar 13, 2013 at 10:44:33PM +0530, Laxman Dewangan wrote: > NVIDIA's Tegra20 and Tegra30 supports the 16x8 keyboard matrix and T114 > support the 11x8 Key matrix. > > Add support for defining the maximum row/columns based on SoC through > proper compatibity. > > Signed-off-by: Laxman Dewan

Re: [PATCH 17/25] wm97xx: don't use [delayed_]work_pending()

2013-03-09 Thread Dmitry Torokhov
On Mon, Dec 24, 2012 at 04:18:27PM +, Mark Brown wrote: > On Sun, Dec 23, 2012 at 01:54:50AM -0800, Dmitry Torokhov wrote: > > > This is not 100% equivalent transformation as now we schedule first and > > disable IRQ later... Anyway, I think the driver shoudl be converted t

[git pull] Input updates for 3.9-rc2

2013-03-10 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Except for the largish change to the ALPS driver adding "Dolphin

Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots

2012-08-06 Thread Dmitry Torokhov
Hi Lee, On Mon, Aug 06, 2012 at 01:32:03PM +0100, Lee Jones wrote: > If we're booting with Device Tree enabled, we want the IRQ numbers to > be taken and translated from the Device Tree binary. If not, they > should be taken from the resource allocation defined in the AB8500 MFD > core driver. >

Re: [RFC ebeam PATCH v3 1/2] hid: Blacklist new eBeam classic device

2012-08-06 Thread Dmitry Torokhov
On Monday, August 06, 2012 02:43:40 PM Greg KH wrote: > On Mon, Aug 06, 2012 at 11:21:43PM +0200, Yann Cantin wrote: > > Signed-off-by: Yann Cantin > > --- > > > > drivers/hid/hid-core.c |3 +++ > > drivers/hid/hid-ids.h |3 +++ > > 2 files changed, 6 insertions(+) > > > > diff --git a

Re: [RFC ebeam PATCH v3 0/2]

2012-08-06 Thread Dmitry Torokhov
On Monday, August 06, 2012 02:44:23 PM Greg KH wrote: > On Mon, Aug 06, 2012 at 11:21:42PM +0200, Yann Cantin wrote: > > Hi, > > > > New USB input driver for eBeam devices. > > > > Currently, only the Luidia eBeam classic projection model is supported. > > Edge model and a NEC interactive video-p

Re: [RFC ebeam PATCH v3 2/2] input: misc: New USB eBeam input driver.

2012-08-06 Thread Dmitry Torokhov
On Tue, Aug 07, 2012 at 02:56:40AM +0200, Yann Cantin wrote: > Hi, > > Le 06/08/2012 23:43, Greg KH a écrit : > > On Mon, Aug 06, 2012 at 11:21:44PM +0200, Yann Cantin wrote: > >> > >> Signed-off-by: Yann Cantin > >> --- > >> drivers/input/misc/ebeam.c | 764 > >> ++

Re: [RFC ebeam PATCH v3 1/2] hid: Blacklist new eBeam classic device

2012-08-06 Thread Dmitry Torokhov
On Tue, Aug 07, 2012 at 03:21:45AM +0200, Yann Cantin wrote: > Le 07/08/2012 00:07, Dmitry Torokhov a écrit : > > On Monday, August 06, 2012 02:43:40 PM Greg KH wrote: > >> On Mon, Aug 06, 2012 at 11:21:43PM +0200, Yann Cantin wrote: > >>> Signed-off-by: Yann Cantin

Re: [PATCH] Input: Let the FT5x06 driver build without debugfs

2012-08-21 Thread Dmitry Torokhov
On Mon, Aug 20, 2012 at 06:53:03AM -0700, Guenter Roeck wrote: > On Fri, Aug 17, 2012 at 12:21:34PM -0700, Eric W. Biederman wrote: > > Simon Budig writes: > > > > > On 08/17/2012 02:15 AM, Eric W. Biederman wrote: > > >> When testing to make certain my user namespace code works in > > >> various

Re: [NEW DRIVER V3 3/8] DA9058 ONKEY driver

2012-08-21 Thread Dmitry Torokhov
On Wed, Aug 15, 2012 at 04:05:22PM +0100, Anthony Olech wrote: > This is the ONKEY component driver of the Dialog DA9058 PMIC. > This driver is just one component of the whole DA9058 PMIC driver. > It depends on the CORE component driver of the DA9058 MFD. > > Signed-off-by: Anthony Olech > Signe

Re: [RFC PATCH 1/17] input: RMI4 public header file and documentation.

2012-08-22 Thread Dmitry Torokhov
On Wednesday, August 22, 2012 09:08:00 PM Linus Walleij wrote: > On Sat, Aug 18, 2012 at 12:17 AM, Christopher Heiny > wrote: > > > +/* Helper fn to convert a byte array representing a short in the RMI > > + * endian-ness to a short in the native processor's specific endianness. Is RMI-endiannes

Re: Input and HID updates for 3.7, version 4

2012-09-19 Thread Dmitry Torokhov
On Tue, Sep 18, 2012 at 06:19:56PM +0200, Henrik Rydberg wrote: > On Tue, Sep 18, 2012 at 01:29:29PM +0200, Jiri Kosina wrote: > > On Sat, 15 Sep 2012, Henrik Rydberg wrote: > > > > > Ok, here is version 4 of the patchset. Rather than sending out all the > > > patches again, the diff to linux-next

Re: [PATCH 20/24] input: rpcmouse: use __iomem pointers for MMIO

2012-09-19 Thread Dmitry Torokhov
On Fri, Sep 14, 2012 at 11:34:48PM +0200, Arnd Bergmann wrote: > ARM is moving to stricter checks on readl/write functions, > so we need to use the correct types everywhere. > > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Signed-off-by: Arnd Bergmann Acked-b

Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots

2012-09-19 Thread Dmitry Torokhov
On Tue, Sep 18, 2012 at 01:22:06PM +0200, Linus Walleij wrote: > On Fri, Sep 14, 2012 at 10:03 AM, Lee Jones wrote: > > On Thu, Sep 13, 2012 at 11:35:43AM +0200, Linus Walleij wrote: > >> > >> Not having this patch in v3.6-rcN gives the following boot noise (and > >> the key does not work): > >> >

[git pull] Input updates for 3.6-rc7

2012-09-20 Thread Dmitry Torokhov
. Changelog: - Anisse Astier (1): Input: i8042 - disable mux on Toshiba C850D Axel Lin (1): Input: edt-ft5x06 - return -EFAULT on copy_to_user() error Dmitry Torokhov (1): Revert "input: ab8500-ponkey: Create AB8500 domain IRQ mapping" Fabio Estevam (1):

Re: [PATCH] Input: omap4-keypad - don't leak in omap4_keypad_probe()

2012-08-08 Thread Dmitry Torokhov
On Wednesday, August 08, 2012 09:36:51 PM Jesper Juhl wrote: > On Wed, 8 Aug 2012, Sachin Kamat wrote: > > On 7 August 2012 23:46, Jesper Juhl wrote: > > > If omap4_keypad_parse_dt() does not return 0 (zero) in > > > omap4_keypad_probe() we will leak the memory we allocated for > > > 'keypad_data'

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Dmitry Torokhov
On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: > On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: > > Many MT devices send a number of keys along with the mt information. > > This patch makes sure that there is room for them in the packet > > buffer. > > > > Signed-off-by: Henrik

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Dmitry Torokhov
On Tue, Aug 14, 2012 at 01:50:38PM -0700, Ping Cheng wrote: > On Tue, Aug 14, 2012 at 12:53 PM, Dmitry Torokhov > wrote: > > On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: > >> On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg > >> wrote: > >>

[git pull] Input updates for 2.6.25-rc0

2008-02-05 Thread Dmitry Torokhov
(1): Input: add Tosa keyboard driver Dmitry Torokhov (10): Input: Add proper locking when changing device's keymap Input: keyspan_remote - add support for loadable keymaps Input: atlas_btns - add support for loadable keymaps Input: cobalt_btns - add support for loadable

Re: [git pull] Input updates for 2.6.25-rc0

2008-02-05 Thread Dmitry Torokhov
On Wednesday 06 February 2008 01:32, Andrew Morton wrote: > > Looks OK. Minorish things from a quick scan: > > > > tosakbd_scankeyboard() looks like it'll spend a perfectly wicked amount of > time under spin_lock_irqsave(). > I think you are right. I will check with Dmitry if it can be relaxe

Re: [git pull] Input updates for 2.6.25-rc0

2008-02-06 Thread Dmitry Torokhov
On Wed, Feb 06, 2008 at 08:56:35AM +0100, Sam Ravnborg wrote: > > > > > > > > > > > > > > i8042_platform_init(): > > > > > > +#if defined(__i386__) || defined(__x86_64__) > > > > > > use #ifdef CONFIG_X86? > > > > > > > I considered it but above was tested and in line with the style of the

Re: [git pull] Input updates for 2.6.25-rc0

2008-02-07 Thread Dmitry Torokhov
On Tue, Feb 05, 2008 at 10:32:42PM -0800, Andrew Morton wrote: > > Looks OK. Minorish things from a quick scan: > *ping* Linus, Do you want me to redo the pull or is it still acceptable as is? I am hesitant touching the tree after sending a pull request... Thanks, Dmitry -- Dmitry -- To un

Re: [PATCH] input: driver for USB VoIP phones with CM109 chipset

2008-02-07 Thread Dmitry Torokhov
Hi Alfred, On Thu, Feb 07, 2008 at 07:38:10PM +0100, Alfred E. Heggestad wrote: > From: Alfred E. Heggestad <[EMAIL PROTECTED]> > > This driver adds support for USB VoIP phones using the CM109 chipset, > such as Komunikate KIP-1000 and Genius G-talk. Keypad is scanned and > events are reported to

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-07 Thread Dmitry Torokhov
Hi Mark, On Sat, Jan 26, 2008 at 05:28:31PM +, Mark Brown wrote: > + > + /* register our battery device */ > + wm->battery_dev = platform_device_alloc("wm97xx-battery", 0); > + if (!wm->battery_dev) > + goto batt_err; ... > + batt_err: > + input_unregister_device(wm

Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN

2012-07-23 Thread Dmitry Torokhov
On Thu, Jul 19, 2012 at 05:36:12PM +0200, Daniel Mack wrote: > On 17.07.2012 14:59, Daniel Mack wrote: > > On 13.07.2012 09:01, Dmitry Torokhov wrote: > >> On Wed, May 02, 2012 at 09:36:51PM -0700, Dmitry Torokhov wrote: > >>> Hi Sven, > >>> > >&

Re: [PATCH] fixed a macro coding style issue

2012-07-24 Thread Dmitry Torokhov
On Wed, Jul 25, 2012 at 01:20:56PM +0800, Baodong Chen wrote: > Fixed a coding style issue in driver/input/input.c > > Signed-off-by: Baodong Chen > --- > drivers/input/input.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/input.c b/drivers/inp

Re: [PATCH] fixed a macro coding style issue

2012-07-24 Thread Dmitry Torokhov
On Wed, Jul 25, 2012 at 07:15:12AM +0100, Al Viro wrote: > On Tue, Jul 24, 2012 at 10:37:55PM -0700, Dmitry Torokhov wrote: > > On Wed, Jul 25, 2012 at 01:20:56PM +0800, Baodong Chen wrote: > > > Fixed a coding style issue in driver/input/input.c > > > > &

[git pull] Input updates for 3.6-rc0

2012-07-25 Thread Dmitry Torokhov
of mt slots Input: atmel_mxt_ts - send all MT-B slots in one input report Input: atmel_mxt_ts - parse T6 reports Input: synaptics - print firmware ID and board number at init Dmitry Torokhov (1): Input: wacom_i2c - fix compiler warning Fabio Estevam (3): Input: imx_keypad

Re: [REPOST #3 PATCH v2] Input: atkbd - make repeat period more accurate.

2012-07-25 Thread Dmitry Torokhov
Hi George, On Sat, Jul 21, 2012 at 11:42:28PM -0400, George Spelvin wrote: > This replaces some inaccurate lookup tables with an exact > computation. Although the diff adds source comments, > it shrinks binary size. (By only 50 bytes, but hey.) > > AT keyboard repeat rates are multiples of 1/24

Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual

2012-08-21 Thread Dmitry Torokhov
child device prior to requesting an IRQ, but as we're no longer using > > > Device Tree to collect our IRQ numbers, it's actually better to allow > > > the core to do this during device registration time. So the IRQ number > > > we pull from its resource has al

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Dmitry Torokhov
On Mon, Jul 09, 2012 at 08:53:01PM +0200, Lee Jones wrote: > From: Lee Jones > Date: Tue, 26 Jun 2012 10:46:50 +0100 > Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping > > Before we can use any domain allocated IRQ, we need to first create a > map between the Hardware I

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Dmitry Torokhov
On Mon, Jul 09, 2012 at 10:35:48PM +0200, Lee Jones wrote: > From: Lee Jones > Date: Tue, 26 Jun 2012 10:46:50 +0100 > Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping > > Before we can use any domain allocated IRQ, we need to first create a > map between the Hardware I

Re: [RESEND/PATCHv5 1/2] drivers: input: keypad: Add device tree support

2012-07-09 Thread Dmitry Torokhov
se DT data if platform data is omitted. This way one can override firmware data if needed. Does the patch below (if applied on top of your) work for you? Thanks. -- Dmitry Input: omap4-keypad - misc fixes Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/omap4-keypad.c | 152 +

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Dmitry Torokhov
for button press, the other > for button depress. > > Signed-off-by: Lee Jones Acked-by: Dmitry Torokhov I think it would be best if this got merged through whatever tree that was used to introduce ab8500_irq_get_virq(); otherwise it will have to wait till I resync with mainline someti

Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-09 Thread Dmitry Torokhov
mem_region(kscandat->io_p_start, kscandat->io_p_size); > + input_unregister_device(kscandat->input); > + kfree(kscandat); > + > + return 0; > +} > + Does the following patch (on top of your) still work with your device? Thanks. -- Dmitry Input: lpc32

<    1   2   3   4   5   6   7   8   9   10   >