On Sat, Feb 25, 2017 at 01:35:51AM +0300, Dmitry V. Levin wrote:
> On Fri, Feb 24, 2017 at 05:35:33PM +0300, Alexey Dobriyan wrote:
> > On Thu, Feb 23, 2017 at 02:44:31PM -0800, a...@linux-foundation.org wrote:
> > > /usr/include/linux/sysctl.h:38:2: error: unknown
linux/reiserfs_xattr.h userspace
compilation error:
/usr/include/linux/reiserfs_xattr.h:21:2: error: unknown type name 'size_t'
size_t length;
Signed-off-by: Dmitry V. Levin
---
Perhaps the whole file could be moved out from the UAPI.
I'm not sure about that, though.
fs/r
where the numeric value
of MAX_ADDR_LEN is used, uapi/linux/if_link.h already does the same,
and there are no UAPI headers besides these two that use MAX_ADDR_LEN.
The alternative fix would be to include which
pulls in other headers and a lot of definitions with them.
Signed-off-by: Dmitry V. Levi
On Mon, Feb 27, 2017 at 05:01:55PM +0100, Nicolas Dichtel wrote:
> Le 24/02/2017 à 17:49, Nicolas Dichtel a écrit :
> > Regularly, when a new header is created in include/uapi/, the developer
> > forgets to add it in the corresponding Kbuild file. This error is usually
> > detected after the releas
Date: Thu, 19 Mar 2015 11:10:54 +
Explicitly check show_devname method return code and bail out in case
of an error. This fixes regression introduced by commit 9d4d65748a5c.
Signed-off-by: Dmitry V. Levin
---
fs/proc_namespace.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs
; to "long int"
that happens on return from sys_sparc64_personality.
For example, a userspace call personality((unsigned) -EINVAL) will
result to any subsequent personality call, including absolutely
harmless read-only personality(0x) call, failing with
errno set to EINVAL.
Signed-off-by: Dmitry V.
Check for TS_COMPAT instead of TIF_IA32 to distinguish ia32 tasks
from 64-bit tasks.
Check for __X32_SYSCALL_BIT only if CONFIG_X86_X32_ABI is defined.
Signed-off-by: Dmitry V. Levin
Cc: Elvira Khabirova
Cc: Andy Lutomirski
---
arch/x86/kernel/signal.c | 13 -
1 file changed, 8
Check for TS_COMPAT instead of TIF_IA32 to distinguish ia32 tasks
from 64-bit tasks.
Check for __X32_SYSCALL_BIT iff CONFIG_X86_X32_ABI is defined.
Signed-off-by: Dmitry V. Levin
Cc: Elvira Khabirova
Cc: Andy Lutomirski
---
v2: reintroduced __NR_restart_syscall | (regs->orig
ce changes")
Cc: Elvira Khabirova
Cc: sta...@vger.kernel.org # v2.6.28+
Signed-off-by: Dmitry V. Levin
---
arch/s390/include/asm/syscall.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/s390/include/asm/syscall.h b/arch/s390/include/asm/syscall.
and the example in ioctl_ns(2) manual page doesn't work
when e.g. it's compiled with -m32 on a 64-bit kernel.
> "Dmitry V. Levin" writes:
> > On Fri, Jul 24, 2020 at 11:20:26AM +0200, Arnd Bergmann wrote:
> >> On Fri, Jul 24, 2020 at 2:12 AM Dmitry V. Levin w
iptor")
Cc: sta...@vger.kernel.org # v4.9+
Signed-off-by: Dmitry V. Levin
---
fs/nsfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/nsfs.c b/fs/nsfs.c
index 800c1d0eb0d0..a00236bffa2c 100644
--- a/fs/nsfs.c
+++ b/fs/nsfs.c
@@ -21,6 +21,7 @@ static long ns_ioctl(struct file *filp, unsigned int
On Fri, Jul 24, 2020 at 11:20:26AM +0200, Arnd Bergmann wrote:
> On Fri, Jul 24, 2020 at 2:12 AM Dmitry V. Levin wrote:
> >
> > According to Documentation/driver-api/ioctl.rst, in order to support
> > 32-bit user space running on a 64-bit kernel, each subsystem or driver
&
Initialize pidfd to an invalid descriptor, to fail gracefully on
those kernels that do not implement CLONE_PIDFD and leave pidfd
unchanged.
Signed-off-by: Dmitry V. Levin
---
samples/pidfd/pidfd-metadata.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/samples/pidfd
Cc'ed more people as the issue is not just with the example but
with the interface itself.
On Thu, Jun 20, 2019 at 12:31:06PM +0200, Christian Brauner wrote:
> On Thu, Jun 20, 2019 at 06:11:44AM +0300, Dmitry V. Levin wrote:
> > Initialize pidfd to an invalid descriptor, to fail
On Thu, Jun 20, 2019 at 01:10:37PM +0200, Christian Brauner wrote:
> On Thu, Jun 20, 2019 at 02:00:37PM +0300, Dmitry V. Levin wrote:
> > Cc'ed more people as the issue is not just with the example but
> > with the interface itself.
> >
> > On Thu, Jun 20, 201
[looks like linux-abi is a typo, Cc'ed linux-api instead]
On Thu, May 16, 2019 at 05:50:22PM +0100, Al Viro wrote:
> [linux-abi cc'd]
>
> On Thu, May 16, 2019 at 06:31:52PM +0200, Christian Brauner wrote:
> > On Thu, May 16, 2019 at 05:22:59PM +0100, Al Viro wrote:
> > > On Thu, May 16, 2019 at 1
On Tue, Apr 25, 2017 at 01:14:26PM +0200, Michael Kerrisk (man-pages) wrote:
[...]
>The file timestamps are structures of the following type:
>
>struct statx_timestamp {
>__s64 tv_sec;/* Seconds since the Epoch (UNIX time) */
>__s32 tv_nsec;
l,
it will cause an immense confusion.
Fix this source of confusion by changing the type of struct
statx_timestamp.tv_nsec from __s32 to __u32.
Fixes: a528d35e8bfc ("statx: Add a system call to make enhanced file info
available")
Signed-off-by: Dmitry V. Levin
---
v1: fix misleading comm
all,
it will cause an immense confusion.
The best fix for this source of confusion is to change the type
of struct statx_timestamp.tv_nsec from __s32 to __u32 .
Fixes: a528d35e8bfc ("statx: Add a system call to make enhanced file info
available")
Signed-off-by: Dmitry V. Levin
---
inc
od;
Fixes: e2d1e2aec572 ("sched/headers: Move various ABI definitions to
")
Cc: sta...@vger.kernel.org # v4.12
Signed-off-by: Dmitry V. Levin
---
include/uapi/linux/sched/types.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/sc
Hi,
On Tue, Nov 14, 2017 at 07:00:19PM -0700, Tycho Andersen wrote:
> With the new SECCOMP_FILTER_FLAG_LOG, we need to be able to extract these
> flags for checkpoint restore, since they describe the state of a filter.
>
> So, let's add PTRACE_SECCOMP_GET_METADATA, similar to ..._GET_FILTER, whic
ed in 4.16-rc2, and so
> should be safe assuming it goes in before then.
>
> Reported-by: "Dmitry V. Levin"
> Signed-off-by: Tycho Andersen
> CC: Kees Cook
> CC: Oleg Nesterov
> ---
> include/uapi/linux/ptrace.h | 4 ++--
> 1 file changed, 2 insertions(+),
On Mon, Feb 26, 2018 at 12:02:25PM +0300, Pavel Emelyanov wrote:
> On 02/21/2018 03:44 AM, Andrew Morton wrote:
> > On Tue, 9 Jan 2018 08:30:49 +0200 Mike Rapoport
> > wrote:
> >
> >> This patches introduces new process_vmsplice system call that combines
> >> functionality of process_vm_read an
On Wed, Aug 09, 2017 at 09:52:41AM -0600, Jason Gunthorpe wrote:
> On Wed, Aug 09, 2017 at 04:48:08PM +0300, Moni Shoua wrote:
> > >
> > > I'm not sure this is a good idea, linux/in.h should not be included in
> > > userspace users of this file, 'sockaddr_in' needs to come from glibc's
> > > 'netin
m call flag")
Cc: sta...@vger.kernel.org
Signed-off-by: Dmitry V. Levin
---
arch/x86/entry/entry_64.S | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 4916725..3bab6af 100644
--- a/arch/x86/entry/entry_64.S
+++ b
Reported-by: Stephen Rothwell
Fixes: 9b24ec57688a ("get_compat_sigset()")
Signed-off-by: Dmitry V. Levin
---
kernel/signal.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index 3198a7d2e5ff..36a523640894 100644
--- a/kernel/signal.c
+++ b/kerne
On Wed, Sep 13, 2017 at 06:49:21PM +0200, Oleg Nesterov wrote:
> On 09/13, Dmitry V. Levin wrote:
> >
> > Before this change, CONFIG_X86_X32=y fastpath behaviour was different
> > from slowpath:
>
> and even with this change they differ if CONFIG_X86_X32=n?
No, I don&#
On Thu, Sep 14, 2017 at 07:40:43PM +, Eugene Syromyatnikov wrote:
> On Wed, Sep 13, 2017 at 4:49 PM, Oleg Nesterov wrote:
> > IOW, why do we want to silently ignore the upper bits in $rax ?
>
> By the way, they are ignored elsewhere, in audit[1] or seccomp[2], for
> example.
>
> [1] include
On Thu, Sep 14, 2017 at 02:05:04PM -0700, Andy Lutomirski wrote:
> On Tue, Sep 12, 2017 at 3:57 PM, Dmitry V. Levin wrote:
> > Before this change, CONFIG_X86_X32=y fastpath behaviour was different
> > from slowpath:
> >
> > $ gcc -xc -Wall -O2 - <<'EOF
On Thu, Sep 14, 2017 at 10:46:37PM -0700, h...@zytor.com wrote:
> On September 14, 2017 10:31:55 PM PDT, Ingo Molnar wrote:
> >
> >* Andy Lutomirski wrote:
> >
> >> >> > diff --git a/arch/x86/entry/entry_64.S
> >b/arch/x86/entry/entry_64.S
> >> >> > index 4916725..3bab6af 100644
> >> >> > --- a/a
Hi,
On Fri, Sep 08, 2017 at 09:25:45AM +1000, Stephen Rothwell wrote:
> Hi Al,
>
> After merging the vfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> kernel/signal.c: In function 'C_SYSC_rt_sigaction':
> kernel/signal.c:3405:19: warning: unused variable '
On Wed, Aug 09, 2017 at 02:25:54AM +0300, Dmitry V. Levin wrote:
> On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote:
> > It is not needed and not part of uapi headers, but causes
> > user space compilation error:
> >
> > fatal error: net/tcp.h: No such file
On Tue, Sep 05, 2017 at 10:05:00PM +0300, Alexey Dobriyan wrote:
> From: Tatsiana Brouka
>
> Implement system call for bulk retrieveing of pids in binary form.
>
> Using /proc is slower than necessary: 3 syscalls + another 3 for each thread +
> converting with atoi().
>
> /proc may be not mount
On Sun, Aug 06, 2017 at 07:22:03PM +0100, Al Viro wrote:
> On Sat, Aug 05, 2017 at 11:00:50PM +0300, Dmitry V. Levin wrote:
> > The latest change of compat_sys_sigpending has broken it in two ways.
> >
> > First, it tries to write 4 bytes more than userspace expects:
&g
set_to_compat() into put_compat_sigset() that also
calls copy_to_user().
Suggested-by: Al Viro
Signed-off-by: Dmitry V. Levin
---
arch/sparc/kernel/sys_sparc32.c | 6 +++---
include/linux/compat.h | 3 ++-
kernel/compat.c | 20 ++--
kernel/signal.c
Remove "if it's big-endian..." ifdef in compat_sigpending(),
use the endian-agnostic variant.
Suggested-by: Al Viro
Signed-off-by: Dmitry V. Levin
---
kernel/signal.c | 4
1 file changed, 4 deletions(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index a1d0426..7d9d8
As sigsetsize argument of do_sigpending() is not used anywhere else in
that function after the check, remove this argument and move the check
out of do_sigpending() into rt_sigpending() and its compat analog.
Suggested-by: Al Viro
Signed-off-by: Dmitry V. Levin
---
kernel/signal.c | 21
On Wed, Jun 14, 2017 at 07:08:39AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 13, 2017 at 09:17:05PM +0300, Gleb Fotengauer-Malinovskiy wrote:
> > On Tue, May 30, 2017 at 04:33:57PM -0700, Laura Abbott wrote:
> > > On 05/30/2017 07:11 AM, Gleb Fotengauer-Malinovskiy wrote:
> > > > This problem
written
in the wrong order.
This bug was found by strace test suite.
Reported-by: Anatoly Pugachev
Inspired-by: Eugene Syromyatnikov
Fixes: 8f13621abced ("sigpending(): move compat to native")
Signed-off-by: Dmitry V. Levin
---
kernel/signal.c | 11 +++
1 file changed, 7 insert
On Sun, Aug 06, 2017 at 06:43:56PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
>
> Signed-off-by: Mikko Rapeli
> Cc: Arnd Bergmann
> Cc: David S. Miller
> ---
> include/uapi/linux/sysctl.h | 4 ++--
> 1 file changed, 2 insertions(+), 2
On Sun, Aug 06, 2017 at 06:44:00PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation errors like:
>
> error: field ‘msg_perm’ has incomplete type
> struct ipc64_perm msg_perm;
> error: unknown type name ‘__kernel_ulong_t’
>
> Signed-off-by: Mikko Rapeli
> Acked-by: Arnd Bergmann
> Cc: H.
On Sun, Aug 06, 2017 at 06:43:59PM +0200, Mikko Rapeli wrote:
> Include linux/types.h and asm/msgbuf.h and use __kernel_size_t instead
> of size_t.
>
> Fixes userspace compilation errors like:
>
> error: field ‘shm_perm’ has incomplete type
> struct ipc64_perm shm_perm; /* operation perms */
> er
On Sun, Aug 06, 2017 at 06:44:03PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
>
> Signed-off-by: Mikko Rapeli
> Cc: Al Viro
> Cc: Arnd Bergmann
> Cc: H. Peter Anvin
> ---
> arch/x86/include/uapi/asm/signal.h | 2 +-
> 1 file changed,
On Sun, Aug 06, 2017 at 06:44:04PM +0200, Mikko Rapeli wrote:
> Fixes userspace compile errors like:
>
> error: field ‘sem_perm’ has incomplete type
> struct ipc64_perm sem_perm; /* permissions .. see ipc.h */
> error: unknown type name ‘__kernel_time_t’
> __kernel_time_t sem_otime; /* last se
On Sun, Aug 06, 2017 at 06:44:05PM +0200, Mikko Rapeli wrote:
> Arnd Bergmann doubts that __kernel_size_t could be used here
> so trying to fall back to gcc's .
The only architecture where you cannot do this safely is x86 family
because of x32 exception. If there is no chance that the change wil
; linux/vm_sockets.h
> linux/ncp_fs.h
> linux/nfc.h
> linux/phonet.h
>
> Signed-off-by: Mikko Rapeli
> Cc: net...@vger.kernel.org
> Cc: Dmitry V. Levin
> ---
> include/uapi/linux/socket.h | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/uap
On Sun, Aug 06, 2017 at 06:44:10PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
>
> Signed-off-by: Mikko Rapeli
> Cc: linux-o...@vger.kernel.org
> Cc: Tomi Valkeinen
> Cc: Aaro Koskinen
> ---
> include/uapi/linux/omapfb.h | 2 +-
> 1 fi
On Sun, Aug 06, 2017 at 06:44:12PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
> size_t bufsz;
>
> Signed-off-by: Mikko Rapeli
> Cc: ke...@lists.infradead.org
> Cc: Eric Biederman
> ---
> include/uapi/linux/kexec.h | 4 ++--
> 1 file
On Sun, Aug 06, 2017 at 06:44:13PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
> size_t length;
>
> Signed-off-by: Mikko Rapeli
> Cc: reiserfs-de...@vger.kernel.org
> ---
> include/uapi/linux/reiserfs_xattr.h | 2 +-
> 1 file changed,
On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote:
> It is not needed and not part of uapi headers, but causes
> user space compilation error:
>
> fatal error: net/tcp.h: No such file or directory
> #include
> ^
>
> Signed-off-by: Mikko Rapeli
> Cc: Dave Watson
On Wed, Aug 09, 2017 at 02:41:59PM +0200, Arnd Bergmann wrote:
> On Wed, Aug 9, 2017 at 12:57 AM, Dmitry V. Levin wrote:
> > On Sun, Aug 06, 2017 at 06:44:05PM +0200, Mikko Rapeli wrote:
> >> Arnd Bergmann doubts that __kernel_size_t could be used
> >> here
> >
Hi,
On Sun, Nov 12, 2017 at 01:30:17PM -0500, Felix Janda wrote:
> libc-compat.h aims to prevent symbol collisions between uapi and libc
> headers for each supported libc. This requires continuous coordination
> between them.
>
> The goal of this commit is to improve the situation for libcs (such
Commit-ID: 9820e1c3376c641299624dd24646aed3167ad5b1
Gitweb: https://git.kernel.org/tip/9820e1c3376c641299624dd24646aed3167ad5b1
Author: Dmitry V. Levin
AuthorDate: Thu, 5 Apr 2018 07:32:10 +0300
Committer: Ingo Molnar
CommitDate: Thu, 5 Apr 2018 10:05:21 +0200
x86/uapi: Fix asm
Commit-ID: 9a7a076e8e4ffcfec05e3cafe4c4e31d41ddbaa0
Gitweb: http://git.kernel.org/tip/9a7a076e8e4ffcfec05e3cafe4c4e31d41ddbaa0
Author: Dmitry V. Levin
AuthorDate: Wed, 11 May 2016 11:48:17 +0300
Committer: Thomas Gleixner
CommitDate: Thu, 12 May 2016 14:27:13 +0200
x86: Use compat
Commit-ID: 22eab1108781eff09961ae7001704f7bd8fb1dce
Gitweb: http://git.kernel.org/tip/22eab1108781eff09961ae7001704f7bd8fb1dce
Author: Dmitry V. Levin
AuthorDate: Tue, 1 Dec 2015 00:54:36 +0300
Committer: Thomas Gleixner
CommitDate: Sat, 5 Dec 2015 18:52:14 +0100
x86/signal: Fix
Commit-ID: 242fc35290bd8cf0effc6e3474e3a417985de2f3
Gitweb: http://git.kernel.org/tip/242fc35290bd8cf0effc6e3474e3a417985de2f3
Author: Dmitry V. Levin
AuthorDate: Wed, 5 Jul 2017 19:23:28 +0300
Committer: Ingo Molnar
CommitDate: Sat, 8 Jul 2017 11:17:55 +0200
sched/headers/uapi: Fix
401 - 456 of 456 matches
Mail list logo
